GNU bug report logs - #34080
27.0.50, 26.1; undocumented key bindings for *vc-diff*

Previous Next

Full log

Message #71 received at 34080 <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 34080 <at> debbugs.gnu.org, Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#34080: 27.0.50, 26.1; undocumented key bindings for *vc-diff*
Date: Sat, 19 Jul 2025 09:57:47 +0100

Hello,

On Fri 18 Jul 2025 at 09:24am -04, Stefan Monnier wrote:

>> I spent some time seeing how this change would be implemented and I now
>> think that, instead, diff-minor-mode should be renamed
>> diff-read-only-mode.  Am I right that diff-minor-mode is only intended
>> as a way to add bindings when diff-mode buffers are read-only?
>
> No, `diff-minor-mode` is intended for use in buffers that need to use
> another major mode than `diff-mode`.
> [ Like the difference between `outline-mode` and `outline-minor-mode`.  ]
>
> Not sure how important it is in practice: IIRC, I implemented this
> because it existed in other people's "diff modes" (when I started
> diff-mode I tried to make it a superset of all the diff/patch modes
> I could find), rather than because I saw a need for it.

Okay, thanks.

Renaming it wouldn't prevent it being used in this way and would improve
comprehensibility for 90% of users, so I'll go ahead with that.

I'll also experimentally mark diff-minor-mode-prefix as obsolete.

-- 
Sean Whitton

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.