GNU bug report logs - #34080
27.0.50, 26.1; undocumented key bindings for *vc-diff*

Previous Next

Full log

Message #59 received at 34080 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: Van L <van <at> scratch.space>, 34080 <at> debbugs.gnu.org,
 Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#34080: 27.0.50, 26.1; undocumented key bindings for *vc-diff*
Date: Wed, 09 Jul 2025 17:47:05 -0400

> - that diff-mode-shared-map is the parent of diff-minor-mode-map, not
>   diff-mode-map, d'oh
> - that diff-minor-mode is the mechanism by which the keys are made
>   available when the buffer is read only.
>
> What do you think about replacing activating a minor mode with just
> switching the major mode map?

Fine by me.

> So far as I can tell the disadvantage would be repeating keymap
> definitions, and the advantage would be more standardised
> *Help* output.

We definitely do not want to repeat keymap definitions (users may have
their own and may want to change the ones we provide).

But you can do things like

    (use-local-map (make-composed-map diff-mode-shared-map diff-mode-map))


- Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.