Subject: bug#34074: closed (Re: bug#34074: 27.0.5; flymake-proc delete temporary directory failed)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 17 Jan 2019 14:59:03 +0000

Your bug report

#34074: 27.0.5; flymake-proc delete temporary directory failed

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
34074: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34074
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#34074: 27.0.5; flymake-proc delete temporary directory failed
From: João Távora <[email-masked]>
To: 林宝龙 <[email-masked]>
Cc: [email-masked], [email-masked]
Date: Thu, 17 Jan 2019 14:58:09 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

林宝龙 <[email-masked]> writes:

> The temporary-file-directory on my host is "/tmp/", current function
> trancates the first charactor of the directory name, cause the
> directory not exist error.
>
> Below patch removes the folder separator of the temporary-file-directory, works fine in my environment.

Thanks, I pushed a slightly safer fix in

commit 80cbfb61c5a562d51197d6f3068fa5f4cda432b0
Author: João Távora <[email-masked]>
Date:   Thu Jan 17 14:38:44 2019 +0000

    Fix flymake-proc--delete-temp-directory if temp dir ends in slash

Subject: 27.0.5; flymake-proc delete temporary directory failed
From: 林宝龙 <[email-masked]>
To: [email-masked]
Date: Mon, 14 Jan 2019 10:55:28 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

The temporary-file-directory on my host is "/tmp/", current function
trancates the first charactor of the directory name, cause the directory
not exist error.

Below patch removes the folder separator of the temporary-file-directory,
works fine in my environment.

diff --git a/lisp/progmodes/flymake-proc.el b/lisp/progmodes/flymake-proc.el
index 7cdbb266fe..f0b979185e 100644
--- a/lisp/progmodes/flymake-proc.el
+++ b/lisp/progmodes/flymake-proc.el
@@ -886,7 +886,7 @@ can also be executed interactively independently of

 (defun flymake-proc--delete-temp-directory (dir-name)
   "Attempt to delete temp dir created by
`flymake-proc-create-temp-with-folder-structure', do not fail on error."
-  (let* ((temp-dir    temporary-file-directory)
+  (let* ((temp-dir    (directory-file-name temporary-file-directory))
         (suffix      (substring dir-name (1+ (length temp-dir)))))

     (while (> (length suffix) 0)