From unknown Fri Jun 20 07:17:14 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#34070 <34070@debbugs.gnu.org> To: bug#34070 <34070@debbugs.gnu.org> Subject: Status: 27.0.50; icomplete-mode candidate cycling broken for C-x C-f Reply-To: bug#34070 <34070@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:17:14 +0000 retitle 34070 27.0.50; icomplete-mode candidate cycling broken for C-x C-f reassign 34070 emacs submitter 34070 Jo=C3=A3o T=C3=A1vora severity 34070 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 14 08:56:55 2019 Received: (at submit) by debbugs.gnu.org; 14 Jan 2019 13:56:55 +0000 Received: from localhost ([127.0.0.1]:58387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gj2jX-0004bu-9z for submit@debbugs.gnu.org; Mon, 14 Jan 2019 08:56:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gj2jV-0004bh-9f for submit@debbugs.gnu.org; Mon, 14 Jan 2019 08:56:53 -0500 Received: from lists.gnu.org ([209.51.188.17]:52424) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gj2jQ-0003q2-0N for submit@debbugs.gnu.org; Mon, 14 Jan 2019 08:56:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gj2jO-0004gJ-Ep for bug-gnu-emacs@gnu.org; Mon, 14 Jan 2019 08:56:47 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gj2b0-0000gg-U2 for bug-gnu-emacs@gnu.org; Mon, 14 Jan 2019 08:48:08 -0500 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:41294) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gj2b0-0000fk-Jo for bug-gnu-emacs@gnu.org; Mon, 14 Jan 2019 08:48:06 -0500 Received: by mail-wr1-x432.google.com with SMTP id x10so22883233wrs.8 for ; Mon, 14 Jan 2019 05:48:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version; bh=kgwHn1LbbEXXp96ecONrWgFYc794ZTSjywCi79mmlw4=; b=rX5FhMgUvaPwxS22n85ScsKqy1nWJxYjjz5HhBH9T2H2tqiVEO7u8X2uH57I+FMGhw juMaUztg/CQ/CdOCa1gh/i2g1Hnh2JAzNt5eIAshp4GUDMiKzxJhUz7qI3F/DeDidByU KVOJZfTOqKyYqenrtQNXYPe3vxHvb0SlRdLA/IdciCORR4y/JR3su2sVNpIJ2iBSM7ls B9LprrakU1YN3QOppjd0T+Zd/DbDqNfCpp1dHxQaHGx5tlZ5HVXGDUtFDzVPqupNXXAO TVHKg5EuS/QMldef9D2pUqiL1wPa3Am1lz0QCKj64eDphM7m2A4CZhZ5UJqrE8KktDlU 4ziw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=kgwHn1LbbEXXp96ecONrWgFYc794ZTSjywCi79mmlw4=; b=I9h3AYbygJXdy4hMOedCssjNu/f1ZNu3LAnaqYvtC2Z6u+u8cvkEpnofMVrHUykyxi +76TcVZmVIOP0GRUw9kYrXW8sB/YkYXHfR/0LrDgRkbZlQXaejHZJDXYHlJWE4xG93to gOI8HnUkciRU4IbDg3JMoThpbjhGJh6/Dj+NTXYYR5hW7dx2DvSB2PIllwbghkr5YUu6 NabyYXtJUIHV5iaYKZjT5suvkVfU/BgN7zCL4F6aqqhNCRYbCOtITYBQsh5jWrec5dSB CNYz02InJF/DppnFLNlJoooyNpEH9HwtBIT54GoC12pM1G8EE5WQiRW31MEwhjkQNd7/ as3w== X-Gm-Message-State: AJcUukePs/HgE1bApvvtPoqHhCOYQCiBWukm5g2igLUiUVlfdVPKS9+o k5vH0+l7sFVzlPZSfdafG0mKoKjU X-Google-Smtp-Source: ALg8bN7EUz9pybAO1Onf5ot4E/u843RAYw/PNJz5IrNySBLx98McldUW9iZfKgMS17kMFaJg25rIJA== X-Received: by 2002:adf:f848:: with SMTP id d8mr25869618wrq.178.1547473682806; Mon, 14 Jan 2019 05:48:02 -0800 (PST) Received: from GONDOMAR.yourcompany.com (mail1.siscog.pt. [89.115.233.242]) by smtp.gmail.com with ESMTPSA id n82sm27786570wma.42.2019.01.14.05.48.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Jan 2019 05:48:02 -0800 (PST) From: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= To: bug-gnu-emacs@gnu.org Subject: 27.0.50; icomplete-mode candidate cycling broken for C-x C-f Date: Mon, 14 Jan 2019 13:47:48 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Antivirus: AVG (VPS 190114-0, 14-01-2019), Outbound message X-Antivirus-Status: Clean X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::432 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Hi maintainers, Emacs -Q M-x icomplete-mode C-x C-f C-. Expected candidate list to rotate once to the left, immediately. Instead if only rotates if I press C-. two additional times. This is because "." and ".." are still taking part in the rotation under the hood (but the user doesn't see them, by default, because of completion-ignored-extensions). Seems to have been introduced by commit 65797b1d75e9f608ffd50fd88be47a854b143bb1 Author: Drew Adams Date: Thu Apr 28 19:31:43 2016 +0200 Make icomplete respect `completion-ignored-extensions' * lisp/icomplete.el (icomplete-completions): Heed `completion-ignored-extensions' (bug#12939). Naive patch attached that seems to fix it for me. Here's another problem that might be related (should I open a new bug?) When using substring completion and navigating deeper in directories using successive C-M-i's (sometimes the directories don't make sense) Try it with: Emacs -Q M-: (add-to-list 'completion-styles 'substring) M-x icomplete-mode C-x C-f p a t h / t o / e m a c s / s r c C-M-i Expected to see the same as if I had typed "s r c /", instead I see "{src | lib-src}" --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-icomplete-s-cycling-when-filename-filtering-kick.patch >From 7ec9a12f2e22b846c2635a045a8c1a13b4573eba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20T=C3=A1vora?= Date: Mon, 14 Jan 2019 12:46:34 +0000 Subject: [PATCH] Fix icomplete's cycling when filename filtering kicks in To reproduce: Emacs -Q M-x icomplete-mode C-x C-f C-. Expected candidate list to rotate once to the left. Instead if only rotates if I press C-. twice more. This is because "." and ".." are still taking part in the rotation under the hood (but one doesn't see them by default because of completion-ignored-extensions) * lisp/icomplete.el (icomplete--filtered-completions): New variable. (icomplete-forward-completions, icomplete-backward-completions): Use it. (icomplete-completions): Set it. --- lisp/icomplete.el | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/lisp/icomplete.el b/lisp/icomplete.el index 8bed46cb3b..82e2728487 100644 --- a/lisp/icomplete.el +++ b/lisp/icomplete.el @@ -162,6 +162,9 @@ icomplete-force-complete-and-exit (minibuffer-force-complete-and-exit) (minibuffer-complete-and-exit))) +(defvar icomplete--filtered-completions nil + "If non-nil completions as filtered by `icomplete-completions'") + (defun icomplete-forward-completions () "Step forward completions by one entry. Second entry becomes the first and can be selected with @@ -169,7 +172,8 @@ icomplete-forward-completions (interactive) (let* ((beg (icomplete--field-beg)) (end (icomplete--field-end)) - (comps (completion-all-sorted-completions beg end)) + (comps (or icomplete--filtered-completions + (completion-all-sorted-completions beg end))) (last (last comps))) (when comps (setcdr last (cons (car comps) (cdr last))) @@ -182,7 +186,8 @@ icomplete-backward-completions (interactive) (let* ((beg (icomplete--field-beg)) (end (icomplete--field-end)) - (comps (completion-all-sorted-completions beg end)) + (comps (or icomplete--filtered-completions + (completion-all-sorted-completions beg end))) (last-but-one (last comps 2)) (last (cdr last-but-one))) (when (consp last) ; At least two elements in comps @@ -382,9 +387,11 @@ icomplete-completions (progn ;;(debug (format "Candidates=%S field=%S" candidates name)) (format " %sNo matches%s" open-bracket close-bracket)) (if last (setcdr last nil)) - (when (and minibuffer-completing-file-name - icomplete-with-completion-tables) - (setq comps (completion-pcm--filename-try-filter comps))) + (if (and minibuffer-completing-file-name + icomplete-with-completion-tables) + (setq comps (completion-pcm--filename-try-filter comps) + icomplete--filtered-completions comps) + (setq icomplete--filtered-completions nil)) (let* ((most-try (if (and base-size (> base-size 0)) (completion-try-completion -- 2.19.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 14 11:03:40 2019 Received: (at 34070) by debbugs.gnu.org; 14 Jan 2019 16:03:40 +0000 Received: from localhost ([127.0.0.1]:59224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gj4iC-0007oG-Ea for submit@debbugs.gnu.org; Mon, 14 Jan 2019 11:03:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41397) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gj4iA-0007o1-33 for 34070@debbugs.gnu.org; Mon, 14 Jan 2019 11:03:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47124) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gj4i4-0007uI-L4; Mon, 14 Jan 2019 11:03:32 -0500 Received: from [176.228.60.248] (port=1400 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gj4i3-0003Cj-JF; Mon, 14 Jan 2019 11:03:32 -0500 Date: Mon, 14 Jan 2019 18:03:18 +0200 Message-Id: <83h8ebdy61.fsf@gnu.org> From: Eli Zaretskii To: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= , Drew Adams In-reply-to: (message from =?iso-8859-1?Q?Jo?= =?iso-8859-1?Q?=E3o_T=E1vora?= on Mon, 14 Jan 2019 13:47:48 +0000) Subject: Re: bug#34070: 27.0.50; icomplete-mode candidate cycling broken for C-x C-f References: MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34070 Cc: 34070@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: João Távora > Date: Mon, 14 Jan 2019 13:47:48 +0000 > Cc: monnier@iro.umontreal.ca > > Emacs -Q > M-x icomplete-mode > C-x C-f > C-. > > Expected candidate list to rotate once to the left, immediately. > Instead if only rotates if I press C-. two additional times. This is > because "." and ".." are still taking part in the rotation under the > hood (but the user doesn't see them, by default, because of > completion-ignored-extensions). > > Seems to have been introduced by > > commit 65797b1d75e9f608ffd50fd88be47a854b143bb1 > Author: Drew Adams > Date: Thu Apr 28 19:31:43 2016 +0200 > > Make icomplete respect `completion-ignored-extensions' > > * lisp/icomplete.el (icomplete-completions): Heed > `completion-ignored-extensions' (bug#12939). > > Naive patch attached that seems to fix it for me. Please add a test for this, if possible, so that we don't screw this up again in the future. > Here's another problem that might be related (should I open a new bug?) I think so, yes. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 14 11:25:57 2019 Received: (at 34070) by debbugs.gnu.org; 14 Jan 2019 16:25:57 +0000 Received: from localhost ([127.0.0.1]:59239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gj53l-0008N0-5p for submit@debbugs.gnu.org; Mon, 14 Jan 2019 11:25:57 -0500 Received: from mail-wr1-f49.google.com ([209.85.221.49]:33631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gj53i-0008Mn-UU for 34070@debbugs.gnu.org; Mon, 14 Jan 2019 11:25:55 -0500 Received: by mail-wr1-f49.google.com with SMTP id c14so23693349wrr.0 for <34070@debbugs.gnu.org>; Mon, 14 Jan 2019 08:25:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=VF2pQjVr8u/TjT/26qJXHQ1oH05aWTD22pLjiYwLZyQ=; b=aY5hgV1Xi0OjmmKNmICcw2Lk/SLlvvQOE9eDCFElAIRuTLvlQf20JUneK51Au1pQvC H0DZ8V/E5CP9CUVNXzGRewoy/wu3+r+imXgJgpjWJjQ7xhPYc3uXgwYirIKv6xe4Cflg uQTBgR+S5S9/boHKC5g6xWxVqzJ23M0YZlBvZ2V5gt/gYk+4eNJNdvQ7VvLBkRoxX69u EAiKRwCi/vZ5XolWMrwhR152cIZ922oRBc5A2u66YjFnfbburm3RsAUCsOPEHqPzXngq PsScVDRWNFwxqpK/475v5mlMPb9TcmvFxXXn4QrBYt9uqSVHmHCn8ohfrpWPZqxeZAjv 3LZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=VF2pQjVr8u/TjT/26qJXHQ1oH05aWTD22pLjiYwLZyQ=; b=Y9w/+BNY4aOPMtNGV7AkDNZ1sOjxYb0Ev2nsJBtMgh6DuFn4mkbXBiOC9CT0oiYny9 DTA28JCRZq1iBS0+8NBeyq7ibvdJwL+e8cKpu++PF8iCxx1/3giXbWMbSKRphb5WpHNq ydS6czaqo22i/daokmpjItKcD8KrBzS/s0pv8WDVeFHWokbCItGOPCAXXE2vZarEz+ZF rATTxaAZV/qSiAuL8NrCarAKKjaYax05Jy3yl6bIzIt2fivfQmkAvTstny3oJaoacVSx vZMGMn04bPKf44ZkaxLI5CZls5TN23B+/c44reJjmFa9OTvg1O6M5b5xFPokkG0erF3a yGFA== X-Gm-Message-State: AJcUukcAtUwx9WCYzdRup9P8NYTXqT7ylv2J4Vv+hm7yAOgFqmD6Wvb7 Q0KsRe/vPQyY9jnjQw1mJOY= X-Google-Smtp-Source: ALg8bN4oLWgRmypp3+KfL0/QBVkIwlQAM0yype5QdLDhoQwTo06lJvpb8dG+PyqAblHrgi6VW4cN5g== X-Received: by 2002:adf:f28d:: with SMTP id k13mr25884838wro.78.1547483149144; Mon, 14 Jan 2019 08:25:49 -0800 (PST) Received: from GONDOMAR.yourcompany.com (mail3.siscog.pt. [195.23.29.18]) by smtp.gmail.com with ESMTPSA id 127sm45446014wmm.45.2019.01.14.08.25.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Jan 2019 08:25:48 -0800 (PST) From: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= To: Eli Zaretskii Subject: Re: bug#34070: 27.0.50; icomplete-mode candidate cycling broken for C-x C-f In-Reply-To: <83h8ebdy61.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 14 Jan 2019 18:03:18 +0200") References: <83h8ebdy61.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) Date: Mon, 14 Jan 2019 16:25:41 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Antivirus: AVG (VPS 190114-0, 14-01-2019), Outbound message X-Antivirus-Status: Clean X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34070 Cc: 34070@debbugs.gnu.org, monnier@iro.umontreal.ca, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Seems to have been introduced by >>=20 >> commit 65797b1d75e9f608ffd50fd88be47a854b143bb1 >> Author: Drew Adams >> Date: Thu Apr 28 19:31:43 2016 +0200 >>=20=20=20=20=20 >> Make icomplete respect `completion-ignored-extensions' >>=20=20=20=20=20=20=20=20 >> * lisp/icomplete.el (icomplete-completions): Heed >> `completion-ignored-extensions' (bug#12939). >>=20 >> Naive patch attached that seems to fix it for me. > > Please add a test for this, if possible, so that we don't screw this > up again in the future. I'd love to, but it's not exactly simple to write tests that observe user interaction the minibuffer with ert. At least for me. How would I go about doing that? Any pointers/prior art? Jo=E3o From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 14 11:40:57 2019 Received: (at 34070) by debbugs.gnu.org; 14 Jan 2019 16:40:57 +0000 Received: from localhost ([127.0.0.1]:59257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gj5IH-0000I3-07 for submit@debbugs.gnu.org; Mon, 14 Jan 2019 11:40:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gj5IF-0000Hq-3v for 34070@debbugs.gnu.org; Mon, 14 Jan 2019 11:40:55 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gj5I6-0005XL-Af; Mon, 14 Jan 2019 11:40:46 -0500 Received: from [176.228.60.248] (port=3912 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gj5I5-0000Ct-2c; Mon, 14 Jan 2019 11:40:46 -0500 Date: Mon, 14 Jan 2019 18:40:32 +0200 Message-Id: <83d0ozdwfz.fsf@gnu.org> From: Eli Zaretskii To: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= In-reply-to: (message from =?iso-8859-1?Q?Jo?= =?iso-8859-1?Q?=E3o_T=E1vora?= on Mon, 14 Jan 2019 16:25:41 +0000) Subject: Re: bug#34070: 27.0.50; icomplete-mode candidate cycling broken for C-x C-f References: <83h8ebdy61.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34070 Cc: 34070@debbugs.gnu.org, monnier@iro.umontreal.ca, drew.adams@oracle.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: João Távora > Cc: Drew Adams , 34070@debbugs.gnu.org, monnier@iro.umontreal.ca > Date: Mon, 14 Jan 2019 16:25:41 +0000 > > > Please add a test for this, if possible, so that we don't screw this > > up again in the future. > > I'd love to, but it's not exactly simple to write tests that observe > user interaction the minibuffer with ert. At least for me. How would I > go about doing that? Any pointers/prior art? (A stab in the dark) invoke the function bound to TAB and examine what it produces? From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 14 12:12:14 2019 Received: (at 34070) by debbugs.gnu.org; 14 Jan 2019 17:12:14 +0000 Received: from localhost ([127.0.0.1]:59279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gj5mY-000112-34 for submit@debbugs.gnu.org; Mon, 14 Jan 2019 12:12:14 -0500 Received: from mail-wm1-f48.google.com ([209.85.128.48]:51539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gj5mU-00010n-9k for 34070@debbugs.gnu.org; Mon, 14 Jan 2019 12:12:12 -0500 Received: by mail-wm1-f48.google.com with SMTP id b11so353437wmj.1 for <34070@debbugs.gnu.org>; Mon, 14 Jan 2019 09:12:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=61IS+JHVGiIamP2ooK6dikoo36ljAlP0/s3dmUPsUME=; b=pPNgYKSwc1H4/M4XivIUI1CQxQFrT6iSgtudQZAOieAmMJ7K6sOVfcHA/FvnjyShxV d82OdO/WwwvTwPRXNqScIOCD+h8lG/eimQontOIgvj7MBHzmfZ4fb7L2qehQK5Gjmyj1 GO03U3z+by74lmEEUT3tGor0fjtucdG81ypwOLeLZ4huH0yxCIu5/8ztMq7LxwWU/1IA bEA/fltMErjWQB+3pzkFuuouHr2OeXILGTa635IOE65p1I29LtBwSsh/XR4601AHP9Oe eMlKn6e40KsQ58+sqoXlR1HTnHVGv36S9G2upHIUpOUDbGsmnx3IaPaQx80Jlo2Z7yeE mxQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=61IS+JHVGiIamP2ooK6dikoo36ljAlP0/s3dmUPsUME=; b=F+6u4pV/omXcYPm6o4Zc9NLeFkgTXghbknKxSwlWUiW6GsKAzE1/js5MdiFTDcx/wS M6/wQYYYHsTSbPu3YthIVKaZdl/ijxO5WPvIrKnMyjMVJ4bfpPdELVnKM4rb+I96SFal MVxjsoIZWHMG+i2Q+1MzzH1OFqGsxxGXiqn+8EhkIfqikzfJWLw2bzqA2d9wtPdgxdng JzF0nHnJuT2ABsQ7DkMJcdyW89dCaGEL4W8ENIIi70ZofqEknLIEHnOEG4cAy/c7GiXW aRRmFt3wasJwFuwgWMy5MmQxMTYeBdhqnTii0gZ+ERix7wBrK9HEkEI/g2lyoYfvbWkD l6AQ== X-Gm-Message-State: AJcUukcMBcrpVaRcclb9sQjO6X4TnqdEHmYGKDYm+ZQVRCI1m/T4xbeY J5WOpLQL2AjyO0Rz46mDxsc= X-Google-Smtp-Source: ALg8bN7MTCKrzfIp1xJqAa813rmR7T7AqLObrLtJZB3ze49aqBeyvRhJL0Vouf657P17XvoxrUZ7/Q== X-Received: by 2002:a7b:cc86:: with SMTP id p6mr96444wma.19.1547485924375; Mon, 14 Jan 2019 09:12:04 -0800 (PST) Received: from GONDOMAR.yourcompany.com (mail3.siscog.pt. [195.23.29.18]) by smtp.gmail.com with ESMTPSA id t76sm31654845wme.33.2019.01.14.09.12.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Jan 2019 09:12:03 -0800 (PST) From: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= To: Eli Zaretskii Subject: Re: bug#34070: 27.0.50; icomplete-mode candidate cycling broken for C-x C-f References: <83h8ebdy61.fsf@gnu.org> <83d0ozdwfz.fsf@gnu.org> Date: Mon, 14 Jan 2019 17:11:58 +0000 In-Reply-To: <83d0ozdwfz.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 14 Jan 2019 18:40:32 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Antivirus: AVG (VPS 190114-0, 14-01-2019), Outbound message X-Antivirus-Status: Clean X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34070 Cc: 34070@debbugs.gnu.org, monnier@iro.umontreal.ca, drew.adams@oracle.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Jo=E3o T=E1vora >> Cc: Drew Adams , 34070@debbugs.gnu.org, monnier= @iro.umontreal.ca >> Date: Mon, 14 Jan 2019 16:25:41 +0000 >>=20 >> > Please add a test for this, if possible, so that we don't screw this >> > up again in the future. >>=20 >> I'd love to, but it's not exactly simple to write tests that observe >> user interaction the minibuffer with ert. At least for me. How would I >> go about doing that? Any pointers/prior art? > > (A stab in the dark) invoke the function bound to TAB and examine what > it produces? :-) Where do you mean TAB? It's not even in the recipe. Well I though about it a bit and can probalby use minibuffer-setup-hook (let ((minibuffer-setup-hook (append minibuffer-setup-hook (list (lambda () ;; commands and observations )))) (default-directory source-directory)) (find-file-read-args "Find file: " (confirm-nonexistent-file-or-buffer))) Don't know how to observe the icomplete candidates though, but this strategy is probably enough to make a test. I'd like to push the fix before that maybe, any objections? Jo=E3o From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 14 12:40:48 2019 Received: (at 34070) by debbugs.gnu.org; 14 Jan 2019 17:40:48 +0000 Received: from localhost ([127.0.0.1]:59284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gj6EC-0001fs-Ii for submit@debbugs.gnu.org; Mon, 14 Jan 2019 12:40:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gj6EB-0001ff-4o for 34070@debbugs.gnu.org; Mon, 14 Jan 2019 12:40:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49193) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gj6E4-0004fY-Nx; Mon, 14 Jan 2019 12:40:40 -0500 Received: from [176.228.60.248] (port=3610 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gj6E4-0005B5-BJ; Mon, 14 Jan 2019 12:40:40 -0500 Date: Mon, 14 Jan 2019 19:40:26 +0200 Message-Id: <83a7k3dto5.fsf@gnu.org> From: Eli Zaretskii To: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= In-reply-to: (message from =?iso-8859-1?Q?Jo?= =?iso-8859-1?Q?=E3o_T=E1vora?= on Mon, 14 Jan 2019 17:11:58 +0000) Subject: Re: bug#34070: 27.0.50; icomplete-mode candidate cycling broken for C-x C-f References: <83h8ebdy61.fsf@gnu.org> <83d0ozdwfz.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34070 Cc: 34070@debbugs.gnu.org, monnier@iro.umontreal.ca, drew.adams@oracle.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: João Távora > Cc: drew.adams@oracle.com, 34070@debbugs.gnu.org, monnier@iro.umontreal.ca > Date: Mon, 14 Jan 2019 17:11:58 +0000 > > I'd like to push the fix before that maybe, any objections? Please wait for Drew to respond, before you do. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 14 12:51:36 2019 Received: (at 34070) by debbugs.gnu.org; 14 Jan 2019 17:51:36 +0000 Received: from localhost ([127.0.0.1]:59304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gj6Oe-0001wf-8Y for submit@debbugs.gnu.org; Mon, 14 Jan 2019 12:51:36 -0500 Received: from mail-qt1-f175.google.com ([209.85.160.175]:36429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gj6Ob-0001wR-TG for 34070@debbugs.gnu.org; Mon, 14 Jan 2019 12:51:34 -0500 Received: by mail-qt1-f175.google.com with SMTP id t13so27529238qtn.3 for <34070@debbugs.gnu.org>; Mon, 14 Jan 2019 09:51:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=rX4YePw479nYhSz09GYR7LB2TziKOwIwXCmCPDGnjyU=; b=lfKwg1Erh5ZJJ0qnY3zxwee7WvfwJ5rQJwsOiYzz0hJyeChlMNGkOBFdK09pY7NFk1 1zouLNkWbJXGhzTp4sP4nBH/Ufb+4lste6Z4JfB0g8njGhEaDFQPobIfZgFk3lCmPMAV 3zwJpUg9LilH3d692ckPDnznfFQDAUiKl496e9RXGJh7ZJYENdejSqPoi0D0BGSrvzze x2J5iiW5U2nrp/BOPRyClH44IVEzU+sAPl53HlcfmzzT89abIZpti3Ovv+NFsBNlyP2I NbSYxs8wbtxA+Ar4IJuJKTWd0m9J4APg5pccmGYGiSj58WA4aovwrnl1fHBjEcKN0Vfv 7XQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=rX4YePw479nYhSz09GYR7LB2TziKOwIwXCmCPDGnjyU=; b=sBpiocq8LetuQUm9GX0llsF0DNvw86W9OMp9ZPkUc8Qour9cpX80wqNo0mlT484P2y bDjceKY4b009OSIptNUiu3GnxLhZvaSK/8dA6sZ9WnWXyN3D7FjLVlus1yrFyChYMggb qAX2fSKuht5z+BizPnchUEKW3gdm5vqwIy4gkA9emL5vEg7k+BXGPQ8m2pA+u46BXmMJ JtIQdSN3jlv65G+6ZV2r1+ym2L35WfFpjIhd9bOOwmopemr2hVR7qWHCapnexSGjcR0f c4W8hU5r8vwabjIBRYHmavGVkUU/VuD3lo4J4e9gbfFJZ++hiNnJgbctgLvI2X1QJ+Z/ HXVw== X-Gm-Message-State: AJcUukfxhLAUmCjjvfwvx5U1mI1Jgiq+E1VMfj1aYYGEnomkUwft0WDA yhK6OUM6B5zVpSWKS6cpfZtnHgXtGIt6zFheWfU= X-Google-Smtp-Source: ALg8bN6IABDOlBay0EfCnQUIFPoPwl6jYIbxURtcIboTE02YM3CvlYKAyWR6gKlcOn8Emfh1P/7C8ThHLKbcgmVaFao= X-Received: by 2002:ac8:88:: with SMTP id c8mr25344703qtg.218.1547488288088; Mon, 14 Jan 2019 09:51:28 -0800 (PST) MIME-Version: 1.0 References: <83h8ebdy61.fsf@gnu.org> <83d0ozdwfz.fsf@gnu.org> <83a7k3dto5.fsf@gnu.org> In-Reply-To: <83a7k3dto5.fsf@gnu.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Mon, 14 Jan 2019 17:51:16 +0000 Message-ID: Subject: Re: bug#34070: 27.0.50; icomplete-mode candidate cycling broken for C-x C-f To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 34070 Cc: 34070@debbugs.gnu.org, Stefan Monnier , Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) On Mon, Jan 14, 2019 at 5:40 PM Eli Zaretskii wrote: > > > From: Jo=C3=A3o T=C3=A1vora > > Cc: drew.adams@oracle.com, 34070@debbugs.gnu.org, monnier@iro.umontre= al.ca > > Date: Mon, 14 Jan 2019 17:11:58 +0000 > > > > I'd like to push the fix before that maybe, any objections? > > Please wait for Drew to respond, before you do. Fair enough. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 14 12:56:00 2019 Received: (at 34070) by debbugs.gnu.org; 14 Jan 2019 17:56:00 +0000 Received: from localhost ([127.0.0.1]:59311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gj6St-00022k-RF for submit@debbugs.gnu.org; Mon, 14 Jan 2019 12:56:00 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:52038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gj6Sr-00022V-A7 for 34070@debbugs.gnu.org; Mon, 14 Jan 2019 12:55:57 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id x0EHnTjn095015; Mon, 14 Jan 2019 17:55:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=AcY3EfBSri6rNrLy8JLOHSm1XWVHmWVSHbLduTVVBhQ=; b=cazRV/STLksjkoELlpWWhJ4UKERQ1/dK+ZfFYzSExtAblGohnco3ooTw0Wz588tu1EhD TZ1Un/SVlSvLPCO1tGhhQvlJzmaVeJwaDGt30fTGnYpedjNwMkUfTbJbYTl40FZITeAh LD33yvIv2mGcta0pi1LTq2ik5HBBHOScl93EI2IbHZ2QM10OzZ4ZH87gLjSVcBbGzQII IjIbH72mpNtXFXnOm0vPITaCOiDtUcAA6OC00y6arMjJD7rseM4IDxl/vGpNl3T89tGi V5Gb2ouTdxmvl5b2AKOT/DKmNK1/f9vo/OJv6dO46KEbpoD+rD6/OKmccSANxVBoqzBC gQ== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2120.oracle.com with ESMTP id 2pybjry08y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Jan 2019 17:55:51 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x0EHtoZH016600 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Jan 2019 17:55:50 GMT Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x0EHtmKI027843; Mon, 14 Jan 2019 17:55:48 GMT MIME-Version: 1.0 Message-ID: <4dd122fb-61b5-4605-9290-bde726598907@default> Date: Mon, 14 Jan 2019 09:55:47 -0800 (PST) From: Drew Adams To: Eli Zaretskii , =?iso-8859-1?B?Sm/jbyBU4XZvcmE=?= Subject: RE: bug#34070: 27.0.50; icomplete-mode candidate cycling broken for C-x C-f References: <83h8ebdy61.fsf@gnu.org> <83d0ozdwfz.fsf@gnu.org> <83a7k3dto5.fsf@gnu.org> In-Reply-To: <83a7k3dto5.fsf@gnu.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4783.0 (x86)] Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9136 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=678 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901140143 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 34070 Cc: 34070@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > I'd like to push the fix before that maybe, any objections? >=20 > Please wait for Drew to respond, before you do. I took a look at the bug description, reproduced it, and took a look at the= proposed patch. It looks OK to me. Thx. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 17 09:20:51 2019 Received: (at 34070) by debbugs.gnu.org; 17 Jan 2019 14:20:51 +0000 Received: from localhost ([127.0.0.1]:34301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gk8XJ-0003ei-Ph for submit@debbugs.gnu.org; Thu, 17 Jan 2019 09:20:51 -0500 Received: from mail-wr1-f41.google.com ([209.85.221.41]:35927) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gk8XH-0003eV-PG for 34070@debbugs.gnu.org; Thu, 17 Jan 2019 09:20:48 -0500 Received: by mail-wr1-f41.google.com with SMTP id u4so11212215wrp.3 for <34070@debbugs.gnu.org>; Thu, 17 Jan 2019 06:20:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=zFNfFEiXPGEzPaPMia4demDIdr4v/TB92UNrrL7mIsA=; b=SGusHLfEaqp9nj/Kv0+C+hiTU1uO6kU1afLrIhKcWfUZEej+UgxN0rCnSjSobaxe8S P81jgnFYMW7GYQvaH1tAkVJNspp84lTSNsQaLk6GrzeB28DGTL5DE/Q1MnRSzkJraaVj fM/+D9q3zKTqNEvpj41nVOfJ8Udvwn996PgKqeYHPtJFHcUm5PPG1U8Azsw8dC9ulrpn LGiLkVa2KQnl85wDJvr0oxKzDEi5bLiH9hWiBjM89ghcR2Lvy4XnAYmjSefncXhkkWlp PK67Jff76IpUwQszUm/A/SrE+ieu6NHSNlrOMzMGC8H4wQhU2SbwiI/DkoewumpM/JNU V3/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=zFNfFEiXPGEzPaPMia4demDIdr4v/TB92UNrrL7mIsA=; b=W/9GZJc+VKg/GhsN6FzFyM7MEiIwgJyNUZfEWOP514MyTmQACSmhtFa3D0N2WF6LRp ndmWUR6+Q7WPJW4N2DEzz/9ccupetyL/kQoJkfMv+v59OQNu2XrQ70YuspLjY/mzY4B8 McdTNKs335amyyjBiFLoyB8+zG0bdX0HEq/j/4R6kLBEiBNuAStFq6bxSolcat+mZY4a ntIpwOWfzi/fC2sULmgmnQ/SITipGh7IWqSaqSW4QQprIweQFoQ2DK15Bh942VtXiWN2 0s/Kbz2xJ8CUOapmv5uW99JjOFpFBcP6yIT49SlTDDP4QMa0CXmYd9Lg9snN05yb3OZJ pIVw== X-Gm-Message-State: AJcUukdiEBTtLxcNNzIdQ5ZPt61NIqOPmXyWvWEkqVhRPNIgMCP4G/rF qjNsLGsblF84moAkzbn67Q0= X-Google-Smtp-Source: ALg8bN4sbaZqtGeBd6/MSQaXgo6BHueynll8Yko+bBoQHourS8D9iFnLVL6SxCrI/Nlu/jYO62zcmA== X-Received: by 2002:adf:a357:: with SMTP id d23mr12739274wrb.195.1547734841787; Thu, 17 Jan 2019 06:20:41 -0800 (PST) Received: from GONDOMAR.yourcompany.com (mail3.siscog.pt. [195.23.29.18]) by smtp.gmail.com with ESMTPSA id a62sm31237623wmf.47.2019.01.17.06.20.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Jan 2019 06:20:41 -0800 (PST) From: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= To: 34070@debbugs.gnu.org Subject: Re: bug#34070: 27.0.50; icomplete-mode candidate cycling broken for C-x C-f References: <83h8ebdy61.fsf@gnu.org> <83d0ozdwfz.fsf@gnu.org> <83a7k3dto5.fsf@gnu.org> <4dd122fb-61b5-4605-9290-bde726598907@default> Date: Thu, 17 Jan 2019 14:20:38 +0000 In-Reply-To: <4dd122fb-61b5-4605-9290-bde726598907@default> (Drew Adams's message of "Mon, 14 Jan 2019 09:55:47 -0800 (PST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Antivirus: AVG (VPS 190117-0, 17-01-2019), Outbound message X-Antivirus-Status: Clean X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34070 Cc: Eli Zaretskii , monnier@iro.umontreal.ca, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable tag 34070 patch Drew Adams writes: >> > I'd like to push the fix before that maybe, any objections? >>=20 >> Please wait for Drew to respond, before you do. > > I took a look at the bug description, reproduced it, and took a look > at the proposed patch. It looks OK to me. Thx. I've already pushed the proposed patch to master, but there's a much less intrusive way using a new patch attached after my sig. Significantly, while still honouring the original intention of Drew's change: 65797b1d7 "Make icomplete respect `completion-ignored-extensions'" the new patch does two things: 1. Still fixes the candidate cycling (i.e. this bug) =20=20=20 2. Leaves the current directory as a candidate, i.e. "./" is *not* filtered from the prospects list (but "../" is). Number 2 can be seen as "new" behaviour, but then Drew's patch also silently introduced new behaviour by filtering out "./" and "../", which are *not* in completion-ignored-extensions. Reading bug#12939 (https://debbugs.gnu.org/12939) this seems to have gone unnoticed. If someone thinks this is a problem we can make this configurable (though I think the default should be what I suggest, since it makes C-x C-f'ing directories much easier). Jo=E3o --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0002-Simplify-ignored-extensions-filtering-in-Icomplete-b.patch >From 99c712809fca46648a02451c4eaa8196e915207b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20T=C3=A1vora?= Date: Tue, 15 Jan 2019 12:10:23 +0000 Subject: [PATCH 2/5] Simplify ignored extensions filtering in Icomplete (bug#34070) * lisp/icomplete.el: Use lexical binding. (icomplete--filtered-completions): Remove. (icomplete-forward-completions, icomplete-backward-completions): Revert last change. (icomplete-completions): Use minibuffer-completion-predicate to filter out completion-ignored-extensions. --- lisp/icomplete.el | 45 ++++++++++++++++++++++++--------------------- 1 file changed, 24 insertions(+), 21 deletions(-) diff --git a/lisp/icomplete.el b/lisp/icomplete.el index 82e2728487..6d77c0649a 100644 --- a/lisp/icomplete.el +++ b/lisp/icomplete.el @@ -1,4 +1,4 @@ -;;; icomplete.el --- minibuffer completion incremental feedback +;;; icomplete.el --- minibuffer completion incremental feedback -*- lexical-binding: t -*- ;; Copyright (C) 1992-1994, 1997, 1999, 2001-2019 Free Software ;; Foundation, Inc. @@ -162,9 +162,6 @@ icomplete-force-complete-and-exit (minibuffer-force-complete-and-exit) (minibuffer-complete-and-exit))) -(defvar icomplete--filtered-completions nil - "If non-nil completions as filtered by `icomplete-completions'") - (defun icomplete-forward-completions () "Step forward completions by one entry. Second entry becomes the first and can be selected with @@ -172,8 +169,7 @@ icomplete-forward-completions (interactive) (let* ((beg (icomplete--field-beg)) (end (icomplete--field-end)) - (comps (or icomplete--filtered-completions - (completion-all-sorted-completions beg end))) + (comps (completion-all-sorted-completions beg end)) (last (last comps))) (when comps (setcdr last (cons (car comps) (cdr last))) @@ -186,8 +182,7 @@ icomplete-backward-completions (interactive) (let* ((beg (icomplete--field-beg)) (end (icomplete--field-end)) - (comps (or icomplete--filtered-completions - (completion-all-sorted-completions beg end))) + (comps (completion-all-sorted-completions beg end)) (last-but-one (last comps 2)) (last (cdr last-but-one))) (when (consp last) ; At least two elements in comps @@ -373,8 +368,21 @@ icomplete-completions The displays for unambiguous matches have ` [Matched]' appended \(whether complete or not), or ` [No matches]', if no eligible matches exist." - (let* ((minibuffer-completion-table candidates) - (minibuffer-completion-predicate predicate) + (let* ((ignored-extension-re + (and minibuffer-completing-file-name + icomplete-with-completion-tables + completion-ignored-extensions + (concat "\\(?:\\`\\.\\./\\|" + (regexp-opt completion-ignored-extensions) + "\\)\\'"))) + (minibuffer-completion-table candidates) + (minibuffer-completion-predicate + (if ignored-extension-re + (lambda (cand) + (and (not (string-match ignored-extension-re cand)) + (or (null predicate) + (funcall predicate cand)))) + predicate)) (md (completion--field-metadata (icomplete--field-beg))) (comps (completion-all-sorted-completions (icomplete--field-beg) (icomplete--field-end))) @@ -385,13 +393,8 @@ icomplete-completions ;; `concat'/`mapconcat' is the slow part. (if (not (consp comps)) (progn ;;(debug (format "Candidates=%S field=%S" candidates name)) - (format " %sNo matches%s" open-bracket close-bracket)) + (format " %sNo matches%s" open-bracket close-bracket)) (if last (setcdr last nil)) - (if (and minibuffer-completing-file-name - icomplete-with-completion-tables) - (setq comps (completion-pcm--filename-try-filter comps) - icomplete--filtered-completions comps) - (setq icomplete--filtered-completions nil)) (let* ((most-try (if (and base-size (> base-size 0)) (completion-try-completion @@ -477,11 +480,11 @@ icomplete-completions (if prefix-len (substring (car comps) prefix-len) (car comps)) comps (cdr comps)) (setq prospects-len - (+ (string-width comp) - (string-width icomplete-separator) - prospects-len)) - (if (< prospects-len prospects-max) - (push comp prospects) + (+ (string-width comp) + (string-width icomplete-separator) + prospects-len)) + (if (< prospects-len prospects-max) + (push comp prospects) (setq limit t)))) (setq prospects (nreverse prospects)) ;; Decorate first of the prospects. -- 2.19.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 17 10:00:18 2019 Received: (at 34070) by debbugs.gnu.org; 17 Jan 2019 15:00:18 +0000 Received: from localhost ([127.0.0.1]:35195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gk99V-00055D-QY for submit@debbugs.gnu.org; Thu, 17 Jan 2019 10:00:17 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]:38925) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gk99U-000555-9A for 34070@debbugs.gnu.org; Thu, 17 Jan 2019 10:00:16 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x0HF0EE3027027; Thu, 17 Jan 2019 10:00:14 -0500 Received: by pastel.home (Postfix, from userid 20848) id 88CE66A58C; Thu, 17 Jan 2019 10:00:14 -0500 (EST) From: Stefan Monnier To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Subject: Re: bug#34070: 27.0.50; icomplete-mode candidate cycling broken for C-x C-f Message-ID: References: <83h8ebdy61.fsf@gnu.org> <83d0ozdwfz.fsf@gnu.org> <83a7k3dto5.fsf@gnu.org> <4dd122fb-61b5-4605-9290-bde726598907@default> Date: Thu, 17 Jan 2019 10:00:14 -0500 In-Reply-To: (=?windows-1252?Q?=22Jo=E3o_T=E1v?= =?windows-1252?Q?ora=22's?= message of "Thu, 17 Jan 2019 14:20:38 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.6 X-NAI-Spam-Rules: 4 Rules triggered ZERO_OBF_STOCK=0.5, GEN_SPAM_FEATRE=0.1, EDT_SA_DN_PASS=0, RV6463=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6463> : inlines <6996> : streams <1810351> : uri <2781364> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 34070 Cc: 34070@debbugs.gnu.org, Eli Zaretskii , Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I've already pushed the proposed patch to master, but there's a much > less intrusive way using a new patch attached after my sig. Sounds good. If you install it, could you install it as 2 separate patches: one that undoes the previous one and another that performs the new changes? Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 17 10:22:42 2019 Received: (at 34070) by debbugs.gnu.org; 17 Jan 2019 15:22:42 +0000 Received: from localhost ([127.0.0.1]:35208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gk9VC-0005dJ-AJ for submit@debbugs.gnu.org; Thu, 17 Jan 2019 10:22:42 -0500 Received: from mail-qt1-f175.google.com ([209.85.160.175]:41479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gk9V8-0005d0-Ol; Thu, 17 Jan 2019 10:22:39 -0500 Received: by mail-qt1-f175.google.com with SMTP id l12so11657917qtf.8; Thu, 17 Jan 2019 07:22:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=A4rRp/cOhf/c4kkIk2b5BIF9VOG9WqoX+Sn8s6THIwY=; b=pZPZzk32JMiVMo997z52DqPakOUyZW0MYcxMvE1dZREd1uETnot2QVsTHC7nOv+clh yTGUlCN0Z9+mxD6spJzDdC9GQIU+1cGWqOf2UsW2jX0Jt6RFg54mao9Vcg+Jz3EiHoGn Br3mBlarNlx9Ypf9wmlUd5JjU+J4xfpA51vBnkPeL5IunfUrM6AhLMFPOvmRWvkkE1ie xE8nM7xhTobK9FCAyXLiUL/SpLIqfkVPKnyufF6cnTi1O48YKOXlxOOkaD+5zu5y9L/K u3c3RMFCsDTwAuG8Q41UpJIghu8k7jDd5Kr0YTz/t8xsddglWNsd9wnwE6r5MLfbcT12 rraA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=A4rRp/cOhf/c4kkIk2b5BIF9VOG9WqoX+Sn8s6THIwY=; b=i9hG8rvpY3vdcGWgLJaGdQOfuajaZr5MCtsqZv0jsXIgj5LuPkZwaUwbJOs5n6b5Tc VG6+yw86GlgRYw90Q5OqTIbK9Ajt2qrl76d74U1m2uGHV8GP8kpwndgOooreM+IFXt/7 1mXEZLUlYRiVc95h4EUR0CHjDM8+KgBi39CVTbPJtsw5pxpsV/jT6PK8f/sJXihjXZyL GIBZMiAzhP6Ep2CaTT8CQ3mt1YnWfx2iRwXrHQSF1GL0XLizBR9YeYA+B3g5NikIYjAb F0SvUBw6nlPJ3s28FJGvMdFsyK7SAY8Sj/StJuApKdtxG3ydgfOQvWp/EVEodv/3XKTj /BnQ== X-Gm-Message-State: AJcUukcdmuJluct9H4XsrqBGsas1hUQF3m4CfvVcMt4+gNgrMsgKJLGG GXvNf6ErsOir5lMMWJvnGdccrM6/9WDm7HBODSo= X-Google-Smtp-Source: ALg8bN4QH7odO+nCJHMejuF05I4IFjMz9omfrwybG+ogkE3ufZ95Ox2JoHEL3M+OS6JxzCFcqrz4d/+XLx32E1a/zIY= X-Received: by 2002:ac8:3790:: with SMTP id d16mr11975864qtc.20.1547738551962; Thu, 17 Jan 2019 07:22:31 -0800 (PST) MIME-Version: 1.0 References: <83h8ebdy61.fsf@gnu.org> <83d0ozdwfz.fsf@gnu.org> <83a7k3dto5.fsf@gnu.org> <4dd122fb-61b5-4605-9290-bde726598907@default> In-Reply-To: From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Thu, 17 Jan 2019 15:22:20 +0000 Message-ID: Subject: Re: bug#34070: 27.0.50; icomplete-mode candidate cycling broken for C-x C-f To: Stefan Monnier Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 34070 Cc: 34070@debbugs.gnu.org, Eli Zaretskii , 34070-done@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) On Thu, Jan 17, 2019 at 3:00 PM Stefan Monnier w= rote: > > > I've already pushed the proposed patch to master, but there's a much > > less intrusive way using a new patch attached after my sig. > > Sounds good. If you install it, could you install it as 2 separate > patches: one that undoes the previous one and another that performs the > new changes? Done. commit 5a6df06494f9ba6df53af82cfdf81f1d3708edc3 Author: Jo=C3=A3o T=C3=A1vora Date: Tue Jan 15 12:10:23 2019 +0000 Simplify ignored extensions filtering in Icomplete (bug#34070) * lisp/icomplete.el: Use lexical binding. (icomplete-completions): Use minibuffer-completion-predicate to filter out completion-ignored-extensions. commit 7560ef7de925b56f367df168befc9b748b6237c1 Author: Jo=C3=A3o T=C3=A1vora Date: Thu Jan 17 15:11:21 2019 +0000 Revert "Fix icomplete's cycling when filename filtering kicks in" This reverts commit cdb082322d4209c5104bc1a98b21bf3dd75e8f17, which was a fix for bug#34070. A much better fix to be added soon. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 17 10:46:30 2019 Received: (at 34070) by debbugs.gnu.org; 17 Jan 2019 15:46:30 +0000 Received: from localhost ([127.0.0.1]:35222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gk9sD-0006F3-KT for submit@debbugs.gnu.org; Thu, 17 Jan 2019 10:46:30 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:52000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gk9s1-0006EM-3V for 34070@debbugs.gnu.org; Thu, 17 Jan 2019 10:46:27 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id x0HFhYXl021223; Thu, 17 Jan 2019 15:46:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=jUQEysy/MiHi2XqtILNpkraKSIpwahvPe+X40/KWH0o=; b=17HHejOF6Lp86OaiLeyStTkqEZNsRepOHnNO6t8/KLYss51LhfVjehk0y3FNTu+tEY2S tHxZ5mTTt4/xo3OhlgsEyXnVEddRhjVvzN8gXXntA9nw9VOKJOAyXktAEc9f9TLTXUKB sm7r6KqLIwkfgRc2A2+rovPo7xASQfxo0BIEguq+4wqfl3WiGXgU0OPut8bMLu6G1Vy7 WBTlkmLbNteFm7SGPxLmzyw3Sw3tiX0jN1CxMIlAExpEDtW9QOZ+P1qz6eyAFNH9lFqh 2653kS19uxWnMOjsIAzWmVEB35faO+7VbLOUQXBpW3cRmN8Ql8qzT0zMzif7De5GDb/f Jw== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2120.oracle.com with ESMTP id 2pybjsgqh6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Jan 2019 15:46:10 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x0HFkANG025458 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Jan 2019 15:46:10 GMT Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x0HFk9OT030126; Thu, 17 Jan 2019 15:46:09 GMT MIME-Version: 1.0 Message-ID: <154c946e-28c9-4afa-865a-ac15d2e83bce@default> Date: Thu, 17 Jan 2019 07:46:08 -0800 (PST) From: Drew Adams To: =?iso-8859-1?B?Sm/jbyBU4XZvcmE=?= , 34070@debbugs.gnu.org Subject: RE: bug#34070: 27.0.50; icomplete-mode candidate cycling broken for C-x C-f References: <83h8ebdy61.fsf@gnu.org> <83d0ozdwfz.fsf@gnu.org> <83a7k3dto5.fsf@gnu.org> <4dd122fb-61b5-4605-9290-bde726598907@default> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4783.0 (x86)] Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9138 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=934 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901170113 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 34070 Cc: Eli Zaretskii , monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > while still honouring the original intention of Drew's change: > 65797b1d7 "Make icomplete respect `completion-ignored-extensions'" > the new patch does two things: > 1. Still fixes the candidate cycling (i.e. this bug) > 2. Leaves the current directory as a candidate, i.e. "./" is *not* > filtered from the prospects list (but "../" is). >=20 > Number 2 can be seen as "new" behaviour, but then Drew's patch also > silently introduced new behaviour by filtering out "./" and "../", > which are *not* in completion-ignored-extensions. Reading bug > #12939... this seems to have gone unnoticed. >=20 > If someone thinks this is a problem we can make this configurable > (though I think the default should be what I suggest, since it > makes C-x C-f'ing directories much easier). I can't speak to whether `.' or `..' should (always? sometimes?) be filtered out for Icomplete completion of file-name candidates. I think you're right that the intention of my patch was just to respect `completion-ignored-extensions'. That was the "new" behavior to be introduced, and not silently. But why is it that `completion-pcm--filename-try-filter' adds `.' and `..' to its filter, so they too are excluded? I guess it's because they are not candidates returned by `try'? Assuming there's a good reason why `c-p--f-t-f' does that, and if that's not appropriate for Icomplete in all or most cases, then I guess `c-p--f-t-f' wasn't a perfect match for Icomplete. ;-) But maybe someone should take a look at `c-p--f-t-f' more generally? If `.' or `..' is appropriate for file-name completions sometimes (e.g. in Icomplete), then do some of the current uses of `c-p--f-t-f' also manifest the same bug that you are adding here? E.g., is removal of `.' and `..' always appropriate for `completion-basic-try-completion', `completion-pcm-try-completion' and `completion-substring-try-completion'? (Note too that you are adding to this bug, which was purportedly about broken cycling. Is this additional change necessary to fix the cycling problem, or should it be the subject of a new bug report?) BTW, see also bug #13322, companion to bug #12939. It should never have been closed, IMHO. BTW2, as stated in bug #12939, `completion-pcm--filename-try-filter' is the wrong name. It should not use `--'. It's not "internal" in any way, or at least it should not be considered so. Internal to what? It's not internal to `completion-pcm' (whatever that might be/mean now) or to `minibuffer.el'. It's as general and useful as any other Lisp function - no reason to try to signal to users that it is (also) used to build some basic Emacs behavior. Users can well make use of such a function. Misuse of the label "internal" is akin to Trump trying to "build that wall". From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 17 10:55:24 2019 Received: (at 34070) by debbugs.gnu.org; 17 Jan 2019 15:55:24 +0000 Received: from localhost ([127.0.0.1]:35226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkA0p-0006S5-Sv for submit@debbugs.gnu.org; Thu, 17 Jan 2019 10:55:24 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:39392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkA0m-0006Rs-Ib for 34070@debbugs.gnu.org; Thu, 17 Jan 2019 10:55:22 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x0HFtIRi012670; Thu, 17 Jan 2019 10:55:19 -0500 Received: by pastel.home (Postfix, from userid 20848) id F07F56AB69; Thu, 17 Jan 2019 10:55:17 -0500 (EST) From: Stefan Monnier To: Drew Adams Subject: Re: bug#34070: 27.0.50; icomplete-mode candidate cycling broken for C-x C-f Message-ID: References: <83h8ebdy61.fsf@gnu.org> <83d0ozdwfz.fsf@gnu.org> <83a7k3dto5.fsf@gnu.org> <4dd122fb-61b5-4605-9290-bde726598907@default> <154c946e-28c9-4afa-865a-ac15d2e83bce@default> Date: Thu, 17 Jan 2019 10:55:17 -0500 In-Reply-To: <154c946e-28c9-4afa-865a-ac15d2e83bce@default> (Drew Adams's message of "Thu, 17 Jan 2019 07:46:08 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6463=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6463> : inlines <6996> : streams <1810355> : uri <2781382> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 34070 Cc: 34070@debbugs.gnu.org, Eli Zaretskii , =?windows-1252?B?Sm/jbyBU4XZvcmE=?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Assuming there's a good reason why `c-p--f-t-f' does that, > and if that's not appropriate for Icomplete in all or most > cases, then I guess `c-p--f-t-f' wasn't a perfect match for > Icomplete. ;-) I think stripping . and .. was fine, and that not stripping them is also acceptable (or only stripping one of the two): it doesn't matter that much. it really matters for c-p--f-t-f, tho, because otherwise TAB in a dir with a single file won't directly complete to that file's name. Stefan > well make use of such a function. Misuse of the label > "internal" is akin to Trump trying to "build that wall". Should Trump also count for Godwin's law? From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 17 10:55:47 2019 Received: (at 34070) by debbugs.gnu.org; 17 Jan 2019 15:55:47 +0000 Received: from localhost ([127.0.0.1]:35229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkA1D-0006Sp-9B for submit@debbugs.gnu.org; Thu, 17 Jan 2019 10:55:47 -0500 Received: from mail-qt1-f178.google.com ([209.85.160.178]:41596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkA1A-0006SY-N0 for 34070@debbugs.gnu.org; Thu, 17 Jan 2019 10:55:45 -0500 Received: by mail-qt1-f178.google.com with SMTP id l12so11789571qtf.8 for <34070@debbugs.gnu.org>; Thu, 17 Jan 2019 07:55:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=wymLc5pKOhFC2ruiuAFXlOqnwKOtNEyk+EsqkBeCmMk=; b=SjZJxJdEqc7hT+cqyhoSVhMQ40WW/PAkn7duiV6DY/ZuyVRbfFPuZcWAIh1p1g45CL gC81UotCziP17EIoy/FWb3n2D8xlhHWsNUviFWc7y/MXT3G+6cyvm5E7DR7oAY5wVoCR WmU/M6TZXI8NRp0EAY8Aauc3NGFmCpIuCDfI7QC7AtGvFezD1wEJc1/GIQf1NAtpDxqd BsB0EPfjjjP9+ZMYC0nZJJZxguK6IGzR0lzOK2sdH8IHrRyHu307z5ZDWzIVcJGu1UrI oSAQmZgHh3pGbAfYKpmVC5F3buXLw/xviUCMr/YrG0rzlf+SKxawHiNkpXVZ8tGoVGWD Hi+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wymLc5pKOhFC2ruiuAFXlOqnwKOtNEyk+EsqkBeCmMk=; b=KBbNxSG+ECnrFnQ86eYfbkHg1rnVjHXtTQHgGx/DiPc8MSYk6iaq6DUvMhY42Mo5lz xDfYgbIylN6rRjD8tGPKazJZG2ewAv8f8bo9DeJ/ZRLQ872sLlYGtWNEvDJog1psM8CB zk1524rCKIEc6OF6YvTYBzNrHGEj0HZrjeEqkIBe13ph6Nx6HqvrW3qfjpiHOTDja9t1 HDYM+5XU5/gFv4e4UqfMinQXOlb9QRVP4Jd00aj83EMLG0s7rle0bXF1lQgikbol6epl 502OvauExAeYh2ORZdJW/iBEOLVwezVeXp2swk1Fo+g2Jcn6+dEKOAUrHe0FvhUnQDWc yOMw== X-Gm-Message-State: AJcUukfG7n7eXf+yGmsyoSiNU3WMD+RNjkV+XgRIM4ROVJ+kdN8HXpZC LvkIh6x9Maw+A+xnBPnbg7NSEqj1EIyXBn50Pww= X-Google-Smtp-Source: ALg8bN4oWoCOW/TCogMtFg4lTruFXTXtjUgklFwazdmtKyUj2s0SFKQ47w1H9PeO0s8L/0tt6WWxuceHrqTuZILl4WU= X-Received: by 2002:ac8:7611:: with SMTP id t17mr11582122qtq.345.1547740539071; Thu, 17 Jan 2019 07:55:39 -0800 (PST) MIME-Version: 1.0 References: <83h8ebdy61.fsf@gnu.org> <83d0ozdwfz.fsf@gnu.org> <83a7k3dto5.fsf@gnu.org> <4dd122fb-61b5-4605-9290-bde726598907@default> <154c946e-28c9-4afa-865a-ac15d2e83bce@default> In-Reply-To: <154c946e-28c9-4afa-865a-ac15d2e83bce@default> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Thu, 17 Jan 2019 15:55:27 +0000 Message-ID: Subject: Re: bug#34070: 27.0.50; icomplete-mode candidate cycling broken for C-x C-f To: Drew Adams Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 34070 Cc: 34070@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) On Thu, Jan 17, 2019 at 3:46 PM Drew Adams wrote: > I think you're right that the intention of my patch was > just to respect `completion-ignored-extensions'. That was > the "new" behavior to be introduced, and not silently. Right. That was the "declared" new behaviour (for your definition of "new"). But there was some "undeclared", undiscussed new behaviour: that was my point. > (Note too that you are adding to this bug, which was > purportedly about broken cycling. Is this additional > change necessary to fix the cycling problem, or should > it be the subject of a new bug report?) Right. I put emphasis on this myself, so I don't have to "note" it. If you believe it should be the subject of a new bug, go ahead and create it. I don't think it's worth it. -- Jo=C3=A3o T=C3=A1vora From unknown Fri Jun 20 07:17:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 15 Feb 2019 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator