GNU bug report logs - #34069
rename-file on fifos hangs if cross device

Previous Next

Package: emacs;

Reported by: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>

Date: Mon, 14 Jan 2019 13:57:01 UTC

Severity: minor

Tags: confirmed

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34069 in the body.
You can then email your comments to 34069 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#34069; Package emacs. (Mon, 14 Jan 2019 13:57:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 14 Jan 2019 13:57:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: bug-gnu-emacs <at> gnu.org
Subject: dired-do-rename on fifos hangs if cross device
Date: Mon, 14 Jan 2019 21:03:23 +0800

$ mkfifo x
then do dired-do-rename x /tmp #not on the same filesystem
This just hangs forever.
(Don't ask me why I am doing this.)
emacs-version "26.1"
$ mv x /tmp #works just fine though.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#34069; Package emacs. (Mon, 31 Aug 2020 10:27:01 GMT) Full text and rfc822 format available.

Message #8 received at 34069 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 34069 <at> debbugs.gnu.org
Subject: Re: bug#34069: dired-do-rename on fifos hangs if cross device
Date: Mon, 31 Aug 2020 10:26:16 +0000

tags 34069 + confirmed
retitle 34069 rename-file on fifos hangs if cross device
thanks

積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:

> $ mkfifo x
> then do dired-do-rename x /tmp #not on the same filesystem
> This just hangs forever.
> (Don't ask me why I am doing this.)
> emacs-version "26.1"
> $ mv x /tmp #works just fine though.

It actually hangs on the rename-file call in copy-file.

Here is a minimal reproducer:

(progn (shell-command "mkfifo foo")
       (rename-file "foo" "/tmp"))
Added tag(s) confirmed. Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Mon, 31 Aug 2020 10:27:02 GMT) Full text and rfc822 format available.
Changed bug title to 'rename-file on fifos hangs if cross device' from 'dired-do-rename on fifos hangs if cross device' Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Mon, 31 Aug 2020 10:27:02 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#34069; Package emacs. (Sun, 08 May 2022 13:43:02 GMT) Full text and rfc822 format available.

Message #15 received at 34069 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 34069 <at> debbugs.gnu.org,
 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Subject: Re: bug#34069: rename-file on fifos hangs if cross device
Date: Sun, 08 May 2022 15:41:58 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

> Here is a minimal reproducer:
>
> (progn (shell-command "mkfifo foo")
>        (rename-file "foo" "/tmp"))

Thanks; I've now fixed this in Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
bug marked as fixed in version 29.1, send any further explanations to 34069 <at> debbugs.gnu.org and 積丹尼 Dan Jacobson <jidanni <at> jidanni.org> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sun, 08 May 2022 13:43:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 06 Jun 2022 11:24:12 GMT) Full text and rfc822 format available.
bug unarchived. Request was from Paul Eggert <eggert <at> cs.ucla.edu> to control <at> debbugs.gnu.org. (Sun, 18 Dec 2022 21:02:01 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#34069; Package emacs. (Sun, 18 Dec 2022 21:08:02 GMT) Full text and rfc822 format available.

Message #24 received at 34069 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 34069 <at> debbugs.gnu.org, Stefan Kangas <stefan <at> marxist.se>,
 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Subject: Re: bug#34069: rename-file on fifos hangs if cross device
Date: Sun, 18 Dec 2022 13:06:58 -0800

[Message part 1 (text/plain, inline)]
In reviewing that patch I discovered that there's a similar bug in 
copy-file, and that there's some opportunity to simplify and robustify 
the rename-file code. I installed the attached patches on master to do that.

[0001-Don-t-hang-when-copying-FIFOs.patch (text/x-patch, attachment)]
[0002-Improve-rename-file-fix-bug-34069.patch (text/x-patch, attachment)]
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 16 Jan 2023 12:24:06 GMT) Full text and rfc822 format available.
This bug report was last modified 2 years and 212 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.