GNU bug report logs - #34027
27.0.50; disable-theme resets variables to their initial values

Previous Next

Package: emacs;

Reported by: Michael Albinus <michael.albinus <at> gmx.de>

Date: Thu, 10 Jan 2019 12:26:02 UTC

Severity: normal

Tags: fixed

Merged with 15687

Found in versions 24.3.50, 27.0.50

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: Michael Albinus <michael.albinus <at> gmx.de>, 34027 <at> debbugs.gnu.org
Subject: bug#34027: 27.0.50; disable-theme resets variables to their initial values
Date: Sat, 05 Sep 2020 13:55:03 +0200

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> That is controlled by the variable custom--inhibit-theme-enable, and
> we should bind it to nil in enable-theme, because we are definitely
> enabling it.  Once we do that, it is just a matter of using
> custom-push-theme to handle the case like it's supposed to.
>
> My patch does that, and introduces an extra check in custom-push-theme,
> because while testing I found another instance of Bug#28904.  The rest
> this patch does is changing the test because of the comments I made in
> another post to this bug, and we now can expect the test to pass.

Thanks, looks good to me (although I'm not all that familiar with the
custom/theme integration), so I've applied your patch to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
This bug report was last modified 4 years and 314 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.