GNU bug report logs - #34021
[PATCH 1/1] gnu: kinit: Use KDEINIT5_LIBRARY_PATH to search for dynlibs.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Subject: bug#34021: closed (Re: bug#34021: Acknowledgement ([PATCH 1/1]
 gnu: kinit: Use KDEINIT5_LIBRARY_PATH to search for dynlibs.))
Date: Fri, 11 Jan 2019 15:40:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#34021: [PATCH 1/1] gnu: kinit: Use KDEINIT5_LIBRARY_PATH to search for dynlibs.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 34021 <at> debbugs.gnu.org.

-- 
34021: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34021
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: 34021-close <at> debbugs.gnu.org
Subject: Re: bug#34021: Acknowledgement ([PATCH 1/1] gnu: kinit: Use
 KDEINIT5_LIBRARY_PATH to search for dynlibs.)
Date: Fri, 11 Jan 2019 16:39:22 +0100

Commited as 46b082f97f73cd79b40bde15cfe3e4ddb28ba209

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

[Message part 3 (message/rfc822, inline)]

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 1/1] gnu: kinit: Use KDEINIT5_LIBRARY_PATH to search for
 dynlibs.
Date: Wed,  9 Jan 2019 17:02:46 +0100

Using LIBRARY_PATH was introduced in
16b8aff85bcdb9799496c4a27257210cd45158e5, but is wrong since
this variable is used by the compiler (gcc) at link time.

* gnu/packages/patches/kinit-kdeinit-libpath.patch: Change
  LIBRARY_PATH to KDEINIT5_LIBRARY_PATH.
* gnu/packages/kde-frameworks.scm (kinit)[native-search-paths]:
  New field.
---
 gnu/packages/kde-frameworks.scm                  | 4 ++++
 gnu/packages/patches/kinit-kdeinit-libpath.patch | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 62cd2dd2d..72152fd78 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2556,6 +2556,10 @@ in applications using the KDE Frameworks.")
                (("GUIX_PKGS_KF5_PARTS") (assoc-ref inputs "kparts"))
                (("GUIX_PKGS_KF5_PLASMA") (assoc-ref inputs "plasma-framework")))
              #t)))))
+    (native-search-paths
+     (list (search-path-specification
+            (variable "KDEINIT5_LIBRARY_PATH")
+            (files '("lib/")))))
     (native-inputs
      `(("extra-cmake-modules" ,extra-cmake-modules)
        ("pkg-config" ,pkg-config)))
diff --git a/gnu/packages/patches/kinit-kdeinit-libpath.patch b/gnu/packages/patches/kinit-kdeinit-libpath.patch
index 89cf1a941..6382e8804 100644
--- a/gnu/packages/patches/kinit-kdeinit-libpath.patch
+++ b/gnu/packages/patches/kinit-kdeinit-libpath.patch
@@ -23,7 +23,7 @@ pkgs/development/libraries/kde-frameworks/kinit/kinit-libpath.patch
 -                    l.load();
 -                }
 +                // Try to load the library relative to the active profiles.
-+                QByteArrayList profiles = qgetenv("LIBRARY_PATH").split(':');
++                QByteArrayList profiles = qgetenv("KDEINIT5_LIBRARY_PATH").split(':');
 +                for (const QByteArray &profile: profiles) {
 +                    if (!profile.isEmpty()) {
 +                        l.setFileName(QFile::decodeName(profile) + QStringLiteral("/") + libpath);
-- 
2.13.7

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.