GNU bug report logs - #34001
26.1.90; :distant-foreground face property fails to work in most cases

Previous Next

Full log

Message #28 received at 34001-done <at> debbugs.gnu.org (full text, mbox):

From: Federico Tedin <federicotedin <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 34001-done <at> debbugs.gnu.org, tinakellyrussell <at> gmail.com
Subject: Re: bug#34001: 26.1.90; :distant-foreground face property fails to
 work in most cases
Date: Fri, 1 Mar 2019 09:44:30 -0300

[Message part 1 (text/plain, inline)]

Thanks Eli!

I have a question regarding commit messages and documentation: should I
include them in the first iteration of the patch I created, or should I
wait until there’s been some conversation first?  Until now I’ve chosen the
first option since I’m not always sure the patch I created is
correct/applicable/etc.

On Fri, 1 Mar 2019 at 05:40 Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Federico Tedin <federicotedin <at> gmail.com>
> > Date: Tue, 15 Jan 2019 22:08:15 -0300
> >
> > I've created a patch that introduces a new variable
> > `face-near-same-color-threshold', with a default value of 30000 (as was
> > defined in NEAR_SAME_COLOR_THRESHOLD in xfaces.c). Changing this
> > variable's value will make certain color combinations be considered as
> > 'same', which will lead to :distant-foreground being used. For example:
>
> Sorry for the long delay, I've now pushed your change to the master
> branch.
>
> Please in the future provide a ChangeLog-style commit log message for
> your changes, and also accompany them with the pertinent updates for
> the documentation.  I did that for this change.
>
> Thanks again for working on this.
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.