From unknown Fri Jun 20 19:52:24 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#33988 <33988@debbugs.gnu.org> To: bug#33988 <33988@debbugs.gnu.org> Subject: Status: [PATCH] gnu: libarchive: Replace with libarchive 3.3.3 and fix CVE-2018-{1000877, 1000878, 1000880}. Reply-To: bug#33988 <33988@debbugs.gnu.org> Date: Sat, 21 Jun 2025 02:52:24 +0000 retitle 33988 [PATCH] gnu: libarchive: Replace with libarchive 3.3.3 and fi= x CVE-2018-{1000877, 1000878, 1000880}. reassign 33988 guix-patches submitter 33988 Alex Vong severity 33988 normal tag 33988 security thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 05 10:57:00 2019 Received: (at submit) by debbugs.gnu.org; 5 Jan 2019 15:57:00 +0000 Received: from localhost ([127.0.0.1]:48008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfoJg-000162-Ur for submit@debbugs.gnu.org; Sat, 05 Jan 2019 10:57:00 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfoJY-00015n-Cg for submit@debbugs.gnu.org; Sat, 05 Jan 2019 10:56:52 -0500 Received: from listsout.gnu.org ([208.118.235.17]:36542) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gfoJY-0007KA-0d for submit@debbugs.gnu.org; Sat, 05 Jan 2019 10:56:44 -0500 Received: from eggsout.gnu.org ([209.51.188.92]:55693 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gfoJV-0000l9-NZ for guix-patches@gnu.org; Sat, 05 Jan 2019 10:56:43 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gfoJT-0007Iw-Ue for guix-patches@gnu.org; Sat, 05 Jan 2019 10:56:41 -0500 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]:46947) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gfoJN-0007Fe-NI; Sat, 05 Jan 2019 10:56:33 -0500 Received: by mail-pl1-x62d.google.com with SMTP id t13so18789394ply.13; Sat, 05 Jan 2019 07:56:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:cc:subject:user-agent:date:message-id:mime-version; bh=82+VOgdBftp3D8zHWGunIRD1zvhObQouEK7vqyoy5LU=; b=JjA7p88AItNzh0RTymaCQobW38KfL4RQsXOm6MHYul9alWuvOHmvOtBsZ1w1o+1MN+ 4NGz/dB7QZutNZzhGd9UO/9MroMFF8g1wixoMfvA6gAEkiZudYQqnRbfUil/y9nNJIKN bzi84dPa/goNmhk7oofrbN7Xs5LNa6B2FewCtlmgLn4o9JCapdpf4ZmcLH/bvE2itCPA Ot8evbsPjadtyuX3ZvDRyGLJIwDjKox997VKz94bZfotqlKzcjhisEgQiePvS4aBix2K Xj3SxMuTZMqIXpJ5GCtOPcza5qhRWuO8bO2cKBWDIkDteUobQW4k+bzKs7I+LFD+jGSm Hg1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:cc:subject:user-agent:date:message-id :mime-version; bh=82+VOgdBftp3D8zHWGunIRD1zvhObQouEK7vqyoy5LU=; b=XyAh/sbysqpiJ7PbfPhU4s010HKqPe4uMzWW6KtB4W3RtS7DO1/evrRZrRQKTbBgV2 Ivev1QIlI5oy7lgTFvTItOLdU9EVtZYkc7ZkUwLOrjzYWlOItOlSJi6GbaLDnwbD4cd0 c7kTFelVjodV+P8VtwDFmC+AIXmy+q3jDDM8x5k0YNMQu2cK2pHl8igLDuHrLrJGH5h7 kec869oQjsVtexMy09iBmi+UNgvLdi73aLu5UPDc76u5T5Gfmyd75IZGcLMc7QXo2bHA +5bd2iM2i/O+qg7hNk1CxtRnp2+alJn/OIUyXHYw9D9OAw/obwuq6vr5jHp6lfxbZEqY g+Bg== X-Gm-Message-State: AJcUukdbVCctoHUacoy5/y6ptnlkaqfOaM4pMwshaTMLHJw5lAqgbddS 2YGnygMFYlUnW9ZsnpG3Peg= X-Google-Smtp-Source: ALg8bN4e55kOcYfVHauevquH0ES5Gpnk4uBi0flBZAUJgWZWmbgcXKNxyuQcurc6nTnC5UtcymXNiQ== X-Received: by 2002:a17:902:b18b:: with SMTP id s11mr54751371plr.56.1546703792455; Sat, 05 Jan 2019 07:56:32 -0800 (PST) Received: from debian (n058152176055.netvigator.com. [58.152.176.55]) by smtp.gmail.com with ESMTPSA id w3sm91866821pge.8.2019.01.05.07.56.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 05 Jan 2019 07:56:31 -0800 (PST) From: Alex Vong To: guix-patches@gnu.org Subject: [PATCH] gnu: libarchive: Replace with libarchive 3.3.3 and fix CVE-2018-{1000877, 1000878, 1000880}. User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Sat, 05 Jan 2019 23:56:23 +0800 Message-ID: <87pntbw120.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::62d X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit Cc: alexvong1995@gmail.com, guix-security@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Tags: security Hello guix, The following patch fixes all CVEs in libarchive. Since updating libarchive would cause > 3000 rebuilds, we graft instead. --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: inline; filename=0001-gnu-libarchive-Replace-with-libarchive-3.3.3-and-fix.patch Content-Transfer-Encoding: quoted-printable From=20c8f1c64de45c7a1fefed69d902164f3577aac817 Mon Sep 17 00:00:00 2001 From: Alex Vong Date: Sat, 5 Jan 2019 23:20:41 +0800 Subject: [PATCH] gnu: libarchive: Replace with libarchive 3.3.3 and fix CVE-2018-{1000877,1000878,1000880}. * gnu/packages/backup.scm (libarchive)[source, home-page]: Use HTTPS. [replacement]: New field. (libarchive-3.3.3): New variable. * gnu/packages/patches/libarchive-CVE-2018-1000877.patch, gnu/packages/patches/libarchive-CVE-2018-1000878.patch, gnu/packages/patches/libarchive-CVE-2018-1000880.patch: New files. * gnu/local.mk (dist_patch_DATA): Add them. =2D-- gnu/local.mk | 5 +- gnu/packages/backup.scm | 22 ++++- .../patches/libarchive-CVE-2018-1000877.patch | 45 ++++++++++ .../patches/libarchive-CVE-2018-1000878.patch | 86 +++++++++++++++++++ .../patches/libarchive-CVE-2018-1000880.patch | 51 +++++++++++ 5 files changed, 206 insertions(+), 3 deletions(-) create mode 100644 gnu/packages/patches/libarchive-CVE-2018-1000877.patch create mode 100644 gnu/packages/patches/libarchive-CVE-2018-1000878.patch create mode 100644 gnu/packages/patches/libarchive-CVE-2018-1000880.patch diff --git a/gnu/local.mk b/gnu/local.mk index 6d4159e16..851a9ef0e 100644 =2D-- a/gnu/local.mk +++ b/gnu/local.mk @@ -9,7 +9,7 @@ # Copyright =C2=A9 2016 Adonay "adfeno" Felipe Nogueira # Copyright =C2=A9 2016, 2017, 2018 Ricardo Wurmus # Copyright =C2=A9 2016 Ben Woodcroft =2D# Copyright =C2=A9 2016, 2017, 2018 Alex Vong +# Copyright =C2=A9 2016, 2017, 2018, 2019 Alex Vong # Copyright =C2=A9 2016, 2017 Efraim Flashner # Copyright =C2=A9 2016, 2017 Jan Nieuwenhuizen # Copyright =C2=A9 2017 Tobias Geerinckx-Rice @@ -877,6 +877,9 @@ dist_patch_DATA =3D \ %D%/packages/patches/liba52-use-mtune-not-mcpu.patch \ %D%/packages/patches/libarchive-CVE-2017-14166.patch \ %D%/packages/patches/libarchive-CVE-2017-14502.patch \ + %D%/packages/patches/libarchive-CVE-2018-1000877.patch \ + %D%/packages/patches/libarchive-CVE-2018-1000878.patch \ + %D%/packages/patches/libarchive-CVE-2018-1000880.patch \ %D%/packages/patches/libbase-fix-includes.patch \ %D%/packages/patches/libbase-use-own-logging.patch \ %D%/packages/patches/libbonobo-activation-test-race.patch \ diff --git a/gnu/packages/backup.scm b/gnu/packages/backup.scm index a9d828670..4a8355f2b 100644 =2D-- a/gnu/packages/backup.scm +++ b/gnu/packages/backup.scm @@ -12,6 +12,7 @@ ;;; Copyright =C2=A9 2018 Mark H Weaver ;;; Copyright =C2=A9 2018 Oleg Pykhalov ;;; Copyright =C2=A9 2018 Ricardo Wurmus +;;; Copyright =C2=A9 2019 Alex Vong ;;; ;;; This file is part of GNU Guix. ;;; @@ -194,11 +195,12 @@ backups (called chunks) to allow easy burning to CD/D= VD.") (define-public libarchive (package (name "libarchive") + (replacement libarchive-3.3.3) (version "3.3.2") (source (origin (method url-fetch) =2D (uri (string-append "http://libarchive.org/downloads/libarchive-" + (uri (string-append "https://libarchive.org/downloads/libarchive-" version ".tar.gz")) (patches (search-patches "libarchive-CVE-2017-14166.patch" "libarchive-CVE-2017-14502.patch")) @@ -258,7 +260,7 @@ backups (called chunks) to allow easy burning to CD/DVD= .") ;; libarchive/test/test_write_format_gnutar_filenames.c needs to be ;; compiled with C99 or C11 or a gnu variant. #:configure-flags '("CFLAGS=3D-O2 -g -std=3Dc99"))) =2D (home-page "http://libarchive.org/") + (home-page "https://libarchive.org/") (synopsis "Multi-format archive and compression library") (description "Libarchive provides a flexible interface for reading and writing @@ -270,6 +272,22 @@ archive. In particular, note that there is currently = no built-in support for random access nor for in-place modification.") (license license:bsd-2))) =20 +(define-public libarchive-3.3.3 + (package + (inherit libarchive) + (version "3.3.3") + (source + (origin + (method url-fetch) + (uri (string-append "https://libarchive.org/downloads/libarchive-" + version ".tar.gz")) + (patches (search-patches "libarchive-CVE-2018-1000877.patch" + "libarchive-CVE-2018-1000878.patch" + "libarchive-CVE-2018-1000880.patch")) + (sha256 + (base32 + "0bhfncid058p7n1n8v29l6wxm3mhdqfassscihbsxfwz3iwb2zms")))))) + (define-public rdup (package (name "rdup") diff --git a/gnu/packages/patches/libarchive-CVE-2018-1000877.patch b/gnu/p= ackages/patches/libarchive-CVE-2018-1000877.patch new file mode 100644 index 000000000..5b68884a0 =2D-- /dev/null +++ b/gnu/packages/patches/libarchive-CVE-2018-1000877.patch @@ -0,0 +1,45 @@ +Fix CVE-2018-1000877: + +https://bugs.launchpad.net/ubuntu/+source/libarchive/+bug/1794909 +https://github.com/libarchive/libarchive/pull/1105 +https://cve.mitre.org/cgi-bin/cvename.cgi?name=3DCVE-2018-1000877 +https://security-tracker.debian.org/tracker/CVE-2018-1000877 + +Patch copied from upstream source repository: + +https://github.com/libarchive/libarchive/commit/021efa522ad729ff0f5806c4ce= 53e4a6cc1daa31 + +From 021efa522ad729ff0f5806c4ce53e4a6cc1daa31 Mon Sep 17 00:00:00 2001 +From: Daniel Axtens +Date: Tue, 20 Nov 2018 17:56:29 +1100 +Subject: [PATCH] Avoid a double-free when a window size of 0 is specified + +new_size can be 0 with a malicious or corrupted RAR archive. + +realloc(area, 0) is equivalent to free(area), so the region would +be free()d here and the free()d again in the cleanup function. + +Found with a setup running AFL, afl-rb, and qsym. +--- + libarchive/archive_read_support_format_rar.c | 5 +++++ + 1 file changed, 5 insertions(+) + +diff --git a/libarchive/archive_read_support_format_rar.c b/libarchive/arc= hive_read_support_format_rar.c +index 23452222..6f419c27 100644 +--- a/libarchive/archive_read_support_format_rar.c ++++ b/libarchive/archive_read_support_format_rar.c +@@ -2300,6 +2300,11 @@ parse_codes(struct archive_read *a) + new_size =3D DICTIONARY_MAX_SIZE; + else + new_size =3D rar_fls((unsigned int)rar->unp_size) << 1; ++ if (new_size =3D=3D 0) { ++ archive_set_error(&a->archive, ARCHIVE_ERRNO_FILE_FORMAT, ++ "Zero window size is invalid."); ++ return (ARCHIVE_FATAL); ++ } + new_window =3D realloc(rar->lzss.window, new_size); + if (new_window =3D=3D NULL) { + archive_set_error(&a->archive, ENOMEM, +--=20 +2.20.1 + diff --git a/gnu/packages/patches/libarchive-CVE-2018-1000878.patch b/gnu/p= ackages/patches/libarchive-CVE-2018-1000878.patch new file mode 100644 index 000000000..fef088132 =2D-- /dev/null +++ b/gnu/packages/patches/libarchive-CVE-2018-1000878.patch @@ -0,0 +1,86 @@ +Fix CVE-2018-1000878: + +https://bugs.launchpad.net/ubuntu/+source/libarchive/+bug/1794909 +https://github.com/libarchive/libarchive/pull/1105 +https://cve.mitre.org/cgi-bin/cvename.cgi?name=3DCVE-2018-1000878 +https://security-tracker.debian.org/tracker/CVE-2018-1000878 + +Patch copied from upstream source repository: + +https://github.com/libarchive/libarchive/commit/bfcfe6f04ed20db2504db8a254= d1f40a1d84eb28 + +From bfcfe6f04ed20db2504db8a254d1f40a1d84eb28 Mon Sep 17 00:00:00 2001 +From: Daniel Axtens +Date: Tue, 4 Dec 2018 00:55:22 +1100 +Subject: [PATCH] rar: file split across multi-part archives must match + +Fuzzing uncovered some UAF and memory overrun bugs where a file in a +single file archive reported that it was split across multiple +volumes. This was caused by ppmd7 operations calling +rar_br_fillup. This would invoke rar_read_ahead, which would in some +situations invoke archive_read_format_rar_read_header. That would +check the new file name against the old file name, and if they didn't +match up it would free the ppmd7 buffer and allocate a new +one. However, because the ppmd7 decoder wasn't actually done with the +buffer, it would continue to used the freed buffer. Both reads and +writes to the freed region can be observed. + +This is quite tricky to solve: once the buffer has been freed it is +too late, as the ppmd7 decoder functions almost universally assume +success - there's no way for ppmd_read to signal error, nor are there +good ways for functions like Range_Normalise to propagate them. So we +can't detect after the fact that we're in an invalid state - e.g. by +checking rar->cursor, we have to prevent ourselves from ever ending up +there. So, when we are in the dangerous part or rar_read_ahead that +assumes a valid split, we set a flag force read_header to either go +down the path for split files or bail. This means that the ppmd7 +decoder keeps a valid buffer and just runs out of data. + +Found with a combination of AFL, afl-rb and qsym. +--- + libarchive/archive_read_support_format_rar.c | 9 +++++++++ + 1 file changed, 9 insertions(+) + +diff --git a/libarchive/archive_read_support_format_rar.c b/libarchive/arc= hive_read_support_format_rar.c +index 6f419c27..a8cc5c94 100644 +--- a/libarchive/archive_read_support_format_rar.c ++++ b/libarchive/archive_read_support_format_rar.c +@@ -258,6 +258,7 @@ struct rar + struct data_block_offsets *dbo; + unsigned int cursor; + unsigned int nodes; ++ char filename_must_match; +=20 + /* LZSS members */ + struct huffman_code maincode; +@@ -1560,6 +1561,12 @@ read_header(struct archive_read *a, struct archive_= entry *entry, + } + return ret; + } ++ else if (rar->filename_must_match) ++ { ++ archive_set_error(&a->archive, ARCHIVE_ERRNO_FILE_FORMAT, ++ "Mismatch of file parts split across multi-volume archive"); ++ return (ARCHIVE_FATAL); ++ } +=20 + rar->filename_save =3D (char*)realloc(rar->filename_save, + filename_size + 1); +@@ -2933,12 +2940,14 @@ rar_read_ahead(struct archive_read *a, size_t min,= ssize_t *avail) + else if (*avail =3D=3D 0 && rar->main_flags & MHD_VOLUME && + rar->file_flags & FHD_SPLIT_AFTER) + { ++ rar->filename_must_match =3D 1; + ret =3D archive_read_format_rar_read_header(a, a->entry); + if (ret =3D=3D (ARCHIVE_EOF)) + { + rar->has_endarc_header =3D 1; + ret =3D archive_read_format_rar_read_header(a, a->entry); + } ++ rar->filename_must_match =3D 0; + if (ret !=3D (ARCHIVE_OK)) + return NULL; + return rar_read_ahead(a, min, avail); +--=20 +2.20.1 + diff --git a/gnu/packages/patches/libarchive-CVE-2018-1000880.patch b/gnu/p= ackages/patches/libarchive-CVE-2018-1000880.patch new file mode 100644 index 000000000..6834cabda =2D-- /dev/null +++ b/gnu/packages/patches/libarchive-CVE-2018-1000880.patch @@ -0,0 +1,51 @@ +Fix CVE-2018-1000880: + +https://bugs.launchpad.net/ubuntu/+source/libarchive/+bug/1794909 +https://github.com/libarchive/libarchive/pull/1105 +https://cve.mitre.org/cgi-bin/cvename.cgi?name=3DCVE-2018-1000880 +https://security-tracker.debian.org/tracker/CVE-2018-1000880 + +Patch copied from upstream source repository: + +https://github.com/libarchive/libarchive/commit/9c84b7426660c09c18cc349f6d= 70b5f8168b5680 + +From 9c84b7426660c09c18cc349f6d70b5f8168b5680 Mon Sep 17 00:00:00 2001 +From: Daniel Axtens +Date: Tue, 4 Dec 2018 16:33:42 +1100 +Subject: [PATCH] warc: consume data once read + +The warc decoder only used read ahead, it wouldn't actually consume +data that had previously been printed. This means that if you specify +an invalid content length, it will just reprint the same data over +and over and over again until it hits the desired length. + +This means that a WARC resource with e.g. +Content-Length: 6666666666666666666666666666666666666666666666666666666666= 66666666666666666666666666666666666666666666666666665 +but only a few hundred bytes of data, causes a quasi-infinite loop. + +Consume data in subsequent calls to _warc_read. + +Found with an AFL + afl-rb + qsym setup. +--- + libarchive/archive_read_support_format_warc.c | 5 +++++ + 1 file changed, 5 insertions(+) + +diff --git a/libarchive/archive_read_support_format_warc.c b/libarchive/ar= chive_read_support_format_warc.c +index e8753853..e8fc8428 100644 +--- a/libarchive/archive_read_support_format_warc.c ++++ b/libarchive/archive_read_support_format_warc.c +@@ -386,6 +386,11 @@ _warc_read(struct archive_read *a, const void **buf, = size_t *bsz, int64_t *off) + return (ARCHIVE_EOF); + } +=20 ++ if (w->unconsumed) { ++ __archive_read_consume(a, w->unconsumed); ++ w->unconsumed =3D 0U; ++ } ++ + rab =3D __archive_read_ahead(a, 1U, &nrd); + if (nrd < 0) { + *bsz =3D 0U; +--=20 +2.20.1 + =2D-=20 2.20.1 --=-=-= Content-Type: text/plain Cheers, Alex --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQQwb8uPLAHCXSnTBVZh71Au9gJS8gUCXDDTpwAKCRBh71Au9gJS 8nLRAQC+OYAjLWLK9qYlY6/SI9b2+9wU/aEyxt1Tkykv6FSL9wEA9tQriX64sSlH 47hMZx3nnnRcIgtegTOpcqmt9INdbAY= =lE/M -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 06 13:16:52 2019 Received: (at 33988) by debbugs.gnu.org; 6 Jan 2019 18:16:52 +0000 Received: from localhost ([127.0.0.1]:48985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggCyh-000368-Ry for submit@debbugs.gnu.org; Sun, 06 Jan 2019 13:16:52 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:55945) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggCyf-00035t-G9 for 33988@debbugs.gnu.org; Sun, 06 Jan 2019 13:16:51 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 262982204C; Sun, 6 Jan 2019 13:16:44 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 06 Jan 2019 13:16:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=vcvFNyPp67RoSNMMrb/bV0DC MITW8nFACM9RKqpXCuo=; b=p8/6bcs+V7eZ/PFMMV8mp+p2Q6+2tV7Yal9fbHnQ /d5HkfZvyVkYxkZEVM89NYTF0McFACejHjW2MWSBbVZINliunwJ83P1YgYuSnx4U G3ajYEri4z47Z5Z3XqJ5KhbYhkBQCHuo0YkziFsb+arRxhwPdaN6PReZg23q0lS6 j2k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=vcvFNy Pp67RoSNMMrb/bV0DCMITW8nFACM9RKqpXCuo=; b=XABJ1pkXaLa6GWw60ev+5/ o7qgDvqp4a9G98RIB4TSF/Vah/lpxAaXzx7uArhDRpGxwUU1xf9c9ydpI9AgZ1nR JxXpxvqCqY3HzxSkNBl2BTHL68PqrO6wf3m/694s70WHWhxaP/hO7BlVzOLSu9fF 13Bq2T75X0UG0LpfVo4cRU2PF9kxLzh3/wYhiVBSdtSWsHkzAEki0nQcLAfarQmh XZe2Hre49huEIkEtsn6lF/DwGUOPQGAHJaT7Lmg0PTXf4zLzK2i8CE3JnL4LLPBU dLhRwztBauTMimERddgPXNjUy6skeecODT8BBJcZRhb7XSfMPJxRF/SRV4a02Udg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrvdehgdduudefucdltddurdegtdekrddttd dmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhht necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujggfsehgtderredtredvnecuhfhrohhmpefnvgho ucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucfkphepje eirdduvdegrddvtddvrddufeejnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehf rghmuhhlrghrihdrnhgrmhgvnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (c-76-124-202-137.hsd1.pa.comcast.net [76.124.202.137]) by mail.messagingengine.com (Postfix) with ESMTPA id BEF38E464E; Sun, 6 Jan 2019 13:16:40 -0500 (EST) Date: Sun, 6 Jan 2019 13:16:38 -0500 From: Leo Famulari To: Alex Vong Subject: Re: [bug#33988] [PATCH] gnu: libarchive: Replace with libarchive 3.3.3 and fix CVE-2018-{1000877, 1000878, 1000880}. Message-ID: <20190106181638.GA18341@jasmine.lan> References: <87pntbw120.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DocE+STaALJfprDB" Content-Disposition: inline In-Reply-To: <87pntbw120.fsf@gmail.com> User-Agent: Mutt/1.11.0 (2018-11-25) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33988 Cc: 33988@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --DocE+STaALJfprDB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 05, 2019 at 11:56:23PM +0800, Alex Vong wrote: > Tags: security >=20 > Hello guix, >=20 > The following patch fixes all CVEs in libarchive. Since updating > libarchive would cause > 3000 rebuilds, we graft instead. >=20 > From c8f1c64de45c7a1fefed69d902164f3577aac817 Mon Sep 17 00:00:00 2001 > From: Alex Vong > Date: Sat, 5 Jan 2019 23:20:41 +0800 > Subject: [PATCH] gnu: libarchive: Replace with libarchive 3.3.3 and fix > CVE-2018-{1000877,1000878,1000880}. >=20 > * gnu/packages/backup.scm (libarchive)[source, home-page]: Use HTTPS. > [replacement]: New field. > (libarchive-3.3.3): New variable. > * gnu/packages/patches/libarchive-CVE-2018-1000877.patch, > gnu/packages/patches/libarchive-CVE-2018-1000878.patch, > gnu/packages/patches/libarchive-CVE-2018-1000880.patch: New files. > * gnu/local.mk (dist_patch_DATA): Add them. Thanks, this works for me. Please push! :) --DocE+STaALJfprDB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlwyRgIACgkQJkb6MLrK fwhaIA//c2/eVCJTsWSFtB2r8RMx6JCwiB7VuKbzQhpuFPXTiTF2lSI2gQWC0ATc 4VSbk2XLmNOeAV4I4LZF9r4pA1rjlWbQh9aSCoEGxMWfmkMfsWABoal0XsLcYccb SxmtWsTOYiZ+qgt6y6ef7odnnmBLikzcWg+Vr2xqqMmyoxiYKK7HdxNx3/KarTZk 5waonSqi+9wf+ES9V30XeKDGwdyf55mVkyRsQ+QibwPJ7UoHFhfSJs12gRxNxloW 6DTSbRVgra0Aebd9g0qvYjxvkQCT6PuSI5mucq9/StNjSuWpNa55Ao/agv1xt+/h wPidDx92CjY8fQoy0RBvbseMhadGILlJSlEi1pfFR9NGnxN96IWlpENR6hpReDSF DNXsYf4U+Rv0BUfIx2vpC/kjmCq4vmwJOhXd8DKfjIkOPITyp9VjVnZZxKKn3HWe ruA2cQ9BqHfglFVQiBM7ilFGoDe22w7WNBh6t1u3upQUdgUATI+AuZqQF1nz2tdI U+9rIkXUXS5PO3/pfMBANVvNWgDCXId6il+YsM4A9FLDwL9RW7lS07+eFsDi6A8n H97PdOGnDlFbJ/aedm19mjFAqTEXLqlwyBP0BWlJfXfZ6sjQOW7WjHHO2Xabcgdu rWuVJ3EEa24kbfuyIZi5PHkrjln4Ewvur7EBcUFlbTNQgeHJ98I= =Ojun -----END PGP SIGNATURE----- --DocE+STaALJfprDB-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 06 16:53:39 2019 Received: (at 33988-done) by debbugs.gnu.org; 6 Jan 2019 21:53:39 +0000 Received: from localhost ([127.0.0.1]:47393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggGMV-0000sN-7R for submit@debbugs.gnu.org; Sun, 06 Jan 2019 16:53:39 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:44442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggGMS-0000s9-RX for 33988-done@debbugs.gnu.org; Sun, 06 Jan 2019 16:53:38 -0500 Received: by mail-pg1-f195.google.com with SMTP id t13so19814247pgr.11 for <33988-done@debbugs.gnu.org>; Sun, 06 Jan 2019 13:53:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=ftAEvYHkRvU69SuWr3VaHPz+f6nb8X6UB3B9lP6vBE0=; b=CwGlYzZ+4YlcAfo0bbRWj7UP6xPF9YE5GPWYg+OuhC1WaZMbOy7HTQ36zNkopalVdM Dd6nkc0a5Pa19Yf7iGmkt3i2RudOu6jymgGTV6rsse6nx+eNOgdDAGMhyDNlqeumh3Ak YNXmO98pqsiQIkmzxc6mohYMT8iHDVveBHj0JMGa6z/vfRHHM/rPqHsy6mfhn+bb9uIT keKKzXGnW4jkSdI0PB+oQufs7Z8VDi5zcg5TqNRMU7v7Sxu3rHUHZGP702NfeuoZ0SHu AK1FurVqxtkfxOgHptV8vOeBgrkFa+dAGPeVzGC6bqImt7DLBHxywlTjRgXvjIF8ICbT 0QKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=ftAEvYHkRvU69SuWr3VaHPz+f6nb8X6UB3B9lP6vBE0=; b=AaI/pm3AJyQZ7FfSZ/F+s4LBXcqemwCfjC7W0rUodg53XeRI4YZIPu07Q2AJi4fd8n xPGg/22xVk4Og6Wab4P0zVp7tR6IfJ4WJFH453WGTUL8d/JqtZ5XZ/5qS0Uxgam3p85L ZNYaV4QC0Yg1uYfQ2oJp8XjiOAMZBn19QUwo7DxkFsRJUizL7xlEfiV21dIfwWIFwpJS O/B5/pAal5y8CNAeWoM5VbyHYtAHElq1sGTqCNa7Nporq/nj3X68bqnOC3a8I9euigX0 Q75z2YvU3tHIG2MJSF1NKd4sAnj8LIRR8QhrMnlRL1v2oFVnkbQvtG4D3Mk+Z1O0TYsO 2kWQ== X-Gm-Message-State: AJcUukfOUgpvixbuEEAzlKkbRIHqfGxDDaTF0nO8isRjcPY+sH1BeKgv ZvatUVJW6eH9ZleulxdD2Zs= X-Google-Smtp-Source: ALg8bN4FgGQxiexNctqnrPnNCukLTK0EhfpehlH78Wt6ofVZ2S5Ks58yXmNzPjAxoa43lnX0WshU5w== X-Received: by 2002:a63:1c61:: with SMTP id c33mr54669684pgm.354.1546811610766; Sun, 06 Jan 2019 13:53:30 -0800 (PST) Received: from debian (n058152176055.netvigator.com. [58.152.176.55]) by smtp.gmail.com with ESMTPSA id a17sm83424371pgm.26.2019.01.06.13.53.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 06 Jan 2019 13:53:30 -0800 (PST) From: Alex Vong To: 33988-done@debbugs.gnu.org Subject: Re: [bug#33988] [PATCH] gnu: libarchive: Replace with libarchive 3.3.3 and fix CVE-2018-{1000877, 1000878, 1000880}. In-Reply-To: <20190106181638.GA18341@jasmine.lan> (Leo Famulari's message of "Sun, 6 Jan 2019 13:16:38 -0500") References: <87pntbw120.fsf@gmail.com> <20190106181638.GA18341@jasmine.lan> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Mon, 07 Jan 2019 05:53:19 +0800 Message-ID: <87va31pi5s.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 33988-done Cc: alexvong1995@gmail.com, Leo Famulari X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > On Sat, Jan 05, 2019 at 11:56:23PM +0800, Alex Vong wrote: >> Tags: security >>=20 >> Hello guix, >>=20 >> The following patch fixes all CVEs in libarchive. Since updating >> libarchive would cause > 3000 rebuilds, we graft instead. >>=20 > >> From c8f1c64de45c7a1fefed69d902164f3577aac817 Mon Sep 17 00:00:00 2001 >> From: Alex Vong >> Date: Sat, 5 Jan 2019 23:20:41 +0800 >> Subject: [PATCH] gnu: libarchive: Replace with libarchive 3.3.3 and fix >> CVE-2018-{1000877,1000878,1000880}. >>=20 >> * gnu/packages/backup.scm (libarchive)[source, home-page]: Use HTTPS. >> [replacement]: New field. >> (libarchive-3.3.3): New variable. >> * gnu/packages/patches/libarchive-CVE-2018-1000877.patch, >> gnu/packages/patches/libarchive-CVE-2018-1000878.patch, >> gnu/packages/patches/libarchive-CVE-2018-1000880.patch: New files. >> * gnu/local.mk (dist_patch_DATA): Add them. > > Thanks, this works for me. Please push! :) Thanks for the review. Pushed as c824dedf711dc4aa33e005fa291a3aec58a9e2e2! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQQwb8uPLAHCXSnTBVZh71Au9gJS8gUCXDJ4zwAKCRBh71Au9gJS 8vZKAQCjIVLlMfl65jaNPVJRWlfoSDZULV0s5xl2u7w/tPxOowD/Xe/0qcImW8qX AqjC6gr53MxWxLYK5C7pU1NG5fUGuQM= =TZlY -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 07 04:27:51 2019 Received: (at 33988) by debbugs.gnu.org; 7 Jan 2019 09:27:51 +0000 Received: from localhost ([127.0.0.1]:47636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggRCH-0002NU-Qu for submit@debbugs.gnu.org; Mon, 07 Jan 2019 04:27:51 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:59628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggRCG-0002NM-7Z for 33988@debbugs.gnu.org; Mon, 07 Jan 2019 04:27:48 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 9BD7BDB6; Mon, 7 Jan 2019 10:27:46 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sSXsvdZ911B1; Mon, 7 Jan 2019 10:27:45 +0100 (CET) Received: from ribbon (unknown [IPv6:2001:660:6102:320:e120:2c8f:8909:cdfe]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 6B6658B5; Mon, 7 Jan 2019 10:27:45 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Alex Vong Subject: Re: [bug#33988] [PATCH] gnu: libarchive: Replace with libarchive 3.3.3 and fix CVE-2018-{1000877, 1000878, 1000880}. References: <87pntbw120.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 18 =?utf-8?Q?Niv=C3=B4se?= an 227 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 07 Jan 2019 10:27:44 +0100 In-Reply-To: <87pntbw120.fsf@gmail.com> (Alex Vong's message of "Sat, 05 Jan 2019 23:56:23 +0800") Message-ID: <8736q4g6lr.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 33988 Cc: 33988@debbugs.gnu.org, guix-security@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi Alex, Alex Vong skribis: > From c8f1c64de45c7a1fefed69d902164f3577aac817 Mon Sep 17 00:00:00 2001 > From: Alex Vong > Date: Sat, 5 Jan 2019 23:20:41 +0800 > Subject: [PATCH] gnu: libarchive: Replace with libarchive 3.3.3 and fix > CVE-2018-{1000877,1000878,1000880}. > > * gnu/packages/backup.scm (libarchive)[source, home-page]: Use HTTPS. > [replacement]: New field. > (libarchive-3.3.3): New variable. > * gnu/packages/patches/libarchive-CVE-2018-1000877.patch, > gnu/packages/patches/libarchive-CVE-2018-1000878.patch, > gnu/packages/patches/libarchive-CVE-2018-1000880.patch: New files. > * gnu/local.mk (dist_patch_DATA): Add them. LGTM, thank you! Ludo=E2=80=99. From unknown Fri Jun 20 19:52:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 04 Feb 2019 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator