GNU bug report logs - #33986
[PATCH 1/9] gnu: Add ocaml-sexplib0.

Previous Next

Full log

Message #32 received at 33986 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: Gabriel Hondet <gabrielhondet <at> gmail.com>,33986 <at> debbugs.gnu.org
Subject: Re: [bug#33986] [PATCH 1/9] gnu: Add ocaml-sexplib0.
Date: Sat, 05 Jan 2019 16:22:02 +0300

Le 3 janvier 2019 10:18:32 GMT+03:00, Gabriel Hondet <gabrielhondet <at> gmail.com> a écrit :
>
>* gnu/packages/ocaml.scm (ocaml-sexplib0): New variable.
>---
> gnu/packages/ocaml.scm | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
>diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
>index e4f17133d..bece14477 100644
>--- a/gnu/packages/ocaml.scm
>+++ b/gnu/packages/ocaml.scm
>@@ -5105,3 +5105,28 @@ speedup, polymorphic variants and optional
>syntax for tuples and variants.
>yojson package.  The program @code{atdgen} can be used to derive
>OCaml-JSON
> serializers and deserializers from type definitions.")
>     (license license:bsd-3)))
>+
>+(define-public ocaml-sexplib0
>+  (package
>+    (name "ocaml-sexplib0")
>+    (version "0.11.0")
>+    (home-page "https://github.com/janestreet/sexplib0")
>+    (source
>+     (origin
>+       (method git-fetch)
>+       (uri (git-reference
>+             (url (string-append home-page ".git"))
>+             (commit (string-append "v" version))))
>+       (file-name (git-file-name name version))
>+       (sha256
>+        (base32
>+         "07v3ggyss7xhfv14bjk1n87sr42iqwj4cgjiv2lcdfkqk49i2bmi"))))
>+    (build-system dune-build-system)
>+    (arguments
>+     '(#:tests? #f))
>+    (synopsis "Library containing the definition of S-expressions and
>some
>+base converters")
>+    (description "Part of Jane Street's Core library The Core suite of
>+libraries is an industrial strength alternative to OCaml's standard
>library
>+that was developed by Jane Street, the largest industrial user of
>OCaml.")
>+(license license:expat)))

Hi Gabriel, thank you for these patches! I'll need a bit more time to review them because I'm travelling. We already have them, but I think they are only for ocaml-4.02.

In the meantime, could you add a comment to explain why you disabled tests whenever you did? It could be as short as "; no tests". Also, do you know what happened with the versionning?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.