Subject: Re: [bug#33986] [PATCH 1/9] gnu: Add ocaml-sexplib0.

From: Gabriel Hondet <[email-masked]>
Date: Sat, 05 Jan 2019 17:36:56 +0100

On Sat 05 Jan 2019 at 14:22 Julien Lepiller wrote:

> We already have them, but I think they are only for ocaml-4.02.

Indeed they exist but only for ocaml-4.02, I hope doing new patches for
the current version was the right thing to do.

> In the meantime, could you add a comment to explain why you disabled tests whenever you did? It could be as short as "; no tests". Also, do you know what happened with the versionning?

Regarding the test, I only disabled them if they don't exist.  I have
added comments to clarify that.  Regarding the versioning number
(113.33.xx in 2016 to 0.9.0 in 2017...), I have no idea what happened.

Here is the first patch, the others are following.

* gnu/packages/ocaml.scm (ocaml-sexplib0): New variable.
---
 gnu/packages/ocaml.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index e4f17133d..a23f6a724 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -5105,3 +5105,28 @@ speedup, polymorphic variants and optional syntax for tuples and variants.
 yojson package.  The program @code{atdgen} can be used to derive OCaml-JSON
 serializers and deserializers from type definitions.")
     (license license:bsd-3)))
+
+(define-public ocaml-sexplib0
+  (package
+    (name "ocaml-sexplib0")
+    (version "0.11.0")
+    (home-page "https://github.com/janestreet/sexplib0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url (string-append home-page ".git"))
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "07v3ggyss7xhfv14bjk1n87sr42iqwj4cgjiv2lcdfkqk49i2bmi"))))
+    (build-system dune-build-system)
+    (arguments
+     '(#:tests? #f)) ;no tests
+    (synopsis "Library containing the definition of S-expressions and some
+base converters")
+    (description "Part of Jane Street's Core library The Core suite of
+libraries is an industrial strength alternative to OCaml's standard library
+that was developed by Jane Street, the largest industrial user of OCaml.")
+(license license:expat)))
-- 
2.20.1