GNU bug report logs - #33984
26.1; fortune-compile does not search exec-path for strfile program

Previous Next

Full log

Message #8 received at 33984 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "Benjamin Ragheb" <ben <at> benzado.com>
Cc: 33984 <at> debbugs.gnu.org
Subject: Re: bug#33984: 26.1;
 fortune-compile does not search exec-path for strfile program
Date: Wed, 10 Jul 2019 00:32:28 +0200

"Benjamin Ragheb" <ben <at> benzado.com> writes:

> I have attached a patch which corrects this problem by using
> executable-find before calling shell-command. If strfile cannot be
> found, it signals an error.

Makes sense.

> I tried to keep the patch as small as possible, and resisted the
> temptation to replace the call to shell-command with
> call-process. Doing so would have broken compatibility with the
> fortune-quiet-strfile-options variable, which people may have
> customized.

Yeah, that would be better, but would be incompatible as you say.

> -			(concat fortune-file fortune-database-extension)))))
> +			(concat fortune-file fortune-database-extension))))
> +         (strfile (or (executable-find fortune-strfile)
> +                      (error "Can't find strfile program %s" fortune-strfile)))
>    (cond ((file-exists-p fortune-file)
>           (cond ((file-newer-than-file-p fortune-file fortune-dat)
>                  (message "Compiling new fortune database %s" fortune-dat)
>                  (shell-command
> -                 (concat fortune-strfile fortune-strfile-options
> +                 (concat strfile fortune-strfile-options

I've now applied this patch to the Emacs trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.