GNU bug report logs - #33980
gnu: Add pwsafe

Previous Next

Full log

Message #8 received at 33980 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
Cc: 33980 <at> debbugs.gnu.org
Subject: Re: [bug#33980] gnu: Add pwsafe
Date: Wed, 09 Jan 2019 18:00:24 +0100

Hi Tim,

Tim Gesthuizen <tim.gesthuizen <at> yahoo.de> skribis:

> From b85b078e18a8166231320f05e938f5f0264f5097 Mon Sep 17 00:00:00 2001
> From: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
> Date: Sat, 29 Dec 2018 23:21:58 +0100
> Subject: [PATCH] gnu: Add pwsafe
>
> * gnu/packages/password-utils.scm (pwsafe): New variable

Overall LGTM.  Nitpicking:

> +    ;; TODO: The help subsystem cannot be initialized
> +    ;; TODO: pwsafe tries to download GTest which does not work in the daemon
> +    ;; environment and is not functional. Substitute CMakeLists.txt to use
> +    ;; native GTest and reenable unit tests.
> +    (arguments '(#:configure-flags (list "-DNO_GTEST=YES")))

It would be ideal if you could get the tests running.  :-)

> +    (native-inputs `(("coreutils" ,coreutils)

Coreutils is not needed, it’s an implicit input already.

> +    (synopsis "Password safe to store passwords encrypted")
> +    (description "A password manager originally designed by Bruce Schneier.
> +It offers a simple UI to manage passwords for different services.  There are
> +other programs that support the file format on different plattforms.")
                                                               ^^
Typo.

Also please make full sentences.

Could you send an updated patch?

Thank you,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.