Subject: [bug#33980] gnu: Add pwsafe

From: Ludovic Courtès <[email-masked]>
Date: Wed, 09 Jan 2019 18:00:24 +0100

Hi Tim,

Tim Gesthuizen <[email-masked]> skribis:

> From b85b078e18a8166231320f05e938f5f0264f5097 Mon Sep 17 00:00:00 2001
> From: Tim Gesthuizen <[email-masked]>
> Date: Sat, 29 Dec 2018 23:21:58 +0100
> Subject: [PATCH] gnu: Add pwsafe
>
> * gnu/packages/password-utils.scm (pwsafe): New variable

Overall LGTM.  Nitpicking:

> +    ;; TODO: The help subsystem cannot be initialized
> +    ;; TODO: pwsafe tries to download GTest which does not work in the daemon
> +    ;; environment and is not functional. Substitute CMakeLists.txt to use
> +    ;; native GTest and reenable unit tests.
> +    (arguments '(#:configure-flags (list "-DNO_GTEST=YES")))

It would be ideal if you could get the tests running.  :-)

> +    (native-inputs `(("coreutils" ,coreutils)

Coreutils is not needed, it’s an implicit input already.

> +    (synopsis "Password safe to store passwords encrypted")
> +    (description "A password manager originally designed by Bruce Schneier.
> +It offers a simple UI to manage passwords for different services.  There are
> +other programs that support the file format on different plattforms.")
                                                               ^^
Typo.

Also please make full sentences.

Could you send an updated patch?

Thank you,
Ludo’.