GNU bug report logs - #33975
[PATCH] inhibit read-only text properties in comint-interrupt-subjob

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Alex Branham <alex.branham <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#33975: closed ([PATCH] inhibit read-only text properties in
 comint-interrupt-subjob)
Date: Mon, 25 Feb 2019 01:12:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 24 Feb 2019 19:11:40 -0600
with message-id <874l8sbrjn.fsf <at> gmail.com>
and subject line Re: bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob
has caused the debbugs.gnu.org bug report #33975,
regarding [PATCH] inhibit read-only text properties in comint-interrupt-subjob
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
33975: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33975
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Alex Branham <alex.branham <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] inhibit read-only text properties in comint-interrupt-subjob
Date: Fri, 04 Jan 2019 10:35:05 -0600

[Message part 3 (text/plain, inline)]

Hi -

This patch inhibits read-only properties during comint-interrupt-subjob.
I ran across this while using ESS and (setq comint-prompt-read-only t).
There's a little more info (including a reproducible example) on ESS's
bugtracker.[1]

Thanks,
Alex

From 8e3885c5b9747987cacd3b17b9de29975e7691e3 Mon Sep 17 00:00:00 2001
From: Alex Branham <alex.branham <at> gmail.com>
Date: Fri, 4 Jan 2019 10:28:09 -0600
Subject: [PATCH] * lisp/comint.el (comint-interrupt-subjob): Inhibit read only

Otherwise with comint-prompt-read-only set to t users can be incapable
of interrupting running busy processes. See ESS's issue tracker for
details: https://github.com/emacs-ess/ESS/issues/792
---
 lisp/comint.el | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lisp/comint.el b/lisp/comint.el
index 0a6aff2e73..2ed65c1c1c 100644
--- a/lisp/comint.el
+++ b/lisp/comint.el
@@ -2500,8 +2500,9 @@ comint-clear-buffer
 (defun comint-interrupt-subjob ()
   "Interrupt the current subjob."
   (interactive)
-  (comint-skip-input)
-  (interrupt-process nil comint-ptyp)
+  (let ((inhibit-read-only t))
+    (comint-skip-input)
+    (interrupt-process nil comint-ptyp))
   ;; (process-send-string nil "\n")
   )

--
2.19.2

[0001-lisp-comint.el-comint-interrupt-subjob-Inhibit-read-.patch (text/x-patch, attachment)]

[Message part 5 (text/plain, inline)]

Footnotes:
[1]  https://github.com/emacs-ess/ESS/issues/792

[signature.asc (application/pgp-signature, inline)]

[Message part 7 (message/rfc822, inline)]

From: Alex Branham <alex.branham <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 33975-done <at> debbugs.gnu.org
Subject: Re: bug#33975: [PATCH] inhibit read-only text properties in
 comint-interrupt-subjob
Date: Sun, 24 Feb 2019 19:11:40 -0600

[Message part 8 (text/plain, inline)]

On Sat 23 Feb 2019 at 11:01, Eli Zaretskii <eliz <at> gnu.org> wrote:

> "this command" is inaccurate here, as comint-skip-input is not a
> command.  I'd say "the command which called this function" instead.
>
> Other than that, LGTM.  Thanks.

Thanks, fixed and pushed to master as
6a3b1aaa066dac28355ca5d09550947250108950 to appear in Emacs 27

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.