From unknown Fri Aug 15 20:54:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Jan 2019 16:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33975 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 33975@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.154661971612043 (code B ref -1); Fri, 04 Jan 2019 16:36:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 Jan 2019 16:35:16 +0000 Received: from localhost ([127.0.0.1]:47023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfSRI-00038B-Ax for submit@debbugs.gnu.org; Fri, 04 Jan 2019 11:35:16 -0500 Received: from eggsout.gnu.org ([209.51.188.92]:52030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfSRG-000383-Kw for submit@debbugs.gnu.org; Fri, 04 Jan 2019 11:35:15 -0500 Received: from lists.gnu.org ([208.118.235.17]:41756) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gfSRF-0000DB-DN for submit@debbugs.gnu.org; Fri, 04 Jan 2019 11:35:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gfSRE-0004yn-DQ for bug-gnu-emacs@gnu.org; Fri, 04 Jan 2019 11:35:13 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gfSRB-0000BM-4F for bug-gnu-emacs@gnu.org; Fri, 04 Jan 2019 11:35:12 -0500 Received: from mail-oi1-x241.google.com ([2607:f8b0:4864:20::241]:41791) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gfSRA-0000At-TP for bug-gnu-emacs@gnu.org; Fri, 04 Jan 2019 11:35:09 -0500 Received: by mail-oi1-x241.google.com with SMTP id j21so30786231oii.8 for ; Fri, 04 Jan 2019 08:35:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=EYT1AeHS/4tw/JuRybyB3UK8lfNqexKDPNAwZY5MVMQ=; b=hN5bb3UD5u5dtFLqGORYESReX7FjQQtWEBQ9xWSszBWfH97sSmSbF1+oj8JBiYSdZM ZrR9ydlJkeP2AzOaYxltJGaqBrAiXdlu4K8sjhYBod4I1QK6tcgesnaYYXCbybOgl3NZ Nu71GRYB5EhddId9XqbvaR4ZzStl2a4+j0QsHO9xJD1cfC2sYNJToI1Sf9P0TGPUIY3X QFSu7L0T8GE25g44W1XNi4xm4jsUm0rVUw45trp7eIH8Mb/4P809QfaQbgQ/hsavgYJ9 5A5ywcZFv9HKPz2akC4zlhrPQfe/N5GBBPeFc5EfiOhzSTBLA5lIKw2j1i1qzmTqjE3/ aL7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=EYT1AeHS/4tw/JuRybyB3UK8lfNqexKDPNAwZY5MVMQ=; b=h6PhyHyd7VYFtFILDLuIwtcMEgxnBILC2gDv3qUGVJTJ6vGNDTYUb71plOWjI3JzCC lr7FbKvt8FL5oSKqmitSdYaLDrTq0bEvwN4a3VdfcChkuCg6XTymG/AwbMHyXZHN8PAN ny/6nUWito14JcggwzlDbMeBPiVflM0JA4ArxuKyn+9os/klOLQYImu9sh8e2PuLy3Qz 2nRr+h27bqVlVyAv/oX/kOJLjmRFRsHRFj8w4MmuJrpAioLv+6X7OoJq7roygjxgtXvE 9K2aIKgSBK6ZOmPguOfveqfjxusaLKVDojTpPkNZ/gYSGflKZDR22jsAqu+i3S/K2+o4 NXQg== X-Gm-Message-State: AA+aEWbqj0xNsbslHhFbtv16spoPy2UvEvQdLhzL1tLWjelTVVRrIskU v77hnvYOxUeQAGA5f8NOVJbPryMf X-Google-Smtp-Source: AFSGD/VjfXyggQ7RZc+Z5/fHds80yssDhbhWddJEm4VQBh7gOL3Wg64aMSeccyYS0zhJeTzyZ3YPrw== X-Received: by 2002:aca:3b83:: with SMTP id i125mr35912903oia.53.1546619707548; Fri, 04 Jan 2019 08:35:07 -0800 (PST) Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id j5sm57771903otc.54.2019.01.04.08.35.06 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 04 Jan 2019 08:35:06 -0800 (PST) User-agent: mu4e 1.1.0; emacs 27.0.50 From: Alex Branham Date: Fri, 04 Jan 2019 10:35:05 -0600 Message-ID: <87d0pcfkjq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::241 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi - This patch inhibits read-only properties during comint-interrupt-subjob. I ran across this while using ESS and (setq comint-prompt-read-only t). There's a little more info (including a reproducible example) on ESS's bugtracker.[1] Thanks, Alex From=208e3885c5b9747987cacd3b17b9de29975e7691e3 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Fri, 4 Jan 2019 10:28:09 -0600 Subject: [PATCH] * lisp/comint.el (comint-interrupt-subjob): Inhibit read o= nly Otherwise with comint-prompt-read-only set to t users can be incapable of interrupting running busy processes. See ESS's issue tracker for details: https://github.com/emacs-ess/ESS/issues/792 =2D-- lisp/comint.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/comint.el b/lisp/comint.el index 0a6aff2e73..2ed65c1c1c 100644 =2D-- a/lisp/comint.el +++ b/lisp/comint.el @@ -2500,8 +2500,9 @@ comint-clear-buffer (defun comint-interrupt-subjob () "Interrupt the current subjob." (interactive) =2D (comint-skip-input) =2D (interrupt-process nil comint-ptyp) + (let ((inhibit-read-only t)) + (comint-skip-input) + (interrupt-process nil comint-ptyp)) ;; (process-send-string nil "\n") ) =2D- 2.19.2 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-lisp-comint.el-comint-interrupt-subjob-Inhibit-read-.patch Content-Transfer-Encoding: quoted-printable From=208e3885c5b9747987cacd3b17b9de29975e7691e3 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Fri, 4 Jan 2019 10:28:09 -0600 Subject: [PATCH] * lisp/comint.el (comint-interrupt-subjob): Inhibit read o= nly Otherwise with comint-prompt-read-only set to t users can be incapable of interrupting running busy processes. See ESS's issue tracker for details: https://github.com/emacs-ess/ESS/issues/792 =2D-- lisp/comint.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/comint.el b/lisp/comint.el index 0a6aff2e73..2ed65c1c1c 100644 =2D-- a/lisp/comint.el +++ b/lisp/comint.el @@ -2500,8 +2500,9 @@ comint-clear-buffer (defun comint-interrupt-subjob () "Interrupt the current subjob." (interactive) =2D (comint-skip-input) =2D (interrupt-process nil comint-ptyp) + (let ((inhibit-read-only t)) + (comint-skip-input) + (interrupt-process nil comint-ptyp)) ;; (process-send-string nil "\n") ) =20 =2D-=20 2.19.2 --=-=-= Content-Type: text/plain Footnotes: [1] https://github.com/emacs-ess/ESS/issues/792 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEeEJ4XAMgliXNXicpHkInolPpmscFAlwvizkACgkQHkInolPp msdsxQgAhDOpfHbPa+4kR9JgPDvPHoR7mI8hLVFZ5Xd3hij6UJ1mCCUWAsaJxGJa Kg7J5mt7/xMfG568sDUpK7Bsg42Kf3ZpsjLVXJMWsnXwJU02l29b2/eWE/7eFa+2 ITK6ZstTguvYNFU3p9tJHBvT4zBbconGAgIiU6cNmo5KCz/Hsu7hz5ca16+nmDLu lLd7XZihyZ+PbcQmYBk4uaaP1arh0KOM56JyCPHRvtG5rZck6wbSy4DsbIzc0lIG Q2oxX6h8owYsle6qYe/htdAUqr6Xo0ocsFXLyg8qz9x502mhU5R7ejDOqZVITljB MQ382KhfOAAOhza1ud7A8qoBfjOZkw== =CFeP -----END PGP SIGNATURE----- --==-=-=-- From unknown Fri Aug 15 20:54:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Feb 2019 16:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33975 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 33975@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.155076676720565 (code B ref -1); Thu, 21 Feb 2019 16:33:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Feb 2019 16:32:47 +0000 Received: from localhost ([127.0.0.1]:59773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwrHD-0005Lc-4J for submit@debbugs.gnu.org; Thu, 21 Feb 2019 11:32:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwrHC-0005LQ-1s for submit@debbugs.gnu.org; Thu, 21 Feb 2019 11:32:46 -0500 Received: from lists.gnu.org ([209.51.188.17]:55303) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gwrH6-0004No-Qa for submit@debbugs.gnu.org; Thu, 21 Feb 2019 11:32:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwrH5-0001Of-8h for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2019 11:32:40 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwrH4-0004JK-5P for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2019 11:32:39 -0500 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]:39530) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gwrH3-0004AT-Uo for bug-gnu-emacs@gnu.org; Thu, 21 Feb 2019 11:32:38 -0500 Received: by mail-oi1-x243.google.com with SMTP id b4so1881642oif.6 for ; Thu, 21 Feb 2019 08:32:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:subject:in-reply-to:date:message-id :mime-version; bh=zolwCdh9kXkOMMg8gsZDCLzBhVWUMIwp6U9u11PbFiU=; b=JCgO3gxE8kJ/L/gbYPA6XoP0fThSxZ+5bVX46dYBWXfcX9niERuI48oIHwyhsTcHHc wA6ivtkqSkofm00lVTI1qxT4WQY9JDLRi+Vb4OSaIS7XemHI73mqEvV9tyWgkQK25g4z bjljUVZXSpNij8fVmT0fE7vB9/3J20FbdHqPX0vaXK5cxXemadgLKsoJtKIOwoLtmKtQ VkWaeq9O+NmgbvQD9uX5CCdBl03PE68t/9y4eRRcccmrkZPYQKaHzQFw8aI9B1u+9bJM bhQDXYWXgRGBEsf7wQzUo+/SkZL0Ug8Svg3ZteicHQwbNqWiiKvM7xbhZxwY8YFbwfDA 46BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:subject :in-reply-to:date:message-id:mime-version; bh=zolwCdh9kXkOMMg8gsZDCLzBhVWUMIwp6U9u11PbFiU=; b=KcvUnvcruiBNnLERdZ8JjLfjQ4Z0ah0IbXBh6Opfzr8B4dBF0djYqYKCF8sm7YIFCg W/CdwEcRZDLN1PrQfNK3bFjRwer6eEjjPlMXxu5gKegjTd6B3VnPtMtW1FSUOFhyYezU BYUUnq+e8+gAUdK6D3rBzqrD6o1aBb0VLRY6N7nWSMj7KYZVQWekSqwRN+6JK+Vnt+hV xJ1Hh2AAzB5SMdraD8m2docCsh8l2bRVnGPxNu2mWyzlPuNPkmHCmkLWYDbB3ZCM5Z2e G2pzNzXe1M4Bd+xJ4d7hB7AtA+SomO1oeNGxYAhckwj1simFwU3AVlN26wsvOxabQGMS F3Zw== X-Gm-Message-State: AHQUAuZrfk8dHjTQzsNxG9a19OgMyB2NK9EkRUK0WisOrjGnHjhSFjyP BKZl5+a3zxp/uhTO6Sl4Pw58VtRm X-Google-Smtp-Source: AHgI3Iaf5aCwH3BN1aDGMzHqwhn7EB4XDBDAGixUlNDcbzoh+uvNlWkJZpRpdRxAmWApq2rtmkLKPw== X-Received: by 2002:aca:de84:: with SMTP id v126mr10258576oig.5.1550766738429; Thu, 21 Feb 2019 08:32:18 -0800 (PST) Received: from mars (nat-128-62-60-177.public.utexas.edu. [128.62.60.177]) by smtp.gmail.com with ESMTPSA id b63sm11034418oih.24.2019.02.21.08.32.17 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Feb 2019 08:32:17 -0800 (PST) References: <87d0pcfkjq.fsf@gmail.com> User-agent: mu4e 1.1.0; emacs 27.0.50 From: Alex Branham In-reply-to: <87d0pcfkjq.fsf@gmail.com> Date: Thu, 21 Feb 2019 10:32:16 -0600 Message-ID: <87mumpgl0v.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::243 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi all - Is this patch OK for Emacs? Or should we figure it out downstream? Thanks, Alex On Fri 04 Jan 2019 at 10:35, Alex Branham wrote: > Hi - > > This patch inhibits read-only properties during comint-interrupt-subjob. > I ran across this while using ESS and (setq comint-prompt-read-only t). > There's a little more info (including a reproducible example) on ESS's > bugtracker.[1] > > Thanks, > Alex > > From 8e3885c5b9747987cacd3b17b9de29975e7691e3 Mon Sep 17 00:00:00 2001 > From: Alex Branham > Date: Fri, 4 Jan 2019 10:28:09 -0600 > Subject: [PATCH] * lisp/comint.el (comint-interrupt-subjob): Inhibit read only > > Otherwise with comint-prompt-read-only set to t users can be incapable > of interrupting running busy processes. See ESS's issue tracker for > details: https://github.com/emacs-ess/ESS/issues/792 > --- > lisp/comint.el | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/lisp/comint.el b/lisp/comint.el > index 0a6aff2e73..2ed65c1c1c 100644 > --- a/lisp/comint.el > +++ b/lisp/comint.el > @@ -2500,8 +2500,9 @@ comint-clear-buffer > (defun comint-interrupt-subjob () > "Interrupt the current subjob." > (interactive) > - (comint-skip-input) > - (interrupt-process nil comint-ptyp) > + (let ((inhibit-read-only t)) > + (comint-skip-input) > + (interrupt-process nil comint-ptyp)) > ;; (process-send-string nil "\n") > ) > > -- > 2.19.2 > > > From 8e3885c5b9747987cacd3b17b9de29975e7691e3 Mon Sep 17 00:00:00 2001 > From: Alex Branham > Date: Fri, 4 Jan 2019 10:28:09 -0600 > Subject: [PATCH] * lisp/comint.el (comint-interrupt-subjob): Inhibit read only > > Otherwise with comint-prompt-read-only set to t users can be incapable > of interrupting running busy processes. See ESS's issue tracker for > details: https://github.com/emacs-ess/ESS/issues/792 > --- > lisp/comint.el | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/lisp/comint.el b/lisp/comint.el > index 0a6aff2e73..2ed65c1c1c 100644 > --- a/lisp/comint.el > +++ b/lisp/comint.el > @@ -2500,8 +2500,9 @@ comint-clear-buffer > (defun comint-interrupt-subjob () > "Interrupt the current subjob." > (interactive) > - (comint-skip-input) > - (interrupt-process nil comint-ptyp) > + (let ((inhibit-read-only t)) > + (comint-skip-input) > + (interrupt-process nil comint-ptyp)) > ;; (process-send-string nil "\n") > ) From unknown Fri Aug 15 20:54:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Feb 2019 08:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33975 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Alex Branham Cc: 33975@debbugs.gnu.org Received: via spool by 33975-submit@debbugs.gnu.org id=B33975.155082463013407 (code B ref 33975); Fri, 22 Feb 2019 08:38:01 +0000 Received: (at 33975) by debbugs.gnu.org; 22 Feb 2019 08:37:10 +0000 Received: from localhost ([127.0.0.1]:47579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gx6KT-0003UB-Hx for submit@debbugs.gnu.org; Fri, 22 Feb 2019 03:37:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42305) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gx6KR-0003Tw-Vm for 33975@debbugs.gnu.org; Fri, 22 Feb 2019 03:37:08 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41096) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gx6KK-0007C2-Ts; Fri, 22 Feb 2019 03:37:02 -0500 Received: from [176.228.60.248] (port=4993 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gx6KJ-0001dP-8n; Fri, 22 Feb 2019 03:37:00 -0500 Date: Fri, 22 Feb 2019 10:37:00 +0200 Message-Id: <83bm34fccz.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87mumpgl0v.fsf@gmail.com> (message from Alex Branham on Thu, 21 Feb 2019 10:32:16 -0600) References: <87d0pcfkjq.fsf@gmail.com> <87mumpgl0v.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Alex Branham > Date: Thu, 21 Feb 2019 10:32:16 -0600 > > Is this patch OK for Emacs? Or should we figure it out downstream? Can you explain how having comint-prompt-read-only interferes with interrupt-process in this case? I don't think I understand the connection, and neither this bug report nor the ESS issue do, AFAICT. Thanks. From unknown Fri Aug 15 20:54:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Feb 2019 21:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33975 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 33975@debbugs.gnu.org Received: via spool by 33975-submit@debbugs.gnu.org id=B33975.155087077128723 (code B ref 33975); Fri, 22 Feb 2019 21:27:01 +0000 Received: (at 33975) by debbugs.gnu.org; 22 Feb 2019 21:26:11 +0000 Received: from localhost ([127.0.0.1]:48607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxIKh-0007TB-AO for submit@debbugs.gnu.org; Fri, 22 Feb 2019 16:26:11 -0500 Received: from mail-oi1-f176.google.com ([209.85.167.176]:38397) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxIKf-0007Sz-4r for 33975@debbugs.gnu.org; Fri, 22 Feb 2019 16:26:09 -0500 Received: by mail-oi1-f176.google.com with SMTP id q81so2865165oic.5 for <33975@debbugs.gnu.org>; Fri, 22 Feb 2019 13:26:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=niJHwQDLtoSsxZT9idLA7gSjfMqal4BwdcQBYGrpyfQ=; b=tumzNqPpRZUv3WVoWsRoGO5ofEbu41UNH/BBdZfp77C9GGcQnVZQ2FR82t3Urt6IvV VNFhl728etoSLKJKmjKkN/L1utyxbhi1vhyrrQunxyuRC7HXgwR/bc+wMnO/O293p3PU cl3BcSn7DSEvE4fCCRb13Lu8AVxOl5H2m18ioRBLMLM0xiQxRLr2EJImIu6hMpdyqz+o aJPGZZOaSwkrQdQimd8SWjEza+/KAsRf57+r3yKaoZOl4pzY/Hf2n6y8zm6GA8IC30v8 wjhpLx+/uUWSMikvt5WunwUvRvZTUks/yKaka6bzMqVVJ4qc7mLvSIZRCWdr4I4/C4mC X0uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=niJHwQDLtoSsxZT9idLA7gSjfMqal4BwdcQBYGrpyfQ=; b=intkXuFwjHY1V/61OHn8xb0nGa7pK2epc3Pzabo8qh5PIk0PfIP/bPQ4KHILvRGwdn jof4Fqpcyjl4PP6zhUt9X4jqQ1deHWB0YKFTqZtxV/xOE42sml0TH4THtE2QSFfdldye Z+GsmPsH1clFuSvDZ1SLRRXyWqIuXNn7ZUQOXFD5vNz76G/j4OdBvkAaQBKcB0Dtgeu+ zCmEJYHwb/DshOl7/wylUQtFX1fBPQaZf3ybFN1mF3Zz9dgKOhWNeRRbYcg3C+Xduzsr uR8KoPOsXTfkH+4Y9f1qE1Sza9vTWWb4d5sPv9XqOuCQjkR895HGCIYXOupq/RpHzCHn wI3A== X-Gm-Message-State: AHQUAua4drkMvyIkI37cpUfP/Cd49X7RamRwMUOxK9Yzz9amgA2T4ylM hpRnsp3gJy3Gqrz3umHEBViF4T5Z X-Google-Smtp-Source: AHgI3Ia+p5NbUuEZY63qmjlfkPidXwYa30HyDp/RTEtDm1SuTZ0mcOHvPbsLLaeq7zZXeFeLTTXrXg== X-Received: by 2002:aca:5114:: with SMTP id f20mr3818750oib.152.1550870762916; Fri, 22 Feb 2019 13:26:02 -0800 (PST) Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id j21sm1008310otr.28.2019.02.22.13.26.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Feb 2019 13:26:01 -0800 (PST) References: <87d0pcfkjq.fsf@gmail.com> <87mumpgl0v.fsf@gmail.com> <83bm34fccz.fsf@gnu.org> User-agent: mu4e 1.1.0; emacs 27.0.50 From: Alex Branham In-reply-to: <83bm34fccz.fsf@gnu.org> Date: Fri, 22 Feb 2019 15:26:00 -0600 Message-ID: <87mumncy6v.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain On Fri 22 Feb 2019 at 02:37, Eli Zaretskii wrote: >> From: Alex Branham >> Date: Thu, 21 Feb 2019 10:32:16 -0600 >> >> Is this patch OK for Emacs? Or should we figure it out downstream? > > Can you explain how having comint-prompt-read-only interferes with > interrupt-process in this case? I don't think I understand the > connection, and neither this bug report nor the ESS issue do, AFAICT. Sure thing. `comint-interrupt-subjob' calls `comint-skip-input', which tries to do this: (insert " " (key-description (this-command-keys))) Which fails if the text at point is read only. Thanks, Alex --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEeEJ4XAMgliXNXicpHkInolPpmscFAlxwaOgACgkQHkInolPp msfUgAf/VP7BUaMD9u/5VDz4IuMPJeAAQK8Ib/tn3nAA0AXIVHulG40BrnK9tSNt wVgivJfp6DkXbYmr+11SU5uEVzTa0FCFlYpCpH8XcfKKgUSEXLoDhEBY9RlRTIdR xIlQ2HLc1lnuMD0M1nrZxV9jAkgrI/vhj3dmeGDUEksn5RBPJkHuxZGov6U7GIKl zx98T6tXqU3EcefUA5eCKNJG9ssJRklzuaiSnOGlLqCVCcmVLJM37wSBOdPVdNOf H7WSWqk3FuUmgW/ewD/r27EBEMBmJbO/xz+lS8aIj0HTOvX4Rx2n51S8iru8grqX GcU/R+jc/4ePt4xFyF/AI81lsNYmiw== =/7YM -----END PGP SIGNATURE----- --=-=-=-- From unknown Fri Aug 15 20:54:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Feb 2019 08:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33975 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Alex Branham Cc: 33975@debbugs.gnu.org Received: via spool by 33975-submit@debbugs.gnu.org id=B33975.155091189618387 (code B ref 33975); Sat, 23 Feb 2019 08:52:01 +0000 Received: (at 33975) by debbugs.gnu.org; 23 Feb 2019 08:51:36 +0000 Received: from localhost ([127.0.0.1]:48832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxT1z-0004mV-QU for submit@debbugs.gnu.org; Sat, 23 Feb 2019 03:51:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxT1y-0004mJ-F6 for 33975@debbugs.gnu.org; Sat, 23 Feb 2019 03:51:35 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47401) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxT1p-0007cg-Eo; Sat, 23 Feb 2019 03:51:25 -0500 Received: from [176.228.60.248] (port=3094 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gxT1p-0002zk-2g; Sat, 23 Feb 2019 03:51:25 -0500 Date: Sat, 23 Feb 2019 10:51:28 +0200 Message-Id: <83zhqmq44v.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87mumncy6v.fsf@gmail.com> (message from Alex Branham on Fri, 22 Feb 2019 15:26:00 -0600) References: <87d0pcfkjq.fsf@gmail.com> <87mumpgl0v.fsf@gmail.com> <83bm34fccz.fsf@gnu.org> <87mumncy6v.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Alex Branham > Cc: 33975@debbugs.gnu.org > Date: Fri, 22 Feb 2019 15:26:00 -0600 > > > Can you explain how having comint-prompt-read-only interferes with > > interrupt-process in this case? I don't think I understand the > > connection, and neither this bug report nor the ESS issue do, AFAICT. > > Sure thing. `comint-interrupt-subjob' calls `comint-skip-input', which > tries to do this: > > (insert " " (key-description (this-command-keys))) > > Which fails if the text at point is read only. Then shouldn't the change be inside comint-skip-input instead? I mean, the same problem will happen also in all other callers of comint-skip-input, no? (I'm not sure I understand why that function inserts the description of this-command-keys -- is that to insert "C-c C-c" into the buffer? This is not in the doc string, perhaps we should add that.) Thanks. From unknown Fri Aug 15 20:54:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Feb 2019 13:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33975 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 33975@debbugs.gnu.org Received: via spool by 33975-submit@debbugs.gnu.org id=B33975.155092901320102 (code B ref 33975); Sat, 23 Feb 2019 13:37:01 +0000 Received: (at 33975) by debbugs.gnu.org; 23 Feb 2019 13:36:53 +0000 Received: from localhost ([127.0.0.1]:48981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxXU5-0005EA-2L for submit@debbugs.gnu.org; Sat, 23 Feb 2019 08:36:53 -0500 Received: from mail-ot1-f42.google.com ([209.85.210.42]:40927) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxXU3-0005Dx-D7 for 33975@debbugs.gnu.org; Sat, 23 Feb 2019 08:36:52 -0500 Received: by mail-ot1-f42.google.com with SMTP id v20so4256180otk.7 for <33975@debbugs.gnu.org>; Sat, 23 Feb 2019 05:36:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=j50s+zZa2ZCC5pjlEVAqsmZZRfjgn/pU7ko5xMQYVZc=; b=RLIqejMRh0hG4BksJaRfHYoV5bKcnZHprLg8XOUMZsxPMud5nADLa+tZWOzwq3svAD g8R7f39Gm5jEr93PoT3DZo3hGibvhG0ulmJcwUTgCGBScr68hb1wiQbFpanM/dvUjuWS 7+hksmvo6xTBaOa0jDSsuh6/rcdNjY094u+0Wz/CorXWvSd9BENuG2qG9Wd4+/JNqvG7 WZA4aWAJHHjANT6/gckSDbCKaKH/AxZpWaBLG+iXvIbLFviDQd76o4iZzHAU0ngIsf4T zIvIZNcODfZm2q4sLY97Muob3jP0GwDdqAtm93kpI3vdHhsdGeANwYvH6gHmO09kDRoF 6e1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=j50s+zZa2ZCC5pjlEVAqsmZZRfjgn/pU7ko5xMQYVZc=; b=mgInJLJpmRYPvDOx3GqblGB4q46quXvX5o2kHPVwV4NwAjHFvi9Wc/EI3Y4SB9AFHk Nl1wOnqQL99npe72LomEfljOBbn02LjphEmk0oOPNDqQ6MU8lmptxDbh4L8fpn4w9yDe 6mupXt+xKzGXSJhDVXzpsnY3Y7T4x54E5xHZanJBz8+XiXse+okQR2Tj2OoMGYNr18Bt DjrOiBTT6TqcEOjRhDyaXSogX9WZ/Y1+50LCi2nS6mBGLreMHyPkocmA+adoz43H0S2l aE42W0tmeBVVOGHAGilb8aRsoNXRo3lAChPFiAkxZYwIIFWxe20ugOKTLPAh5eW0zeHV EJkA== X-Gm-Message-State: AHQUAua5CX/O4x783sbBXWdcxLqqVe3c45CAulJlqr0QihlWMU6zhOyG 0VBV1cbFohISfN2MCe0Kga8fwnxA X-Google-Smtp-Source: AHgI3IZ2KmlzVrIGacS2mWn0E9D0JBmw5msaXjGm1Cmks4MWb10oRKQiTxuzlV9NBPs3cI9e9Gn7Ag== X-Received: by 2002:a9d:6d94:: with SMTP id x20mr5762115otp.78.1550929005388; Sat, 23 Feb 2019 05:36:45 -0800 (PST) Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id m26sm1695420otl.32.2019.02.23.05.36.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 23 Feb 2019 05:36:44 -0800 (PST) References: <87d0pcfkjq.fsf@gmail.com> <87mumpgl0v.fsf@gmail.com> <83bm34fccz.fsf@gnu.org> <87mumncy6v.fsf@gmail.com> <83zhqmq44v.fsf@gnu.org> User-agent: mu4e 1.1.0; emacs 27.0.50 From: Alex Branham In-reply-to: <83zhqmq44v.fsf@gnu.org> Date: Sat, 23 Feb 2019 07:36:43 -0600 Message-ID: <87va1ask2c.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain On Sat 23 Feb 2019 at 02:51, Eli Zaretskii wrote: > Then shouldn't the change be inside comint-skip-input instead? I > mean, the same problem will happen also in all other callers of > comint-skip-input, no? Probably, yes. Changed in the attached patch. > (I'm not sure I understand why that function inserts the description > of this-command-keys -- is that to insert "C-c C-c" into the buffer? > This is not in the doc string, perhaps we should add that.) The attached patch adds it. WDYT? >From 0eba90f40c4ffdd020b86ffa2e19815c0edfe2f0 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Sat, 23 Feb 2019 07:35:01 -0600 Subject: [PATCH] * lisp/comint.el (comint-skip-input): Set inhibit-read-only to t Bug#33975 --- lisp/comint.el | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lisp/comint.el b/lisp/comint.el index 0a6aff2e73..ab6297a709 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -2536,13 +2536,16 @@ Useful if you accidentally suspend the top-level process." (defun comint-skip-input () "Skip all pending input, from last stuff output by interpreter to point. -This means mark it as if it had been sent as input, without sending it." +This means mark it as if it had been sent as input, without +sending it. The command keys used to trigger this command are +inserted into the buffer." (let ((comint-input-sender 'ignore) (comint-input-filter-functions nil)) (comint-send-input t t)) (end-of-line) (let ((pos (point)) - (marker (process-mark (get-buffer-process (current-buffer))))) + (marker (process-mark (get-buffer-process (current-buffer)))) + (inhibit-read-only t)) (insert " " (key-description (this-command-keys))) (if (= marker pos) (set-marker marker (point))))) -- 2.19.2 --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-lisp-comint.el-comint-skip-input-Set-inhibit-read-on.patch >From 0eba90f40c4ffdd020b86ffa2e19815c0edfe2f0 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Sat, 23 Feb 2019 07:35:01 -0600 Subject: [PATCH] * lisp/comint.el (comint-skip-input): Set inhibit-read-only to t Bug#33975 --- lisp/comint.el | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lisp/comint.el b/lisp/comint.el index 0a6aff2e73..ab6297a709 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -2536,13 +2536,16 @@ Useful if you accidentally suspend the top-level process." (defun comint-skip-input () "Skip all pending input, from last stuff output by interpreter to point. -This means mark it as if it had been sent as input, without sending it." +This means mark it as if it had been sent as input, without +sending it. The command keys used to trigger this command are +inserted into the buffer." (let ((comint-input-sender 'ignore) (comint-input-filter-functions nil)) (comint-send-input t t)) (end-of-line) (let ((pos (point)) - (marker (process-mark (get-buffer-process (current-buffer))))) + (marker (process-mark (get-buffer-process (current-buffer)))) + (inhibit-read-only t)) (insert " " (key-description (this-command-keys))) (if (= marker pos) (set-marker marker (point))))) -- 2.19.2 --=-=-=-- From unknown Fri Aug 15 20:54:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Feb 2019 17:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33975 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Alex Branham Cc: 33975@debbugs.gnu.org Received: via spool by 33975-submit@debbugs.gnu.org id=B33975.15509413116881 (code B ref 33975); Sat, 23 Feb 2019 17:02:02 +0000 Received: (at 33975) by debbugs.gnu.org; 23 Feb 2019 17:01:51 +0000 Received: from localhost ([127.0.0.1]:49578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxagR-0001mv-Jk for submit@debbugs.gnu.org; Sat, 23 Feb 2019 12:01:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxagP-0001mj-Ir for 33975@debbugs.gnu.org; Sat, 23 Feb 2019 12:01:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52229) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxagK-0002pX-6o; Sat, 23 Feb 2019 12:01:44 -0500 Received: from [176.228.60.248] (port=2208 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gxagJ-0002aB-GY; Sat, 23 Feb 2019 12:01:44 -0500 Date: Sat, 23 Feb 2019 19:01:46 +0200 Message-Id: <83h8cuphfp.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87va1ask2c.fsf@gmail.com> (message from Alex Branham on Sat, 23 Feb 2019 07:36:43 -0600) References: <87d0pcfkjq.fsf@gmail.com> <87mumpgl0v.fsf@gmail.com> <83bm34fccz.fsf@gnu.org> <87mumncy6v.fsf@gmail.com> <83zhqmq44v.fsf@gnu.org> <87va1ask2c.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Alex Branham > Cc: 33975@debbugs.gnu.org > Date: Sat, 23 Feb 2019 07:36:43 -0600 > > > Then shouldn't the change be inside comint-skip-input instead? I > > mean, the same problem will happen also in all other callers of > > comint-skip-input, no? > > Probably, yes. Changed in the attached patch. > > > (I'm not sure I understand why that function inserts the description > > of this-command-keys -- is that to insert "C-c C-c" into the buffer? > > This is not in the doc string, perhaps we should add that.) > > The attached patch adds it. WDYT? > > (defun comint-skip-input () > "Skip all pending input, from last stuff output by interpreter to point. > -This means mark it as if it had been sent as input, without sending it." > +This means mark it as if it had been sent as input, without > +sending it. The command keys used to trigger this command are > +inserted into the buffer." "this command" is inaccurate here, as comint-skip-input is not a command. I'd say "the command which called this function" instead. Other than that, LGTM. Thanks. From unknown Fri Aug 15 20:54:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Feb 2019 14:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33975 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 33975@debbugs.gnu.org Received: via spool by 33975-submit@debbugs.gnu.org id=B33975.15510196583975 (code B ref 33975); Sun, 24 Feb 2019 14:48:01 +0000 Received: (at 33975) by debbugs.gnu.org; 24 Feb 2019 14:47:38 +0000 Received: from localhost ([127.0.0.1]:49909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxv46-000123-A4 for submit@debbugs.gnu.org; Sun, 24 Feb 2019 09:47:38 -0500 Received: from mail-ot1-f68.google.com ([209.85.210.68]:34946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxv44-00011p-Ha for 33975@debbugs.gnu.org; Sun, 24 Feb 2019 09:47:36 -0500 Received: by mail-ot1-f68.google.com with SMTP id z19so5783257otm.2 for <33975@debbugs.gnu.org>; Sun, 24 Feb 2019 06:47:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=a34PgE+RuiouJJBYnhGPzMD08R+n73QL5milURmTtAA=; b=Z8DQ87TDWkAYPkagDsQcFG80Aitw7R87PQVhcCKCH8fdpUhAmsf5xVYhwacC7adUfQ x6a2USQXoVKJg85naktiITXhRpBaPNCgpXKFyjM27qqK4IOQNenY0pbG0AgNj6V6oFBE Y6L+BVyzvw77EtruAb02Lrv1TR7l7OVRDN559FWFiJ9D+iuHBMI5GUImHOYEenz930Xm Zhjwjn2luDQXQOswymg6X5cFkwhdLtPuwi58duL+PZYw0YsstC6xXnluQWUEUZBA3X/n MJdY+BgTozwKxzT9M4fSyf91xZEjO4Krj8pZiNAYL0BmaVFrv6lGM5A2X8BUed9QN9je Ykkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=a34PgE+RuiouJJBYnhGPzMD08R+n73QL5milURmTtAA=; b=O7eIgkQe7VCml6CzArGtTZxhK/lprXW+Y4MAv/foLgUlPRdgzXbK65899nnkd7PsOO b1/hlCn2RM+q2rwrcrFTUyX5wYhj6kWFSkcRkXDF3cm7k9SKah4puhtcoVtLEDaLIKtJ 7rfUUj7emR8mGkHqHfse3RTILl4C9UUjzEN8VSzCzgxsD8VTH2cQ3IxguxbGM7URoyXo jwCIkdn3o4zaZEI2Bk8B9fLVRUv4R+I+jv7Ji6ldr2tic/22AA5S/tEjtxeud95WgRYV pbIVtpCNDVckpNrDFVRWwJ1riaq/1NqVle5H/dkWZYzzMKi/SjEdueID3V56rL6hUhMl EnfA== X-Gm-Message-State: AHQUAubt9bKgcyp5EdnKM49mlbrnNxrSWJmeozIsjD2xiC/Kp13XvxcR f/HhJV4jbHO6QP8CYPihCGe+soFW X-Google-Smtp-Source: AHgI3IaAn5ggTiuDZvGpbnZcU9XrFtS65h2XQ+NPC4JdzbNYDj3EyKher32R2pD08P7XmJJuIjojpw== X-Received: by 2002:a9d:2944:: with SMTP id d62mr1574065otb.193.1551019649701; Sun, 24 Feb 2019 06:47:29 -0800 (PST) Received: from mars (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id a4sm3121469otc.21.2019.02.24.06.47.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 Feb 2019 06:47:28 -0800 (PST) References: <87d0pcfkjq.fsf@gmail.com> <87mumpgl0v.fsf@gmail.com> <83bm34fccz.fsf@gnu.org> <87mumncy6v.fsf@gmail.com> <83zhqmq44v.fsf@gnu.org> <87va1ask2c.fsf@gmail.com> <83h8cuphfp.fsf@gnu.org> User-agent: mu4e 1.1.0; emacs 27.0.50 From: Alex Branham In-reply-to: <83h8cuphfp.fsf@gnu.org> Date: Sun, 24 Feb 2019 08:47:25 -0600 Message-ID: <87lg256y6a.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain On Sat 23 Feb 2019 at 11:01, Eli Zaretskii wrote: >> (defun comint-skip-input () >> "Skip all pending input, from last stuff output by interpreter to point. >> -This means mark it as if it had been sent as input, without sending it." >> +This means mark it as if it had been sent as input, without >> +sending it. The command keys used to trigger this command are >> +inserted into the buffer." > > "this command" is inaccurate here, as comint-skip-input is not a > command. I'd say "the command which called this function" instead. > > Other than that, LGTM. Thanks. Great, thanks I'll make that change and push to master later today or tomorrow, unless I hear back otherwise. Alex --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEeEJ4XAMgliXNXicpHkInolPpmscFAlxyrn0ACgkQHkInolPp msd+AggAiWnG+7i/E8N3/u+F5UQXXu+BSiz2THrGTQf0ztzMs6AZlFutC+exZAEY oL5GkV9azFmF06FhQtCwM06gyDU4MhK56nKX7MiU9N6lQsPFVw9kLPXfszBBQ6eh 6DDualGHRZOsHy4v6V7wgg2pPd6wJXuqcRT+imgEGhKXm78OgWOoRddNL6HzF4bq bnqQ+t1i0uK+hj+gCf5XRIJp5xDqr2QZHCMZnbzvWkmXAyWXF2I09qt4iOEw5MnO DEG3WTVoezADMozro2cutLCFWHeNtvKkOJ/+q/ob1bg5hAmpGLeaMfJ2HYMZGWrf wkoK3nA/SED9YXSh9an2iQCXrJNBrQ== =X6ub -----END PGP SIGNATURE----- --=-=-=-- From unknown Fri Aug 15 20:54:38 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Alex Branham Subject: bug#33975: closed (Re: bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob) Message-ID: References: <874l8sbrjn.fsf@gmail.com> <87d0pcfkjq.fsf@gmail.com> X-Gnu-PR-Message: they-closed 33975 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 33975@debbugs.gnu.org Date: Mon, 25 Feb 2019 01:12:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1551057122-29664-1" This is a multi-part message in MIME format... ------------=_1551057122-29664-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 33975@debbugs.gnu.org. --=20 33975: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D33975 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1551057122-29664-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 33975-done) by debbugs.gnu.org; 25 Feb 2019 01:11:51 +0000 Received: from localhost ([127.0.0.1]:50677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gy4oB-0007i6-1o for submit@debbugs.gnu.org; Sun, 24 Feb 2019 20:11:51 -0500 Received: from mail-qt1-f171.google.com ([209.85.160.171]:41162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gy4o9-0007hu-Vi for 33975-done@debbugs.gnu.org; Sun, 24 Feb 2019 20:11:50 -0500 Received: by mail-qt1-f171.google.com with SMTP id v10so8715117qtp.8 for <33975-done@debbugs.gnu.org>; Sun, 24 Feb 2019 17:11:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=VuxNTzxH4Vy5kafctpylupMTDk4N40C90/4bT/L5OSQ=; b=ZoJ6LlSDrS3OKb4bd7z7Qa/eaEjsDzmzBnyLUQhR+/Bog+stxFoZJW6LCaExEgZ1Jx BYfPuDZOj1Dx9hvHn8WBa42yen2i5k1zfhu1ualpVr0C4RoSJj1WEWcwApgKOwlx7Ug4 w0olonbh4RZYpcTFiaLwULAFVtjryv0aH728bgO4l91ugu58a6NpJoRlWbOMKDcu2IOc xhBm/YXujMhlQfoQUKxtEcQEpESxTOkD4Ih0KHDUW4PtoC3uhY11gbvKhZlhbOnA1YdO vsO9KNp50XzeBjWyXor0BcpzNZ7FmFoO8KdvpIS9NsedAlnPgUkCvbmuxz0Ux4NRBph7 UTXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=VuxNTzxH4Vy5kafctpylupMTDk4N40C90/4bT/L5OSQ=; b=XWvhNAABGXiqxXkyehFc5MEgayrim7divzFcvu210bkakaVOgKFLiau/WDDsBlVEgu 64a5HHktqc7nma5wR6cvOiqJvI+JbZRQogDIHg1WFJiFPxfWucN7KOXAYV/Ow5Fw7trG 9Hn2skBSUrtjpcOb+HrrSKFqycwTjeGlbkwt9FE3vSZ5Lvd1ia1eHYNsjdRzba8ZSkL6 mLXZ0htXlEiUUnDldplZnY7stIjhDKKv3oyrH4L4LPA4Tf9xbOhCyrLxWCgsWOGNZsfR l6cFJKm5iiV4JJicfhptAwiEU2VB4ty7+ORWYpEsbN/4BPz16T9PljM0HujCZK3L45s/ ah0Q== X-Gm-Message-State: AHQUAuZSkH89mSArHxbs2592fW2QJr8XnYQ77KUcu6uUsrBJIuWUqB8E ZaxspsdNBGg8QspANRSKQuV7uO48 X-Google-Smtp-Source: AHgI3IY31OmluL/69ZY0wJAcnSE2OSeJUBhhc3BNolv7xB7cFQbkAyjUKprN/B/VVlWzHR6OB264WQ== X-Received: by 2002:ac8:372b:: with SMTP id o40mr11778768qtb.73.1551057104155; Sun, 24 Feb 2019 17:11:44 -0800 (PST) Received: from mars (wsip-174-64-53-131.dc.dc.cox.net. [174.64.53.131]) by smtp.gmail.com with ESMTPSA id d67sm4478925qkf.76.2019.02.24.17.11.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 Feb 2019 17:11:43 -0800 (PST) References: <87d0pcfkjq.fsf@gmail.com> <87mumpgl0v.fsf@gmail.com> <83bm34fccz.fsf@gnu.org> <87mumncy6v.fsf@gmail.com> <83zhqmq44v.fsf@gnu.org> <87va1ask2c.fsf@gmail.com> <83h8cuphfp.fsf@gnu.org> User-agent: mu4e 1.1.0; emacs 27.0.50 From: Alex Branham To: Eli Zaretskii Subject: Re: bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob In-reply-to: <83h8cuphfp.fsf@gnu.org> Date: Sun, 24 Feb 2019 19:11:40 -0600 Message-ID: <874l8sbrjn.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33975-done Cc: 33975-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain On Sat 23 Feb 2019 at 11:01, Eli Zaretskii wrote: > "this command" is inaccurate here, as comint-skip-input is not a > command. I'd say "the command which called this function" instead. > > Other than that, LGTM. Thanks. Thanks, fixed and pushed to master as 6a3b1aaa066dac28355ca5d09550947250108950 to appear in Emacs 27 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEeEJ4XAMgliXNXicpHkInolPpmscFAlxzQMwACgkQHkInolPp msebKwf6A6RDRhQsilwaJGNqDjPdv9BP475sqOcQyFQHtKDyNo5XNTaB/s02hhcr qsUA0rSdC24ShyRwdds8q0M13aew0LUXryzxTYIsnC6wxwcH3AfpRLUoIz7uE2Vh hL3RG4JL3njJFcqFjclSNamU9qMBFxoJ5DHS9cphfr4sPbFL8E7jCtmu9rRph4rh UHvZhbr+j5cy8rJA3z2ik1xk5qGuAEHI+SCZwzs2jjbqv/olo++ch/3kpzDnt2Z9 0lxcb0yHh5DsKly777sasRkHnoIV6V2xaFj+dp0IYUcx+/Ie6wHlGiJz+1FACQVC OWRJ4V91Rnx8uP5vPudMbE32Sd7qZQ== =EARq -----END PGP SIGNATURE----- --=-=-=-- ------------=_1551057122-29664-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 4 Jan 2019 16:35:16 +0000 Received: from localhost ([127.0.0.1]:47023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfSRI-00038B-Ax for submit@debbugs.gnu.org; Fri, 04 Jan 2019 11:35:16 -0500 Received: from eggsout.gnu.org ([209.51.188.92]:52030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfSRG-000383-Kw for submit@debbugs.gnu.org; Fri, 04 Jan 2019 11:35:15 -0500 Received: from lists.gnu.org ([208.118.235.17]:41756) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gfSRF-0000DB-DN for submit@debbugs.gnu.org; Fri, 04 Jan 2019 11:35:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gfSRE-0004yn-DQ for bug-gnu-emacs@gnu.org; Fri, 04 Jan 2019 11:35:13 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gfSRB-0000BM-4F for bug-gnu-emacs@gnu.org; Fri, 04 Jan 2019 11:35:12 -0500 Received: from mail-oi1-x241.google.com ([2607:f8b0:4864:20::241]:41791) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gfSRA-0000At-TP for bug-gnu-emacs@gnu.org; Fri, 04 Jan 2019 11:35:09 -0500 Received: by mail-oi1-x241.google.com with SMTP id j21so30786231oii.8 for ; Fri, 04 Jan 2019 08:35:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=EYT1AeHS/4tw/JuRybyB3UK8lfNqexKDPNAwZY5MVMQ=; b=hN5bb3UD5u5dtFLqGORYESReX7FjQQtWEBQ9xWSszBWfH97sSmSbF1+oj8JBiYSdZM ZrR9ydlJkeP2AzOaYxltJGaqBrAiXdlu4K8sjhYBod4I1QK6tcgesnaYYXCbybOgl3NZ Nu71GRYB5EhddId9XqbvaR4ZzStl2a4+j0QsHO9xJD1cfC2sYNJToI1Sf9P0TGPUIY3X QFSu7L0T8GE25g44W1XNi4xm4jsUm0rVUw45trp7eIH8Mb/4P809QfaQbgQ/hsavgYJ9 5A5ywcZFv9HKPz2akC4zlhrPQfe/N5GBBPeFc5EfiOhzSTBLA5lIKw2j1i1qzmTqjE3/ aL7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=EYT1AeHS/4tw/JuRybyB3UK8lfNqexKDPNAwZY5MVMQ=; b=h6PhyHyd7VYFtFILDLuIwtcMEgxnBILC2gDv3qUGVJTJ6vGNDTYUb71plOWjI3JzCC lr7FbKvt8FL5oSKqmitSdYaLDrTq0bEvwN4a3VdfcChkuCg6XTymG/AwbMHyXZHN8PAN ny/6nUWito14JcggwzlDbMeBPiVflM0JA4ArxuKyn+9os/klOLQYImu9sh8e2PuLy3Qz 2nRr+h27bqVlVyAv/oX/kOJLjmRFRsHRFj8w4MmuJrpAioLv+6X7OoJq7roygjxgtXvE 9K2aIKgSBK6ZOmPguOfveqfjxusaLKVDojTpPkNZ/gYSGflKZDR22jsAqu+i3S/K2+o4 NXQg== X-Gm-Message-State: AA+aEWbqj0xNsbslHhFbtv16spoPy2UvEvQdLhzL1tLWjelTVVRrIskU v77hnvYOxUeQAGA5f8NOVJbPryMf X-Google-Smtp-Source: AFSGD/VjfXyggQ7RZc+Z5/fHds80yssDhbhWddJEm4VQBh7gOL3Wg64aMSeccyYS0zhJeTzyZ3YPrw== X-Received: by 2002:aca:3b83:: with SMTP id i125mr35912903oia.53.1546619707548; Fri, 04 Jan 2019 08:35:07 -0800 (PST) Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id j5sm57771903otc.54.2019.01.04.08.35.06 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 04 Jan 2019 08:35:06 -0800 (PST) User-agent: mu4e 1.1.0; emacs 27.0.50 From: Alex Branham To: bug-gnu-emacs@gnu.org Subject: [PATCH] inhibit read-only text properties in comint-interrupt-subjob Date: Fri, 04 Jan 2019 10:35:05 -0600 Message-ID: <87d0pcfkjq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::241 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi - This patch inhibits read-only properties during comint-interrupt-subjob. I ran across this while using ESS and (setq comint-prompt-read-only t). There's a little more info (including a reproducible example) on ESS's bugtracker.[1] Thanks, Alex From=208e3885c5b9747987cacd3b17b9de29975e7691e3 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Fri, 4 Jan 2019 10:28:09 -0600 Subject: [PATCH] * lisp/comint.el (comint-interrupt-subjob): Inhibit read o= nly Otherwise with comint-prompt-read-only set to t users can be incapable of interrupting running busy processes. See ESS's issue tracker for details: https://github.com/emacs-ess/ESS/issues/792 =2D-- lisp/comint.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/comint.el b/lisp/comint.el index 0a6aff2e73..2ed65c1c1c 100644 =2D-- a/lisp/comint.el +++ b/lisp/comint.el @@ -2500,8 +2500,9 @@ comint-clear-buffer (defun comint-interrupt-subjob () "Interrupt the current subjob." (interactive) =2D (comint-skip-input) =2D (interrupt-process nil comint-ptyp) + (let ((inhibit-read-only t)) + (comint-skip-input) + (interrupt-process nil comint-ptyp)) ;; (process-send-string nil "\n") ) =2D- 2.19.2 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-lisp-comint.el-comint-interrupt-subjob-Inhibit-read-.patch Content-Transfer-Encoding: quoted-printable From=208e3885c5b9747987cacd3b17b9de29975e7691e3 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Fri, 4 Jan 2019 10:28:09 -0600 Subject: [PATCH] * lisp/comint.el (comint-interrupt-subjob): Inhibit read o= nly Otherwise with comint-prompt-read-only set to t users can be incapable of interrupting running busy processes. See ESS's issue tracker for details: https://github.com/emacs-ess/ESS/issues/792 =2D-- lisp/comint.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/comint.el b/lisp/comint.el index 0a6aff2e73..2ed65c1c1c 100644 =2D-- a/lisp/comint.el +++ b/lisp/comint.el @@ -2500,8 +2500,9 @@ comint-clear-buffer (defun comint-interrupt-subjob () "Interrupt the current subjob." (interactive) =2D (comint-skip-input) =2D (interrupt-process nil comint-ptyp) + (let ((inhibit-read-only t)) + (comint-skip-input) + (interrupt-process nil comint-ptyp)) ;; (process-send-string nil "\n") ) =20 =2D-=20 2.19.2 --=-=-= Content-Type: text/plain Footnotes: [1] https://github.com/emacs-ess/ESS/issues/792 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEeEJ4XAMgliXNXicpHkInolPpmscFAlwvizkACgkQHkInolPp msdsxQgAhDOpfHbPa+4kR9JgPDvPHoR7mI8hLVFZ5Xd3hij6UJ1mCCUWAsaJxGJa Kg7J5mt7/xMfG568sDUpK7Bsg42Kf3ZpsjLVXJMWsnXwJU02l29b2/eWE/7eFa+2 ITK6ZstTguvYNFU3p9tJHBvT4zBbconGAgIiU6cNmo5KCz/Hsu7hz5ca16+nmDLu lLd7XZihyZ+PbcQmYBk4uaaP1arh0KOM56JyCPHRvtG5rZck6wbSy4DsbIzc0lIG Q2oxX6h8owYsle6qYe/htdAUqr6Xo0ocsFXLyg8qz9x502mhU5R7ejDOqZVITljB MQ382KhfOAAOhza1ud7A8qoBfjOZkw== =CFeP -----END PGP SIGNATURE----- --==-=-=-- ------------=_1551057122-29664-1--