From unknown Thu Aug 14 18:37:19 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33963] [PATCH] gnu: octave: Fix makeinfo path configuration Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 03 Jan 2019 16:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33963 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 33963@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.154653425926887 (code B ref -1); Thu, 03 Jan 2019 16:51:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 Jan 2019 16:50:59 +0000 Received: from localhost ([127.0.0.1]:45914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gf6Cr-0006zT-PX for submit@debbugs.gnu.org; Thu, 03 Jan 2019 11:50:59 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42041) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gf6Cp-0006zL-4f for submit@debbugs.gnu.org; Thu, 03 Jan 2019 11:50:52 -0500 Received: from lists.gnu.org ([208.118.235.17]:58596) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gf6Co-0004uw-JU for submit@debbugs.gnu.org; Thu, 03 Jan 2019 11:50:50 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gf6Cn-0001TM-Js for guix-patches@gnu.org; Thu, 03 Jan 2019 11:50:50 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.3 required=5.0 tests=BAYES_50,RCVD_IN_SORBS_WEB autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gf6Cj-0004rf-Cr for guix-patches@gnu.org; Thu, 03 Jan 2019 11:50:49 -0500 Received: from vultr.systemreboot.net ([45.77.148.100]:51776) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gf6Ci-0004l7-3M for guix-patches@gnu.org; Thu, 03 Jan 2019 11:50:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NA1ijyzR9VGuu4k2wFxXuoh/2y+XnzGVr9uK5yADIA4=; b=H8/w3+jz3P2ql+wDgcqyWkGS6o fsQZOuTrWPCKd3INcUHYv7JKEsg66TPBqUeghxyKLENfHLlsk5t9bAkt6iwMONmGpCJCJD9oSKpBB u34JEPNuEtMZIdGShLtCYn/s0EwaFR0nPvukAEisDz7HNFoPPT2Sz+0t890DffU0/i9M=; Received: from [103.5.134.173] (helo=steel) by systemreboot.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gf6CZ-0005TH-49 for guix-patches@gnu.org; Thu, 03 Jan 2019 22:20:36 +0530 From: Arun Isaac Date: Thu, 03 Jan 2019 22:20:05 +0530 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.77.148.100 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain The makeinfo path now needs to be substituted in libinterp/corefcn/help.h, not libinterp/corefn/help.cc. I have addressed this in the attached patch. I have also filed a bug upstream asking them to add a configure flag --with-makeinfo. Hopefully, we won't have to manually substitute the path to makeinfo in the next release. https://savannah.gnu.org/bugs/index.php?55371 --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-gnu-octave-Fix-makeinfo-path-configuration.patch Content-Transfer-Encoding: quoted-printable From=2036612684f6f7719aef4b1b9fd40632b8749fcd90 Mon Sep 17 00:00:00 2001 From: Arun Isaac Date: Thu, 3 Jan 2019 21:56:26 +0530 Subject: [PATCH] gnu: octave: Fix makeinfo path configuration. * gnu/packages/maths.scm (octave-cli)[arguments]: Fix makeinfo path configuration in configure-makeinfo phase. =2D-- gnu/packages/maths.scm | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm index 448d9e373..e67bc5e93 100644 =2D-- a/gnu/packages/maths.scm +++ b/gnu/packages/maths.scm @@ -19,7 +19,7 @@ ;;; Copyright =C2=A9 2017 Nils Gillmann ;;; Copyright =C2=A9 2017 Ben Woodcroft ;;; Copyright =C2=A9 2017 Theodoros Foradis =2D;;; Copyright =C2=A9 2017 Arun Isaac +;;; Copyright =C2=A9 2017, 2019 Arun Isaac ;;; Copyright =C2=A9 2017, 2018 Tobias Geerinckx-Rice ;;; Copyright =C2=A9 2017 Dave Love ;;; Copyright =C2=A9 2018 Jan Nieuwenhuizen @@ -1484,11 +1484,10 @@ can solve two kinds of problems: (modify-phases %standard-phases (add-after 'configure 'configure-makeinfo (lambda* (#:key inputs #:allow-other-keys) =2D (substitute* "libinterp/corefcn/help.cc" =2D (("Vmakeinfo_program =3D \"makeinfo\"") =2D (string-append "Vmakeinfo_program =3D \"" =2D (assoc-ref inputs "texinfo") =2D "/bin/makeinfo\""))) + (substitute* "libinterp/corefcn/help.h" + (("\"makeinfo\"") + (string-append + "\"" (assoc-ref inputs "texinfo") "/bin/makeinfo\""))) #t))))) (home-page "https://www.gnu.org/software/octave/") (synopsis "High-level language for numerical computation") =2D-=20 2.19.2 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAlwuPT0ACgkQLiXui2GA K7O3Dgf/b1AN1GjyFAwkbI7GeevUNNQv818n5hs/NmwwFzysDn49NJqPnyL4dcSB ymO7lYSymgsAhUaGpy0E1cmhcZWGkUQ7cJt5fCgmjEnzv87DSplstOv4aw5T5/HL 5q6Wyg0Am+yHTjQJb62zE+flmypLTnwkIvS2MXC6aqgAmCmIRJ0/pWHgd37baAvJ HDcmqAQXp/KL/nla3i+EBbDsNCNd/NFfOIALj+edeI6bFNcDm9Ql90hKmiEkiYXJ 3dKKG5RbDbRUrYrrLs0gWdvYkzbCjnbyOggnL/rpQRQ5pePxFRT43fH43D16H3bc R3N24bu7FERpGacUqVLbTdu7pywUJA== =gSZX -----END PGP SIGNATURE----- --==-=-=-- From unknown Thu Aug 14 18:37:19 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#33963] [PATCH] gnu: octave: Fix makeinfo path configuration Resent-From: Kei Kebreau Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 05 Jan 2019 03:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33963 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Arun Isaac Cc: 33963@debbugs.gnu.org Received: via spool by 33963-submit@debbugs.gnu.org id=B33963.154665871023218 (code B ref 33963); Sat, 05 Jan 2019 03:26:01 +0000 Received: (at 33963) by debbugs.gnu.org; 5 Jan 2019 03:25:10 +0000 Received: from localhost ([127.0.0.1]:47172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfca8-00062G-Fd for submit@debbugs.gnu.org; Fri, 04 Jan 2019 22:25:10 -0500 Received: from mout01.posteo.de ([185.67.36.65]:38911) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfca4-00061a-SK for 33963@debbugs.gnu.org; Fri, 04 Jan 2019 22:25:02 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 98EF916005E for <33963@debbugs.gnu.org>; Sat, 5 Jan 2019 04:24:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1546658694; bh=wunEX7vMaMtampBc8FMH0U5xslW/u2Rgpn//t8QjT50=; h=From:To:Cc:Subject:Date:From; b=opFx+Vm4UPpwZTZwBNeYv1+99LVr5xKvb2ojiOLPkXFKkc9S6ZHS1rbA/aAzEkTuM vm3Rpf7wNkeKWqZtcanNsBTeXi+54t7KVeI2ewVae5NRSqMOrUwmOyLgdKKKOrI1um 8paJAKnSZfBRdulEak/fJf8hk3H8Mv8Dre8HSxRaSLNqpOaIbFrP9E5JNLOiybVW1H zzycd5HtFWNvYjuJYQS57h0YYk8inO2Hmz3ocSxUjPGcByC/XLfPTxPLhNMuYSqnci NYKbwuUihXe0r3c3MKljdRQoNNKW4J75Dcz0plDILCoHOP/67uSjhCAikyaHqUl5Zk xCkqKEklre5bA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 43Wn8P29PHz6tm9; Sat, 5 Jan 2019 04:24:53 +0100 (CET) From: Kei Kebreau References: Date: Fri, 04 Jan 2019 22:24:30 -0500 In-Reply-To: (Arun Isaac's message of "Thu, 03 Jan 2019 22:20:05 +0530") Message-ID: <8736q7bxch.fsf@posteo.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Arun Isaac writes: > The makeinfo path now needs to be substituted in > libinterp/corefcn/help.h, not libinterp/corefn/help.cc. I have addressed > this in the attached patch. > > I have also filed a bug upstream asking them to add a configure flag > --with-makeinfo. Hopefully, we won't have to manually substitute > the path to makeinfo in the next release. > > https://savannah.gnu.org/bugs/index.php?55371 > > From 36612684f6f7719aef4b1b9fd40632b8749fcd90 Mon Sep 17 00:00:00 2001 > From: Arun Isaac > Date: Thu, 3 Jan 2019 21:56:26 +0530 > Subject: [PATCH] gnu: octave: Fix makeinfo path configuration. > > * gnu/packages/maths.scm (octave-cli)[arguments]: Fix makeinfo path > configuration in configure-makeinfo phase. > --- > gnu/packages/maths.scm | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm > index 448d9e373..e67bc5e93 100644 > --- a/gnu/packages/maths.scm > +++ b/gnu/packages/maths.scm > @@ -19,7 +19,7 @@ > ;;; Copyright =C2=A9 2017 Nils Gillmann > ;;; Copyright =C2=A9 2017 Ben Woodcroft > ;;; Copyright =C2=A9 2017 Theodoros Foradis > -;;; Copyright =C2=A9 2017 Arun Isaac > +;;; Copyright =C2=A9 2017, 2019 Arun Isaac > ;;; Copyright =C2=A9 2017, 2018 Tobias Geerinckx-Rice > ;;; Copyright =C2=A9 2017 Dave Love > ;;; Copyright =C2=A9 2018 Jan Nieuwenhuizen > @@ -1484,11 +1484,10 @@ can solve two kinds of problems: > (modify-phases %standard-phases > (add-after 'configure 'configure-makeinfo > (lambda* (#:key inputs #:allow-other-keys) > - (substitute* "libinterp/corefcn/help.cc" > - (("Vmakeinfo_program =3D \"makeinfo\"") > - (string-append "Vmakeinfo_program =3D \"" > - (assoc-ref inputs "texinfo") > - "/bin/makeinfo\""))) > + (substitute* "libinterp/corefcn/help.h" > + (("\"makeinfo\"") > + (string-append > + "\"" (assoc-ref inputs "texinfo") "/bin/makeinfo\""))) > #t))))) > (home-page "https://www.gnu.org/software/octave/") > (synopsis "High-level language for numerical computation") LGTM. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlwwI24ACgkQ5qXuPBlG eg2kGQ//eycgLCJkWe+cdlnuhLZ/cIb9kzNKsum7q7bir36jvBWkG+Jbe8khTeq6 lgvZ+c5N9rVcVD/8MOys4ygp7ScyuyIH3iPshM5Er+pXr/wJznI+Lczmf1qr0UcG Hc44yadC22sJT3EOLridUYoLjqUfymsxIMmHIMAKeycCbB3gQlJwxp5VgP+9SM75 5rEB7NywAEH0ZdqT7DVjueXseTjJhnk1rHpl1DAkoAcCB9KJwzrD8anDynKr0zJq DW+P0Iqtby3hbdMPHAuog6a8p5RmeBNdPFxoWnoEP40HGlqeH572tzWeC+Dsop2g 1vl2VjsQU3yd+7/MBMVB+VZ+ibLHsha4Lx/5zMkh6GPQG0jyE6eqoZ8Yz8TJxHEN WfCP66eqbiF1nto0JwY67gfop6HRpXujhlb7NVVLxPln/p1WoYDZEt+P9L30puoa UArCv0cKfGLLeuom1LUSDrM4Gjg1/NbvCwwe9F2p15RHidx/iEO4aCNIOWdOf0Q/ kQiy3kVZ0abrz7hXn9Y/y4L7XdPkbU4eDMT+wjqVQGwZiM7eJtM3DGpLXWyoI/PN nEt80idw1AU0BQG5lFvolyIqxxz6F7zN5ygy/nZGdPzZIHA6yM7wxHjEdZ5V7Mg0 q7/ZimUlwv0Uuy3M1Vue4X19I6HA3aL3kyyLMZ3m5qMkEzx7M78= =2VAj -----END PGP SIGNATURE----- --=-=-=-- From unknown Thu Aug 14 18:37:19 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Arun Isaac Subject: bug#33963: closed (Re: [bug#33963] [PATCH] gnu: octave: Fix makeinfo path configuration) Message-ID: References: X-Gnu-PR-Message: they-closed 33963 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 33963@debbugs.gnu.org Date: Sat, 05 Jan 2019 18:26:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1546712762-25846-1" This is a multi-part message in MIME format... ------------=_1546712762-25846-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #33963: [PATCH] gnu: octave: Fix makeinfo path configuration which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 33963@debbugs.gnu.org. --=20 33963: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D33963 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1546712762-25846-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 33963-done) by debbugs.gnu.org; 5 Jan 2019 18:25:44 +0000 Received: from localhost ([127.0.0.1]:48065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfqdj-0006iM-P2 for submit@debbugs.gnu.org; Sat, 05 Jan 2019 13:25:43 -0500 Received: from vultr.systemreboot.net ([45.77.148.100]:45580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfqdh-0006iD-8T for 33963-done@debbugs.gnu.org; Sat, 05 Jan 2019 13:25:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=eLzDvyv6A0aEc9PCP7rFee/Yr7V1E4WHrrUkbTRTxi8=; b=X1KbiMCMPqjtCpZU0i09g9mev FUQzZAWzt2V4hNZL98IpeDxcaVd5N8Mm3yRrG7MUc2k/4fL5bjWtRAAgx0vY8chMDUHpVpm4h9H2o 3z9qkbBPvqsxGQB4I3ly+IWfa+cnWB47ZvT+dCKvA+CoFSBbRZjaIUx4LIDyBDTiN1Ucw=; Received: from [103.5.134.173] (helo=steel) by systemreboot.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gfqda-00024m-3X; Sat, 05 Jan 2019 23:55:35 +0530 From: Arun Isaac To: Kei Kebreau Subject: Re: [bug#33963] [PATCH] gnu: octave: Fix makeinfo path configuration In-Reply-To: <8736q7bxch.fsf@posteo.net> References: <8736q7bxch.fsf@posteo.net> Date: Sat, 05 Jan 2019 23:55:18 +0530 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 2.7 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Pushed, thanks for the review! Content analysis details: (2.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [103.5.134.173 listed in dnsbl.sorbs.net] 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] -0.0 SPF_PASS SPF: sender matches SPF record X-Debbugs-Envelope-To: 33963-done Cc: 33963-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Pushed, thanks for the review! Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [103.5.134.173 listed in dnsbl.sorbs.net] -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --=-=-= Content-Type: text/plain Pushed, thanks for the review! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAlww9o4ACgkQLiXui2GA K7PcOQf/QyL32q6DLS3tfL5V2otbRiho6eAw3izbSKjEDcq7jHOqCJUcINpwYhrl YbWPAKd6pkIiGO1Z46xSFy0LUJYtP1s39zqpo/P6IPmHuQ2nIGVIg5tdxYKRD75D qADL2FKf4TyJhfttUUoeQKBuBkcJcIRXx9U6t8qWyGuX+2nmoB0BGhpVhq6zK+us 4XjcgMLjU/P4Gfj+QCPCFnGpKQuG2sMaDSY9kpyu5WODtwG8/ud0xQjM+77HSOQ1 f95n5RjcEoFIPf9dAKqXguAppFUxA9sFEXhruiXI6uFH9U3XPt0MBjrxgxa4F8wj 0cjza9BGnSqYduKclKMTcG+YFByhMw== =h61O -----END PGP SIGNATURE----- --=-=-=-- ------------=_1546712762-25846-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 3 Jan 2019 16:50:59 +0000 Received: from localhost ([127.0.0.1]:45914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gf6Cr-0006zT-PX for submit@debbugs.gnu.org; Thu, 03 Jan 2019 11:50:59 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42041) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gf6Cp-0006zL-4f for submit@debbugs.gnu.org; Thu, 03 Jan 2019 11:50:52 -0500 Received: from lists.gnu.org ([208.118.235.17]:58596) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gf6Co-0004uw-JU for submit@debbugs.gnu.org; Thu, 03 Jan 2019 11:50:50 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gf6Cn-0001TM-Js for guix-patches@gnu.org; Thu, 03 Jan 2019 11:50:50 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.3 required=5.0 tests=BAYES_50,RCVD_IN_SORBS_WEB autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gf6Cj-0004rf-Cr for guix-patches@gnu.org; Thu, 03 Jan 2019 11:50:49 -0500 Received: from vultr.systemreboot.net ([45.77.148.100]:51776) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gf6Ci-0004l7-3M for guix-patches@gnu.org; Thu, 03 Jan 2019 11:50:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NA1ijyzR9VGuu4k2wFxXuoh/2y+XnzGVr9uK5yADIA4=; b=H8/w3+jz3P2ql+wDgcqyWkGS6o fsQZOuTrWPCKd3INcUHYv7JKEsg66TPBqUeghxyKLENfHLlsk5t9bAkt6iwMONmGpCJCJD9oSKpBB u34JEPNuEtMZIdGShLtCYn/s0EwaFR0nPvukAEisDz7HNFoPPT2Sz+0t890DffU0/i9M=; Received: from [103.5.134.173] (helo=steel) by systemreboot.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gf6CZ-0005TH-49 for guix-patches@gnu.org; Thu, 03 Jan 2019 22:20:36 +0530 From: Arun Isaac To: guix-patches@gnu.org Subject: [PATCH] gnu: octave: Fix makeinfo path configuration Date: Thu, 03 Jan 2019 22:20:05 +0530 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.77.148.100 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain The makeinfo path now needs to be substituted in libinterp/corefcn/help.h, not libinterp/corefn/help.cc. I have addressed this in the attached patch. I have also filed a bug upstream asking them to add a configure flag --with-makeinfo. Hopefully, we won't have to manually substitute the path to makeinfo in the next release. https://savannah.gnu.org/bugs/index.php?55371 --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-gnu-octave-Fix-makeinfo-path-configuration.patch Content-Transfer-Encoding: quoted-printable From=2036612684f6f7719aef4b1b9fd40632b8749fcd90 Mon Sep 17 00:00:00 2001 From: Arun Isaac Date: Thu, 3 Jan 2019 21:56:26 +0530 Subject: [PATCH] gnu: octave: Fix makeinfo path configuration. * gnu/packages/maths.scm (octave-cli)[arguments]: Fix makeinfo path configuration in configure-makeinfo phase. =2D-- gnu/packages/maths.scm | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm index 448d9e373..e67bc5e93 100644 =2D-- a/gnu/packages/maths.scm +++ b/gnu/packages/maths.scm @@ -19,7 +19,7 @@ ;;; Copyright =C2=A9 2017 Nils Gillmann ;;; Copyright =C2=A9 2017 Ben Woodcroft ;;; Copyright =C2=A9 2017 Theodoros Foradis =2D;;; Copyright =C2=A9 2017 Arun Isaac +;;; Copyright =C2=A9 2017, 2019 Arun Isaac ;;; Copyright =C2=A9 2017, 2018 Tobias Geerinckx-Rice ;;; Copyright =C2=A9 2017 Dave Love ;;; Copyright =C2=A9 2018 Jan Nieuwenhuizen @@ -1484,11 +1484,10 @@ can solve two kinds of problems: (modify-phases %standard-phases (add-after 'configure 'configure-makeinfo (lambda* (#:key inputs #:allow-other-keys) =2D (substitute* "libinterp/corefcn/help.cc" =2D (("Vmakeinfo_program =3D \"makeinfo\"") =2D (string-append "Vmakeinfo_program =3D \"" =2D (assoc-ref inputs "texinfo") =2D "/bin/makeinfo\""))) + (substitute* "libinterp/corefcn/help.h" + (("\"makeinfo\"") + (string-append + "\"" (assoc-ref inputs "texinfo") "/bin/makeinfo\""))) #t))))) (home-page "https://www.gnu.org/software/octave/") (synopsis "High-level language for numerical computation") =2D-=20 2.19.2 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAlwuPT0ACgkQLiXui2GA K7O3Dgf/b1AN1GjyFAwkbI7GeevUNNQv818n5hs/NmwwFzysDn49NJqPnyL4dcSB ymO7lYSymgsAhUaGpy0E1cmhcZWGkUQ7cJt5fCgmjEnzv87DSplstOv4aw5T5/HL 5q6Wyg0Am+yHTjQJb62zE+flmypLTnwkIvS2MXC6aqgAmCmIRJ0/pWHgd37baAvJ HDcmqAQXp/KL/nla3i+EBbDsNCNd/NFfOIALj+edeI6bFNcDm9Ql90hKmiEkiYXJ 3dKKG5RbDbRUrYrrLs0gWdvYkzbCjnbyOggnL/rpQRQ5pePxFRT43fH43D16H3bc R3N24bu7FERpGacUqVLbTdu7pywUJA== =gSZX -----END PGP SIGNATURE----- --==-=-=-- ------------=_1546712762-25846-1--