GNU bug report logs - #33961
guix pull error

Previous Next

Package: guix;

Reported by: Bradley Haggerty <bradigger <at> gmail.com>

Date: Thu, 3 Jan 2019 14:24:01 UTC

Severity: normal

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #10 received at 33961-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Brendan Tildesley <brendan.tildesley <at> gmail.com>
Cc: 33961-done <at> debbugs.gnu.org, 33962-done <at> debbugs.gnu.org,
 rhelling <at> mykolab.com
Subject: Re: bug#33962: guix pull fails on latest master
Date: Thu, 3 Jan 2019 14:33:21 -0500

[Message part 1 (text/plain, inline)]
On Fri, Jan 04, 2019 at 01:24:22AM +1100, Brendan Tildesley wrote:
> 95bf2fb637ba4abb27efe94e0b671c1e93204e4f , which adds wl-clipboard fails
> to build because it references meson-build-system without importing the
> required module. I'm guessing adding  #:use-module (guix build-system
> meson)   ; would fix it.
> 
> I'm curious to know how this error was made.

My guess is that the code contribution was tested with the
meson-build-system module imported correctly. However, the actual commit
or patch was created without the module import line.

When reviewing patches just by reading them, it's easy to miss mistakes
like this one.

This should be fixed in commit 4382cef28cb6de4b2b505788b759b0fe4f8ea603

Thanks for the reports!

[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 6 years and 197 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.