From unknown Mon Aug 18 00:08:23 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#33959 <33959@debbugs.gnu.org> To: bug#33959 <33959@debbugs.gnu.org> Subject: Status: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled Reply-To: bug#33959 <33959@debbugs.gnu.org> Date: Mon, 18 Aug 2025 07:08:23 +0000 retitle 33959 26.1.90; python.el font-lock buffer wreaks havoc when company= is enabled reassign 33959 emacs submitter 33959 Carlos Pita severity 33959 normal tag 33959 patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 02 21:09:32 2019 Received: (at submit) by debbugs.gnu.org; 3 Jan 2019 02:09:32 +0000 Received: from localhost ([127.0.0.1]:45096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gesRv-0006RY-VF for submit@debbugs.gnu.org; Wed, 02 Jan 2019 21:09:32 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gesRt-0006RQ-Ui for submit@debbugs.gnu.org; Wed, 02 Jan 2019 21:09:30 -0500 Received: from lists.gnu.org ([208.118.235.17]:40098) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gesRt-0003RW-OT for submit@debbugs.gnu.org; Wed, 02 Jan 2019 21:09:29 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gesRs-0000ED-0v for bug-gnu-emacs@gnu.org; Wed, 02 Jan 2019 21:09:29 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gesRn-0003JW-1G for bug-gnu-emacs@gnu.org; Wed, 02 Jan 2019 21:09:27 -0500 Received: from mail-qk1-x736.google.com ([2607:f8b0:4864:20::736]:32949) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gesRk-00032f-PB for bug-gnu-emacs@gnu.org; Wed, 02 Jan 2019 21:09:21 -0500 Received: by mail-qk1-x736.google.com with SMTP id d15so4457855qkj.0 for ; Wed, 02 Jan 2019 18:09:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=rnKLTZEs0x6IQtCGK/GWBWvwW0czAn61uhYK7DxrlJk=; b=WasbGepq8Lf9CNaO7p9DHVGGxhM5s2Lx02lLt4vtJjVai/7k5fpvD9+agO7ajl6XcT 3kKKRKzujCn544iUIsn/OROYngxHAY2E8lVLaYQIsDZXF71b1xcSNPvExAncZNZ40cO1 pDl6AnrVSoGY2R+VThf0Yigj9OQjjHRR4RaGivh5YeVKBfkfRzztwpNc0L+FVjng7A8j fI6Jj3jzLJ1fXjfMo5TwWBuYjlylM0IOXGFcjtTCfyEDGKeeC/OK1CDhzNWIId3GbGzr zDBsxowZFAQR4wdCYY4aCpf8sZ4NytpUp28bTaRk2u9dZNmU8wj8wFtV7/HuEuEuS2NE TuNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=rnKLTZEs0x6IQtCGK/GWBWvwW0czAn61uhYK7DxrlJk=; b=YIKVSS1w+7xJrg/Id1/MY/zkG4awqUlJpwdrHp26mixBG4AW/yZmV7Ke+yRG8DgfvM rugFLiK19V3N5kObKazRdvjlLxzH5Bp5mrCuVeBe1DEAZXbHMjMfSHpbSoeDPTNs83lz z1tI0J6cwuk/YjLYux8sOsf6YVDBH8rdzBj512uGzXGTxsyf2tGqQspkVyTb3St4ND2K pBpfGIEM/K+HzRkxltrHofQMMXb0PGZDswqU7d/ErW2n9SGteLjGO1TuxmH845gyLDNC iL0tPMnk3PWbeMFRutieaq0K6seAJpbYi00NSPZenTyVKD5UsiLVsusfa+le8/hlrcoz lbeg== X-Gm-Message-State: AJcUukf62p3zeQPdLhJOtzGnt6EKwzlrI0hHBjw20Zaz2yy4t4haoh/N gRIgLBJne0dCuVva2rJsQaZJvNTi X-Google-Smtp-Source: ALg8bN40DNS6RuNera03y28BVOuhyh1kA7mzrW8tpfIKLMnkSBQtS5V8TgeImvANzg+WIp4IEuWYkw== X-Received: by 2002:a37:5f05:: with SMTP id t5mr43258648qkb.47.1546481341876; Wed, 02 Jan 2019 18:09:01 -0800 (PST) Received: from archlinux ([181.228.213.205]) by smtp.gmail.com with ESMTPSA id v53sm25634501qtb.6.2019.01.02.18.09.00 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 02 Jan 2019 18:09:01 -0800 (PST) From: Carlos Pita To: bug-gnu-emacs@gnu.org Subject: 26.1.90; python.el font-lock buffer wreaks havoc when eldoc is enabled Date: Wed, 02 Jan 2019 23:08:53 -0300 Message-ID: <87h8eq332i.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::736 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Simply open the font lock buffer *Python-font-lock* while keeping an inferior mode python buffer at its side. Now start typing, wait a couple of seconds and type another character, play like this for a while and you will find out that many new lines are added to the buffer and that the current line is replicated between those empty lines. This is bad by itself, but the symptom that made me realize of the problem is that unclosed strings pair with their replicas in other lines and hence get quite a random fontification. Easier: enter the font lock buffer and scroll to the top. Maybe write something. Sooner than later the buffer will scroll down by itself. Delete everything, add a character, wait a moment, newlines appear below the character. I started disabling minor modes one by one until I found out that the culprit was eldoc. I haven't investigated further but I believe that just disabling eldoc there would be fine, don't you? I will submit a patch in a moment. Btw, I've submitted a patch for another font lock buffer related bug [1] a time ago and I might be wrong but I got the impression that python.el is rather forgotten these days. I wouldn't mind becoming a maintainer at all, or helping with maintenance, if necessary. [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=32390 Best regards -- Carlos --------------------------------------- In GNU Emacs 26.1.90 (build 4, x86_64-pc-linux-gnu, GTK+ Version 3.24.1) of 2018-12-05 built on archlinux Repository revision: c7897c27861fd8b2690f40e77402edced6aa0ceb Windowing system distributor 'The X.Org Foundation', version 11.0.12003000 Recent messages: delete-backward-char: Beginning of buffer Winner mode disabled delete-backward-char: Beginning of buffer Xclip mode disabled Invalid byte code in /home/carlos/local/stow/emacs-26/share/emacs/26.1.90/lisp/emacs-lisp/cl-extra.elc Show-Paren mode disabled Ido-Ubiquitous mode disabled Invalid byte code in /home/carlos/local/stow/emacs-26/share/emacs/26.1.90/lisp/emacs-lisp/cl-extra.elc Eldoc mode disabled in current buffer delete-backward-char: Text is read-only Configured using: 'configure --prefix=/home/carlos/local/stow/emacs-26 --libexecdir=/home/carlos/local/stow/emacs-26/lib --with-x-toolkit=gtk3 --with-xft --with-modules' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD LCMS2 Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Help Minor modes in effect: semantic-minor-modes-format: ((:eval (if (or semantic-highlight-edits-mode semantic-show-unmatched-syntax-mode) S))) global-magit-file-mode: t magit-auto-revert-mode: t global-git-commit-mode: t async-bytecomp-package-mode: t pdf-occur-global-minor-mode: t diff-auto-refine-mode: t pyvenv-mode: t shell-dirtrack-mode: t ido-everywhere: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug sendmail pulse cl-print edebug misearch multi-isearch magit-extras magit-bookmark magit-submodule magit-obsolete magit-blame magit-stash magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-collab ghub-graphql treepy graphql ghub url-http tls gnutls url-gw nsm url-auth url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func magit-diff smerge-mode magit-core magit-autorevert autorevert filenotify magit-process magit-margin magit-mode git-commit magit-git magit-section magit-utils magit-popup crm log-edit message rmc puny rfc822 mml mml-sec epa derived epg mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader pcvs-util add-log with-editor async-bytecomp async dash autoload lisp-mnt checkdoc whitespace visual-fill-column face-remap vc-git term/xterm xterm server projectile pdf-occur ibuf-ext ibuffer ibuffer-loaddefs tablist tablist-filter semantic/wisent/comp semantic/wisent semantic/wisent/wisent semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local cedet dired dired-loaddefs pdf-isearch let-alist pdf-misc imenu pdf-tools pdf-view bookmark pp jka-compr pdf-cache pdf-info tq pdf-util image-mode ox-md ox-html table ox-beamer ox-latex ox-ascii ox-publish ox org-capture org-protocol org-element avl-tree generator org org-macro org-footnote org-pcomplete org-list org-faces org-entities noutline outline org-version ob-python ob-emacs-lisp ob ob-tangle org-src ob-ref ob-lob ob-table ob-keys ob-exp ob-comint ob-core ob-eval org-compat org-macs org-loaddefs find-func cal-menu calendar cal-loaddefs cl-extra yasnippet elec-pair highlight-indentation flymake-proc flymake warnings help-fns radix-tree help-mode elpy find-file-in-project ivy delsel colir color ivy-overlay ffap thingatpt windmove diff-mode elpy-shell pyvenv esh-var esh-io esh-cmd esh-opt esh-ext esh-proc esh-arg esh-groups eshell esh-module esh-mode esh-util elpy-profile elpy-django elpy-refactor subr-x python tramp-sh tramp tramp-compat tramp-loaddefs trampver ucs-normalize shell pcomplete parse-time format-spec advice json map grep compile comint ansi-color files-x easy-mmode doom-themes-org company-oddmuse company-keywords company-etags etags xref project company-gtags company-dabbrev-code company-dabbrev company-files company-capf company-cmake company-xcode company-clang company-semantic company-eclim company-template company-bbdb doom-tomorrow-night-theme doom-themes doom-themes-common xclip winner ring paren ido-completing-read+ memoize s cus-edit minibuf-eldef ido gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums time-date mail-utils mm-util mail-prsvr wid-edit company edmacro kmacro pcase cus-start cus-load finder-inf info package easymenu epg-config url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 1011425 82213) (symbols 48 51276 0) (miscs 40 1854 1775) (strings 32 170805 3260) (string-bytes 1 4865573) (vectors 16 88778) (vector-slots 8 2035058 160578) (floats 8 582 818) (intervals 56 6500 1583) (buffers 992 36)) From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 02 21:29:30 2019 Received: (at control) by debbugs.gnu.org; 3 Jan 2019 02:29:30 +0000 Received: from localhost ([127.0.0.1]:45106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1geslG-0006wy-EF for submit@debbugs.gnu.org; Wed, 02 Jan 2019 21:29:30 -0500 Received: from mail-yw1-f54.google.com ([209.85.161.54]:39373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1geslF-0006wk-8Z for control@debbugs.gnu.org; Wed, 02 Jan 2019 21:29:29 -0500 Received: by mail-yw1-f54.google.com with SMTP id k188so2208145ywa.6 for ; Wed, 02 Jan 2019 18:29:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=YqJe5xlLgTat6mxBVSn/ZkOoz+rnQMBWJojTi9Zf7vw=; b=Il5Wo26vjkXcknQHPgU5YvvSEhQ+REYqcp6vqh7FJ9rLLjhBZOK5TTrkffb2CU/idM aYtECPdCCjr6gcpE4L1HlwgXztvVL4VOaKm6HPLlKmKEfm3VTXlQYkVvfhYi/BuRcEHQ Q0JXtIB6gKaeyEDvl6nDf57B2yqWNVlEHKIVBsV5fqW7370xJWGzjIQCJvKKcCylBC3X Fg5CeofljCQ0uuDe9EfeAg7MMrpOPLTm9haeS5XmHmyMdgBTzhXZctKoJu9Uf/DerKz6 Cm38qWGqImFGopROzENPm3y/tSEbAGp+jxdGibXEuBDv/cGk5OYaOSn+f1OZJ8/xu+wc BBdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=YqJe5xlLgTat6mxBVSn/ZkOoz+rnQMBWJojTi9Zf7vw=; b=fHX5O5aUFH8GlXG6Ka0epBUM6SI2GozSfIMZKJdFAd7QsJt7r3NqtIWBdRP56Q/oRK y46hm4NScy1ble8XDEEj8e6zAaWtuXinVO5dYpe4w5CCsRJuyDh8x5mq9OKFyvgjwrsK lqDsDypMhmdqdZYvNkjCfDFkxqSnCo5PkOQWwFYQmYUC7Rp5/lpPfFGmrUwhmwr85eGy UIe+NnTg6JOfIx+jUir1yhl5rkLzbf5hJX1zrbjFCPToYBkLxtfVDbcaZF5Z99LOKhW9 Pf+a22T4mkmIuuWQvOgywgsXBeio3JTaT5fd/7f8rdPEakYlgoFHWzQJlF/jUQnd7SpD ZQLw== X-Gm-Message-State: AA+aEWYl/+djBvmmU4lumL6TlDQ9unNf9G8/2O2lx2lEQbQ/N4f53HMy ULC29Dv/Ebft2Ddvbv4mMb2KoCRJvrPrRmAiZOc3pvbs X-Google-Smtp-Source: AFSGD/VwPsn4abi446hJjSpFA1QUPQHwRN8Fe0pMh3vTYJgOmHQTLo1ozAk3cXux7P5IhaZRqFrfnPNLXRO+Is5S4ok= X-Received: by 2002:a81:b653:: with SMTP id h19mr46151493ywk.170.1546482563435; Wed, 02 Jan 2019 18:29:23 -0800 (PST) MIME-Version: 1.0 From: Carlos Pita Date: Wed, 2 Jan 2019 23:29:11 -0300 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: retitle 33959 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (carlosjosepita[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.161.54 listed in list.dnswl.org] 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) retitle 33959 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 02 21:34:43 2019 Received: (at 33959) by debbugs.gnu.org; 3 Jan 2019 02:34:43 +0000 Received: from localhost ([127.0.0.1]:45109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gesqJ-0000dC-3A for submit@debbugs.gnu.org; Wed, 02 Jan 2019 21:34:43 -0500 Received: from mail-yw1-f47.google.com ([209.85.161.47]:41834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gesqG-0000cx-Rl for 33959@debbugs.gnu.org; Wed, 02 Jan 2019 21:34:41 -0500 Received: by mail-yw1-f47.google.com with SMTP id f65so12751523ywc.8 for <33959@debbugs.gnu.org>; Wed, 02 Jan 2019 18:34:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=xIccXHy7z3Ha15Cqe/dLvvDeOx6tSVzxnU6hru2ku+s=; b=axAWAVRLfwEi8WMeB63LTdYjP5RwEIMPq1ZMNewSQXutGefVCZtZQHvCfDSLAv2NV0 Rwcqrb4RLwSAm80xuZG+WwI7B2f20iuTS2TCP4sy1B7K4nEG98V7kERYydZVXGQ9ZLZF YNjtc32FPeFZjvbCHBflcO12HOEgEhAnyUujnOgksDrtmpriTikn+Aq++BDXz9WD/to2 Tgh3ylDm+ChDZl+y9hcxJ7O3S/L5EcP1ca9/xQefqbHwKxDC/s2D8vKnGTi2f/W0Ywb7 ZnSNQWB2jZcwP9y/C6lyOIOv8lIPmCcRdGz6hFpw5cVlXTvC0aTFd6KprFh9RlU5Agra tOXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=xIccXHy7z3Ha15Cqe/dLvvDeOx6tSVzxnU6hru2ku+s=; b=TUNMehQHUH8Eix3pp19eoP69szd5bLGRim0xW2p5m2f+BsQIFbVjsI8VlKQkKYbeKW 1j0oZ17qnwpzRpDCMAo8OCvZrWKocThYYhDd/caYAzFAUMELHjM0aVGP9DYGd7sWwm44 cGNzrXgx6n0b0dmceoqG8g1TaKCZwo/Oa+kIqpLoKSK6uGYeA6bLgFfuo2PqcuaMY4OV qQjSQviYppx5UaIKt7k+/qMy0zBpwiGEW+YoXcCOUY25BX41xpJe4dGFzQSnui4Mnalt HcNgfzp7bqTe4k5/kUF4g/LynyIFaujkHsFTQA3BzoFZbWWQRHFaMVZS9XbN04/jzsOv Pv7w== X-Gm-Message-State: AA+aEWZtui/8bAiRYRxaQ3D4NmXGqrxsfcgeBYyRbymyMmdr1a6MRHHJ WqsN0Sfx2HL7psE8Hih1xoY9UcqqVDmJ6KhqaOGOqA== X-Google-Smtp-Source: AFSGD/WyEyeK49T3ZRHXqm8FMnY6Zwve1YC1Pi6D2RSuLSGlGvMQNcojzptup5yu4R/wz6A9Ce1uxxf6pl56P/05eXk= X-Received: by 2002:a81:7051:: with SMTP id l78mr45849217ywc.146.1546482875227; Wed, 02 Jan 2019 18:34:35 -0800 (PST) MIME-Version: 1.0 From: Carlos Pita Date: Wed, 2 Jan 2019 23:34:24 -0300 Message-ID: Subject: To: 33959@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: I've changed the subject because the problem seems to be company and not eldoc. It's weird since my first suspicion was about company menu opening and inserting those empty lines so I turned off compa [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (carlosjosepita[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.161.47 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: 33959 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) I've changed the subject because the problem seems to be company and not eldoc. It's weird since my first suspicion was about company menu opening and inserting those empty lines so I turned off company local and global minor modes to no avail... maybe I inadvertently toggle the mode on. I will experiment a bit more until I'm sure which mode is causing the issue, but company makes a lot of sense. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 02 21:37:03 2019 Received: (at control) by debbugs.gnu.org; 3 Jan 2019 02:37:03 +0000 Received: from localhost ([127.0.0.1]:45112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gessY-0000gz-Fw for submit@debbugs.gnu.org; Wed, 02 Jan 2019 21:37:03 -0500 Received: from mail-qt1-f173.google.com ([209.85.160.173]:43031) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gessV-0000gU-0v for control@debbugs.gnu.org; Wed, 02 Jan 2019 21:37:01 -0500 Received: by mail-qt1-f173.google.com with SMTP id i7so35558922qtj.10 for ; Wed, 02 Jan 2019 18:36:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:date:message-id:mime-version; bh=b2dRcAJoNvmMfignVGvkk/ficj24+PLddrn9I9qwWh0=; b=r42Lz2cu2i5nBMoasXc8gATUUOaLfr+JJuVzPUyz9bIi2HWUKbzXRj5IknXBD0VxJS 06ayL2Gu8mHanmpIA7iwoQkfklNxxk9CnG+ZCuEw21PY6+9/CrnKD7nN9RN6cfIwLBx2 RZHK+OrZYdlBBa4lTBfMvz7eu0TVqq4rfs8MIrv//q5JN+f87PVjz8q51NPqbmt0pkdO 1SPOnrUWu9VIYjNGie9FGeKvTNtfJCImaDtDjdwtDgdw8NJqTi9s17UxCSfXuiwC/JKY /Glgk15P6CNvi8ZPdFrbSeyAhdKjDjCVlzEorz+dFt/hf3+rvFtr9lVxAuyFMHM/TNpv xZnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:date:message-id:mime-version; bh=b2dRcAJoNvmMfignVGvkk/ficj24+PLddrn9I9qwWh0=; b=pb/sgcTMxm32OXVMNXNZjsAJgL3Aj5Q8ZphMTPTuKs/zNaSZLL8DToheYClsED8v2f TSgoA0j8x+caFeCVAhTnYDDXfoqqDCgQyd2RRiwCS+5tp7dAPqu0FFkiax6suBkVZeAZ Q9WAdaPhKg/c4QJVr0ZRWx2x8a4C7qwgPauDKe5wKGCLHNSOgsK1tbvOte4yy2JthU+Y CQ9CviDtE0VQaBsI66mEeH41E7nGjWB1RQ9idD5p0Gu2hWg7pU/7qD4eZcr0T9nn07bM rThPF6c97R/GPUpeH1SVIzIFHZghMNCpQFflpGKC+EwL2pLNXm3iyFqzo7XDbBHML+6/ mmZQ== X-Gm-Message-State: AJcUukc1XORdGEyslACFRfMqMhKLyxe1y80D1sw6+Vb/20v/NnnNVn7w 6HG6Z5mm5lKdGiWgXMUQJxDr7j0O X-Google-Smtp-Source: ALg8bN58qnMmORTPnksJB00gVY/z/gfECRSV3W3eDcSy60quAbf6Ujhreflwh/J68wrCYEhKA8ZkHg== X-Received: by 2002:a0c:c2ce:: with SMTP id c14mr46159290qvi.7.1546483013379; Wed, 02 Jan 2019 18:36:53 -0800 (PST) Received: from archlinux ([181.228.213.205]) by smtp.gmail.com with ESMTPSA id n71sm5899556qkl.72.2019.01.02.18.36.52 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 02 Jan 2019 18:36:52 -0800 (PST) From: Carlos Pita To: control@debbugs.gnu.org Date: Wed, 02 Jan 2019 23:36:40 -0300 Message-ID: <874laqeabr.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: retitle 33959 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (carlosjosepita[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.160.173 listed in list.dnswl.org] 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) retitle 33959 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 02 23:40:21 2019 Received: (at 33959) by debbugs.gnu.org; 3 Jan 2019 04:40:21 +0000 Received: from localhost ([127.0.0.1]:45151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1geuns-0001Nw-O7 for submit@debbugs.gnu.org; Wed, 02 Jan 2019 23:40:20 -0500 Received: from mail-yb1-f179.google.com ([209.85.219.179]:36935) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1geunq-0001Ng-Hh for 33959@debbugs.gnu.org; Wed, 02 Jan 2019 23:40:18 -0500 Received: by mail-yb1-f179.google.com with SMTP id 2so11077031ybw.4 for <33959@debbugs.gnu.org>; Wed, 02 Jan 2019 20:40:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=i0MryV1YR+VOU/m2uziOW3lrnDby9Mdhw+zP356ry2c=; b=W7wSkSJNW/I0Na2BasyvWtOu2wABvoVYL31DZf+ZuxUOQAcXG60NXIMBze/pt3atoi gcoulNu8JjQz0YZ3Ozx6k6mHASr//p0InV8McsGU1wbm/bKIlH1S7Ona3aydpGCoog7r SvgRlGA+fRg7MpiGbinMrQjRgCzw28J8g3fxa/H3RBEdLdrDFss2dzSp9C9Ye1XnvgY8 mTWSGFH6qSp7qw7UPu54cEckq4P/Xj4EoQhoTV5NYd5Pqj056NdJVwLFlLEf2KF7gSFC ui3nvpGAr87Hovkibm3lqCdKL9NhlkrGjbaXdW2g3Jz7tGKEjgsF0bMv58CGdXa5Klij VcOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=i0MryV1YR+VOU/m2uziOW3lrnDby9Mdhw+zP356ry2c=; b=seAvAV/Gx19y1UYydRF3Ia9LXsu20OyJDeQJ+wSq1LKGUA4Ta1V28JRM8XZfAZebr+ 7gERp/rDezds+Arbl5sxG+9B9czcivLUVSZcX06mK4q/rIfCgPRcdhhkKkSDAVC3/9lr L8UhAZKblt+lEoEHx7uE5J+wpa14UpyiPAlQky02AuDjeyZEpw7mBZftht5bjxdKFU/2 4NescKxt1HbvNoKkatNVFMs4uFMS9swxTuW4mlaEn4f9sdS+gOpJcmZCdgMtEGNGpfNW yH16frrq9EnJpdAoAJTBy3JPEf0iU/zRPzncvpfPgVgXK9IXmemT9XKuV3DnvH1F7MN3 2yWg== X-Gm-Message-State: AJcUukewP/KK0YqQ1Yk+uaNDUMWo824oSJkDwS70QSY8BaZPUAj4bvT3 Lbv0X80Pf0vK+uqrwLwxnK28xtXboGmEcSb07z5ckZi4 X-Google-Smtp-Source: ALg8bN4AaYE2nA0CAktPzMqBwPMIx5sH3siW0kDVfCVDluCUhZjzbLgsGAhSn3UPp4MNu93scnb76cNbLyNntkPQ+UA= X-Received: by 2002:a25:7ec5:: with SMTP id z188mr13719913ybc.282.1546490412504; Wed, 02 Jan 2019 20:40:12 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Carlos Pita Date: Thu, 3 Jan 2019 01:40:00 -0300 Message-ID: Subject: Re: To: 33959@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33959 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Well, I think I was right both times but because the problem is more complex than I thought at first. When I was editing the font lock buffer itself, it was eldoc that was adding an extra line. But when I was editing the shell buffer line, it was company that was adding those lines to the font lock buffer (probably because of a weird effect of an empty menu or something invisibly opening and adding content to the shell buffer). Btw, company is disabled in the font lock buffer since the globalized mode is off for buffers whose name starts with a whitespace: (defun company-mode-on () (when (and (not (or noninteractive (eq (aref (buffer-name) 0) ?\s))) .... The first effect (eldoc) is simple to fix by just disabling eldoc in the font lock buffer, but this is not even necessary since it requires the user to directly edit the font lock buffer in order to trigger it, and this is not a relevant use case. For the second effect (company) I propose to delete from the beginning of buffer each time instead of from the beginning of line, since the font lock buffer won't contain multiline input in any case. Currently after each change in the current line this is being done: (delete-region (line-beginning-position) (point-max)) but I see no reason to not call (erase-buffer) altogether. Do you? From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 03 00:39:12 2019 Received: (at 33959) by debbugs.gnu.org; 3 Jan 2019 05:39:12 +0000 Received: from localhost ([127.0.0.1]:45157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1geviq-0002tK-7a for submit@debbugs.gnu.org; Thu, 03 Jan 2019 00:39:12 -0500 Received: from mail-yb1-f180.google.com ([209.85.219.180]:35907) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gevin-0002t7-Vh for 33959@debbugs.gnu.org; Thu, 03 Jan 2019 00:39:10 -0500 Received: by mail-yb1-f180.google.com with SMTP id a190so10100471ybg.3 for <33959@debbugs.gnu.org>; Wed, 02 Jan 2019 21:39:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=9WjJruoMVrH99H1AzbGWfYKSqiSn1lX0c/DtgIlvLvA=; b=dtjkUv1fZYqGgd6F3l3gmCXQ49G4qmfZQCWFzGXO56eGRHhY2pDKrzS7+ar1ioUhTT IJ4fbBI3cAiur4UoTkTz3Ofn7ddY2FNZ6gYbC9a//1Cmb/iE6fjfY3+sWQO+2W02LSD1 IrwZM/K8S8l5RkYF2cBcJ3xPcTeeUkAxRiSyqZOi94UYD+6ABh5jIzbKjhn/G4qnEyRz YyT/jnJo8krXvLUmUVnHGFe+xom9wOh42a1wlnq0gQF58whzR4vDx24y5qTqqwfZbxFE aDUWNta8JZkUBj5VlApVol12m1AITVvUP/npvKYZbWVGUUqLq2lAzvIuFKC8hYNK0xYH UfCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=9WjJruoMVrH99H1AzbGWfYKSqiSn1lX0c/DtgIlvLvA=; b=ZnX3T4vYDWILWuI47OGyxEiV2oyRYfoAeDJWgk4rxQhRNQiMDEQVxYy9DmS9YHuOX+ DIIUslUXBaH6VBKUlRtoEcBFdM/uJW28vdEQvHFQb69NMlG2/A5ov7vMmeHQMXNSJrLh CB6MuL4eEEryTx0+EQrWipAYdTcfrRWw79/RaOKvQXjFCO6MfHxyqvGm7fmztj9JyweT 4QyALy6Ucdqa7I9IgpcSG/iwIvgyee24exmDcfcw803FvobIqp2fAJgzLcpF9TauB/33 vJqGHOSAk5yJsgDhxVYiJpiSrUhsl0ZFekEgm9iuJst/n68qoGWe/rq+rkiFGvgp4g/Y 6GLw== X-Gm-Message-State: AJcUukdFsm64LzWwj1GZ7YU0qizTX5W8257CN0RNbGVZa1o5LhL1Y+K8 DQbUy+0QoXkKRRI7SD0NVwiYEMtYF+rbkiGVGFPislNr X-Google-Smtp-Source: AFSGD/X4jhXYaLf4IWKg+t939kS2FVK9+e2TGLvaXehbzYblgb/5RbE2XTHAtL82MVAScAU8ihEM9RNK5DLQQpCNAqQ= X-Received: by 2002:a25:7b81:: with SMTP id w123mr46854042ybc.26.1546493944151; Wed, 02 Jan 2019 21:39:04 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Carlos Pita Date: Thu, 3 Jan 2019 02:38:52 -0300 Message-ID: Subject: Re: To: 33959@debbugs.gnu.org Content-Type: multipart/mixed; boundary="0000000000003068fb057e872e84" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33959 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000003068fb057e872e84 Content-Type: text/plain; charset="UTF-8" > but I see no reason to not call (erase-buffer) altogether. > > Do you? Yes, obviously, multiline input, I forgot. Nevertheless I found the origin of the problem. Somehow when company is enabled in the shell buffer python-shell-font-lock-comint-output-filter-function is getting empty strings as output and then the ";; Otherwise just add a newline." clause is activated. No matter the reason why empty output is being passed to the filter, it's wrong for the filter to add a new line to the font lock buffer if this happens. I'm attaching two patches, since python-shell-font-lock-comint-output-filter-function is an old friend of mine and we have spent many nights together now: 1. The first one (Avoid-spurious...) strictly fixes this issue by moving the not-empty condition to the top and doing everything else unless not-empty. Period. That works. 2. The second one (Fix-font-lock...) combines 1 with my previous patch for fixing ipython multiline input (#32390) since both changes overlap. I suggest to directly apply patch 2 since it improves prompt detection heuristic and fixes two bugs. Then you can close this and #32390. Regards -- Carlos --0000000000003068fb057e872e84 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Avoid-spurious-empty-lines-in-font-lock-buffer-fixes.patch" Content-Disposition: attachment; filename="0001-Avoid-spurious-empty-lines-in-font-lock-buffer-fixes.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jqg6etg90 RnJvbSBkODE2YTI5ZjVhOWNkY2ViZDhmNjlhZDBhNjU1NWVhY2EwNTE1ODdlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBtZW1lcGxleCA8Y2FybG9zam9zZXBpdGFAZ21haWwuY29tPgpE YXRlOiBUaHUsIDMgSmFuIDIwMTkgMDI6Mjg6MzAgLTAzMDAKU3ViamVjdDogW1BBVENIXSBBdm9p ZCBzcHVyaW91cyBlbXB0eSBsaW5lcyBpbiBmb250IGxvY2sgYnVmZmVyLCBmaXhlcyAjMzM5NTkK Ci0tLQogbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsIHwgMjcgKysrKysrKysrKysrKystLS0tLS0t LS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsIGIvbGlzcC9wcm9nbW9kZXMv cHl0aG9uLmVsCmluZGV4IDI3ZDMxYWIuLjgxYTZlODkgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21v ZGVzL3B5dGhvbi5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9weXRob24uZWwKQEAgLTI1NTYsMTkg KzI1NTYsMTkgQEAgcHl0aG9uLXNoZWxsLWZvbnQtbG9jay1jbGVhbnVwLWJ1ZmZlcgogCiAoZGVm dW4gcHl0aG9uLXNoZWxsLWZvbnQtbG9jay1jb21pbnQtb3V0cHV0LWZpbHRlci1mdW5jdGlvbiAo b3V0cHV0KQogICAiQ2xlYW4gdXAgdGhlIGZvbnQtbG9jayBidWZmZXIgYWZ0ZXIgYW55IE9VVFBV VC4iCi0gIChpZiAoYW5kIChub3QgKHN0cmluZz0gIiIgb3V0cHV0KSkKLSAgICAgICAgICAgOzsg SXMgZW5kIG9mIG91dHB1dCBhbmQgaXMgbm90IGp1c3QgYSBwcm9tcHQuCi0gICAgICAgICAgIChu b3QgKG1lbWJlcgotICAgICAgICAgICAgICAgICAocHl0aG9uLXNoZWxsLWNvbWludC1lbmQtb2Yt b3V0cHV0LXAKLSAgICAgICAgICAgICAgICAgIChhbnNpLWNvbG9yLWZpbHRlci1hcHBseSBvdXRw dXQpKQotICAgICAgICAgICAgICAgICAnKG5pbCAwKSkpKQotICAgICAgOzsgSWYgb3V0cHV0IGlz IG90aGVyIHRoYW4gYW4gaW5wdXQgcHJvbXB0IHRoZW4gInJlYWwiIG91dHB1dCBoYXMKLSAgICAg IDs7IGJlZW4gcmVjZWl2ZWQgYW5kIHRoZSBmb250LWxvY2sgYnVmZmVyIG11c3QgYmUgY2xlYW5l ZCB1cC4KLSAgICAgIChweXRob24tc2hlbGwtZm9udC1sb2NrLWNsZWFudXAtYnVmZmVyKQotICAg IDs7IE90aGVyd2lzZSBqdXN0IGFkZCBhIG5ld2xpbmUuCi0gICAgKHB5dGhvbi1zaGVsbC1mb250 LWxvY2std2l0aC1mb250LWxvY2stYnVmZmVyCi0gICAgICAoZ290by1jaGFyIChwb2ludC1tYXgp KQotICAgICAgKG5ld2xpbmUpKSkKKyAgKHVubGVzcyAoc3RyaW5nPSAiIiBvdXRwdXQpCisgICAg KGlmIDs7IElzIGVuZCBvZiBvdXRwdXQgYW5kIGlzIG5vdCBqdXN0IGEgcHJvbXB0LgorICAgICAg ICAobm90IChtZW1iZXIKKyAgICAgICAgICAgICAgKHB5dGhvbi1zaGVsbC1jb21pbnQtZW5kLW9m LW91dHB1dC1wCisgICAgICAgICAgICAgICAoYW5zaS1jb2xvci1maWx0ZXItYXBwbHkgb3V0cHV0 KSkKKyAgICAgICAgICAgICAgJyhuaWwgMCkpKQorICAgICAgICA7OyBJZiBvdXRwdXQgaXMgb3Ro ZXIgdGhhbiBhbiBpbnB1dCBwcm9tcHQgdGhlbiAicmVhbCIgb3V0cHV0IGhhcworICAgICAgICA7 OyBiZWVuIHJlY2VpdmVkIGFuZCB0aGUgZm9udC1sb2NrIGJ1ZmZlciBtdXN0IGJlIGNsZWFuZWQg dXAuCisgICAgICAgIChweXRob24tc2hlbGwtZm9udC1sb2NrLWNsZWFudXAtYnVmZmVyKQorICAg ICAgOzsgT3RoZXJ3aXNlIGp1c3QgYWRkIGEgbmV3bGluZS4KKyAgICAgIChweXRob24tc2hlbGwt Zm9udC1sb2NrLXdpdGgtZm9udC1sb2NrLWJ1ZmZlcgorICAgICAgICAoZ290by1jaGFyIChwb2lu dC1tYXgpKQorICAgICAgICAobmV3bGluZSkpKSkKICAgb3V0cHV0KQogCiAoZGVmdW4gcHl0aG9u LXNoZWxsLWZvbnQtbG9jay1wb3N0LWNvbW1hbmQtaG9vayAoKQpAQCAtMjU5Nyw2ICsyNTk3LDcg QEAgcHl0aG9uLXNoZWxsLWZvbnQtbG9jay1wb3N0LWNvbW1hbmQtaG9vawogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIChwb2ludC1tYXgpKSkpCiAgICAgICAgICAgICAgKHJlcGxh Y2VtZW50LWxlbmd0aCAobGVuZ3RoIHJlcGxhY2VtZW50KSkKICAgICAgICAgICAgICAoaSAwKSkK KwogICAgICAgICA7OyBJbmplY3QgdGV4dCBwcm9wZXJ0aWVzIHRvIGdldCBpbnB1dCBmb250aWZp ZWQuCiAgICAgICAgICh3aGlsZSAobm90ICg9IGkgcmVwbGFjZW1lbnQtbGVuZ3RoKSkKICAgICAg ICAgICAobGV0KiAoKHBsaXN0ICh0ZXh0LXByb3BlcnRpZXMtYXQgaSByZXBsYWNlbWVudCkpCi0t IAoyLjIwLjEKCg== --0000000000003068fb057e872e84 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-font-lock-output-filter-bugs-33959-and-32390.patch" Content-Disposition: attachment; filename="0001-Fix-font-lock-output-filter-bugs-33959-and-32390.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jqg6f1cu1 RnJvbSBkYzgwZGYzMTA5MzNmOWY1ZjliOWJmMDY1ZTcyZWU3OWE2YjE2MTM0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBtZW1lcGxleCA8Y2FybG9zam9zZXBpdGFAZ21haWwuY29tPgpE YXRlOiBUaHUsIDMgSmFuIDIwMTkgMDI6MzE6NTIgLTAzMDAKU3ViamVjdDogW1BBVENIXSBGaXgg Zm9udCBsb2NrIG91dHB1dCBmaWx0ZXIgYnVncyAjMzM5NTkgYW5kICMzMjM5MAoKSW1wcm92ZXMg bXVsdGlsaW5lIGlucHV0IGRldGVjdGlvbiBoZXVyaXN0aWMuCkZpeGVzIG11bHRpbGluZSBpbnB1 dCBmb3IgaXB5dGhvbi4KQXZvaWQgYWRkaW5nIHNwdXJpb3VzIGVtcHR5IGxpbmVzIHRvIHRoZSBm b250IGxvY2sgYnVmZmVyLgpGaWx0ZXIgYW5zaSBjb2xvciBmcm9tIG91dHB1dCBiZWZvcmUgbWF0 Y2hpbmcuCi0tLQogbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsIHwgMjcgKysrKysrKysrKysrKy0t LS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgMTQgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsIGIvbGlzcC9wcm9n bW9kZXMvcHl0aG9uLmVsCmluZGV4IDI3ZDMxYWIuLmU5OGQ4OGUgMTAwNjQ0Ci0tLSBhL2xpc3Av cHJvZ21vZGVzL3B5dGhvbi5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9weXRob24uZWwKQEAgLTI1 NTYsMjAgKzI1NTYsMTggQEAgcHl0aG9uLXNoZWxsLWZvbnQtbG9jay1jbGVhbnVwLWJ1ZmZlcgog CiAoZGVmdW4gcHl0aG9uLXNoZWxsLWZvbnQtbG9jay1jb21pbnQtb3V0cHV0LWZpbHRlci1mdW5j dGlvbiAob3V0cHV0KQogICAiQ2xlYW4gdXAgdGhlIGZvbnQtbG9jayBidWZmZXIgYWZ0ZXIgYW55 IE9VVFBVVC4iCi0gIChpZiAoYW5kIChub3QgKHN0cmluZz0gIiIgb3V0cHV0KSkKLSAgICAgICAg ICAgOzsgSXMgZW5kIG9mIG91dHB1dCBhbmQgaXMgbm90IGp1c3QgYSBwcm9tcHQuCi0gICAgICAg ICAgIChub3QgKG1lbWJlcgotICAgICAgICAgICAgICAgICAocHl0aG9uLXNoZWxsLWNvbWludC1l bmQtb2Ytb3V0cHV0LXAKLSAgICAgICAgICAgICAgICAgIChhbnNpLWNvbG9yLWZpbHRlci1hcHBs eSBvdXRwdXQpKQotICAgICAgICAgICAgICAgICAnKG5pbCAwKSkpKQotICAgICAgOzsgSWYgb3V0 cHV0IGlzIG90aGVyIHRoYW4gYW4gaW5wdXQgcHJvbXB0IHRoZW4gInJlYWwiIG91dHB1dCBoYXMK LSAgICAgIDs7IGJlZW4gcmVjZWl2ZWQgYW5kIHRoZSBmb250LWxvY2sgYnVmZmVyIG11c3QgYmUg Y2xlYW5lZCB1cC4KLSAgICAgIChweXRob24tc2hlbGwtZm9udC1sb2NrLWNsZWFudXAtYnVmZmVy KQotICAgIDs7IE90aGVyd2lzZSBqdXN0IGFkZCBhIG5ld2xpbmUuCi0gICAgKHB5dGhvbi1zaGVs bC1mb250LWxvY2std2l0aC1mb250LWxvY2stYnVmZmVyCi0gICAgICAoZ290by1jaGFyIChwb2lu dC1tYXgpKQotICAgICAgKG5ld2xpbmUpKSkKLSAgb3V0cHV0KQorICAodW5sZXNzIChzdHJpbmc9 IG91dHB1dCAiIikKKyAgICAoaWYgKGxldCAoKG91dHB1dCAoYW5zaS1jb2xvci1maWx0ZXItYXBw bHkgb3V0cHV0KSkpCisgICAgICAgICAgKGFuZCAocHl0aG9uLXNoZWxsLWNvbWludC1lbmQtb2Yt b3V0cHV0LXAgb3V0cHV0KQorICAgICAgICAgICAgICAgKG5vdCAoc3RyaW5nLW1hdGNoICJcXC5c XC5cXC4iIG91dHB1dCkpKSkKKyAgICAgICAgOzsgSWYgb3V0cHV0IGVuZHMgd2l0aCBhbiBpbml0 aWFsIChub3QgY29udGludWF0aW9uKSBpbnB1dCBwcm9tcHQKKyAgICAgICAgOzsgdGhlbiB0aGUg Zm9udC1sb2NrIGJ1ZmZlciBtdXN0IGJlIGNsZWFuZWQgdXAuCisgICAgICAgIChweXRob24tc2hl bGwtZm9udC1sb2NrLWNsZWFudXAtYnVmZmVyKQorICAgICAgOzsgT3RoZXJ3aXNlIGp1c3QgYWRk IGEgbmV3bGluZS4KKyAgICAgIChweXRob24tc2hlbGwtZm9udC1sb2NrLXdpdGgtZm9udC1sb2Nr LWJ1ZmZlcgorICAgICAgICAoZ290by1jaGFyIChwb2ludC1tYXgpKQorICAgICAgICAobmV3bGlu ZSkpKQorICAgIG91dHB1dCkpCiAKIChkZWZ1biBweXRob24tc2hlbGwtZm9udC1sb2NrLXBvc3Qt Y29tbWFuZC1ob29rICgpCiAgICJGb250aWZpZXMgY3VycmVudCBsaW5lIGluIHNoZWxsIGJ1ZmZl ci4iCkBAIC0yNTk3LDYgKzI1OTUsNyBAQCBweXRob24tc2hlbGwtZm9udC1sb2NrLXBvc3QtY29t bWFuZC1ob29rCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHBvaW50LW1heCkp KSkKICAgICAgICAgICAgICAocmVwbGFjZW1lbnQtbGVuZ3RoIChsZW5ndGggcmVwbGFjZW1lbnQp KQogICAgICAgICAgICAgIChpIDApKQorCiAgICAgICAgIDs7IEluamVjdCB0ZXh0IHByb3BlcnRp ZXMgdG8gZ2V0IGlucHV0IGZvbnRpZmllZC4KICAgICAgICAgKHdoaWxlIChub3QgKD0gaSByZXBs YWNlbWVudC1sZW5ndGgpKQogICAgICAgICAgIChsZXQqICgocGxpc3QgKHRleHQtcHJvcGVydGll cy1hdCBpIHJlcGxhY2VtZW50KSkKLS0gCjIuMjAuMQoK --0000000000003068fb057e872e84-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 03 00:39:51 2019 Received: (at control) by debbugs.gnu.org; 3 Jan 2019 05:39:52 +0000 Received: from localhost ([127.0.0.1]:45160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gevjT-0002uL-Nt for submit@debbugs.gnu.org; Thu, 03 Jan 2019 00:39:51 -0500 Received: from mail-yw1-f41.google.com ([209.85.161.41]:36629) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gevjS-0002u9-Fq for control@debbugs.gnu.org; Thu, 03 Jan 2019 00:39:50 -0500 Received: by mail-yw1-f41.google.com with SMTP id i73so12878338ywg.3 for ; Wed, 02 Jan 2019 21:39:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=8ADMy7olbtGH3960U1c77lt3G9uQeG2i7L9WI61ljDg=; b=n4OQcU/59BI8vG24XtvlS3wtl87XyWq/zsWlinZ7ng3evXHvBmq30yMPaaq0Q0cj7v 5aW4jTvlgAFXFCrnD5A0U53BDlTU6BqVVMzAYIdVWUa/WxyYKW+HqZJg6pkIOI1OuOCJ mgdRHkAr59iU+4geI/ox27YWKmaxiCNBhX0AcEBcVLGIE8ISyGbGVRrDFepwk8mbpkVH cRArjp+/aBjZYxXlu8cZHhThB4quN7FXbEwx/2d7TvV18/lSa8QW2zmynKAjpbDKQtAx W/j+vJv4jgSd60/Q++8aq8aZEvHljGuaeWGyLAcgg4VMLf+MDl8ozcmCvED3ZGeUisBH 1SfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=8ADMy7olbtGH3960U1c77lt3G9uQeG2i7L9WI61ljDg=; b=GDUfUJowL0WDEqL0/E+C6XF7DZY6sNyvtid7xDZTnCo6PTSlIRuE6hlLWaEYjN0FJa QZHZN4VmL1j/D8lISjpxP8m67mp4j5Ux7PX99sakNu2W1LMFvHzOs8/AVchlU1Y3ljQC VSw1Y0+MqDjeb+jxJu25PL/JOTazkLEg9BBgsYOxP/Ku+URUaVQXb/Qsm8qETl11rDt7 3ByMkUD/UG6IEcu6i1XPVucPeSgmoPlnRrlzyH6fNDB6XyB+191wE6yWX8eoG9LXMM+K 1wlX/fNZDX/x5ncEwtzVwsx3WY0zhYh8eq24g+4i57pKOxDj1qY842Hnmufe7WceLnzT +EBg== X-Gm-Message-State: AA+aEWY1msfTpapHh0V4oHWdVXZRGSVFzr1opTTwLP3DXT9slvFLSLJB 28YdRFEldv3OXmO7QvYkjQBPgtu7UIcHH4AYyFunC0Wa X-Google-Smtp-Source: AFSGD/UgQB3p3APi2nFvGYZM3srrhYVbW3137VNzXTbFMXGmkUIz8ABdQXkj3cRgmFC11R9TxtIaBeRvxLiX2c+/1ho= X-Received: by 2002:a81:301:: with SMTP id 1mr47014071ywd.185.1546493984783; Wed, 02 Jan 2019 21:39:44 -0800 (PST) MIME-Version: 1.0 From: Carlos Pita Date: Thu, 3 Jan 2019 02:39:33 -0300 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 33959 patch Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (carlosjosepita[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.161.41 listed in list.dnswl.org] 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) tags 33959 patch From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 04 22:36:30 2019 Received: (at 33959) by debbugs.gnu.org; 5 Apr 2019 02:36:30 +0000 Received: from localhost ([127.0.0.1]:44915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCEiU-0006tR-7t for submit@debbugs.gnu.org; Thu, 04 Apr 2019 22:36:30 -0400 Received: from mail-qt1-f179.google.com ([209.85.160.179]:37533) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCEiS-0006tA-3P for 33959@debbugs.gnu.org; Thu, 04 Apr 2019 22:36:28 -0400 Received: by mail-qt1-f179.google.com with SMTP id z16so5793065qtn.4 for <33959@debbugs.gnu.org>; Thu, 04 Apr 2019 19:36:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=hJs1ZL/4POrccxE1LSfdgMPWSLXXMgexkcrl6gwqEDs=; b=biqKm+EwYRthNH9AZTOqIqXX5d/n3g5kjJlMG126QNw6WJ2RmscEWuWWFYakcscPl7 zLqN7vg49Wofa46b3hjXqHj6t/uRx+slPGvnPJO05VrXbCAHZIOishJuT7sNtkrFhrCC lO10nIymGqssE9KBMjqlnQdWsCdYA/rcH4tYy76ePQk5+F9Hm3OnpcAdDOmCD/rswdJm mxP2efrZzQj81cDiIJJZ+kQSuSs7N3w0Y7keNsTEEBvAELwU2+PMbMdHL26Tzav3BwMU 70f0YdoWy3u0F8Ytvmfb05DCJIClPUe+w4swplRDke/IjoDiuf3NRpdiDvybV3hxZ1i+ yeSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=hJs1ZL/4POrccxE1LSfdgMPWSLXXMgexkcrl6gwqEDs=; b=hgYKls+53zlvC8yhV1xf+RcWDR7RTEdvUXTVS6v/pp7g5Xi4uM7Y2mENlESioPGJt3 k2EfIdzopQaoaZU6o7O2K+6XIGboQKuw19AR79GQ1515sUt91jeeA6a+ku81a0oDJsIj 7vmOF5zcJPtNwD0cdKnrNZDUj367xpg1lFkUPhzmM0Cx/9tEBOlwhDtDy3gd2NMQvdF3 o9n+Q9XbDfgWbQgNUccxrb9i5xjyF0e/q2HBQJ1RZ2l1rUntAXSEAUO0oSqYRwN0WVP1 qy+MxWAAQ5/VbyBL4V90fz2F+ZUS5p6Fh128guoWonURPijAMD7eJp+dOKpv+UvWFNKI BTCA== X-Gm-Message-State: APjAAAWG8/Kt6TvSLopC2QAHZN9onTMm8BbMXv+Y8k8CUObtpBcOqivw B+VVkDnrSO+5AotdRKje9ewaUkkw X-Google-Smtp-Source: APXvYqy3QXJ0PoUijRO4BPc4OZgTsC08zVu6V8PT9oLeih4sdBRUZSQKLedTWg56MpU29SMzqQL4eA== X-Received: by 2002:ac8:33ad:: with SMTP id c42mr8852720qtb.318.1554431782407; Thu, 04 Apr 2019 19:36:22 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id p52sm15419264qta.37.2019.04.04.19.36.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Apr 2019 19:36:21 -0700 (PDT) From: Noam Postavsky To: Carlos Pita Subject: Re: bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled References: Date: Thu, 04 Apr 2019 22:36:20 -0400 In-Reply-To: (Carlos Pita's message of "Thu, 3 Jan 2019 02:38:52 -0300") Message-ID: <87zhp5ch5n.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33959 Cc: 33959@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Carlos Pita writes: > Nevertheless I found the origin of the problem. Somehow when company > is enabled in the shell buffer > python-shell-font-lock-comint-output-filter-function is getting empty > strings as output and then the ";; Otherwise just add a newline." > clause is activated. > 1. The first one (Avoid-spurious...) strictly fixes this issue by > moving the not-empty condition to the top and doing everything else > unless not-empty. Period. That works. Hmm, I'm not sure if it's working here. My *Python* buffer looks like this: Python 3.7.0 (default, Sep 15 2018, 19:13:07) Type 'copyright', 'credits' or 'license' for more information IPython 6.5.0 -- An enhanced Interactive Python. Type '?' for help. In [1]: 1 + len('123') + 99 + len('aa') In [13]: 1 + len('123') + 99 + len('aa') Out[13]: 105 In [14]: 1 + len('123') + 99 + len('aa') In [14]: 1 + len('123') + 99 + len('aa') Out[14]: 105 In [15]: 1 + len('123') + 99 + len('aa') In [21]: 1 + len('123') + 99 + len('aa') Out[21]: 105 In [22]: And my " *Python-font-lock*" looks like this: 1 + len('123') + 99 + len('aa') 1 + len( 1 + len('123' 1 + len('123') + 99 + len('aa') The behaviour seems rather inconsistent. I think to solve this properly we need some deterministic tests which reproduce the problem. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 04 22:55:51 2019 Received: (at 33959) by debbugs.gnu.org; 5 Apr 2019 02:55:51 +0000 Received: from localhost ([127.0.0.1]:44921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCF1C-0007N8-VR for submit@debbugs.gnu.org; Thu, 04 Apr 2019 22:55:51 -0400 Received: from mail-qk1-f179.google.com ([209.85.222.179]:37799) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCF1B-0007Mu-5N for 33959@debbugs.gnu.org; Thu, 04 Apr 2019 22:55:49 -0400 Received: by mail-qk1-f179.google.com with SMTP id c1so2999475qkk.4 for <33959@debbugs.gnu.org>; Thu, 04 Apr 2019 19:55:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=WhvDztSkmAtHA+eruuHiOUoVjOybhCtQuvWPmSKG7y8=; b=nw/Xa7kVVMN0WTnPq0pRio/S2iwIVOo49RpTL7vQzzHCONVEw8ZEy3bytZuOp61FQL Po6lpgu5oNKk+67e3KrKnJnIMGMGZNp+d3FhHS8EG+NYaCJquFlOJv+OoZuh6duZ01U0 FX4563vUBI0U/5t2NCUuoT+EEqypH6M1C7vWnkB1azUhentiqwJBlHDleMqdJ9/niFeT fyC0T1eeM27888VgpxjDnuGeQJg976pQRg0F/bs6pvHsbzr+pzh39U0D/k/vkJan3d6b 9BJHYYIkxNhTM1teX2ecP1QHLCAqYnR8I6Zkzbdt7UZmqC0pdfuWXhlndlEjCwfowHc/ cb0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=WhvDztSkmAtHA+eruuHiOUoVjOybhCtQuvWPmSKG7y8=; b=SHhpR1ahg0gNBpG6MbbZBPhDdBMv3k8dv4ae4cJg4eCSkM4htGbPYT07cn+wY6i0Ir GUBeIsBG/1KroD5h7FQftBaI+PYmUBaT62E/RZy3d2hi1UoRqACa7OMfKjC5Zc8JrMwD 6IYNSZtihDyeeIBs3IhYOVwQj3s8WbIDN3B8ep7mO/n1K41/Xrm53GwEPvNz756AdnWw rL/VcodPb9hZ0bFuphMu/EElXvodWwlxZOmWka8IM/GcGlF7dW5OxYZfvFFr5kKz9Mm/ HvAh8OuzhgQG1AH2rHCSBkIl4GDwdeN9gDmJ8yYYPGlgRZSgE0/hYmOR24KryB5DIvoG gZDg== X-Gm-Message-State: APjAAAXKukS1ovZepAKxiMSt1SyCaNQKmD7Y97sGVdFMKhsYUUwMGu9I n+AYmvut755sX19ZUtOTHHQxQeVu X-Google-Smtp-Source: APXvYqzbTP3FHUuM2wDJaW+ssek/RJYDghbf5d3HOWWNzSslldhWNdw1M0f2dNe85gtBgIsrB1twRA== X-Received: by 2002:a05:620a:1334:: with SMTP id p20mr8495898qkj.244.1554432943473; Thu, 04 Apr 2019 19:55:43 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id c18sm11954105qkk.1.2019.04.04.19.55.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Apr 2019 19:55:42 -0700 (PDT) From: Noam Postavsky To: Carlos Pita Subject: Re: bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when eldoc is enabled References: <87h8eq332i.fsf@gmail.com> Date: Thu, 04 Apr 2019 22:55:41 -0400 In-Reply-To: <87h8eq332i.fsf@gmail.com> (Carlos Pita's message of "Wed, 02 Jan 2019 23:08:53 -0300") Message-ID: <87wok9cg9e.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33959 Cc: 33959@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Carlos Pita writes: > Btw, I've submitted a patch for another font lock buffer related bug [1] > a time ago and I might be wrong but I got the impression that python.el > is rather forgotten these days. I wouldn't mind becoming a maintainer at > all, or helping with maintenance, if necessary. Yeah, there's no maintainer for python.el, so maintenance is sporadic at best. I think having one would definitely be a big help. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 16 16:42:50 2019 Received: (at 33959) by debbugs.gnu.org; 16 Apr 2019 20:42:50 +0000 Received: from localhost ([127.0.0.1]:38041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGUuo-0002Uu-6a for submit@debbugs.gnu.org; Tue, 16 Apr 2019 16:42:50 -0400 Received: from mail-yw1-f48.google.com ([209.85.161.48]:33861) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGUuk-0002Ue-LI for 33959@debbugs.gnu.org; Tue, 16 Apr 2019 16:42:47 -0400 Received: by mail-yw1-f48.google.com with SMTP id x129so7834356ywc.1 for <33959@debbugs.gnu.org>; Tue, 16 Apr 2019 13:42:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1yxHL71O+v/xvz7/wD0D+rRr8ebgJT1ahNqcQMl1yQ8=; b=f+MfrliRka1RseFHemmn3vkEWCtYWSNJXtj+DGcpUSG7X/9MKFmBI5iP3DBm44mlVD /pF3rShEQMILBUtocSKpsIgVy9Poqlf8/rmnNO3iAfLCpF0hG9uQBIIRGyRI+nAZ5Z8e fSboFKVNPV6aKO85T4Bx+qDZ359CmIcI736i3Q2e5erQ6ZOrOfueWSXw0+oXLY/a3GPv AzjQoU85Udr1pKm44ZNBNG92UVrpDB66TC4o+EwTfS16cjorOpPIRrwXTFd7QQJfjKdt iVlRlz2MHpDI7Onv4Ra6Fe5w5ADtMhZ+ewnbVSwpqSRlgVODgffS+zmaufZqUfVqWf4/ Q9Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1yxHL71O+v/xvz7/wD0D+rRr8ebgJT1ahNqcQMl1yQ8=; b=N/d1x9fqPmuIul0QHq2ahABxUraeffXQkFY+WozVZMHYkvNPJ6vNqLF/9niafSpy/X bshv7PBwyWlhiwlgdM7vp1DpK1aYx+Jyd2iycWh1xbgt62PsdnmrHsTny7qEsT8GrJt7 rz7ptQ643fwu853Esj2viBIvl9A2rqD9aKmGKT8zX8BkEubEbdjPAlWDbKXZS85xHliQ 5MrsIo9kW2c5rQBUZxB3vS9794MFgLoTAsFqm0CoRtczpSC58FmkxeVNDNAD5fcbBSX+ sJ62f+EpNpc2h4mAXXtJDEdlZ4w/UWMKKPKqDNoxJSeJXaK3vVJY0a5fj15B3xjuRhVZ bk4w== X-Gm-Message-State: APjAAAVCxAn9FvqG/jVX1IUaCvAHrO9AjDAvEiLmsXu8Ozhw2AMovWzo AOffWiWsNfBWYdqo9xmaxkEq+/XCDH0YT8aIlVw= X-Google-Smtp-Source: APXvYqxQJRZ0bcuqAeruqdbypNIOTmvMjBs8+DG5J17nGnhcXeEukV2Bpwry29OpYDt74WDCIDDxbBmaV/MvOM/4hB4= X-Received: by 2002:a81:52c1:: with SMTP id g184mr66185668ywb.341.1555447358830; Tue, 16 Apr 2019 13:42:38 -0700 (PDT) MIME-Version: 1.0 References: <87h8eq332i.fsf@gmail.com> <87wok9cg9e.fsf@gmail.com> In-Reply-To: <87wok9cg9e.fsf@gmail.com> From: Carlos Pita Date: Tue, 16 Apr 2019 17:42:25 -0300 Message-ID: Subject: Re: bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when eldoc is enabled To: Noam Postavsky Content-Type: multipart/alternative; boundary="0000000000004a58180586abcf88" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33959 Cc: 33959@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000004a58180586abcf88 Content-Type: text/plain; charset="UTF-8" Hi Noam, Yeah, there's no maintainer for python.el, so maintenance is sporadic at > best. I think having one would definitely be a big help. > I would like to know your opinion regarding the approach that was suggested near the end of https://github.com/jorgenschaefer/elpy/issues/1531 in order to avoid direct access to python.el yet keep the ability to port changes. Essentially, it consists in keeping a more active drop-in python.el as an external package with periodic updates to core python.el once the changes were more or less tested by real world usage. --0000000000004a58180586abcf88 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Noam,

Yeah, there's no maintainer for python.el, so maintenance is sporadic a= t
best.=C2=A0 I think having one would definitely be a big help.

I would like to know your opinion regarding the app= roach that was suggested near the end of https://github.com/jorgenschaefer/elpy/issues/= 1531 in order to avoid direct access to python.el yet keep the ability = to port changes. Essentially, it consists in keeping a more active drop-in = python.el as an external package with periodic updates to core python.el on= ce the changes were more or less tested by real world usage.
--0000000000004a58180586abcf88-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 16 17:47:39 2019 Received: (at 33959) by debbugs.gnu.org; 16 Apr 2019 21:47:39 +0000 Received: from localhost ([127.0.0.1]:38621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGVvX-0006Qc-GF for submit@debbugs.gnu.org; Tue, 16 Apr 2019 17:47:39 -0400 Received: from mail-yb1-f169.google.com ([209.85.219.169]:39763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGVvV-0006QP-Ln for 33959@debbugs.gnu.org; Tue, 16 Apr 2019 17:47:38 -0400 Received: by mail-yb1-f169.google.com with SMTP id x71so7815695ybe.6 for <33959@debbugs.gnu.org>; Tue, 16 Apr 2019 14:47:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yUhoJtLR1ujtRQZIX74K4/1kUzXIHXExTY5NWBORyj0=; b=qoUCaSJYyH+4dkRKj7IPG/nXFtdfUJxmcP9AMb0ONtr0/DJZx5GjBqNWziMHvUigpK h9Ea9YuSMY/B/+457lCmw+soi6QhHzHoM9IeRfNsckatiOUlw/oy2HWQcKsh45GfGr8N RKsci+PVSafO/8KiiKgIY2dNabnPFoiYCuEe0DpQNDtjsSWQtBKCSqz6bYAkOdBRAEz5 pP8AqxhE38f5ffQQJLqOmwLn19LxWrIogMxvfC8Y0ntK9qsojLBIlq53P4MSq+0Kp+3t MW0snoeNdgE9OLo4dJL+wTLMPUJwXZAz0tTRUMoQOnZLbvXpYrwH8hDlOqAQ/Fc54Rbo UiIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yUhoJtLR1ujtRQZIX74K4/1kUzXIHXExTY5NWBORyj0=; b=lG9rZc3HHE5yrTjYfv80Scz4295ytqclyCQt4eMy677sVhdCaIL0dQSfAb9d/BIklm phrzmkjfpjXDN8RxoflBnZG6cuiISnYANS+tHo7Tr+WPl3sRhJVKZGqSFu2EyYNf/mbg Lnvhen6Mxn/Kj5o0otKpt0y14Ah9dIyWgIjD05bA8FwUlrP3T4CsBJKrvqBjcUmyBsLu /otMI5d6GVQOriuIwUi5cYrjJI/qkldUM5OK+dyWSOoxpmea7NaYxTHy96X3PhOaGcfX VAQMib6xpyKTmohQISiyNBB5RvMildnt/7KHuTL+PKh5xg+yKPIxJc7IHA9fbyCoLlv1 w5lA== X-Gm-Message-State: APjAAAVXa7pQUjCkmucigWi4Cx4YqGfdvY36MlQ0e3CrhewyPgPkBST/ aHoR9tOe8TaADptRaFiTl/M+/liFjgeOrszWP+k= X-Google-Smtp-Source: APXvYqzQcS2yrHL28iT0vY83Xf2yP+ElTmqIzlgmChlfwezhKRzVo6rg0paAMuCFVhaSkT+nNB4DSioCZfCGrAPgris= X-Received: by 2002:a25:c281:: with SMTP id s123mr72030325ybf.401.1555451251993; Tue, 16 Apr 2019 14:47:31 -0700 (PDT) MIME-Version: 1.0 References: <87zhp5ch5n.fsf_-_@gmail.com> In-Reply-To: <87zhp5ch5n.fsf_-_@gmail.com> From: Carlos Pita Date: Tue, 16 Apr 2019 18:47:19 -0300 Message-ID: Subject: Re: bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled To: Noam Postavsky Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33959 Cc: 33959@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Noam, > And my " *Python-font-lock*" looks like this: > > > 1 + len('123') + 99 + len('aa') > > > > 1 + len( > 1 + len('123' > 1 + len('123') + 99 + len('aa') > > The behaviour seems rather inconsistent. I think to solve this properly > we need some deterministic tests which reproduce the problem. The state of your " *Python-font-lock*" buffer is exactly what I mean. The duplications you see are caused by spurious newlines added when empty output is passed to the filter. There are two bad things there: i) empty strings are transformed into new lines and 2) empty strings are an undesirable side effect of company being triggered in a hidden buffer (this is analogous to the problem with org mode hidden buffer and yasnippet that I recently reported). Try disabling company mode in python font lock buffer; even though, this is not necessary if (i) above is fixed, which IMO should be done independently of the nasty company interaction. Besides, remember that patch 2 is fixing two different issues. This is somewhat undesirable but there are a lot of overlapping between them. Nevertheless, I provided patch 1 in case you are unwilling to apply one of them. Best regards -- Carlos From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 16 18:04:10 2019 Received: (at 33959) by debbugs.gnu.org; 16 Apr 2019 22:04:10 +0000 Received: from localhost ([127.0.0.1]:38650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGWBW-0006ps-A3 for submit@debbugs.gnu.org; Tue, 16 Apr 2019 18:04:10 -0400 Received: from mail-qt1-f171.google.com ([209.85.160.171]:32850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGWBV-0006pf-5w for 33959@debbugs.gnu.org; Tue, 16 Apr 2019 18:04:09 -0400 Received: by mail-qt1-f171.google.com with SMTP id k14so25237565qtb.0 for <33959@debbugs.gnu.org>; Tue, 16 Apr 2019 15:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ZHlh2SNi9x73Y2f6iNPeo9sLwYmwin+pkeP7kjS3K8g=; b=OzxftIshY3J97Kd6C2oQRJtSvp5SOQhlQ+7v610gAPC79W9HTtMS24wmC5W7aIdzxF QtSLIv17lVc2V1b7mW/li9KWdmzT/VOh0mzVkeRskfFxs2SIPR5jdYp0vUTWin3FA8Gd LrfRuTxjJj5u+JucLxulvG9+b4Fj703uB5uZAuCCxvFJUYCnLtREAI0vtlmIeGS6LSZx weceocej8erfir1U/EmFrg50ctMF5upxTYAeaN9HQ2KIMpc/3RTjPALaHb0merElzSiH P58lFlHqahQRclL9pByAFZXn9InEkPNM4QQ+yrYpHQaY4Pf+1W+av4WEeUrjIs10/UPP h+Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ZHlh2SNi9x73Y2f6iNPeo9sLwYmwin+pkeP7kjS3K8g=; b=Pf7AV3IfyclU5lWSFrSdiByrdICzRHywkhELcT4fFvGcl37lr7WUOoHeHx7zaqFXaC eztUPQTIv1Gu9bRfUoXXC8KuKFl236Xc5yjSHcL3DZNDGN0FpGrzVW1hbmkRl91+LsUB twKs/sKrjjeikgMfoplBGrzkdCWgb8cTjcC5zhLldKZP3wD/P8xz7ITRXxZCoOUOnahM +iwT0f8dV6gz88zlW+ia4/RUEa8rVUOzT1eESvxGOmkLwAgFkZ5VzXrzSs5bBsAvlvB7 xu60s86uCDRQJNpkXBBnq6rW3Cy8sRO0RePUsFMu+56EKPjFHSxjt5iRJeSYvTp7gSfI N6mg== X-Gm-Message-State: APjAAAVrJtvF6qGoWdoPFO+9T5asuynU1b9pIOsnHQGf8QLQt6y5LBvx tbptmxqFZq20VdqzSdUnj74jopaM X-Google-Smtp-Source: APXvYqwgBlMDkbSCnEzhrxWUbFAOgUExkGbLGx0s1J27h+pCd6/ch7gXsZ1yMn1wSi1N+wcy4QnTsw== X-Received: by 2002:ac8:38f8:: with SMTP id g53mr68778006qtc.221.1555452243611; Tue, 16 Apr 2019 15:04:03 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id h22sm42835907qth.68.2019.04.16.15.04.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Apr 2019 15:04:02 -0700 (PDT) From: Noam Postavsky To: Carlos Pita Subject: Re: bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled References: <87zhp5ch5n.fsf_-_@gmail.com> Date: Tue, 16 Apr 2019 18:04:01 -0400 In-Reply-To: (Carlos Pita's message of "Tue, 16 Apr 2019 18:47:19 -0300") Message-ID: <87pnply5da.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33959 Cc: 33959@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Carlos Pita writes: > Hi Noam, > >> And my " *Python-font-lock*" looks like this: >> >> >> 1 + len('123') + 99 + len('aa') >> >> >> >> 1 + len( >> 1 + len('123' >> 1 + len('123') + 99 + len('aa') >> >> The behaviour seems rather inconsistent. I think to solve this properly >> we need some deterministic tests which reproduce the problem. > > > The state of your " *Python-font-lock*" buffer is exactly what I mean. > The duplications you see are caused by spurious newlines added when > empty output is passed to the filter. There are two bad things there: > i) empty strings are transformed into new lines and 2) empty strings > are an undesirable side effect of company being triggered in a hidden > buffer (this is analogous to the problem with org mode hidden buffer > and yasnippet that I recently reported). Try disabling company mode in > python font lock buffer; even though, this is not necessary if (i) > above is fixed, which IMO should be done independently of the nasty > company interaction. > > Besides, remember that patch 2 is fixing two different issues. This is > somewhat undesirable but there are a lot of overlapping between them. > Nevertheless, I provided patch 1 in case you are unwilling to apply > one of them. The above state happens after I've applied your patch #2. So I can't tell if it fixes anything. That's why I think we need some deterministic tests to show what is fixed and what is broken. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 16 18:08:45 2019 Received: (at 33959) by debbugs.gnu.org; 16 Apr 2019 22:08:45 +0000 Received: from localhost ([127.0.0.1]:38665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGWFw-0006ww-Vl for submit@debbugs.gnu.org; Tue, 16 Apr 2019 18:08:45 -0400 Received: from mail-yw1-f54.google.com ([209.85.161.54]:38922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGWFv-0006wk-Oi for 33959@debbugs.gnu.org; Tue, 16 Apr 2019 18:08:44 -0400 Received: by mail-yw1-f54.google.com with SMTP id z9so7906237ywd.6 for <33959@debbugs.gnu.org>; Tue, 16 Apr 2019 15:08:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ahdOu+dwOBu0mvkZwRsXK8wmXf/B/1Hw5bsKvubGRlk=; b=QyU5IauV1inj32HNJstv3Yf3eKFni5mjnpqNpYD1dsIFw8E7+K7poHjBg5hch21qLv /EPqkw4VcXsvBEzKlDacYUArf5HXVvgMkCd9Gab7Csu6DNX2IM3DV/Whcc3Y/kRfXLbx E4i1k5dsr4LzcgXF+fYur5FEYHsZaWjq1cZxrBwrrwj8EhRdU0hBpcISkHlW9TWBsuVB Gfmo+nb/zoTVF+YvUsw9G+E7gGOr0ABOXOldpbAujylcZR6P37f07we3bpt7Lwaz89a+ GmXxhsBKB0zzHOCI49ipFtlBcNRFK0RE9PumJkSw6rr33edr3LNduuqe2LIyTHkvnRzf Gmeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ahdOu+dwOBu0mvkZwRsXK8wmXf/B/1Hw5bsKvubGRlk=; b=m6zp4O4SmpLdYl8BDnr4e/PjQ3+BAyafrraaVsU3ZGSOyW+FTTrNCnkNUEYhmENm6A YOWqjEX+KOu5RHV3deeqi2mLO4jlHNEJnFJnoPY84W2tVi1Lo5iQX24jcao3IcWWsUy0 1L2NnP2kI9aQwjurDu96Xza40XEbibH/DjrqpHvqcDBt2miQZ+ZGJef0iUDLDEVCwa8+ U2apvt7G7fzniBY0FALY0H2U6xgGMjp2P3CFzzwGCCoSDsRPBlnzO94zPYIYy5CklH2F IpOnaGJ0O8yJWKZ091QJFORnacg9r/4R2uDQP1q7Y1SOoLgEGOdFcVdTc+gTKCiEpnU3 pvZw== X-Gm-Message-State: APjAAAWxJubTpuqs9udYcvJbNqrW4KvA7IEr8+JvBYpHMNsdmC16RmZO WAhY+Vm8QH3R/tyheiQXptQifpIRz9zjJ6Xfr/c= X-Google-Smtp-Source: APXvYqxE39qzwA+J3VnFBEIWZxSdFrMWoL0MdruyfmhBgo0x/RpJE4+u6QmZJy52n8q61knZHc/g5UgWWqweBL1gy5s= X-Received: by 2002:a81:554b:: with SMTP id j72mr67065859ywb.54.1555452518172; Tue, 16 Apr 2019 15:08:38 -0700 (PDT) MIME-Version: 1.0 References: <87zhp5ch5n.fsf_-_@gmail.com> <87pnply5da.fsf@gmail.com> In-Reply-To: <87pnply5da.fsf@gmail.com> From: Carlos Pita Date: Tue, 16 Apr 2019 19:08:26 -0300 Message-ID: Subject: Re: bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled To: Noam Postavsky Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33959 Cc: 33959@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > The above state happens after I've applied your patch #2. Ah, ok! I hadn't understood that was *after* applying the patch. Let me try to reproduce your example then. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 16 18:15:17 2019 Received: (at 33959) by debbugs.gnu.org; 16 Apr 2019 22:15:17 +0000 Received: from localhost ([127.0.0.1]:38682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGWMG-00076z-MP for submit@debbugs.gnu.org; Tue, 16 Apr 2019 18:15:16 -0400 Received: from mail-yb1-f178.google.com ([209.85.219.178]:39577) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGWMC-00076h-UY for 33959@debbugs.gnu.org; Tue, 16 Apr 2019 18:15:15 -0400 Received: by mail-yb1-f178.google.com with SMTP id x71so7840715ybe.6 for <33959@debbugs.gnu.org>; Tue, 16 Apr 2019 15:15:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=StFmofN0tNf6tSbMfz6j87a2oAyxLOchlsDs2Yojs7Y=; b=h3h8s5Uj+YuRlc+u9sbLECvV3jS8zEXP7IddDBUBOf3p5dTbhKJm8xlQi9IN6pswBC j4XQaesiqMJA1L9CifQUQvhctb1AryWXMqaxW7hDh3PrVHiY465bhJ29VtlOliaPuDxb mzjMyQoUaK30Y9ITkblKgFNS25h1pha/rI8ngRABSi3fBq4CKQwL7HYbxSQUjdsSR+DH 7AdgOX0utTu1NlYkDRA1hi9pppJqbe73ohNSMy4AOvkHjS3JuYlHV4NvzHjKYwxNrmPR qmtdVyusg9HKVXtMtGbXBT9HJfyGt2C/aXaj/KlY6P1nIyNu7Cii30AKUGOrzyZA3vTR yHpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=StFmofN0tNf6tSbMfz6j87a2oAyxLOchlsDs2Yojs7Y=; b=Ux2Rs2X459bVVxhYUJUiSUeCXcwH+26QDH++b0SN93A15kUxIXmrZFSjyI8A95uc2F Md7Ewd2gBGQ8S5XVc3YfvI2UiwmznbYkn4+eA/mGBq0KvT5KG9hQfOaV137RqvlMbwjl 2c/prbGU1ma0n2hCMW+tyxl2W6BONba0aO9jKDVhay3wkIRWpnQle4YiNZWfAiTazM8c GvB+cY+yyYhlHc/h6N+0Q38Cw/7xiIU00xFg4z2L/Xxbi6Yjl+N+2AcmJ2L76mojco6D mwMLW7mG1lXYrzkwdLgegfCFKiUMiNlwDPlPS8JPlIGXMm1FjK9SX5mnLPfW9lVJ2zHq QG8g== X-Gm-Message-State: APjAAAWddZxe6ZmDafFpwPJlIFaQNGxA3XUnHvPUSOAIeVjLEXT5e0Wy yHyuVXBWL2hGU6uyFFefoT17YQR5Lxa9+KglkBQ= X-Google-Smtp-Source: APXvYqyHXxmV1Q5glK+xnHaXuc2pmqNXo+hzvx6VPILtu4mZ6zXLTtezA4JwcDUJB58/H1AZs5vo5C+yRoT8R95GS2Y= X-Received: by 2002:a25:850e:: with SMTP id w14mr1547120ybk.13.1555452907340; Tue, 16 Apr 2019 15:15:07 -0700 (PDT) MIME-Version: 1.0 References: <87zhp5ch5n.fsf_-_@gmail.com> <87pnply5da.fsf@gmail.com> In-Reply-To: From: Carlos Pita Date: Tue, 16 Apr 2019 19:14:55 -0300 Message-ID: Subject: Re: bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled To: Noam Postavsky Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33959 Cc: 33959@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I'm unable to get your output, here the font lock buffer always contains one line. Nevertheless, I don't quite understand your example. Here: In [14]: 1 + len('123') + 99 + len('aa') In [14]: 1 + len('123') + 99 + len('aa') Out[14]: 105 How do you manage to have two input lines with the same prompt number? Is that an artifact of copy pasting from the REPL? If it is, if your example just consists of successively sending the line `1 + len('123') + 99 + len('aa')` many times, I'm unable to reproduce the case (after my patch is applied, that is, with this definition (defun python-shell-font-lock-comint-output-filter-function (output) "Clean up the font-lock buffer after any OUTPUT." (unless (string= output "") (if (let ((output (ansi-color-filter-apply output))) (and (python-shell-comint-end-of-output-p output) (not (string-match "\\.\\.\\." output)))) ;; If output ends with an initial (not continuation) input prompt ;; then the font-lock buffer must be cleaned up. (python-shell-font-lock-cleanup-buffer) ;; Otherwise just add a newline. (python-shell-font-lock-with-font-lock-buffer (goto-char (point-max)) (newline))) output)) ) On Tue, Apr 16, 2019 at 7:08 PM Carlos Pita wrote: > > > The above state happens after I've applied your patch #2. > > Ah, ok! I hadn't understood that was *after* applying the patch. Let > me try to reproduce your example then. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 16 19:01:45 2019 Received: (at 33959) by debbugs.gnu.org; 16 Apr 2019 23:01:46 +0000 Received: from localhost ([127.0.0.1]:38732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGX5F-0008DJ-Ir for submit@debbugs.gnu.org; Tue, 16 Apr 2019 19:01:45 -0400 Received: from mail-qt1-f173.google.com ([209.85.160.173]:39512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGX5D-0008D5-0a for 33959@debbugs.gnu.org; Tue, 16 Apr 2019 19:01:43 -0400 Received: by mail-qt1-f173.google.com with SMTP id t28so25342777qte.6 for <33959@debbugs.gnu.org>; Tue, 16 Apr 2019 16:01:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=WTXzLZxrE5F/qQ2WQY3dfVUFILdBS+vKzqjlnlqE2QM=; b=Lt9hVhNoZvQho/whLxV2VJlLuAaORLZP4X0reHCESpn731v+H1Fmyq49MUyfz32gNw zYbzHrA6N/P2LZFykm7lWizyNH5trWIosvV1abub5QY8iXopmOCAhrBL6yB6mzU29XS9 svoSwyN4HulITnWhLPnhdfQqqtgce6wovmDGAjFD0fPY3L5yGKiD0cMexNiHaZrrhvga nVUBLJvKS58X9LxjZs9Y20DuFTykEVNAmA+QvzY/vcfvHeNl+D/+rtw3xl9KsmacgclA uPuUn3ekekfaRY5fuWfhSmAWCJfPrfJTxlaVfIDcYTG8aSylDy7wisp2Z5xiH9hvdjWZ fD3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=WTXzLZxrE5F/qQ2WQY3dfVUFILdBS+vKzqjlnlqE2QM=; b=AYkB4pr9zk/rZTNnEaPoFVR1iD8TFHP40w0ys6hmT874tmn0ScrG6jrl9JJuBloOdR ia9N4Jze6jiw6HiZO3Idb5x6MzqqQUzBAeZ0/IQNg8z1Alj5GEij73CP8VN2HFMs9iPw IQmMTInXzyzF88WA/eQYvEo35uLefa6JuKDxPF8RY+iQhC6YoaXJUY0aPEF2SkHEcO0H U5+JDBUfx7shRPar9fogbUTO1GvW4zPs1kbqrzRhysZSKuq7t6dZ3kP5RH+x0olhiJ5y CN0KgK/oXnk/Md++bWhY9TQXzaOV9nTazPvVRjLx5M8tft1FRqaJF2IiSi3+zcG9JwlB E+ZA== X-Gm-Message-State: APjAAAU7kEjKGIvITtxf3LIKZ0QCF/8xqQyPLhW0l0bucwhdIDnj57th desbHyTGk55jW/foJegb2aGB+RJL X-Google-Smtp-Source: APXvYqx2/c+LMIjeBiWq1M8t8x5zY9e1Pawvj/EsJ4RD86Okz5BoV693A7qybzQ61F3adFg4ph0U7g== X-Received: by 2002:aed:3bc3:: with SMTP id s3mr69439103qte.313.1555455697297; Tue, 16 Apr 2019 16:01:37 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id e15sm26163242qkl.80.2019.04.16.16.01.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Apr 2019 16:01:36 -0700 (PDT) From: Noam Postavsky To: Carlos Pita Subject: Re: bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled References: <87zhp5ch5n.fsf_-_@gmail.com> <87pnply5da.fsf@gmail.com> Date: Tue, 16 Apr 2019 19:01:35 -0400 In-Reply-To: (Carlos Pita's message of "Tue, 16 Apr 2019 19:14:55 -0300") Message-ID: <87mukpy2pc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33959 Cc: 33959@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Carlos Pita writes: > I'm unable to get your output, here the font lock buffer always > contains one line. Hmm, it might have to do with the fact that I'm running ipython over TRAMP, since my main box doesn't have IPython 6.x. But I suspect that only affects the timing, so that it's still theoretically possible (although less likely) for it to happen when running locally. > Nevertheless, I don't quite understand your example. Here: > > In [14]: 1 + len('123') + 99 + len('aa') > In [14]: 1 + len('123') + 99 + len('aa') > Out[14]: 105 > > How do you manage to have two input lines with the same prompt number? I don't know, I didn't realize it was abnormal. As far as I can tell, the prompt number increases by a random amount (sometimes 0) each time I press enter. > Is that an artifact of copy pasting from the REPL? No, that's the real text of my *Python* buffer, unedited. > if your example just consists of successively sending the line `1 + > len('123') + 99 + len('aa')` many times, I'm unable to reproduce the > case (after my patch is applied, that is, with this definition My example consists of successively *typing* the line "1 + len('123') + 99 + len('aa')", it usually takes about 3 tries before I see trouble. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 16 19:51:33 2019 Received: (at 33959) by debbugs.gnu.org; 16 Apr 2019 23:51:33 +0000 Received: from localhost ([127.0.0.1]:38758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGXrQ-0000uG-MP for submit@debbugs.gnu.org; Tue, 16 Apr 2019 19:51:32 -0400 Received: from mail-qt1-f182.google.com ([209.85.160.182]:37619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGXrO-0000u4-VT for 33959@debbugs.gnu.org; Tue, 16 Apr 2019 19:51:31 -0400 Received: by mail-qt1-f182.google.com with SMTP id z16so25472268qtn.4 for <33959@debbugs.gnu.org>; Tue, 16 Apr 2019 16:51:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=fUqQSv9HGWofxnI8xPaR2l9UT+PDMkeiTKIdx6ePSqc=; b=AuEJg0LnvZ6MzvI54i8Bs78sspblOSPd30IPH/OqGGsHAuJtzrIEeIX492srD9qDcC T4R0Hb8r99r57G5+szkd7g2envedc8h5XUa78MRotN19m/TU+3knQ6GMk6Tg+ndXmGGL o4VL/TJvJYxYhLw92nIVQc9MB3TbIZAMqCAC2x7gPMeNJY4pEiu/UY1LgVoBNZtzGf8N XjtZnWLBYQvwrs/S3Qe4tjMWXJMHpvxDDA6DYY8KIl9ityEPQzE2zTjlCNwOJDZDRp8Z k26dcBP3BTU8dgXUuZgvKxbgwzD5DCDGROxg/szolZ/dTuHkiZ/y2/eJcQAvIiG0Yhgv mohQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=fUqQSv9HGWofxnI8xPaR2l9UT+PDMkeiTKIdx6ePSqc=; b=tPc/jK4CCeuqTiuBx9LfDVGGzvWYw0mhWWl/kCNd8UyK7kohYSEt0VUyxBYicg5JvH fofwEKy4VEFu7+wOxWDfYrae77FUpkmfWc8cLKxZKR7KYZLi5xeWPFbWmuShRLMH1rQ6 qvYfLdbZqwdKLbTv7sArAts+24EAPIDa2zpFwBjH8zQiOv/njEFVOkdiuFAoKv3ZRgh0 IG0YpjjrvwPdLcDCVEM47lqJB3bRMEWtK0Y/FPn6/fuVujXS27Hy3uiE4D+qq3TnRIV7 MpWc71MyCFbxUForo2UDz+0+eQp36WP1L2IxB+MuSsciibQel9mw7dlm+lgzu0GwJ8m3 nvVg== X-Gm-Message-State: APjAAAW7Y2oVOvdJQkyweAaAVOkYt/pwKSQMPetGQCai2ON6DQD2Gux1 m3qoUDQ4Jc+KIP6efxp5Re4afxEF X-Google-Smtp-Source: APXvYqxjd/OZx8wtqpNn7i7oI0aEi+N9R8ImPG+5kswYKswp8T3w3trEQHoGL/eeHCOy6DN/qT8hBw== X-Received: by 2002:a0c:92d5:: with SMTP id c21mr70691432qvc.215.1555458685279; Tue, 16 Apr 2019 16:51:25 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id z16sm22649908qti.53.2019.04.16.16.51.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Apr 2019 16:51:23 -0700 (PDT) From: Noam Postavsky To: Carlos Pita Subject: Re: bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled References: <87zhp5ch5n.fsf_-_@gmail.com> <87pnply5da.fsf@gmail.com> <87mukpy2pc.fsf@gmail.com> Date: Tue, 16 Apr 2019 19:51:22 -0400 In-Reply-To: <87mukpy2pc.fsf@gmail.com> (Noam Postavsky's message of "Tue, 16 Apr 2019 19:01:35 -0400") Message-ID: <87k1fty0ed.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33959 Cc: 33959@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Noam Postavsky writes: > Carlos Pita writes: > >> I'm unable to get your output, here the font lock buffer always >> contains one line. > > Hmm, it might have to do with the fact that I'm running ipython over > TRAMP, since my main box doesn't have IPython 6.x. But I suspect that > only affects the timing, so that it's still theoretically possible > (although less likely) for it to happen when running locally. I installed IPython 6.5.0 locally using pip, and I still see the same behaviour (including repeated input prompt numbers). From debbugs-submit-bounces@debbugs.gnu.org Fri May 10 23:51:40 2019 Received: (at 33959) by debbugs.gnu.org; 11 May 2019 03:51:40 +0000 Received: from localhost ([127.0.0.1]:39599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPJ2y-0006em-8i for submit@debbugs.gnu.org; Fri, 10 May 2019 23:51:40 -0400 Received: from mail-it1-f174.google.com ([209.85.166.174]:54724) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPJ2w-0006ea-48 for 33959@debbugs.gnu.org; Fri, 10 May 2019 23:51:38 -0400 Received: by mail-it1-f174.google.com with SMTP id a190so12511700ite.4 for <33959@debbugs.gnu.org>; Fri, 10 May 2019 20:51:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=YQi3oA9cbWy/caS3IQNdKKZBjy5zS3VRUtgD+dfgGMc=; b=Ux7r5gGm2ZTwUcUGdOelQBHprhXPyTA+N1P5z2PJGwq/eBOVO4MWVfwb7+xOIlml/r CaDke59pyllyb7TBA93+aUgvo9+H8SOqAQRgiHNhcLgvb1QEA0npe+IGk6EEKytCTuK4 3zr+lyClGyyGSA/rMXkChZ2ct0fNEdOjLONN3SSpECr++kUo/wf72HROu548VSwdfeAy Huu81BQqRrOMHF7j+sSW6fmoMpqooCN6YdO5yOVO3Sb4IdRLyPwNZgivUF7aUnVOfLt5 8i1oAXz8hhEkoC30cplHXPChCpcwJK1G8HC1lXn/pZxpjwBgjXc18UsNPSg47xjGKdgu 23lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=YQi3oA9cbWy/caS3IQNdKKZBjy5zS3VRUtgD+dfgGMc=; b=KuvGesLV4/d1jizWawj7YtiD3nMzOU+7KFTRc+7v2GgXFehqP81AJObaLjlNdQCB/T kxKNPfUjiSpiL3wjpC7wFPoe7nOScXa8t+25PnPeP1+ngyxfP8N5EtO+/wDGTVVigKes B6RpXOk0Dtxu0ua7PbT7FY7MwflSe4BwO+5C0gc24BKS4VKlg7UApvxjBGwhZBTFU02o wG+UBBhEovSpyVbRRudm3RINzrrIUt1roW2Vnb73tS75q+XH6rkGcEcnwO/gAGJhgiuI CXcrUxE6IdxUDgkckraBbCTPucvbWH7gT330TXWkIUb/GRIqeXttDEsWaYAnDnX03Jt0 mW8w== X-Gm-Message-State: APjAAAXMM0/Fw8l4v7f4DG7N1G/kePK4j6fHDE2i+CdyE+bFl2YrdRn1 uFWqMA11xwtp4Q28JLz7DEgIt5z8 X-Google-Smtp-Source: APXvYqwDDpsAhrONd5UCYnbOAaKHk//2z4qaejI8SdGQPlafb8devWYRhh3XlgXbVY05S+OSFh9fCA== X-Received: by 2002:a24:920a:: with SMTP id l10mr9635771itd.98.1557546692199; Fri, 10 May 2019 20:51:32 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id k197sm3582106itk.36.2019.05.10.20.51.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 10 May 2019 20:51:31 -0700 (PDT) From: Noam Postavsky To: Carlos Pita Subject: Re: bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled References: <87zhp5ch5n.fsf_-_@gmail.com> <87pnply5da.fsf@gmail.com> <87mukpy2pc.fsf@gmail.com> <87k1fty0ed.fsf@gmail.com> Date: Fri, 10 May 2019 23:51:30 -0400 In-Reply-To: <87k1fty0ed.fsf@gmail.com> (Noam Postavsky's message of "Tue, 16 Apr 2019 19:51:22 -0400") Message-ID: <87y33dir7h.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33959 Cc: 33959@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Noam Postavsky writes: > Noam Postavsky writes: > >> Carlos Pita writes: >> >>> I'm unable to get your output, here the font lock buffer always >>> contains one line. >> >> Hmm, it might have to do with the fact that I'm running ipython over >> TRAMP, since my main box doesn't have IPython 6.x. But I suspect that >> only affects the timing, so that it's still theoretically possible >> (although less likely) for it to happen when running locally. > > I installed IPython 6.5.0 locally using pip, and I still see the same > behaviour (including repeated input prompt numbers). I think I figured out what the difference is: I forgot to add --simple-prompt to python-shell-interpreter-args. After doing that, your patch does indeed fix the problem. I'd still like a deterministic test, though, since this bug is such a pain to reproduce. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 13 15:39:57 2019 Received: (at 33959) by debbugs.gnu.org; 13 Oct 2019 19:39:57 +0000 Received: from localhost ([127.0.0.1]:37050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJjif-0002HP-2r for submit@debbugs.gnu.org; Sun, 13 Oct 2019 15:39:57 -0400 Received: from mail-yw1-f48.google.com ([209.85.161.48]:43716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJjic-0002H6-Q1 for 33959@debbugs.gnu.org; Sun, 13 Oct 2019 15:39:55 -0400 Received: by mail-yw1-f48.google.com with SMTP id q7so5406882ywe.10 for <33959@debbugs.gnu.org>; Sun, 13 Oct 2019 12:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=QemE9b2sd0mWzKrf9bPZ+3XUVv4jbBV8aIGumj/JsI8=; b=Je4Aq2lKVFxea5qxp/tIRaruT/EH8FhI15Unirlf+LjHRXo5PVZDFq7x9s/soFsM+s wNEM/gkAgLygRTGh7cpv+YpcCiMZzZqmudYehH319/dokD6z0tlo/Mz0VMLl4C8S+v1I Ydguo/oAjboDlkhARCzDuet3uQ8MSlJ69e2PaLEAcsqRg++mN8g+zjC7ZKHaBiavc/fW i9ajskv0VAuNeVMv8vcNjBWEi+fjLqwmxDlnfX6ZXVGghEHu05dd/9zaJs9aA0LMneew c/ki9D5DPRzqbZepL+TUV9uPAlkY4hcONx6qE7ycR4Dg41EVAVEf6taUzVUdHG+8jmw+ xJiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=QemE9b2sd0mWzKrf9bPZ+3XUVv4jbBV8aIGumj/JsI8=; b=aucak/6ZZtDfY4QkTBYzJUxC+gbS1LFW4BXGAdfJXVV84BTl22rCtK+I7eOIXmFBbQ 8STc3suwDnNXr9aPANjBTzqFiC28uWE1ljjXp1MtMI9TC7MIq5ciSqy+tt3yAvFbxKqV viCnJj8wEKYgGiBlDzbShYvU18YUGX40W5JU8COdhKeUcIBHBHjmb3EMhOFsSFEbxXUv c/+vsPzKaKAbuBNTbZq3UWbOdWfOGAFY0sJyN+MUseW2hSq3ah+3qA4vj1XCbPmD3qPu cIzWDN2hvuCHau9gXRmPG02kzEKatTfqmcbY7kw+dhTSfts+Ydfr+sawTQojRO4G6krd 1goA== X-Gm-Message-State: APjAAAUEMiL44zV7v2ud6qOt3wQxyt08i9Gt1wYFaZG0dc5eq6ndYe79 Fpv7WdIYSKqq8s6/DxBmnCKsYyrNV82Vc39KNE+zV5Vaymg= X-Google-Smtp-Source: APXvYqx571W2TP3f/8Uxd8jf7WhfAsfObjfOHPR4MRP/O2tztkDz7+VlkdmeDf46KUQso73DDGGmZHxbkEjjRrlYeqU= X-Received: by 2002:a81:ab42:: with SMTP id d2mr10394239ywk.64.1570995588995; Sun, 13 Oct 2019 12:39:48 -0700 (PDT) MIME-Version: 1.0 From: Carlos Pita Date: Sun, 13 Oct 2019 16:39:38 -0300 Message-ID: Subject: To: 33959@debbugs.gnu.org, Noam Postavsky Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Noam I'd like to get this merged (because my local patch queue is getting too big :P ) > I'd still like a deterministic test, though, since this bug is such a pain to reproduce. I'm not quite understanding what do you want me to do. I don't think there is a suite of unit tests to prevent regressions in python.el and you can't reasonably expect me to write that entire suite ju [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (carlosjosepita[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.161.48 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.161.48 listed in list.dnswl.org] 2.0 BLANK_SUBJECT Subject is present but empty 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 33959 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Noam I'd like to get this merged (because my local patch queue is getting too big :P ) > I'd still like a deterministic test, though, since this bug is such a pain to reproduce. I'm not quite understanding what do you want me to do. I don't think there is a suite of unit tests to prevent regressions in python.el and you can't reasonably expect me to write that entire suite just to get this minor patch accepted, so I figure you're after another thing here. Do you want very explicit instructions that ensure reproducibility of the issue, is that it? Best regards -- Carlos From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 13 15:44:24 2019 Received: (at 33959) by debbugs.gnu.org; 13 Oct 2019 19:44:24 +0000 Received: from localhost ([127.0.0.1]:37066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJjmy-0002QH-74 for submit@debbugs.gnu.org; Sun, 13 Oct 2019 15:44:24 -0400 Received: from quimby.gnus.org ([80.91.231.51]:37170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJjmw-0002Q9-92 for 33959@debbugs.gnu.org; Sun, 13 Oct 2019 15:44:22 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iJjms-0004en-WF; Sun, 13 Oct 2019 21:44:21 +0200 From: Lars Ingebrigtsen To: Carlos Pita Subject: Re: bug#33959: References: <87h8eq332i.fsf@gmail.com> Date: Sun, 13 Oct 2019 21:44:18 +0200 In-Reply-To: (Carlos Pita's message of "Sun, 13 Oct 2019 16:39:38 -0300") Message-ID: <87zhi48m7h.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Carlos, you seem to be dropping the text from all the Subject headers in the emails you're sending, leaving just the bug number. This makes it difficult to remember what the patches are about, because [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33959 Cc: Noam Postavsky , 33959@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Carlos, you seem to be dropping the text from all the Subject headers in the emails you're sending, leaving just the bug number. This makes it difficult to remember what the patches are about, because you have to open up the bug report to do so. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 13 15:51:27 2019 Received: (at 33959) by debbugs.gnu.org; 13 Oct 2019 19:51:27 +0000 Received: from localhost ([127.0.0.1]:37087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJjtn-0004fq-8X for submit@debbugs.gnu.org; Sun, 13 Oct 2019 15:51:27 -0400 Received: from mail-yb1-f176.google.com ([209.85.219.176]:46712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJjtl-0004fb-5J for 33959@debbugs.gnu.org; Sun, 13 Oct 2019 15:51:25 -0400 Received: by mail-yb1-f176.google.com with SMTP id h202so4783007ybg.13 for <33959@debbugs.gnu.org>; Sun, 13 Oct 2019 12:51:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3ecVsZ3yvbGU6KdnU9zdhPhpPT58o5pb1RUpaelXqzI=; b=iV2bKLVkWLyCHk5q0etX7uKKqryJyc2v5dBvXp5ikocYV9pks4HjcPL6Bdnn7zr94n Kbh3d+0P05SRTfIC9qX3SbALNxYA2Fp1B7qOT8MLoTxI68AU7BOBGi3SsCusxQpHchcK PL5I4hjSsC67AAoW+YcZ4E4kSYfLvzGNu7uMTuGEJIuT5W7v0BfJUFOCnmeZhD6Bsj9d XofRCqJOXKCc8xPOYMe6nkXNccc9o1J5RGMQ3vqIqnYdm6zPdWbUS+WH9Dl1OBwLQz9/ i7/fnYBB2mQ6iVhp+5hwnJIGitgwHBG6Q/KBBghhPYh4xwp87HqvYS6KibX5Yc+wHsoi w/IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3ecVsZ3yvbGU6KdnU9zdhPhpPT58o5pb1RUpaelXqzI=; b=NsuPT/LUijTlXqHRnp8Gb2jri8evifRFfX8Li6HUVZT0SnsKsqFryz0T/1FLQOXErh hW98BYQI07JX/HY3mxKhfQ+n5JTOheDwFaMy11vfvyI5R8J6LHIaT4R2RNgrpHHlF9+y 4Y8iePdYOXJUNswRIuuuKkelDhh5hVMNz+L5bU4gQlG8+G8gf7EMIiq/r8Sh9FdsV12Q JEy+mYZjxpcYvxYhBZU9hsqjfIjSmO1DML9JucOAwxZh1hVLWKAYCQ1XEeLnHEdikK+H E77odcYh/4iEmiyEnZRXBDoc8PzWTCiem+/s6+KhZJLj5ARC3TR6VU8N4W/KWQnIsLFv CU4Q== X-Gm-Message-State: APjAAAWLj8uAKH+WjF5B6oW6fiecBhxsNcrUByNIbGWJSRQr0ZTEUe/K pVWmZ67jp2KTZf2F19aUZRuXNoLir49IzTdit0s= X-Google-Smtp-Source: APXvYqx+lwQLKUZIhD6W/4zZ4252/T+aMOrPH2LA504WiPjWgIsoRBHBJ+U7HDe9VPJMjed7hsmO0Hu0SRFpJoBGCsc= X-Received: by 2002:a25:42:: with SMTP id 63mr17314853yba.454.1570996279520; Sun, 13 Oct 2019 12:51:19 -0700 (PDT) MIME-Version: 1.0 References: <87h8eq332i.fsf@gmail.com> <87zhi48m7h.fsf@gnus.org> In-Reply-To: <87zhi48m7h.fsf@gnus.org> From: Carlos Pita Date: Sun, 13 Oct 2019 16:51:07 -0300 Message-ID: Subject: Re: bug#33959: To: Lars Ingebrigtsen Content-Type: multipart/alternative; boundary="0000000000002f31d50594d013cc" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33959 Cc: Noam Postavsky , 33959@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000002f31d50594d013cc Content-Type: text/plain; charset="UTF-8" Ah, ok, sorry, I don't have the old threads in my account anymore and thought debbugs would take care of that, but you're right that CCs will get an empty subject, my bad, sorry again. --0000000000002f31d50594d013cc Content-Type: text/html; charset="UTF-8"
Ah, ok, sorry, I don't have the old threads in my account anymore and thought debbugs would take care of that, but you're right that CCs will get an empty subject, my bad, sorry again.
--0000000000002f31d50594d013cc-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 14 20:34:32 2019 Received: (at 33959) by debbugs.gnu.org; 15 Oct 2019 00:34:32 +0000 Received: from localhost ([127.0.0.1]:42454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKAnG-0001XA-N0 for submit@debbugs.gnu.org; Mon, 14 Oct 2019 20:34:30 -0400 Received: from mail-io1-f46.google.com ([209.85.166.46]:34164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKAnF-0001Wu-8g for 33959@debbugs.gnu.org; Mon, 14 Oct 2019 20:34:29 -0400 Received: by mail-io1-f46.google.com with SMTP id q1so42026852ion.1 for <33959@debbugs.gnu.org>; Mon, 14 Oct 2019 17:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=CIdXHl6zTUW8Kr5HcChUD/FeZBZu5XaOzxDWh/PHLx0=; b=PqEA/1jqahrdmcAcEtph0uCJ5teWkc9KpLXlnmYGc9dfU2LV7MMaymy62W9NYo7HVd R4oKBMMCMLsTnB3tpLnv8v0JB46T1qKie/HMbLqNP4HN9Dk+oDgoul55GhAqJPbBjg6P jMbkE0tQ6ZzmTji+TjnohySifNwzC0OSlR+fiyBjhaqWK70a7wpZLX5gvohUF6q89SCl g3pcaZybcsClKvblbNTVKIx16mwSlhHYjA5sJqd1ZKwmrTwYo0ZegXGMLVyRGF1DC7YZ 6kqKoA4Fu9dOR/uTmPbfXBTdD87KCJo8srMACR8k+NK6xxW7KVPMonKGci5b+W7+5axX iQUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=CIdXHl6zTUW8Kr5HcChUD/FeZBZu5XaOzxDWh/PHLx0=; b=gd82PFulWUlVuvYuGgv6MdWLkATXyqQMouC+zU/RVVpFSXRuz/V4T8XygWdnXqGat+ Mw2rG0lxnAT4C4moy3nltiSC25oLhutaShNblrY04Bpou3CUS/q0ou03aHtCV14mwi5H fBBMA9CzB7ejknoGeJ5RCd5+kwljOkNmtRlqojk4bAX1zjmRZuW8txiZDrFx1pfxZWKi rmCa0C7eSGKO33z3JLgGPfJl87I0iHWFFZOpMm1bEJjbQPOjhQa4eP3Cuv/Gk8ruhVoN TiY3U/mQwMB/2IBij0BizZCE/0IUaUh7QrJ+figA9P3dwsGHLqhjlktEorTPoRQ7F5ss AyhA== X-Gm-Message-State: APjAAAUil3dZtlLu8OIaiF9+MhgJ13ZR+tquXxhuwzHfwwL2WpZraL+v 39z88zr05iyx5L/nECfUQQubhuap X-Google-Smtp-Source: APXvYqzxjIkg684mFco1kyL6kF34OS9qRsAZE9z2q+rk+z647awMfHE1Ws4m9r8oPO/F+C4uhbFpRw== X-Received: by 2002:a92:3bdc:: with SMTP id n89mr3200566ilh.219.1571099663436; Mon, 14 Oct 2019 17:34:23 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id w5sm2300696ila.75.2019.10.14.17.34.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Oct 2019 17:34:22 -0700 (PDT) From: Noam Postavsky To: Carlos Pita Subject: Re: bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled References: <87h8eq332i.fsf@gmail.com> Date: Mon, 14 Oct 2019 20:34:21 -0400 In-Reply-To: (Carlos Pita's message of "Sun, 13 Oct 2019 16:39:38 -0300") Message-ID: <87h84a6e42.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33959 Cc: 33959@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Carlos Pita writes: > Noam I'd like to get this merged (because my local patch queue is > getting too big :P ) Heh, I know the feeling :) >> I'd still like a deterministic test, though, since this bug is such a pain to reproduce. > > I'm not quite understanding what do you want me to do. I don't think > there is a suite of unit tests to prevent regressions in python.el Well, test/lisp/progmodes/python-tests.el exists, so yes there is? > you can't reasonably expect me to write that entire suite just to get > this minor patch accepted, so I figure you're after another thing > here. Do you want very explicit instructions that ensure > reproducibility of the issue, is that it? Mainly I've been hesitant to apply this patch because I don't understand why it works. It kind of looks like it might just be papering over some subtle problems (similar to fixing a race condition by adding a sleep call). And also the overlap with the Bug#32390 fix made things more confusing; now that I've pushed it, at least that problem is gone. Writing a regression test would be one way of showing where exactly the problem comes from, and would help understand why the solution is correct. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 14 20:52:23 2019 Received: (at 33959) by debbugs.gnu.org; 15 Oct 2019 00:52:23 +0000 Received: from localhost ([127.0.0.1]:42471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKB4Y-000224-VQ for submit@debbugs.gnu.org; Mon, 14 Oct 2019 20:52:23 -0400 Received: from mail-yw1-f53.google.com ([209.85.161.53]:38143) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKB4W-00021k-SN for 33959@debbugs.gnu.org; Mon, 14 Oct 2019 20:52:21 -0400 Received: by mail-yw1-f53.google.com with SMTP id s6so6739279ywe.5 for <33959@debbugs.gnu.org>; Mon, 14 Oct 2019 17:52:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=acLd5Y4eXnIzCYqF6qfDloyZ9ngJd8mOGlY4h8g0MwE=; b=YobOevRZlfLDBkB8m8v8NcqPYNDhcES1rNYvkcEqWmaYacML8usqPRHv6BwEg+GU8L HxdrZLzMRbp4/Ahad68gUbezAhIwzsTNto8TQhbo2bZV4vRGm2PrvUXAnN8gdWIsplLx 5nd2jqXQMvV9Iq97k4yGVHMoeAOLo1pUhv2CPyLdPmiKssEkSblH2LFLBpP95G8Cx6ay +0tfeeUzxiPzRaaoSu9L5w/faUopm0FCWMIaIXxYrFwgGvOFKjvqUoCOlYs/jb50txaQ vYXcNmoPh7b0veTYJC7e2zEFpogcLTC+xBa1oZ2wRRYBoJwcRLt84ejHZdaRk2QQUgnw tezw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=acLd5Y4eXnIzCYqF6qfDloyZ9ngJd8mOGlY4h8g0MwE=; b=akCEDbIa1pCEq7MQscPywsi6puGdrkO8ReESoMxMvmW0GwyjHrr/4lnKZcUEmYoSYk VTp9yPr0+dj2szVxFjGcYD9/RQd/MkIGCSgOVTCV4GnXaXK7Zz1edoqjFIHr62iXF6vu YMI5CwE4djHWyRwZfAAxMX1jxGB5dBYK3w552b07S6onxhU6sHPDh8/cnlxEBg0Q9B9s v2qWbuh1CuS6kH7oS3Y3xJ+6nwvAb/6xXIbt8Wv7Yb2xHuYT9o2ie6VRenbOp6e2TQxp +EfYxkzFIiHidDt2aD03Bqwfys6RgXUtUTnTOeOQEv9AWNWvCktAnXZ31gD/HiQj98Ka z3ag== X-Gm-Message-State: APjAAAVuyPxLtIp5HRlJmcXCpSZ7m/NlRnp2Nux9+NzokrAeHzKuSxD0 HVu4tmu761QgVsprXwyXGpUn5jt4zY/5OagGeqQ= X-Google-Smtp-Source: APXvYqww4DXr6T3FSTOXnDfQhwvty0ZgshmIYbBsbx/dJvNu39+Xj9wlPQr9aDcGG+ZNsD9Uji+SGgBLWEly3cl9CMw= X-Received: by 2002:a81:57d4:: with SMTP id l203mr13923788ywb.277.1571100735129; Mon, 14 Oct 2019 17:52:15 -0700 (PDT) MIME-Version: 1.0 References: <87h8eq332i.fsf@gmail.com> <87h84a6e42.fsf_-_@gmail.com> In-Reply-To: <87h84a6e42.fsf_-_@gmail.com> From: Carlos Pita Date: Mon, 14 Oct 2019 21:52:03 -0300 Message-ID: Subject: Re: bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled To: Noam Postavsky Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33959 Cc: 33959@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > And also the overlap with the Bug#32390 fix made things more > confusing; now that I've pushed it, at least that problem is gone. I'm in the process of creating a patch for this that applies on top of your recent commit and it's just wrapping everything into: (unless (string= output "") ... ) So I believe that if you already bought to other one this is way easier to buy :) Even without further digging into the specifics of the issue, I'd advanced an argument for adding that guard: > No matter the reason why empty output is being passed to the filter, > it's wrong for the filter to add a new line to the font lock buffer if > this happens. And the check for empty output was always there, but in conjunction with a check for "just a prompt": (if (and (not (string= "" output)) (not just-a-prompt)) do-something add-a-newline) I think it's clear this logic is faulty. Both an empty output and a just-a-prompt output are reasons not to do-something. But only just-a-prompt is a reason to add-a-newline. Have I been persuasive enough now :) ? From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 14 20:58:25 2019 Received: (at 33959) by debbugs.gnu.org; 15 Oct 2019 00:58:25 +0000 Received: from localhost ([127.0.0.1]:42475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKBAP-0002Aj-2I for submit@debbugs.gnu.org; Mon, 14 Oct 2019 20:58:25 -0400 Received: from mail-yw1-f54.google.com ([209.85.161.54]:45755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKBAM-0002AP-Sv for 33959@debbugs.gnu.org; Mon, 14 Oct 2019 20:58:23 -0400 Received: by mail-yw1-f54.google.com with SMTP id x65so6734701ywf.12 for <33959@debbugs.gnu.org>; Mon, 14 Oct 2019 17:58:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NZKFNnYituNmW5YsY5nU6XNG0RQZ3oxOdocM0JWyKu4=; b=qRzpAYU2WAy01QQPQ6Pz44lMHiEHv5rTZHxa47R8zp3tY8iO2+CIWQv+oFZrWb69e1 UsX/h6rqqzmUBXYrwo6b9ZpNY03srJbdTxEb+/DGm9pjj1YKbHMqvvCFi8GBCRSdKgc0 BPP8D17DguBuwIPgeWUhW+DGl8fNSEQHZ5pw/1nrA15SUXz+sIk+ghh+EbGmrshWSoJf 5f/RNK7juvAouvIMeQUpAaEJBrUHJ+JHjvDvkQyb0Onedvh9xcquLKOcTo0CM4wMfMji egLlnpgyUA5M/hJ4Pg07evGrPcAFW8dHo2cQfzlU6GvL7Lp4r/GfqOZZvmaJL5nZlc4C vreA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NZKFNnYituNmW5YsY5nU6XNG0RQZ3oxOdocM0JWyKu4=; b=nr2yjNBSfySAG2IHwk4PZSY7wgPaNiPvJPvmslfQylwEgM+TzhvYSr4c2V/FmK8kEq SB5LONCjsD1x4bf7as8dlVAuifW96kS9Tsj4G3APmLSlpuAA0qFluAWlWHzN/j4cx5BD IgXnAIy192O9b9wdIWZXoaYhZs9OM0C0uo4Tp7Z15CPzyOZjn6y6hwDyEtq/FKadgE30 nQD/I7HcPsE6Sg+WkJm0uqoX/OlOVlW9xNmdUDJn+pH6Iw33kiZ81iuOX0KHfwlMGCeL JhDFa4Zue3SehT4utbnQS+Sqrg6Y052J/fG4MLdkhpTkPCt8lruCmUqLmfnv8d1ZX97a PArw== X-Gm-Message-State: APjAAAVRMPiyvyciDlT7b6lKIUHO8abI6EWtQlGloQNl7FDS9dZJxs2L gP5jk+RtkuK0D8SuTYPWpsJcjyHo9g0rw5C/P5U= X-Google-Smtp-Source: APXvYqyiZOEPmyakWsodhFUa3x4AjPBt1RkBvswYM1soe7S30phpi2Alr6f0sK7q/gJaCTSTmFI74i111HRwIaKXPis= X-Received: by 2002:a81:b616:: with SMTP id u22mr15003490ywh.80.1571101097238; Mon, 14 Oct 2019 17:58:17 -0700 (PDT) MIME-Version: 1.0 References: <87h8eq332i.fsf@gmail.com> <87h84a6e42.fsf_-_@gmail.com> In-Reply-To: From: Carlos Pita Date: Mon, 14 Oct 2019 21:58:06 -0300 Message-ID: Subject: Re: bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled To: Noam Postavsky Content-Type: multipart/mixed; boundary="000000000000cece410594e87a2b" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33959 Cc: 33959@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000cece410594e87a2b Content-Type: text/plain; charset="UTF-8" This should cleanly apply on top of the one you recently merged. --000000000000cece410594e87a2b Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Avoid-spurious-empty-lines-in-font-lock-buffer-fixes.patch" Content-Disposition: attachment; filename="0001-Avoid-spurious-empty-lines-in-font-lock-buffer-fixes.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k1r5010l0 RnJvbSA1ZDMxM2IwYmIxMWVjN2FjZThhYjZiM2NlZTdhYWMzMzQ1YWE0NjkyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBtZW1lcGxleCA8Y2FybG9zam9zZXBpdGFAZ21haWwuY29tPgpE YXRlOiBNb24sIDE0IE9jdCAyMDE5IDIxOjM3OjIwIC0wMzAwClN1YmplY3Q6IFtQQVRDSF0gQXZv aWQgc3B1cmlvdXMgZW1wdHkgbGluZXMgaW4gZm9udCBsb2NrIGJ1ZmZlciwgZml4ZXMgIzMzOTU5 CgoqIGxpc3AvcHJvZ21vZGVzL3B5dGhvbi5lbDogYWRkIGNsYXVzZSB0byBhdm9pZCB3cml0aW5n IGEgbmV3bGluZSB0byB0aGUKICBmb250IGxvY2sgYnVmZmVyIHdoZW4gYW4gZW1wdHkgc3RyaW5n IGlzIHJlY2VpdmVkIGFzIG91dHB1dC4KLS0tCiBsaXNwL3Byb2dtb2Rlcy9weXRob24uZWwgfCAy NSArKysrKysrKysrKysrLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTMgaW5zZXJ0aW9u cygrKSwgMTIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvcHl0aG9u LmVsIGIvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsCmluZGV4IGIxNjhiNjIuLjg2YTgwOWIgMTAw NjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL3B5dGhvbi5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9w eXRob24uZWwKQEAgLTI2MDAsMTggKzI2MDAsMTkgQEAgcHl0aG9uLXNoZWxsLWZvbnQtbG9jay1j bGVhbnVwLWJ1ZmZlcgogCiAoZGVmdW4gcHl0aG9uLXNoZWxsLWZvbnQtbG9jay1jb21pbnQtb3V0 cHV0LWZpbHRlci1mdW5jdGlvbiAob3V0cHV0KQogICAiQ2xlYW4gdXAgdGhlIGZvbnQtbG9jayBi dWZmZXIgYWZ0ZXIgYW55IE9VVFBVVC4iCi0gIChpZiAobGV0ICgob3V0cHV0IChhbnNpLWNvbG9y LWZpbHRlci1hcHBseSBvdXRwdXQpKSkKLSAgICAgICAgKGFuZCAocHl0aG9uLXNoZWxsLWNvbWlu dC1lbmQtb2Ytb3V0cHV0LXAgb3V0cHV0KQotICAgICAgICAgICAgIDs7IEFzc3VtZSAiLi4uIiBy ZXByZXNlbnRzIGEgY29udGludWF0aW9uIHByb21wdC4KLSAgICAgICAgICAgICAobm90IChzdHJp bmctbWF0Y2ggIlxcLlxcLlxcLiIgb3V0cHV0KSkpKQotICAgICAgOzsgSWYgb3V0cHV0IGVuZHMg d2l0aCBhbiBpbml0aWFsIChub3QgY29udGludWF0aW9uKSBpbnB1dCBwcm9tcHQKLSAgICAgIDs7 IHRoZW4gdGhlIGZvbnQtbG9jayBidWZmZXIgbXVzdCBiZSBjbGVhbmVkIHVwLgotICAgICAgKHB5 dGhvbi1zaGVsbC1mb250LWxvY2stY2xlYW51cC1idWZmZXIpCi0gICAgOzsgT3RoZXJ3aXNlIGp1 c3QgYWRkIGEgbmV3bGluZS4KLSAgICAocHl0aG9uLXNoZWxsLWZvbnQtbG9jay13aXRoLWZvbnQt bG9jay1idWZmZXIKLSAgICAgIChnb3RvLWNoYXIgKHBvaW50LW1heCkpCi0gICAgICAobmV3bGlu ZSkpKQotICBvdXRwdXQpCisgICAodW5sZXNzIChzdHJpbmc9IG91dHB1dCAiIikKKyAgICAoaWYg KGxldCAoKG91dHB1dCAoYW5zaS1jb2xvci1maWx0ZXItYXBwbHkgb3V0cHV0KSkpCisgICAgICAg ICAgKGFuZCAocHl0aG9uLXNoZWxsLWNvbWludC1lbmQtb2Ytb3V0cHV0LXAgb3V0cHV0KQorICAg ICAgICAgICAgICAgOzsgQXNzdW1lICIuLi4iIHJlcHJlc2VudHMgYSBjb250aW51YXRpb24gcHJv bXB0LgorICAgICAgICAgICAgICAgKG5vdCAoc3RyaW5nLW1hdGNoICJcXC5cXC5cXC4iIG91dHB1 dCkpKSkKKyAgICAgICAgOzsgSWYgb3V0cHV0IGVuZHMgd2l0aCBhbiBpbml0aWFsIChub3QgY29u dGludWF0aW9uKSBpbnB1dCBwcm9tcHQKKyAgICAgICAgOzsgdGhlbiB0aGUgZm9udC1sb2NrIGJ1 ZmZlciBtdXN0IGJlIGNsZWFuZWQgdXAuCisgICAgICAgIChweXRob24tc2hlbGwtZm9udC1sb2Nr LWNsZWFudXAtYnVmZmVyKQorICAgICAgOzsgT3RoZXJ3aXNlIGp1c3QgYWRkIGEgbmV3bGluZS4K KyAgICAgIChweXRob24tc2hlbGwtZm9udC1sb2NrLXdpdGgtZm9udC1sb2NrLWJ1ZmZlcgorICAg ICAgICAoZ290by1jaGFyIChwb2ludC1tYXgpKQorICAgICAgICAobmV3bGluZSkpKQorICAgIG91 dHB1dCkpCiAKIChkZWZ1biBweXRob24tc2hlbGwtZm9udC1sb2NrLXBvc3QtY29tbWFuZC1ob29r ICgpCiAgICJGb250aWZpZXMgY3VycmVudCBsaW5lIGluIHNoZWxsIGJ1ZmZlci4iCi0tIAoyLjIw LjEKCg== --000000000000cece410594e87a2b-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 16 16:36:01 2019 Received: (at 33959) by debbugs.gnu.org; 16 Oct 2019 20:36:02 +0000 Received: from localhost ([127.0.0.1]:46666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKq1Z-0002SK-IS for submit@debbugs.gnu.org; Wed, 16 Oct 2019 16:36:01 -0400 Received: from mail-yb1-f172.google.com ([209.85.219.172]:35788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKq1X-0002S1-MN for 33959@debbugs.gnu.org; Wed, 16 Oct 2019 16:36:00 -0400 Received: by mail-yb1-f172.google.com with SMTP id i6so3863773ybe.2 for <33959@debbugs.gnu.org>; Wed, 16 Oct 2019 13:35:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/S68S9SUVq8QKbQwu+sUX/XkcURILZNoMtArEPTy0yM=; b=PZpw5UM56/UZoGXyqV7/B8W/R/7neJ49evekD5q/cMjGkGcVmwYLI0n6JYYpS181KY Rfv9QYEvD25p6g+hyfuGoHaXSsI4W6vZ8ZbVO2+fKR9F0fZ2CuRppIetgPPsXgYQy/Yw 71rrPC9kr2067DReTAPYOUugkIQsA1twWnabKMc9i+nbOoHjh9EqNrjMuFFkySlFWFNz DBu7mxvEdPmvyjQVXpxz8hN9hBlFPKNq4u2Vuge+uWecZFZG9tz75Vs9aXkW0GIG0KjS fZ6uZdVh7gDdcBI/xnRpH3MIsK65NhGQtglgjNrVE5Qg8VMIiCYxH9h1V2WnJiTdySVe iJIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/S68S9SUVq8QKbQwu+sUX/XkcURILZNoMtArEPTy0yM=; b=jnlQG/52J0cPToy79cQTcxoqK1ybkddb6PaMPgZZMloJJuacIJIK0oTc8t4fPS1lDt MrIAHPd+MgRrg0ek7/t7U74xRI0l0xKqPZZyDX31Cz07hM/kdfjBuZMq0e+kQ03B3dKL rg+ucREiXdS8HPTPNpYJemTpSWJnIfa4ioqcaySKUN1Ej9z0LeWsQSltULGfYDqFndHZ z2m3bWu6kJHyTddROd/JMEAoJvkjSW4a7X6ZfGSndmg1oVvk5MUem/SZ7fceVAFG+UIJ Xm6TuPJEh1KtRZHrY2QhWPwsI/aiH9tlqJGmRvmcA6cjbeGv+6csNQrs10rPigZaqdaJ d1Tw== X-Gm-Message-State: APjAAAUh3NzuiRIqqC8Fj+4HwbHy+JqSZpC0dbGdL5A8gRC0o34zGMKK XtnkD4TQowBIrJbYAZdGqaQCTMSQ7vD3kPP6XiI= X-Google-Smtp-Source: APXvYqypgRtQIEWSq24FtNIUNlqDxBd+odnRQRZGWiCvTcx7wCB1quhlVOUegYE/7bDxEYVVqKGEweBICnOTD10W97M= X-Received: by 2002:a25:42:: with SMTP id 63mr379204yba.454.1571258153937; Wed, 16 Oct 2019 13:35:53 -0700 (PDT) MIME-Version: 1.0 References: <87h8eq332i.fsf@gmail.com> <87h84a6e42.fsf_-_@gmail.com> In-Reply-To: From: Carlos Pita Date: Wed, 16 Oct 2019 17:35:42 -0300 Message-ID: Subject: Re: bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled To: Noam Postavsky Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33959 Cc: 33959@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Noam, I don't want to be insistent (and I'm probably being) but it won't take much time for someone to complaint about [1] because it removed the `(not (string= "" output))` guard from the original code. As it is now, it's certainly buggy. I know it would be desirable to provide an unit test for [1] but this new commit I'm providing can't harm (remember it's just an "around advice": `(unless (string= output "") ... )`) and I believe my argument against the way the empty output condition was checked before is sound and simple enough. Thanks and sorry for the insistence. --- [1] 7acc621e3 (Fix python-shell font-lock cleanup for unclosed quotes (Bug#32390)) From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 21 16:57:04 2019 Received: (at 33959) by debbugs.gnu.org; 21 Oct 2019 20:57:04 +0000 Received: from localhost ([127.0.0.1]:57953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMejg-0002z4-4Y for submit@debbugs.gnu.org; Mon, 21 Oct 2019 16:57:04 -0400 Received: from mail-yw1-f48.google.com ([209.85.161.48]:46103) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMeje-0002yP-HC for 33959@debbugs.gnu.org; Mon, 21 Oct 2019 16:57:02 -0400 Received: by mail-yw1-f48.google.com with SMTP id l64so5405010ywe.13 for <33959@debbugs.gnu.org>; Mon, 21 Oct 2019 13:57:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UIcj7tIbpQGKo/U66UAiEBONqGSXJN7jf4IuumZVH/s=; b=fuUqqFWCeM5LQOYLlxpvuSv+4YWaZEXsF8VjjXmnYOIKB9C9wQCLgkCzvafokdzzXx w2pWbBMmFpuV+ivXL3E3loiYLIdkCmHfOaTo7rhkOUwbMOde5g8c8JaGNzg3MqGQ8MpR mGIotgODo+sCWEQ7vjWqT1YLmaxJSuXJqs8wrQ2aThcgDQWpLpWWlw1Hmf3BmWbnGasY y5mVz9JT0H/U4ghyGiNODj2UYW0NMxPQ1PbSnr7YffLdinbu7emg4Rp+QI8k6KAsOzpo pKIxC/6osCYRR3bNIfo+Kem8Yvy5CbrI+wQ4LQz+vO05Z8aFHCYvvjUlhWMj1inmdUSz Oj3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UIcj7tIbpQGKo/U66UAiEBONqGSXJN7jf4IuumZVH/s=; b=MPPaF51hAB15C2mn+ILiJtAB9ENhr0n62MWWHDrT2BCI9I0/KF59CBzWSVuZ76RdmG 63PJZrN/FDqgMkELrKEvnyYzoXlo1aw25g0aYHQ13jIGHVr7skmm1oIJsh+9pyjXRplE gJBhmBhaD80X3ntlC7kmf4OgOaHfhMA/Y01q3hGzqaOww1x+smv0UKCD2VcTtL8ah3B6 YvbrTsftxiNYqzV3Ia2sTa6AOc+HpOPQvk61en3xa/fsmjrhXiaA9deX6vG0uFGEfP+d PC5wviBpaZ63TbN9NFaCjpJCumw97Ezpn6srRp9qw492WMB0k5HnmR7arGMf536eOjRs ZE1g== X-Gm-Message-State: APjAAAU2wWX9PpfuEvBv1Afo1MHHYYmG092owonXWy6NSmK/09X0vIIN OrcOwjbqFX6yWmCPgN1h6usd9TJlbM4F38AmwGPc0DHDBOw= X-Google-Smtp-Source: APXvYqzfF8iSfPlHFk0WGcPvsTRzue2TAEJWj9sJsVqDcnesW2q4lS3Xw5oNmQan2p5Flr3P8Nq1Cz0UwmWg4EnlPzI= X-Received: by 2002:a81:35c9:: with SMTP id c192mr683261ywa.57.1571691416857; Mon, 21 Oct 2019 13:56:56 -0700 (PDT) MIME-Version: 1.0 References: <87h8eq332i.fsf@gmail.com> <87h84a6e42.fsf_-_@gmail.com> In-Reply-To: From: Carlos Pita Date: Mon, 21 Oct 2019 17:56:45 -0300 Message-ID: Subject: Re: bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled To: Noam Postavsky Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33959 Cc: 33959@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I've improved the commit message following the guidelines described in CONTRIBUTE. Here is the commit https://github.com/memeplex/emacs/commit/6792b4a7e6daad602ad92f0987bfea7499a50205 You can generate a nicely formatted patch by adding the .patch suffix to that URL. Best regards -- Carlos From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 22 20:18:34 2019 Received: (at 33959) by debbugs.gnu.org; 23 Oct 2019 00:18:34 +0000 Received: from localhost ([127.0.0.1]:60641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iN4ME-0004Jx-DF for submit@debbugs.gnu.org; Tue, 22 Oct 2019 20:18:34 -0400 Received: from mail-qt1-f174.google.com ([209.85.160.174]:37531) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iN4M4-0004JP-JO; Tue, 22 Oct 2019 20:18:25 -0400 Received: by mail-qt1-f174.google.com with SMTP id g50so15541724qtb.4; Tue, 22 Oct 2019 17:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=lA0E3B2W12dT4lLZiEh+SsES6h1+hbxYNLNf/J1QNSY=; b=ScChpmbRspysZCJa2nXdyfRodbQYojMhroj5wu3H1ihAGKdP/nMDUFfuNi/uzQbYdj TpwS2b3pZbs1YP2CTSGG7p4bOMpsoE37UHVcz3bBv3/uNPzXN0GBghSkbWP5eHFefgM+ byQhbRsUL7z/oFwtj9tgWbDkZnes3d2pPHtsWBCv/ihs9MZZd1+StFJ1OVIyB3A/JYiB lTmog0uQ1aydcWWmV7D6M7+dhX/Bxn7LlTkPZAwJPRAVSwoimddwgbfaQUuYzPsRapNY v3puGnnQ7sVEZ1jQzPHh4NfpiMxGiBWR9uzNlKbmypVl1yE3HS+ExQICl6rNhklIhogQ ySXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=lA0E3B2W12dT4lLZiEh+SsES6h1+hbxYNLNf/J1QNSY=; b=scSf6hVSO3N6rxAkjgM3LEqyo4DKs6AlIxaeNAZXLAgiT2PP/kPjdBuQ2+feVXdjYk QXldbFnL4Wh98/wLNEbzHEPrKZcr7B3y7Y+hUn8c/W2LPPrvfO2OWwk+tIFVaNBRc4jZ /g2WbXG33GlGsnHrV6EObT7Nbp0TJ4TW/cRNjEK1sx4MGt4B1Q6qEEM++TFOu5WD76jh M9lOTEkDiln3Q4CDI3M/93lp/QFpZFMoPbZKFXbHZyNHk9c9p2o2NYrjCKrbu7AoXzKL S93xAEQoH85UVU/raJyexs4oYWGiXzIDkEdu93Yc9UOQHnAPHTg5NIzlehRjodzwqL8/ dYPw== X-Gm-Message-State: APjAAAVFIKTqDVuIMJ/7DX7YCmr3Ek897KNEdr7ObEegf4VaVTN8mzOa xoQZWAAz+K9xtBnIRQePN5xhWyWi X-Google-Smtp-Source: APXvYqxs7sqdvSJkOAIN/y2OPEA0d9B/WrO28SocWe3f6xx5SPbJ92xeS1DdjqiQoo3W0GYhIGqbsQ== X-Received: by 2002:aed:37c9:: with SMTP id j67mr6409625qtb.291.1571789898705; Tue, 22 Oct 2019 17:18:18 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id k15sm1465088qtp.90.2019.10.22.17.18.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Oct 2019 17:18:17 -0700 (PDT) From: Noam Postavsky To: Carlos Pita Subject: Re: bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled References: <87h8eq332i.fsf@gmail.com> <87h84a6e42.fsf_-_@gmail.com> Date: Tue, 22 Oct 2019 20:18:17 -0400 In-Reply-To: (Carlos Pita's message of "Wed, 16 Oct 2019 17:35:42 -0300") Message-ID: <87y2xcco1i.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33959 Cc: 33959@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 33959 fixed close 33959 27.1 quit Carlos Pita writes: > Hi Noam, I don't want to be insistent (and I'm probably being) No worries, sorry for taking so long on this. > As it is now, it's certainly buggy. I know it would be desirable to > provide an unit test for [1] but this new commit I'm providing can't > harm (remember it's just an "around advice": `(unless (string= output > "") ... )`) and I believe my argument against the way the empty output > condition was checked before is sound and simple enough. Thanks and > sorry for the insistence. Looking at this now afresh, I agree that this change looks safe enough. I think I was confused before by the other patch removing that same guard in the first branch of the `if'. I do suspect that the filter function receiving an empty string is a bug in itself though. Meanwhile I've pushed your fix (since we'll want it in the GNU ELPA python.el for Emacs 26 and earlier regardless of whether the underlying process filter bug is fixed). [2: ab67287872]: 2019-10-22 20:11:49 -0400 Avoid extra lines in python-shell font lock buffer (Bug#33959) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=ab6728787245e0d46bd8a8919e30c882f6011182 From unknown Mon Aug 18 00:08:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 20 Nov 2019 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator