GNU bug report logs - #33902
[PATCH] gnu: Add wlstream.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33902 in the body.
You can then email your comments to 33902 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rutger Helling <rhelling <at> mykolab.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add wlstream.
Date: Sat, 29 Dec 2018 13:46:26 +0100

[Message part 1 (text/plain, inline)]

Hey Guix,

these patches add wlstream. It needs libdrm support in ffmpeg, which
the first patch does.

Tested and working under Sway with:
wlstream 25 vaapi /dev/dri/renderD128 libx264rgb bgr0 12 output.mkv

[0001-gnu-ffmpeg-Add-libdrm-support.patch (text/x-patch, attachment)]

[0002-gnu-Add-wlstream.patch (text/x-patch, attachment)]

[Message part 4 (application/pgp-signature, inline)]

Message #8 received at 33902 <at> debbugs.gnu.org (full text, mbox):

From: Brendan Tildesley <brendan.tildesley <at> gmail.com>
To: 33902 <at> debbugs.gnu.org
Subject: Re: [bug#33902] [PATCH] gnu: Add wlstream.
Date: Sun, 30 Dec 2018 01:38:26 +1100

The description for wlstream is vague and the English unnatural
("streams" should be "stream"). I'm not sure what it does and the git
repo doesn't even provide an explanation. Could you write  a more
thorough description?

Message #11 received at 33902 <at> debbugs.gnu.org (full text, mbox):

From: Rutger Helling <rhelling <at> mykolab.com>
To: 33902 <at> debbugs.gnu.org, brendan.tildesley <at> gmail.com
Subject: Re: [PATCH] gnu: Add wlstream.
Date: Sat, 29 Dec 2018 22:43:04 +0100

[Message part 1 (text/plain, inline)]

Here's a second version of the patch with a synopsis
and description that's hopefully clearer.

> The description for wlstream is vague and the English unnatural
> ("streams" should be "stream"). I'm not sure what it does and the git
> repo doesn't even provide an explanation. Could you write  a more
> thorough description?

[0001-gnu-ffmpeg-Add-libdrm-support.patch (text/x-patch, attachment)]

[0002-gnu-Add-wlstream-v2.patch (text/x-patch, attachment)]

[Message part 4 (application/pgp-signature, inline)]

Message #14 received at 33902 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Rutger Helling <rhelling <at> mykolab.com>
Cc: brendan.tildesley <at> gmail.com, 33902 <at> debbugs.gnu.org,
 272c6bd6-de75-987a-527c-7649b84d62cd <at> gmail.com
Subject: Re: [bug#33902] [PATCH] gnu: Add wlstream.
Date: Wed, 09 Jan 2019 16:41:31 +0100

Hello Rutger,

Rutger Helling <rhelling <at> mykolab.com> skribis:

> From b38bdecd0dee379f50241092aab2be4b69606209 Mon Sep 17 00:00:00 2001
> From: Rutger Helling <rhelling <at> mykolab.com>
> Date: Fri, 28 Dec 2018 20:15:22 +0100
> Subject: [PATCH 1/2] gnu: ffmpeg: Add libdrm support.
>
> * gnu/packages/video.scm (ffmpeg): Add libdrm support.

[...]

> From 5d18a851060605deee53c275159a6d37bfc0b007 Mon Sep 17 00:00:00 2001
> From: Rutger Helling <rhelling <at> mykolab.com>
> Date: Sat, 29 Dec 2018 16:17:59 +0100
> Subject: [PATCH 2/2] gnu: Add wlstream.
>
> * gnu/packages/video.scm (wlstream): New variable.

Both LGTM!

> +(define-public wlstream
> +  (let ((commit "182076a94562b128c3a97ecc53cc68905ea86838")
> +        (revision "1"))
> +    (package
> +     (name "wlstream")
       ^

We usually add an extra space here.  Did you try running
./etc/indent-code.el on your packages?  Or is it too inconvenient?

Thanks,
Ludo’.

Message #19 received at 33902-done <at> debbugs.gnu.org (full text, mbox):

From: Rutger Helling <rhelling <at> mykolab.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: brendan.tildesley <at> gmail.com, 33902-done <at> debbugs.gnu.org
Subject: Re: [bug#33902] [PATCH] gnu: Add wlstream.
Date: Thu, 10 Jan 2019 08:57:16 +0100

[Message part 1 (text/plain, inline)]

Thanks for the review, pushed with fixed indentation.

I'll make sure to double check with ./etc/indent-code.el from now on.

On Wed, 09 Jan 2019 16:41:31 +0100
Ludovic Courtès <ludo <at> gnu.org> wrote:

> Hello Rutger,
> 
> Rutger Helling <rhelling <at> mykolab.com> skribis:
> 
> > From b38bdecd0dee379f50241092aab2be4b69606209 Mon Sep 17 00:00:00
> > 2001 From: Rutger Helling <rhelling <at> mykolab.com>
> > Date: Fri, 28 Dec 2018 20:15:22 +0100
> > Subject: [PATCH 1/2] gnu: ffmpeg: Add libdrm support.
> >
> > * gnu/packages/video.scm (ffmpeg): Add libdrm support.  
> 
> [...]
> 
> > From 5d18a851060605deee53c275159a6d37bfc0b007 Mon Sep 17 00:00:00
> > 2001 From: Rutger Helling <rhelling <at> mykolab.com>
> > Date: Sat, 29 Dec 2018 16:17:59 +0100
> > Subject: [PATCH 2/2] gnu: Add wlstream.
> >
> > * gnu/packages/video.scm (wlstream): New variable.  
> 
> Both LGTM!
> 
> > +(define-public wlstream
> > +  (let ((commit "182076a94562b128c3a97ecc53cc68905ea86838")
> > +        (revision "1"))
> > +    (package
> > +     (name "wlstream")  
>        ^
> 
> We usually add an extra space here.  Did you try running
> ./etc/indent-code.el on your packages?  Or is it too inconvenient?
> 
> Thanks,
> Ludo’.

[Message part 2 (application/pgp-signature, inline)]

Message #22 received at 33902-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Rutger Helling <rhelling <at> mykolab.com>
Cc: brendan.tildesley <at> gmail.com, 33902-done <at> debbugs.gnu.org
Subject: Re: [bug#33902] [PATCH] gnu: Add wlstream.
Date: Thu, 10 Jan 2019 09:54:42 +0100

Rutger Helling <rhelling <at> mykolab.com> skribis:

> Thanks for the review, pushed with fixed indentation.

Thank you.

> I'll make sure to double check with ./etc/indent-code.el from now on.

You shouldn’t lose your hair on it obviously, but if indent-code.el
works well for you, that’d be great.  (We could also add config snippets
for your editor in the repo, if you know what it would take to customize
its indentation facility.)

Ludo’.

Message #25 received at 33902-done <at> debbugs.gnu.org (full text, mbox):

From: Rutger Helling <rhelling <at> mykolab.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 33902-done <at> debbugs.gnu.org
Subject: Re: [bug#33902] [PATCH] gnu: Add wlstream.
Date: Fri, 11 Jan 2019 10:25:30 +0100

[Message part 1 (text/plain, inline)]

I'm actually using Emacs (with Evil :) ). I think I might have been
using an old version of indent-code.el. I'll see what happens in the
future.

On Thu, 10 Jan 2019 09:54:42 +0100
Ludovic Courtès <ludo <at> gnu.org> wrote:

> Rutger Helling <rhelling <at> mykolab.com> skribis:
> 
> > Thanks for the review, pushed with fixed indentation.  
> 
> Thank you.
> 
> > I'll make sure to double check with ./etc/indent-code.el from now
> > on.  
> 
> You shouldn’t lose your hair on it obviously, but if indent-code.el
> works well for you, that’d be great.  (We could also add config
> snippets for your editor in the repo, if you know what it would take
> to customize its indentation facility.)
> 
> Ludo’.

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.