GNU bug report logs - #339
ffap attempts to get the whole region

Previous Next

Full log

Message #22 received at 339-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: jidanni <at> jidanni.org
To: monnier <at> iro.umontreal.ca
Cc: 339-done <at> debbugs.gnu.org
Subject: Re: bug#339: ffap thinks whole region is URL
Date: Fri, 06 Jun 2008 02:18:59 +0800

In ffap.el, please add a new variable that will allow the user to
disable
	  (if (and transient-mark-mode mark-active)
	      (buffer-substring
	       (setcar ffap-string-at-point-region (region-beginning))...
Why?
1. The user shouldn't have to worry if he has marks active or not.
2. The goal is probably to allow users to get URLs with (,) and
Unicode in them, like Wikipedia's.
That goal is better accomplished by
(eval-after-load "ffap"
  '(setcar (cdr (assq 'url ffap-string-at-point-mode-alist))
 	   "--:=&?$+@-Z_[:lower:][:multibyte:]()~#,%;*"))
and not snarfing up the whole region, newlines and all, as one big URL.
Thank you.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.