GNU bug report logs - #33896
libblockdev inputs are not used correctly

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#33896: closed (libblockdev inputs are not used correctly)
Date: Mon, 01 Sep 2025 15:41:05 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 01 Sep 2025 17:28:27 +0200
with message-id <87wm6i9opw.fsf <at> gmail.com>
and subject line Re: bug#33896: [PATCH 1/2] gnu: libblockdev: Embed executable paths.
has caused the debbugs.gnu.org bug report #33896,
regarding libblockdev inputs are not used correctly
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
33896: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33896
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: <bug-guix <at> gnu.org>
Subject: libblockdev inputs are not used correctly
Date: Fri, 28 Dec 2018 14:32:55 +0100

[Message part 3 (text/plain, inline)]

Currently, libblockdev has inputs which aren't used.

These SHOULD be used, but the source files are not patched
so the executables in the inputs are not found or used.

Example:

* libblockdev depends on dosfstools because src/plugins/fs/vfat.c would use
"mkfs.vfat" etc, but src/plugins/fs/vfat.c is not patched to actually refer
to the inputs.

This problem is valid for everything in src/plugins/fs .

Do we proceed to patch it to use the inputs or do we move dosfstools etc
to propagated-inputs ?

I'd suggest the former.

[Message part 4 (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: 33896-done <at> debbugs.gnu.org
Subject: Re: bug#33896: [PATCH 1/2] gnu: libblockdev: Embed executable paths.
Date: Mon, 01 Sep 2025 17:28:27 +0200

Hi,

On Sat, 25 Sep 2021 at 14:28, Sarah Morgensen <iskarian <at> mgsn.dev> wrote:
> Fixes <https://bugs.gnu.org/33896>.
>
> * gnu/packages/disk.scm (libblockdev)[arguments]<#:phases>: Add
> 'patch-plugin-paths' phase.
> ---
>  gnu/packages/disk.scm | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)

Merged with 69899ca818e5606fc4694cbaf3385562b7394dab.

Closing.

Cheers,
simon

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.