Subject: Re: [bug#33893] [PATCH v5 4/4] gnu: Add docker-cli.

From: Ludovic Courtès <[email-masked]>
Date: Sun, 06 Jan 2019 21:33:12 +0100

Danny Milosavljevic <[email-masked]> skribis:

> * gnu/packages/docker.scm (docker-cli): New variable.

[...]

> +    (arguments
> +     `(#:import-path "github.com/docker/cli"
> +       ;; TODO: Tests require a running Docker daemon.
> +       #:tests? #f

I suppose we cannot run the daemon in the build environment, can we?

Or is it possible to use some of the tests?

> +    (native-inputs
> +     `(("go" ,go)
> +       ("libltdl" ,libltdl)

Shouldn’t libltdl be an input?

Otherwise LGTM, thanks!

Ludo’.