From unknown Sat Aug 16 22:00:23 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#33872 <33872@debbugs.gnu.org> To: bug#33872 <33872@debbugs.gnu.org> Subject: Status: flymake-tests different-diagnostic-types test fails Reply-To: bug#33872 <33872@debbugs.gnu.org> Date: Sun, 17 Aug 2025 05:00:23 +0000 retitle 33872 flymake-tests different-diagnostic-types test fails reassign 33872 emacs submitter 33872 Micha=C5=82 Nazarewicz severity 33872 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 25 18:17:29 2018 Received: (at submit) by debbugs.gnu.org; 25 Dec 2018 23:17:29 +0000 Received: from localhost ([127.0.0.1]:36497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gbvx2-0006Jt-OD for submit@debbugs.gnu.org; Tue, 25 Dec 2018 18:17:29 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gbvx1-0006Jg-2e for submit@debbugs.gnu.org; Tue, 25 Dec 2018 18:17:27 -0500 Received: from lists.gnu.org ([208.118.235.17]:45538) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gbvwv-000626-ND for submit@debbugs.gnu.org; Tue, 25 Dec 2018 18:17:21 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gbvwu-000580-Fs for bug-gnu-emacs@gnu.org; Tue, 25 Dec 2018 18:17:21 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gbvwp-0005qr-J4 for bug-gnu-emacs@gnu.org; Tue, 25 Dec 2018 18:17:20 -0500 Received: from mail-wm1-f50.google.com ([209.85.128.50]:37655) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gbvwp-0005ml-Ci for bug-gnu-emacs@gnu.org; Tue, 25 Dec 2018 18:17:15 -0500 Received: by mail-wm1-f50.google.com with SMTP id g67so14182191wmd.2 for ; Tue, 25 Dec 2018 15:17:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=q4xT00KiTwBrTdBieJiyAl3Y1HlqhLUJvl8LuRAZhQI=; b=s/TyYN8qBstjkbYp6geACHj1rBZms47gJpRoVzWbqTVLLvBn/faBd9F1uMrI/SQJsI ihyBRp8VH10klHuYWy7KYb28wHkS3jzqCjM6pOL/EgzCjlrm+LpnGXzwS4do3XlUaIvl qPaVhhDsQtjg5slKIRdLJ+4NCCdu5MWcDUzhLeBEWkjWEwKboWvzSZT4RS28QpgifXE8 pW9vmguzra06s8DAbQQ44TrrP++zpDQa99tDlwifQLp8FXXjnsiTHdj9T5dtHXWfC/lu kfF8zqtC+RdMJqxGCHc5hmJos849aah5oVsQvPUso3ZL4R1QLFr4gnAr8QQvfT5WfJl0 HcMQ== X-Gm-Message-State: AJcUukefeKi1Wsa9e7f9JSzStlNvjV7bcfuKH/kAw06lxzQg7SpVZunC fbrSK57xjXWWBwaRFX+21DYJQ9JlLooBmzYiK0U0ZKvpVtU= X-Google-Smtp-Source: ALg8bN6Vjt5TOH5e4YR5PNylvJoI1rlT86u1lWW0P9k2VTLFaOt7rxPSBlH+Uh/1ffalhuwTNqfMg0sFPbvQDkZ1CPQ= X-Received: by 2002:a1c:d00d:: with SMTP id h13mr15723258wmg.13.1545779833356; Tue, 25 Dec 2018 15:17:13 -0800 (PST) MIME-Version: 1.0 From: =?UTF-8?Q?Micha=C5=82_Nazarewicz?= Date: Tue, 25 Dec 2018 23:16:52 +0000 Message-ID: Subject: flymake-tests different-diagnostic-types test fails To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.128.50 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) The flymake-tests different-diagnostic-types test fails on HEAD (commit 9fe788a1fa02c6b717c709773f3cca7bc8b2ebe6) with gcc 8.2.0 (though I=E2=80=99m not sure if gcc version is relevant) as can be seen in test log: ---- >8 ---------------------------------------------------------------- Running 9 tests (2018-12-25 13:58:53+0000, selector `(not (or (tag :expensive-test) (tag :unstable)))') Test different-diagnostic-types backtrace: signal(ert-test-failed (((should (eq 'flymake-error (face-at-point)) ert-fail(((should (eq 'flymake-error (face-at-point))) :form (eq fly #f(compiled-function () #)() flymake-tests--call-with-fixture(#f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name different-diagnostic-types :documenta ert-run-or-rerun-test(#s(ert--stats :selector (not (or ... ...)) :te ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/progmodes/flymake-te command-line() normal-top-level() Test different-diagnostic-types condition: (ert-test-failed ((should (eq 'flymake-error (face-at-point))) :form (eq flymake-error flymake-note) :value nil)) FAILED 1/9 different-diagnostic-types (1.058400 sec) passed 2/9 dummy-backends (1.003778 sec) passed 3/9 eob-region-and-trailing-newline (0.000181 sec) passed 4/9 included-c-header-files (2.029273 sec) passed 5/9 perl-backend (1.024491 sec) passed 6/9 recurrent-backend (1.006058 sec) skipped 7/9 ruby-backend (0.000575 sec) passed 8/9 warning-predicate-function-gcc (1.015344 sec) passed 9/9 warning-predicate-rx-gcc (1.017081 sec) Ran 9 tests, 7 results as expected, 1 unexpected, 1 skipped (2018-12-25 13:59:01+0000, 8.225831 sec) 1 unexpected results: FAILED different-diagnostic-types 1 skipped results: SKIPPED ruby-backend ---- 8< ---------------------------------------------------------------- The issue is that flymake does not recognise #include "some-problems.h" line in the test file as problematic even though gcc complains about the header file: ---- >8 ---------------------------------------------------------------- $ make ./test/lisp/progmodes/flymake-resources/errors-and-warnings cc test/lisp/progmodes/flymake-resources/errors-and-warnings.c -o test/lisp/progmodes/flymake-resources/errors-and-warnings In file included from test/lisp/progmodes/flymake-resources/errors-and-warnings.c:3: test/lisp/progmodes/flymake-resources/some-problems.h:3:1: warning: data definition has no type or storage class strange; ^~~~~~~ test/lisp/progmodes/flymake-resources/some-problems.h:3:1: warning: type defaults to =E2=80=98int=E2=80=99 in declaration of =E2=80=98strange= =E2=80=99 [-Wimplicit-int] test/lisp/progmodes/flymake-resources/some-problems.h:5:1: error: unknown type name =E2=80=98sint=E2=80=99; did you mean =E2=80=98int=E2=80= =99? sint main(); ^~~~ int test/lisp/progmodes/flymake-resources/errors-and-warnings.c: In function = =E2=80=98main=E2=80=99: test/lisp/progmodes/flymake-resources/errors-and-warnings.c:9:12: warning: overflow in conversion from =E2=80=98int=E2=80=99 to =E2=80=98char= =E2=80=99 changes value from =E2=80=981000=E2=80=99 to =E2=80=98-24=E2=80=99 [-Woverflow] char c =3D 1000; /* a note and a warning */ ^~~~ test/lisp/progmodes/flymake-resources/errors-and-warnings.c:11:8: error: redeclaration of =E2=80=98c=E2=80=99 with no linkage char c; if (bla =3D=3D (void*)3); /* an error, and two warnings */ ^ test/lisp/progmodes/flymake-resources/errors-and-warnings.c:9:8: note: previous definition of =E2=80=98c=E2=80=99 was here char c =3D 1000; /* a note and a warning */ ^ test/lisp/progmodes/flymake-resources/errors-and-warnings.c:11:19: warning: comparison between pointer and integer char c; if (bla =3D=3D (void*)3); /* an error, and two warnings */ ^~ make: *** [: test/lisp/progmodes/flymake-resources/errors-and-warnings] Error 1 ---- 8< ---------------------------------------------------------------- Commenting the first check in the test (as shown below) makes it pass: ---- >8 ---------------------------------------------------------------- diff --git a/test/lisp/progmodes/flymake-tests.el b/test/lisp/progmodes/flymake-tests.el index ef1fd19e86..f16db1e09e 100644 --- a/test/lisp/progmodes/flymake-tests.el +++ b/test/lisp/progmodes/flymake-tests.el @@ -151,8 +151,8 @@ ruby-mode-hook (flymake-tests--with-flymake ("errors-and-warnings.c") (flymake-goto-next-error) - (should (eq 'flymake-error (face-at-point))) - (flymake-goto-next-error) + ;; (should (eq 'flymake-error (face-at-point))) + ;; (flymake-goto-next-error) (should (eq 'flymake-note (face-at-point))) (flymake-goto-next-error) (should (eq 'flymake-warning (face-at-point))) ---- >8 ---------------------------------------------------------------- --=20 Best regards =E3=83=9F=E3=83=8F=E3=82=A6 =E2=80=9C=F0=9D=93=B6=F0=9D=93=B2=F0=9D=93=B7= =F0=9D=93=AA86=E2=80=9D =E3=83=8A=E3=82=B6=E3=83=AC=E3=83=B4=E3=82=A4=E3=83= =84 =C2=ABIf at first you don=E2=80=99t succeed, give up skydiving=C2=BB From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 05 06:47:57 2019 Received: (at 33872) by debbugs.gnu.org; 5 Jan 2019 11:47:57 +0000 Received: from localhost ([127.0.0.1]:47314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfkQn-0007i9-Jo for submit@debbugs.gnu.org; Sat, 05 Jan 2019 06:47:57 -0500 Received: from mail-wm1-f52.google.com ([209.85.128.52]:33641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfkQl-0007hq-ST; Sat, 05 Jan 2019 06:47:56 -0500 Received: by mail-wm1-f52.google.com with SMTP id r24so2763665wmh.0; Sat, 05 Jan 2019 03:47:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=MEnrTHggAFSzye10ZRKWHfHOL1ivS8pVB0tSYOW7NVc=; b=iLDtgB7E1POPbJatygTbq+uuLQzsNC4EagU3RH7uVAM4ZshXHW35miYm2gnrcHthZ4 VoHxar7CmvXYzt6EHvU6eTXA1Z0p4WKbWDneuKBhvJfrS6yUdCyb3nKIl8UR1N/Fg8UR aAJ6QDYd4ugUU7Kg3N1yL8XnqT7GN2Y5Z/bwIbyT/Qv0Q0z+1zuXu45YuIdeFjZgdzh/ hdwmnPNWA3ma/Si31pj2bbaB3n09F5320eAzPENy6LYsPXk6uH9QOx/gpaTHDSIwzxnR SQDjMUdbf9v4Y7WOpNAAesZgmx4izDqb68AWxCbUoeVE9WgA3qb+ay9+UnpIKokN06+J s20w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=MEnrTHggAFSzye10ZRKWHfHOL1ivS8pVB0tSYOW7NVc=; b=IzLkMycAkrz92js2AWgDA7kVraeEdiIarkdHjue90I/mA/REvg6Usb0oRbXKCZhrwa PSS9ltNgFsKJUhpT8Ys2KXjWWJd3ahnjGcuD23XB4AQJrcMxD++/ts+vPcM070K0NYrN V8BHLWs5bXPHEYexaibLtc3MDb6BPT22/61fUpfgGDwjCjo06zqIihKDxHQKnfio7sCt XDvsiHKvkGJ94wIiZsSAnqkDX9JNEpJTDJJqo2xMeG5I7Jb2xL+/lHrtnG0iW6T4y4kr 1p0octZRRcFyliT5pfe9i7/+1M6yq4mgRhgylloljKZ4JIaYryHL0Hm1DiQtSRgO7T1M SxsQ== X-Gm-Message-State: AJcUukdmZVVJYWKXxMVqEHAbPXf5gh2ic3086r6ZMDirfEdPTt77Rda3 In80ctbb/dE1CX7AIiqUEL14ee/C7kU= X-Google-Smtp-Source: ALg8bN4Vymt1pPy2lQPIWgOrrD+PN3dyh9VKLYNprWTfdIiZMZU1KvdIB7uU6WcRuYJFFdthfrAT6g== X-Received: by 2002:a1c:35ca:: with SMTP id c193mr3827241wma.146.1546688869817; Sat, 05 Jan 2019 03:47:49 -0800 (PST) Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id y34sm136933308wrd.68.2019.01.05.03.47.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 05 Jan 2019 03:47:49 -0800 (PST) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: =?utf-8?Q?Micha=C5=82?= Nazarewicz Subject: Re: bug#33872: flymake-tests different-diagnostic-types test fails References: Date: Sat, 05 Jan 2019 11:47:47 +0000 In-Reply-To: (=?utf-8?Q?=22Micha=C5=82?= Nazarewicz"'s message of "Tue, 25 Dec 2018 23:16:52 +0000") Message-ID: <87va33iavw.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 33872 Cc: 33872@debbugs.gnu.org, 33872-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) Micha=C5=82 Nazarewicz writes: > The flymake-tests different-diagnostic-types test fails on HEAD > (commit 9fe788a1fa02c6b717c709773f3cca7bc8b2ebe6) with gcc 8.2.0 > (though I=E2=80=99m not sure if gcc version is relevant) as can be seen in > test log: Thanks for the report. I reproduced and fixed the bug in 04d3315271cd1357fbbc192505d00c760be02952. GCC 8.2.0 doesn't report the column in "In file included from" errors. Jo=C3=A3o From unknown Sat Aug 16 22:00:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 02 Feb 2019 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator