GNU bug report logs - #33870
27.0.50; xref-goto-xref not configurable

Previous Next

Full log

Message #344 received at 33870 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Juri Linkov <juri <at> linkov.net>
Cc: 33870 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>, joaotavora <at> gmail.com,
 dgutov <at> yandex.ru
Subject: Re: bug#33870: 27.0.50; xref-goto-xref not configurable
Date: Tue, 29 Jan 2019 09:50:06 +0100

>> You probably mean separate 'direction' and 'window' entries instead of
>> the (direction . (WIN . DIR)).  But we didn't find a good term for
>> denoting the reference window and the two inherently belong together.
>
> I think your idea of combining them is good.

So using (direction . (DIR . WIN)) would be OK?

> Currently it requires too much boilerplate code to do such simple things
> as displaying the buffer below/bottom with resizing to fit its height.
> Please grep “-at-bottom” and “-below-selected” for the current cases,
> they are all ugly: some of them use ‘with-displayed-buffer-window’ with
>
>    '((window-height . fit-window-to-buffer)
>      (preserve-size . (nil . t)))
>
> some are more uglier
>
>    ,(if temp-buffer-resize-mode
>         '(window-height . resize-temp-buffer-window)
>       '(window-height . fit-window-to-buffer))
>    ,(when temp-buffer-resize-mode
>       '(preserve-size . (nil . t)))
>
> some use the macro ‘with-current-buffer-window’, some use
> ‘pop-to-buffer’ with ‘display-buffer-below-selected’ action.
>
> Do you think it's possible to generalize all these cases
> to use simpler display actions/alists?

I'm afraid that this one

>    ,(if temp-buffer-resize-mode
>         '(window-height . resize-temp-buffer-window)

is not entirely kosher.  'resize-temp-buffer-window' should be called
only from 'temp-buffer-show-hook' or 'temp-buffer-window-show-hook'.
'display-buffer-at-bottom' can't tell whether BUFFER is temporary or
not.  Or am I missing something?

martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.