GNU bug report logs - #33870
27.0.50; xref-goto-xref not configurable

Previous Next

Full log

Message #287 received at 33870 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: João Távora <joaotavora <at> gmail.com>
Cc: 33870 <at> debbugs.gnu.org, martin rudalics <rudalics <at> gmx.at>,
 Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#33870: 27.0.50; xref-goto-xref not configurable
Date: Sat, 19 Jan 2019 22:35:30 +0200

>>> I see the prototype of window--display-buffer has changed recently, and
>>> so has it docstring.  I assumed that was it for the cleanup Martin
>>> requested, but indeed I could be wrong, as I didn't follow that
>>> subthread closely (has it died down or I am just not Cc: anymore?).
>>
>> The cleanup has been done.  The final message of that subthread says:
>>
>>   Anyone interested in renaming 'window--display-buffer' - please go
>>   ahead.  I think a 'display-buffer-' prefix should then be appropriate.
>>
>> What I meant there is that calling it say 'display-buffer-in-window'
>> would be appropriate but the final name is up to its clients.
>
> Actually seems like a really good name.  If I make a function alias,
> code in window.el can still use the old name.  Do you prefer that, or
> should I replace all uses that I can find in Emacs?

I agree that 'display-buffer-in-window' is a good name.

> Actually2, we should keep the old name.  A code search on github.com
> reveals that other packages/customizations are using the internal
> function, too (which now takes one less arg, but if they break for that,
> they were really asking for it).

Then better to keep the old name with its old signature and
declare it obsolete and replace its body with the call to the
function with the new name and one less arg.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.