GNU bug report logs - #33870
27.0.50; xref-goto-xref not configurable

Previous Next

Package: emacs;

Reported by: Juri Linkov <juri <at> linkov.net>

Date: Tue, 25 Dec 2018 20:53:01 UTC

Severity: minor

Found in version 27.0.50

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

Full log


Message #167 received at 33870 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 33870 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Dmitry Gutov <dgutov <at> yandex.ru>, Stefan Monnier <monnier <at> iro.umontreal.ca>,
 Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#33870: 27.0.50; xref-goto-xref not configurable
Date: Tue, 8 Jan 2019 11:17:21 +0000
On Tue, Jan 8, 2019 at 9:25 AM martin rudalics <rudalics <at> gmx.at> wrote:

> So before making this function public, we should resolve this calling
> convention.

Makes sense.  Then, in my view, the logical sequence to fix this bug is

A. First do these changes to window.el and publish a decent
   window-display-buffer calling convention.

B. Push a xref.el based on the new function that doesn't change
the xref UI.

C. Discuss the xref.el UI in the other bug.

> Personally, I'd proceed as follows:
>
> (1) Deprecate the variable 'display-buffer-mark-dedicated'.
>
> (2) Remove the DEDICATED argument from this function.
>
> (3) Add a 'dedicated' action alist entry to implement the
>      functionality.

When do you think you can do this?  Be advised there is indeed some
third-party code already relying on the internal "--" version of this function.
We might be breaking some of that code (otoh it was "asking for it" for
using such an implementation detail).

> And we should [...] and another thing

Do both of these more ambitious refactorings really need to
make it in before we can do B as outlined above? Or can we
do them later in parallel?

João




This bug report was last modified 6 years and 35 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.