GNU bug report logs - #33856
PATCH: switch to non-recursive makefile

Previous Next

To reply to this bug, email your comments to 33856 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: bug-gzip <at> gnu.org
Subject: PATCH: switch to non-recursive makefile
Date: Mon, 24 Dec 2018 01:03:29 -0700

[Message part 1 (text/plain, inline)]

Hello,

Attached first attempt at converting gzip to non-recursive makefile.

There's atleast one existing problem which I couldn't figure out:
"dist-check.mk" contains "build_programs =" statement
that is supposed to automatically generate list of programs.
Doesn't seem to work, resulting in:

$ make check
[...]
/bin/bash: line 2: bin_PROGRAMS: command not found
/bin/bash: line 2: @echo: command not found
[...]

and in failure of "tests/help-version":
===
$ make check TESTS=tests/help-version
[....]
+ test '$(echo spy:'
+ test 1.9.19-cfef
+ for i in $built_programs
++ env '$(echo' --version
++ sed -n '1s/.* //p;q'
env: '$(echo': No such file or directory
+ v=
+ break
+ test x = x1.9.19-cfef
+ fail_ '--version-$VERSION mismatch'
===

The "$(echo spy:" is result of incorrect "build_programs" execution
 (I think).

To be continued,
 - assaf

[0001-built-switch-to-non-recursive-make.patch.gz (application/gzip, attachment)]

Message #12 received at 33856 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Assaf Gordon <assafgordon <at> gmail.com>, 33856 <at> debbugs.gnu.org
Subject: Re: bug#33856: PATCH: switch to non-recursive makefile
Date: Mon, 24 Dec 2018 14:23:19 -0800

Thanks for starting on that. The bin_PROGRAMS thing is computed automatically in 
coreutils, but is overkill for gzip. You might try adding 'bin_PROGRAMS = gzip' 
to cfg.mk.

I ran into a different problem with that patch. When I configured with 
--enable-gcc-warnings, I got:

  CC       lib/malloca.o
lib/malloca.c:18:0: error: macro "_GL_USE_STDLIB_ALLOC" is not used 
[-Werror=unused-macros]
 #define _GL_USE_STDLIB_ALLOC 1

and this is most likely a shortcoming in Gnulib that would need to be fixed there.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.