GNU bug report logs - #3385
Bug calling patched appt-display-message

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 3385 in the body.
You can then email your comments to 3385 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: Re: Bug calling patched appt-display-message
Date: Tue, 26 May 2009 02:03:52 -0400

(The mail to which I am replying does not appear in the Emacs bug
tracker owing to bug 936.)

Davin Pearson wrote:

> When I add the following line of code to my ~/.diary file:
>
> Tuesday
>    13:37 apple.wav
>
> It calls (appt-display-message STRING MINS) with the value "apple.wa"
> (without the trailing v). 

I was unable to reproduce this problem in Emacs 22.2 on GNU/Linux,
with a diary file with and without a trailing newline, and with DOS or
unix line endings.

> In GNU Emacs 22.2.1 (i386-mingw-nt5.1.2600)
>  of 2008-03-27 on RELEASE
> Windowing system distributor `Microsoft Corp.', version 5.1.2600
> configured using `configure --with-gcc (3.4)'

Message #8 received at 3385 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Jason Rumney <jasonr <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>, 3385 <at> debbugs.gnu.org
Cc: davin.pearson <at> gmail.com
Subject: Re: bug#3385: Bug calling patched appt-display-message
Date: Tue, 26 May 2009 14:54:55 +0800

Glenn Morris wrote:
> I was unable to reproduce this problem in Emacs 22.2 on GNU/Linux,
> with a diary file with and without a trailing newline, and with DOS or
> unix line endings.
>   

Likewise on Windows XP with 22.3 and current trunk.

I note the work "patched" in the subject line, and wonder if the user's 
own patches might be responsible. I suspect there have been changes made 
to the way the string is constructed, as the time is missing from the 
front of the string in the original bug report, while a study of appt.el 
shows that the time is always prepended to the string when an 
appointment is taken from the diary or created with appt-add.

Message #11 received at 3385 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 3385 <at> debbugs.gnu.org
Subject: Re: bug#3385: Bug calling patched appt-display-message
Date: Tue, 26 May 2009 16:54:12 -0400

reassign 3385 emacs,calendar
tags 3385 moreinfo unreproducible
stop

With ~/diary consisting of:

------
Tuesday
   13:07 apple.wav
------

emacs-22.2 -Q -f appt-activate

works as it should for me, displaying the full text of the appointment
in the reminder window.

Please provide a complete recipe showing the problem starting from
emacs -Q (sorry, but I don't know how you do that on Windows).

Note there should be no need to patch anything, simply set the
variable appt-disp-window-function to a function that plays a sound.
As proof of concept, this works fine for me:

emacs -Q --eval "(progn \
  (setq appt-disp-window-function \
        (lambda (mins time string) \
                (play-sound (list 'sound :file (substring string 6))))) \
  (appt-activate))"

Message #24 received at 3385 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 3385 <at> debbugs.gnu.org
Subject: Re: bug#3385: Bug calling patched appt-display-message
Date: Wed, 27 May 2009 20:49:29 -0400

tags 3385 =
stop

Davin Pearson wrote:

> I have narrowed down my code to the smallest possible file that
> reproduces the bug:
[long file]

I have to take issue with "smallest possible", since:

emacs -Q -f appt-activate

with a diary file:

----
Wednesday
 17:34 foo
 21:00 bar
----

is enough.

This is a problem introduced 3.5 years ago in rev 1.62 that I guess
has to wait for Emacs 23.2 to be fixed:


*** appt.el	5 Jan 2009 03:20:31 -0000	1.95
--- appt.el	28 May 2009 00:39:20 -0000
***************
*** 568,574 ****
                                   (match-end 0)))
                             ;; Get the whole string for this appointment.
                             (appt-time-string
!                             (substring time-string beg (if end (1- end))))
                             (appt-time (list (appt-convert-time only-time)))
                             (time-msg (list appt-time appt-time-string)))
                        ;; Add this appointment to appt-time-msg-list.
--- 568,574 ----
                                   (match-end 0)))
                             ;; Get the whole string for this appointment.
                             (appt-time-string
!                             (substring time-string beg end))
                             (appt-time (list (appt-convert-time only-time)))
                             (time-msg (list appt-time appt-time-string)))
                        ;; Add this appointment to appt-time-msg-list.

Message #31 received at 3385-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 3385-done <at> debbugs.gnu.org
Subject: Re: bug#3385: Bug calling patched appt-display-message
Date: Mon, 22 Jun 2009 02:30:01 -0400

Fixed in trunk for 23.2.

  (appt-make-list): Fix off-by-one error caused by
  differing behavior of \n and ^ in strings.  (Bug#3385)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.