From unknown Mon Jun 16 23:53:28 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#33842 <33842@debbugs.gnu.org> To: bug#33842 <33842@debbugs.gnu.org> Subject: Status: [PATCH] build: avoid build failure with --enable-gcc-warnings and latest gcc Reply-To: bug#33842 <33842@debbugs.gnu.org> Date: Tue, 17 Jun 2025 06:53:28 +0000 retitle 33842 [PATCH] build: avoid build failure with --enable-gcc-warnings= and latest gcc reassign 33842 gzip submitter 33842 Jim Meyering severity 33842 normal tag 33842 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 23 02:07:41 2018 Received: (at submit) by debbugs.gnu.org; 23 Dec 2018 07:07:41 +0000 Received: from localhost ([127.0.0.1]:60461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gaxrQ-0003QA-R2 for submit@debbugs.gnu.org; Sun, 23 Dec 2018 02:07:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gaxrN-0003Pw-CQ for submit@debbugs.gnu.org; Sun, 23 Dec 2018 02:07:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gaxrH-0008Pq-9F for submit@debbugs.gnu.org; Sun, 23 Dec 2018 02:07:32 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52589) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gaxrH-0008PV-5N for submit@debbugs.gnu.org; Sun, 23 Dec 2018 02:07:31 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52359) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gaxrG-0004i8-8g for bug-gzip@gnu.org; Sun, 23 Dec 2018 02:07:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gaxrC-0008Ib-BC for bug-gzip@gnu.org; Sun, 23 Dec 2018 02:07:30 -0500 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]:46694) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gaxrC-0008Ah-5H for bug-gzip@gnu.org; Sun, 23 Dec 2018 02:07:26 -0500 Received: by mail-pg1-x541.google.com with SMTP id w7so4371282pgp.13 for ; Sat, 22 Dec 2018 23:07:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version; bh=UXGvkW9s9bFim0f6Nigok95nRhLfeLMqB9rnACImZ34=; b=UlwbqFARe51CWjnOQykN2umCa+U6ai41l/f9DgLAndEyyCUSf2we7mPk5BS4na1dKn t4fjw9U8IH/HG8PaqEBjEyAPy9Mw05dryVdYNVy9xbcCmIatqqGwpevLIeO6id5/tRYz wbzChhcYu5d7Xi0uMu632Iieg0Yb4ExrASOhFNe9lwhh1E31G93QvQGi+sSP7PPoqOEX 5ftzj7bszWhqI+4Fw442SDfbYmOWMom+ZsUHWcOJ+cU8BVEmtQP/QQo0EVNE9+s9D9BF mFUklTyOi5z5qsUsoXyoRRBULYUv/vXcSH93fbsiRl7PEdJyYKKqZYBEOS0ds98YQbzC 54oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=UXGvkW9s9bFim0f6Nigok95nRhLfeLMqB9rnACImZ34=; b=nWnXrkGxA1mI1x7nCVRuadIhTo8dXGZPHp3iLgc1mmDUrH7z/SA5E1Mec5F//vSABW meQ0hBXhqGsZ4Sh9BI3et+4Fqzr6lqlg9h1rFFCH6tTng7ESdjVezMhM7sEndSDU3dXW lwRhbSsIUV3FqtC4OR1lcRQHrYlFU1lcCQQgRY1RnFRUrlwvVd42Yf06+UCMfBPPgZfR 07v5emLifwDL/hYPb/4JWjN+qTeSvdLAijKSPKHQKS+EuPRjanAR7UYWiQDFfCcAR/0l ZYuVTMlXMRjH3BENUpeuOa874XE0mttOKOnHAW0F80jXIGcBsMqjWJrpxio3avE1STIA Lz3Q== X-Gm-Message-State: AA+aEWbbnStwz9F7EmEZlfsWYlmcfdRyABH6O6LIXisbqCAU02sHE9qI zFjhY9KPPibPzkg+OzNdq4AUv/VN X-Google-Smtp-Source: ALg8bN4+THanbY/94JGmdF6baY1p5h5xbxomKxwPfUz8cflv+d/tEAWHraeyHTe+evTFctmiHrafSg== X-Received: by 2002:a62:e044:: with SMTP id f65mr8835746pfh.208.1545548840634; Sat, 22 Dec 2018 23:07:20 -0800 (PST) Received: from meyering-mbp ([24.249.149.4]) by smtp.gmail.com with ESMTPSA id q1sm40075660pfb.96.2018.12.22.23.07.19 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Dec 2018 23:07:19 -0800 (PST) From: Jim Meyering To: bug-gzip@gnu.org Subject: [PATCH] build: avoid build failure with --enable-gcc-warnings and latest gcc Date: Sat, 22 Dec 2018 23:07:13 -0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.7 (----) FYI, I noticed a build failure and fixed it with the change below. I've also pushed three more patches: build: make the autoconf-2.63 requirement explicit maint: update gnulib to latest; also update bootstrap and init.sh maint: improve a comment * gzip.c (do_list): There was a loop to compute the maximum width of a decimal positive off_t value. Replace it with assignment to a constant. Noticed because gcc 9.0.0 20181219 warned about its use as a printf format-width value. (OFF_T_MAX): Remove now-unused definition. --- gzip.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/gzip.c b/gzip.c index e6a7761..bef6bc6 100644 --- a/gzip.c +++ b/gzip.c @@ -115,10 +115,6 @@ static char const *const license_msg[] = { off_t lseek (int fd, off_t offset, int whence); #endif -#ifndef OFF_T_MAX -# define OFF_T_MAX TYPE_MAXIMUM (off_t) -#endif - #ifndef HAVE_WORKING_O_NOFOLLOW # define HAVE_WORKING_O_NOFOLLOW 0 #endif @@ -1737,12 +1733,7 @@ local void do_list(ifd, method) "lzh ", /* 3 */ "", "", "", "", /* 4 to 7 reserved */ "defla"}; /* 8 */ - int positive_off_t_width = 1; - off_t o; - - for (o = OFF_T_MAX; 9 < o; o /= 10) { - positive_off_t_width++; - } + int positive_off_t_width = INT_BUFSIZE_BOUND (off_t) - 2; if (first_time && method >= 0) { first_time = 0; From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 23 02:26:47 2018 Received: (at 33842-done) by debbugs.gnu.org; 23 Dec 2018 07:26:48 +0000 Received: from localhost ([127.0.0.1]:60472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gay9v-0003uN-K2 for submit@debbugs.gnu.org; Sun, 23 Dec 2018 02:26:47 -0500 Received: from mail-wr1-f53.google.com ([209.85.221.53]:36262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gay9u-0003u8-NY for 33842-done@debbugs.gnu.org; Sun, 23 Dec 2018 02:26:47 -0500 Received: by mail-wr1-f53.google.com with SMTP id u4so9049575wrp.3 for <33842-done@debbugs.gnu.org>; Sat, 22 Dec 2018 23:26:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU=; b=oNCGoEABzBYIYMw6ChYTw7lR3SN+8QKM9Jl03BPM+VuAIpgF8QgsfKOc+kCUcr3hob cDrDN5eMIFCWwNHOc2bqsNNjsKQQ0NkjKZMrdMKXRA6aDyQomiuk57AdK4AotuhFNnPT gmMNdKiV/2RA8X/ATczLzpF/Y5+lTzd8ankebr8fXezuYaBLRfaQ03Vx+Pr+WNmbSymi nBiT4Yf0Sb7UP3ZlogQKRYARVHHouqye/dbZKwSvKZ07UlPTWmbTSCy2Yk4XVBgmD5RL 5BU1/Mh+zqQuA3XjecAYj9fkR5vB1kVWsHay4gF+ZYx6CMBthrlz8czzJ5hhMnVU2f4O MVrQ== X-Gm-Message-State: AJcUukfUAJV053xulJJXdNrHoX9ekuwCx7PuM+vMIezv8tlXvxWS1TGF Hp/2ct7uQzWmL8QVo6lSCVQpz3Mx2tauorhNma/ehg== X-Google-Smtp-Source: ALg8bN7uU3btDYCjto66hzLgZaKVwnrujD3FqyPIzabzRVOWJrIw1KwVHSWJ+4ekhYaKIzCHI+myaN8Nlp3fEBwEies= X-Received: by 2002:adf:9422:: with SMTP id 31mr8529419wrq.106.1545549999752; Sat, 22 Dec 2018 23:26:39 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jim Meyering Date: Sat, 22 Dec 2018 23:26:27 -0800 Message-ID: Subject: Re: bug#33842: [PATCH] build: avoid build failure with --enable-gcc-warnings and latest gcc To: 33842-done@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 33842-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) From unknown Mon Jun 16 23:53:28 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 20 Jan 2019 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator