Subject: bug#33812: closed (Re: bug#33812: Acknowledgement ([PATCH 1/2] gnu: extra-cmake-modules: Fix install-path for plugins.))

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 04 Jan 2019 09:28:02 +0000

Your bug report

#33812: [PATCH 1/2] gnu: extra-cmake-modules: Fix install-path for plugins.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
33812: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33812
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#33812: Acknowledgement ([PATCH 1/2] gnu: extra-cmake-modules: Fix install-path for plugins.)
From: Hartmut Goebel <[email-masked]>
To: [email-masked]
Date: Fri, 4 Jan 2019 10:27:25 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Applied as b824dbec5d331e79a50734fb543bbe064eb7fc17

with trivial changes to the second patch.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | [email-masked]               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Subject: [PATCH 1/2] gnu: extra-cmake-modules: Fix install-path for plugins.
From: Hartmut Goebel <[email-masked]>
To: [email-masked]
Date: Thu, 20 Dec 2018 15:17:19 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

The respective entry changed for kde-frameworks 5.46.

* gnu/packages/kde-frameworks.scm(krunner)[#phases]<fix-lib-path>:
  Change substitute for QTPLUGINDIR.
---
 gnu/packages/kde-frameworks.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 49c986483..8997f0522 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -98,8 +98,10 @@
                (("\"lib64\"") "\"lib\"")
                ;; TODO: Base the following on values taken from Qt
                ;; Install plugins into lib/qt5/plugins
-               (("_define_relative\\(QTPLUGINDIR LIBDIR \"plugins\"")
-                "_define_relative(QTPLUGINDIR LIBDIR \"qt5/plugins\"")
+               ;; TODO: Check if this is okay for Android, too
+               ;; (see comment in KDEInstallDirs.cmake)
+               (("_define_relative\\(QTPLUGINDIR \"\\$\\{_pluginsDirParent}\" \"plugins\"")
+                "_define_relative(QTPLUGINDIR \"${_pluginsDirParent}\" \"qt5/plugins\"")
                ;; Install imports into lib/qt5/imports
                (("_define_relative\\(QTQUICKIMPORTSDIR QTPLUGINDIR \"imports\"")
                 "_define_relative(QTQUICKIMPORTSDIR LIBDIR \"qt5/imports\"")
-- 
2.13.7