From unknown Mon Jun 16 23:48:26 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#33808 <33808@debbugs.gnu.org> To: bug#33808 <33808@debbugs.gnu.org> Subject: Status: eshell keybinding Reply-To: bug#33808 <33808@debbugs.gnu.org> Date: Tue, 17 Jun 2025 06:48:26 +0000 retitle 33808 eshell keybinding reassign 33808 emacs submitter 33808 Spenser Truex severity 33808 minor tag 33808 patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 19 19:38:29 2018 Received: (at submit) by debbugs.gnu.org; 20 Dec 2018 00:38:29 +0000 Received: from localhost ([127.0.0.1]:55311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZmM8-0000sB-Ho for submit@debbugs.gnu.org; Wed, 19 Dec 2018 19:38:28 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZlLW-0007dJ-8v for submit@debbugs.gnu.org; Wed, 19 Dec 2018 18:33:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZlLN-0006Sz-3k for submit@debbugs.gnu.org; Wed, 19 Dec 2018 18:33:39 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_05, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45280) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gZlLK-0006Rn-CC for submit@debbugs.gnu.org; Wed, 19 Dec 2018 18:33:35 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZlLJ-0004aZ-G5 for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 18:33:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZlLF-0006MK-BI for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 18:33:31 -0500 Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]:44011) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gZlLE-0006KW-S0 for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 18:33:29 -0500 Received: by mail-lj1-x233.google.com with SMTP id q2-v6so7788989lji.10 for ; Wed, 19 Dec 2018 15:33:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=Y12xXhJ6qnP1vZsPz/UDra0UoIDJU3Lzh17t/uIUn80=; b=VP5xivs8CPVtjRSQAhreYjywgumPu0i+EhaApS2ybaAVhPKWuZ7ZKJc7mGxefET7BN Puu221aMt/hpDkm/wz9zAGIhZdH9no7LS88c1aHO1NzDFioV4bN7DaFEIkBkobJ6KbpH 7rltDkcC7T4pSEb12VLq8v0r7/GkYBwitpiQFTXJR0fQKbP/ReEG0+zzYVUxnW2+g0k9 Y59NdNhBi0MtWvBJzEyVRz1cQRNy3am5CQy5uO75xajDqKHYLicVxAjONih5Y6Uol8wW AaL3tngLwfa94E5/6zgY5b4sbTzFNvb3Yc/gxDPnjE7jinqDOmTuEGKw3+ShZeHhGtlv 2wbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=Y12xXhJ6qnP1vZsPz/UDra0UoIDJU3Lzh17t/uIUn80=; b=VUZEsxQfc8XTYJzi/VuRFSHe7wdhNwfa48RznOkCLxy9pzw/xZvTCgY1k7sbMiC+c9 ErmYsiM0LjInuFYcr3H5mqM6KWU4jZGfXoAtaBgQm+IyG2qRkXEWL4imGHqw31qN6DIJ LWDYdN1xlyXgRBDpTPJK2xOHA23h+LkVKH+0oJxxzmHw3/oCyciV5JmBkcUbFDJrDrIg O2k0f5y5ImSH4UOAQ+5l+I91LAX1Au/E5BHKUZiIxCVYjbf6JFwfOhidqtSErJxDNLjH JsZtP5N20p0tvnxbobVhh65Kyv8IFZF1llZ1vDM0DjUERfFrGAy6Xs0dH41irDiDdAx3 7sVQ== X-Gm-Message-State: AA+aEWbk0cbmgvv7f713rdvQauT1xjryQdh75+roOp662Is5oe6iZyIQ 3M2Q8Ow2xVMrw5RjpnZQecaqC72h2pS9XSj0lrASF2mx X-Google-Smtp-Source: AFSGD/X4xvRlc+TqDx7Rhozg9TSNJS4G5HatJZ3QtTUf+LV1/btsiMtroztcIWlE+lGXye3UW+GMzqpsQnVxrLjANmg= X-Received: by 2002:a2e:9ad0:: with SMTP id p16-v6mr15059149ljj.102.1545262407090; Wed, 19 Dec 2018 15:33:27 -0800 (PST) MIME-Version: 1.0 From: Spenser Truex Date: Wed, 19 Dec 2018 15:32:50 -0800 Message-ID: Subject: To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 19 Dec 2018 19:38:27 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) Here I reproduce an email sent to emacs-devel@gnu.org and I suggest edits to the eshell manual https://www.gnu.org/software/emacs/manual/eshell.html which currently lacks information on keybinding. This is unfortunate as eshell suffers from a major bug related to keybinding. >Hello, >It isn't possible to bind keys to eshell-mode-map using define-keys like t= his: >(define-key eshell-mode-map (kbd "") 'other-window) >instead a user must use an add-hook >(add-hook 'eshell-mode-hook (lambda () (define-key eshell-mode-map (kbd "<= C-f12>") 'other-window) >The cause of this can be seen in the patch: eshell-mode-map is set to nil = initially "for the byte compiler," then made buffer local (amusingly commen= ted out with FIXME: What the hell?!). This patch resolves the issue and man= ages to byte compile. > >What is the benefit to setting it to nil initially with respect to the byt= e compiler? The comment above the defvar Also what is the benefit of settin= g it locally when it is already defined globally? The new version byte comp= iles okay, and the above test cases work. The following also runs without i= ssue: >M-x emacs-byte-compile-and-load ;in the new esh-mode.el buffer >(require 'esh-mode) > > >I am skeptical that any performance benefit here is worth breaking the sta= ndard keybinding mechanism. And my recommended edit (to be put under the "5.4 Key rebinding" heading): Eshell currently suffers (version 27) from a bug concerning keybinding such= that >(define-key eshell-mode-map (kbd "key") 'command) cannot be used before the hooks are run. Use >(add-hook 'eshell-mode-hook > (lambda () > (define-key eshell-mode-map (kbd "key1") 'command1) > (define-key eshell-mode-map (kbd "key2") 'command2)) instead. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 20 12:50:52 2018 Received: (at control) by debbugs.gnu.org; 20 Dec 2018 17:50:52 +0000 Received: from localhost ([127.0.0.1]:56715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ga2TE-0000BD-08 for submit@debbugs.gnu.org; Thu, 20 Dec 2018 12:50:52 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ga2TC-0000Ax-01 for control@debbugs.gnu.org; Thu, 20 Dec 2018 12:50:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ga2T6-0005fj-4A for control@debbugs.gnu.org; Thu, 20 Dec 2018 12:50:44 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ga2T6-0005fX-08 for control@debbugs.gnu.org; Thu, 20 Dec 2018 12:50:44 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ga2T5-00082f-TV for control@debbugs.gnu.org; Thu, 20 Dec 2018 12:50:43 -0500 Subject: control message for bug 33808 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Thu, 20 Dec 2018 12:50:43 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) retitle 33808 eshell keybinding severity 33808 minor forwarded 33808 http://lists.gnu.org/r/emacs-devel/2018-12/msg00382.html From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 29 11:56:27 2019 Received: (at 33808) by debbugs.gnu.org; 29 Mar 2019 15:56:28 +0000 Received: from localhost ([127.0.0.1]:35988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9trn-0004Fe-KQ for submit@debbugs.gnu.org; Fri, 29 Mar 2019 11:56:27 -0400 Received: from mail-ot1-f53.google.com ([209.85.210.53]:41488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9trl-0004FR-9y for 33808@debbugs.gnu.org; Fri, 29 Mar 2019 11:56:25 -0400 Received: by mail-ot1-f53.google.com with SMTP id 64so2445755otb.8 for <33808@debbugs.gnu.org>; Fri, 29 Mar 2019 08:56:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=/NDtj/3KYv1XqHoESbDC19lxrhSIHwWpAkSUi21QeTI=; b=IR71XvAyJJZxa9tRhQZFBIlkmYZCGKhRj0TOkv1+Htu58zeCaxGkDvzzqIDJr4XG4d /RNLPxNOncfJzbdeWzH+7DpDDiiBLl4p78ZdnDuWvlBOrjWUabnH0OfBtNrKz5rrfOYX ad99HwbSXVS80JPYlYlyENzPWXZMh5N484siBavag6HCZnCon1LjUTCg/osnL2JdeB07 kDQayDyjturZFWQYIjqWxdFP6/R3MobggC5b/Gy3JAXZDKwdQNHfI+G2sl//GtQG7wqX hkj3mQJJSxDPMKUF4714YS/EQSRPZiLAqAbIj0SY9jKqUSHBBHyb0H61C3qNerH7Knav 28ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=/NDtj/3KYv1XqHoESbDC19lxrhSIHwWpAkSUi21QeTI=; b=au9KJKIOJO2FhDfSbeQ8J8mD1bfiHXG1mEUP+UsZQhUHbmRuCwHlgFXcfVs2Z/EnEx PFSBTUlzt5aIpuWA1JkGwRMpDbcj03/mYWKEJ2vR00sV2stiQXYP4M44Meo5/hgaA6yS RC86EOzStd1ZbvtEscX2CGy+SwJsHpLEqlRdCNk8rw0SQidtCCYY0UnReDzj3Ttv1pOs Dowc00+1BSXvGBzed/9Or6E3uEQ+tgOWq2oCUvI1WMJMwqm6HmFodgQKXLcbuHCGpBwO e7Baxz4kV2vOga4jOQOoVZabcGFAroWDIZwOa1xpDmu1byeaBbELk/PYHyBJrRt2r/tE /HXA== X-Gm-Message-State: APjAAAWXATF6LC39AfyEraZi/pKKhKqPvIvwy9OaenLcEA5fqg6eKk3X 2KJugj3PVgl1idAr4Uqo0MTvsoqjnYYB91k3UxI= X-Google-Smtp-Source: APXvYqwxTSAvn5H0hxa8XEawanKmPVaU7jXY7IE/fWYDVdbae2ZQo+BPdVJ1ITajekq7+cZv11eHdwWn3+bjA52LrHk= X-Received: by 2002:a9d:3d03:: with SMTP id a3mr22498904otc.72.1553874978365; Fri, 29 Mar 2019 08:56:18 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Noam Postavsky Date: Fri, 29 Mar 2019 11:56:08 -0400 Message-ID: Subject: Re: bug#33808: To: Spenser Truex Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33808 Cc: 33808@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, 19 Dec 2018 at 19:39, Spenser Truex wrote: > >It isn't possible to bind keys to eshell-mode-map using define-keys like= this: > >(define-key eshell-mode-map (kbd "") 'other-window) > >instead a user must use an add-hook > >(add-hook 'eshell-mode-hook (lambda () (define-key eshell-mode-map (kbd = "") 'other-window) > >The cause of this can be seen in the patch: eshell-mode-map is set to ni= l initially "for the byte compiler," then made buffer local (amusingly comm= ented out with FIXME: What the hell?!). This patch resolves the issue and m= anages to byte compile. > > > >What is the benefit to setting it to nil initially with respect to the b= yte compiler? The comment above the defvar Also what is the benefit of sett= ing it locally when it is already defined globally? The new version byte co= mpiles okay, and the above test cases work. It's not quite enough, because eshell-mode defines some more keys, so settings like (define-key eshell-command-map [(control ?a)] 'my-eshell-bol) would still get overridden every time eshell starts. And there are additional key definitions in other eshell files. The definitions set up by eshell-command seem the most tricky to fix (probably requires splitting out to a separate keymap): (defun eshell-return-exits-minibuffer () (define-key eshell-mode-map [(control ?g)] 'abort-recursive-edit) (define-key eshell-mode-map [return] 'exit-minibuffer) ...) (defun eshell-command (&optional command arg) ... ;; Enable `eshell-mode' only in this minibuffer. (minibuffer-with-setup-hook #'(lambda () (eshell-mode) (eshell-return-exits-minibuffer)) > And my recommended edit (to be put under the "5.4 Key rebinding" heading)= : > Eshell currently suffers (version 27) from a bug concerning keybinding su= ch that > >(define-key eshell-mode-map (kbd "key") 'command) > cannot be used before the hooks are run. We don't document bugs in the manual. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 27 11:46:31 2019 Received: (at 33808) by debbugs.gnu.org; 27 Jun 2019 15:46:31 +0000 Received: from localhost ([127.0.0.1]:39339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgWbW-00040f-QX for submit@debbugs.gnu.org; Thu, 27 Jun 2019 11:46:31 -0400 Received: from mail-ot1-f41.google.com ([209.85.210.41]:40142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgWbV-0003vV-On for 33808@debbugs.gnu.org; Thu, 27 Jun 2019 11:46:30 -0400 Received: by mail-ot1-f41.google.com with SMTP id e8so2735567otl.7 for <33808@debbugs.gnu.org>; Thu, 27 Jun 2019 08:46:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=Rzbbr+V4eJwZTrpxXSbHgfzZWSsbm42rEh3i4vPRKu4=; b=tFFhWQaV6kdMFHh2KMk3uCwIZuIzVmXO4DrOlvfZJlDTfOh0e/kfSYAL89d8E4MZgi lNE72rOqvvkGeouNrUvDVnMeTxnBvw3PpZQL1FuX4C0WrcySt9ApaTeA5/BkP9zIK7mz 7SV6Tt84BkfX2pT9Aa6gZNzc3t39AQkRxPpKF4b8mQe0h4B7lhOdYRMU+2L2zhpHLc6+ NFV23IQIz0aUABsXo6hBc9UqLsNLJdjAOuYm09KpRVVXOINu7ZRWY7Mnc60+w0yKFD4C 6DV3IKMpUhbdopJ8sEVEkk4nDIjqs0wlzUy44b8RNzfoPehvNUJPRSmlD0yze3nZbIW3 fUwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=Rzbbr+V4eJwZTrpxXSbHgfzZWSsbm42rEh3i4vPRKu4=; b=ScmTK0PZxyBzqjJYt/TqdriTzwOERl/gB5vDYA0PHNbfTPnbhPuuctyMag/FBQ4RZB 9ZjwF16UMHQHABc/IvTb/vl5olx664RUa3SwDkDgbiyf7Mn2M/iF6pv3lLYwqk8rF0jx Fqt74hwevC4hTi0n9bbiQiUfpyyMarmWXv/jBh8Htk5h1s+sXCoTjSecRO3kxUOswoAJ yja/9VOcNnZsdi2xDJLYuhNjSQDZedWH/3hD8yFXtt6AlGYKV9I3os4VimctvxY/EJQu /v6loXISyvsgxJXE/WvhZgeRA7oiqUOFOxBghxZZXbRgJRWwtquJeYCqmTtg6lmlOtOk myMA== X-Gm-Message-State: APjAAAWTpoiA7H3J4zcc7i/d+A8PU64xuqRgb+xO258lvsBnyYBSP5BU 4Omuz229zRthZIvcgBIJ0LKvLcqe X-Google-Smtp-Source: APXvYqzU4IUnFGBLfLLMOxmdSi80Q1pllVvPpjXAlr8DEsvCtryHP5EIYtcLjNNOSkLImoO7KJE6TQ== X-Received: by 2002:a9d:73d0:: with SMTP id m16mr4004842otk.190.1561650383706; Thu, 27 Jun 2019 08:46:23 -0700 (PDT) Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id w140sm941965oie.32.2019.06.27.08.46.23 for <33808@debbugs.gnu.org> (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 27 Jun 2019 08:46:23 -0700 (PDT) User-agent: mu4e 1.2.0; emacs 27.0.50 From: Alex Branham To: 33808@debbugs.gnu.org Subject: eshell keybinding Date: Thu, 27 Jun 2019 10:46:22 -0500 Message-ID: <875zor6ng1.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33808 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I think this is the same bug as bug#22792. Can someone with more debbugs-foo than me please merge these? Thanks, Alex From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 27 15:25:14 2019 Received: (at 33808) by debbugs.gnu.org; 27 Jun 2019 19:25:14 +0000 Received: from localhost ([127.0.0.1]:39734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hga1C-0007XT-Bt for submit@debbugs.gnu.org; Thu, 27 Jun 2019 15:25:14 -0400 Received: from mail-io1-f51.google.com ([209.85.166.51]:45318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hga18-0007X1-3V; Thu, 27 Jun 2019 15:25:10 -0400 Received: by mail-io1-f51.google.com with SMTP id e3so7215559ioc.12; Thu, 27 Jun 2019 12:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=POBBtYHFFbo+YCJ9tGGMIalTUZliKrDbVmIpYYn2VQo=; b=kRRWRPBUJHMqQuc02WnvdfVoXLiITi2Z3lUfAdMEQAKwd9jxUKq1TJmWsW85rQhTbl Qafv6kc71kq4+sQOs6NINv7Z9OHQZ+DLjNcTfRMt+8fDWp2Auyal6eBtXd9yZEbqI9I+ htLYNi6FygsnTQMJUGdtEMFgW15z3pTlljRV8MsOOBcJJtfaGea3SZQjr9x286U9VIZl le03JhTkRMkvg83kbbANJHNToD3FFamHfhUw+MnBsWh1EdTDUZdDP8hweDVQ7CHkVrqA u2LFFoB34JLr7jaVcbexvimRhC4l6KImoTACJYInegBVMlxH0SKyKkyl132fEELFh5+v bYLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=POBBtYHFFbo+YCJ9tGGMIalTUZliKrDbVmIpYYn2VQo=; b=kkYseoPPtHnmFbiD8bbHyZhRDP8+fsBS9DEF7lUTBVDzURaNvi/5SfIrM2R6E4Rc3v Y2SoS2BhOXZ3gQsO+M1xL0IqpjVYW6Koy9RVvBCsCnYtGHbD5712cVwu5OGtMLvSH5an YDVBQAFwYExwlQGHGEBRUt1iRuWp+QJEsmzW8ieEiQ+JC4sldcNPQYWQqR04VUHsOJRP 5ZetFLbAJRPhV8FInly4O1/brOof5DKmQBtT8Wstznc+kCf8O587RTu8mDIwj9MQ46sc 27HZsIkyPVAXuTpwmvPDgZ4yjWhwdV035MNZ3RcYWyYhhtiOCtEKXvtj8RDUpJ7tTGPA 06sw== X-Gm-Message-State: APjAAAVMD+LHUXC8gZAj/ZNiXgZyvnvhOC/WIfwVtnTtbjzcRGLQQsq0 F5ZdhNE+cYT8pj1fIsPjBd2q5y/r X-Google-Smtp-Source: APXvYqy+lAy6P76+0L9v1Y37Z/Iekil5b3HVBRIpREo/uv8k16QQxi3DvcbzZdE7y/mCXx4249aQDw== X-Received: by 2002:a02:5185:: with SMTP id s127mr6738767jaa.44.1561663504453; Thu, 27 Jun 2019 12:25:04 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.51.196]) by smtp.gmail.com with ESMTPSA id w23sm169091iod.12.2019.06.27.12.25.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Jun 2019 12:25:04 -0700 (PDT) From: Noam Postavsky To: Alex Branham Subject: Re: bug#33808: eshell keybinding References: <875zor6ng1.fsf@gmail.com> Date: Thu, 27 Jun 2019 15:25:03 -0400 In-Reply-To: <875zor6ng1.fsf@gmail.com> (Alex Branham's message of "Thu, 27 Jun 2019 10:46:22 -0500") Message-ID: <85mui26dbk.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33808 Cc: 33808@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) merge 22792 33808 quit Alex Branham writes: > I think this is the same bug as bug#22792. Can someone with more > debbugs-foo than me please merge these? Done. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 27 15:37:10 2019 Received: (at control) by debbugs.gnu.org; 27 Jun 2019 19:37:10 +0000 Received: from localhost ([127.0.0.1]:39762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgaCk-0001bc-9r for submit@debbugs.gnu.org; Thu, 27 Jun 2019 15:37:10 -0400 Received: from mail-io1-f49.google.com ([209.85.166.49]:42237) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgaCi-0001bN-Bn for control@debbugs.gnu.org; Thu, 27 Jun 2019 15:37:08 -0400 Received: by mail-io1-f49.google.com with SMTP id u19so7294278ior.9 for ; Thu, 27 Jun 2019 12:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=/dLNT3bS3+sU8xUmvMWUjd/d3KxN+Aw7z8PfW3VBdrg=; b=bc0T0pQISDYHX98e+nEkwBreByPoFIvLvnMHtzh3DeU0lm0li0tgf4usc6C8xxKASY FiBKQxU/ZacX0pd5c882doOzYRMdv0TdoKFKj9gi7Rh6shuKrqjYS/u3xL3XjDR/vea3 yhnzFwsPOxGuUVKynnWdOEbiuzhMH7Xv5EdfuWZT5N46epF/LCwKLVq+NGA0l+z+ML++ 3BM+ZfBTdSOjgmCXNTo5GZUWSVQphvSizws10Q80uBIdJn7xU4rK1TNq2KGsWXuwAPnX rOoAPc01Mc3qmeNSii4SNfZ2LjSm3WekCX/50gWwlfiQvbZxyMWn6IprzaIkuagkHmd8 abJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=/dLNT3bS3+sU8xUmvMWUjd/d3KxN+Aw7z8PfW3VBdrg=; b=buvnEQx52D9qWFpXw8uZeFHYyMKAcSLWtGbplls+CMMHzvkaDxdDrc8m/VDgRO+ceI CEJmK47Arz6VrIZAkUQsosE7o6FwHMG98Ypa1m+jaP+9gJmxdnLHMMLfgoClODADPseT jMYLArjkpLdNMHbFRBgoU4nN3OyLIme6OeROSJivYOOU0t9HwYSqpM7+r6PDfM0I8jLC p/tlu/30T2NmyBv23zokbDoibcvUsgsCP7uzFbMWvXRsaIY+6+qInTWaB4LSl3ZW6L5V o/qA1N7fLs84z3cbzigwQLmEpE2Xp7jHtRn4GhRFDX+v/JGellw3b7rOzeqXB2siY0QR B/ng== X-Gm-Message-State: APjAAAUxaRSDKWpANI2c+j15OjJD1Oij45uN16cLHEYrJLXuBZVvkqCs uI9aj8iGJlLEC+03B2O3eSz5i9U5 X-Google-Smtp-Source: APXvYqzzxvwgYFN4F9gBflFuWSrwAp6o8RFJsUVh8k8lqCCj3eX9Ll4NUx0cNQSCqR+I/FqjkngpUQ== X-Received: by 2002:a5d:8905:: with SMTP id b5mr6686857ion.291.1561664222489; Thu, 27 Jun 2019 12:37:02 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.51.196]) by smtp.gmail.com with ESMTPSA id e84sm173149iof.39.2019.06.27.12.37.01 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Jun 2019 12:37:01 -0700 (PDT) From: Noam Postavsky To: control@debbugs.gnu.org Subject: control message for bug #33808 Date: Thu, 27 Jun 2019 15:37:02 -0400 Message-ID: <85lfxm6crl.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) # second try notforwarded 33808 merge 22792 33808 quit From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 28 14:14:34 2019 Received: (at control) by debbugs.gnu.org; 28 Jun 2019 18:14:34 +0000 Received: from localhost ([127.0.0.1]:42943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgvOJ-0000fd-CC for submit@debbugs.gnu.org; Fri, 28 Jun 2019 14:14:34 -0400 Received: from mail-ot1-f42.google.com ([209.85.210.42]:45870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgvOH-0000fK-1d; Fri, 28 Jun 2019 14:14:30 -0400 Received: by mail-ot1-f42.google.com with SMTP id x21so6860607otq.12; Fri, 28 Jun 2019 11:14:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=Wn9y/fLy2tgarmmLwukz7hgZDTYI1cr6dLWddMq3Tn0=; b=FZ2Y4efKIFkulA2NMcp+oC1qwQacZ9soGb0M3j5YLqX13qbiWQIr5lRbVfrljhTHsV rZHnLK9nNzVdepRMG0k8SOgxMeeE4kxcRDSTYAPla4Nz9zB6SDQ/pL8NweVn2xbDC6ss lBCQdQ0uP6lI5XKgJaSsDPEoF0svJ78aH7CdOnfLaxE02wKKoUreFB8Aly6+sUs7XuKR ouK2orX5FrPssKRWkGaLJXCyOZmHpEFO7qzfwUpe5z0PJHv5YmXsS6843EhHFmsBWvmd C740f/1rOy/8g/9wxCMJuQIxrxQcZW57cZ8yV0qx0uqP4XTBOrcnGBfsCzjSAs9HwC1N P6fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=Wn9y/fLy2tgarmmLwukz7hgZDTYI1cr6dLWddMq3Tn0=; b=noOBiOvEecftyKYU6VqjkNOoU/QPDRId4YZe7JznxuJN2lUQeEjd1YNroGIaRPr4BQ 3eZuNHFPsJXUBjnEjnICk1eteMLypJvn9qGts5oQuzwYjowKHRcvloGxZPzvXxbiwLaQ K8XU8IBq74SzJhJ4wuT2suEpj2pk71RScUm3nAKSDb9S5qORggp0QV4U/k0Ikh+XFlkz 7JgBx3PaWrDQic/b8gD4MEl/kcVz2iuzk3S9v9605cwD3zRkachBkurr7Wx76cgcGEJU 8cWiYy9AaAAtq1FG80C/mCBT/+s3ZhD9rgspTb06VEnAn9QnNdrZwjP8oAJZU9FQRqkS KJdg== X-Gm-Message-State: APjAAAWeHK9Xj+6awGsaS4rAitOvHgwFy/APznkxuvK7hN+YI4NcwirN Q/VLbSlv+10G/pZaKjJbw/FizXXGbDc= X-Google-Smtp-Source: APXvYqz2sSdUwf1sqRbQKOmPCDew0b9W0bmFTgMDwc6r9cNLQNh+iA3NrxzC6zhjSw009ORkiMXmqg== X-Received: by 2002:a05:6830:1042:: with SMTP id b2mr9269312otp.345.1561745662989; Fri, 28 Jun 2019 11:14:22 -0700 (PDT) Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id i19sm968322oib.12.2019.06.28.11.14.21 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 28 Jun 2019 11:14:21 -0700 (PDT) References: <56CDC6D3.1050106@boccaperta.com> <877e976nhx.fsf@gmail.com> <85pnmy6deq.fsf@gmail.com> User-agent: mu4e 1.2.0; emacs 27.0.50 From: Alex Branham To: Noam Postavsky Subject: Re: bug#22792: eshell-mode-map declaration In-reply-to: <85pnmy6deq.fsf@gmail.com> Date: Fri, 28 Jun 2019 13:14:20 -0500 Message-ID: <87woh5mvb7.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: control@debbugs.gnu.org, 22792@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain tags 22792 patch quit On Thu 27 Jun 2019 at 14:23, Noam Postavsky wrote: > Alex Branham writes: > >> We could create an em-cmpl minor mode with its own keymap, I >> suppose. Would that be satisfactory? > > Makes sense to me. OK, here's a patch that does so. The general idea is to make a minor mode with its own keymap for each of eshell's modules that (previously) assigned their keybindings into eshell-mode-map. Alex --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-eshell-mode-map-initialization.patch >From 00e5ad69971e7f9abacf10d25325bdee6088f648 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Wed, 26 Jun 2019 13:59:06 -0500 Subject: [PATCH] Fix eshell-mode-map initialization * lisp/eshell/esh-mode.el (eshell-mode-map): (eshell-command-map): Set up normal keymaps and prefix commands rather than re-initializing them in each eshell buffer * lisp/eshell/em-cmpl.el (eshell-cmpl-mode-map): (eshell-cmpl-mode): (eshell-cmpl-initialize): * lisp/eshell/em-hist.el (eshell-hist-mode-map): (eshell-hist-mode): (eshell-hist-initialize): * lisp/eshell/em-pred.el (eshell-pred-mode-map): (eshell-pred-mode): (eshell-pred-initialize): * lisp/eshell/em-prompt.el (eshell-prompt-mode-map): (eshell-prompt-mode): (eshell-prompt-initialize): * lisp/eshell/em-rebind.el (eshell-rebind-mode-map): (eshell-rebind-mode): (eshell-rebind-initialize): * lisp/eshell/esh-arg.el (eshell-arg-mode-map): (eshell-arg-mode): (eshell-arg-initialize): * lisp/eshell/esh-proc.el (eshell-proc-mode-map): (eshell-proc-mode): (eshell-proc-initialize): * lisp/eshell/esh-var.el (eshell-var-mode-map): (eshell-var-mode): (eshell-var-initialize): Create a new minor mode with a keymap and call it in the module initialization function. bug#33808 bug#22792 --- etc/NEWS | 5 ++++ lisp/eshell/em-cmpl.el | 33 ++++++++++++---------- lisp/eshell/em-hist.el | 60 +++++++++++++++++++++------------------- lisp/eshell/em-pred.el | 13 +++++++-- lisp/eshell/em-prompt.el | 14 ++++++++-- lisp/eshell/em-rebind.el | 11 +++++++- lisp/eshell/esh-arg.el | 14 +++++++--- lisp/eshell/esh-mode.el | 58 +++++++++++++++++--------------------- lisp/eshell/esh-proc.el | 26 +++++++++-------- lisp/eshell/esh-var.el | 14 ++++++---- 10 files changed, 148 insertions(+), 100 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 864eb8c110..83fac26e3a 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1237,6 +1237,11 @@ default, and not just the opening element. behave similarly, e.g. Pcomplete's default cycling can be obtained with '(setq completion-cycle-threshold 5)'. +*** Eshell no longer re-initializes its keymap every call. +This allows users to use (define-key eshell-mode-map ...) as usual. +Some modules have their own minor mode now to account for these +changes. + --- *** Expansion of history event designators is disabled by default. To restore the old behavior, use diff --git a/lisp/eshell/em-cmpl.el b/lisp/eshell/em-cmpl.el index 8f6c6781b9..952091a479 100644 --- a/lisp/eshell/em-cmpl.el +++ b/lisp/eshell/em-cmpl.el @@ -244,6 +244,24 @@ to writing a completion function." (let ((completion-at-point-functions '(lisp-completion-at-point))) (completion-at-point))) +(defvar eshell-cmpl-mode-map + (let ((map (make-sparse-keymap))) + (define-key map [(control ?i)] #'completion-at-point) + ;; jww (1999-10-19): Will this work on anything but X? + (define-key map [backtab] #'pcomplete-reverse) + (define-key map [(meta ??)] #'completion-help-at-point) + (define-key map [(meta control ?i)] #'eshell-complete-lisp-symbol) + ;; C-c prefix: + (define-key map (kbd "C-c M-h") #'eshell-completion-help) + (define-key map (kbd "C-c TAB") #'pcomplete-expand-and-complete) + (define-key map (kbd "C-c C-i") #'pcomplete-expand-and-complete) + (define-key map (kbd "C-c SPC") #'pcomplete-expand) + map)) + +(define-minor-mode eshell-cmpl-mode + "Minor mode that provides a keymap when `eshell-cmpl' active." + :keymap eshell-cmpl-mode-map) + (defun eshell-cmpl-initialize () ;Called from `eshell-mode' via intern-soft! "Initialize the completions module." (set (make-local-variable 'pcomplete-command-completion-function) @@ -291,22 +309,9 @@ to writing a completion function." eshell-special-chars-outside-quoting))) nil t) (add-hook 'pcomplete-quote-arg-hook #'eshell-quote-backslash nil t) - ;;(define-key eshell-mode-map [(meta tab)] 'eshell-complete-lisp-symbol) ; Redundant - (define-key eshell-mode-map [(meta control ?i)] 'eshell-complete-lisp-symbol) - (define-key eshell-command-map [(meta ?h)] 'eshell-completion-help) - (define-key eshell-command-map [tab] 'pcomplete-expand-and-complete) - (define-key eshell-command-map [(control ?i)] - 'pcomplete-expand-and-complete) - (define-key eshell-command-map [space] 'pcomplete-expand) - (define-key eshell-command-map [? ] 'pcomplete-expand) - ;;(define-key eshell-mode-map [tab] 'completion-at-point) ;Redundant! - (define-key eshell-mode-map [(control ?i)] 'completion-at-point) (add-hook 'completion-at-point-functions #'pcomplete-completions-at-point nil t) - ;; jww (1999-10-19): Will this work on anything but X? - (define-key eshell-mode-map - (if (featurep 'xemacs) [iso-left-tab] [backtab]) 'pcomplete-reverse) - (define-key eshell-mode-map [(meta ??)] 'completion-help-at-point)) + (eshell-cmpl-mode)) (defun eshell-completion-command-name () "Return the command name, possibly sans globbing." diff --git a/lisp/eshell/em-hist.el b/lisp/eshell/em-hist.el index adb028002b..19782e8d6c 100644 --- a/lisp/eshell/em-hist.el +++ b/lisp/eshell/em-hist.el @@ -202,6 +202,32 @@ element, regardless of any text on the command line. In that case, map) "Keymap used in isearch in Eshell.") +(defvar eshell-hist-mode-map + (let ((map (make-sparse-keymap))) + (define-key map [up] #'eshell-previous-matching-input-from-input) + (define-key map [down] #'eshell-next-matching-input-from-input) + (define-key map [(control up)] #'eshell-previous-input) + (define-key map [(control down)] #'eshell-next-input) + (define-key map [(meta ?r)] #'eshell-previous-matching-input) + (define-key map [(meta ?s)] #'eshell-next-matching-input) + (define-key map (kbd "C-c M-r") #'eshell-previous-matching-input-from-input) + (define-key map (kbd "C-c M-s") #'eshell-next-matching-input-from-input) + ;; FIXME: Relies on `eshell-hist-match-partial' being set _before_ + ;; em-hist is loaded and won't respect changes. + (if eshell-hist-match-partial + (progn + (define-key map [(meta ?p)] 'eshell-previous-matching-input-from-input) + (define-key map [(meta ?n)] 'eshell-next-matching-input-from-input) + (define-key map (kbd "C-c M-p") #'eshell-previous-input) + (define-key map (kbd "C-c M-n") #'eshell-next-input)) + (define-key map [(meta ?p)] #'eshell-previous-input) + (define-key map [(meta ?n)] #'eshell-next-input) + (define-key map (kbd "C-c M-p") #'eshell-previous-matching-input-from-input) + (define-key map (kbd "C-c M-n") #'eshell-next-matching-input-from-input)) + (define-key map (kbd "C-c C-l") #'eshell-list-history) + (define-key map (kbd "C-c C-x") #'eshell-get-next-from-history) + map)) + (defvar eshell-rebind-keys-alist) ;;; Functions: @@ -216,6 +242,10 @@ Returns non-nil if INPUT is blank." Returns nil if INPUT is prepended by blank space, otherwise non-nil." (not (string-match-p "\\`\\s-+" input))) +(define-minor-mode eshell-hist-mode + "Minor mode for the eshell-hist module." + :keymap eshell-hist-mode-map) + (defun eshell-hist-initialize () ;Called from `eshell-mode' via intern-soft! "Initialize the history management code for one Eshell buffer." (when (eshell-using-module 'eshell-cmpl) @@ -242,30 +272,7 @@ Returns nil if INPUT is prepended by blank space, otherwise non-nil." (lambda () (setq overriding-terminal-local-map nil))) nil t)) - (define-key eshell-mode-map [up] 'eshell-previous-matching-input-from-input) - (define-key eshell-mode-map [down] 'eshell-next-matching-input-from-input) - (define-key eshell-mode-map [(control up)] 'eshell-previous-input) - (define-key eshell-mode-map [(control down)] 'eshell-next-input) - (define-key eshell-mode-map [(meta ?r)] 'eshell-previous-matching-input) - (define-key eshell-mode-map [(meta ?s)] 'eshell-next-matching-input) - (define-key eshell-command-map [(meta ?r)] - 'eshell-previous-matching-input-from-input) - (define-key eshell-command-map [(meta ?s)] - 'eshell-next-matching-input-from-input) - (if eshell-hist-match-partial - (progn - (define-key eshell-mode-map [(meta ?p)] - 'eshell-previous-matching-input-from-input) - (define-key eshell-mode-map [(meta ?n)] - 'eshell-next-matching-input-from-input) - (define-key eshell-command-map [(meta ?p)] 'eshell-previous-input) - (define-key eshell-command-map [(meta ?n)] 'eshell-next-input)) - (define-key eshell-mode-map [(meta ?p)] 'eshell-previous-input) - (define-key eshell-mode-map [(meta ?n)] 'eshell-next-input) - (define-key eshell-command-map [(meta ?p)] - 'eshell-previous-matching-input-from-input) - (define-key eshell-command-map [(meta ?n)] - 'eshell-next-matching-input-from-input))) + (eshell-hist-mode)) (make-local-variable 'eshell-history-size) (or eshell-history-size @@ -300,10 +307,7 @@ Returns nil if INPUT is prepended by blank space, otherwise non-nil." (add-hook 'kill-emacs-hook #'eshell-save-some-history) (make-local-variable 'eshell-input-filter-functions) - (add-hook 'eshell-input-filter-functions #'eshell-add-to-history nil t) - - (define-key eshell-command-map [(control ?l)] 'eshell-list-history) - (define-key eshell-command-map [(control ?x)] 'eshell-get-next-from-history)) + (add-hook 'eshell-input-filter-functions #'eshell-add-to-history nil t)) (defun eshell-save-some-history () "Save the history for any open Eshell buffers." diff --git a/lisp/eshell/em-pred.el b/lisp/eshell/em-pred.el index 9bc856a296..1017e2b7c0 100644 --- a/lisp/eshell/em-pred.el +++ b/lisp/eshell/em-pred.el @@ -229,6 +229,12 @@ FOR LISTS OF ARGUMENTS: EXAMPLES: *.c(:o) sorted list of .c files") +(defvar eshell-pred-mode-map + (let ((map (make-sparse-keymap))) + (define-key map (kbd "C-c M-q") #'eshell-display-predicate-help) + (define-key map (kbd "C-c M-m") #'eshell-display-modifier-help) + map)) + ;;; Functions: (defun eshell-display-predicate-help () @@ -245,12 +251,15 @@ EXAMPLES: (lambda () (insert eshell-modifier-help-string))))) +(define-minor-mode eshell-pred-mode + "Minor mode for the eshell-pred module." + :keymap eshell-pred-mode-map) + (defun eshell-pred-initialize () ;Called from `eshell-mode' via intern-soft! "Initialize the predicate/modifier code." (add-hook 'eshell-parse-argument-hook #'eshell-parse-arg-modifier t t) - (define-key eshell-command-map [(meta ?q)] 'eshell-display-predicate-help) - (define-key eshell-command-map [(meta ?m)] 'eshell-display-modifier-help)) + (eshell-pred-mode)) (defun eshell-apply-modifiers (lst predicates modifiers) "Apply to LIST a series of PREDICATES and MODIFIERS." diff --git a/lisp/eshell/em-prompt.el b/lisp/eshell/em-prompt.el index adc68b6c85..9c396ce627 100644 --- a/lisp/eshell/em-prompt.el +++ b/lisp/eshell/em-prompt.el @@ -97,8 +97,18 @@ arriving, or after." :options '(eshell-show-maximum-output) :group 'eshell-prompt) +(defvar eshell-prompt-mode-map + (let ((map (make-sparse-keymap))) + (define-key map (kbd "C-c C-n") #'eshell-next-prompt) + (define-key map (kbd "C-c C-p") #'eshell-previous-prompt) + map)) + ;;; Functions: +(define-minor-mode eshell-prompt-mode + "Minor mode for eshell-prompt module." + :keymap eshell-prompt-mode-map) + (defun eshell-prompt-initialize () ;Called from `eshell-mode' via intern-soft! "Initialize the prompting code." (unless eshell-non-interactive-p @@ -110,9 +120,7 @@ arriving, or after." (set (make-local-variable 'eshell-skip-prompt-function) 'eshell-skip-prompt) - - (define-key eshell-command-map [(control ?n)] 'eshell-next-prompt) - (define-key eshell-command-map [(control ?p)] 'eshell-previous-prompt))) + (eshell-prompt-mode))) (defun eshell-emit-prompt () "Emit a prompt if eshell is being used interactively." diff --git a/lisp/eshell/em-rebind.el b/lisp/eshell/em-rebind.el index a817edbcc9..318f13d244 100644 --- a/lisp/eshell/em-rebind.el +++ b/lisp/eshell/em-rebind.el @@ -137,6 +137,11 @@ This is default behavior of shells like bash." :type '(repeat function) :group 'eshell-rebind) +(defvar eshell-rebind-mode-map + (let ((map (make-sparse-keymap))) + (define-key map (kbd "C-c M-l") #'eshell-lock-local-map) + map)) + ;; Internal Variables: (defvar eshell-input-keymap) @@ -145,6 +150,10 @@ This is default behavior of shells like bash." ;;; Functions: +(define-minor-mode eshell-rebind-mode + "Minor mode for the eshell-rebind module." + :keymap eshell-rebind-mode-map) + (defun eshell-rebind-initialize () ;Called from `eshell-mode' via intern-soft! "Initialize the inputting code." (unless eshell-non-interactive-p @@ -154,7 +163,7 @@ This is default behavior of shells like bash." (make-local-variable 'overriding-local-map) (add-hook 'post-command-hook 'eshell-rebind-input-map nil t) (set (make-local-variable 'eshell-lock-keymap) nil) - (define-key eshell-command-map [(meta ?l)] 'eshell-lock-local-map))) + (eshell-rebind-mode))) (defun eshell-lock-local-map (&optional arg) "Lock or unlock the current local keymap. diff --git a/lisp/eshell/esh-arg.el b/lisp/eshell/esh-arg.el index 026edc5980..bd31703e0d 100644 --- a/lisp/eshell/esh-arg.el +++ b/lisp/eshell/esh-arg.el @@ -155,14 +155,20 @@ treated as a literal character." :type 'hook :group 'eshell-arg) +(defvar eshell-arg-mode-map + (let ((map (make-sparse-keymap))) + (define-key map (kbd "C-c M-b") #'eshell-insert-buffer-name) + map)) + ;;; Functions: +(define-minor-mode eshell-arg-mode + "Minor mode for the arg eshell module." + :keymap eshell-arg-mode-map) + (defun eshell-arg-initialize () ;Called from `eshell-mode' via intern-soft! "Initialize the argument parsing code." - ;; This is supposedly run after enabling esh-mode, when eshell-mode-map - ;; already exists. - (defvar eshell-command-map) - (define-key eshell-command-map [(meta ?b)] 'eshell-insert-buffer-name) + (eshell-arg-mode) (set (make-local-variable 'eshell-inside-quote-regexp) nil) (set (make-local-variable 'eshell-outside-quote-regexp) nil)) diff --git a/lisp/eshell/esh-mode.el b/lisp/eshell/esh-mode.el index 80844c3a64..91204877f5 100644 --- a/lisp/eshell/esh-mode.el +++ b/lisp/eshell/esh-mode.el @@ -213,10 +213,7 @@ This is used by `eshell-watch-for-password-prompt'." ;; these are only set to nil initially for the sake of the ;; byte-compiler, when compiling other files which `require' this one (defvar eshell-mode nil) -(defvar eshell-mode-map nil) (defvar eshell-command-running-string "--") -(defvar eshell-command-map nil) -(defvar eshell-command-prefix nil) (defvar eshell-last-input-start nil) (defvar eshell-last-input-end nil) (defvar eshell-last-output-start nil) @@ -286,6 +283,32 @@ This is used by `eshell-watch-for-password-prompt'." (standard-syntax-table)) st)) +(defvar eshell-mode-map + (let ((map (make-sparse-keymap))) + (define-key map [(control ?c)] 'eshell-command-map) + (define-key map "\r" #'eshell-send-input) + (define-key map "\M-\r" #'eshell-queue-input) + (define-key map [(meta control ?l)] #'eshell-show-output) + (define-key map [(control ?a)] #'eshell-bol) + map)) + +(defvar eshell-command-map + (let ((map (define-prefix-command 'eshell-command-map))) + (define-key map [(meta ?o)] #'eshell-mark-output) + (define-key map [(meta ?d)] #'eshell-toggle-direct-send) + (define-key map [(control ?a)] #'eshell-bol) + (define-key map [(control ?b)] #'eshell-backward-argument) + (define-key map [(control ?e)] #'eshell-show-maximum-output) + (define-key map [(control ?f)] #'eshell-forward-argument) + (define-key map [(control ?m)] #'eshell-copy-old-input) + (define-key map [(control ?o)] #'eshell-kill-output) + (define-key map [(control ?r)] #'eshell-show-output) + (define-key map [(control ?t)] #'eshell-truncate-buffer) + (define-key map [(control ?u)] #'eshell-kill-input) + (define-key map [(control ?w)] #'backward-kill-word) + (define-key map [(control ?y)] #'eshell-repeat-argument) + map)) + ;;; User Functions: (defun eshell-kill-buffer-function () @@ -304,10 +327,6 @@ and the hook `eshell-exit-hook'." "Emacs shell interactive mode." (setq-local eshell-mode t) - ;; FIXME: What the hell!? - (setq-local eshell-mode-map (make-sparse-keymap)) - (use-local-map eshell-mode-map) - (when eshell-status-in-mode-line (make-local-variable 'eshell-command-running-string) (let ((fmt (copy-sequence mode-line-format))) @@ -316,31 +335,6 @@ and the hook `eshell-exit-hook'." (if mode-line-elt (setcar mode-line-elt 'eshell-command-running-string)))) - (define-key eshell-mode-map "\r" 'eshell-send-input) - (define-key eshell-mode-map "\M-\r" 'eshell-queue-input) - (define-key eshell-mode-map [(meta control ?l)] 'eshell-show-output) - (define-key eshell-mode-map [(control ?a)] 'eshell-bol) - - (setq-local eshell-command-prefix (make-symbol "eshell-command-prefix")) - (fset eshell-command-prefix (make-sparse-keymap)) - (setq-local eshell-command-map (symbol-function eshell-command-prefix)) - (define-key eshell-mode-map [(control ?c)] eshell-command-prefix) - - (define-key eshell-command-map [(meta ?o)] 'eshell-mark-output) - (define-key eshell-command-map [(meta ?d)] 'eshell-toggle-direct-send) - - (define-key eshell-command-map [(control ?a)] 'eshell-bol) - (define-key eshell-command-map [(control ?b)] 'eshell-backward-argument) - (define-key eshell-command-map [(control ?e)] 'eshell-show-maximum-output) - (define-key eshell-command-map [(control ?f)] 'eshell-forward-argument) - (define-key eshell-command-map [(control ?m)] 'eshell-copy-old-input) - (define-key eshell-command-map [(control ?o)] 'eshell-kill-output) - (define-key eshell-command-map [(control ?r)] 'eshell-show-output) - (define-key eshell-command-map [(control ?t)] 'eshell-truncate-buffer) - (define-key eshell-command-map [(control ?u)] 'eshell-kill-input) - (define-key eshell-command-map [(control ?w)] 'backward-kill-word) - (define-key eshell-command-map [(control ?y)] 'eshell-repeat-argument) - (setq local-abbrev-table eshell-mode-abbrev-table) (set (make-local-variable 'list-buffers-directory) diff --git a/lisp/eshell/esh-proc.el b/lisp/eshell/esh-proc.el index 32a3eecb52..7825377e66 100644 --- a/lisp/eshell/esh-proc.el +++ b/lisp/eshell/esh-proc.el @@ -109,6 +109,16 @@ information, for example." (defvar eshell-process-list nil "A list of the current status of subprocesses.") +(defvar eshell-proc-mode-map + (let ((map (make-sparse-keymap))) + (define-key map (kbd "C-c M-i") #'eshell-insert-process) + (define-key map (kbd "C-c C-c") #'eshell-interrupt-process) + (define-key map (kbd "C-c C-k") #'eshell-kill-process) + (define-key map (kbd "C-c C-d") #'eshell-send-eof-to-process) + (define-key map (kbd "C-c C-s") #'list-processes) + (define-key map (kbd "C-c C-\\") #'eshell-quit-process) + map)) + ;;; Functions: (defun eshell-kill-process-function (proc status) @@ -121,20 +131,14 @@ PROC and STATUS to functions on the latter." (eshell-reset-after-proc status) (run-hook-with-args 'eshell-kill-hook proc status)) +(define-minor-mode eshell-proc-mode + "Minor mode for the proc eshell module." + :keymap eshell-proc-mode-map) + (defun eshell-proc-initialize () ;Called from `eshell-mode' via intern-soft! "Initialize the process handling code." (make-local-variable 'eshell-process-list) - ;; This is supposedly run after enabling esh-mode, when eshell-command-map - ;; already exists. - (defvar eshell-command-map) - (define-key eshell-command-map [(meta ?i)] 'eshell-insert-process) - (define-key eshell-command-map [(control ?c)] 'eshell-interrupt-process) - (define-key eshell-command-map [(control ?k)] 'eshell-kill-process) - (define-key eshell-command-map [(control ?d)] 'eshell-send-eof-to-process) -; (define-key eshell-command-map [(control ?q)] 'eshell-continue-process) - (define-key eshell-command-map [(control ?s)] 'list-processes) -; (define-key eshell-command-map [(control ?z)] 'eshell-stop-process) - (define-key eshell-command-map [(control ?\\)] 'eshell-quit-process)) + (eshell-proc-mode)) (defun eshell-reset-after-proc (status) "Reset the command input location after a process terminates. diff --git a/lisp/eshell/esh-var.el b/lisp/eshell/esh-var.el index b08a5d242f..00bea09384 100644 --- a/lisp/eshell/esh-var.el +++ b/lisp/eshell/esh-var.el @@ -197,8 +197,17 @@ function), and the arguments passed to this function would be the list (put 'eshell-variable-aliases-list 'risky-local-variable t) +(defvar eshell-var-mode-map + (let ((map (make-sparse-keymap))) + (define-key map (kbd "C-c M-v") #'eshell-insert-envvar) + map)) + ;;; Functions: +(define-minor-mode eshell-var-mode + "Minor mode for the esh-var module." + :keymap eshell-var-mode-map) + (defun eshell-var-initialize () ;Called from `eshell-mode' via intern-soft! "Initialize the variable handle code." ;; Break the association with our parent's environment. Otherwise, @@ -207,11 +216,6 @@ function), and the arguments passed to this function would be the list (set (make-local-variable 'process-environment) (eshell-copy-environment))) - ;; This is supposedly run after enabling esh-mode, when eshell-command-map - ;; already exists. - (defvar eshell-command-map) - (define-key eshell-command-map [(meta ?v)] 'eshell-insert-envvar) - (set (make-local-variable 'eshell-special-chars-inside-quoting) (append eshell-special-chars-inside-quoting '(?$))) (set (make-local-variable 'eshell-special-chars-outside-quoting) -- 2.22.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 15 20:56:46 2019 Received: (at control) by debbugs.gnu.org; 16 Aug 2019 00:56:46 +0000 Received: from localhost ([127.0.0.1]:52738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyQXu-0008IO-4v for submit@debbugs.gnu.org; Thu, 15 Aug 2019 20:56:46 -0400 Received: from mail-io1-f48.google.com ([209.85.166.48]:44089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyQXs-0008I8-Dk; Thu, 15 Aug 2019 20:56:44 -0400 Received: by mail-io1-f48.google.com with SMTP id j4so2989994iop.11; Thu, 15 Aug 2019 17:56:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=TlC1NVJxbj5C8+rGt8Vb/rcu8k5T0CflvFsoZPEbJD4=; b=RhXiAVuaeDKlLK/it0T0Kq+IEc/PsKmZQKdTNt1GA5WMnHIH/CQtEiv+HCQI7Sj6c5 +vqfQgaBDjBENE62wfhe8jmN8nr8k4Hdd96Y75VscWRcHWJqXn3qIZSiqJgJS7Y0IGUC K6cAzxAjdgUA10LLqDNKfhYCeK0BngUBuiKlevxyHqpZIezdq8KGM6ED+zzZjfh/mB4a IBtbK+7LyB6+WmJ1qJWTVGoHAECQZkHf3bLF0y7AFgGklHF1ep3oDDW0qJ/+dQRgjWMI uXgA/jj9rJ5E2sGk592B4CA+FDpaeb3LF/a7qHmXfx/NNdFQ2wqehS+m4p06yNTbXsHj 5Tug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=TlC1NVJxbj5C8+rGt8Vb/rcu8k5T0CflvFsoZPEbJD4=; b=Lqz+/XejWS67aji3xgRb7zsLOejXRUYFgtfvABFmMA2mKGDwgVw5vFegBnOti8r5d3 Dn0+gPVgFr2CD7Jsgr9W8LtV2058NeJ8q2LkKVh9rTpU3mn5OEzn4J/70MQRklZprNAB nPZJrg0bGdIMhT5+Eu9PVJPt8mu9bKZUWMnUllu3fevGJoTQJd8+qgMLgOlDYywk+Cdl wohsRenvDZ4gPkQ1pQMUCLPtAzSwvpe7HSBmkK8HC1PVqpL2w+Gk87ozTTnMQRpmqJzd yTJJ7N0Z0QYyq5ZGl6v7pC2ZyHvYl82MnKMH0NEFaepIh7I18ZgRV4fNlK9JSJDGgwhS 0X3w== X-Gm-Message-State: APjAAAX00k8gS6j64CBnBeUnOtc+HsZk68WWl27M8xLnV9+FaOU7iE8i 60CZDrnD02x8Pc1ku56pawebWLlj X-Google-Smtp-Source: APXvYqwitfx3ihieCSGGuKMHu2DU3rEqjuMXscTlRbUXx286tDtBNJP/8f3tD2zLEoi0iRPqDm5hxQ== X-Received: by 2002:a6b:f002:: with SMTP id w2mr8799858ioc.104.1565916998653; Thu, 15 Aug 2019 17:56:38 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id s3sm4012829iob.49.2019.08.15.17.56.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Aug 2019 17:56:38 -0700 (PDT) From: Noam Postavsky To: Alex Branham Subject: Re: bug#22792: eshell-mode-map declaration References: <56CDC6D3.1050106@boccaperta.com> <877e976nhx.fsf@gmail.com> <85pnmy6deq.fsf@gmail.com> <87woh5mvb7.fsf@gmail.com> <87v9wf4zss.fsf@gmail.com> <87ftm5uj0y.fsf@gmail.com> Date: Thu, 15 Aug 2019 20:56:37 -0400 In-Reply-To: <87ftm5uj0y.fsf@gmail.com> (Alex Branham's message of "Tue, 13 Aug 2019 11:28:29 -0500") Message-ID: <87lfvuorlm.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: control Cc: 22792@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) tags 22792 fixed close 22792 27.1 quit Alex Branham writes: > I don't know of a straightforward way to keep those in C-h m since this > uses minor modes, but it's easy enough to add those into the docstring > of the minor mode. Alright, good enough for now, I think. Pushed to master. 1ee0192b79 2019-08-15T20:49:15-04:00 "Fix eshell-mode-map initialization" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1ee0192b792124663a0a40a729dd83c047d21535 > The more I think about this the more I wonder whether the whole > eshell-module framework should just be moved to minor modes, then we > could just call run-hooks on eshell-modules to set everything up. But > that's a question for a later day I suppose. Agreed on both counts. > * lisp/eshell/esh-mode.el (eshell-mode-map): > (eshell-command-map): Set up normal keymaps and prefix commands rather > than re-initializing them in each eshell buffer > > * lisp/eshell/em-cmpl.el (eshell-cmpl-mode-map): > (eshell-cmpl-mode): > (eshell-cmpl-initialize): > * lisp/eshell/em-hist.el (eshell-hist-mode-map): > (eshell-hist-mode): > (eshell-hist-initialize): > * lisp/eshell/em-pred.el (eshell-pred-mode-map): > (eshell-pred-mode): > (eshell-pred-initialize): > * lisp/eshell/em-prompt.el (eshell-prompt-mode-map): > (eshell-prompt-mode): > (eshell-prompt-initialize): > * lisp/eshell/em-rebind.el (eshell-rebind-mode-map): > (eshell-rebind-mode): > (eshell-rebind-initialize): > * lisp/eshell/esh-arg.el (eshell-arg-mode-map): > (eshell-arg-mode): > (eshell-arg-initialize): > * lisp/eshell/esh-proc.el (eshell-proc-mode-map): > (eshell-proc-mode): > (eshell-proc-initialize): > * lisp/eshell/esh-var.el (eshell-var-mode-map): > (eshell-var-mode): > (eshell-var-initialize): Create a new minor mode with a keymap and > call it in the module initialization function. By the way, the formatting of the ChangeLog entries is bit off here (there shouldn't be a colon between empty entries of the same file). But it's a nice use-case for the new log-edit-fill-entry: I can fix it with just two presses of M-q :) From unknown Mon Jun 16 23:48:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 13 Sep 2019 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Sun May 24 20:28:10 2020 Received: (at control) by debbugs.gnu.org; 25 May 2020 00:28:10 +0000 Received: from localhost ([127.0.0.1]:39105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jd0yP-0005c8-Nk for submit@debbugs.gnu.org; Sun, 24 May 2020 20:28:09 -0400 Received: from mail-qt1-f182.google.com ([209.85.160.182]:39563) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jd0yO-0005bt-IF; Sun, 24 May 2020 20:28:09 -0400 Received: by mail-qt1-f182.google.com with SMTP id l1so12776247qtp.6; Sun, 24 May 2020 17:28:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=sox1taBnmCIiJl0rJY4ZCgP573DHrvF0Gg21Q72cZRw=; b=rq8uk8cOWHUfFajGfAhhyk+0097T7k2g+WC9vsdXbfTjhOn5jt78FTQ0Xt+SssYbyT mDE5/30esvaFqG8jW7Z0Vej9Om92MhnZbGDwcK6AjBOtyShQexvxVXQi72Y7Z5T4P8Ll kImHcRoHRWBBQKUIlF70xhHaM5rauh9w0cHqKChOuT2/3PvklGKvUwR/jxMEFLTYoY0z 4pnrZgnGFcQFzTO8FP54ckofHX3I9K9HFvHfXl0YzwRtFrH42Ejr9OEtl3mnV/OyXsv4 pFXth1levTThoCXcJRnIfsOjpuMtO6GpH/Ro96OicoLgrNv7BKkTdxtUwIejkqC9U22/ ebYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=sox1taBnmCIiJl0rJY4ZCgP573DHrvF0Gg21Q72cZRw=; b=KPST/mKS60i32ehp3whuyeQ+VvQLB79WxH19eV1QAlJ0/zE0L/2QsXXRYhegWo1O2n myo1q3exTeASIlkK9vLE1G68m+bCLH4tjUreBudlZvZvNV6mHWF5Swgqjvyiujzo/F9a 8m4XV9XBrm+bzcApVgf/L2F5d/p/tvgDqhgFuL1KCnogsa8GTgLcmRIEs05cGk/Qsnrp k7VUiMpkHDKEBHb21kS+lo5h2C7X4eB0SiiFD6sThw7dBYjNMpdIBNwWA/Fp4HbVzc0v kgBXfrclL2IBMBSuBZnCJc8xCpiDPDvlxLs4y4ghH7eQyQHGJjhaFhSB0reTbQDUu+We Oetg== X-Gm-Message-State: AOAM531pYQ85W1ffUCszivvlin5vxLnMwLJsYx5sJNtfAYuczTRweCF2 GsXE6hWrhT1SdcvUPANRE4CHPP/T X-Google-Smtp-Source: ABdhPJwCvFAIXb/WixcQo3RkOpF83nnYFj9ccrYnEkL7MEH9DZoFjgHs8MD2XcnU1pukUFC0pSosWQ== X-Received: by 2002:ac8:6f55:: with SMTP id n21mr7085808qtv.175.1590366482666; Sun, 24 May 2020 17:28:02 -0700 (PDT) Received: from minid (cbl-45-2-119-47.yyz.frontiernetworks.ca. [45.2.119.47]) by smtp.gmail.com with ESMTPSA id u68sm851506qkf.102.2020.05.24.17.28.01 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 May 2020 17:28:02 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#41370: 27.0.91; Eshell and exit-minibuffer References: <875zcui7m4.fsf@gmail.com> <85k116o6n3.fsf@gmail.com> <83v9kq5vpk.fsf@gnu.org> Date: Sun, 24 May 2020 20:28:00 -0400 In-Reply-To: <83v9kq5vpk.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 20 May 2020 21:04:39 +0300") Message-ID: <874ks4luy7.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control Cc: andremegafone@gmail.com, alex.branham@gmail.com, 41370@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 41370 fixed close 41370 27.1 unarchive 33808 notfixed 33808 27.1 fixed 33808 28.1 quit Eli Zaretskii writes: >> [1: 1ee0192b792]: 2019-08-15 20:49:15 -0400 >> Fix eshell-mode-map initialization >> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1ee0192b792124663a0a40a729dd83c047d21535 >> >> I think that should be reverted from emacs-27, and the patch below can >> fix it for master: > > Agreed, thanks. Done. [2: 478638e470]: 2020-05-24 20:12:30 -0400 Revert "Fix eshell-mode-map initialization" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=478638e4706716b74de5b1aa3e85c8fd943f17ba [3: b9b8c5e3fa]: 2020-05-24 20:17:40 -0400 Make dedicated keymap and mode for eshell-command (Bug#41370) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=b9b8c5e3fa71aea719934ce422fb22734590a8b3 From unknown Mon Jun 16 23:48:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 22 Jun 2020 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator