From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 17 14:12:12 2018 Received: (at submit) by debbugs.gnu.org; 17 Dec 2018 19:12:12 +0000 Received: from localhost ([127.0.0.1]:52137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYyJI-0007tw-5A for submit@debbugs.gnu.org; Mon, 17 Dec 2018 14:12:12 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYyJG-0007tk-OK for submit@debbugs.gnu.org; Mon, 17 Dec 2018 14:12:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gYyJA-00083a-S1 for submit@debbugs.gnu.org; Mon, 17 Dec 2018 14:12:05 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41334) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gYyJA-00083O-Na for submit@debbugs.gnu.org; Mon, 17 Dec 2018 14:12:04 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYyJ9-00014q-QY for bug-automake@gnu.org; Mon, 17 Dec 2018 14:12:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gYyJ9-00081k-4a for bug-automake@gnu.org; Mon, 17 Dec 2018 14:12:03 -0500 Received: from mail-vs1-xe34.google.com ([2607:f8b0:4864:20::e34]:45012) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gYyJ8-0007zc-V3 for bug-automake@gnu.org; Mon, 17 Dec 2018 14:12:03 -0500 Received: by mail-vs1-xe34.google.com with SMTP id g68so8403242vsd.11 for ; Mon, 17 Dec 2018 11:12:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=+E2Mob41AEdvOB0uzg8lbec6suTwCR1eRi1mUyxutGU=; b=bqe7nnXvPF2p66gVx1YInneX8ZKqp7DSpbkIkswTYRi4RjiUSNCl5x21bXG7VNEPfG vY2Fj4mIIQmqEaheERN9WkpBIbs9C0jFy3VnpL+8Kah61SA3TAseMC4y7HJsc3hD8Od/ AyLtq4LCSmQRltXJMbRTeRKQNkBjPGO8zrjrdQn6xfIc8bKhi/tUTE+x6PBwHs3htXSn il775m9dRIffZ523wfNzG+oWMwO2hwxC/JQwg04y+QKR7v96xU+pLq+5+uwtFCYA38O1 T9bsA5WDlvnJ7O9VxKHRNWkDpgKWBQrZ8M3QNd4aDgJB4QpgAJljc/Ti29OCkxRr2oTe 0+Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=+E2Mob41AEdvOB0uzg8lbec6suTwCR1eRi1mUyxutGU=; b=GxMMtYgbTbdghYFYabaHly49o7p8LLuK8CkNBcV1N1spponvZM52GDRiSMAEXbSzN9 qF8TBnP5KDsF1mJ4T8gFVBm3yrhvXQI75ZV4HC9T8DKqx5RBqe+xIWDOjRgXpPWZDQoa v0rgJU0kGOmdRdl+3lnzTvy0A+hgCOeQphtm4yVEsZg2vA2/TTOxFcizV2phkUb1AAh7 OsPqKijLFUk8J1f+r4espLkDAWgawXWZHadyohOWK4oM+7uI6fwENrn7NVL5a3ei+rlg ujX1fRHYXUd6IPADkUDh/ge4nGE7e0LbQo7/fGFtx6qj20ck2WAYjaqnv+ifFI7BZjY+ G+Lg== X-Gm-Message-State: AA+aEWbhD3FcXl33IY+IWoSpD6sG84BImsoYK8BShCT9F7UgZ+Z8TPSc Bu09RL2wIuUvOJxAuV/blfmZyfKWrUhullrrR+UtQCRt X-Google-Smtp-Source: AFSGD/WwMvS3yXg/8j9PBv7Q+aif2HJodDa9XXXtoNGZVG5CE+3hkIiwuKPRzqgQ3VO1u8F7SEiNs1H20y25Ei/KtY4= X-Received: by 2002:a67:5d83:: with SMTP id r125mr6827852vsb.197.1545073920132; Mon, 17 Dec 2018 11:12:00 -0800 (PST) MIME-Version: 1.0 From: Bert Wesarg Date: Mon, 17 Dec 2018 20:11:48 +0100 Message-ID: Subject: Wrong lib-list in install-%DIR%LTLIBRARIES To: bug-automake@gnu.org Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) All, looking at lib/am/ltlib.am, the rule for installing libraries looks weird for the !LIBTOOL case. Though I have the impression that this file should not be used at all, if libtool is not used. Nevertheless, the install command in this cases uses the $list variable, not the sanitized $list2 variable. A simple patch looks like: diff --git i/lib/am/ltlib.am w/lib/am/ltlib.am index 1cbf7192e..2ac157472 100644 --- i/lib/am/ltlib.am +++ w/lib/am/ltlib.am @@ -49,8 +49,8 @@ if %?BASE% ## permissions to use. ?LIBTOOL? echo " $(LIBTOOL) $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS) --mode=install $(INSTALL) $(INSTALL_STRIP_FLAG) $$list2 '$(DESTDIR)$(%NDIR%dir)'"; \ ?LIBTOOL? $(LIBTOOL) $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS) --mode=install $(INSTALL) $(INSTALL_STRIP_FLAG) $$list2 "$(DESTDIR)$(%NDIR%dir)"; \ -?!LIBTOOL? echo " $(INSTALL) $(INSTALL_STRIP_FLAG) $$list '$(DESTDIR)$(%NDIR%dir)'"; \ -?!LIBTOOL? $(INSTALL) $(INSTALL_STRIP_FLAG) $$list "$(DESTDIR)$(%NDIR%dir)"; \ +?!LIBTOOL? echo " $(INSTALL) $(INSTALL_STRIP_FLAG) $$list2 '$(DESTDIR)$(%NDIR%dir)'"; \ +?!LIBTOOL? $(INSTALL) $(INSTALL_STRIP_FLAG) $$list2 "$(DESTDIR)$(%NDIR%dir)"; \ } else !%?BASE% @list='$(%DIR%_LTLIBRARIES)'; test -n "$(%NDIR%dir)" || list=; \ Best, Bert From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 13 00:57:25 2023 Received: (at 33779) by debbugs.gnu.org; 13 Jan 2023 05:57:26 +0000 Received: from localhost ([127.0.0.1]:49215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGD49-0000h8-Ki for submit@debbugs.gnu.org; Fri, 13 Jan 2023 00:57:25 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:40250 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGD45-0000ga-Aj for 33779@debbugs.gnu.org; Fri, 13 Jan 2023 00:57:21 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id BE25A33BF51; Fri, 13 Jan 2023 05:57:15 +0000 (UTC) From: Mike Frysinger To: Bert Wesarg Subject: Re: Wrong lib-list in install-%DIR%LTLIBRARIES User-Agent: GNU debbugs/0 Message-Id: <20230113055715.BE25A33BF51@smtp.gentoo.org> Date: Fri, 13 Jan 2023 05:57:15 +0000 (UTC) X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 33779 Cc: 33779@debbugs.gnu.org, bug-automake@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Mon, 17 Dec 2018 20:11:48 +0100, Bert Wesarg wrote: > looking at lib/am/ltlib.am, the rule for installing libraries looks > weird for the !LIBTOOL case. Though I have the impression that this > file should not be used at all, if libtool is not used. Nevertheless, > the install command in this cases uses the $list variable, not the > sanitized $list2 variable. A simple patch looks like: i agree it looks funky. do you have an example of where this fails ? how did you discover the bug ? we'd want to write a test for it so we can be sure it doesn't fail again. -mike From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 23 04:39:08 2023 Received: (at 33779) by debbugs.gnu.org; 23 Jan 2023 09:39:08 +0000 Received: from localhost ([127.0.0.1]:53373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJtIC-0006QB-BY for submit@debbugs.gnu.org; Mon, 23 Jan 2023 04:39:08 -0500 Received: from mail-ej1-f53.google.com ([209.85.218.53]:41590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJtIA-0006Ph-53 for 33779@debbugs.gnu.org; Mon, 23 Jan 2023 04:39:06 -0500 Received: by mail-ej1-f53.google.com with SMTP id u19so28820390ejm.8 for <33779@debbugs.gnu.org>; Mon, 23 Jan 2023 01:39:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=wcP9A/o1DkwfBekmO+clh6Bg051DsdB+cKyJO6crMQM=; b=Ht3sbqEuoKvgEjdajoYRGhM66HzWGETpZ6W6AeN6Un1geI9ZVZxVGM9ZdtrcRiBQaq hdp5Rv8yEEQRhqZJCzltOajgtI1sFj/bqgbWPEL+gquOynB8EXFLGErZpYEfPeOjO62W JVJCSkCAXqY/LbmMTlSLLlcSrHyqfrFmg5+Jyso9ZyVpJrqJVDh7CUa8BBMu7pKZR0p2 5VTFOkksMWspCXX7cajd0vVQ/biWM3pGsVIeUNIMVFHWHMHnaSM5zkqyTm1x007RAGaS utzsZDRz+Wsd0xMphJk7jfPT26QHjpS15w5koRtjExkiZnIIys2uWwbr0jerQWm0aAfY KIxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wcP9A/o1DkwfBekmO+clh6Bg051DsdB+cKyJO6crMQM=; b=mp+Vt45JP5dT8eKrVN2JKod7gY3t0leXyPgl4d0ZoLKHBZv35432S1JATRXO+9wUa+ QU1K7ClnDDnFdS6gks4Dc7NT/bWzo2+S0qipbbkH5ygG7+TRjhmk7szGUvFFHU3/whi6 n4CV85fP8oG6PTbqGQg+UWID4aDgvtQu/7aaJLsA6R/0W9aLNFJMuR6KDGWY7uvp4Plk pVmDdE+bJECk3H9CahdLWJKtT/5DmGJxaysNjEVcvEfaCjfqRgVlhUZ5ntx6zEn3NGSc bjysA25MQi/lhfwcSOMKM9Nhr6fjCi+9YsqeL/BkgJSTtaL6m5b4JxvOZLB6NzgnhNd1 ijDA== X-Gm-Message-State: AFqh2kpNRUK7TYLoh7oxQuTDipyM3FenMCSrDaWVdUC4NedlyG+HrEGk 7dHwo6bLdPaHMpPuXBffZcolvRmNIcKVQT8UXAE= X-Google-Smtp-Source: AMrXdXskh9L9yTuc0uVma2ZBxPBorcFfZeH6Q6K/HydmjBnWO2MX92JsVueaM9oHX5nZ1rpvtjHtFgaOaBzQp67CZW8= X-Received: by 2002:a17:906:4757:b0:79a:101a:7e57 with SMTP id j23-20020a170906475700b0079a101a7e57mr3026314ejs.368.1674466740127; Mon, 23 Jan 2023 01:39:00 -0800 (PST) MIME-Version: 1.0 References: <20230113055715.BE25A33BF51@smtp.gentoo.org> In-Reply-To: <20230113055715.BE25A33BF51@smtp.gentoo.org> From: Bert Wesarg Date: Mon, 23 Jan 2023 10:38:47 +0100 Message-ID: Subject: Re: bug#33779: Wrong lib-list in install-%DIR%LTLIBRARIES To: Mike Frysinger Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33779 Cc: woodard@redhat.com, 33779@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Jan 13, 2023 at 6:58 AM Mike Frysinger wrote: > > On Mon, 17 Dec 2018 20:11:48 +0100, Bert Wesarg wrote: > > looking at lib/am/ltlib.am, the rule for installing libraries looks > > weird for the !LIBTOOL case. Though I have the impression that this > > file should not be used at all, if libtool is not used. Nevertheless, > > the install command in this cases uses the $list variable, not the > > sanitized $list2 variable. A simple patch looks like: > > i agree it looks funky. do you have an example of where this fails ? > how did you discover the bug ? we'd want to write a test for it so we > can be sure it doesn't fail again. No, I don't have one. It just crossed my eyes while working on more silent rules in Automake. I made Ben recently aware of these changes, which are availalbe here: https://github.com/bertwesarg/automake/commits/more-and-colorful-silence and also Autoconf is now more colorful: https://github.com/bertwesarg/autoconf/commits/color Bert > -mike > > > From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 23 09:28:52 2023 Received: (at submit) by debbugs.gnu.org; 23 Jan 2023 14:28:52 +0000 Received: from localhost ([127.0.0.1]:53757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJxoZ-0002Kv-Vo for submit@debbugs.gnu.org; Mon, 23 Jan 2023 09:28:52 -0500 Received: from lists.gnu.org ([209.51.188.17]:55748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJxoY-0002Kn-EP for submit@debbugs.gnu.org; Mon, 23 Jan 2023 09:28:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJxoW-0001h2-5h for bug-automake@gnu.org; Mon, 23 Jan 2023 09:28:48 -0500 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJxoT-00069R-NK for bug-automake@gnu.org; Mon, 23 Jan 2023 09:28:47 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id DA9EB3200954 for ; Mon, 23 Jan 2023 09:28:41 -0500 (EST) Received: from imap45 ([10.202.2.95]) by compute1.internal (MEProxy); Mon, 23 Jan 2023 09:28:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=owlfolio.org; h= cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1674484121; x=1674570521; bh=jWHJIsP8ty NUMkO98foITQ3B6KV5ToOMdZ/fsQPokn0=; b=AT5Tw+GJ9/qQW1nzJMpMOH0EEY eSjpSLw+X6HoxihHvv6LT5SZMNxehBsQfn/5odP3GcTx1Wg5EkGYJ50mMNjTnKcs QplYr0cJZjdh8/LAEi/l+cZN0AVm9S/gHwo4vnTDDmH79dZR9rorLL3sv7E61Oc2 0fAG62uswYCmj47OCEu98qVdeto12rfJ76VWqRyUuemqFCFDEwqHf6ZsT91vejzM w/jPc0yQCOARqSnMQKY0Y19yFRWVxh52bVGRBDekB6KL6MK7PE5qtW+guJj1KzmA Y9ZIKPANgWK82S+mzrZ3zEoUQN+mdHLhKZFLW4e/xUXRvh20gezPMxZLclLw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1674484121; x=1674570521; bh=jWHJIsP8tyNUMkO98foITQ3B6KV5 ToOMdZ/fsQPokn0=; b=SwCq4TrWulUowA1RCfvlZWX8TTk0Qf68pxCwv4rz5Igp VSv16QnER+UjOWmQFdNoKjJOTgiU40IB/WbhEMOqK8eur1qoZUCjm8RqMX0N+MsW 2QwwpDjTtqOgdnJ65KPJYk162Dt/m6VRmIICUvWHulV26qjJu+cI7EOCLnccvsci nCzHbbXVlNug5Lt/EMCh7edmzXscI7mD6120hBG3LsDKzjNxf7fUqJ+SFMCCtoyc eVDFZuMXvy5gg5x8sPFwyL6BG8Dv7tqwGlktlf7knA6Nxa2I/XxaWAR50KTkl7aQ oeFt//GqAuWHcqL6tTp+kDM5broq8fImcEwafRE+iw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddukedgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreertdenucfhrhhomhepfdgkrggt khcuhggvihhnsggvrhhgfdcuoeiirggtkhesohiflhhfohhlihhordhorhhgqeenucggtf frrghtthgvrhhnpeefledvteduteeflefgfeeludejuedtuddugeeuieefgffgtedvgffg lefgfeefkeenucffohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepiigrtghksehofihlfhholhhiohdr ohhrgh X-ME-Proxy: Feedback-ID: i876146a2:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 29A6D272007B; Mon, 23 Jan 2023 09:28:41 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-85-gd6d859e0cf-fm-20230116.001-gd6d859e0 Mime-Version: 1.0 Message-Id: <9bb2eb71-2a02-428e-beb4-b0f53d5f13ef@app.fastmail.com> In-Reply-To: References: <20230113055715.BE25A33BF51@smtp.gentoo.org> Date: Mon, 23 Jan 2023 09:28:19 -0500 From: "Zack Weinberg" To: "Automake Bugs" Subject: Color-coded output from autoconf/automake (was Re: bug#33779: Wrong lib-list in install-%DIR%LTLIBRARIES) Content-Type: text/plain Received-SPF: pass client-ip=64.147.123.20; envelope-from=zack@owlfolio.org; helo=wout4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) On Mon, Jan 23, 2023, at 4:38 AM, Bert Wesarg via Bug reports for Automake wrote: > On Fri, Jan 13, 2023 at 6:58 AM Mike Frysinger wrote: > No, I don't have one. It just crossed my eyes while working on more > silent rules in Automake. I made Ben recently aware of these changes, > which are availalbe here: > > https://github.com/bertwesarg/automake/commits/more-and-colorful-silence > > and also Autoconf is now more colorful: > > https://github.com/bertwesarg/autoconf/commits/color Both of those URLs are 404 for me. FYI, with my Autoconf hat on, I will not be inclined to take patches that hardcode "ANSI" terminal control codes. $TERM must be honored in detail. The easiest way to do that is probably to probe for the existence of the `tput` command and then use that to set shell variables with all the necessary control codes. When working on patches for Automake, also keep in mind that $TERM might change between "./configure" and "make". zw From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 24 01:07:14 2023 Received: (at 33779) by debbugs.gnu.org; 24 Jan 2023 06:07:14 +0000 Received: from localhost ([127.0.0.1]:55722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKCSg-0007LZ-3c for submit@debbugs.gnu.org; Tue, 24 Jan 2023 01:07:14 -0500 Received: from mail-ed1-f41.google.com ([209.85.208.41]:35507) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKCSe-0007Ii-TR for 33779@debbugs.gnu.org; Tue, 24 Jan 2023 01:07:13 -0500 Received: by mail-ed1-f41.google.com with SMTP id y19so17140490edc.2 for <33779@debbugs.gnu.org>; Mon, 23 Jan 2023 22:07:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IaghE9Thcrd13RF6oBOJMPHDvmfZSu3Jy499vAfnAYc=; b=A2BEraLFfF8/1d6qG1GXDaF/xhW6EDARs+nkRCx3RPNQlGNVPvizVa5lrFNWjh1y2H +MsTvuAWqqPjxUG8cnxki7Zl/l6SOwGqtKKhuv+zQQBRBRGUu/lMkW/8AM8yKtNQzdDo Wgh1oWywAst2ztnf82x/R8Kq1zDanWgjpvCUN+VBp+qFpJv79YBwaR4jQYxXcTiBPCH+ RFEcQqTl2nnFFurqhvN9QQS2YVlQJppJCWolmGRQkfdKFGrOfvMyDPuVEPqQmgdzQHNK fH8NblubgN81aiSg0riEIIM7+WRNVBS1pmLAwvC961B0u/RZxZ0Bgp2z+8O0yEjdIB1w 5Hsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IaghE9Thcrd13RF6oBOJMPHDvmfZSu3Jy499vAfnAYc=; b=EHfjUTay+JlIYHtUp9QJoIzQMTR4hmAd7Lq6Q0qLVqXVpaAHr709RN7CFNnF32/t+/ uIKIlMb8w+fZtaFOMqLaTmG9W+GSHq3c6jBrpnC37XROwbaDg5rpO4RnezhwMNxHTJRx 0YoC96XnwfjkcJ9d7FcCDJlQMvd+n9JQUAKEpO7Br7mGRKw7Jw8We6btSlnv7x3Mle5s olA/ldyu4Tf24d3BDCJMvBDIxfXe9ZWnekSFX1lWu+6O9O2WIhAGAlVB3rzAjPyTt/Se HogkjgebOmyULRpznEF6LEwWuCnU8HP9R7Gb7H+mhSzLUAYEs6l8I45u0625TwkWs8lJ xZtQ== X-Gm-Message-State: AFqh2koHhYJIjNIY+Q7H/3Lp/3FppptiYDQwm9AVOFeaSANiUevjhGMY /0pjIs/+P3cjW0lnqk0c4eoQQB6Y/bpFtGm/kc4rmlXf X-Google-Smtp-Source: AMrXdXuIs7UuwRC+BPQro+i7w1REJ9SiGuVP9jD70Ikzl7SDG7QVf9NPrK8EV6mxXKK6vuBpa9bL0PxTbrTa+zBTZAY= X-Received: by 2002:aa7:c681:0:b0:461:e3f2:38bc with SMTP id n1-20020aa7c681000000b00461e3f238bcmr3456179edq.149.1674540426830; Mon, 23 Jan 2023 22:07:06 -0800 (PST) MIME-Version: 1.0 References: <20230113055715.BE25A33BF51@smtp.gentoo.org> <9bb2eb71-2a02-428e-beb4-b0f53d5f13ef@app.fastmail.com> In-Reply-To: <9bb2eb71-2a02-428e-beb4-b0f53d5f13ef@app.fastmail.com> From: Bert Wesarg Date: Tue, 24 Jan 2023 07:06:54 +0100 Message-ID: Subject: Re: bug#33779: Color-coded output from autoconf/automake (was Re: bug#33779: Wrong lib-list in install-%DIR%LTLIBRARIES) To: Zack Weinberg Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33779 Cc: 33779@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Jan 23, 2023 at 3:29 PM Zack Weinberg wrote: > > On Mon, Jan 23, 2023, at 4:38 AM, Bert Wesarg via Bug reports for Automak= e wrote: > > On Fri, Jan 13, 2023 at 6:58 AM Mike Frysinger wrot= e: > > No, I don't have one. It just crossed my eyes while working on more > > silent rules in Automake. I made Ben recently aware of these changes, > > which are availalbe here: > > > > https://github.com/bertwesarg/automake/commits/more-and-colorful-silenc= e > > > > and also Autoconf is now more colorful: > > > > https://github.com/bertwesarg/autoconf/commits/color > > Both of those URLs are 404 for me. Its now public. > > FYI, with my Autoconf hat on, I will not be inclined to take patches that= hardcode "ANSI" terminal control codes. $TERM must be honored in detail. = The easiest way to do that is probably to probe for the existence of the `= tput` command and then use that to set shell variables with all the necessa= ry control codes. When working on patches for Automake, also keep in mind = that $TERM might change between "./configure" and "make". It reuses the color setting code from lib/am/check.am, which is already in use. And autoconf has its own logic copied into m4sh.m4. So the decision is independent Bert From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 24 01:14:54 2023 Received: (at 33779) by debbugs.gnu.org; 24 Jan 2023 06:14:54 +0000 Received: from localhost ([127.0.0.1]:55727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKCa6-0007YP-2V for submit@debbugs.gnu.org; Tue, 24 Jan 2023 01:14:54 -0500 Received: from mail-ej1-f45.google.com ([209.85.218.45]:45013) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKCa4-0007YC-NG for 33779@debbugs.gnu.org; Tue, 24 Jan 2023 01:14:53 -0500 Received: by mail-ej1-f45.google.com with SMTP id ss4so36171727ejb.11 for <33779@debbugs.gnu.org>; Mon, 23 Jan 2023 22:14:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=v8G/+wn+EZ2F4xxQX09TarkaQhGwva6gsuOJul5VIww=; b=PvUHpzwH8wpXKn85LGj36onO4fc5ISQxoYhw2x99fDlgZpeXmkGJLpVC81TCnOVQLg MDp6JJPZuSiJW4D79kmeHLsd/UfHC50NPEe0Pnuqrhd9HKfWqDKPLdM/CekwTL0mNX1I gm1wH8BK6N8TSal0Fs7aPy17Iyt+J9AAs1NKfZsMu6pKRjhl8pQLyJQ8bit/Y/W7Eren hdAihVxPqW6t2ub+RGbDcINMzwm911/csfgNPiMn/sDwFRkjvz0nMF5X67wAdnyqyhpi LEvnyae65yf13qLtHSI+ZlqM8fXjSoHD0BDCJIvIvFgSwYyl98bFPpy1KBKI49QQ1OMk YDZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v8G/+wn+EZ2F4xxQX09TarkaQhGwva6gsuOJul5VIww=; b=MgKkrhOA/BSS02YzB7fiKEFc+gYX4HFKQvRdWdtJEw5/kDjOGnvry3VCpspb/RFHxv sdpTvYaIoAMRxXKWgtXZC5+yGVgSckwtWsVkCre6nT8MZ+Sb1JzHaey5AIrKHzoQeqn1 MURBnDSWLilblSEjzTluDT0l4b+OwQpcc0tb5N9QaVg1mgMdeXJBYA4VAvcUCi8wGRmZ 474HBoKLpb4CBnOkT4HHtrQ5hb6PiHx975W//nAryfj6XQXAc2Jxws8UDByV8iwt09t5 h5UJlA7+0PRr026l/DnY2wJiw89gDcOWdJIvRNT3H2/gBjaF60JBXt1eqDhlYK6R9HUO EO/A== X-Gm-Message-State: AFqh2kre+OD6LAiJmN85MuNIhz3yvWqhaWrMvwyGntY7PcgP1KGd2WUs 6iOQ+WibJzRFxJRqWwL6RwDu5jfku44iF7LoN2M= X-Google-Smtp-Source: AMrXdXuDcttUQ5rqe90ra11mFwcP89D2iodya5Gi1Pby72WZYZdYY5iI4LXFfflw3y0CSUux5rICkMyA5Tq7zp8pmWw= X-Received: by 2002:a17:906:2f10:b0:871:fe55:c5da with SMTP id v16-20020a1709062f1000b00871fe55c5damr3784621eji.189.1674540886850; Mon, 23 Jan 2023 22:14:46 -0800 (PST) MIME-Version: 1.0 References: <20230113055715.BE25A33BF51@smtp.gentoo.org> <9bb2eb71-2a02-428e-beb4-b0f53d5f13ef@app.fastmail.com> In-Reply-To: From: Bert Wesarg Date: Tue, 24 Jan 2023 07:14:34 +0100 Message-ID: Subject: Re: bug#33779: Color-coded output from autoconf/automake (was Re: bug#33779: Wrong lib-list in install-%DIR%LTLIBRARIES) To: Zack Weinberg Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33779 Cc: 33779@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Full disclosure: the most controversial change in behavior is probably the removal of batch processing files at install time, or maybe also other times, to get for each file a colored silent rule output.. JAVAC is the exception, as all .java files needs to passed at once to the compiler. On Tue, Jan 24, 2023 at 7:06 AM Bert Wesarg wr= ote: > > On Mon, Jan 23, 2023 at 3:29 PM Zack Weinberg wrote: > > > > On Mon, Jan 23, 2023, at 4:38 AM, Bert Wesarg via Bug reports for Autom= ake wrote: > > > On Fri, Jan 13, 2023 at 6:58 AM Mike Frysinger wr= ote: > > > No, I don't have one. It just crossed my eyes while working on more > > > silent rules in Automake. I made Ben recently aware of these changes, > > > which are availalbe here: > > > > > > https://github.com/bertwesarg/automake/commits/more-and-colorful-sile= nce > > > > > > and also Autoconf is now more colorful: > > > > > > https://github.com/bertwesarg/autoconf/commits/color > > > > Both of those URLs are 404 for me. > > Its now public. > > > > > FYI, with my Autoconf hat on, I will not be inclined to take patches th= at hardcode "ANSI" terminal control codes. $TERM must be honored in detail= . The easiest way to do that is probably to probe for the existence of the= `tput` command and then use that to set shell variables with all the neces= sary control codes. When working on patches for Automake, also keep in min= d that $TERM might change between "./configure" and "make". > > It reuses the color setting code from lib/am/check.am, which is > already in use. And autoconf has its own logic copied into m4sh.m4. So > the decision is independent > > Bert From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 24 08:05:31 2023 Received: (at 33779) by debbugs.gnu.org; 24 Jan 2023 13:05:31 +0000 Received: from localhost ([127.0.0.1]:56107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKIzT-00048s-6x for submit@debbugs.gnu.org; Tue, 24 Jan 2023 08:05:31 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:47224 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKIzO-00048a-7d for 33779@debbugs.gnu.org; Tue, 24 Jan 2023 08:05:30 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 19D4133D4A6; Tue, 24 Jan 2023 13:05:18 +0000 (UTC) Date: Tue, 24 Jan 2023 08:05:16 -0500 From: Mike Frysinger To: Bert Wesarg Subject: Re: bug#33779: Color-coded output from autoconf/automake (was Re: bug#33779: Wrong lib-list in install-%DIR%LTLIBRARIES) Message-ID: References: <20230113055715.BE25A33BF51@smtp.gentoo.org> <9bb2eb71-2a02-428e-beb4-b0f53d5f13ef@app.fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OWSURCNgQHXU0d87" Content-Disposition: inline In-Reply-To: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 33779 Cc: 33779@debbugs.gnu.org, Zack Weinberg X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --OWSURCNgQHXU0d87 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 24 Jan 2023 07:06, Bert Wesarg via Bug reports for Automake wrote: > On Mon, Jan 23, 2023 at 3:29 PM Zack Weinberg wrote: > > On Mon, Jan 23, 2023, at 4:38 AM, Bert Wesarg via Bug reports for Autom= ake wrote: > > > On Fri, Jan 13, 2023 at 6:58 AM Mike Frysinger wr= ote: > > > No, I don't have one. It just crossed my eyes while working on more > > > silent rules in Automake. I made Ben recently aware of these changes, > > > which are availalbe here: > > > > > > https://github.com/bertwesarg/automake/commits/more-and-colorful-sile= nce > > > > > > and also Autoconf is now more colorful: > > > > > > https://github.com/bertwesarg/autoconf/commits/color > > > > Both of those URLs are 404 for me. >=20 > Its now public. feel free to send commits to automake-patches@gnu.org via `git am` for revi= ew. although if you haven't signed FSF copyright papers, we'll want that first. -mike --OWSURCNgQHXU0d87 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmPP14wACgkQQWM7n+g3 9YEQTBAApIPyvG4aI3enCN7iQF85bMbL0GXGuLdVrqzZtwknw/j6FHEaENZ4DvGA GcHH8L2XbM10VfOnqMwbbbclaB5QmFxUZeOT4pxmKvip413ZGio9rkxKFXw8GaMb IneO1j+mNZ2V57VObSrDZc7xt/pQcuazvqEcBtLX2I2TDJb7hVfcVV85XpqG3vGI sy1APsYfwqQ5m9RzulLDA5358bnnK6dkA++XXqAGBA1s3C0MdWnRLW3lkj44oJzJ oJcWQQSaO9VzpBYF/P91YGeF6qveNkWzBAN9mGv3f0kBoHbtMw10WGjcHGF35Ycr lHogUpU4VUWwRjHHXFZf/T9IqiQs82kMUzY95zSySxE9gTy7TRz6tDFBuOqL2xCe RW08yHJc2/Iz+rtdHbbYoLdNpxkxOz99DtN5z5+duJZEhLu63uX/ewZTL3zT2pUi Ijr5zgnLfHu/e6aJNVhbijTHD8dQXk762FGngEbUchdDIiiPM9qK1aOiEPR0xdJY IRhfxynKFShzSC05AH1BwSL/Gh24wGqrZ0CNfR7S8mVx2GfftrYNIaIEleLFfvBv w1n65tLZp+I6ug6xEcQXZMUt1mrB0iYETysPJ7fMqeeO9Hs75ec8Ck9zt5PmhzHz 5YcOWJw9oOHFhyfl9ysutl44hDurJnQetlx6rS1h9gfuPmyDfBg= =Nd4e -----END PGP SIGNATURE----- --OWSURCNgQHXU0d87--