GNU bug report logs - #33779
Wrong lib-list in install-%DIR%LTLIBRARIES

Previous Next

To reply to this bug, email your comments to 33779 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Bert Wesarg <bert.wesarg <at> googlemail.com>
To: bug-automake <at> gnu.org
Subject: Wrong lib-list in install-%DIR%LTLIBRARIES
Date: Mon, 17 Dec 2018 20:11:48 +0100

All,

looking at lib/am/ltlib.am, the rule for installing libraries looks
weird for the !LIBTOOL case. Though I have the impression that this
file should not be used at all, if libtool is not used. Nevertheless,
the install command in this cases uses the $list variable, not the
sanitized $list2 variable. A simple patch looks like:

diff --git i/lib/am/ltlib.am w/lib/am/ltlib.am
index 1cbf7192e..2ac157472 100644
--- i/lib/am/ltlib.am
+++ w/lib/am/ltlib.am
@@ -49,8 +49,8 @@ if %?BASE%
 ## permissions to use.
 ?LIBTOOL?        echo " $(LIBTOOL) $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS)
--mode=install $(INSTALL) $(INSTALL_STRIP_FLAG) $$list2
'$(DESTDIR)$(%NDIR%dir)'"; \
 ?LIBTOOL?        $(LIBTOOL) $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS)
--mode=install $(INSTALL) $(INSTALL_STRIP_FLAG) $$list2
"$(DESTDIR)$(%NDIR%dir)"; \
-?!LIBTOOL?       echo " $(INSTALL) $(INSTALL_STRIP_FLAG) $$list
'$(DESTDIR)$(%NDIR%dir)'"; \
-?!LIBTOOL?       $(INSTALL) $(INSTALL_STRIP_FLAG) $$list
"$(DESTDIR)$(%NDIR%dir)"; \
+?!LIBTOOL?       echo " $(INSTALL) $(INSTALL_STRIP_FLAG) $$list2
'$(DESTDIR)$(%NDIR%dir)'"; \
+?!LIBTOOL?       $(INSTALL) $(INSTALL_STRIP_FLAG) $$list2
"$(DESTDIR)$(%NDIR%dir)"; \
        }
 else !%?BASE%
        @list='$(%DIR%_LTLIBRARIES)'; test -n "$(%NDIR%dir)"  || list=; \

Best,
Bert

Message #8 received at 33779 <at> debbugs.gnu.org (full text, mbox):

From: Mike Frysinger <vapier <at> gentoo.org>
To: Bert Wesarg <bert.wesarg <at> googlemail.com>
Cc: 33779 <at> debbugs.gnu.org, bug-automake <at> gnu.org
Subject: Re: Wrong lib-list in install-%DIR%LTLIBRARIES
Date: Fri, 13 Jan 2023 05:57:15 +0000 (UTC)

On Mon, 17 Dec 2018 20:11:48 +0100, Bert Wesarg wrote:
> looking at lib/am/ltlib.am, the rule for installing libraries looks
> weird for the !LIBTOOL case. Though I have the impression that this
> file should not be used at all, if libtool is not used. Nevertheless,
> the install command in this cases uses the $list variable, not the
> sanitized $list2 variable. A simple patch looks like:

i agree it looks funky.  do you have an example of where this fails ?
how did you discover the bug ?  we'd want to write a test for it so we
can be sure it doesn't fail again.
-mike

Message #11 received at 33779 <at> debbugs.gnu.org (full text, mbox):

From: Bert Wesarg <bert.wesarg <at> googlemail.com>
To: Mike Frysinger <vapier <at> gentoo.org>
Cc: woodard <at> redhat.com, 33779 <at> debbugs.gnu.org
Subject: Re: bug#33779: Wrong lib-list in install-%DIR%LTLIBRARIES
Date: Mon, 23 Jan 2023 10:38:47 +0100

On Fri, Jan 13, 2023 at 6:58 AM Mike Frysinger <vapier <at> gentoo.org> wrote:
>
> On Mon, 17 Dec 2018 20:11:48 +0100, Bert Wesarg wrote:
> > looking at lib/am/ltlib.am, the rule for installing libraries looks
> > weird for the !LIBTOOL case. Though I have the impression that this
> > file should not be used at all, if libtool is not used. Nevertheless,
> > the install command in this cases uses the $list variable, not the
> > sanitized $list2 variable. A simple patch looks like:
>
> i agree it looks funky.  do you have an example of where this fails ?
> how did you discover the bug ?  we'd want to write a test for it so we
> can be sure it doesn't fail again.

No, I don't have one. It just crossed my eyes while working on more
silent rules in Automake. I made Ben recently aware of these changes,
which are availalbe here:

https://github.com/bertwesarg/automake/commits/more-and-colorful-silence

and also Autoconf is now more colorful:

https://github.com/bertwesarg/autoconf/commits/color

Bert

> -mike
>
>
>

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Zack Weinberg" <zack <at> owlfolio.org>
To: "Automake Bugs" <bug-automake <at> gnu.org>
Subject: Color-coded output from autoconf/automake (was Re: bug#33779: Wrong
 lib-list in install-%DIR%LTLIBRARIES)
Date: Mon, 23 Jan 2023 09:28:19 -0500

On Mon, Jan 23, 2023, at 4:38 AM, Bert Wesarg via Bug reports for Automake wrote:
> On Fri, Jan 13, 2023 at 6:58 AM Mike Frysinger <vapier <at> gentoo.org> wrote:
> No, I don't have one. It just crossed my eyes while working on more
> silent rules in Automake. I made Ben recently aware of these changes,
> which are availalbe here:
>
> https://github.com/bertwesarg/automake/commits/more-and-colorful-silence
>
> and also Autoconf is now more colorful:
>
> https://github.com/bertwesarg/autoconf/commits/color

Both of those URLs are 404 for me.

FYI, with my Autoconf hat on, I will not be inclined to take patches that hardcode "ANSI" terminal control codes.  $TERM must be honored in detail.  The easiest way to do that is probably to probe for the existence of the `tput` command and then use that to set shell variables with all the necessary control codes.  When working on patches for Automake, also keep in mind that $TERM might change between "./configure" and "make".

zw

Message #17 received at 33779 <at> debbugs.gnu.org (full text, mbox):

From: Bert Wesarg <bert.wesarg <at> googlemail.com>
To: Zack Weinberg <zack <at> owlfolio.org>
Cc: 33779 <at> debbugs.gnu.org
Subject: Re: bug#33779: Color-coded output from autoconf/automake (was Re:
 bug#33779: Wrong lib-list in install-%DIR%LTLIBRARIES)
Date: Tue, 24 Jan 2023 07:06:54 +0100

On Mon, Jan 23, 2023 at 3:29 PM Zack Weinberg <zack <at> owlfolio.org> wrote:
>
> On Mon, Jan 23, 2023, at 4:38 AM, Bert Wesarg via Bug reports for Automake wrote:
> > On Fri, Jan 13, 2023 at 6:58 AM Mike Frysinger <vapier <at> gentoo.org> wrote:
> > No, I don't have one. It just crossed my eyes while working on more
> > silent rules in Automake. I made Ben recently aware of these changes,
> > which are availalbe here:
> >
> > https://github.com/bertwesarg/automake/commits/more-and-colorful-silence
> >
> > and also Autoconf is now more colorful:
> >
> > https://github.com/bertwesarg/autoconf/commits/color
>
> Both of those URLs are 404 for me.

Its now public.

>
> FYI, with my Autoconf hat on, I will not be inclined to take patches that hardcode "ANSI" terminal control codes.  $TERM must be honored in detail.  The easiest way to do that is probably to probe for the existence of the `tput` command and then use that to set shell variables with all the necessary control codes.  When working on patches for Automake, also keep in mind that $TERM might change between "./configure" and "make".

It reuses the color setting code from lib/am/check.am, which is
already in use. And autoconf has its own logic copied into m4sh.m4. So
the decision is independent

Bert

Message #20 received at 33779 <at> debbugs.gnu.org (full text, mbox):

From: Bert Wesarg <bert.wesarg <at> googlemail.com>
To: Zack Weinberg <zack <at> owlfolio.org>
Cc: 33779 <at> debbugs.gnu.org
Subject: Re: bug#33779: Color-coded output from autoconf/automake (was Re:
 bug#33779: Wrong lib-list in install-%DIR%LTLIBRARIES)
Date: Tue, 24 Jan 2023 07:14:34 +0100

Full disclosure: the most controversial change in behavior is probably
the removal of batch processing files at install time, or maybe also
other times, to get for each file a colored silent rule output.. JAVAC
is the exception, as all .java files needs to passed at once to the
compiler.

On Tue, Jan 24, 2023 at 7:06 AM Bert Wesarg <bert.wesarg <at> googlemail.com> wrote:
>
> On Mon, Jan 23, 2023 at 3:29 PM Zack Weinberg <zack <at> owlfolio.org> wrote:
> >
> > On Mon, Jan 23, 2023, at 4:38 AM, Bert Wesarg via Bug reports for Automake wrote:
> > > On Fri, Jan 13, 2023 at 6:58 AM Mike Frysinger <vapier <at> gentoo.org> wrote:
> > > No, I don't have one. It just crossed my eyes while working on more
> > > silent rules in Automake. I made Ben recently aware of these changes,
> > > which are availalbe here:
> > >
> > > https://github.com/bertwesarg/automake/commits/more-and-colorful-silence
> > >
> > > and also Autoconf is now more colorful:
> > >
> > > https://github.com/bertwesarg/autoconf/commits/color
> >
> > Both of those URLs are 404 for me.
>
> Its now public.
>
> >
> > FYI, with my Autoconf hat on, I will not be inclined to take patches that hardcode "ANSI" terminal control codes.  $TERM must be honored in detail.  The easiest way to do that is probably to probe for the existence of the `tput` command and then use that to set shell variables with all the necessary control codes.  When working on patches for Automake, also keep in mind that $TERM might change between "./configure" and "make".
>
> It reuses the color setting code from lib/am/check.am, which is
> already in use. And autoconf has its own logic copied into m4sh.m4. So
> the decision is independent
>
> Bert

Message #23 received at 33779 <at> debbugs.gnu.org (full text, mbox):

From: Mike Frysinger <vapier <at> gentoo.org>
To: Bert Wesarg <bert.wesarg <at> googlemail.com>
Cc: 33779 <at> debbugs.gnu.org, Zack Weinberg <zack <at> owlfolio.org>
Subject: Re: bug#33779: Color-coded output from autoconf/automake (was Re:
 bug#33779: Wrong lib-list in install-%DIR%LTLIBRARIES)
Date: Tue, 24 Jan 2023 08:05:16 -0500

[Message part 1 (text/plain, inline)]

On 24 Jan 2023 07:06, Bert Wesarg via Bug reports for Automake wrote:
> On Mon, Jan 23, 2023 at 3:29 PM Zack Weinberg <zack <at> owlfolio.org> wrote:
> > On Mon, Jan 23, 2023, at 4:38 AM, Bert Wesarg via Bug reports for Automake wrote:
> > > On Fri, Jan 13, 2023 at 6:58 AM Mike Frysinger <vapier <at> gentoo.org> wrote:
> > > No, I don't have one. It just crossed my eyes while working on more
> > > silent rules in Automake. I made Ben recently aware of these changes,
> > > which are availalbe here:
> > >
> > > https://github.com/bertwesarg/automake/commits/more-and-colorful-silence
> > >
> > > and also Autoconf is now more colorful:
> > >
> > > https://github.com/bertwesarg/autoconf/commits/color
> >
> > Both of those URLs are 404 for me.
> 
> Its now public.

feel free to send commits to automake-patches <at> gnu.org via `git am` for review.
although if you haven't signed FSF copyright papers, we'll want that first.
-mike

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.