Subject: Re: [bug#33770] [PATCH] gnu: Add nip2.

From: Ludovic Courtès <[email-masked]>
Date: Sun, 06 Jan 2019 00:20:33 +0100

Hi,

L  p R n  d n    <[email-masked]> skribis:

> Hello,
>
> Thanks for the review!
>
> Here is a new version of the Nip2 patch.
> For the source, I thought only Github "archives" urls where problematic? 

Oh you’re right, I was confused.

> From 5c32d2e6c940e2d3aef91071417a9774ab7cfe4b Mon Sep 17 00:00:00 2001
> From: Lprndn <[email-masked]>
> Date: Wed, 5 Dec 2018 19:03:13 +0100
> Subject: [PATCH] gnu: Add nip2.
>
> * gnu/packages/image-processing.scm (nip2): New variable.

Applied with the tiny changes below (the configure phase would fail
without libjpeg.)  Thank you!

Ludo’.

diff --git a/gnu/packages/image-processing.scm b/gnu/packages/image-processing.scm
index f9be2dcab8..9c2ec50bec 100644
--- a/gnu/packages/image-processing.scm
+++ b/gnu/packages/image-processing.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2016 Eric Bavier <[email-masked]>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <[email-masked]>
 ;;; Copyright © 2018 Björn Höfling <[email-masked]>
+;;; Copyright © 2018 Lprndn <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -460,13 +461,13 @@ vision algorithms.  It can be used to do things like:
         (base32 "08dxfds4n1vxdilxcw01741a2r6fxyhawi656b7f0hy6znnkbsbc"))))
     (build-system gnu-build-system)
     (arguments
-     `(#:tests? #t
-       #:phases
+     `(#:phases
        (modify-phases %standard-phases
          ;; test_conv.ws keep failing so disabling for now
          (add-after 'unpack 'disable-test-conv
            (lambda _
-             (delete-file "test/workspaces/test_conv.ws")))
+             (delete-file "test/workspaces/test_conv.ws")
+             #t))
          (add-before 'check 'set-home
            (lambda _
              (setenv "HOME" "/tmp") #t)))))
@@ -477,6 +478,7 @@ vision algorithms.  It can be used to do things like:
        ("gtk+-2" ,gtk+-2)
        ("libxml2" ,libxml2)
        ("libexif" ,libexif)
+       ("libjpeg" ,libjpeg)                       ;required by vips.pc
        ("librsvg" ,librsvg)
        ("fftw" ,fftw)
        ("libgsf" ,libgsf)
@@ -494,7 +496,8 @@ vision algorithms.  It can be used to do things like:
        ("pkg-config" ,pkg-config)))
     (home-page "https://github.com/libvips/nip2")
     (synopsis "Spreadsheet-like GUI for libvips")
-    (description "GUI for the VIPS image processing library.
-It's a little like a spreadsheet: you create a set of formula connecting your
-objects together, and on a change nip2 recalculates")
+    (description "This package provide a graphical user interface (GUI) for
+the VIPS image processing library.  It's a little like a spreadsheet: you
+create a set of formula connecting your objects together, and on a change nip2
+recalculates.")
     (license license:gpl2+)))