Subject: bug#33770: closed (Re: [bug#33770] [PATCH] gnu: Add nip2.)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 05 Jan 2019 23:21:02 +0000

Your bug report

#33770: [PATCH] gnu: Add vips. 

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
33770: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33770
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#33770] [PATCH] gnu: Add nip2.
From: Ludovic Courtès <[email-masked]>
To: L p R n d n <[email-masked]>
Cc: [email-masked]
Date: Sun, 06 Jan 2019 00:20:33 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

L  p R n  d n    <[email-masked]> skribis:

> Hello,
>
> Thanks for the review!
>
> Here is a new version of the Nip2 patch.
> For the source, I thought only Github "archives" urls where problematic? 

Oh you’re right, I was confused.

> From 5c32d2e6c940e2d3aef91071417a9774ab7cfe4b Mon Sep 17 00:00:00 2001
> From: Lprndn <[email-masked]>
> Date: Wed, 5 Dec 2018 19:03:13 +0100
> Subject: [PATCH] gnu: Add nip2.
>
> * gnu/packages/image-processing.scm (nip2): New variable.

Applied with the tiny changes below (the configure phase would fail
without libjpeg.)  Thank you!

Ludo’.

diff --git a/gnu/packages/image-processing.scm b/gnu/packages/image-processing.scm
index f9be2dcab8..9c2ec50bec 100644
--- a/gnu/packages/image-processing.scm
+++ b/gnu/packages/image-processing.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2016 Eric Bavier <[email-masked]>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <[email-masked]>
 ;;; Copyright © 2018 Björn Höfling <[email-masked]>
+;;; Copyright © 2018 Lprndn <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -460,13 +461,13 @@ vision algorithms.  It can be used to do things like:
         (base32 "08dxfds4n1vxdilxcw01741a2r6fxyhawi656b7f0hy6znnkbsbc"))))
     (build-system gnu-build-system)
     (arguments
-     `(#:tests? #t
-       #:phases
+     `(#:phases
        (modify-phases %standard-phases
          ;; test_conv.ws keep failing so disabling for now
          (add-after 'unpack 'disable-test-conv
            (lambda _
-             (delete-file "test/workspaces/test_conv.ws")))
+             (delete-file "test/workspaces/test_conv.ws")
+             #t))
          (add-before 'check 'set-home
            (lambda _
              (setenv "HOME" "/tmp") #t)))))
@@ -477,6 +478,7 @@ vision algorithms.  It can be used to do things like:
        ("gtk+-2" ,gtk+-2)
        ("libxml2" ,libxml2)
        ("libexif" ,libexif)
+       ("libjpeg" ,libjpeg)                       ;required by vips.pc
        ("librsvg" ,librsvg)
        ("fftw" ,fftw)
        ("libgsf" ,libgsf)
@@ -494,7 +496,8 @@ vision algorithms.  It can be used to do things like:
        ("pkg-config" ,pkg-config)))
     (home-page "https://github.com/libvips/nip2")
     (synopsis "Spreadsheet-like GUI for libvips")
-    (description "GUI for the VIPS image processing library.
-It's a little like a spreadsheet: you create a set of formula connecting your
-objects together, and on a change nip2 recalculates")
+    (description "This package provide a graphical user interface (GUI) for
+the VIPS image processing library.  It's a little like a spreadsheet: you
+create a set of formula connecting your objects together, and on a change nip2
+recalculates.")
     (license license:gpl2+)))

Subject: [PATCH] gnu: Add vips.
From: L p R n d n <[email-masked]>
To: [email-masked]
Date: Sun, 16 Dec 2018 15:31:44 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

>From d5d6b66818b47f3ea87e13bf0236294b91f942fb Mon Sep 17 00:00:00 2001
From: Lprndn <[email-masked]>
Date: Wed, 5 Dec 2018 18:59:34 +0100
Subject: [PATCH] gnu: Add vips.

* gnu/packages/image-processing.scm (vips): New variable.
---
 gnu/packages/image-processing.scm | 47 +++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/gnu/packages/image-processing.scm b/gnu/packages/image-processing.scm
index 0901dc429..df0099c7d 100644
--- a/gnu/packages/image-processing.scm
+++ b/gnu/packages/image-processing.scm
@@ -35,13 +35,18 @@
   #:use-module (gnu packages compression)
   #:use-module (gnu packages documentation)
   #:use-module (gnu packages fontutils)
+  #:use-module (gnu packages ghostscript)
   #:use-module (gnu packages gl)
+  #:use-module (gnu packages glib)
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages graphics)
   #:use-module (gnu packages graphviz)
+  #:use-module (gnu packages gstreamer)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages image)
+  #:use-module (gnu packages imagemagick)
   #:use-module (gnu packages maths)
+  #:use-module (gnu packages pdf)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages photo)
   #:use-module (gnu packages pkg-config)
@@ -396,3 +401,45 @@ vision algorithms.  It can be used to do things like:
 @end itemize\n")
     (home-page "https://opencv.org/")
     (license license:bsd-3)))
+
+(define-public vips
+  (package
+    (name "vips")
+    (version "8.7.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://github.com/libvips/libvips/releases/download/v"
+                    version "/vips-" version ".tar.gz"))
+              (sha256
+               (base32 "1w3b90pdw7nj2p0gb4f96h6zhmga513f968ldfhz1rkhg7y81c0s"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("gobject-introspection" ,gobject-introspection)))
+    (inputs
+     `(("glib" ,glib)
+       ("libjpeg" ,libjpeg)
+       ("libpng" ,libpng)
+       ("librsvg" ,librsvg)
+       ("libtiff" ,libtiff)
+       ("libexif" ,libexif)
+       ("giflib" ,giflib)
+       ("libgsf" ,libgsf)
+       ("fftw" ,fftw)
+       ("poppler" ,poppler)
+       ("pango" ,pango)
+       ("lcms" ,lcms)
+       ("matio" ,matio)
+       ("libwebp" ,libwebp)
+       ("niftilib" ,niftilib)
+       ("openexr" ,openexr)
+       ("orc" ,orc)
+       ("imagemagick" ,imagemagick)
+       ("libxml2" ,libxml2)
+       ("expat" ,expat)
+       ("hdf5" ,hdf5)))
+    (home-page "https://libvips.github.io/libvips/")
+    (synopsis "A free image processing system")
+    (description "vips is a demand-driven, horizontally threaded image processing library")
+    (license license:lgpl2.1+)))
-- 
2.19.2