GNU bug report logs - #33761
Allow split to write into FIFOs

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33761 in the body.
You can then email your comments to 33761 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: scottworley <at> scottworley.com
To: bug-coreutils <at> gnu.org
Subject: Allow split to write into FIFOs
Date: Sat, 15 Dec 2018 00:00:18 -0800

[Message part 1 (text/plain, inline)]

TL;DR: Attached: Patch to allow split to write into FIFOs.



Currently, split fails when its output files are FIFOs because
FIFOs cannot be ftruncate()d.  Split exits with this error message:

  split: xaa: error truncating: Invalid argument

The attached patch causes split to only attempt the ftruncate when its
output is a regular file.

[coreutils-split-into-fifos.patch (text/x-diff, attachment)]

Message #10 received at 33761-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: scottworley <at> scottworley.com, 33761-done <at> debbugs.gnu.org
Subject: Re: bug#33761: Allow split to write into FIFOs
Date: Sat, 15 Dec 2018 12:20:00 -0800

[Message part 1 (text/plain, inline)]

Thanks for reporting that. I see similar problems in a couple of other coreutils 
programs. The style elsewhere seems to be to try ftruncate first, and report an 
error if it fails only if the file is not one for which POSIX specifies the 
behavior, so I think it'd be better if 'split' did that too. So I installed the 
attached patch to fix the problems that I found, and this should fix the bug you 
reported so I'll close the bug report.

Thanks also for the test case. To install that I'll need a copyright assignment 
form signed; can you do that for us? If so, please let me know and I'll get the 
paperwork ball rolling for you.

[0001-shred-sort-split-fix-ftruncate-error-reporting.patch (text/x-patch, attachment)]

Message #13 received at 33761-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: scottworley <at> scottworley.com, 33761-done <at> debbugs.gnu.org
Subject: Re: bug#33761: Allow split to write into FIFOs
Date: Sat, 15 Dec 2018 12:44:07 -0800

[Message part 1 (text/plain, inline)]

I forgot to add a NEWS item for this, which I fixed by installing the attached.

[0001-shred-sort-split-add-NEWS-item.patch (text/x-patch, attachment)]

Message #16 received at 33761-done <at> debbugs.gnu.org (full text, mbox):

From: scottworley <at> scottworley.com
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 33761-done <at> debbugs.gnu.org
Subject: Re: bug#33761: Allow split to write into FIFOs
Date: Sat, 15 Dec 2018 16:11:03 -0800

On Sat, Dec 15, 2018 at 12:20:00PM -0800, Paul Eggert wrote:
> Thanks also for the test case. To install that I'll need a copyright assignment 
> form signed; can you do that for us? If so, please let me know and I'll get the 
> paperwork ball rolling for you.

Yes, I can do copyright assignment.  I sent an email to assign <at> gnu.org per
the directions at 
https://www.gnu.org/software/gnulib/Copyright/request-assign.future ,
as referenced from
https://git.savannah.gnu.org/cgit/coreutils.git/plain/HACKING ,
as referenced from
https://www.gnu.org/software/coreutils/


Thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.