From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 15 02:09:51 2018 Received: (at submit) by debbugs.gnu.org; 15 Dec 2018 07:09:51 +0000 Received: from localhost ([127.0.0.1]:48904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gY458-0001uP-Qi for submit@debbugs.gnu.org; Sat, 15 Dec 2018 02:09:51 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gY457-0001uA-5F for submit@debbugs.gnu.org; Sat, 15 Dec 2018 02:09:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gY451-0008Q2-IO for submit@debbugs.gnu.org; Sat, 15 Dec 2018 02:09:44 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43942) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gY451-0008Pp-FD for submit@debbugs.gnu.org; Sat, 15 Dec 2018 02:09:43 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gY450-0004UP-NE for bug-guix@gnu.org; Sat, 15 Dec 2018 02:09:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gY44x-0008IB-JU for bug-guix@gnu.org; Sat, 15 Dec 2018 02:09:42 -0500 Received: from mx1.riseup.net ([198.252.153.129]:47106) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gY44x-0008G2-BG for bug-guix@gnu.org; Sat, 15 Dec 2018 02:09:39 -0500 Received: from piha.riseup.net (piha-pn.riseup.net [10.0.1.163]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.riseup.net (Postfix) with ESMTPS id 4BA061A0468 for ; Fri, 14 Dec 2018 23:09:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1544857778; bh=tVtlK9lUImujUTrKRGGXKPVyPuiq4fIcB+RGdwVrD1Y=; h=Date:From:To:Subject:From; b=bsZczNcnzk1ubemz/04v7eSnxtB0sHVk2rGExZKJ/BTcxIkpo5OLPeRVRdQ/Ogatb /MX6KivPnCBaOkVOEGZcDD81Fz5n3zryjDmLERLpyHSE++yDJi7wGPaCrFBpNWjOUw 0iGbYjlGk5EeW3tkrwa+gL6MeXqCgBQSZJ0hOWY8= X-Riseup-User-ID: B9215562418F58C02186213F02E484181F162739CBE856008612ACB30C279389 Received: from [127.0.0.1] (localhost [127.0.0.1]) by piha.riseup.net with ESMTPSA id 1EC366B16F for ; Fri, 14 Dec 2018 23:09:38 -0800 (PST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Fri, 14 Dec 2018 23:09:37 -0800 From: swedebugia@riseup.net To: bug-guix@gnu.org Subject: error: execlp: No such file or directory from guix environment Message-ID: <6d6639a0587b793ec342c7d1de36e7c3@riseup.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) Hi Is this a bug? sdb@antelope ~/src/guix$ guix environment guix -- ad-hoc libgit2 texinfo guix environment: error: execlp: No such file or directory I meant to type: sdb@antelope ~/src/guix$ guix environment guix --ad-hoc libgit2 texinfo I would have liked an error saying "error: package ad-hoc not found - cannot add it to the environment" -- Cheers Swedebugia From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 15 04:41:00 2018 Received: (at 33755) by debbugs.gnu.org; 15 Dec 2018 09:41:00 +0000 Received: from localhost ([127.0.0.1]:48956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gY6RQ-0005ZW-6c for submit@debbugs.gnu.org; Sat, 15 Dec 2018 04:41:00 -0500 Received: from lepiller.eu ([89.234.186.109]:45588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gY6RO-0005ZO-Rm for 33755@debbugs.gnu.org; Sat, 15 Dec 2018 04:40:59 -0500 Received: from [100.66.218.119] (158.255.3.14 [158.255.3.14]) by lepiller.eu (OpenSMTPD) with ESMTPSA id 73c65fc5 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sat, 15 Dec 2018 09:37:59 +0000 (UTC) Date: Sat, 15 Dec 2018 10:40:48 +0100 User-Agent: K-9 Mail for Android In-Reply-To: <6d6639a0587b793ec342c7d1de36e7c3@riseup.net> References: <6d6639a0587b793ec342c7d1de36e7c3@riseup.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: bug#33755: error: execlp: No such file or directory from guix environment To: swedebugia@riseup.net,33755@debbugs.gnu.org From: Julien Lepiller Message-ID: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33755 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, this is because we have a -- option=2E "guix environment guix -- ad-hoc= libgit2" means you want to run "ad-hoc libgit2" in a guix environment=2E T= he error message tells you that it can't find an ad-hoc executable in that = environment=2E There is no "ad-hoc" package involved here=E2=80=A6 Le 15 d=C3=A9cembre 2018 08:09:37 GMT+01:00, swedebugia@riseup=2Enet a =C3= =A9crit : >Hi > >Is this a bug? > >sdb@antelope ~/src/guix$ guix environment guix -- ad-hoc libgit2 >texinfo >guix environment: error: execlp: No such file or directory > >I meant to type:=20 >sdb@antelope ~/src/guix$ guix environment guix --ad-hoc libgit2 texinfo > >I would have liked an error saying "error: package ad-hoc not found - >cannot add it to the environment" From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 15 13:18:43 2018 Received: (at 33755) by debbugs.gnu.org; 15 Dec 2018 18:18:43 +0000 Received: from localhost ([127.0.0.1]:49613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYEWQ-0006GZ-Vl for submit@debbugs.gnu.org; Sat, 15 Dec 2018 13:18:43 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:40025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYEWO-0006GN-Jg for 33755@debbugs.gnu.org; Sat, 15 Dec 2018 13:18:41 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 9CCD1E25; Sat, 15 Dec 2018 13:18:34 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 15 Dec 2018 13:18:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=w96Qwi W+HyNXp8enFPVluwZEd6vBZSXkMl/NO4ShhTs=; b=P8m1aMagu9CVf0Vgy8kY0t IUiAMWh23+vTjCREEgRWl0iszuCMHA06TenOUUZ932IEne+zg2AGTo5xivJq1hVD UF2NPWw7jK9XQV5sxvHIOBbd/CwGSUH9j/4ZJvoCydL44GZAr4/b5AKKhrVMH+89 OAlE6yU5NnoMMpCBcKK9ZDnSMhXcYDaBjS3It8T2/I+82eV28pN5OCNqugbSxgc6 1Jpj+ACEy2pVdnadQqh5O5QKOHxC9IyZyYAI1wJACauLoE78X6tjIwkDAcjWuEd3 0lLcNiH3k2xPxCRLrtkb1n7nuw+naga/bilcuaaEkjigBR2gzmCqu0nwUUpX8pRA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudehjedguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecu fedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufgjfh gffffkgggtsehmtderredtreejnecuhfhrohhmpefvihhmohhthhihucfurghmphhlvgcu oehsrghmphhlvghtsehnghihrhhordgtohhmqeenucfkphepjeegrdduudeirddukeeird eggeenucfrrghrrghmpehmrghilhhfrhhomhepshgrmhhplhgvthesnhhghihrohdrtgho mhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from mrblack (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA id 59C50E4675; Sat, 15 Dec 2018 13:18:33 -0500 (EST) From: Timothy Sample To: Julien Lepiller Subject: Re: bug#33755: error: execlp: No such file or directory from guix environment In-Reply-To: (Julien Lepiller's message of "Sat, 15 Dec 2018 10:40:48 +0100") References: <6d6639a0587b793ec342c7d1de36e7c3@riseup.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Sat, 15 Dec 2018 13:18:32 -0500 Message-ID: <87h8femz5z.fsf@ngyro.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33755 Cc: swedebugia@riseup.net, 33755@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Julien Lepiller writes: > Hi, this is because we have a -- option. "guix environment guix -- > ad-hoc libgit2" means you want to run "ad-hoc libgit2" in a guix > environment. The error message tells you that it can't find an ad-hoc > executable in that environment. There is no "ad-hoc" package involved > here=E2=80=A6 This is true, but I would argue that the error message is not quite as clear as you say. Specifically, it does not mention =E2=80=9Cad-hoc=E2=80= =9D at all. I=E2=80=99ve attached a patch that so that the command $ guix environment guix -- ad-hoc prints guix environment: error: ad-hoc: command not found and exits with status 127. (In imitation of =E2=80=9Cbash -c 'ad-hoc'=E2= =80=9D.) Thoughts? > Le 15 d=C3=A9cembre 2018 08:09:37 GMT+01:00, swedebugia@riseup.net a =C3= =A9crit : >>Hi >> >>Is this a bug? >> >>sdb@antelope ~/src/guix$ guix environment guix -- ad-hoc libgit2 >>texinfo >>guix environment: error: execlp: No such file or directory >> >>I meant to type:=20 >>sdb@antelope ~/src/guix$ guix environment guix --ad-hoc libgit2 texinfo >> >>I would have liked an error saying "error: package ad-hoc not found - >>cannot add it to the environment" -- Tim --=-=-= Content-Type: message/external-body; name="/home/samplet/code/3rdparty/guix/0001-environment-Print-command-name-on-execlp-error.patch"; access-type=local-file Content-Type: text/x-patch Content-ID: <87ftuymz5z.fsf@ngyro.com> Content-Transfer-Encoding: binary --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 15 13:36:03 2018 Received: (at 33755) by debbugs.gnu.org; 15 Dec 2018 18:36:03 +0000 Received: from localhost ([127.0.0.1]:49622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYEnC-0006mQ-Kn for submit@debbugs.gnu.org; Sat, 15 Dec 2018 13:36:02 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:56497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYEnA-0006lw-8n for 33755@debbugs.gnu.org; Sat, 15 Dec 2018 13:36:01 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 1E28EA00; Sat, 15 Dec 2018 13:35:54 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 15 Dec 2018 13:35:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=BFiLCd dW3ty+tRtXxQh7PilyKjtU7lyTzcq92MtDL/w=; b=F6biOHoLwyq+DST3RH8vsP C8QCVG66SqFL+G1VVe+3s2eieiuHIu5AXE1m4l534WU2YX/76+mF+7QMyD3YI5Ba o7zdey0oDGKh8znG5STt+QM2aBC7uTy2xtrSS2Xa9xZVJYd2yNTKnS6fA8Xns0f7 U4uZgqgHzNRTD7+LBRDclAj6BzlQyjf36j8FKiYP7zv3byUEVMk4yj53NFj8FxcF oj1CYNZ80dihBZF5T1E9PzETIPJG+dIy9DE3njlZZz+JmA+KAk7Xfgyh4WMV7BIa /tnk8SIBz8h4WtDrhjBZc0OAS7NkIJ6Pg74nDktcLQVR1suUExyTyxaN1RXiXG6w == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudehjedgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecu fedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhfff gjkfgfgggtsehmtderredtredtnecuhfhrohhmpefvihhmohhthhihucfurghmphhlvgcu oehsrghmphhlvghtsehnghihrhhordgtohhmqeenucfkphepjeegrdduudeirddukeeird eggeenucfrrghrrghmpehmrghilhhfrhhomhepshgrmhhplhgvthesnhhghihrohdrtgho mhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from mrblack (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA id CC3D1E43A6; Sat, 15 Dec 2018 13:35:52 -0500 (EST) From: Timothy Sample To: Julien Lepiller Subject: Re: bug#33755: error: execlp: No such file or directory from guix environment References: <6d6639a0587b793ec342c7d1de36e7c3@riseup.net> <87h8femz5z.fsf@ngyro.com> Date: Sat, 15 Dec 2018 13:35:52 -0500 In-Reply-To: <87h8femz5z.fsf@ngyro.com> (Timothy Sample's message of "Sat, 15 Dec 2018 13:18:32 -0500") Message-ID: <875zvumyd3.fsf@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33755 Cc: swedebugia@riseup.net, 33755@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Bah! I goofed on the attachment. Sorry for the trouble. Here it is again. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-environment-Print-command-name-on-execlp-error.patch >From e88baf0363607d4e072f5a29a2cd01ededfa00d2 Mon Sep 17 00:00:00 2001 From: Timothy Sample Date: Sat, 15 Dec 2018 12:57:52 -0500 Subject: [PATCH] environment: Print command name on execlp error. Fixes . * guix/scripts/environment.scm: When execlp raises ENOENT, print a clear error message and exit with status 127 (like a shell would). --- guix/scripts/environment.scm | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/guix/scripts/environment.scm b/guix/scripts/environment.scm index 5965e3426..27483acb2 100644 --- a/guix/scripts/environment.scm +++ b/guix/scripts/environment.scm @@ -389,7 +389,15 @@ variables are cleared before setting the new ones." (create-environment profile manifest #:pure? pure?) (match command ((program . args) - (apply execlp program program args)))) + (catch 'system-error + (lambda () + (apply execlp program program args)) + (lambda args + (if (= ENOENT (system-error-errno args)) + (begin + (report-error (G_ "~a: command not found~%") program) + (exit 127)) + (apply throw args))))))) (define* (launch-environment/fork command profile manifest #:key pure?) "Run COMMAND in a new process with an environment containing PROFILE, with -- 2.20.0 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Timothy Sample writes: > Hi, > > Julien Lepiller writes: > >> Hi, this is because we have a -- option. "guix environment guix -- >> ad-hoc libgit2" means you want to run "ad-hoc libgit2" in a guix >> environment. The error message tells you that it can't find an ad-hoc >> executable in that environment. There is no "ad-hoc" package involved >> here=E2=80=A6 > > This is true, but I would argue that the error message is not quite as > clear as you say. Specifically, it does not mention =E2=80=9Cad-hoc=E2= =80=9D at all. > I=E2=80=99ve attached a patch that so that the command > > $ guix environment guix -- ad-hoc > > prints > > guix environment: error: ad-hoc: command not found > > and exits with status 127. (In imitation of =E2=80=9Cbash -c 'ad-hoc'=E2= =80=9D.) > > Thoughts? > >> Le 15 d=C3=A9cembre 2018 08:09:37 GMT+01:00, swedebugia@riseup.net a =C3= =A9crit : >>>Hi >>> >>>Is this a bug? >>> >>>sdb@antelope ~/src/guix$ guix environment guix -- ad-hoc libgit2 >>>texinfo >>>guix environment: error: execlp: No such file or directory >>> >>>I meant to type:=20 >>>sdb@antelope ~/src/guix$ guix environment guix --ad-hoc libgit2 texinfo >>> >>>I would have liked an error saying "error: package ad-hoc not found - >>>cannot add it to the environment" > > > -- Tim --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 15 14:39:00 2018 Received: (at 33755) by debbugs.gnu.org; 15 Dec 2018 19:39:00 +0000 Received: from localhost ([127.0.0.1]:49670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYFm8-0008Mp-7p for submit@debbugs.gnu.org; Sat, 15 Dec 2018 14:39:00 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:34148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYFm6-0008Mh-7x for 33755@debbugs.gnu.org; Sat, 15 Dec 2018 14:38:58 -0500 Received: from localhost (178.112.139.158.wireless.dyn.drei.com [178.112.139.158]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 57B53336038A; Sat, 15 Dec 2018 20:38:56 +0100 (CET) Date: Sat, 15 Dec 2018 20:38:53 +0100 From: Danny Milosavljevic To: Timothy Sample Subject: Re: bug#33755: error: execlp: No such file or directory from guix environment Message-ID: <20181215203853.1b267a72@scratchpost.org> In-Reply-To: <875zvumyd3.fsf@ngyro.com> References: <6d6639a0587b793ec342c7d1de36e7c3@riseup.net> <87h8femz5z.fsf@ngyro.com> <875zvumyd3.fsf@ngyro.com> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/0OlSMeXCh_=aJm2p+uPOMfu"; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33755 Cc: swedebugia@riseup.net, 33755@debbugs.gnu.org, Julien Lepiller X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/0OlSMeXCh_=aJm2p+uPOMfu Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Tim, I like it in princple, but why special-case ENOENT? I think it would be be= tter to just always print the program name (and maybe program args, too!) a= nd the system error message. --Sig_/0OlSMeXCh_=aJm2p+uPOMfu Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlwVWE0ACgkQ5xo1VCww uqUWYgf/dWp5EA5nSwcOxyZMZwd7ZZKVY+YSlP8gidyJjXR+5qGVtfOukF9mqOsr FLZgCC8DC1AJIxMd/5TCqGJckGKcJmuo3/HVXlhHeeOSUdq3zD13wZkOC3cz24pb clhfiSl6LEOWSBWV1j4rnX19kbr2tdsG0R7D1xM6XnNlouVLbyaXmTyTEyASfbGy CDkc/bZG9eieRmNZ1W9wvUFDGIk+QRd1PkgsmaF1w44CMWHGNO4NlnO1YvXzHulE 5ZkVUtic983+rnDK6MkzxRstnsbxz040aCiZwVjJc+hR7BtM/k/4W/8/j+LX6A0u GyoJ7Te0487K5Wh/Ac1k/4U07y7rOw== =YI+s -----END PGP SIGNATURE----- --Sig_/0OlSMeXCh_=aJm2p+uPOMfu-- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 15 23:26:19 2018 Received: (at 33755) by debbugs.gnu.org; 16 Dec 2018 04:26:19 +0000 Received: from localhost ([127.0.0.1]:49827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYO0Q-0003jh-T2 for submit@debbugs.gnu.org; Sat, 15 Dec 2018 23:26:19 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:44743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYO0O-0003jR-TV for 33755@debbugs.gnu.org; Sat, 15 Dec 2018 23:26:17 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 21A67C5F; Sat, 15 Dec 2018 23:26:10 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 15 Dec 2018 23:26:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=fgoZp8 Aec84PVVkX2TVfQXRO8aSvRSwmBK99b4fxPPQ=; b=HyuBhNA5x0VGONHe9HPM5x glVZN855E44N+UB+jOyeej/wsACiX1ki7mOCHKCnH8uilEvNVZPbOkUel7Ote4dV 7QymuoPiQoP59ZJYzId9Gm+a6CIGb25/I0i5tI0i8e4ZU7qpBOYnl06OftNLEayP BGaQ5rk9TxriVOQ9ZyI6AAdBQ7vD3HvtXkxGQkECAR7abCqMGS+zwd3GctkQk6w4 1o1vwNMBkSRTftXm77Oyz01rssqjLSnWGGcc4hV/h9zYmgHlrl6VBvr3hes52i9k jGcJkPKWQnQU1rHpx6m+DwsXFb+KwQcwBdvGrMsam6/zspnKvcF+BeQPEUij2xjg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudehkedgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffujghffg ffkfggtgesmhdtreertderjeenucfhrhhomhepvfhimhhothhhhicuufgrmhhplhgvuceo shgrmhhplhgvthesnhhghihrohdrtghomheqnecukfhppeejgedrudduiedrudekiedrge egnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsrghmphhlvghtsehnghihrhhordgtohhm necuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from mrblack (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA id 52F4110087; Sat, 15 Dec 2018 23:26:08 -0500 (EST) From: Timothy Sample To: Danny Milosavljevic Subject: Re: bug#33755: error: execlp: No such file or directory from guix environment In-Reply-To: <20181215203853.1b267a72@scratchpost.org> (Danny Milosavljevic's message of "Sat, 15 Dec 2018 20:38:53 +0100") References: <6d6639a0587b793ec342c7d1de36e7c3@riseup.net> <87h8femz5z.fsf@ngyro.com> <875zvumyd3.fsf@ngyro.com> <20181215203853.1b267a72@scratchpost.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Sat, 15 Dec 2018 23:26:07 -0500 Message-ID: <87efaiyu5c.fsf@ngyro.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33755 Cc: swedebugia@riseup.net, 33755@debbugs.gnu.org, Julien Lepiller X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Danny, Danny Milosavljevic writes: > Hi Tim, > > I like it in princple, but why special-case ENOENT? I think it would > be better to just always print the program name (and maybe program > args, too!) and the system error message. You are right. I got fixated on the fact that it was failing the $PATH search, and forgot about the more general cases. I think printing the program name and the system error message is the right choice. According to the manual for =E2=80=9Cexecve=E2=80=9D, the arguments only ca= use an error if they exceed ARG_MAX, in which case we probably don=E2=80=99t want to pri= nt them anyway. Here=E2=80=99s an updated patch. I also got rid of the 127 status code, si= nce doesn=E2=80=99t make sense for the more general cases. Thanks for the help! -- Tim --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-environment-Print-command-name-on-execlp-error.patch >From aedc745a3f9765ae00dc61a59fa53d22a458551b Mon Sep 17 00:00:00 2001 From: Timothy Sample Date: Sat, 15 Dec 2018 23:17:46 -0500 Subject: [PATCH] environment: Print command name on execlp error. Fixes . * guix/scripts/environment.scm (launch-environment): When execlp fails, include the command name in the error message. --- guix/scripts/environment.scm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/guix/scripts/environment.scm b/guix/scripts/environment.scm index 5965e3426..64035a740 100644 --- a/guix/scripts/environment.scm +++ b/guix/scripts/environment.scm @@ -389,7 +389,12 @@ variables are cleared before setting the new ones." (create-environment profile manifest #:pure? pure?) (match command ((program . args) - (apply execlp program program args)))) + (catch 'system-error + (lambda () + (apply execlp program program args)) + (lambda args + (let ((errno (system-error-errno args))) + (leave (G_ "~a: ~a~%") program (strerror errno)))))))) (define* (launch-environment/fork command profile manifest #:key pure?) "Run COMMAND in a new process with an environment containing PROFILE, with -- 2.20.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 16 11:05:43 2018 Received: (at 33755) by debbugs.gnu.org; 16 Dec 2018 16:05:43 +0000 Received: from localhost ([127.0.0.1]:50521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYYvF-0006zj-1S for submit@debbugs.gnu.org; Sun, 16 Dec 2018 11:05:42 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYYvD-0006zW-HX for 33755@debbugs.gnu.org; Sun, 16 Dec 2018 11:05:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gYYv7-00030F-C5 for 33755@debbugs.gnu.org; Sun, 16 Dec 2018 11:05:34 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42043) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYYv6-0002zs-Mj; Sun, 16 Dec 2018 11:05:32 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=32870 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gYYv6-0005Qt-DM; Sun, 16 Dec 2018 11:05:32 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Timothy Sample Subject: Re: bug#33755: error: execlp: No such file or directory from guix environment References: <6d6639a0587b793ec342c7d1de36e7c3@riseup.net> <87h8femz5z.fsf@ngyro.com> <875zvumyd3.fsf@ngyro.com> <20181215203853.1b267a72@scratchpost.org> <87efaiyu5c.fsf@ngyro.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 26 Frimaire an 227 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 16 Dec 2018 17:05:31 +0100 In-Reply-To: <87efaiyu5c.fsf@ngyro.com> (Timothy Sample's message of "Sat, 15 Dec 2018 23:26:07 -0500") Message-ID: <8736qxtq2c.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33755 Cc: swedebugia@riseup.net, Danny Milosavljevic , 33755@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hello comrades! Timothy Sample skribis: > Danny Milosavljevic writes: > >> Hi Tim, >> >> I like it in princple, but why special-case ENOENT? I think it would >> be better to just always print the program name (and maybe program >> args, too!) and the system error message. > > You are right. [...] > From aedc745a3f9765ae00dc61a59fa53d22a458551b Mon Sep 17 00:00:00 2001 > From: Timothy Sample > Date: Sat, 15 Dec 2018 23:17:46 -0500 > Subject: [PATCH] environment: Print command name on execlp error. > > Fixes . > > * guix/scripts/environment.scm (launch-environment): When execlp fails, > include the command name in the error message. Another option would be to do: (set! execl (error-reporting-wrapper =E2=80=A6)) in (guix ui), as done for a few other procedures that have the same issue. WDYT? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 16 23:41:50 2018 Received: (at 33755) by debbugs.gnu.org; 17 Dec 2018 04:41:50 +0000 Received: from localhost ([127.0.0.1]:50761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYkiy-0004sx-Ly for submit@debbugs.gnu.org; Sun, 16 Dec 2018 23:41:48 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:57435) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYkiw-0004sb-Ao for 33755@debbugs.gnu.org; Sun, 16 Dec 2018 23:41:46 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id E11B221BD8; Sun, 16 Dec 2018 23:41:40 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 16 Dec 2018 23:41:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=azziRg M2hxOHX+T5RvIxVKw/0CRtytvBg0D0RtrqWyk=; b=zE7iQCkrbYs5eim3PW8EhB U4NRtjKPk3qQFQb26Eyg1kyLKQl5Kwa4Rs4f7GC5OB2XYhKe7RX7RL2V6mrJiFDP XajPfMmJcOaMvIcY0H+DuZyMBJjqPq7DZUb/ev3rdFkCOm43EGv0iO3+YaUpCKBP zQul9z/XV/GM3F9mbNozvWXOO5ngGrDeS7o4qnMleHPzVeh2L08JKmXIVYMYyW9z 2fnywGMAZW4vwfdJGJNeRIfDtSrTk9mgvUiU/TilbVeD96677dpQc6cBVoRLBGD6 64fPYG3H0NY1YYjOecdkv1p7a7FpvyEQzgkVfuciFkd2YJkIfVhjidsVoIW2rZQw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudeiuddgudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufhffjg fkfgggtgesmhdtreertderjeenucfhrhhomhepvfhimhhothhhhicuufgrmhhplhgvuceo shgrmhhplhgvthesnhhghihrohdrtghomheqnecuffhomhgrihhnpehgnhhurdhorhhgne cukfhppeejgedrudduiedrudekiedrgeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehs rghmphhlvghtsehnghihrhhordgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from mrblack (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA id 7085910085; Sun, 16 Dec 2018 23:41:39 -0500 (EST) From: Timothy Sample To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#33755: error: execlp: No such file or directory from guix environment References: <6d6639a0587b793ec342c7d1de36e7c3@riseup.net> <87h8femz5z.fsf@ngyro.com> <875zvumyd3.fsf@ngyro.com> <20181215203853.1b267a72@scratchpost.org> <87efaiyu5c.fsf@ngyro.com> <8736qxtq2c.fsf@gnu.org> Date: Sun, 16 Dec 2018 23:41:38 -0500 In-Reply-To: <8736qxtq2c.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sun, 16 Dec 2018 17:05:31 +0100") Message-ID: <875zvszrwd.fsf@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33755 Cc: swedebugia@riseup.net, Danny Milosavljevic , 33755@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo, Ludovic Court=C3=A8s writes: > Hello comrades! > > Timothy Sample skribis: > >> [...] >> >> From aedc745a3f9765ae00dc61a59fa53d22a458551b Mon Sep 17 00:00:00 2001 >> From: Timothy Sample >> Date: Sat, 15 Dec 2018 23:17:46 -0500 >> Subject: [PATCH] environment: Print command name on execlp error. >> >> Fixes . >> >> * guix/scripts/environment.scm (launch-environment): When execlp fails, >> include the command name in the error message. > > Another option would be to do: > > (set! execl > (error-reporting-wrapper =E2=80=A6)) > > in (guix ui), as done for a few other procedures that have the same > issue. > > WDYT? Aha! I didn=E2=80=99t know about =E2=80=9Cerror-reporting-wrapper=E2=80=9D= . I think this makes sense. It fixes the same issue in the container script, too. I=E2=80=99ve attached an updated patch. I had to modify =E2=80=9Cerror-reporting-wrapper=E2=80=9D to deal with the = fact that =E2=80=9Cexeclp=E2=80=9D takes a variable number of arguments. I tested it= and it works for the old use-case as well as the new. On whether or not it works stylistically, I defer to you. -- Tim --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-ui-Report-file-names-in-system-error-exceptions-from.patch >From 428b80973026909c915e1f33d4509e82f66355e3 Mon Sep 17 00:00:00 2001 From: Timothy Sample Date: Sun, 16 Dec 2018 23:12:13 -0500 Subject: [PATCH] ui: Report file names in 'system-error' exceptions from 'execlp'. Fixes . * guix/ui.scm (apply-formals): New macro. (execlp): New error-reporting wrapper. --- guix/ui.scm | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/guix/ui.scm b/guix/ui.scm index 60636edac..148c18103 100644 --- a/guix/ui.scm +++ b/guix/ui.scm @@ -502,14 +502,19 @@ General help using GNU software: ")) (list (strerror (car errno)) file) (list errno)))) -(define-syntax-rule (error-reporting-wrapper proc (args ...) file) +(define-syntax apply-formals + (syntax-rules () + ((_ proc (args ...)) (proc args ...)) + ((_ proc (arg1 args ... . rest)) (apply proc arg1 args ... rest)))) + +(define-syntax-rule (error-reporting-wrapper proc formals file) "Wrap PROC such that its 'system-error' exceptions are augmented to mention FILE." (let ((real-proc (@ (guile) proc))) - (lambda (args ...) + (lambda formals (catch 'system-error (lambda () - (real-proc args ...)) + (apply-formals real-proc formals)) (augmented-system-error-handler file))))) (set! symlink @@ -528,6 +533,8 @@ FILE." (set! delete-file (error-reporting-wrapper delete-file (file) file)) +(set! execlp + (error-reporting-wrapper execlp (filename . args) filename)) (define (make-regexp* regexp . flags) "Like 'make-regexp' but error out if REGEXP is invalid, reporting the error -- 2.20.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 18 04:05:34 2018 Received: (at 33755-done) by debbugs.gnu.org; 18 Dec 2018 09:05:34 +0000 Received: from localhost ([127.0.0.1]:52596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZBJk-0000dH-7a for submit@debbugs.gnu.org; Tue, 18 Dec 2018 04:05:34 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZBJi-0000d2-Ga for 33755-done@debbugs.gnu.org; Tue, 18 Dec 2018 04:05:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZBJX-0007YQ-94 for 33755-done@debbugs.gnu.org; Tue, 18 Dec 2018 04:05:25 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZBJT-0007Uh-Dd; Tue, 18 Dec 2018 04:05:15 -0500 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=56102 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gZBJS-0000mW-UB; Tue, 18 Dec 2018 04:05:15 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Timothy Sample Subject: Re: bug#33755: error: execlp: No such file or directory from guix environment References: <6d6639a0587b793ec342c7d1de36e7c3@riseup.net> <87h8femz5z.fsf@ngyro.com> <875zvumyd3.fsf@ngyro.com> <20181215203853.1b267a72@scratchpost.org> <87efaiyu5c.fsf@ngyro.com> <8736qxtq2c.fsf@gnu.org> <875zvszrwd.fsf@ngyro.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 28 Frimaire an 227 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 18 Dec 2018 10:05:12 +0100 In-Reply-To: <875zvszrwd.fsf@ngyro.com> (Timothy Sample's message of "Sun, 16 Dec 2018 23:41:38 -0500") Message-ID: <87tvjbjjcn.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33755-done Cc: swedebugia@riseup.net, Danny Milosavljevic , 33755-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hi Timothy, Timothy Sample skribis: > Aha! I didn=E2=80=99t know about =E2=80=9Cerror-reporting-wrapper=E2=80= =9D. I think this makes > sense. It fixes the same issue in the container script, too. I=E2=80=99= ve > attached an updated patch. > > I had to modify =E2=80=9Cerror-reporting-wrapper=E2=80=9D to deal with th= e fact that > =E2=80=9Cexeclp=E2=80=9D takes a variable number of arguments. I tested = it and it works > for the old use-case as well as the new. On whether or not it works > stylistically, I defer to you. I like it. :-) > From 428b80973026909c915e1f33d4509e82f66355e3 Mon Sep 17 00:00:00 2001 > From: Timothy Sample > Date: Sun, 16 Dec 2018 23:12:13 -0500 > Subject: [PATCH] ui: Report file names in 'system-error' exceptions from > 'execlp'. > > Fixes . > > * guix/ui.scm (apply-formals): New macro. > (execlp): New error-reporting wrapper. Applied, thank you! Ludo=E2=80=99. From unknown Thu Sep 11 02:37:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 15 Jan 2019 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator