From unknown Fri Aug 15 20:04:05 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3375: 23.0.94; Document incompatible change to format of bookmarks Reply-To: "Drew Adams" , 3375@debbugs.gnu.org Resent-From: "Drew Adams" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 25 May 2009 21:30:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 3375 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.124328687611690 (code B ref -1); Mon, 25 May 2009 21:30:05 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 25 May 2009 21:27:56 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.4 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4PLRqYm011683 for ; Mon, 25 May 2009 14:27:53 -0700 Received: from mail.gnu.org ([199.232.76.166]:55827 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1M8gBn-0005CF-Kf for emacs-pretest-bug@gnu.org; Mon, 25 May 2009 15:50:27 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1M8gBm-0005Qp-7s for emacs-pretest-bug@gnu.org; Mon, 25 May 2009 15:50:27 -0400 Received: from acsinet12.oracle.com ([141.146.126.234]:29408) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M8gBl-0005Qh-NQ for emacs-pretest-bug@gnu.org; Mon, 25 May 2009 15:50:25 -0400 Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by acsinet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4PJo5sK003330 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 25 May 2009 19:50:07 GMT Received: from abhmt002.oracle.com (abhmt002.oracle.com [141.146.116.11]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4PJoNCA019649 for ; Mon, 25 May 2009 19:50:23 GMT Received: from dradamslap1 (/98.210.250.59) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 25 May 2009 12:50:19 -0700 From: "Drew Adams" To: Date: Mon, 25 May 2009 12:50:40 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcndchTRbD6A3nCXTLS7uwpt/lKLRQ== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt002.oracle.com [141.146.116.11] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A010207.4A1AF67C.00B2:SCFSTAT5015188,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Emacs 23 apparently introduces an incompatible change to the format of bookmarks. A bookmark that formerly would have had this form: ("Directories" ((front-context-string . "\n22.8 File Direc") (rear-context-string . ": > Directories\n") (position . 133657) (filename . "c:/Emacs-23-0-3/info/emacs") (info-node . "Directories") (handler . Info-bookmark-jump))) Now can have this form: ("Directories" (front-context-string . "\n22.8 File Direc") (rear-context-string . ": > Directories\n") (position . 133657) (filename . "c:/Emacs-23-0-3/info/emacs") (info-node . "Directories") (handler . Info-bookmark-jump)) The is handled in the changed definition of `bookmark-get-bookmark-record', which accommodates both forms. However, if you try to do, say, `C-x r l' in Emacs 22 and you have created a bookmark of the latter form (using Emacs 23), then `C-x r l' raises an error. That's normal - Emacs 22 can't know about the incompatible change that Emacs 23 introduces. I don't know why this change was necessary. (Why?) But let's assume that it was in fact necessary. The bug is that it is totally undocumented. Please _at least_ document this in NEWS. The _only_ thing mentioned in NEWS about bookmarks is this: "*** bookmark provides `bookmark-make-record-function' so special major modes like Info can teach bookmark.el how to save and restore the relevant data." In GNU Emacs 23.0.94.1 (i386-mingw-nt5.1.2600) of 2009-05-24 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4)' From unknown Fri Aug 15 20:04:05 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: "Drew Adams" Subject: bug#3375 closed by Karl Fogel (Fix "Document incompatible change to format of bookmarks") Message-ID: References: <87ljjlb0cp.fsf@red-bean.com> X-Emacs-PR-Message: they-closed 3375 X-Emacs-PR-Package: emacs Reply-To: 3375@debbugs.gnu.org Date: Fri, 09 Oct 2009 05:35:06 +0000 Content-Type: multipart/mixed; boundary="----------=_1255066506-9922-1" This is a multi-part message in MIME format... ------------=_1255066506-9922-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #3375: 23.0.94; Document incompatible change to format of bookmarks It has been closed by Karl Fogel . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Karl Fogel by replying to this email. --=20 3375: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D3375 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1255066506-9922-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 3375-close) by emacsbugs.donarmstrong.com; 9 Oct 2009 05:30:32 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.2 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from sanpietro.red-bean.com (Debian-exim@sanpietro.red-bean.com [66.146.206.141]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n995UVJx009699 for <3375-close@emacsbugs.donarmstrong.com>; Thu, 8 Oct 2009 22:30:32 -0700 Received: from localhost ([127.0.0.1]:33920 helo=floss ident=kfogel) by sanpietro.red-bean.com with esmtp (Exim 4.69) (envelope-from ) id 1Mw83i-00025P-L4 for 3375-close@emacsbugs.donarmstrong.com; Fri, 09 Oct 2009 00:30:30 -0500 From: Karl Fogel To: 3375-close@debbugs.gnu.org Subject: Fix "Document incompatible change to format of bookmarks" Reply-To: Karl Fogel Date: Fri, 09 Oct 2009 01:30:30 -0400 Message-ID: <87ljjlb0cp.fsf@red-bean.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii fixed -- Thanks for the report. I've documented the format change in NEWS; here's the commit: $ cvs ci -F msg etc/NEWS etc/ChangeLog /sources/emacs/emacs/etc/NEWS,v <-- etc/NEWS new revision: 1.2100; previous revision: 1.2099 /sources/emacs/emacs/etc/ChangeLog,v <-- etc/ChangeLog new revision: 1.812; previous revision: 1.811 Mailing notification to emacs-diffs@gnu.org... sent. $ (I don't know why the default write-out format was changed, as I didn't commit rev 1.114 of bookmark.el. We could investigate and find out, but it would be of forensic interest only at this point -- the change is made, and there's a long list of bookmark.el bugs to go. So I'm not going to investigate the reasoning behind 1.114 closely; if you happen to find out, please let me know.) -Karl ------------=_1255066506-9922-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 25 May 2009 21:27:56 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.4 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4PLRqYm011683 for ; Mon, 25 May 2009 14:27:53 -0700 Received: from mail.gnu.org ([199.232.76.166]:55827 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1M8gBn-0005CF-Kf for emacs-pretest-bug@gnu.org; Mon, 25 May 2009 15:50:27 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1M8gBm-0005Qp-7s for emacs-pretest-bug@gnu.org; Mon, 25 May 2009 15:50:27 -0400 Received: from acsinet12.oracle.com ([141.146.126.234]:29408) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M8gBl-0005Qh-NQ for emacs-pretest-bug@gnu.org; Mon, 25 May 2009 15:50:25 -0400 Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by acsinet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4PJo5sK003330 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 25 May 2009 19:50:07 GMT Received: from abhmt002.oracle.com (abhmt002.oracle.com [141.146.116.11]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4PJoNCA019649 for ; Mon, 25 May 2009 19:50:23 GMT Received: from dradamslap1 (/98.210.250.59) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 25 May 2009 12:50:19 -0700 From: "Drew Adams" To: Subject: 23.0.94; Document incompatible change to format of bookmarks Date: Mon, 25 May 2009 12:50:40 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcndchTRbD6A3nCXTLS7uwpt/lKLRQ== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt002.oracle.com [141.146.116.11] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A010207.4A1AF67C.00B2:SCFSTAT5015188,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Emacs 23 apparently introduces an incompatible change to the format of bookmarks. A bookmark that formerly would have had this form: ("Directories" ((front-context-string . "\n22.8 File Direc") (rear-context-string . ": > Directories\n") (position . 133657) (filename . "c:/Emacs-23-0-3/info/emacs") (info-node . "Directories") (handler . Info-bookmark-jump))) Now can have this form: ("Directories" (front-context-string . "\n22.8 File Direc") (rear-context-string . ": > Directories\n") (position . 133657) (filename . "c:/Emacs-23-0-3/info/emacs") (info-node . "Directories") (handler . Info-bookmark-jump)) The is handled in the changed definition of `bookmark-get-bookmark-record', which accommodates both forms. However, if you try to do, say, `C-x r l' in Emacs 22 and you have created a bookmark of the latter form (using Emacs 23), then `C-x r l' raises an error. That's normal - Emacs 22 can't know about the incompatible change that Emacs 23 introduces. I don't know why this change was necessary. (Why?) But let's assume that it was in fact necessary. The bug is that it is totally undocumented. Please _at least_ document this in NEWS. The _only_ thing mentioned in NEWS about bookmarks is this: "*** bookmark provides `bookmark-make-record-function' so special major modes like Info can teach bookmark.el how to save and restore the relevant data." In GNU Emacs 23.0.94.1 (i386-mingw-nt5.1.2600) of 2009-05-24 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4)' ------------=_1255066506-9922-1-- From unknown Fri Aug 15 20:04:05 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3375: FW: Fix "Document incompatible change to format of bookmarks" Reply-To: "Drew Adams" , 3375@debbugs.gnu.org Resent-From: "Drew Adams" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Fri, 09 Oct 2009 06:30:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3375 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3375-submit@emacsbugs.donarmstrong.com id=B3375.125506934817404 (code B ref 3375); Fri, 09 Oct 2009 06:30:04 +0000 Received: (at 3375) by emacsbugs.donarmstrong.com; 9 Oct 2009 06:22:28 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.4 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from acsinet11.oracle.com (acsinet11.oracle.com [141.146.126.233]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n996MQgs017401 for <3375@emacsbugs.donarmstrong.com>; Thu, 8 Oct 2009 23:22:28 -0700 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by acsinet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n996MXdZ016175 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <3375@emacsbugs.donarmstrong.com>; Fri, 9 Oct 2009 06:22:34 GMT Received: from acsmt355.oracle.com (acsmt355.oracle.com [141.146.40.155]) by acsinet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n9966IR9032467 for <3375@emacsbugs.donarmstrong.com>; Fri, 9 Oct 2009 06:23:11 GMT Received: from abhmt019.oracle.com by acsmt357.oracle.com with ESMTP id 20306085251255069240; Fri, 09 Oct 2009 01:20:40 -0500 Received: from dradamslap1 (/24.5.184.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 08 Oct 2009 23:20:39 -0700 From: "Drew Adams" To: <3375@debbugs.gnu.org> Date: Thu, 8 Oct 2009 23:20:42 -0700 Message-ID: <08D2B8259FBD400FB5F924D2B067AE69@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcpIoZ6G/0QVzZwxR3yB7SXjwnGrWAAAv66AAAD3DAA= X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: acsmt355.oracle.com [141.146.40.155] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090205.4ACED69A.005B:SCFMA4539814,ss=1,fgs=0 Forgot to send to the bug thread. I keep forgetting that cc'ing the close message doesn't copy the actual bug thread. -----Original Message----- From: Drew Adams Sent: Thursday, October 08, 2009 11:18 PM To: 'Karl Fogel'; '3375-close@debbugs.gnu.org' Subject: RE: Fix "Document incompatible change to format of bookmarks" > Thanks for the report. I've documented the format change in NEWS;... > > (I don't know why the default write-out format was changed, > as I didn't commit rev 1.114 of bookmark.el. We could investigate > and find out, but it would be of forensic interest only at this > point -- the change is made, and there's a long list of > bookmark.el bugs to go. So I'm not going to investigate the > reasoning behind 1.114 closely; if you happen to find out, > please let me know.) Thanks for adding the NEWS entry, Karl. It's really too bad that this incompatible change was made without anyone documenting the reason (at least I haven't found such documentation). Likewise, without any discussion (that I'm aware of). One can only hope that the change was truly necessary or at least somehow useful, for whatever unknown reason. The 1.114 log entry seems to suggest that it only adjusted some parts of the code to work with "the 2 slightly different formats used until now in bookmark.el's code." It's unclear what that text really tries to mean, but if it is suggesting that the new, Emacs 23 format was already in use in (some parts of) the bookmark code, then that's not true (assuming that you're right that 1.114 is the culprit, which it does seem to be). This is an incompatible change in the basic bookmark format, starting with Emacs 23 (apparently, starting with 1.114). It seems to be a gratuitous change, but how to tell, since no reason was given? I wonder if, in making that change, Stefan was aware that the format is new, or if he perhaps really thought that it had been in use previously. Perhaps he was confused by the misleading (incorrect) comments in the file. Dunno. And we'll likely never know, as you point out. Too bad. We've now had at least two incompatible format changes to the `bookmark-alist' structure, over its history. Neither of which brought anything useful to the party, AFAICT. Oh well. Let's hope that next year someone doesn't mutate the structure to a fourth format. ;-) Thx - Drew From unknown Fri Aug 15 20:04:05 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3375: Fix "Document incompatible change to format of bookmarks" Reply-To: "Drew Adams" , 3375@debbugs.gnu.org Resent-From: "Drew Adams" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Fri, 09 Oct 2009 07:25:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3375 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3375-submit@emacsbugs.donarmstrong.com id=B3375.125507275625924 (code B ref 3375); Fri, 09 Oct 2009 07:25:06 +0000 Received: (at 3375) by emacsbugs.donarmstrong.com; 9 Oct 2009 07:19:16 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.4 required=4.0 tests=AWL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from acsinet11.oracle.com (acsinet11.oracle.com [141.146.126.233]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n997JEZt025921 for <3375@emacsbugs.donarmstrong.com>; Fri, 9 Oct 2009 00:19:15 -0700 Received: from rgminet13.oracle.com (rcsinet13.oracle.com [148.87.113.125]) by acsinet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n997JKGx000542 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 9 Oct 2009 07:19:22 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by rgminet13.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n997JbCo031558; Fri, 9 Oct 2009 07:19:37 GMT Received: from abhmt004.oracle.com by acsmt353.oracle.com with ESMTP id 20303445831255072742; Fri, 09 Oct 2009 00:19:02 -0700 Received: from dradamslap1 (/24.5.184.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 09 Oct 2009 00:19:01 -0700 From: "Drew Adams" To: "'Karl Fogel'" , <3375@debbugs.gnu.org> References: <87ljjlb0cp.fsf@red-bean.com><3D5E36D3F3A44D099A343AD97AB81599@us.oracle.com> <87vdip9hon.fsf@red-bean.com> Date: Fri, 9 Oct 2009 00:19:05 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87vdip9hon.fsf@red-bean.com> Thread-Index: AcpIrg4Bdzq65lSrRhew0/wBOXm/zQAAjk0g X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: acsmt357.oracle.com [141.146.40.157] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090209.4ACEE3E9.00CB:SCFMA4539814,ss=1,fgs=0 > Thanks for noticing the problem and taking the time to describe it so > thoroughly; that was a huge help. Thanks for your help on this. It helps even just to hear that it's normal to be confused given the current state and the history. ;-) It's not obvious for someone who tries to read the code and comments to stay convinced that s?he understands. ;-) - Drew