From unknown Sat Aug 16 13:48:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33744: 26.1; ada-mode 6.0.0 indentation of operators starting a line in a multi-line expression Resent-From: Ludovic Brenta Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Dec 2018 15:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33744 X-GNU-PR-Package: emacs, ada-mode X-GNU-PR-Keywords: To: 33744@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15448030579282 (code B ref -1); Fri, 14 Dec 2018 15:58:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Dec 2018 15:57:37 +0000 Received: from localhost ([127.0.0.1]:48462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXpqL-0002Pe-7P for submit@debbugs.gnu.org; Fri, 14 Dec 2018 10:57:37 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXpqJ-0002PR-L5 for submit@debbugs.gnu.org; Fri, 14 Dec 2018 10:57:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXpqD-0002Jp-O4 for submit@debbugs.gnu.org; Fri, 14 Dec 2018 10:57:30 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43372) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gXpqC-0002E6-Cu for submit@debbugs.gnu.org; Fri, 14 Dec 2018 10:57:29 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXpqB-0007Au-Jd for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 10:57:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXpq5-00022J-SK for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 10:57:27 -0500 Received: from webmail.bookmyname.com ([88.191.249.153]:24731 helo=webmail.free.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gXpq4-00020Q-58 for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 10:57:21 -0500 Received: from 153.98.68.208 (unknown [127.0.1.3]) by webmail.free.org (Postfix) with ESMTP id C6AEB2590C; Fri, 14 Dec 2018 16:57:17 +0100 (CET) Received: from [153.98.68.208] by webmail.ludovic-brenta.org with HTTP (HTTP/1.1 POST); Fri, 14 Dec 2018 16:57:17 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 14 Dec 2018 16:57:17 +0100 From: Ludovic Brenta Message-ID: X-Sender: ludovic@ludovic-brenta.org X-Complaints-To: abuse_at_bookmyname.com X-Abuse-Info: Please be sure to forward a copy of ALL headers X-Origin-Web-Site: webmail.ludovic-brenta.org X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) Package: emacs, ada-mode X-Debbug-CC: ada-mode-users@nongnu.org Hello, consider the line marked "incorrectly indented" below: procedure Operator_Indentation is begin if B or else C > 2 -- incorrectly indented then null; end if; end Operator_Indentation; We think the indentation performed by ada-mode 6.0.0 is incorrect. Of course we understand that the line is indented relative to B but as this line is part of a sub-expression, we think it should be indented relative to the sub-expression instead. We cannot decide which of the two following alternatives is the most "correct": procedure Operator_Indentation is begin if B or else C > 2 -- indented relative to "or else" then null; end if; end Operator_Indentation; procedure Operator_Indentation is begin if B or else C > 2 -- indented relative to C, which starts the sub-expression then null; end if; end Operator_Indentation; (we set ada-indent to 2). Of course, these examples are overly simplified; in our real code base, we don't write our operators on a separate line unless the previous line ("C" in these examples) is very long. To illustrate this, our actual code looks more like: procedure Operator_Indentation is begin if Blarg_Meets_Preconditions_For_Subsequent_Test (Blarg) or else Critical_Cruising_Configuration_Condition_Code (Blarg.Blurp) > 2 then null; end if; end Operator_Indentation; PS. The value of ada-indent-hanging-rel-exp has no effect in this particular case. -- Ludovic Brenta. From unknown Sat Aug 16 13:48:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33744: effect of ada-indent-hanging-rel-exp References: In-Reply-To: Resent-From: Stephen Leake Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Dec 2018 23:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33744 X-GNU-PR-Package: emacs, ada-mode X-GNU-PR-Keywords: To: 33744@debbugs.gnu.org Received: via spool by 33744-submit@debbugs.gnu.org id=B33744.154543407520635 (code B ref 33744); Fri, 21 Dec 2018 23:15:01 +0000 Received: (at 33744) by debbugs.gnu.org; 21 Dec 2018 23:14:35 +0000 Received: from localhost ([127.0.0.1]:58972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gaU02-0005Ml-S3 for submit@debbugs.gnu.org; Fri, 21 Dec 2018 18:14:35 -0500 Received: from smtp103.ord1d.emailsrvr.com ([184.106.54.103]:42417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gaU00-0005MV-17 for 33744@debbugs.gnu.org; Fri, 21 Dec 2018 18:14:33 -0500 Received: from smtp5.relay.ord1d.emailsrvr.com (localhost [127.0.0.1]) by smtp5.relay.ord1d.emailsrvr.com (SMTP Server) with ESMTP id 90552A0374 for <33744@debbugs.gnu.org>; Fri, 21 Dec 2018 18:14:26 -0500 (EST) X-Auth-ID: board-president@tomahawk-creek-hoa.com Received: by smtp5.relay.ord1d.emailsrvr.com (Authenticated sender: board-president-AT-tomahawk-creek-hoa.com) with ESMTPSA id 44EB3A0326 for <33744@debbugs.gnu.org>; Fri, 21 Dec 2018 18:14:26 -0500 (EST) X-Sender-Id: board-president@tomahawk-creek-hoa.com Received: from Takver4 ([UNAVAILABLE]. [76.77.182.20]) (using TLSv1.2 with cipher AES256-GCM-SHA384) by 0.0.0.0:25 (trex/5.7.12); Fri, 21 Dec 2018 18:14:26 -0500 From: Stephen Leake Date: Fri, 21 Dec 2018 15:14:23 -0800 Message-ID: <86bm5e4gmo.fsf@stephe-leake.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Ludovic writes: > The value of ada-indent-hanging-rel-exp has no effect in this > particular case. Actually, it does. With ada-indent = 2, ada-indent-hanging-rel-exp = nil, the indentation is: procedure Operator_Indentation is begin if B or else C > 2 -- indented relative to "or else" then null; end if; end Operator_Indentation; Changing an indentation parameter does not force a reparse, so calling 'indent-region' does not use the new parameter value. Use M-x wisi-parse-buffer to force a reparse and reindent. -- -- Stephe From unknown Sat Aug 16 13:48:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33744: effect of ada-indent-hanging-rel-exp References: In-Reply-To: Resent-From: Stephen Leake Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Dec 2018 23:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33744 X-GNU-PR-Package: emacs, ada-mode X-GNU-PR-Keywords: To: 33744@debbugs.gnu.org Received: via spool by 33744-submit@debbugs.gnu.org id=B33744.154543431421011 (code B ref 33744); Fri, 21 Dec 2018 23:19:02 +0000 Received: (at 33744) by debbugs.gnu.org; 21 Dec 2018 23:18:34 +0000 Received: from localhost ([127.0.0.1]:58976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gaU3u-0005Sp-D9 for submit@debbugs.gnu.org; Fri, 21 Dec 2018 18:18:34 -0500 Received: from smtp87.ord1d.emailsrvr.com ([184.106.54.87]:39832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gaU3s-0005Sd-Su for 33744@debbugs.gnu.org; Fri, 21 Dec 2018 18:18:33 -0500 Received: from smtp3.relay.ord1d.emailsrvr.com (localhost [127.0.0.1]) by smtp3.relay.ord1d.emailsrvr.com (SMTP Server) with ESMTP id 9F4A36016D for <33744@debbugs.gnu.org>; Fri, 21 Dec 2018 18:18:27 -0500 (EST) X-Auth-ID: board-president@tomahawk-creek-hoa.com Received: by smtp3.relay.ord1d.emailsrvr.com (Authenticated sender: board-president-AT-tomahawk-creek-hoa.com) with ESMTPSA id 52569601FF for <33744@debbugs.gnu.org>; Fri, 21 Dec 2018 18:18:27 -0500 (EST) X-Sender-Id: board-president@tomahawk-creek-hoa.com Received: from Takver4 ([UNAVAILABLE]. [76.77.182.20]) (using TLSv1.2 with cipher AES256-GCM-SHA384) by 0.0.0.0:25 (trex/5.7.12); Fri, 21 Dec 2018 18:18:27 -0500 From: Stephen Leake User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (windows-nt) Date: Fri, 21 Dec 2018 15:18:24 -0800 Message-ID: <86a7ky4gfz.fsf@stephe-leake.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Ludovic writes: > The value of ada-indent-hanging-rel-exp has no effect in this > particular case. Actually, it does. With ada-indent = 2, ada-indent-hanging-rel-exp = nil, the indentation is: procedure Operator_Indentation is begin if B or else C > 2 -- indented relative to "or else" then null; end if; end Operator_Indentation; Changing an indentation parameter does not force a reparse, so calling 'indent-region' does not use the new parameter value. Use M-x wisi-parse-buffer to force a reparse and reindent. -- -- Stephe From unknown Sat Aug 16 13:48:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33744: effect of ada-indent-hanging-rel-exp Resent-From: Stephen Leake Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Dec 2018 17:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33744 X-GNU-PR-Package: emacs, ada-mode X-GNU-PR-Keywords: To: 33744@debbugs.gnu.org Cc: Ludovic Brenta Received: via spool by 33744-submit@debbugs.gnu.org id=B33744.154558680225829 (code B ref 33744); Sun, 23 Dec 2018 17:41:02 +0000 Received: (at 33744) by debbugs.gnu.org; 23 Dec 2018 17:40:02 +0000 Received: from localhost ([127.0.0.1]:33997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gb7jO-0006iX-9W for submit@debbugs.gnu.org; Sun, 23 Dec 2018 12:40:02 -0500 Received: from smtp71.ord1d.emailsrvr.com ([184.106.54.71]:50333) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gb7jM-0006hy-7l for 33744@debbugs.gnu.org; Sun, 23 Dec 2018 12:40:01 -0500 Received: from smtp17.relay.ord1d.emailsrvr.com (localhost [127.0.0.1]) by smtp17.relay.ord1d.emailsrvr.com (SMTP Server) with ESMTP id AEE3F20142; Sun, 23 Dec 2018 12:39:54 -0500 (EST) X-Auth-ID: board-president@tomahawk-creek-hoa.com Received: by smtp17.relay.ord1d.emailsrvr.com (Authenticated sender: board-president-AT-tomahawk-creek-hoa.com) with ESMTPSA id 4C5E5200BE; Sun, 23 Dec 2018 12:39:54 -0500 (EST) X-Sender-Id: board-president@tomahawk-creek-hoa.com Received: from Takver4 ([UNAVAILABLE]. [76.77.182.20]) (using TLSv1.2 with cipher AES256-GCM-SHA384) by 0.0.0.0:25 (trex/5.7.12); Sun, 23 Dec 2018 12:39:54 -0500 From: Stephen Leake References: <86bm5e4gmo.fsf@stephe-leake.org> Date: Sun, 23 Dec 2018 09:39:53 -0800 In-Reply-To: <86bm5e4gmo.fsf@stephe-leake.org> (Stephen Leake's message of "Fri, 21 Dec 2018 15:14:23 -0800") Message-ID: <86woo02lcm.fsf@stephe-leake.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Is the fact that the first token on a line is an operator significant? In other words, would this indentation be correct: procedure Operator_Indentation is begin if B or else C > 2 then null; end if; end Operator_Indentation; -- -- Stephe From unknown Sat Aug 16 13:48:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33744: 26.1; ada-mode 6.0.0 indentation of operators starting a line in a multi-line expression References: In-Reply-To: Resent-From: Ludovic Brenta Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Jan 2019 11:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33744 X-GNU-PR-Package: emacs, ada-mode X-GNU-PR-Keywords: To: 33744@debbugs.gnu.org Received: via spool by 33744-submit@debbugs.gnu.org id=B33744.154694807521814 (code B ref 33744); Tue, 08 Jan 2019 11:48:02 +0000 Received: (at 33744) by debbugs.gnu.org; 8 Jan 2019 11:47:55 +0000 Received: from localhost ([127.0.0.1]:49295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggprO-0005fm-Lm for submit@debbugs.gnu.org; Tue, 08 Jan 2019 06:47:54 -0500 Received: from webmail.bookmyname.com ([88.191.249.153]:62819 helo=webmail.free.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggprL-0005fa-OM for 33744@debbugs.gnu.org; Tue, 08 Jan 2019 06:47:52 -0500 Received: from 153.98.68.208 (unknown [127.0.1.3]) by webmail.free.org (Postfix) with ESMTP id B2F492A2AC for <33744@debbugs.gnu.org>; Tue, 8 Jan 2019 12:47:49 +0100 (CET) Received: from [153.98.68.208] by webmail.ludovic-brenta.org with HTTP (HTTP/1.1 POST); Tue, 08 Jan 2019 12:47:49 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 08 Jan 2019 12:47:49 +0100 From: Ludovic Brenta Message-ID: <92144fefb6ac61d7f162661b767acd2b@ludovic-brenta.org> X-Sender: ludovic@ludovic-brenta.org X-Complaints-To: abuse_at_bookmyname.com X-Abuse-Info: Please be sure to forward a copy of ALL headers X-Origin-Web-Site: webmail.ludovic-brenta.org X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Our coding standard forbids operators at end of line, so in our case we would always place the operator at the beginning of the next line. Were it not for that coding standard, I think your example would be correct. But this does not solve our problem :) -- Ludovic Brenta.