GNU bug report logs - #33743
26.1; ada-mode 6.0.0 indentation of comments before "then"

Previous Next

Packages: ada-mode, emacs;

Reported by: Ludovic Brenta <ludovic <at> ludovic-brenta.org>

Date: Fri, 14 Dec 2018 15:40:02 UTC

Severity: minor

Found in version 26.1

Done: Stephen Leake <stephen_leake <at> stephe-leake.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stephen Leake <stephen_leake <at> stephe-leake.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#33743: closed (26.1; ada-mode 6.0.0 indentation of comments
 before "then")
Date: Mon, 25 Mar 2019 16:42:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Mon, 25 Mar 2019 08:40:58 -0800
with message-id <86lg12ewkl.fsf <at> stephe-leake.org>
and subject line update
has caused the debbugs.gnu.org bug report #33743,
regarding 26.1; ada-mode 6.0.0 indentation of comments before "then"
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
33743: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33743
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Ludovic Brenta <ludovic <at> ludovic-brenta.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.1; ada-mode 6.0.0 indentation of comments before "then"
Date: Fri, 14 Dec 2018 16:39:09 +0100
Package: emacs, ada-mode
X-Debbugs-CC: ada-mode-users <at> nongnu.org

Hello,

With ada-mode 6.0.0, comments appearing on a line of their on before 
"then"
are indented like "then"; we think they should be indented one more 
level:

procedure Comment_Indentation is
begin
  if A
    -- This comment is indented correctly
    and then B
  -- This comment is indented incorrectly, should be as above
  then
    -- This comment is indented correctly
    null;
  elsif C
    -- This comment is indented correctly
    and then D
  -- This comment is indented incorrectly, should be as above
  then
    null;
  end if;
end Comment_Indentation;

This "incorrect" indentation is a change from ada-mode 5.2.1 which can
affect many lines in our large code base.  In 5.2.1, all comments are
indented in the same way.

I have browsed the ada-mode customization variables but did not see
which one, if any, allows us to customize this behavior.  (note: we
set ada-indent to 2).

--
Ludovic Brenta.


[Message part 3 (message/rfc822, inline)]
From: Stephen Leake <stephen_leake <at> stephe-leake.org>
To: 33743-close <at> debbugs.gnu.org
Subject: update
Date: Mon, 25 Mar 2019 08:40:58 -0800
-- 
-- Stephe


This bug report was last modified 6 years and 61 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.