From unknown Sun Jun 22 00:54:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33743: 26.1; ada-mode 6.0.0 indentation of comments before "then" Resent-From: Ludovic Brenta Original-Sender: "Debbugs-submit" Resent-CC: ada-mode-users@nongnu.org, bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Dec 2018 15:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33743 X-GNU-PR-Package: emacs, ada-mode X-GNU-PR-Keywords: To: 33743@debbugs.gnu.org Cc: ada-mode-users@nongnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: ada-mode-users@nongnu.org Received: via spool by submit@debbugs.gnu.org id=B.15448019687589 (code B ref -1); Fri, 14 Dec 2018 15:40:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Dec 2018 15:39:28 +0000 Received: from localhost ([127.0.0.1]:48450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXpYm-0001yL-BS for submit@debbugs.gnu.org; Fri, 14 Dec 2018 10:39:28 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48173) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXpYk-0001y8-Hu for submit@debbugs.gnu.org; Fri, 14 Dec 2018 10:39:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXpYd-0000Tq-UN for submit@debbugs.gnu.org; Fri, 14 Dec 2018 10:39:21 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42288) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gXpYc-0000Rp-F2 for submit@debbugs.gnu.org; Fri, 14 Dec 2018 10:39:19 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXpYb-00072J-JD for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 10:39:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXpYX-0000Pm-Vy for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 10:39:17 -0500 Received: from webmail.bookmyname.com ([88.191.249.153]:20931 helo=webmail.free.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gXpYW-0000OL-CG for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 10:39:13 -0500 Received: from 153.98.68.208 (unknown [127.0.1.3]) by webmail.free.org (Postfix) with ESMTP id 5F0FB258F8; Fri, 14 Dec 2018 16:39:09 +0100 (CET) Received: from [153.98.68.208] by webmail.ludovic-brenta.org with HTTP (HTTP/1.1 POST); Fri, 14 Dec 2018 16:39:09 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 14 Dec 2018 16:39:09 +0100 From: Ludovic Brenta Message-ID: X-Sender: ludovic@ludovic-brenta.org X-Complaints-To: abuse_at_bookmyname.com X-Abuse-Info: Please be sure to forward a copy of ALL headers X-Origin-Web-Site: webmail.ludovic-brenta.org X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) Package: emacs, ada-mode X-Debbugs-CC: ada-mode-users@nongnu.org Hello, With ada-mode 6.0.0, comments appearing on a line of their on before "then" are indented like "then"; we think they should be indented one more level: procedure Comment_Indentation is begin if A -- This comment is indented correctly and then B -- This comment is indented incorrectly, should be as above then -- This comment is indented correctly null; elsif C -- This comment is indented correctly and then D -- This comment is indented incorrectly, should be as above then null; end if; end Comment_Indentation; This "incorrect" indentation is a change from ada-mode 5.2.1 which can affect many lines in our large code base. In 5.2.1, all comments are indented in the same way. I have browsed the ada-mode customization variables but did not see which one, if any, allows us to customize this behavior. (note: we set ada-indent to 2). -- Ludovic Brenta. From unknown Sun Jun 22 00:54:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33743: update References: In-Reply-To: Resent-From: Stephen Leake Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Mar 2019 16:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33743 X-GNU-PR-Package: emacs, ada-mode X-GNU-PR-Keywords: To: 33743@debbugs.gnu.org Received: via spool by 33743-submit@debbugs.gnu.org id=B33743.155353205213622 (code B ref 33743); Mon, 25 Mar 2019 16:41:02 +0000 Received: (at 33743) by debbugs.gnu.org; 25 Mar 2019 16:40:52 +0000 Received: from localhost ([127.0.0.1]:58570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8Sea-0003Xd-26 for submit@debbugs.gnu.org; Mon, 25 Mar 2019 12:40:52 -0400 Received: from gproxy8-pub.mail.unifiedlayer.com ([67.222.33.93]:33270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8SeV-0003XK-Pw for 33743@debbugs.gnu.org; Mon, 25 Mar 2019 12:40:50 -0400 Received: from cmgw12.unifiedlayer.com (unknown [10.9.0.12]) by gproxy8.mail.unifiedlayer.com (Postfix) with ESMTP id 35A561AB092 for <33743@debbugs.gnu.org>; Mon, 25 Mar 2019 10:40:41 -0600 (MDT) Received: from host114.hostmonster.com ([74.220.207.114]) by cmsmtp with ESMTP id 8SePhfEnymds98SePhO6J5; Mon, 25 Mar 2019 10:40:41 -0600 X-Authority-Reason: nr=8 Received: from [76.77.182.20] (port=56954 helo=Takver4) by host114.hostmonster.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h8SeO-000MQB-UA for 33743@debbugs.gnu.org; Mon, 25 Mar 2019 10:40:41 -0600 From: Stephen Leake Date: Mon, 25 Mar 2019 08:40:37 -0800 Message-ID: <86pnqeewl6.fsf@stephe-leake.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host114.hostmonster.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 76.77.182.20 X-Source-L: No X-Exim-ID: 1h8SeO-000MQB-UA X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (Takver4) [76.77.182.20]:56954 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 1 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDExNC5ob3N0bW9uc3Rlci5jb20= X-Local-Domain: yes X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Fixed in ada-mode 6.1.0 in GNU ELPA. -- -- Stephe From unknown Sun Jun 22 00:54:13 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ludovic Brenta Subject: bug#33743: closed (update) Message-ID: References: <86lg12ewkl.fsf@stephe-leake.org> X-Gnu-PR-Message: they-closed 33743 X-Gnu-PR-Package: emacs, ada-mode Reply-To: 33743@debbugs.gnu.org Date: Mon, 25 Mar 2019 16:42:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1553532122-13757-1" This is a multi-part message in MIME format... ------------=_1553532122-13757-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #33743: 26.1; ada-mode 6.0.0 indentation of comments before "then" which was filed against the emacs, ada-mode package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 33743@debbugs.gnu.org. --=20 33743: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D33743 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1553532122-13757-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 33743-close) by debbugs.gnu.org; 25 Mar 2019 16:41:08 +0000 Received: from localhost ([127.0.0.1]:58574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8Seq-0003Yh-DB for submit@debbugs.gnu.org; Mon, 25 Mar 2019 12:41:08 -0400 Received: from gproxy8-pub.mail.unifiedlayer.com ([67.222.33.93]:44700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h8Seo-0003Y7-WA for 33743-close@debbugs.gnu.org; Mon, 25 Mar 2019 12:41:07 -0400 Received: from CMGW (unknown [10.9.0.13]) by gproxy8.mail.unifiedlayer.com (Postfix) with ESMTP id B1CDC1AB14D for <33743-close@debbugs.gnu.org>; Mon, 25 Mar 2019 10:41:01 -0600 (MDT) Received: from host114.hostmonster.com ([74.220.207.114]) by cmsmtp with ESMTP id 8SejhkPpyeyBx8SejhFlG7; Mon, 25 Mar 2019 10:41:01 -0600 X-Authority-Reason: nr=8 Received: from [76.77.182.20] (port=56955 helo=Takver4) by host114.hostmonster.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h8Sej-000Mh7-FR for 33743-close@debbugs.gnu.org; Mon, 25 Mar 2019 10:41:01 -0600 From: Stephen Leake To: 33743-close@debbugs.gnu.org Subject: update Date: Mon, 25 Mar 2019 08:40:58 -0800 Message-ID: <86lg12ewkl.fsf@stephe-leake.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host114.hostmonster.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 76.77.182.20 X-Source-L: No X-Exim-ID: 1h8Sej-000Mh7-FR X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (Takver4) [76.77.182.20]:56955 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 2 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDExNC5ob3N0bW9uc3Rlci5jb20= X-Local-Domain: yes X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33743-close X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) -- -- Stephe ------------=_1553532122-13757-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Dec 2018 15:39:28 +0000 Received: from localhost ([127.0.0.1]:48450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXpYm-0001yL-BS for submit@debbugs.gnu.org; Fri, 14 Dec 2018 10:39:28 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48173) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXpYk-0001y8-Hu for submit@debbugs.gnu.org; Fri, 14 Dec 2018 10:39:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXpYd-0000Tq-UN for submit@debbugs.gnu.org; Fri, 14 Dec 2018 10:39:21 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42288) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gXpYc-0000Rp-F2 for submit@debbugs.gnu.org; Fri, 14 Dec 2018 10:39:19 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXpYb-00072J-JD for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 10:39:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXpYX-0000Pm-Vy for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 10:39:17 -0500 Received: from webmail.bookmyname.com ([88.191.249.153]:20931 helo=webmail.free.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gXpYW-0000OL-CG for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 10:39:13 -0500 Received: from 153.98.68.208 (unknown [127.0.1.3]) by webmail.free.org (Postfix) with ESMTP id 5F0FB258F8; Fri, 14 Dec 2018 16:39:09 +0100 (CET) Received: from [153.98.68.208] by webmail.ludovic-brenta.org with HTTP (HTTP/1.1 POST); Fri, 14 Dec 2018 16:39:09 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 14 Dec 2018 16:39:09 +0100 From: Ludovic Brenta To: bug-gnu-emacs@gnu.org Subject: 26.1; ada-mode 6.0.0 indentation of comments before "then" Message-ID: X-Sender: ludovic@ludovic-brenta.org X-Complaints-To: abuse_at_bookmyname.com X-Abuse-Info: Please be sure to forward a copy of ALL headers X-Origin-Web-Site: webmail.ludovic-brenta.org X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) Package: emacs, ada-mode X-Debbugs-CC: ada-mode-users@nongnu.org Hello, With ada-mode 6.0.0, comments appearing on a line of their on before "then" are indented like "then"; we think they should be indented one more level: procedure Comment_Indentation is begin if A -- This comment is indented correctly and then B -- This comment is indented incorrectly, should be as above then -- This comment is indented correctly null; elsif C -- This comment is indented correctly and then D -- This comment is indented incorrectly, should be as above then null; end if; end Comment_Indentation; This "incorrect" indentation is a change from ada-mode 5.2.1 which can affect many lines in our large code base. In 5.2.1, all comments are indented in the same way. I have browsed the ada-mode customization variables but did not see which one, if any, allows us to customize this behavior. (note: we set ada-indent to 2). -- Ludovic Brenta. ------------=_1553532122-13757-1--