From unknown Fri Jun 20 20:07:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33741: Packages built with Go 1.10+ keep unnecessary references to Go inputs Resent-From: Pierre Neidhardt Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 14 Dec 2018 15:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33741 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 33741@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15448013056516 (code B ref -1); Fri, 14 Dec 2018 15:29:01 +0000 Received: (at submit) by debbugs.gnu.org; 14 Dec 2018 15:28:25 +0000 Received: from localhost ([127.0.0.1]:48439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXpO4-0001h2-W4 for submit@debbugs.gnu.org; Fri, 14 Dec 2018 10:28:25 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXpO3-0001go-9J for submit@debbugs.gnu.org; Fri, 14 Dec 2018 10:28:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXpNw-0001kc-C5 for submit@debbugs.gnu.org; Fri, 14 Dec 2018 10:28:17 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43871) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gXpNv-0001kW-T2 for submit@debbugs.gnu.org; Fri, 14 Dec 2018 10:28:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXpNu-0002My-8o for bug-guix@gnu.org; Fri, 14 Dec 2018 10:28:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXpNq-0001cx-A8 for bug-guix@gnu.org; Fri, 14 Dec 2018 10:28:14 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:51861) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gXpNp-0001ba-GF for bug-guix@gnu.org; Fri, 14 Dec 2018 10:28:09 -0500 X-Originating-IP: 86.246.35.59 Received: from mimimi (lfbn-1-799-59.w86-246.abo.wanadoo.fr [86.246.35.59]) (Authenticated sender: mail@ambrevar.xyz) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id A783260004 for ; Fri, 14 Dec 2018 15:28:07 +0000 (UTC) User-agent: mu4e 1.0; emacs 26.1 From: Pierre Neidhardt Date: Fri, 14 Dec 2018 16:28:07 +0100 Message-ID: <877egcdt6g.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) --=-=-= Content-Type: text/plain See https://lists.gnu.org/archive/html/guix-devel/2018-11/msg00223.html. Go binaries are statically build, but since Go 1.10, the full paths to the Go libraries are kept in the binaries, which results in the Go dependencies being part of the package closure: $ guix gc --references $(./pre-inst-env guix build --no-grafts kurly) /gnu/store/2b2md66fbzyspsmd5dj6zkj9hilac40r-tzdata-2018e /gnu/store/4iwksvq53rlzphfp3xvp63ihlw226c0n-go-github-com-aki237-nscjar-0.0.0-0.e2df936 /gnu/store/5rxdjbk8h0bh1hbaan8y8ib13va2bcmw-net-base-5.3 /gnu/store/ahvdlp6y44qj6kx63rmx1sq8r61x3zc2-go-github-com-alsm-ioprogress-0.0.0-0.063c372 /gnu/store/f8yps0l8p371jgzh6cki0z5n2kgfjiwy-go-github-com-urfave-cli-1.19.1-0.934abfb /gnu/store/l4lr0f5cjd0nbsaaf8b5dmcw1a1yypr3-glibc-2.27 /gnu/store/pp0bakrbyv9xmp1kyv2114l19s11b74z-gcc-6.4.0-lib Previously, they did not: $ guix gc --references $(guix build --no-grafts kurly) /gnu/store/2b2md66fbzyspsmd5dj6zkj9hilac40r-tzdata-2018e /gnu/store/5rxdjbk8h0bh1hbaan8y8ib13va2bcmw-net-base-5.3 /gnu/store/l4lr0f5cjd0nbsaaf8b5dmcw1a1yypr3-glibc-2.27 /gnu/store/pp0bakrbyv9xmp1kyv2114l19s11b74z-gcc-6.4.0-lib It seems to be an upstream bug: https://github.com/golang/go/issues/16860 It's still unresolved and only planned for Go 1.13. Note that adding "-asmflags=all=-trimpath=/gnu/store" "-gcflags=all=-trimpath=/gnu/store" to the build system does not work, because we need to trim the hash too. -trimpath supports only one parameter, so we can't use it for this purpose. We could use Boyer-Moore to replace the hashes of all Go dependencies. We must be careful to only replace paths to Go libraries. -- Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlwTzAcACgkQm9z0l6S7 zH/coAf/YvJSuI0oh+xHwPDXes3i2uw1hysc7tAesSk4mGdS6ImsWdLuUEm6V1or gZ1fNzikwEFzY86F/h6VR0nya/gv17UiyUInZmiVkOrrM1b8tQA7x00YFqjKqr0U jKtdgN7dXgyLYinK0XG4mnNi9UefWhyQgfeQHPs2NVczbIqsRkB7ECQU9CuSfoeM qNUkhHVij4y5FX0nuYw5ftrvZTvoIBU+FZ7UuCR3yonNC4q7wEVbKvQiNWFEwdu/ 4z2DINUnbBqOL84VjnRa95NobYpCuhse1XyQQBZDVjqUGDwbyDD8BIk15lDHvSa1 YTzzYNjC3spRhE8FdymB0qIc+SE0gg== =/d4s -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 16 16:26:34 2018 Received: (at control) by debbugs.gnu.org; 16 Dec 2018 21:26:34 +0000 Received: from localhost ([127.0.0.1]:50647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYdvl-0000RE-VW for submit@debbugs.gnu.org; Sun, 16 Dec 2018 16:26:34 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:41615) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYdvk-0000Qx-3r for control@debbugs.gnu.org; Sun, 16 Dec 2018 16:26:32 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 88FE921D2A; Sun, 16 Dec 2018 16:26:26 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 16 Dec 2018 16:26:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:message-id:mime-version:content-type; s=mesmtp; bh=dc0HfUC97lCqRwPi/PFsyU8u/7qCTSyHFvRGmH+Ulb8=; b=D33eW0d0hfb3 c3iHZW1aF54ZxTQCxzYrYMX+TbxRyysvoU3RKQ7mHkstaKYK78Ap4HnCPxWbmIJh F5kxw603DtjWXij+YlE4Qy3tMW3ww6sCoH1RSq0hi/+FS5E7fBL0Z8xr9QISl1s/ TizsZ53tL80jNjed0mt56wGHd35y8xc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=dc0HfUC97lCqRwPi/PFsyU8u/7qCTSyHFvRGmH+Ul b8=; b=vf/CLg33ihKlMzhJjAMhZSm+tymWE5ANBmMcDfXYJiPdoVpZmCPydwDpw 5jpCjRWtdoaTQ+2Dl0RJvQvv8rpTz/lCJ9ixjvhb3ZBhZhpI87NBmS/rNEzJ3vOK 58Ot4cAif0HfyCqKFn500aViWGjqOxC+AkOfffLtBVOWpSJ6nk/R1IWKW4Tw+O4Z NFPM4lj+xkyL2J7SyDISkVAAlyDdXdAFRp+4x1ab+tiH9GJXllAdlUGD3CQCyGxW K4vsSsg6oWKSrD5XoRAlDjyuqdiHtakku/oK6+TV5lHdo9HtPTdP+/weO0f9jQ4p 8+VzuClMI5bldGHwnL2D7cCCNoJ2A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudehledgudehtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecu fedttdenucfgmhhpthihuchsuhgsjhgvtghtucdluddtmdenucfjughrpeffhffvkfggtg gufgesghdtreertdervdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohes fhgrmhhulhgrrhhirdhnrghmvgeqnecukfhppeejuddruddthedrvddttddrjedvnecurf grrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgvnecuvehl uhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (pool-71-105-200-72.nycmny.fios.verizon.net [71.105.200.72]) by mail.messagingengine.com (Postfix) with ESMTPA id C25BAE462B for ; Sun, 16 Dec 2018 16:26:23 -0500 (EST) Date: Sun, 16 Dec 2018 16:26:23 -0500 From: Leo Famulari To: control@debbugs.gnu.org Message-ID: <20181216212623.GA32482@jasmine.lan> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SUOF0GtieIMvvwua" Content-Disposition: inline User-Agent: Mutt/1.11.0 (2018-11-25) X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: merge 33741 33620 Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [66.111.4.25 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) --SUOF0GtieIMvvwua Content-Type: text/plain; charset=us-ascii Content-Disposition: inline merge 33741 33620 --SUOF0GtieIMvvwua Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlwWwv8ACgkQJkb6MLrK fwhztg//fsLVRKJJ1OHzOA9i0aMZJII8pm7Xy1ZWrzmhxUpDq083xjkHEltEIYj+ grdNKEwjfbyVGiH+4fomRMdqZSCXJJrmdVL1bvUEJYNmURD9vRi2g4ofn/gQ0svV EBwpH96FZs2clVgZ9XRbNJcI9RuUmcMOolNIde9n+CmrdKlKD5BK9YoW0EocqXY2 DHOjfUlYtKXMFDXzzFH5tQ54A7n/ytK1zfRrNTccxdb4WjPLcJKB4jzvCf9Y85sp T6/qBi9PcoG7PiLwqmEeqSnlxy8dCoeepU0gIACdCgLbtjOjMGn4SkcdCrMrxuek ZTBrPAM88ymIoMfntOG7JXwqCQySaP/bm56DFOs8ThtIlGZkKFBOaGX2fgNQSoGO 2ZIM+lDd5J1OFHBDnKmOEAchdHGAIVdPgBlOWYgxlfb5CiZCQzpV7V059wnvI2Ah vDI/UXt3hnAZAsd0MICtA4jNYt6avSAdxeM1ZUkcCp2QR+LcP1Fb55tF+GhN4tmf bvyc9YxRjSnlSetGQjfTSJBSMMQKhnUKUvTTsR0ukPSZKaUKJSq4g90OxdyuCfuq 0iAZKjMj8liEmt4aScH6Di94nuHv1/UKgIWVQ5mD8ez4TrbboUbyukTFLI8kc7N1 a5HiAzeuCqhgJwxLuM3bNq2bW01SxCuDT2HzYsStP+yw9jy7Dlo= =KMK0 -----END PGP SIGNATURE----- --SUOF0GtieIMvvwua--