From unknown Thu Jun 19 14:23:03 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#33740 <33740@debbugs.gnu.org> To: bug#33740 <33740@debbugs.gnu.org> Subject: Status: [PATCH] Customizable flymake mode-line indicator Reply-To: bug#33740 <33740@debbugs.gnu.org> Date: Thu, 19 Jun 2025 21:23:03 +0000 retitle 33740 [PATCH] Customizable flymake mode-line indicator reassign 33740 emacs submitter 33740 Andrii Kolomoiets severity 33740 wishlist tag 33740 fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 14 04:20:08 2018 Received: (at submit) by debbugs.gnu.org; 14 Dec 2018 09:20:08 +0000 Received: from localhost ([127.0.0.1]:47306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXjdg-0006n3-ER for submit@debbugs.gnu.org; Fri, 14 Dec 2018 04:20:08 -0500 Received: from eggs.gnu.org ([208.118.235.92]:55066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXjde-0006mP-C8 for submit@debbugs.gnu.org; Fri, 14 Dec 2018 04:20:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXjdX-0006TX-L6 for submit@debbugs.gnu.org; Fri, 14 Dec 2018 04:20:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53888) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gXjdX-0006TB-GX for submit@debbugs.gnu.org; Fri, 14 Dec 2018 04:19:59 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXjdW-0002cT-3E for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 04:19:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXjdR-0006NZ-2N for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 04:19:57 -0500 Received: from mail-lf1-x143.google.com ([2a00:1450:4864:20::143]:41044) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gXjdQ-00069I-J4 for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 04:19:52 -0500 Received: by mail-lf1-x143.google.com with SMTP id c16so3713190lfj.8 for ; Fri, 14 Dec 2018 01:19:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:content-transfer-encoding:mime-version:subject:message-id:date :to; bh=WfEcAxlfv76KZ0w4j/4NRQdj5q2b+UwvkHS6jntAy8c=; b=lE1yx5ZaX2S4oxxiY/dWKUVuoKn0YpK65e7ZBeZIEQJy1elFPonCU2vskcbpVA4ReQ z6DXdKjLKR03objPtjl37L0BeunWMtIdCjBj7cGp4JKqzJrqjr5B6C4OnMPGaEUKv4RF 8HcUayNj/M0ry5zqV7ehsLGXYxNWZ0Rfq61vDqtXdxNQFqasupDIM9jDdN+U7gJAQ71y BFy/3xO2jCK369Kg7Y73roKXRIsNtK9euDFG4hAYFB88/rbUrdYnrGgfWzzq3Z9LI75Q AtNttsFZ2R7mhaDVt+pXJ/FHvo02laiBLgEujWhxYl5c2RtxgJxBUMuqCk/U2Eff8FUu mScA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:to; bh=WfEcAxlfv76KZ0w4j/4NRQdj5q2b+UwvkHS6jntAy8c=; b=d9SRop83mRhVvbsUj/56fbUBdAJVFmcOHzGxccjqi6saD7TECM0QocVVJYfuUVOCfV cn9ql1THE6ub6N3v0RS1h39WoVHd3XZ+Ygyd8kErLaUh7oZ1HOrxVW9sNEaN0jf8+d9N IbcATYBf6K8kLtHtFgVOfbi6JELO3wZ4fRzjow8N9XYfmbFbr5lFQ5kBlFg8OFN0MOSk meKQytzaRuFnPG0ipHkhKoRX4ozTWorMxA/kZqGZmZDAQPjrezSHqM6CyrQ3Q2jn3pFt yFm4L4txffD8kZoDTRT10mDeLD2k/Q4EARbBjtjby2XJrP/X1iWKg6/Tp75OOYdHT8zg se9Q== X-Gm-Message-State: AA+aEWZ2+cO6tJKyxjvYwcMVzqc+JqVOTLCzvXTOgnXyywgUnYPfNhgt 7Q/eNxh6Oicc2LHwi1y0Nfz6ufQZ X-Google-Smtp-Source: AFSGD/VelTG9EKpEpsVYG6/6bM65pz8wDN2OTzYL0NzHnHi2Dwo3ZRda4xetLsPwSAY2NEHNcmb70g== X-Received: by 2002:a19:5402:: with SMTP id i2mr1266127lfb.128.1544779174009; Fri, 14 Dec 2018 01:19:34 -0800 (PST) Received: from [10.1.1.118] (188-42-207-82.ip.ukrtel.net. [82.207.42.188]) by smtp.gmail.com with ESMTPSA id z9sm796681lfj.79.2018.12.14.01.19.32 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Dec 2018 01:19:33 -0800 (PST) From: Andrii Kolomoiets Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: [PATCH] Customizable flymake mode-line indicator Message-Id: Date: Fri, 14 Dec 2018 11:19:31 +0200 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3445.102.3) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi, I would like to hide Flymake label in mode line leaving just counters. Customizable mode line indicator like in this patch can solve my issue and can help to those wanting to keep their mode line cleaner. diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el index 7b100da..477abdd 100644 --- a/lisp/progmodes/flymake.el +++ b/lisp/progmodes/flymake.el @@ -220,6 +220,10 @@ Specifically, start it when the saved buffer is = actually displayed." :version "26.1" :type 'boolean) +(defcustom flymake-mode-line-indicator "Flymake" + "Mode label in mode-line." + :type 'string) + (when (fboundp 'define-fringe-bitmap) (define-fringe-bitmap 'flymake-double-exclamation-mark (vector #b00000000 @@ -1152,7 +1156,7 @@ default) no filter is applied." diags-by-type))) (flymake--backend-state-diags state))) flymake--backend-state) - `((:propertize " Flymake" + `((:propertize ,(format " %s" flymake-mode-line-indicator) mouse-face mode-line-highlight help-echo ,(concat (format "%s known backends\n" (length = known))= From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 04 15:28:09 2019 Received: (at 33740) by debbugs.gnu.org; 4 Jan 2019 20:28:09 +0000 Received: from localhost ([127.0.0.1]:47066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfW4f-00025X-1X for submit@debbugs.gnu.org; Fri, 04 Jan 2019 15:28:09 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:37453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfW4c-000253-0S for 33740@debbugs.gnu.org; Fri, 04 Jan 2019 15:28:06 -0500 Received: by mail-wm1-f66.google.com with SMTP id g67so2309232wmd.2 for <33740@debbugs.gnu.org>; Fri, 04 Jan 2019 12:28:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=3shcwMFP15O2RMFg/a7btgEt+aONaOt+luIvHZ3jLEs=; b=N2mB4Mb775YYVyV1i1bf36q5+sAqeMOVz9e8yIJOJcRKBJntGhekdwyIUThRSOpQOi XAGbbYlBS4iJWjkdxuZlEyTU5FUDYXqynR5kfTQbXIl56Su2YkTFvM+CybTnxPjFYVUC BEcuascXHPhqn0btmQtwj550mpN6cP+xZwLT8cKb/KNG5P9b8E1+dMnZ/AgIcwSnwHnO hZFJxxJqOc08z8AuzWglTeR3W3n5qCXuCsIZIwoDPfAj5mcyhsbxy4s7bq6e41Q9z6+z 4z+xuZvjUwFCfKUk0NUb6pGxsJeJTLqDvGJVMyeRjJcWd2nLk0aPe1VBVlXdCmKAM505 iJ+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=3shcwMFP15O2RMFg/a7btgEt+aONaOt+luIvHZ3jLEs=; b=OU1aNDe+Kwz6KFWOxVTzyGu7MSO3fDlv8prux69MEDT0Sbo4GIn/AmCg7F/1OmElNv f8OHzw6W9A32agSk/I+WlozNOEJnmWLRHTv9NU/ezokOG+kFezXGuTwTxDYA07+dGF04 U7FkBWd8HU+NLJT7hQWTbNaJuvyY55wgNrHMTolvzn/5oVEeIKyfdT1isJQXijOoRU57 2c5dvUsafuciRLSPbqn0f3X0f+C78aHriOP0dkJK9LosJqDavfCH0PAB5+zDXgxccrln cXUbw2Vu6nC5QUBJIVivKmuZ6tcjNOqcXF3ULC3G1RUvDw0A8C6kwn8wJU5sZIaV/0e/ VTZw== X-Gm-Message-State: AJcUukc4omTeQX5Rp7oMPChYYpofsEMgiaYwchNyH0dhTZ60KusnbZbw 0BqTArNp70vv41LdgaatpyHgR3OpF2c= X-Google-Smtp-Source: ALg8bN7U73RFE1Ar2Q9sXizTna0y6YV2UwnNHRCbw6o9qptf+fh03DDIK238y+80pRK9SqVVGMzO+w== X-Received: by 2002:a1c:9806:: with SMTP id a6mr2318907wme.114.1546633679988; Fri, 04 Jan 2019 12:27:59 -0800 (PST) Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id r69sm2729561wmd.4.2019.01.04.12.27.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 04 Jan 2019 12:27:59 -0800 (PST) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Andrii Kolomoiets Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: Date: Fri, 04 Jan 2019 20:27:57 +0000 In-Reply-To: (Andrii Kolomoiets's message of "Fri, 14 Dec 2018 11:19:31 +0200") Message-ID: <87bm4wjhgy.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) Andrii Kolomoiets writes: > Hi, > > I would like to hide Flymake label in mode line leaving just counters. > > Customizable mode line indicator like in this patch can solve my issue > and can help to those wanting to keep their mode line cleaner. > > > diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el > index 7b100da..477abdd 100644 > --- a/lisp/progmodes/flymake.el > +++ b/lisp/progmodes/flymake.el > @@ -220,6 +220,10 @@ Specifically, start it when the saved buffer is actu= ally displayed." > :version "26.1" > :type 'boolean) > > +(defcustom flymake-mode-line-indicator "Flymake" > + "Mode label in mode-line." > + :type 'string) > + > (when (fboundp 'define-fringe-bitmap) > (define-fringe-bitmap 'flymake-double-exclamation-mark > (vector #b00000000 > @@ -1152,7 +1156,7 @@ default) no filter is applied." > diags-by-type))) > (flymake--backend-state-diags state))) > flymake--backend-state) > - `((:propertize " Flymake" > + `((:propertize ,(format " %s" flymake-mode-line-indicator) > mouse-face mode-line-highlight > help-echo > ,(concat (format "%s known backends\n" (length known)) Looks good, though I would prefer if the defcustom was a format-string where %s would be substituted by the error counts. That way you could even get rid of the braces or use something else. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 10:16:00 2019 Received: (at 33740) by debbugs.gnu.org; 22 Jun 2019 14:16:00 +0000 Received: from localhost ([127.0.0.1]:52351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hegoC-0008RL-H6 for submit@debbugs.gnu.org; Sat, 22 Jun 2019 10:16:00 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:39366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hego9-0008R6-MK for 33740@debbugs.gnu.org; Sat, 22 Jun 2019 10:15:58 -0400 Received: by mail-wm1-f51.google.com with SMTP id z23so9173611wma.4 for <33740@debbugs.gnu.org>; Sat, 22 Jun 2019 07:15:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=tUfYvTXSPd/5/ot1CUzN0XQNEgxp0ySoeIJ0ypmq47c=; b=JzHxR94JQjDFWR3JkYXPMvhp8J09vUbPnJbVT1HlT7qsubEp/FWrcqDtqQojtHQByG u2MdJMFsqe/2mDK4fC8HUpGa+Svn2+kuQ6dSNOpE7Qq3LRUxUcp0Oh2ZeURVozk7cylE ITXTWNt7YOK/N5yNObOUQvI6L+NIjb4VI3IUhw7aQ4sGYAoOUHUZJ5WBW0jkeALfHWFp XJ+CQW0HIEZSzePWu5ZyOo3q5xArCEOovCqeAktayZXJV1gggzUHPtb5lnjlUYxwkNwn CKB+xL3uksH8BEAXi4/rrmkjNOKpVDX1DqAaafBLuwf8/7P+OQwxOhalW8RqFSuYw98a Q/PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=tUfYvTXSPd/5/ot1CUzN0XQNEgxp0ySoeIJ0ypmq47c=; b=NTR7NQ4qYikeADCQaH9WWgJ/Xk85OvZrF2Vl8iVE3gBpnNmDXa9BjLwKuHivnFLS1v XZOBoBZV/JSGVMi9lddHgVnpZpWT8t6A9mAiC1Khp3n/LFMzL2nlnZMymVmU8lmF388K KM1leQcB+kGL/2z7f6sNM5vPxmnZqQDFcL/y0ZKQwKwlAYpk7ghLoNF2N/xVCeINHWwX MuteJ+9SKReYhQt4bgDgIWguj0qyfttSJDJJGNBUmVEo+wISXU20PnvCz3I2XCMu8AR2 z0UplaLHjlwEU9snMJWXiwWXGfllQNl06GjyMPqfEgk7Ibr7HLk6q0Xg4afwZZ8JR6TW 6vbg== X-Gm-Message-State: APjAAAVZHJjQrAVKTw817Q/AJnngB5SAfE8svdO/KhFBsJCHIyiE00zD tQ5+UTxYnDjGoTSozWZiJjU= X-Google-Smtp-Source: APXvYqzoKXYYB/TAxY571C9fka9W5V4Gmh8L9Vq7d667Jj7e5hOIjAnCgnRsDK85EWUrmB+VHe7LYg== X-Received: by 2002:a1c:be0a:: with SMTP id o10mr8190652wmf.91.1561212951935; Sat, 22 Jun 2019 07:15:51 -0700 (PDT) Received: from localhost ([185.112.167.114]) by smtp.gmail.com with ESMTPSA id k125sm5518592wmf.41.2019.06.22.07.15.51 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 22 Jun 2019 07:15:51 -0700 (PDT) From: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator In-Reply-To: <87bm4wjhgy.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Fri, 04 Jan 2019 20:27:57 +0000") References: <87bm4wjhgy.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Date: Sat, 22 Jun 2019 16:15:50 +0200 Message-ID: <878sttiu3t.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Could we have a fix for this installed already, please? --=20 =C5=A0t=C4=9Bp=C3=A1n From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 16 18:22:16 2019 Received: (at 33740) by debbugs.gnu.org; 16 Sep 2019 22:22:16 +0000 Received: from localhost ([127.0.0.1]:51268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9zNv-0001Lc-LD for submit@debbugs.gnu.org; Mon, 16 Sep 2019 18:22:16 -0400 Received: from quimby.gnus.org ([80.91.231.51]:40812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9zNt-0001LT-As for 33740@debbugs.gnu.org; Mon, 16 Sep 2019 18:22:14 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i9zNp-0007Jy-5n; Tue, 17 Sep 2019 00:22:11 +0200 From: Lars Ingebrigtsen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> Date: Tue, 17 Sep 2019 00:22:08 +0200 In-Reply-To: <87bm4wjhgy.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Fri, 04 Jan 2019 20:27:57 +0000") Message-ID: <87h85bq3u7.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: João Távora writes: > Looks good, though I would prefer if the defcustom was a format-string > where %s would be substituted by the error counts. That way you could > even get rid of the braces or use something else. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > Looks good, though I would prefer if the defcustom was a format-string > where %s would be substituted by the error counts. That way you could > even get rid of the braces or use something else. Below is a proof-of-this-concept-not-working when done via the normal format-spec machinery. :-) I thought we could just put text properties on strings we feed to the mode-line machinery, but it seems like these don't survive? Do I remember vaguely there being a long-running bug report about that problem? I thought it had been fixed by now. Anybody remember? diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el index 6d47c8bb17..00c941ca5d 100644 --- a/lisp/progmodes/flymake.el +++ b/lisp/progmodes/flymake.el @@ -1166,6 +1166,15 @@ flymake--mode-line-format =20 (put 'flymake--mode-line-format 'risky-local-variable t) =20 +(defcustom flymake-mode-line-indicator-format " Flymake%s[%e %w %n]" + "Format to use for the Flymake mode line indicator. +The following format characters can be used: + +%s: The status. +%e: The number of errors. +%w: The number of warnings. +%n: The number of notes." + :type 'string) =20 (defun flymake--mode-line-format () "Produce a pretty minor mode indicator." @@ -1183,71 +1192,74 @@ flymake--mode-line-format diags-by-type))) (flymake--backend-state-diags state))) flymake--backend-state) - `((:propertize " Flymake" - mouse-face mode-line-highlight - help-echo - ,(concat (format "%s known backends\n" (length known)) - (format "%s running\n" (length running)) - (format "%s disabled\n" (length disabled)) - "mouse-1: Display minor mode menu\n" - "mouse-2: Show help for minor mode") - keymap - ,(let ((map (make-sparse-keymap))) - (define-key map [mode-line down-mouse-1] - flymake-menu) - (define-key map [mode-line mouse-2] - (lambda () - (interactive) - (describe-function 'flymake-mode))) - map)) - ,@(pcase-let ((`(,ind ,face ,explain) - (cond ((null known) - '("?" mode-line "No known backends")) - (some-waiting - `("Wait" compilation-mode-line-run - ,(format "Waiting for %s running backend(s)" - (length some-waiting)))) - (all-disabled - '("!" compilation-mode-line-run - "All backends disabled")) - (t - '(nil nil nil))))) - (when ind - `((":" - (:propertize ,ind - face ,face - help-echo ,explain - keymap - ,(let ((map (make-sparse-keymap))) - (define-key map [mode-line mouse-1] - 'flymake-switch-to-log-buffer) - map)))))) - ,@(unless (or all-disabled - (null known)) - (cl-loop - with types =3D (hash-table-keys diags-by-type) - with _augmented =3D (cl-loop for extra in '(:error :warning) - do (cl-pushnew extra types - :key #'flymake--sever= ity)) - for type in (cl-sort types #'> :key #'flymake--severity) - for diags =3D (gethash type diags-by-type) - for face =3D (flymake--lookup-type-property type - 'mode-line-face - 'compilation-error) - when (or diags - (cond ((eq flymake-suppress-zero-counters t) - nil) - (flymake-suppress-zero-counters - (>=3D (flymake--severity type) - (warning-numeric-level - flymake-suppress-zero-counters))) - (t t))) - collect `(:propertize - ,(format "%d" (length diags)) - face ,face - mouse-face mode-line-highlight - keymap - ,(let ((map (make-sparse-keymap)) + (format-spec + (propertize flymake-mode-line-indicator-format + 'mouse-face 'mode-line-highlight + 'help-echo + (concat (format "%s known backends\n" (length known)) + (format "%s running\n" (length running)) + (format "%s disabled\n" (length disabled)) + "mouse-1: Display minor mode menu\n" + "mouse-2: Show help for minor mode") + 'keymap + (let ((map (make-sparse-keymap))) + (define-key map [mode-line down-mouse-1] + flymake-menu) + (define-key map [mode-line mouse-2] + (lambda () + (interactive) + (describe-function 'flymake-mode))) + map)) + (cons + (cons ?s (cl-destructuring-bind + (ind face explain) + (cond ((null known) + '("?" mode-line "No known backends")) + (some-waiting + `("Wait" compilation-mode-line-run + ,(format "Waiting for %s running backend(s)" + (length some-waiting)))) + (all-disabled + '("!" compilation-mode-line-run + "All backends disabled")) + (t + '(nil nil nil))) + (when ind + (concat + ":" + (propertize ind + 'face face + 'help-echo explain + 'keymap + (let ((map (make-sparse-keymap))) + (define-key map [mode-line mouse-1] + 'flymake-switch-to-log-buffer) + map)))))) + (cl-loop + with types =3D (hash-table-keys diags-by-type) + with _augmented =3D (cl-loop for extra in '(:error :warning) + do (cl-pushnew extra types + :key #'flymake--severity)) + for type in (cl-sort types #'> :key #'flymake--severity) + for diags =3D (gethash type diags-by-type) + for face =3D (flymake--lookup-type-property type + 'mode-line-face + 'compilation-error) + when (or diags + (cond ((eq flymake-suppress-zero-counters t) + nil) + (flymake-suppress-zero-counters + (>=3D (flymake--severity type) + (warning-numeric-level + flymake-suppress-zero-counters))) + (t t))) + collect (cons (elt (format "%s" type) 1) + (propertize + (format "%d" (length diags)) + 'face face + 'mouse-face 'mode-line-highlight + 'keymap + (let ((map (make-sparse-keymap)) (type type)) (define-key map (vector 'mode-line mouse-wheel-down-event) @@ -1262,8 +1274,8 @@ flymake--mode-line-format (with-selected-window (posn-window (event-star= t event)) (flymake-goto-next-error 1 (list type) t)))) map) - help-echo - ,(concat (format "%s diagnostics of type %s\n" + 'help-echo + (concat (format "%s diagnostics of type %s\n" (propertize (format "%d" (length diags)) 'face face) @@ -1271,14 +1283,7 @@ flymake--mode-line-format 'face face)) (format "%s/%s: previous/next of this type" mouse-wheel-down-event - mouse-wheel-up-event))) - into forms - finally return - `((:propertize "[") - ,@(cl-loop for (a . rest) on forms by #'cdr - collect a when rest collect - '(:propertize " ")) - (:propertize "]"))))))) + mouse-wheel-up-event))))))))) =20 ;;; Diagnostics buffer =20 --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 17 02:09:25 2019 Received: (at 33740) by debbugs.gnu.org; 17 Sep 2019 06:09:25 +0000 Received: from localhost ([127.0.0.1]:51510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iA6g0-0004jq-UR for submit@debbugs.gnu.org; Tue, 17 Sep 2019 02:09:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iA6fy-0004jZ-Ki for 33740@debbugs.gnu.org; Tue, 17 Sep 2019 02:09:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35912) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iA6ft-0007O2-Hs; Tue, 17 Sep 2019 02:09:17 -0400 Received: from [176.228.60.248] (port=4611 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iA6fs-00034z-Mt; Tue, 17 Sep 2019 02:09:17 -0400 Date: Tue, 17 Sep 2019 09:09:14 +0300 Message-Id: <83lfunwj1x.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: <87h85bq3u7.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 17 Sep 2019 00:22:08 +0200) Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, joaotavora@gmail.com, andreyk.mad@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Date: Tue, 17 Sep 2019 00:22:08 +0200 > Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets > > I thought we could just put text properties on strings we feed to the > mode-line machinery, but it seems like these don't survive? You need to do it "wisely", then they do survive. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 17 07:57:39 2019 Received: (at 33740) by debbugs.gnu.org; 17 Sep 2019 11:57:39 +0000 Received: from localhost ([127.0.0.1]:51721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAC71-0002xj-H8 for submit@debbugs.gnu.org; Tue, 17 Sep 2019 07:57:39 -0400 Received: from quimby.gnus.org ([80.91.231.51]:56974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAC6z-0002xb-SC for 33740@debbugs.gnu.org; Tue, 17 Sep 2019 07:57:38 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iAC6w-0008Gy-SL; Tue, 17 Sep 2019 13:57:37 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> <83lfunwj1x.fsf@gnu.org> Date: Tue, 17 Sep 2019 13:57:34 +0200 In-Reply-To: <83lfunwj1x.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 17 Sep 2019 09:09:14 +0300") Message-ID: <871rwfnnip.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: >> I thought we could just put text properties on strings we feed to the >> mode-line machinery, but it seems like these don't survive? > > You need to do it "wisely", then they do survive. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, joaotavora@gmail.com, andreyk.mad@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> I thought we could just put text properties on strings we feed to the >> mode-line machinery, but it seems like these don't survive? > > You need to do it "wisely", then they do survive. What does the wisdom entail? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 17 08:13:53 2019 Received: (at 33740) by debbugs.gnu.org; 17 Sep 2019 12:13:53 +0000 Received: from localhost ([127.0.0.1]:51761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iACMi-0005S6-RV for submit@debbugs.gnu.org; Tue, 17 Sep 2019 08:13:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53355) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iACMh-0005Rt-6O for 33740@debbugs.gnu.org; Tue, 17 Sep 2019 08:13:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40414) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iACMW-0001TZ-DV; Tue, 17 Sep 2019 08:13:41 -0400 Received: from [176.228.60.248] (port=3487 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iACMU-0001g6-Qn; Tue, 17 Sep 2019 08:13:39 -0400 Date: Tue, 17 Sep 2019 15:13:37 +0300 Message-Id: <837e67w26m.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: <871rwfnnip.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 17 Sep 2019 13:57:34 +0200) Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> <83lfunwj1x.fsf@gnu.org> <871rwfnnip.fsf@gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, joaotavora@gmail.com, andreyk.mad@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: joaotavora@gmail.com, 33740@debbugs.gnu.org, andreyk.mad@gmail.com > Date: Tue, 17 Sep 2019 13:57:34 +0200 > > Eli Zaretskii writes: > > >> I thought we could just put text properties on strings we feed to the > >> mode-line machinery, but it seems like these don't survive? > > > > You need to do it "wisely", then they do survive. > > What does the wisdom entail? Apply the properties judiciously to specific parts of the mode-line string, not wholesale to all of it. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 17 08:22:34 2019 Received: (at 33740) by debbugs.gnu.org; 17 Sep 2019 12:22:34 +0000 Received: from localhost ([127.0.0.1]:51774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iACV8-0005g9-8p for submit@debbugs.gnu.org; Tue, 17 Sep 2019 08:22:34 -0400 Received: from quimby.gnus.org ([80.91.231.51]:57502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iACV6-0005g0-9O for 33740@debbugs.gnu.org; Tue, 17 Sep 2019 08:22:32 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iACV2-00005m-Ar; Tue, 17 Sep 2019 14:22:30 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> <83lfunwj1x.fsf@gnu.org> <871rwfnnip.fsf@gnus.org> <837e67w26m.fsf@gnu.org> Date: Tue, 17 Sep 2019 14:22:27 +0200 In-Reply-To: <837e67w26m.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 17 Sep 2019 15:13:37 +0300") Message-ID: <87o8zjm7ss.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > Apply the properties judiciously to specific parts of the mode-line > string, not wholesale to all of it. That's what I did (or tried to do). I basically made the function return something like Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, joaotavora@gmail.com, andreyk.mad@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Apply the properties judiciously to specific parts of the mode-line > string, not wholesale to all of it. That's what I did (or tried to do). I basically made the function return something like (concat "foo" (propertize "bar" 'face 'bold) "zot") but the "bar" remained non-bold in the mode line. If that's supposed to work, then there's something else wrong with my code, I guess? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 17 08:44:40 2019 Received: (at 33740) by debbugs.gnu.org; 17 Sep 2019 12:44:40 +0000 Received: from localhost ([127.0.0.1]:51813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iACqV-0008JD-RL for submit@debbugs.gnu.org; Tue, 17 Sep 2019 08:44:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iACqU-0008J0-7f for 33740@debbugs.gnu.org; Tue, 17 Sep 2019 08:44:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iACqO-0006t4-Uv; Tue, 17 Sep 2019 08:44:33 -0400 Received: from [176.228.60.248] (port=1608 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iACqO-0004el-Do; Tue, 17 Sep 2019 08:44:32 -0400 Date: Tue, 17 Sep 2019 15:44:30 +0300 Message-Id: <834l1bw0r5.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: <87o8zjm7ss.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 17 Sep 2019 14:22:27 +0200) Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> <83lfunwj1x.fsf@gnu.org> <871rwfnnip.fsf@gnus.org> <837e67w26m.fsf@gnu.org> <87o8zjm7ss.fsf@gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, joaotavora@gmail.com, andreyk.mad@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: joaotavora@gmail.com, 33740@debbugs.gnu.org, andreyk.mad@gmail.com > Date: Tue, 17 Sep 2019 14:22:27 +0200 > > Eli Zaretskii writes: > > > Apply the properties judiciously to specific parts of the mode-line > > string, not wholesale to all of it. > > That's what I did (or tried to do). I basically made the function > return something like > > (concat "foo" (propertize "bar" 'face 'bold) "zot") > > but the "bar" remained non-bold in the mode line. If that's supposed to > work, then there's something else wrong with my code, I guess? Most probably, but a bare-bones minimal Lisp to run and investigate will be appreciated. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 17 10:08:18 2019 Received: (at 33740) by debbugs.gnu.org; 17 Sep 2019 14:08:18 +0000 Received: from localhost ([127.0.0.1]:53111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAE9S-0004Cy-D1 for submit@debbugs.gnu.org; Tue, 17 Sep 2019 10:08:18 -0400 Received: from mail-io1-f53.google.com ([209.85.166.53]:39280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAE9Q-0004Cl-Sw for 33740@debbugs.gnu.org; Tue, 17 Sep 2019 10:08:17 -0400 Received: by mail-io1-f53.google.com with SMTP id a1so7907098ioc.6 for <33740@debbugs.gnu.org>; Tue, 17 Sep 2019 07:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LbKYPO/D2DS0HSCOBZQXXKdUdPds5kFoJP96ytmsDDc=; b=l7jBYoibYigPOpzwL5B/qBWUe4PDy3sNsEUz0kvyAB2dGgZuOHAW5E4UzF/GJyrOD1 0TqMC07c5mQwlTzDRGJzHY/hW2g3tBOnM2rtSr4tODPDw3ivIudI6wqQZzYdyvLzLec3 64sS2EBrT05p5oZDRbVO0ZoWjeNFTMpPOg+piINxMMxLIm1hGDZZ6VNBrSjXf01tNngS uoW/IZ65noAMcm9Kwx+gnuUUA1UA2eEQhq6zQps2ksuf6IRpAEkDbrhvtygIMVqSi5Y5 Dx2A2ZepuZbnBF1rCgMCSPKxf/9fCUEpuYkWWAP0X2x8v3CTXoEXirlbdaq0Kfr/JVRv CzJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LbKYPO/D2DS0HSCOBZQXXKdUdPds5kFoJP96ytmsDDc=; b=KMjpe3SOZj+PPMQUlaOABdQC5WLj9ntAtVLNod4rW/5JXzefpPxNjdTo6EQ506/es8 YryXwFMu4/CXiu3lKRAh+YPdDq/YjvulcHaZo/Id6XpvCaduAzzIoojnBgxOQXv9tjU6 GO3iN09xgkBQI05JkcoE2cotEbNoH0d3eeGmJjV7/irvds5tcTqMQPhSV3NOaI6Ep+F5 wGDn28F7nq69N3854BoF6rDVseCz8MfDDsQaK/EKG129LOgwUKVJIk5zqqfWs8kB1MqR o+UmN6hOsh/nExkCK6eIHf9DXURl92FC+qJ1Ox/2A6JTlk844GClRmM5U+VHOvGEbg4F 14wQ== X-Gm-Message-State: APjAAAVYQKo3fy4LZyj0rRsiFwzzHyugOP04tMlscNUSqM6sRMqei+It 4Io0Reo8BjXFOI4y65TOwwAp4dJQ5fx4spIZ3+g= X-Google-Smtp-Source: APXvYqycIglERRkP0E19FHG+SEa9RZBCsHVYSTgAk7TsaH7IPay3nDJTJccxGqfyWgun9lNO929Zquj4c/cbQP9s4bA= X-Received: by 2002:a6b:b643:: with SMTP id g64mr2018416iof.149.1568729291181; Tue, 17 Sep 2019 07:08:11 -0700 (PDT) MIME-Version: 1.0 References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> In-Reply-To: <87h85bq3u7.fsf@gnus.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Tue, 17 Sep 2019 15:07:59 +0100 Message-ID: Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator To: Lars Ingebrigtsen Content-Type: multipart/alternative; boundary="0000000000002661b30592c04063" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000002661b30592c04063 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Sep 16, 2019 at 11:22 PM Lars Ingebrigtsen wrote: > Jo=C3=A3o T=C3=A1vora writes: > > > Looks good, though I would prefer if the defcustom was a format-string > > where %s would be substituted by the error counts. That way you could > > even get rid of the braces or use something else. > > Below is a proof-of-this-concept-not-working when done via the normal > format-spec machinery. :-) > Thanks, Lars. I'm away from my emacs dev machine so I can't read the diff very carefully, but if you want to risk it, go ahead and push, because I like the defcustom spec and I see you've kept the default. A short entry in NEWS and the Flymake manual is probably worth it (but you can skip the latter). There are arbitrary errors levels in this flymake (not just error warning and note). But those are the main ones and anyway we can always add more format machinery later. I see a lot of changed lines, but most of them are probably whitespace. Is there some diff format which elides those? Jo=C3=A3o --0000000000002661b30592c04063 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Sep 16, 2019 at 11:22 PM Lars Ing= ebrigtsen <larsi@gnu= s.org> wrote:
Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> writ= es:

> Looks good, though I would prefer if the defcustom was a format-string=
> where %s would be substituted by the error counts.=C2=A0 That way you = could
> even get rid of the braces or use something else.

Below is a proof-of-this-concept-not-working when done via the normal
format-spec machinery.=C2=A0 :-)

Thanks= , Lars.=C2=A0 I'm away from my emacs dev machine so I can't read
the diff very carefully, but if you want to risk it, go ahead and p= ush, because I
like the defcustom spec and I see you've kept= the default. A short entry
in NEWS and the Flymake manual is pro= bably worth it (but you can skip
the latter).
=
There are arbitrary errors levels in this flymake (not just = error warning
and note). But those are the main ones and any= way we can always
add more format machinery later.

I see a lot of changed lines, but most of them are probably= whitespace.
Is there some diff format which elides those?
<= div>
Jo=C3=A3o
--0000000000002661b30592c04063-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 18 09:38:23 2019 Received: (at 33740) by debbugs.gnu.org; 18 Sep 2019 13:38:23 +0000 Received: from localhost ([127.0.0.1]:53765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAaA3-0001jb-5o for submit@debbugs.gnu.org; Wed, 18 Sep 2019 09:38:23 -0400 Received: from quimby.gnus.org ([80.91.231.51]:57328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAaA1-0001jR-IW for 33740@debbugs.gnu.org; Wed, 18 Sep 2019 09:38:21 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iAa9x-00025R-IK; Wed, 18 Sep 2019 15:38:20 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> <83lfunwj1x.fsf@gnu.org> <871rwfnnip.fsf@gnus.org> <837e67w26m.fsf@gnu.org> <87o8zjm7ss.fsf@gnus.org> <834l1bw0r5.fsf@gnu.org> Date: Wed, 18 Sep 2019 15:38:17 +0200 In-Reply-To: <834l1bw0r5.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 17 Sep 2019 15:44:30 +0300") Message-ID: <87pnjxlo6u.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > Most probably, but a bare-bones minimal Lisp to run and investigate > will be appreciated. Here's a simple one: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, joaotavora@gmail.com, andreyk.mad@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Most probably, but a bare-bones minimal Lisp to run and investigate > will be appreciated. Here's a simple one: (setq my-format (concat " foo " (propertize " bar " 'face 'bold) " zot ")) (setq mode-line-format (append mode-line-format (list 'my-format))) I get " foo bar zot " at the end of the mode line without any faces. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 18 09:40:52 2019 Received: (at 33740) by debbugs.gnu.org; 18 Sep 2019 13:40:52 +0000 Received: from localhost ([127.0.0.1]:53771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAaCR-0001ng-KN for submit@debbugs.gnu.org; Wed, 18 Sep 2019 09:40:52 -0400 Received: from quimby.gnus.org ([80.91.231.51]:57456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAaCN-0001nW-Kf for 33740@debbugs.gnu.org; Wed, 18 Sep 2019 09:40:50 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iAaCK-00028Y-G8; Wed, 18 Sep 2019 15:40:46 +0200 From: Lars Ingebrigtsen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> Date: Wed, 18 Sep 2019 15:40:44 +0200 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Tue, 17 Sep 2019 15:07:59 +0100") Message-ID: <87lfullo2r.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: João Távora writes: > Thanks, Lars. I'm away from my emacs dev machine so I can't read the > diff very carefully, but if you want to risk it, go ahead and push, > because I like the defcustom spec and I see you've kept t [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > Thanks, Lars. I'm away from my emacs dev machine so I can't read the > diff very carefully, but if you want to risk it, go ahead and push, > because I like the defcustom spec and I see you've kept the default. A > short entry in NEWS and the Flymake manual is probably worth it (but > you can skip the latter). Well, it doesn't quite work yet, so it's a bit premature. :-) > There are arbitrary errors levels in this flymake (not just error warning= =20 > and note). But those are the main ones and anyway we can always > add more format machinery later. Hm, is there a list of all the error levels? If not, I think the approach I took in the patch is probably misguided (what with %e for "error" and stuff).=20=20 > I see a lot of changed lines, but most of them are probably whitespace. Yes, it's mostly whitespace due to rearranging the way the strings are computed. > Is there some diff format which elides those? I'm not sure? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 18 09:59:30 2019 Received: (at 33740) by debbugs.gnu.org; 18 Sep 2019 13:59:30 +0000 Received: from localhost ([127.0.0.1]:54671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAaUT-0002VN-Ju for submit@debbugs.gnu.org; Wed, 18 Sep 2019 09:59:30 -0400 Received: from mail-io1-f51.google.com ([209.85.166.51]:37597) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAaUP-0002V3-HX for 33740@debbugs.gnu.org; Wed, 18 Sep 2019 09:59:26 -0400 Received: by mail-io1-f51.google.com with SMTP id b19so16408780iob.4 for <33740@debbugs.gnu.org>; Wed, 18 Sep 2019 06:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E0Yb62viBahwNBZLB4RUWmQwwFTIB4HUygLjdsDL6nc=; b=Ne5kaz4KehF/2ZiZdxvijC4P1bJc+oiD9i+mWaNCKywMjw+Q6FYV/r3f7Sz6j1P/OM swCTRs5zHtet0+tMQ5RVTfve8P3AttcVHhBCHzs7K+ItGnOgOmP2UhTLVnaHSL9FEZXE VoecxQsjeLzuTs6HH3xH+d3OQTaeOdXGY+RoI9IN5pWD5duCTaEhDohfXxMzheOhRuS+ Mz2FEI48NCxJF80kW0F8WP9HmSgPo+skHrN/Rt1ftpeYm3tTgUmL23R5xEbEvGnhA4MS OQGcEsl2MYWBZa+qw4qcrUw901C67xqp7AYNgI9GdW0/6hY2ZyxT+EccbWqkwJz0uJGn baNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E0Yb62viBahwNBZLB4RUWmQwwFTIB4HUygLjdsDL6nc=; b=XtB6Nvf5E86oV7NoJbO7cQxSSxObCVpbGyPf2VO0CvdvgpMGQffj2VJNLdBUyJfhqg MIwy9B2go0iBAJTlXplUx1I2+7Ost6I+VZAF39EPF/Ug53W3sAKGLoQyGjtLG2WTTQ5q qs6DWK5qzCOq7SARZEn8183QUEmRB7EXfp5gsfiGKR/cR3gZGmH9SV/of5mJV8bIUbJK 2fQhyu/ERPlQln4HqzYgC/G/C3lU8hPW8lFxrWObn4+kU5yY0BS7+qujjF+D8kFMXC77 2TRBqKQjpd54IBOAbL8VhdTVYb08wcGF3HtJYq5NvFDRfl1hiK5dhG5bf5CsobwfK3Dv 8aUA== X-Gm-Message-State: APjAAAUD4P31/vXMhqiFSbGSbtLV0t8nn5Zq5+qZ23NKGMcC9yCXpC6K brXLCeDF/77QPoFaCkzX9cJOv/x5boYLdH2WH0o= X-Google-Smtp-Source: APXvYqwvShcYcEXukGU7Q3MaYDHC6dmkqGVi/6BKPfbzMK8DWfKUuETDhBHl35pWmrLwbqdmbReFjrLRQv01ByceqPQ= X-Received: by 2002:a6b:b643:: with SMTP id g64mr5056034iof.149.1568815159792; Wed, 18 Sep 2019 06:59:19 -0700 (PDT) MIME-Version: 1.0 References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> <87lfullo2r.fsf@gnus.org> In-Reply-To: <87lfullo2r.fsf@gnus.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Wed, 18 Sep 2019 14:59:08 +0100 Message-ID: Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator To: Lars Ingebrigtsen Content-Type: multipart/alternative; boundary="000000000000515a990592d43e3b" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000515a990592d43e3b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Sep 18, 2019 at 2:40 PM Lars Ingebrigtsen wrote: > Jo=C3=A3o T=C3=A1vora writes: > > > Thanks, Lars. I'm away from my emacs dev machine so I can't read the > > diff very carefully, but if you want to risk it, go ahead and push, > > because I like the defcustom spec and I see you've kept the default. A > > short entry in NEWS and the Flymake manual is probably worth it (but > > you can skip the latter). > > Well, it doesn't quite work yet, so it's a bit premature. :-) > I see, what's wrong with it? > > There are arbitrary errors levels in this flymake (not just error > warning > > and note). But those are the main ones and anyway we can always > > add more format machinery later. > > Hm, is there a list of all the error levels? If not, I think the > approach I took in the patch is probably misguided (what with %e for > "error" and stuff). > There isn't a list of error levels, there are just severities. There are some built-in flymake _categories_ linked to the symbols :error, :warning and :note that connect these symbols with some preset severity. But flymake can work with annotations of arbitrary severities with some user-specified meaning. Hence errors, warnings, notes etc are just annotations of severities 3, 2, 1, respectively. This was tied to warning-numeric-level, which predates flymake. So I see "%e" as a shortcut for, say, "%3a" (number of annotations of severity 3), which is no problem imo. "%na" is the thing that could be implemented later... > > I see a lot of changed lines, but most of them are probably whitespace. > > Yes, it's mostly whitespace due to rearranging the way the strings are > computed. > > > Is there some diff format which elides those? > > I'm not sure? > I think git diff -w does something to that effect. Jo=C3=A3o T=C3=A1vora --000000000000515a990592d43e3b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Sep 18, 2019 at 2:40 PM Lars Inge= brigtsen <larsi@gnus.org> wrote= :
Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> writes:

> Thanks, Lars.=C2=A0 I'm away from my emacs dev machine so I can= 9;t read the
> diff very carefully, but if you want to risk it, go ahead and push, > because I like the defcustom spec and I see you've kept the defaul= t. A
> short entry in NEWS and the Flymake manual is probably worth it (but > you can skip the latter).

Well, it doesn't quite work yet, so it's a bit premature.=C2=A0 :-)=

I see, what's wrong with it?
<= /div>
=C2=A0
> There are arbitrary errors levels in this flymake (not just error warn= ing
> and note). But those are the main ones and anyway we can always
> add more format machinery later.

Hm, is there a list of all the error levels?=C2=A0 If not, I think the
approach I took in the patch is probably misguided (what with %e for
"error" and stuff).=C2=A0

Th= ere isn't a list of error levels, there are just severities. There are<= /div>
some built-in flymake _categories_ linked to the symbols :error, = :warning and
:note that connect these symbols with some preset se= verity.

But flymake can work with annotations of a= rbitrary severities with some
user-specified meaning. Hence = errors, warnings, notes etc are just
annotations of severities 3,= 2, 1, respectively. This was tied to
warning-numeric-level, which= predates flymake.

So I see "%e" a= s a shortcut for, say, "%3a" (number of annotations
of severity 3), which is no problem imo. "%na" is the thing tha= t could
be implemented later...
=C2=A0
> I see a lot of changed lines, but most of them are probably whitespace= .

Yes, it's mostly whitespace due to rearranging the way the strings are<= br> computed.

> Is there some diff format which elides those?

I'm not sure?

I think git diff -w d= oes something to that effect.

Jo=C3=A3o T=C3=A1vora
--000000000000515a990592d43e3b-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 18 10:03:07 2019 Received: (at 33740) by debbugs.gnu.org; 18 Sep 2019 14:03:07 +0000 Received: from localhost ([127.0.0.1]:54685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAaXy-0002ds-Vl for submit@debbugs.gnu.org; Wed, 18 Sep 2019 10:03:07 -0400 Received: from mail-io1-f52.google.com ([209.85.166.52]:46726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAaXx-0002cy-7L for 33740@debbugs.gnu.org; Wed, 18 Sep 2019 10:03:05 -0400 Received: by mail-io1-f52.google.com with SMTP id d17so16295158ios.13 for <33740@debbugs.gnu.org>; Wed, 18 Sep 2019 07:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=wX7nxYmHsDB7DhPFMC82pSmTZQITLq/8t4wqxiUq32w=; b=MrqqaOxrqb8sm7unVVJ8/nPm25WDGUdW1YGS2Qo/AIltaBj7/pBFxbUi54saLn/nzL Y6wfFpBYbdSehD0wzUcqpb78CiQvjCKo/Y5r9AEpY3u6sdyPZbCvoSVScYikl0kZv5HM 0oLxhI92nJ7Vx4bWAo4q9X++fb+xbc859Cg+HHxqaPnponPRVMFQeGXAHYY++GPJG4eW udNPDtaZ7/dZ1qobr4YOsXyRnUGcQgzNPsOFxgNiaYRd7s0i8Wqu5DWm834G6TvEpt3S 4whVGHW+E7TzhrlFqFFKOJE5oM6EU/v+IZM0OFZ9bgsqYQ4sNBn34vVBRnOzvzzCTh9y uing== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=wX7nxYmHsDB7DhPFMC82pSmTZQITLq/8t4wqxiUq32w=; b=XQtUfVlQG/ffTsw8LJKhGQVbWfnCljXVkH6AiI3p8Fwua6H9Iwfms6rO4kKw1sY6Qm 505fyWW1wbdOdH7LaGcgDD6wqywXaNaEL7qgwA4bY3EXAMlclAD9ux8PbUsiPaQawzQ3 9m0DHqVMbPV4KJ/vnYDU5v4Y8kDk9J5I/u5saYrR3K4DbrbjUpX5h0KLWrZb/A1ZVuRj bXFQMq2GYv3yLSL/x3fEo9dKQ3ZsM2VwVEAIwLOIwRqx3ngjmAHT9a2AQNUy7+4PG98p HPVb0F239JYM5obGwTzUEDFvlRbomJyEpMApT0uP6yM9Tyzi2eL9xfyoXxgEL+wJNdUR K0Ug== X-Gm-Message-State: APjAAAWwNNn9Gt2M7n7lGvh2aWFvDrN7OIUSakP8i9CqkKkdhb5BwaQs 808IDPg9JHZvNgLTL8a0T/fH3RQH X-Google-Smtp-Source: APXvYqx+8WzfhqL88DmZRoc/uE2AufPbp4/P3y2NqcTT9gTKnWOeWsRGrcej3f0gYHFMTTXlzPGx4A== X-Received: by 2002:a6b:fa14:: with SMTP id p20mr4838728ioh.15.1568815379790; Wed, 18 Sep 2019 07:02:59 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.38.42]) by smtp.gmail.com with ESMTPSA id u124sm8630036ioe.63.2019.09.18.07.02.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 Sep 2019 07:02:55 -0700 (PDT) From: Noam Postavsky To: Lars Ingebrigtsen Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> <87lfullo2r.fsf@gnus.org> Date: Wed, 18 Sep 2019 10:02:53 -0400 In-Reply-To: <87lfullo2r.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 18 Sep 2019 15:40:44 +0200") Message-ID: <85r24dk8he.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, =?iso-8859-1?Q?Jo=E3o_T=E1vora?= , Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Yes, it's mostly whitespace due to rearranging the way the strings are > computed. > >> Is there some diff format which elides those? > > I'm not sure? You can pass --ignore-all-space (aka -w) to git diff (although the result might not work for git apply). https://git-scm.com/docs/git-diff#Documentation/git-diff.txt--w From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 18 10:09:20 2019 Received: (at 33740) by debbugs.gnu.org; 18 Sep 2019 14:09:20 +0000 Received: from localhost ([127.0.0.1]:54693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAae0-0002om-1L for submit@debbugs.gnu.org; Wed, 18 Sep 2019 10:09:20 -0400 Received: from quimby.gnus.org ([80.91.231.51]:58458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAady-0002oc-DC for 33740@debbugs.gnu.org; Wed, 18 Sep 2019 10:09:18 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iAadt-0002VB-68; Wed, 18 Sep 2019 16:09:16 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> <83lfunwj1x.fsf@gnu.org> <871rwfnnip.fsf@gnus.org> <837e67w26m.fsf@gnu.org> <87o8zjm7ss.fsf@gnus.org> <834l1bw0r5.fsf@gnu.org> <87pnjxlo6u.fsf@gnus.org> Date: Wed, 18 Sep 2019 16:09:12 +0200 In-Reply-To: <87pnjxlo6u.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 18 Sep 2019 15:38:17 +0200") Message-ID: <87woe5k86v.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > Eli Zaretskii writes: > >> Most probably, but a bare-bones minimal Lisp to run and investigate >> will be appreciated. > > Here's a simple one: > > (setq my-format (concat " foo " (pr [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, joaotavora@gmail.com, andreyk.mad@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Eli Zaretskii writes: > >> Most probably, but a bare-bones minimal Lisp to run and investigate >> will be appreciated. > > Here's a simple one: > > (setq my-format (concat " foo " (propertize " bar " 'face 'bold) " zot ")) > (setq mode-line-format (append mode-line-format (list 'my-format))) > > I get " foo bar zot " at the end of the mode line without any faces. I did something as radical as actually reading the doc string to mode-line-format, and doing this (put 'my-format 'risky-local-variable t) makes this work as expected. Then I guess I can proceed with the original flymake feature implementation. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 19 11:28:50 2019 Received: (at 33740) by debbugs.gnu.org; 19 Sep 2019 15:28:50 +0000 Received: from localhost ([127.0.0.1]:56285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAyMU-0000rU-H1 for submit@debbugs.gnu.org; Thu, 19 Sep 2019 11:28:50 -0400 Received: from quimby.gnus.org ([80.91.231.51]:58902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAyMQ-0000rI-FU for 33740@debbugs.gnu.org; Thu, 19 Sep 2019 11:28:46 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iAyMK-0003jL-Vg; Thu, 19 Sep 2019 17:28:44 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> <83lfunwj1x.fsf@gnu.org> <871rwfnnip.fsf@gnus.org> <837e67w26m.fsf@gnu.org> <87o8zjm7ss.fsf@gnus.org> <834l1bw0r5.fsf@gnu.org> <87pnjxlo6u.fsf@gnus.org> <87woe5k86v.fsf@gnus.org> Date: Thu, 19 Sep 2019 17:28:40 +0200 In-Reply-To: <87woe5k86v.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 18 Sep 2019 16:09:12 +0200") Message-ID: <87blvgjoev.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > I did something as radical as actually reading the doc string to > mode-line-format, and doing this > > (put 'my-format 'risky-local-variable t) > > makes this work as expected. Then I guess I can p [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, joaotavora@gmail.com, andreyk.mad@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > I did something as radical as actually reading the doc string to > mode-line-format, and doing this > > (put 'my-format 'risky-local-variable t) > > makes this work as expected. Then I guess I can proceed with the > original flymake feature implementation. But... no. As a test case, go to any .el file in Emacs and say `M-x flymake-mode', and you'll get a lighter in the minor modes in the mode lines saying something like " Flymake[0 3 17]" or whatever. Then try this: (setq flymake--mode-line-format (concat (propertize " bar " 'face 'bold) "foo")) Both "bar" and "foo" will be bold in the mode line. (setq flymake--mode-line-format (concat "foo" (propertize " bar " 'face 'bold))) Neither "foo" nor "bar" will be bold. So it seems like whatever is computing the mode line is somehow copying the faces from the first character in the lighter string and applies them to the entire lighter? Very confusing. This does not happen outside of the minor modes in the mode line (i.e., if I add an element outside of the minor modes, text properties are not overwritten this way). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 19 11:39:45 2019 Received: (at 33740) by debbugs.gnu.org; 19 Sep 2019 15:39:45 +0000 Received: from localhost ([127.0.0.1]:56294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAyX2-00019d-Sf for submit@debbugs.gnu.org; Thu, 19 Sep 2019 11:39:45 -0400 Received: from quimby.gnus.org ([80.91.231.51]:59192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAyX0-00019V-RI for 33740@debbugs.gnu.org; Thu, 19 Sep 2019 11:39:43 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iAyWw-0003t6-TH; Thu, 19 Sep 2019 17:39:41 +0200 From: Lars Ingebrigtsen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> <87lfullo2r.fsf@gnus.org> Date: Thu, 19 Sep 2019 17:39:38 +0200 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Wed, 18 Sep 2019 14:59:08 +0100") Message-ID: <877e64jnwl.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: João Távora writes: > Well, it doesn't quite work yet, so it's a bit premature. :-) > > I see, what's wrong with it? I'm not sure -- there's something about the way Emacs renders the minor mode lighters that doesn't quite preserve the text properties. That'll have to be fixed first... if indeed that's the problem an [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > Well, it doesn't quite work yet, so it's a bit premature. :-) > > I see, what's wrong with it?=20 I'm not sure -- there's something about the way Emacs renders the minor mode lighters that doesn't quite preserve the text properties. That'll have to be fixed first... if indeed that's the problem and I'm not just doing something stupid here somehow. > But flymake can work with annotations of arbitrary severities with some=20 > user-specified meaning. Hence errors, warnings, notes etc are just > annotations of severities 3, 2, 1, respectively. This was tied to=20 > warning-numeric-level, which predates flymake. Right, I see.=20=20 > So I see "%e" as a shortcut for, say, "%3a" (number of annotations=20 > of severity 3), which is no problem imo. "%na" is the thing that could > be implemented later... But the problem I see here is that the "unknown" annotations can't really be specified in the format string and will therefore not be shown. If we have (defvar flymake-mode-line-indicator-format " Flymake%s[%e %w %n]") then we've enumerated all the annotations the user will ever see, and new ones won't appear. So I think specifying it on this detailed level isn't the path to go, but instead we'll have (defvar flymake-mode-line-indicator-format " Flymake%s[%a]") where "%a" is "all the annotations". I think that's flexible enough -- it doesn't allow the user to change the order of the annotations individually, but I don't think that's really needed, either... --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 19 11:55:09 2019 Received: (at 33740) by debbugs.gnu.org; 19 Sep 2019 15:55:09 +0000 Received: from localhost ([127.0.0.1]:56302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAylw-0001ce-L7 for submit@debbugs.gnu.org; Thu, 19 Sep 2019 11:55:08 -0400 Received: from quimby.gnus.org ([80.91.231.51]:59558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAylu-0001cR-Ll for 33740@debbugs.gnu.org; Thu, 19 Sep 2019 11:55:07 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iAylo-00042b-Rj; Thu, 19 Sep 2019 17:55:04 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> <83lfunwj1x.fsf@gnu.org> <871rwfnnip.fsf@gnus.org> <837e67w26m.fsf@gnu.org> <87o8zjm7ss.fsf@gnus.org> <834l1bw0r5.fsf@gnu.org> <87pnjxlo6u.fsf@gnus.org> <87woe5k86v.fsf@gnus.org> <87blvgjoev.fsf@gnus.org> Date: Thu, 19 Sep 2019 17:55:00 +0200 In-Reply-To: <87blvgjoev.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 19 Sep 2019 17:28:40 +0200") Message-ID: <8736gsjn6z.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > Then try this: > > (setq flymake--mode-line-format (concat (propertize " bar " 'face 'bold) "foo")) > > Both "bar" and "foo" will be bold in the mode line. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, joaotavora@gmail.com, andreyk.mad@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Then try this: > > (setq flymake--mode-line-format (concat (propertize " bar " 'face 'bold) "foo")) > > Both "bar" and "foo" will be bold in the mode line. I... think I know why this is happening. Mixing the two ways of specifying text properties isn't really allowed. `mode-line-modes' has this: (:propertize ("" minor-mode-alist) mouse-face mode-line-highlight help-echo "Minor mode\nmouse-1: Display minor m ... display_mode_element does this for strings: Lisp_Object oprops, aelt; oprops = Ftext_properties_at (make_fixnum (0), elt); /* If the starting string's properties are not what we want, translate the string. Also, if the string is risky, do that anyway. */ if (NILP (Fequal (props, oprops)) || risky) { /* If the starting string has properties, merge the specified ones onto the existing ones. */ if (! NILP (oprops) && !risky) So we basically do exactly what I was seeing -- overwrite the entire string's text properties with the text property in the first character of the string. But! This is only done if the string is inside a (:propertize ...) clause, because this is only done of props is passed in, which (if I read the code correctly) only happens if that's done. But the code in that function could be clearer -- I don't really understand why this is done at all. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 19 12:23:10 2019 Received: (at 33740) by debbugs.gnu.org; 19 Sep 2019 16:23:10 +0000 Received: from localhost ([127.0.0.1]:56317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAzD4-0002Vf-HT for submit@debbugs.gnu.org; Thu, 19 Sep 2019 12:23:10 -0400 Received: from quimby.gnus.org ([80.91.231.51]:60192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAzD2-0002VU-2I for 33740@debbugs.gnu.org; Thu, 19 Sep 2019 12:23:09 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iAzCw-0004Ts-7D; Thu, 19 Sep 2019 18:23:06 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> <83lfunwj1x.fsf@gnu.org> <871rwfnnip.fsf@gnus.org> <837e67w26m.fsf@gnu.org> <87o8zjm7ss.fsf@gnus.org> <834l1bw0r5.fsf@gnu.org> <87pnjxlo6u.fsf@gnus.org> <87woe5k86v.fsf@gnus.org> <87blvgjoev.fsf@gnus.org> <8736gsjn6z.fsf@gnus.org> Date: Thu, 19 Sep 2019 18:23:01 +0200 In-Reply-To: <8736gsjn6z.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 19 Sep 2019 17:55:00 +0200") Message-ID: <87sgosi7bu.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > But the code in that function could be clearer -- I don't really > understand why this is done at all. aelt = Fassoc (elt, mode_line_proptrans_alist, Qnil); if (! NILP (aelt) && !NILP (Fequal (props, XCDR (aelt)))) { /* AELT is what we want. Move it to the front without consing. */ elt = XCAR (aelt); [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, joaotavora@gmail.com, andreyk.mad@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > But the code in that function could be clearer -- I don't really > understand why this is done at all. aelt = Fassoc (elt, mode_line_proptrans_alist, Qnil); if (! NILP (aelt) && !NILP (Fequal (props, XCDR (aelt)))) { /* AELT is what we want. Move it to the front without consing. */ elt = XCAR (aelt); mode_line_proptrans_alist = move_elt_to_front (aelt, mode_line_proptrans_alist); } else { Lisp_Object tem; /* If AELT has the wrong props, it is useless. so get rid of it. */ Oh, this entire thing is just so that we can maintain a cache of text properties and avoid some consing? And if we have a cache, then all the characters in the element has to have the same text properties. I wonder whether all this is really warranted... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 19 13:26:25 2019 Received: (at 33740) by debbugs.gnu.org; 19 Sep 2019 17:26:25 +0000 Received: from localhost ([127.0.0.1]:56361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iB0CH-0004OW-Fz for submit@debbugs.gnu.org; Thu, 19 Sep 2019 13:26:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42867) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iB0CE-0004OE-H6 for 33740@debbugs.gnu.org; Thu, 19 Sep 2019 13:26:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53860) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iB0C9-0003bO-AJ; Thu, 19 Sep 2019 13:26:17 -0400 Received: from [176.228.60.248] (port=4443 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iB0C8-0002CB-B7; Thu, 19 Sep 2019 13:26:17 -0400 Date: Thu, 19 Sep 2019 20:26:17 +0300 Message-Id: <83lfuktcxy.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: <87sgosi7bu.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 19 Sep 2019 18:23:01 +0200) Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> <83lfunwj1x.fsf@gnu.org> <871rwfnnip.fsf@gnus.org> <837e67w26m.fsf@gnu.org> <87o8zjm7ss.fsf@gnus.org> <834l1bw0r5.fsf@gnu.org> <87pnjxlo6u.fsf@gnus.org> <87woe5k86v.fsf@gnus.org> <87blvgjoev.fsf@gnus.org> <8736gsjn6z.fsf@gnus.org> <87sgosi7bu.fsf@gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, joaotavora@gmail.com, andreyk.mad@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: 33740@debbugs.gnu.org, joaotavora@gmail.com, andreyk.mad@gmail.com > Date: Thu, 19 Sep 2019 18:23:01 +0200 > > Lars Ingebrigtsen writes: > > > But the code in that function could be clearer -- I don't really > > understand why this is done at all. > > aelt = Fassoc (elt, mode_line_proptrans_alist, Qnil); > if (! NILP (aelt) && !NILP (Fequal (props, XCDR (aelt)))) > { > /* AELT is what we want. Move it to the front > without consing. */ > elt = XCAR (aelt); > mode_line_proptrans_alist > = move_elt_to_front (aelt, mode_line_proptrans_alist); > } > else > { > Lisp_Object tem; > > /* If AELT has the wrong props, it is useless. > so get rid of it. */ > > > Oh, this entire thing is just so that we can maintain a cache of text > properties and avoid some consing? And if we have a cache, then all the > characters in the element has to have the same text properties. Yes. > I wonder whether all this is really warranted... It is. Redrawing the mode line is a very frequent redisplay thing, so optimizing the heck out of it is justified. That's what I meant when I said "wisely": you need to create faces in advance, and take care to have each individual string you use to be of a uniform face. And don't use propertize. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 20 08:32:08 2019 Received: (at 33740) by debbugs.gnu.org; 20 Sep 2019 12:32:08 +0000 Received: from localhost ([127.0.0.1]:56918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBI52-0003QE-BY for submit@debbugs.gnu.org; Fri, 20 Sep 2019 08:32:08 -0400 Received: from quimby.gnus.org ([80.91.231.51]:54016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBI4z-0003Q0-M8 for 33740@debbugs.gnu.org; Fri, 20 Sep 2019 08:32:06 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iBI4v-0000VE-8R; Fri, 20 Sep 2019 14:32:03 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> <83lfunwj1x.fsf@gnu.org> <871rwfnnip.fsf@gnus.org> <837e67w26m.fsf@gnu.org> <87o8zjm7ss.fsf@gnus.org> <834l1bw0r5.fsf@gnu.org> <87pnjxlo6u.fsf@gnus.org> <87woe5k86v.fsf@gnus.org> <87blvgjoev.fsf@gnus.org> <8736gsjn6z.fsf@gnus.org> <87sgosi7bu.fsf@gnus.org> <83lfuktcxy.fsf@gnu.org> Date: Fri, 20 Sep 2019 14:32:00 +0200 In-Reply-To: <83lfuktcxy.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 19 Sep 2019 20:26:17 +0300") Message-ID: <87k1a3b133.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > It is. Redrawing the mode line is a very frequent redisplay thing, so > optimizing the heck out of it is justified. In the simple case where the mode line element is a string, I can definitely see that it's warranted. In the Flymake case, where the value is (:eval (flymake--mode-line-format)), which returns a long [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, joaotavora@gmail.com, andreyk.mad@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > It is. Redrawing the mode line is a very frequent redisplay thing, so > optimizing the heck out of it is justified. In the simple case where the mode line element is a string, I can definitely see that it's warranted. In the Flymake case, where the value is (:eval (flymake--mode-line-format)), which returns a long and complex (:propertize) form that's then interpreted by this machinery -- it's pessimal. > That's what I meant when I said "wisely": you need to create faces in > advance, and take care to have each individual string you use to be of > a uniform face. And don't use propertize. Most modes do not have dynamic lighters, and using (:propertize) forms is a fine solution. For something like Flymake, that updates its lighter every time the mode line is redrawn, it just doesn't make much sense. If Flymake could just return a properly propertized string, then that would be a lot more efficient (both cons-wise and time wise) having it return this form (which I've lightly edited to elide the keymaps): ((:propertize " Flymake" mouse-face mode-line-highlight help-echo "3 known backends\n2 running\n1 disabled\nmouse-1: Display minor mode menu\nmouse-2: Show help for minor mode" keymap ...) (:propertize "[") (:propertize "0" face compilation-error mouse-face mode-line-highlight keymap .. help-echo #("0 diagnostics of type :error\nmouse-4/mouse-5: previous/next of this type" 0 1 (face compilation-error) 22 28 (face compilation-error))) (:propertize " ") (:propertize "0" face compilation-warning mouse-face mode-line-highlight keymap ... help-echo #("0 diagnostics of type :warning\nmouse-4/mouse-5: previous/next of this type" 0 1 (face compilation-warning) 22 30 (face compilation-warning))) (:propertize " ") (:propertize "14" face compilation-info mouse-face mode-line-highlight keymap ... help-echo #("14 diagnostics of type :note\nmouse-4/mouse-5: previous/next of this type" 0 2 (face compilation-info) 23 28 (face compilation-info))) (:propertize "]")) If there was a way to tell display_mode_element "don't do the caching stuff on this element", then Flymake could just return a propertized string and display_mode_element would have to do a whole lot less processing. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 20 09:06:44 2019 Received: (at 33740) by debbugs.gnu.org; 20 Sep 2019 13:06:44 +0000 Received: from localhost ([127.0.0.1]:56952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBIcV-0006OF-Ut for submit@debbugs.gnu.org; Fri, 20 Sep 2019 09:06:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBIcT-0006O1-F0 for 33740@debbugs.gnu.org; Fri, 20 Sep 2019 09:06:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51314) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iBIcO-0002dj-BU; Fri, 20 Sep 2019 09:06:36 -0400 Received: from [176.228.60.248] (port=1256 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iBIcM-00077m-Kk; Fri, 20 Sep 2019 09:06:35 -0400 Date: Fri, 20 Sep 2019 16:06:36 +0300 Message-Id: <83r24bruar.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: <87k1a3b133.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 20 Sep 2019 14:32:00 +0200) Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> <83lfunwj1x.fsf@gnu.org> <871rwfnnip.fsf@gnus.org> <837e67w26m.fsf@gnu.org> <87o8zjm7ss.fsf@gnus.org> <834l1bw0r5.fsf@gnu.org> <87pnjxlo6u.fsf@gnus.org> <87woe5k86v.fsf@gnus.org> <87blvgjoev.fsf@gnus.org> <8736gsjn6z.fsf@gnus.org> <87sgosi7bu.fsf@gnus.org> <83lfuktcxy.fsf@gnu.org> <87k1a3b133.fsf@gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, joaotavora@gmail.com, andreyk.mad@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: 33740@debbugs.gnu.org, joaotavora@gmail.com, andreyk.mad@gmail.com > Date: Fri, 20 Sep 2019 14:32:00 +0200 > > Eli Zaretskii writes: > > > It is. Redrawing the mode line is a very frequent redisplay thing, so > > optimizing the heck out of it is justified. > > In the simple case where the mode line element is a string, I can > definitely see that it's warranted. In the Flymake case, where the > value is (:eval (flymake--mode-line-format)), which returns a long and > complex (:propertize) form that's then interpreted by this machinery -- > it's pessimal. No, it isn't. If I'm not mistaken, we have bug reports regarding flickering of mode lines, including under Flymake. If we want to have a richer set of indicators for Flymake, may I suggest considering alternative methods of indicating stuff, and leaving the poor-old crammed mode line alone? From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 20 09:07:49 2019 Received: (at 33740) by debbugs.gnu.org; 20 Sep 2019 13:07:49 +0000 Received: from localhost ([127.0.0.1]:56957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBIdZ-0006Q9-9v for submit@debbugs.gnu.org; Fri, 20 Sep 2019 09:07:49 -0400 Received: from mail-io1-f48.google.com ([209.85.166.48]:35303) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBIdY-0006Pv-0l for 33740@debbugs.gnu.org; Fri, 20 Sep 2019 09:07:48 -0400 Received: by mail-io1-f48.google.com with SMTP id q10so16040898iop.2 for <33740@debbugs.gnu.org>; Fri, 20 Sep 2019 06:07:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c2ipP8ozQLzjnyskWtW/tbrdSuQDte298k9Ej3GHJiM=; b=VYFbz7y95hnjJj99jjQVv2KkSwxu+enmyuUxV0nwQE33RGeMKHrW8jMzIuw9+8PfAn tqpaxQXJOaa98573Z5RvIQ0B/kQgM70ii41sVaA+1F2lZxCeiqchREsjBxYArC9WzV6z NMt9wGWGYNravbTECPqikZdp9lK9PB8z/Zt9AKGK+0yDnTiL7SyRtNP/W+fcA0HiMOCi sZmWou7vehF0d3brwVuyvi24Hoh1xQlPMRng+VERKcnygr5En86S16MeR2BWxurX9pV5 i5S6CkL1HaK9gGGBRJ0CE1IE2+oaapRJ2+UXmsgsfR3LpusNSBr+ePF97lgDQljOqPgj e09w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c2ipP8ozQLzjnyskWtW/tbrdSuQDte298k9Ej3GHJiM=; b=nNszy6XO4fv8rDMRnwDHPzdzF+nmNHpDZS10urOZE+3fPoF+DpUfmDQJthnAlaVWf/ 8Hh12W4cZGVqAjFdYwAJP884n/8SxjPkFq19WKmQoRKQfrR4yTL3hLPDOeDuxgvdAMKJ NEcZQ9xQtQ2ExNWofRzPkxwTp/jSMIMufk6hVmMyDTYJC1QQlwQ1bP+vUgyn0hcueCDp hdhlyIX+rpY+JLCxQda6W3IMj1yNn3iotVWaj9AMGiael9fsS+iPL5b7HnCCXCrKa9gL ByvhHDMTmNEEpR79deCKkSZ+6aEkjs9faI0kJWgCFDfVie8tksFFG2pYNOEV0hz0GbGb n0VA== X-Gm-Message-State: APjAAAUeCho18g7dtoVAJn8lmbr5pm05BN02tO+ZtzUHTXRxSNusxQ+i 3vsOo+fLCif19QymoiOEKh8wynew8r5l0RLs0GI= X-Google-Smtp-Source: APXvYqzvGcKj5Q8i7xYaxc9WYuCdIBIgiOq5GnJGjUBG6g0EQoz5kkSHvX1fRh9rET+bGWPSsL7y6MXaBhQgzHtkquw= X-Received: by 2002:a6b:c38f:: with SMTP id t137mr15867230iof.137.1568984862323; Fri, 20 Sep 2019 06:07:42 -0700 (PDT) MIME-Version: 1.0 References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> <87lfullo2r.fsf@gnus.org> <877e64jnwl.fsf@gnus.org> In-Reply-To: <877e64jnwl.fsf@gnus.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Fri, 20 Sep 2019 14:07:30 +0100 Message-ID: Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator To: Lars Ingebrigtsen Content-Type: multipart/alternative; boundary="0000000000006079d30592fbc1bb" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000006079d30592fbc1bb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Sep 19, 2019 at 4:39 PM Lars Ingebrigtsen wrote: > > I'm not sure -- there's something about the way Emacs renders the minor > mode lighters that doesn't quite preserve the text properties. That'll > have to be fixed first... if indeed that's the problem and I'm not just > doing something stupid here somehow. > OK. And this is what you're discussing with Eli in the side thread, I suppose. > > So I see "%e" as a shortcut for, say, "%3a" (number of annotations > > of severity 3), which is no problem imo. "%na" is the thing that could > > be implemented later... > > But the problem I see here is that the "unknown" annotations can't > really be specified in the format string and will therefore not be > shown. > ...unless he sets flymake-mode-line-indicator-format buffer-locally or globally or something. And to be clear, he may not see them _summarized_ in the mode line, which is not the same as saying he is not seeing them. I think using non-standard severities should be possible (that's why I added them), but reasonably rare, so I think the extra effort of changing flymake-mode-line-indicator-format for those cases is in proportion. But read to the end of the mail for another idea. it doesn't allow the user to change the order of the annotations > individually, but I don't think that's really needed, either... On the contrary, I think this is what is requested. Not only change the order, but the display paraphernalia around it, for mode-line loving users. There is something that we might be forgetting, and which might bridge the gap between our views. Currently, notes (diagnostics of severity 1) are only shown in the mode-lin= e summary if they total >=3D 0. This is hardcoded, but the behaviour should b= e configurable, too. So, along with "%e" we should probably have something like "%!e". The former would mean "replace with number of errors if this number is greater than 0", the latter being "replace with number of errors, even if 0". The default value for the proposed defcustom would be "Flymake[%!e %!w %n]" which mirrors the current behaviour. Now, supposing there are some new annotations with arbitrary severities, we could use the non-! form to include them and keep the default value working. Maybe "%>e" could mean "put all annotations more severe than 3 here". Or something like that. We should also do something about whitespace. I lean towards somehow(TM) munching whitespace so that "Flymake[%!e %!w %n]" becomes "Flymake[42 42]" if there are 0 notes. Hope this isn't becoming very complicated. Jo=C3=A3o. --0000000000006079d30592fbc1bb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Sep 19, 2019 at 4:39 PM Lars Inge= brigtsen <larsi@gnus.org> wrote= :

I'm not sure -- there's something about the way Emacs renders the m= inor
mode lighters that doesn't quite preserve the text properties.=C2=A0 Th= at'll
have to be fixed first...=C2=A0 if indeed that's the problem and I'= m not just
doing something stupid here somehow.

OK= . And this is what you're discussing with Eli in the side thread, I sup= pose.
=C2=A0
> So I see "%e" as a shortcut for, say, "%3a"= ; (number of annotations
> of severity 3), which is no problem imo. "%na" is the thing = that could
> be implemented later...

But the problem I see here is that the "unknown" annotations can&= #39;t
really be specified in the format string and will therefore not be
shown.

...unless he sets flymake-mode-l= ine-indicator-format buffer-locally
or globally or something= .=C2=A0=C2=A0

And to be clear, he may not see them= _summarized_ in the mode line,
which is not the same as saying h= e is not seeing them.

I think using non-standard s= everities should be possible
(that's why I added them), = but reasonably rare, so I think the extra effort of
changing= flymake-mode-line-indicator-format for those cases is in proportion.
=

But read to the end of the mail for another idea.

it doesn't allow the user to change the order of the annotations
individually, but I don't think that's really needed, either...

On the contrary, I think this is what is reque= sted. Not only change
the order,=C2=A0 but the display paraphern= alia around it, for mode-line
loving users.

<= /div>
There is something that we might be forgetting, and which might b= ridge the
gap between our views.

Cu= rrently, notes (diagnostics of severity 1) are only shown in the mode-line<= /div>
summary if they total >=3D 0. This is hardcoded, but the behav= iour should be
configurable, too.

So, a= long with "%e" we should probably have something like "%!e&q= uot;. The
former would mean "replace with number of err= ors if this number is greater
than 0", the latter being= "replace with number of errors, even if 0".

=
The default value for the proposed defcustom would be

"Flymake[%!e %!w %n]"

which mir= rors the current behaviour. Now, supposing there are some
new an= notations with arbitrary severities, we could use the non-! form
= to include them and keep the default value working. Maybe "%>e"= ;
could mean "put all annotations more severe than 3 he= re".=C2=A0 Or something
like that.

= We should also do something about whitespace.=C2=A0 I lean towards
somehow(TM) munching whitespace so that "Flymake[%!e %!w %n]&qu= ot;
becomes "Flymake[42 42<no whitespace here>]" = if there are 0 notes.

Hope this isn't becoming very complicated.
<= div class=3D"gmail_quote">
Jo=C3=A3o.



=
--0000000000006079d30592fbc1bb-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 20 09:13:27 2019 Received: (at 33740) by debbugs.gnu.org; 20 Sep 2019 13:13:27 +0000 Received: from localhost ([127.0.0.1]:56962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBIj1-0006Yd-4h for submit@debbugs.gnu.org; Fri, 20 Sep 2019 09:13:27 -0400 Received: from quimby.gnus.org ([80.91.231.51]:54988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBIiz-0006YU-KK for 33740@debbugs.gnu.org; Fri, 20 Sep 2019 09:13:26 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iBIiv-0000vQ-H8; Fri, 20 Sep 2019 15:13:24 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> <83lfunwj1x.fsf@gnu.org> <871rwfnnip.fsf@gnus.org> <837e67w26m.fsf@gnu.org> <87o8zjm7ss.fsf@gnus.org> <834l1bw0r5.fsf@gnu.org> <87pnjxlo6u.fsf@gnus.org> <87woe5k86v.fsf@gnus.org> <87blvgjoev.fsf@gnus.org> <8736gsjn6z.fsf@gnus.org> <87sgosi7bu.fsf@gnus.org> <83lfuktcxy.fsf@gnu.org> <87k1a3b133.fsf@gnus.org> <83r24bruar.fsf@gnu.org> Date: Fri, 20 Sep 2019 15:13:21 +0200 In-Reply-To: <83r24bruar.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 Sep 2019 16:06:36 +0300") Message-ID: <874l17az66.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > If we want to have a richer set of indicators for Flymake, may I > suggest considering alternative methods of indicating stuff, and > leaving the poor-old crammed mode line alone? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, joaotavora@gmail.com, andreyk.mad@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > If we want to have a richer set of indicators for Flymake, may I > suggest considering alternative methods of indicating stuff, and > leaving the poor-old crammed mode line alone? No, we don't want a richer set of indicators -- a user requested being allowed to customise it (to remove stuff from it), and I tried to do that via the `format-spec' machinery. But that can't be used, since display_mode_element requires us to return a complex list that it re-interprets instead of being able to just give it a string that it'll display. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 21 03:54:21 2019 Received: (at 33740) by debbugs.gnu.org; 21 Sep 2019 07:54:21 +0000 Received: from localhost ([127.0.0.1]:59003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBaDl-0004u9-5H for submit@debbugs.gnu.org; Sat, 21 Sep 2019 03:54:21 -0400 Received: from quimby.gnus.org ([80.91.231.51]:48368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBaDj-0004u0-LG for 33740@debbugs.gnu.org; Sat, 21 Sep 2019 03:54:20 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iBaDe-0007hd-JF; Sat, 21 Sep 2019 09:54:18 +0200 From: Lars Ingebrigtsen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> <87lfullo2r.fsf@gnus.org> <877e64jnwl.fsf@gnus.org> Date: Sat, 21 Sep 2019 09:54:13 +0200 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Fri, 20 Sep 2019 14:07:30 +0100") Message-ID: <877e622ifu.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: João Távora writes: > On Thu, Sep 19, 2019 at 4:39 PM Lars Ingebrigtsen wrote: > > I'm not sure -- there's something about the way Emacs renders the minor > mode lighters that doesn't quite preserve the [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > On Thu, Sep 19, 2019 at 4:39 PM Lars Ingebrigtsen wrote: > > I'm not sure -- there's something about the way Emacs renders the minor > mode lighters that doesn't quite preserve the text properties. That'll > have to be fixed first... if indeed that's the problem and I'm not just > doing something stupid here somehow. > > OK. And this is what you're discussing with Eli in the side thread, I sup= pose.=20 Yes, and it doesn't seem like looks very positively on the possibility of allowing the minor mode lighters of being strings with text properties, so my suggested rewrite is a no-go. But if we move the status from the minor mode lighter to mode-line-process, then it'd work... And perhaps that's a more logical place, anyway? > Currently, notes (diagnostics of severity 1) are only shown in the mode-l= ine > summary if they total >=3D 0. This is hardcoded, but the behaviour should= be > configurable, too. > > So, along with "%e" we should probably have something like "%!e". The=20 > former would mean "replace with number of errors if this number is greate= r=20 > than 0", the latter being "replace with number of errors, even if 0". > > The default value for the proposed defcustom would be > > "Flymake[%!e %!w %n]" `format-spec' doesn't allow two-character specs, but %E/%e would work... > which mirrors the current behaviour. Now, supposing there are some > new annotations with arbitrary severities, we could use the non-! form > to include them and keep the default value working. Maybe "%>e"=20 > could mean "put all annotations more severe than 3 here". Or something > like that. Having a spec for "all the rest of the annotations" is possible, but seems a bit odd, interface wise... > We should also do something about whitespace. I lean towards=20 > somehow(TM) munching whitespace so that "Flymake[%!e %!w %n]" > becomes "Flymake[42 42]" if there are 0 notes. > > Hope this isn't becoming very complicated. Only slightly. :-) --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 22 17:09:47 2019 Received: (at 33740) by debbugs.gnu.org; 22 Sep 2019 21:09:47 +0000 Received: from localhost ([127.0.0.1]:34573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iC975-0006Ri-03 for submit@debbugs.gnu.org; Sun, 22 Sep 2019 17:09:47 -0400 Received: from anteater.elm.relay.mailchannels.net ([23.83.212.3]:27086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iC973-0006RZ-Bi for 33740@debbugs.gnu.org; Sun, 22 Sep 2019 17:09:46 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 14314500EE2; Sun, 22 Sep 2019 21:09:44 +0000 (UTC) Received: from pdx1-sub0-mail-a21.g.dreamhost.com (100-96-29-122.trex.outbound.svc.cluster.local [100.96.29.122]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 6DBD35012D3; Sun, 22 Sep 2019 21:09:43 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a21.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.5); Sun, 22 Sep 2019 21:09:43 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Eyes-Juvenile: 10f0e7982e6e25d4_1569186583685_1330287476 X-MC-Loop-Signature: 1569186583685:345290111 X-MC-Ingress-Time: 1569186583685 Received: from pdx1-sub0-mail-a21.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a21.g.dreamhost.com (Postfix) with ESMTP id 485E37F60D; Sun, 22 Sep 2019 14:09:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=ykPNP051EsqzrTuASFzLzQTyY4Q=; b= j9tc/vBVaICnQK/uZ8+7TiWFjPKGR8qJzuTqhDQaIOApLFawjPchisA4CPpIxne5 8Kmhn8I9RwdIuf1yEoplQA1XbmEq40/Y90MUZajIWu25WCfqulg/T51vIy4gt2eK lMslsVJkKxXHxYfHP6VkD2jTpRivIaXkIHboYlHdpXQ= Received: from mail.jurta.org (m91-129-105-145.cust.tele2.ee [91.129.105.145]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a21.g.dreamhost.com (Postfix) with ESMTPSA id 9E77D7F600; Sun, 22 Sep 2019 14:09:36 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a21 From: Juri Linkov To: Lars Ingebrigtsen Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator Organization: LINKOV.NET References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> <87lfullo2r.fsf@gnus.org> <877e64jnwl.fsf@gnus.org> <877e622ifu.fsf@gnus.org> Date: Sun, 22 Sep 2019 23:55:07 +0300 In-Reply-To: <877e622ifu.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 21 Sep 2019 09:54:13 +0200") Message-ID: <871rw88310.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrvdeigdduheeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdehrddugeehnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddthedrudeghedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehlrghrshhisehgnhhushdrohhrghenucevlhhushhtvghrufhiiigvpedt X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, =?iso-8859-1?Q?Jo=E3o_T=E1vora?= , Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > But if we move the status from the minor mode lighter to mode-line-process, > then it'd work... And perhaps that's a more logical place, anyway? A more logical place would be in the same place where errors are displayed by compilation-mode, i.e. mode-line-process indeed. >From compile.el: (setq mode-line-process '((:propertize ":%s" face compilation-mode-line-run) compilation-mode-line-errors)) From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 23 05:18:38 2019 Received: (at 33740) by debbugs.gnu.org; 23 Sep 2019 09:18:38 +0000 Received: from localhost ([127.0.0.1]:35062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCKUQ-0004NF-0c for submit@debbugs.gnu.org; Mon, 23 Sep 2019 05:18:38 -0400 Received: from mail-io1-f45.google.com ([209.85.166.45]:35319) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCKUO-0004N0-CB for 33740@debbugs.gnu.org; Mon, 23 Sep 2019 05:18:36 -0400 Received: by mail-io1-f45.google.com with SMTP id q10so31734778iop.2 for <33740@debbugs.gnu.org>; Mon, 23 Sep 2019 02:18:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KSJEHdJ+Xwx7rARc6CDBfUlAMCj3jgaDQYJcbsL6dpc=; b=T2/jHHhgG1mDtdHcPSbQ9COja3XBcjK8iOMDxezhLuJzb4G4IrJgpHpYozGYoJL5DF qB3epVomZyPoOZGz477doPqHXSAc4BU4jnd+hrgtJSMA+/4ujIWKyPfO8SSYx5b7ohoZ nyKSPcwNoMkKXfm9QDlVs+uALh54YJjNfCrSE5oWrq3LyXQ7cZrB/SEPkDsursCG5Z4m qYZLGPF+d+1TwvWy5gjxq8FktivX+EzijskGwpSzunxLv38oUm089nVLCS+BvLblcx32 JZQ5lGCM2MwLJ03j8abCiz5Intf9ZbGX03cAJCNsrODk5khfqHxjbfxTqghBiDEKvbJp Ryvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KSJEHdJ+Xwx7rARc6CDBfUlAMCj3jgaDQYJcbsL6dpc=; b=fGA+UsK8C2z47Pi4TYLB7mXvlHazk+2F5ECK/nmYk6mst+LFaauhIFu+5vLvvL5D78 9y7+pg2XknEaMpanjq3mSh6CCFpHUupe+4F/zi9NBfcxx7SmR+IC6bgmEwFUaN0qgBCO WWoGVBuqLr34RA+kfV/0RM95YhJpoLJy8WPP496ohE/mF4IjcYs5anPmVQ0v1ZpBDW+G fsHofMcBkStEyDgI0CjB3e1FOD4vmaKAxJOo8AB8zdnoRJ41pAbTMBlyZyFnW2w7lKKZ /Juy0Pll3Zd+B3qQcFHMY2pYdL+T4pVhlUfzRJu/a3r4I+Iwp5R7jU7VkxaBOtvobw0n O2Bw== X-Gm-Message-State: APjAAAUGWB+CS28iTbfuXvZ8W6xqkn8FKsP4A1CmtI8DP7MNHtJsOjxm 3NbdOj3rP90uDCoPOPe7L6cOX0zHPpgq3jQpWyw= X-Google-Smtp-Source: APXvYqz14abQIOzUHLUnAZsn5JOU7sMf8HhvFq4IN3LivJRp0/bSjXsSgWjWKa7N9TAM0hpN2u36wVUEuolY8xP75nI= X-Received: by 2002:a5e:c745:: with SMTP id g5mr18317437iop.9.1569230309814; Mon, 23 Sep 2019 02:18:29 -0700 (PDT) MIME-Version: 1.0 References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> <87lfullo2r.fsf@gnus.org> <877e64jnwl.fsf@gnus.org> <877e622ifu.fsf@gnus.org> <871rw88310.fsf@mail.linkov.net> In-Reply-To: <871rw88310.fsf@mail.linkov.net> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Mon, 23 Sep 2019 10:18:30 +0100 Message-ID: Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator To: Juri Linkov Content-Type: multipart/alternative; boundary="0000000000002ff581059334e762" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: Lars Ingebrigtsen , 33740@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000002ff581059334e762 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Sep 22, 2019 at 10:09 PM Juri Linkov wrote: > > But if we move the status from the minor mode lighter to > mode-line-process, > > then it'd work... And perhaps that's a more logical place, anyway? > > A more logical place would be in the same place where errors > are displayed by compilation-mode, i.e. mode-line-process indeed. > +1 from me, no objections. Indeed flymake is a kind of incremental compilation, so it makes perfect sense... not least because I can't possibly see the need of ever enabling flymake in a compilation-mode buffer (but this is Emacs so I probably should shut up now...) Jo=C3=A3o --0000000000002ff581059334e762 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sun, Sep 22, 2019 at 10:09 PM Juri Lin= kov <juri@linkov.net> wrote:
> But if we move the status from the minor mode lighter to mo= de-line-process,
> then it'd work...=C2=A0 And perhaps that's a more logical plac= e, anyway?

A more logical place would be in the same place where errors
are displayed by compilation-mode, i.e. mode-line-process indeed.

+1 from me, no objections.=C2=A0 Indeed flymake = is a kind of incremental
compilation, so it makes perfect se= nse... not least because I can't
possibly see the need o= f ever enabling flymake in a compilation-mode
buffer (but th= is is Emacs so I probably should shut up now...)

J= o=C3=A3o
--0000000000002ff581059334e762-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 23 05:25:40 2019 Received: (at 33740) by debbugs.gnu.org; 23 Sep 2019 09:25:40 +0000 Received: from localhost ([127.0.0.1]:35076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCKbD-0004aE-Iy for submit@debbugs.gnu.org; Mon, 23 Sep 2019 05:25:39 -0400 Received: from mail-io1-f54.google.com ([209.85.166.54]:47054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCKbB-0004a1-QL for 33740@debbugs.gnu.org; Mon, 23 Sep 2019 05:25:38 -0400 Received: by mail-io1-f54.google.com with SMTP id c6so18509345ioo.13 for <33740@debbugs.gnu.org>; Mon, 23 Sep 2019 02:25:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3LRuZC/AlRidN03rPNtjr49I959WWtc8eWsfRnVyxvQ=; b=tuvNqKIUKqqyomS2bxIXBzNgwLh8/MbEZ5EhU/fXvQ3mCJIyek9pvbMlbVJsrEud0+ qutfMxP2R9GGmwee1XcvhuRhkXX7vSQvuy7sJUEILYMuE5axKoqvfhiBbvGXhuLd8cF2 XuY0x8xwEelcAJGjGyba7ycxvU328kiFDtdbXIr6vlcRgnDvtKu+FtpH14WW+Lgoae3x KSdg4TERKLmRo3WIX8M2izlGokZbvJXFP6nJvuT+JoI4l9vP2iKm1a3JKaYcgFl+XfVo AXcn/52E2ZtFc0PzIDgfk2dpploGEHUgc7WA8JSy022ubkvzDGRCEJoCdCir+lCK5/XX q/SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3LRuZC/AlRidN03rPNtjr49I959WWtc8eWsfRnVyxvQ=; b=Md4EB/WQajGhD8ndEo1nUF92dehDlX7ckRXCrGu2jkXWICymOqiX/GEzW0v52qin/T VX0nPTm36IYGyXRG0cSL7icUwXTPynEciA6Z3jPCmolf6hjok+H35eqIf2gxwcFkmJ9O vbGgxT4H7yciSiuZfb+QSJi1ywjz/qBgTvvTOzQI721B4lZXe9AxWdc+WwE1tg9movsH vYyhl+DxV/lp3ydyJ9ufYsU/LbUT279nO72Md4Jk3TaxgRmj3FTCqq8o3IvtcoVJtnmc CdX9ve1S3PlVF/ZyoH5o8xXsqj/hN7kMHerKzOJ7fWOeSfSzS+4S5yuNnRRBXoH8Payr cVxA== X-Gm-Message-State: APjAAAWGy5PGS4ruL/iZ88TpwysDZNSD63Kn9sfHli1hjZd8JFBMcGB5 eWbMX8D4IAI4x8jEd/lEpNcAImctzaSTZESPTjdjEw== X-Google-Smtp-Source: APXvYqztYoCMtMIP8DEYyH7PGnKuaooYOCDkF7pWyLlUw6P8/sIZ3Vc7gZ3F59ewFI9VDKeOH1toW/Ic6heIoLmLlb0= X-Received: by 2002:a6b:c38f:: with SMTP id t137mr15702425iof.137.1569230732106; Mon, 23 Sep 2019 02:25:32 -0700 (PDT) MIME-Version: 1.0 References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> <87lfullo2r.fsf@gnus.org> <877e64jnwl.fsf@gnus.org> <877e622ifu.fsf@gnus.org> In-Reply-To: <877e622ifu.fsf@gnus.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Mon, 23 Sep 2019 10:25:32 +0100 Message-ID: Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator To: Lars Ingebrigtsen Content-Type: multipart/alternative; boundary="0000000000005ba2220593350031" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000005ba2220593350031 Content-Type: text/plain; charset="UTF-8" On Sat, Sep 21, 2019 at 8:54 AM Lars Ingebrigtsen wrote: > > work... And perhaps that's a more logical place, anyway? > Yup. > The default value for the proposed defcustom would be > > > > "Flymake[%!e %!w %n]" > > `format-spec' doesn't allow two-character specs, but %E/%e would work... > Fine with me. > > which mirrors the current behaviour. Now, supposing there are some > > new annotations with arbitrary severities, we could use the non-! form > > to include them and keep the default value working. Maybe "%>e" > > could mean "put all annotations more severe than 3 here". Or something > > like that. > > Having a spec for "all the rest of the annotations" is possible, but > seems a bit odd, interface wise... > It's really "all the annotations for which you selected a non-standard severity", but they can be of many types. So the use case for this might be smaller than you think. Also, one reason I can think of for selecting a non-standard severity for your custom diagnostic type might be precisely to hide it from the mode-line. And if 'format-spec' is ever enhanced to allow numeric stuff, then we can fine tune %a into something like %a or something. > We should also do something about whitespace. I lean towards > > somehow(TM) munching whitespace so that "Flymake[%!e %!w %n]" > > becomes "Flymake[42 42]" if there are 0 notes. > > > > Hope this isn't becoming very complicated. > > Only slightly. :-) But is it complicated enough? :-) --0000000000005ba2220593350031 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Sat, Sep 21, 2019 at 8:54 AM Lars Ingebrigtsen <larsi@gnus.org> wrote:

work...=C2=A0 And perhaps that's a more logical place, anyway?

Yup.

> The default value for the proposed defcustom would be
>
> "Flymake[%!e %!w %n]"

`format-spec' doesn't allow two-character specs, but %E/%e would wo= rk...

Fine with me.
=C2= =A0
> which mirrors the current behaviour. Now, supposing there are some
> new annotations with arbitrary severities, we could use the non-! form=
> to include them and keep the default value working. Maybe "%>e= "
> could mean "put all annotations more severe than 3 here".=C2= =A0 Or something
> like that.

Having a spec for "all the rest of the annotations" is possible, = but
seems a bit odd, interface wise...

It&#= 39;s really "all the annotations for which you selected a non-standard=
severity", but they can be of many types. So the use c= ase for this might
be smaller than you think.=C2=A0 Also, one rea= son I can think of for selecting
a non-standard severity for= your custom diagnostic type might be precisely
to hide it f= rom the mode-line.

And if 'format-spec' is= ever enhanced to allow numeric stuff, then we can
fine tune= %a into something like %<integer>a or something.

=
> We should also do something about whitespace.=C2=A0 I lean towards > somehow(TM) munching whitespace so that "Flymake[%!e %!w %n]"= ;
> becomes "Flymake[42 42<no whitespace here>]" if there = are 0 notes.
>
> Hope this isn't becoming very complicated.

Only slightly.=C2=A0 :-)

But is it co= mplicated enough? :-)
--0000000000005ba2220593350031-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 23 14:11:00 2019 Received: (at 33740) by debbugs.gnu.org; 23 Sep 2019 18:11:00 +0000 Received: from localhost ([127.0.0.1]:37063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCSnc-0005eH-LG for submit@debbugs.gnu.org; Mon, 23 Sep 2019 14:11:00 -0400 Received: from quimby.gnus.org ([80.91.231.51]:42128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCSna-0005e8-Me for 33740@debbugs.gnu.org; Mon, 23 Sep 2019 14:10:59 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iCSnV-0001lT-MJ; Mon, 23 Sep 2019 20:10:56 +0200 From: Lars Ingebrigtsen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> <87lfullo2r.fsf@gnus.org> <877e64jnwl.fsf@gnus.org> <877e622ifu.fsf@gnus.org> <871rw88310.fsf@mail.linkov.net> Date: Mon, 23 Sep 2019 20:10:53 +0200 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Mon, 23 Sep 2019 10:18:30 +0100") Message-ID: <87impiyjbm.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: João Távora writes: > +1 from me, no objections. Indeed flymake is a kind of incremental > compilation, so it makes perfect sense... not least because I can't > possibly see the need of ever enabling flymake in a compila [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > +1 from me, no objections. Indeed flymake is a kind of incremental=20 > compilation, so it makes perfect sense... not least because I can't=20 > possibly see the need of ever enabling flymake in a compilation-mode=20 > buffer (but this is Emacs so I probably should shut up now...) They can probably coexist, I think? That is, both of them can add to the variable buffer-locally. Perhaps. :-) --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 23 14:11:37 2019 Received: (at 33740) by debbugs.gnu.org; 23 Sep 2019 18:11:37 +0000 Received: from localhost ([127.0.0.1]:37067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCSoC-0005fY-TS for submit@debbugs.gnu.org; Mon, 23 Sep 2019 14:11:37 -0400 Received: from quimby.gnus.org ([80.91.231.51]:42152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCSoA-0005fQ-SM for 33740@debbugs.gnu.org; Mon, 23 Sep 2019 14:11:35 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iCSo7-0001lk-Ra; Mon, 23 Sep 2019 20:11:34 +0200 From: Lars Ingebrigtsen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> <87lfullo2r.fsf@gnus.org> <877e64jnwl.fsf@gnus.org> <877e622ifu.fsf@gnus.org> Date: Mon, 23 Sep 2019 20:11:31 +0200 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Mon, 23 Sep 2019 10:25:32 +0100") Message-ID: <87ef06yjak.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: João Távora writes: > It's really "all the annotations for which you selected a non-standard > severity", but they can be of many types. So the use case for this might > be smaller than you think. Also, one reason I can [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > It's really "all the annotations for which you selected a non-standard=20 > severity", but they can be of many types. So the use case for this might > be smaller than you think. Also, one reason I can think of for selecting= =20 > a non-standard severity for your custom diagnostic type might be precisel= y=20 > to hide it from the mode-line. Makes sense. I'll try to implement this, but probably not right away. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 28 21:12:29 2020 Received: (at 33740) by debbugs.gnu.org; 29 Dec 2020 02:12:29 +0000 Received: from localhost ([127.0.0.1]:37265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ku4Uv-0001FM-1G for submit@debbugs.gnu.org; Mon, 28 Dec 2020 21:12:29 -0500 Received: from quimby.gnus.org ([95.216.78.240]:49296) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ku4Ur-0001F2-QK for 33740@debbugs.gnu.org; Mon, 28 Dec 2020 21:12:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=en50/fArFU1YBD1NJpK1Vs0a664UvMqBGVI/q4gDGP4=; b=vPxj/UA6LlpTW3jgpvoT0XYWNd bCtKVTJK6pe9I/qYZzg+fXuDFEhmXlyFK5LjNJuYKLEndfdDRg68t8f+xXOtq/FmTD5v2F/ngax7y NdUIULyv9iAJ/FK9qJKP/5T6N7RAwU0gkBeOPkPeSY4MHwF3XQXtDtwpXc9Wkb3dLCz8=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ku4Uh-0003wH-Ni; Tue, 29 Dec 2020 03:12:19 +0100 From: Lars Ingebrigtsen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> X-Now-Playing: WS Burroughs's _The Fruit of the Original Sin_: "Twilight's Last Gleaming" Date: Tue, 29 Dec 2020 03:12:14 +0100 In-Reply-To: <87bm4wjhgy.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Fri, 04 Jan 2019 20:27:57 +0000") Message-ID: <87lfdhgy2p.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: João Távora writes: > Looks good, though I would prefer if the defcustom was a format-string > where %s would be substituted by the error counts. That way you could > even get rid of the braces or use something else. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > Looks good, though I would prefer if the defcustom was a format-string > where %s would be substituted by the error counts. That way you could > even get rid of the braces or use something else. I've now altered format-spec to (optionally) return a list of strings, which makes the previously proposed patch work, so I've now pushed it (after rebasing it). It seems to work fine in my test cases, but it hasn't been tested extensively. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 28 21:12:34 2020 Received: (at control) by debbugs.gnu.org; 29 Dec 2020 02:12:34 +0000 Received: from localhost ([127.0.0.1]:37268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ku4V0-0001Fd-AM for submit@debbugs.gnu.org; Mon, 28 Dec 2020 21:12:34 -0500 Received: from quimby.gnus.org ([95.216.78.240]:49310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ku4Uy-0001FE-3i for control@debbugs.gnu.org; Mon, 28 Dec 2020 21:12:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iC5HSHT+szHoiHwC/FFLOonx3zO+q62jgukY+jxZhvE=; b=mBoRxkAGTsqlrN7R6vMYXYotVL bKJexdmIusImKLEUuR1h/399E+pIVoetmYyHlb3av/m6hZ7MPxFr8rHhRjzgIZeaHLb1/QBcR9ugP LQ4TRXGC1Z6bn0+AZ1M+JklCt6HciCwR4wbLgng52NyJfgch9Ns5mXb+ZqWFt6tzgyZ0=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ku4Uq-0003wO-Kb for control@debbugs.gnu.org; Tue, 29 Dec 2020 03:12:26 +0100 Date: Tue, 29 Dec 2020 03:12:23 +0100 Message-Id: <87k0t1gy2g.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #33740 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 33740 fixed close 33740 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 33740 fixed close 33740 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 28 21:19:43 2020 Received: (at 33740) by debbugs.gnu.org; 29 Dec 2020 02:19:43 +0000 Received: from localhost ([127.0.0.1]:37281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ku4bv-0003We-0q for submit@debbugs.gnu.org; Mon, 28 Dec 2020 21:19:43 -0500 Received: from quimby.gnus.org ([95.216.78.240]:49370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ku4bs-0003WR-Bs for 33740@debbugs.gnu.org; Mon, 28 Dec 2020 21:19:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=r8HZooHzF9anEz718Fq3HyT6aqfxWCxzRHu2ltcg/MY=; b=sto+8or0TOMMO13jmVYXZLOsYy d8k8/LhMecYVLk78ZbCpoIqvlq+b2OjcS2OAGECSLYZzLz5NrCKPuJszkL/l54Y9PyIUVIL6jB1Vu PNCip5mMfdPWmdYrcdeS9fM5ba8frKPv3jgS/A9chf1fcTTG2fXbf/HdjVTmt35HrkGY=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ku4bj-000402-Ux; Tue, 29 Dec 2020 03:19:34 +0100 From: Lars Ingebrigtsen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87lfdhgy2p.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEUZKTEZKTIkOkUt SVdNU2JJc4v////jk2ZGAAAAAWJLR0QGYWa4fQAAAAd0SU1FB+QMHQIRNrll85AAAAG6SURBVDjL lZNNkhoxDIVl4ACWMgdoyxwgWMwesDlAKvT9rzKS7G7oYbKIiuqFPz/9WA8A4lzYgiJsgkmYRWoi ZJp2EeK0m/R8l1QgIn+v5SYfUuRWc5HrpILMWUG9nv6U/eGSW91fjucISJZfQZMsR9HbWT+/JkDM DiQjEMbDbxXsLwyQhkIYrZVju7Xc2g2AnKxAPq6H1upFFcheXIHNcaz13Ko0AEwdFEaThEi7PuiS iDm5JPjPBnfACwjaZnwB/loYgycLAb8BtDyKY3QgJS+59BA1VsDSNdqXA5cq8LaMJAQc0WuMQZTE odDOeBTRjyULq4T6g4iM6VeAG5D+BTgtuXQfBnhh6UXhgy+At+AZRSW0gPxKVEKsWzWXrIe2u6K3 bWZT8BO0nsvBWKG2aqDKBvSQdp8ftbyDfL7PcxsSCOMUEzp4SJk6oL5VDRIFc5WTXX4HXmULMH8q mFvVKk8AagQ6z060PkP/D/qWYYCHnAzgSGVey/cOigPivjiT2PA6vSQCL5LMBObcvL6xefIJujWK Ld+AEregVfHEaqQEneh1B2BWhNGL+zVCQHiLfj3AT/Hz6X/FFzD4giiy6Z5hAAAAJXRFWHRkYXRl OmNyZWF0ZQAyMDIwLTEyLTI5VDAyOjE3OjU0KzAwOjAw66me2QAAACV0RVh0ZGF0ZTptb2RpZnkA MjAyMC0xMi0yOVQwMjoxNzo1NCswMDowMJr0JmUAAAAASUVORK5CYII= X-Now-Playing: Tuxedomoon's _Desire_: "East" Date: Tue, 29 Dec 2020 03:19:30 +0100 In-Reply-To: <87lfdhgy2p.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 29 Dec 2020 03:12:14 +0100") Message-ID: <87bledgxql.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > I've now altered format-spec to (optionally) return a list of strings, > which makes the previously proposed patch work, so I've now pushed it > (after rebasing it). It seems to work fine in my test [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > I've now altered format-spec to (optionally) return a list of strings, > which makes the previously proposed patch work, so I've now pushed it > (after rebasing it). It seems to work fine in my test cases, but it > hasn't been tested extensively. (Jo=C3=A3o, if you could have a look over the resulting code change (which = is mostly just indentation changes, but also changes a lot of the quoting), that'd be nice.) --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 29 08:52:43 2020 Received: (at 33740) by debbugs.gnu.org; 29 Dec 2020 13:52:43 +0000 Received: from localhost ([127.0.0.1]:38038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuFQZ-0004LA-C1 for submit@debbugs.gnu.org; Tue, 29 Dec 2020 08:52:43 -0500 Received: from mail-wm1-f42.google.com ([209.85.128.42]:54459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuFQX-0004Ky-N7 for 33740@debbugs.gnu.org; Tue, 29 Dec 2020 08:52:42 -0500 Received: by mail-wm1-f42.google.com with SMTP id c133so2638776wme.4 for <33740@debbugs.gnu.org>; Tue, 29 Dec 2020 05:52:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=Kp+FeKfmurAnQbyu5W9eUh5/eSK4vQaRUdCQVrKMHuI=; b=RvXAQwZB+vB0uIUgjHJENDWygdEepZlG9bZz4aHPjURQJ1XMh3uIbqxOBn1Tds6GCW ohtmGC4DG9XqtkhzTY6iajjFN8NXWrbqrPRrIaSPIrFR7N1+eC6/YTp/yZA0rfBz4rhh SmsYQG2J2AdQ4ZvCjXXApfgyyD5+0FlP/rvJ2kmH0S9q7LiMd75T8tzbtXi468J9Zr+5 QVEHUb4tA+Gi/3QEp9aoCTj7UAx1NHCZXunbKKWZiqcMWJRZRCeiu2b3uV29e7BEbPBd UZE3ZqEwhYxMTbmouq07Xm3530Q+ggycRh8slw6oNmh7YIQuEmm2jXlsqepiSGvRGZgx CZrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Kp+FeKfmurAnQbyu5W9eUh5/eSK4vQaRUdCQVrKMHuI=; b=OcwesGWV8kp8OFumLl+6tqjReSZLfRM3f6HPeaITehmhY3kO1VcCexcFOaGkQkN/2q FHZkHENAQ6JdkNR7qPp7DI+A/+gi6wUEgFUhHjTsT1ec1d/2LkFqebwGU6pXVD6D3z0A qXP+YBqO5rImBrUJVqQVwqTmMn6FCP0I5nq8KgPjs9nFozrILQBW/YM8RqRgCFDzRmsZ EVoffI4X2LnCgc0oQK4jOzivl3HFO0Ty2T1wYATXnTbc00Q0ilBTEW2UrybrGt3adobp Z8LZonohn3KFqXzDI2Z/oEJ7xLKgu/u6fxwIWF1g3SKGvrGXelNE0jX2+TAHgCC9JbXq wv8Q== X-Gm-Message-State: AOAM530KqltyrgKgB2Z3E6q0U5dzTRcHmRWvo7UjGyig4IEOfspQ+p7p RNKkLBWFezSf0cyjTxvMK4U= X-Google-Smtp-Source: ABdhPJx9LgMLFdAGhkxKQwJg2Mzq42FModAEFDqTgq+cgoNV6qeDSFQ608q9jF9Px5h4MU5IOjZIAQ== X-Received: by 2002:a7b:c45a:: with SMTP id l26mr3603309wmi.91.1609249955879; Tue, 29 Dec 2020 05:52:35 -0800 (PST) Received: from krug (222.201.137.78.rev.vodafone.pt. [78.137.201.222]) by smtp.gmail.com with ESMTPSA id r13sm61325015wrt.10.2020.12.29.05.52.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Dec 2020 05:52:35 -0800 (PST) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Lars Ingebrigtsen Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87lfdhgy2p.fsf@gnus.org> <87bledgxql.fsf@gnus.org> Date: Tue, 29 Dec 2020 13:52:32 +0000 In-Reply-To: <87bledgxql.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 29 Dec 2020 03:19:30 +0100") Message-ID: <87lfdgk9cv.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Lars Ingebrigtsen writes: > >> I've now altered format-spec to (optionally) return a list of strings, >> which makes the previously proposed patch work, so I've now pushed it >> (after rebasing it). It seems to work fine in my test cases, but it >> hasn't been tested extensively. > > (Jo=C3=A3o, if you could have a look over the resulting code change (whic= h is > mostly just indentation changes, but also changes a lot of the quoting), > that'd be nice.) The first thing I notice is that the indicator is completely gone. I.e. I can't see any flymake indications in the mode-line. Is that intended, or am I doing something wrong? Did you test this? I tried with src/emacs -Q -f flymake-mode Before your change, one sees error thingies in the mode-line, after your change one doesn't. Perhaps it wouldn't be a bad idea to revert and stage these ideas in a side branch? Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 29 09:15:02 2020 Received: (at 33740) by debbugs.gnu.org; 29 Dec 2020 14:15:02 +0000 Received: from localhost ([127.0.0.1]:38067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuFm9-0004uj-SC for submit@debbugs.gnu.org; Tue, 29 Dec 2020 09:15:02 -0500 Received: from quimby.gnus.org ([95.216.78.240]:54622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuFm7-0004uK-Av for 33740@debbugs.gnu.org; Tue, 29 Dec 2020 09:15:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1SkWuLGtV1FVqghId2FFWEAqvrHoUZ3LScYWax6t1fA=; b=gRPRVFzU11vvNSEzbyWV9Gzhab aIh8v3VptR3YfembQISM3NiCTzuLyEur+QbjLw/d+p47ovmin/TVFnd7dtOeaWv6DhtysCYuzK1lg mCghvVCxl5s111E9TgwjtF6agPVpEVx1AkwIlqq9BWwk9t75mUPWHZCD58nSmz0Iufpk=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kuFlw-0002KA-Ls; Tue, 29 Dec 2020 15:14:52 +0100 From: Lars Ingebrigtsen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87lfdhgy2p.fsf@gnus.org> <87bledgxql.fsf@gnus.org> <87lfdgk9cv.fsf@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEXa0MOifGBZSUAX EAz////FK/tFAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+QMHQ4NJku/R80AAAGpSURBVDjLdZMBkuwg CEQx/wLCXCDABSLc/27b6iQx2f1WJlPlC9I0SPTfVYgqlUrMz31WY8aDZWKin71wLSyULdsnGA/n WGbjjzI9BSybj40ItrQB3kvF/wCGxR7+CyBvUTF+Ay1Dn7A/QdSivQS2F2gktRcn7xyt2HTDXxEq Ov0QA4he4yl2X0DNnC6EX4A7IEeQIQogbxBGJcMsDMBRIGQxKQBPAFPD/BtRVCkVwF5gYwCuGwJk gDwjYADTlooumgwQA3yQvNAnlQ2WjqOyThCkDCn4QLcuIfPAGRQlqMdXkgv0s0oUG14RnRHzrC22 CSqjNOydSTaTCeJr4gDwF2P1tH0kQSWlst0ghu0edfSWV+Ddmr9AdGNcCxUTXnNg1DDdGGo20wF8 /tQwaiiWBSro1IMXc+U+QdY1rADd456rg3Wujr3r953T9AEqBlcgt+CKPMCuSAtlv0ATjDlkcb8h ABbfW9ccelGBJNo8InzW0sZ4jUovYH1KDx9Gzq965TbaER3cxsmVPLz9W8CtKmwFy3VuRMtR7W7t gRE+7fdYIo4rQEs38QeO1Z37pdofrwAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMC0xMi0yOVQxNDox MzozOCswMDowMN5nY/sAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMTItMjlUMTQ6MTM6MzgrMDA6 MDCvOttHAAAAAElFTkSuQmCC X-Now-Playing: The Honeymoon Killers's _Les tueurs de la lune de miel_: "Route Nationale 7" Date: Tue, 29 Dec 2020 15:14:47 +0100 In-Reply-To: <87lfdgk9cv.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Tue, 29 Dec 2020 13:52:32 +0000") Message-ID: <877dp0u2aw.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: João Távora writes: > The first thing I notice is that the indicator is completely gone. > I.e. I can't see any flymake indications in the mode-line. Is that > intended, or am I doing something wrong? Did you test this? [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jo=C3=A3o T=C3=A1vora writes: > The first thing I notice is that the indicator is completely gone. > I.e. I can't see any flymake indications in the mode-line. Is that > intended, or am I doing something wrong? Did you test this? > > I tried with > > src/emacs -Q -f flymake-mode Yes, my test case was src/emacs -Q lisp/abbrev.el -f flymake-mode And I get: --=-=-= Content-Type: image/png Content-Disposition: inline Content-Transfer-Encoding: base64 iVBORw0KGgoAAAANSUhEUgAAAxwAAAB0CAIAAACAKqP1AAAABGdBTUEAALGPC/xhBQAAACBjSFJN AAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAABmJLR0QA/wD/AP+gvaeTAAAA EGNhTnYAAA8AAAAIcAAAC2cAAAcRgvL90AAAM6RJREFUeNrt3XdcFMceAPCZvcYdvfcqSpFiwYbY sKMxJuqzpBhfYhJNYkw0RqOJmkRNNTHPmFijphh77GJDbNiQIipNeoejHRzc3d7O++MOvDuOA2SJ oL/v5/3xJHA3Ozsz+5uyM5gQggAAAAAAQPtQkAUAAAAAAO0HQRUAAAAAAAsgqAIAAAAAYAEEVQAA AAAALICgCgAAAACABRBUAQAAAACwAIIqAAAAAAAWQFAFAAAAAMACCKoAAAAAAFgAQRUAAAAAAAsg qAIAAAAAYAEEVQAAAAAALICgCgAAAACABRBUAQAAAACwAIIqAAAAAAAWQFAFAAAAAMACCKoAAAAA AFgAQRUAAAAAAAsgqAIAAAAAYAEEVQAAAAAALICgCgAAAACABRBUAQAAAACwAIIqAAAAAAAWQFAF AAAAAMACCKoAAAAAAFgAQRUAAAAAAAsgqAIAAAAAYAEEVQAAAAAALICgCgAAAACABRBUAQAAAACw AIIqAAAAAAAWQFAFAAAAAMACCKoAAAAAAFgAQRUAAAAAAAsgqAIAAAAAYAEEVQAAAAAALICgCgAA AACABRBUAQAAAACwAIIqAAAAAAAWQFAFAAAAAMACbmFhIeQCAAAAAEA7cVNSUiAXAAAAAADaCab/ AAAAAABYAEEVAAAAAAALIKgCAAAAAGABBFUAAAAAACyAoAoAAAAAgAVcyIJWUKTtfvfdnalyQjk+ /+22hX1EXfMqLn8xaeWFeoIQx/PVX7fO8eY8S/eQvvHNlE9OVTN6/hPH69XNW+Z061LZ8ZRdDmuU GbveenPnQyVCiBv4zu4fpzp2in6jMnXb6/P/zFbq/pxynLZh9/yAVjbDtET0INE0o0AgkSGeSGHv JgkMrLEWPIHrIRJRbaJpXYGAliFKpOC7SUwCa3hPIiUsVim6OKc2t1BWXq2UKzFPyLW0NXJxFzma U9hwXpQf+2jG+liF7s+xUfjqo58O4UF70vUxeQc+mLspsZ5QNqNXbV02xMJQkYCgqjUZemzT3jQ5 QZTpgFde7mUgoqLjfpy5+EgZ0/rPxqbj1h78eKBWxaMT/vfSh4dKGIQQZTZ+7cElA+AutQqpufLV 7JVnyhmEKItRq3Z/MsQUd9Kk0nd/fmXhgaI2lBRo2p5limKr/Vs990ebVtJaP6dEdX0nZL/1alE3 k3+rkhVbFW/1LI42pbVTgkR1ZhOyXV4tEv47KVFU12Wk1qSmSlJSJRn5CplGVeL36/a/ty1b32jW FVRcOF1yObamrJ4Q7f+EMWXiZNJ7kMOkcWaWnbUxYem50+6SUXly6X++vanQyj0Oj28kMre2c3Tx 6uEf3C90UC8P8y74OKNcnnt9wpEPDuYx4gubd4/vu6C3gTAAHtctF5Xo7b8nSgnCHLdJs0fbwIRp Z8UURu6PrmAQQpjjNmHqIJ2Iysw1ICi49lGjSaqyk7Iqma56tU/Z5Tw7KAuPAHdzddmkrJ2MW3xW Vyd4rFjpnlSFSdMyLxXe2u+bGGO5aF3KaJcOv/t0gsfDle41VfqSLBVW7/dNjrF0X5di1ZEpITkX MvdcqM4sohWk/W2G4sHxzB0nqsvpZr6MMJL86suR/L6jzZoN03jW3YKCG2JMUleUmlZcT1AX0xHt CSEMLa+vkdfXVBZnp8ZfPb1vm8AucMzMN16bGGjVxUIPQcDMWf1Pf3u9VllwYsuhif972avZC4Cg qgWK5H27rlQxCGFhyLTJ3SG/Oi1Z0uHDSTKCEMLCvlOe171VXL+Za36YqXlnL61+btVFWZdr/Z7K y3l2YF6vOd+tHNrqMQI622X1p+53JYZCL1me/TfLaItNaf1MOzDlJNsl41P3GoMpYfLss5bR3E1p Zh2XkrL0yrRChoWCTuR3dqduuVLfzuAMm4bO+y604V/K9N/mvr07Uwntid4sl5UkHvtp4eWoWctX zgmx6kojFJR1+PSxv988VMjIU/fvjJ6wemRzQ5cQJBguA+ILfxzLoQlClO2oqeFtGKaizAbNXT6l e0uzNZhr4/1v3QOO58g5c7vRBCHKIuBpG3EjFZcORBYyCCFE2Y6cNtK2y1wfFobMWTnDv6VSQImc nGCU9FnDiA6v94yTtDzxROc5fb9FvP3DcmPcUSkpWe8paUVKSJ5T9hax/4flnE47XaZKZ8GZjB3t jqg6m07y3OF4Tlm9bJw9JrS8rraytDAnPSk25lpcjkRJECJMZeKfKz6q+3L9OyHmnbuQaBEEvfC8 37HN9xSMJObPQ6nDXvfRn4UQVBmizDi2/2YtQQhxXEeP72XUlr/l2Xbv07dvZ8pfyiX0PzNDn9I7 lXXiQEwNgxDCvB6TpvQRdqG0c628+/Tt2zXWs4J/Ve11t7+TOJqPfcqkZsSUgkFuTGmiw4ETFuJH 01a45IzH8ekV0106JEpQXncrTtJ+VJvUWE0pMHdjFIkOxScsFBopkZ/xKJteYe/SieMVUlL655Ga Os0UYsrGz2bUMEs/DyMLAaqXyAsyJUl3xDfu1tV2oSLTOZ47WGDt1s3btbEXGDpy4ow36/Ku/Ll+ w9/xYiVBRJZxeN0Pfps/G9mFuveU86iIPrvu36gjdPbx/TH/Wa5/0S4EVQbUxx05lUkThDC3+5gx PSCvOi3p7YNH02mCEKJMQ6dOcIMhHdD1Ef6lY7YVGstaMLf2xS/i5/eiMUIovCTULfDdny0lDb9A 5KYnTppOebOa2wEpqTxmq9BcYMOttfsi3rUXjRBC4SXmboHJP1sqG39Bblp20tTuzeoOHIbAmDJz MvbxNfPtwc89mhWV36YIjnkQWZQq0/g0ihc4vfubI0XChiSbmPJsnIyDBjtMLauOOlcv6kIjKp0U FroMeeMbT4fPFvwQU8EgxJRf3rLr9qBF/bvOy/TYasi4Ab/euihhmKqr/1woHfy8nZ5HDTx9mm9I JDdORqveqOB4DxniAlnVWTEl5w5cUN8pp7FTDb/vCkDXQKqsriRoDlMR08HZLwfTDaWbcXsuc6Kr 1lhLwTWbhx2xmqfKqiJBc5iKcAdnOwY3jk0xRs9l2mqnRHbNpq6D1hXZBTu9NM/n8x96ff+5z1uz HIf1MbbitzFnpVWXb8kfxYgY2w330oyoNPFtzMbOsPOC125ZwXWJ+OCNfiaqjGZKz+8/V9KVXq7B piHDQowxQojIEk+dzdWbdlWnhpYUpN1PycwvqZDKEdfYwt6lm39AD3tRu+IIIhM/vHs3Jaeoso7w TaycvHoG+buYdpmySSQ3z99U9QK5noMHO0NMxdSXZT5IfphXXF4tVSCekdDE0sHZ1aNbNyezNvaN SX1JSnx8Sk6pRMERWTl6+gYHeFo89vyXIvWfQ3F1BCGEBYEvvODP7+T5+DRTVqbfiEnMqVAIHf36 Dwp0NFK3njU5d2Ji00uk2MTJt9+AICfDHX+ltCQ7IzMnt0hcXVsnJ1yhqZWdk0cPv24Oxk+i/eiQ 5rFl8gcW9zQGUxBW9h5WrrUGhScZGlq3L1vUGL0o880Ti5GPE9s1/4FFrXZKTIeVc7VTYhFaV5wt agysSL65pBiJnNjPFuwywMGlfR8hS664J9X4RCPzic+ZCqEr9q+gbEdOGb7j1nExgxCpTzh/uXji FIObyTHS4rT7DzJySypqZYQrMrdxdO/R08/tsXZmUFTlpSan5RSWVdbKGI7Q1MrBo7uvj7u1oNV1 2bhvWB/RxehaQuj0qItZM2d7NflTbtrZrb/vPRmTUUlrDZ9iSmDbc9T0N+ZMCrJuIfFM4YGFr/58 l0YIcXu//9d3k20pReGNPZs3H7iSJVFqfCrmW/uFT3/rzSlBlp0/QiG1sZfvSAlCCFH2vXt3wZiK yd/73mu/3tf3rnBbN/9UFN86uHPXoagHZbImb91gysjKKzh0+PgXXhjq2fRZSSSRy6d8FaNACHF9 527/eYbZ/UM//7g7KkOzaGCuRY/wWfPffpySQaqv7juVq0QIIcpq+LSxnWOzx65QPrL+mDd3RypN EOK4TN/w29s9DVf0+lvfv7L0eBmDEBb0XrDru8n2FEJ03I8zFh8RM4iyef6r9b0urfr2RIaq1iDM sw99Z+2nz3vUxe749Iu/71Wpbzjm2vSb++Wq//gImzSe+YlXoqKir91KSCuqpZtM52CeRbeB46e9 MmNUd7N23WSmMnbrspX7kmsZhDDXPuz9r5dPdNe3cSUjSTv/dzubx8eG81JMajR7wpzaAD+d2ky8 AqtFf4skjYlTGqc85CAndseIsCzFRKmdEpMmKREGVnP+FtEaKZGynxJ2kJwUrdVUwkDr3mbQIPxr BEGhIaYnI6sYhAidfDOu+kVH/ZMLipLbB3fsPHjxvlimvYEY5pp5DJj40n9fCvdq5bxsfd61f/7a fzQ6sUiq8wjDlNDOP3Ts5OkvDu9u3vIjEZsE9/XlXYqVE6TMvno15xUvD93GiJq/7q/LDyubtGCE kZXcPbHxw7lL/kiStG29ofT+n0vmf7IzOlMrokIIEbn4/ulthxO7xNum8qSbCaqKR5kG9PJ+dtdT EUnCjg/mLt1y+l6pTN97zISpF6ffOPbb9nM5LY7jkoqYDQsXbzr3UKdoELoy5cwvi95edTxb3sbk MfmnDlytYhBCmOsxceoAY2izWolyGxMRyMcIIaQsuBAZLzP86zW3Ii+XMwghhEUh44Y3WUugSN+z +qvGiAohRBTF1zZ+uevika9W70mqenTDCV12a+va3fd1d6Cm727/cNG67UevPSjUE1EhhIiiMv3y nq/mv77s7/s1j70GWll67adFK/aqIiq+65hlP3ymN6JiKuN3f/xf9pvH1t+f3GyhZo2ijKWu1rq/ xHWROmvNy3Fys43Ynk+h6rOFWhdpLBU0SQl2kQq0U1KfbdQpV6oTRU6O5vow7O5jYtQZE/rU4vv0 bOjREzo1KUVfx58pv7V54Rsfb4m8VyYjTeofXZ159a81899aczqnxScGkdzft+K/r6/YfCq+UNr0 EUaYuuKk87vXzP9gd1prQhNsGRjsrkq9MvN2rJ7ZS66qvcA8C/eAXgHdHMwFRCrOTYmLTy6RMoQo K+J++2SV8H9fT3FvXVjBiKO++2xHfCWDEMKUwNTe0cFCiGU1FSWFpTV013l7VZmZkKReAUp5+np3 yVezBHbdg4J5j8oJqcpOyq5s2wYvjPjC+s//vKfOCiyw9enTx9/T0dKYR2S1VaW56Sn3k7PKZa36 UKY86qdvMrNlBHNMnIP69/G2N0Y1hamxN+8WShmCCF1yZcOKXxw2LQhp/UbosoSD/zyQE4QQFvWb +hxsON4GlO3wCf23xV+uIYgRXzp9862QIc2GpKTy2ukY1SEWlMXgiLAmPUum6l68xMw7/PkwT0H5 3QuRt/LrCSJ01v41m5RKyjZozMi+TpySO2cjE0poQui8s6fiX/Pvp/9cE0zxzRw8unl7utiYmxgb YUVtVUlOSmLiQ7GMIYQuu7n1k9WCDetecG9zV4cuPP/tkq/P5ikIQljYbfKnX707SN/bR6Q69tfF Kw48rG8YdGOpeWxLzeOXlGrt9omtZU2TSlnLrLV/WFosYFAtxWpK5KVatxtby/hNvgBby3jaP1QU CxDqhC/OKWVFpRoZS/EcHblYIU+5VhJ9q/phbn2llCAex8xW6OVjPmCobS8XDgx+swububpZUqp4 hKnJzSljBuhMMMiS/1ixau+DhkFvjqlzUEjvbg5mnLqynHu3Y9PFcoIQkeVd+H4p13jjx0Osmnti EEnclsUr9qY2dPYwx9TZPzjA28XahIfqq0vz05MSkwtrlIQQhbx1wz2Us093EyqtkkFEmZZwr26K g06zyUWYZz9o9uL3poY4CDSbyJRj//vylwt5MsJI4rZ/f7jfj9Na80pVXdzvW66JGUrkPnTmf2dF DOpu1RCOMHUlD66c2Pfn0S5x10llamqxKospK0+PLjBdqefe24xY+P0IzUZOdfZfWz6DyTqx54pq fIIy9p++avV/Q2x0Hh9MXdG9K5FHDt5uMZ5hSh5mIMy1D5u3aslkX9OGPGUq7/69dvX222KGEDr/ 2IbfR2ybH9S6U8QY8YV9Z4tVybMfPS3cGpZFtKltMw+dMMTq6ikxg5jqmNNXKsLGNrOfHVMaHRmr Hri1HxERou99HY7LlC9+mh9khBBinvf7dM431yQMIjStFPV5b8O3LzhSCKGZox3fe2N7Mk2YyqTE HGU/nf10eJY+4eMiRg4J7dvDRtA0bEs+8sPnmy4V0oSpit3+69mha8Zbt6ViyrJPrP34x8vFNEGI Mu05c/Wa13vr3SaHKTn77ZcHVREVq81jm6oer0J743JsqtDT2eArzIQEyRv/A66t4MnZfaub4Sl0 tlA3VXD0pYSrnRJlBY9BqPN1cxTyyhrNfOWayCp2r8m+lKsxfC6jy/Mk5XmS2KiibqM93ppiYQXd NRZRNnZWFFIN8jAlRSUM0gqqFGl71v+RrIqDMN9t1Pufvj/e+9EGbIri67+tWbf3bjWDCF14dsOv g4OWDdFfk0vPffvFPnVEhQXOYbMXzn9RqyojhOQlccf/2P7H6arWpp7j3s2NQpUMQkSWnpxBjwzU rm5c+/ClP30SrjuYT5n7PL/sa0oy78eb1Qypu7d3762JHw1ocfMfZeq16wRZ9pv39eop3bUX/lFC u56j56weNqGotgsUT2VOZq46bKUcXR5n00VGfHTx6BYjSN6Ajw+uG9dpT6hjyhLislVjsxzXye83 jagQQpTQIXD07MBRL9FMKyak+d6zVq940UezVFMWgTNXLhfP++hwrpIQZf6Jv6NmBI6zakWe0BlH D9yWEoQQ5vtNnhLcNc9zJZIzn4w5YzjbjMd8eXhZKPvjpcI+E0Y6Re7LYxCpiz19sWT0C/b6yjpT cCEyUU5UDcqocQH6XgWg7AcN81fPolBWA8P8OTE3GIIQ5vqPGO6g/lSuy4D+br8lZygRU5iZXY+6 a/TxOD1e3fSXuVmzrxlQ5r4vLFtRkrXg72wlItLYs5fLxk62a2XVJNK0A6uX/nqrnCEIUxa931j3 +Qxf/ftkEsnVbVuuqcbaOaw2j23DrdEe5cFCpRAjUmtyerfbxQzKrm/+7KkVNkhpLEJI43nASLm1 DGJ1ET1XqTPeJFRyMEK1JuLdbuUZFL9vvtPUCh5SUtopIVKukkGdbpiH1NK1miOAjDz6t8zqaqJ3 sJ0wdPqZh9/VdVv6qoVZV+iydY3nDjYxbfxyIqnUPseZVF/56/BD1aaslFn/d9YuiXDWeu7w7AfO XfOpdP6yo3k0QUx51B/HZg1+ucnSJkQk17dvvqrakwTz3Cau+mHhQD2buPPter/44YZhw8+mmLQu QyhrF2djKrGKQYgpy8qWkEDtvij13oIRzTRMHKfxc55z5SCEEFNx5fydulaUV4ZBNqM+XK4bUWle gENXWKUuLSpUH3uEeda25s/q8C+pEJer2xqOi4eLoe4v5nJbjqkoy+Gzp/VoGvtg4+BZM0JUZYbU 3Tl/tbwV04mk5ub+E1mqzanMw6aOh/czHwPPb9yYblyMECLypMhz+l8RVmacPZtKq8ZtfMeO0T/H ynFydeI8uqEODuquI7Z0dX3UelP2Tqrmhigryiq0vg0LDURUagKf8KFuHIQQInT6g9buHkAkSb9/ svjXm+UMQZhrF7rg+7UzfZvbeZwpitwfrR6ctR7JavPYtrpHyeXaI1VcwiX8qO+Cv9tnd/O2zfEt gcv3mCgx0a13ckrBdkpIk5Rgwi//Ljhrn131bZuyLYHpe0wIJlSTlHTG9R5Ewcg100XoqmYiqoZf IMWXs/fEdqHFK50eFhg1jkQTZX2dZoklVTFnb6jXm3A8Xpg7wVnPcweb9n1t9iATVVNCPzx3Xk9b wJSc239RvQyU6/bikncGGjgWh2PdZ1xoa7dNwla2DZMiTHFhsW6jSQ0wEH9zvQf2VzUpTE1SfDrd im/j+r74SmhX2npefzWqKK9smIM1szB/Zkd+MY/PV99LZWFeYXvfMKDM+g/vq783QFmFDlOvmiby +3futvyIYorO7FM//Dgu46cO7hL9yM6Hcm9Yrk7o9LNnU/VUcvrBmfNZSoQQwka9x4/SP26LuWbm GnEKNjFT32jKzML00V9gIxMTHkYIIaa6qrrtK6ope0d1kEPqy0qrW/GcYypjtyxZuiuhmkEI85xH Llm/6nkvgYFidfniA/WgnMuYF9htHttGqZM9HEIxxnGJXPWPCZURZ15BCEeneVJi1jf+IU1Sghhj SWLDw45QdXHmNCGoSUo6ZRzCEL0ZhDlclwDr4eF2YX1MrHUKCFHEnijJh9PK2Wt2NEotUSo1A1bZ vdgk9VpGrnf4CM9mnr7YInRkiPrVP2V+3J0i3bvDlF2NvidXT/z1mjrVj72JDGxh1RDjMJXiJqdO cw1OvnNc3Jw5qJBBiCnLzaslgS2FSxyfoUOeghPKSF1t48I2gRH/cR7XlFnoW59N68Fp6bfcOvNW vZSTt5eISq9mEFJmHd74R/CKl3q34xVyjnfPZks2NvP1d+XcSKcRIrLM9FzlcB+DeSe/f/jwXfXx yb2nTPbpuqe8tOLsP8y17tZR759SdsMj+m+Pv1xDkDL3XOTdV317a48XyeIjL6oPVTQZMH5oM709 LBAaUZr/NFJvUYUEQqHW7xkJMJIShOTy5kZU6MqM+Nvx91Iz84rFlRKpnGaYxqEEpipHHdsTaY2U IIPL6Iiy7NpPy744mlFPEMICj4mffvP+YFtD5YrUJiWkqxdTmgf39ma3eWxjddHJaSVmqHo3J4LL VcEKsXKTmiKs1OnrcAjrDTBukhJE1Rs5EVSuumDCc5NyEEZNUtIp2zaMmyYLi0wmve/9nLd68y1F iXjXD1nXSx6NYCnzKm7lOrq4d/auWxd57jAaPQbM4Wgs0WMK0hteIaas/HsamH8w8gvoxolKoBFC yqy0TAVy1nq4yO7fTVO/hsf1CxvI5uHNWCBoGGgjMmmtEiGtxw934cKFhtqYyuyGJqyqooqgFloN yrK7j/1TMAtDlHTjokUu7/Ge1zybbsG9enXxrRiM+k4Y63T+QJ6SIKY6fueiWUe9+4YODOkV6O/b w8vJvG3hJmXu7Nz8rDVl7+zIwek0QYgpKSxRIkNBFam8vO90gepJbxM+dZRdVy50T/jsP2wRGtGw XL00+vTtub1DNdeh196MvCxW5bTVsIiBza7D4GiPmDz6J7eZ/0DrCaoUxbf2b922PzqtshWTLTRt eJ6LiK+u/+B+fEHDkbm0nHD5LRQUpiAnr+Gr629vX7zwD4Pf0LbmsW23heHzCEKPPpHQmMZ1kxal Zn/neTET2/fNe39OhQCZ0zqhDJ9huShhBjdJCcF1totS67/zrMjE/L55bnMqKGTONElJZwxBMJfi 6qQLU90mekz0fvRjnp31S7MkKT+VlTc++5n6tIcK4s7v7FFVl3juEJlMRhozn2+kUWJV69YRQghR Di6Gdh2krJydjKmEKgYhIistrmCQg8ZvM0W5+eppXmzb3duCzScE5vJ4jeVAqdQdo+YmJCS0Lhvk 8pbP86as7bvQ8YgGMo3DbYydaYXiKbiixyUImrPijYfLtsZVMAQhIi9PizmeFnMcIYS5ImsXb7/A PoNGjBnRq2HrbIO5amJqaCUg38SYj5GMIERoSbWUoObbLyb7xH718cncbs9NCek6h0d1SqK+EeGO kfvzGcRUXjt9rWrQqMbogFRejbxWrT4BaOS43s3v56PT/6co3OT/qX6PUrcQjM5CFiK5+/uKFbvu Vrdy0w/CMAaXwiBlQUKc5u8rC05+uz5400pDITipbJz4Z6SFyQmFrczCVjWPbUMbGyNUqfEV9Zw6 gkw9ihZvLFr86Lc4UqnWn1Ei2pjlNpjmaKcE1XOUBPE9itw3Frlr/BajnRIsojvlZgRGlG4p5hj3 72ekk1Shn3VvS/F58aO7WlIoYxAf3gJkAampbtxpDptZmmlkqrxG0hBvUWbmpoYKEDYzN1W/GkEk 1Tpb1zFVFVUNwZmVjRWrBZHQikfL8jgc3Qi2Dd/VmjbDSPBUnBGCRcaixuG9evkzvUJR6DPj663r 353U20mk9XQktLQsK/HysZ3fLJo9e8nO2IoWVxxgnsBgP4/fWHgITRsaqZDGHjyiGtmlTAZOm+gB 7Vw78fzHNyxXr70ZeansUfe8NPrMbdUJQFyvMeP8Oq4DzJRd+H7VrkRVRIV51j3HzVmy7udd+46e Onv+QtQjJ5YP5relRcI8pxFzXwtVvR3DiK/89PU/OQZWPxGF/DEXJLPdSFAKSwvtHXKreXr2GZXz quq0qqXIUsFnOyU87ZSgap5SX0po7ZRQlorOGFNhI66JdjmmTIXO5k1+jyN00zpkh9RKaFhVxVJt F5c2NjKUrb3to3JCaMWjCsjlGG5wuDzuo7EP3VpNKxq2BcV8PrsDjEQmkzcuDzJucnQWNyoqis0C i5+K5cLY0rphd0NSXVGpZHffly6Hax384gfrX5gvzkhKSHqQnPLgQdK91PxquXpIgShKbu9evoT+ fsMbPQ2NGRG5zGB8+miRjfYsu26FLDm/77yqSlIOY6cNtYQV6u1GuY8dH/BXeryMEHnC6fMFE2a4 UAghpiDqrGorBcwPGD/areOekfSD/TvVG7ZTpsGvrfvipZ56O6lEoWhD0IONvJ5bvm5BmG21W8G8 lWeLGcJI4ras/cN/w2u+zew7yuNzsSpC4g/57OjnI57YNh2U3N6WYI1gjYgFYgbpvHrJiAVi7Se9 rb2MYjslfFvt8E4sUDBIqJ0S1Q818e1lnbM541uaY1SveU4NR88KI8wRiTBGj0ZDiZJAUMUKIsnN qWgYjhK5uGsEVVgjUEK0kkbIQBdBIwDj8nQf0VxeYx9dLpdrzV+3O/0V4obxbMrSqsnMIryGrg8W Ojipd34gCnFZJdQlhBAWWHfrG/78y/OXrPnf7sNH/9606q3xfhbqGkBkD/f/cizPYEaRWomh00Xk NTWyhg10TUybXUdJpx452HB8csALLwR0zc2pOhvKbkREP9Xp64qUM2dVLygrM8+dSVaotqsPGT+i A1dL0imXrqiWyGFB4GsfNxNRIa3puZavyXH8Z9+/H2bHQdhy8HtLJruqxuJkqX+u2xLbzOEy2Nyy oTvF1FRLnmTFZ1zd6jVzgakV5YibZFyeSOulNKzU+StWUmLkVq9VHWtF9U1SQvJEMu2U6P5V52nI HGy1n7BKou/FZqKzWIbiUTAmzgp5yr30xpNAewR011wEyDMxbVgEzlRXGayBpLpK0nBPTXWXllDm lg1bITHlpeWs1mRSXtYwLUzZOTpAUNUqHFcPV3UFYgpyCiCo0oUFtr7DZizZuO3LSR489U4IKVdj ig3lFFOVn9/8QWlMcX5hQ0WzcWjuFS0iuXbgpPr4ZIuh7Ts+GTeOhimZp+AOt+9ysMXgiDBVR0KZ ffbMPQVCdHLDVgqU+eDxYRYd94QkNVmZpeqdabwHDzIQvclyMvNbu7MHZePp0XDyMjbpM3fpTG+B au+I3H++2XBJrC+TKGd3Z3U/gcnNzHmSxYK4+Ei0Vkcpje8l63THcUaSmVT7qGMfb9bPViUCHwlH OyU1TVJSl2Smc+iyyLtznvKKOS6uWvv1k2p5edOFs4xcXKG5aA+bmXOfpUHxjmseZXev3lZvp4K5 Pfr30ZproOwaZwOZwtxCA9/MlOfn16o/hm9rr7P/JeXg6qye9COl6ekVLF4CU5abp651lI2ne5OF whTru6s8HQXKooePg+q5zlRmZZZDVKUfZd3/9ZcGqBep69sHTYsyPelBczMCpDr5fp6qEcYCj26u +oMqJv/Uvsuq45M57hOmDmzPnsBYKFQPh5GaakmXXzfX7ssRhUSMVHW6mOKo03fq6uMjo9QvWNqN GN+vI18GILU1DZtcYxMT4+ZvquzujXjpY94qI79Xls0JFGGEEGFKon749mRB04c+NvYP8lJX/PJb 15OfZPPI96/sqTn3QTh3oq20tuaiTa5cFWpeBMepKti+A6q5f6Wxdkok0Va0dkoqr2oduoydqkzt UeeEnbubaI6EE1lNcoZuy0Ukkgd5mjEVtncyeobGIDqseWTKLhxU78mJMD9g5FDtkR6Ok7eX+ouZ ivtJBjYHq7t/t2HLT46Ht6fuO68Cv8DuqiiY0PevXBez9wxXZmfkNByG6+3j2WRpEHWhDAIGPTie QQHqKQgmIzlN/oxnh4G6JxBpLK4wHOMw1beib+ufASTlMdGqbacQ5vn0CdL/YJUlHGo4PlkYMvV5 73atdKMcnNVDIkzVw7Tirl4N2n85vJ7jxnpxMUKIqbhy+nxUw1YKHLfR4wM79gUUgVHDLC4Rl4qb a8GZ0vOHotvRweF5Tl06r79qUoCpuvnL2r8fNqnYlFPY0B7q7UmLIv9+ks0jNi8fEqzUqAhYcsX9 j7vchuyhco97Hs3VGnJxGlzWIWeKm5dbBGsGb5i+4l50t7H6UfXHPcu0UyIYXCbstJNl/B7mPTUP wWXk10+WFWteIFEmnyh+oDl8RQl9vDnP0EhVBzWPdN6pH7bdrGkY5wn/T5N3cQUBfQPU3XT6YdSF h830a0jF1XO31R0sjlPv3k3mLCjb0KE9G/aTjjt44D5bK/yUucmpqgvAnO7BepYRU798fTijhW+T Fd05HpXyjMUVgoD+vVQBM1OblJD2bA7oMeXZGWLDO0pI42MS1OdVUo4uLczGMRUXd+9PbVrcSG38 X3tUb5khbBQ0MkzvxhxEHHXgrGrjXMp21NTwdu7eQTn0DFAPNCtTIk8kd85Vtf/m5VAeY8YH8DFC iKm5+svP6iFBrk9zJ9Owl3YLF1f1Aghl1qWL+ttRRe6JH7bdqmlXn5njGPHR+8NVBYdI7+9euyNR d+CLch43LUwdeFXHPNHmEcuHTCzTXAZLaOODy3ut3eV4Icph34agD3+20lxzgvmSiPGSDnmlBsst J5bxNOsbbVy8vFfmLsfyKIfiDUGpP1tpvRnHl9iMl3RIBEIqSr+bFzt3rsb/3rp3KEvrJipuZ8yb q/U7b36YfU+zUAnNw0K0tiyTPshdv7HgZnp9ZbWiLLf6wu+pv1yo13zFkedp1df+WZr9Y795JPX5 13YsW/hjjLpfRFkOfmNO/yaTZ9h80Kj+Jg2tweEtJ/L0NAek+tZvv1+vVe/t6TkyvHvTFoqyHz1l mJX6UKycQ99sjDHQIWMkyZduF7YmdGTK7yaoB6o4niF99ezPwq2M3bRwYe6892eP9rXUqY9KSfbt qDNnTp2+lFIz4JPwET5PxXYJrSXqO6SvcXR0DUFM6Z24HCbQq23PcEVp2p3Yls9oxxwrryDP5rYm I3RZemwstxUNJWXpFezF9rGKTMaBxSuuOw9/bsKY8LBgFxOdq2Eq7x/89vtTqtUwmO83eEBLcQ6R p/+1co35qo8m+zYuRWaqkvatXfNPnqoJoxzGzhxpq+9jlBnHD96sVb1x32Pyi32M2nt1XL9RI90O /5lFE0Jn7V+9ynjh2xNCXC14XXSMn4XLoezDx4fsSLhaS4hCqjpEF/ODx4Z3+CEJXP/QAZbHT4oZ ROiMvWs3eK55b7iTRnNDl8Tu/eGbnTcqCJfLVdLtOIaNsh7+/uI7yStOFNCEyDMPfLUxaNNHoZrr xbDF0Llv9Luz/kYVg5gn3DyaDMqe7mez+R6n8YKZGpNzO33O6atbdmOynnPpqGlszqBsez+bvHsa TUCNSflOn3J9KeGPybLpsJQQwhDDi3wIITo7mGHdLc0o37EOPtdzHtQ/+puyxILNiQXNlBp+/wjr rrHDMCvPnXa3J0QmznmYLsOEoWW1FaX52Wn37ly7FpdTTTduReAx6eMPR+tr6bH5kJmTPa7+kUET xEhiN33yNfezhRHejyYvFMXXf1uz7kTDE8NiyEuTPPWlCpuGvj530M1vrlYyiNC5J1a9V/XaB/Nf DHHQfrlJWZlyfu+Onf8UDvthcIhji1dWk3A7hVYfLj94sKueL+YiwkiSj3wz/+QWj4Be/l6OVsYc RW11RUluWnJKdplUHaw/U+FUwx0ZMHKA2eXzVQyis69cy3nZy6MtlYqpjtn8cUwrvkY4cvWRFUOa C6qkt7YtvdWa7+OHrfjni5ENB4Iok/9eueV6jXbTQ6qy1f1ppjDy2w8TdA695nhMWrogvEkpV5Ql Rf6WFLlzvalTN18fbw8Ha3MTAamvLM68d/v2g+I6Rj1n5zbp9QmGzzSm7Lzc6rKyii9vfDfun+AB fbwdjImkKP3OjYT8WvWncJ0i3p/TW6jvr2tvHDiWodqcynTwtAg2Xu/ndp/25pjzn54qVBJCl1zf 9sn17Zh6tCkIP2z5odXhwi5TYlm4HGwRFhFmGRPZ2KXDon5jh9p2/NNEGDJjRuDFTQlSgogs6/jn /725f+CgYC9bY1RXVZSZcDM2TSwjCIsCZkwS7f37Znv248VmA+YtnXp/8d4MOSHKwsjvvg/+ZfVY zcXxlGPE0k8yFq08nFFPnnDzyJFOWZR1fYFXfE0LoyRcl8IP5pYb4w5Mid2irKoFXpKWUoJdCt3m lnf2mTLKzvaVqVVr/6xqeegTY7vBblODusYqdXaeO+1uT5SZB1e8ebC576bMe/7nk1Vz+zf37gvP Z9biWTc//D2lniAizz33/ds39gb17+1tb8qpE+fcu3U7TdywWTrHbsSC+UOb+yDKbsySFQ8XfXog vY4gIi+4vGVJzB5n/16B3s42Jnwil4jzM+/fvZdTqSCI49Ka/CU1ty+rXz7neo8YrnePRC4PIwVB iCgqM+MuZsY1kwtcPu/Z2w3IuH/EcNuoI8UMojMvXc6Z5eHRZcYwiCTvXkJCs1tBkPri1MRi3aIg H2hgiJcoJPnJt/KT9UV42Mh9zOI1bwa3sJaZshqxYHrB+rWn8xQ1uXfO597RLWS2g9798l39R9gy hWcOqFc3cpzGTx3CzoEg2GzQgi/fq/pk47ViVd+DEI0uLcN0sdXrbFyOqF9EuP3ZA+qBcMo8dOxg i3+j6nNcX/zko4yPvjqdIyMIEVnJ/egj96O1rk7o9fzyVdOlP+xr95eJAucsfSXx/R336whiKq5t /Oqgz7fTPDRGorBF/3e+/9rqqzW7bpY84eaR65m76nPu8lVu96ubPZ9Y4FL84br0AWYdXLw8c70+ 5z5c5VZT3fxhUy7FbuvSzTs4Jexcjv1wr/flGZsOVlUYeEsRUw4D3Re8bPEsntfeAc0jFtgGjJrx +pxJwYbPkDXym71mVd2KLw8m1zAIEaUkN+58rm71wzzHIQvWfDTc0PwINus777uvLb9a89uNYoXq tI68xMt5iU1/EfNasVs+kdyMviNV7dwXOH60q95v5m5d/fqeAycuJTUMOWiVJ4GlR2DIoCHho0eE uHedHjtrBMGTIrqd2JlGEzrjTGTyzLf8n7E9QDn+/1m2yPbKtRu3E1MLJU0nXTAWWPuGPTfz1Wlh bsJWtDqU9dDFP5o5b/jxr6t5Uo3yhrkW3UfMnPfWlF7W+su1/ME/hxLrCUIIGwW9ONmPvdPNBF7P f741MPrwgVNX4lNzSiRyZVcLpVi+HJ7/8DCHQ/sLGIQQZTN0bL9/6wwgym74Rxsd/Lf9svv03VKt XWIxJXToM/G1ea+N9hLVnWPly/jdZyydG//OxlgJg5iahO1rd/X86XV/zRllyiLopXW/hV059OSb R/Pemes3V+3f6nXgkkmlzt5Jwrq+E7PffLXI2+TfuEfc3pndN1eVbPUqvmRC6yx1EdaZTcx2frVI 9K+khA2Y4zXWe2UP8cmjRVeS6qWMbuNm7GQ+bKJzRD+h8JndX7id7QmmOByewNjc2s7B1dPHv1dI 6KA+nhateopS1gPmb9jS98Bvuw5FJ4t1do3GHFO3fhGzXn95tLdJi/cGmwfOXLtj8NXDe/afuJRU JNW5AkwJrHsMGvvC9Kkju7cUVTFl0adVS1Ao87DJ4c0M4eOoqCiEiKwiJzU5PaewrEoqZ7hGIhNz Oyd3Dy8PZwvBM71fNak4+9nsr65IGETZTFi3e3H/ZzC0VJWmenFuRmZOXkFJZU1dPY34IjMre1cv X18vW6HB8TsiiVw+5asYBUKI6zt3+8+z3CiEGGnhg7iE1FxxDU2JLB09/YIDvSybD5RI5fnVs9dG VzMIUdbjvtz18SDjZ7lQdvCdztu74L+b7ykIQhzXGf/b8Zbfv92ToCX5KXfvpReUS+qUXGMLe7fu PXt62wmf3DAxC82jMnXb6/P/zFYihAXDVx1bOfSxugV0lej+XbOMAr5Ehnkiub17TUCAxNboSWRJ laj2rlldAZ+WYSySC9xrjAMk/CeREpbKXE195kNpQam8pp4hHI6JhcDJw8TLkdv2sq9M/23u27sz lQhho/DVRz8dwuuymdJZWiRpUWrSg4d5xZW1csIVmlk7efj09HO3eJyMlVdmpyanZxeUVUnlhCs0 sbB38/bx8bITtap1YXL+euf1bck0wVyPWRu3vuGjv3iofooFlu6Bg9wD4QbqwJbDX5r01/W/smhG HHXg/KshE7vGakXWUUbW7v7W7v4sfZrIsedgx56trVQ5Jw9ck6jeRPN6bmp/iKg6EJ12+rR6F3Wu 99hxPk9gbJZr6twz1Lln58mTTtM8cs2lQWHSoM6QJeZSkzBplxmTajlnTYy6Bxt1h/rfCVEiB9/+ Dr792fgsvoV7wED3gMf74/r4Q0dTaYIQZTropRd7NNs0PtNn2rUGz2fqa8NOfn6+gqm7c+BI6ti5 vtDz+HfV3Tl4JFX1mDfuP3WiFxwV0XGI5PqhUzlKhBDCgl4RzawZAO2hSNj18aIj6hEuynrYO0sn dZ3FmkBfpYnZ8uWBVPVsKKkrLIKtH59CTNn5fWdLGIQwv/vU14ZbNT9GDUFVS7DFkDkvB8dsjJMq c4/uOjd5zXhbaAL/RcpyuXPEK7MJQpjnPmSENRyf3HFkKXt3XlAd6ECZD540Ako6+whTkRFX0fAv yrFbDQOnhXVtirK0uDt3FJART7P6u3v23JIShDmOEW9N8TIUOEFQ1TLK+bl50yPf3Zkqr7n5+5/x wxb2EUGm/Gs4zqHTZ4dCPnQwWpITe2zzD3tVu1ZgruuEqYNMIYAFAAAm7/iOkwUMQpR1+NuzexkO AFQL1QHoIHoXqoPO0lZk/vnee39kKIlSLqcbX5fGHMeIL39dNPBZfI0cAADaA0aqAHhmEULL6uvr tY5149oNevfL9yCiAgCAtoOgCgCAMcUVWjr36BUWMX3ayO5mMJwIAACPAab/AAAAAABYwD1+/Djk AgAAAABAO2Hd87wBAAAAAEDbwdoJAAAAAAAWQFAFAAAAAMACCKoAAAAAAFgAQRUAAAAAAAsgqAIA AAAAYAEEVQAAAAAALICgCgAAAACABRBUAQAAAACwAIIqAAAAAAAWQFAFAAAAAMACCKoAAAAAAFgA QRUAAAAAAAsgqAIAAAAAYAEEVQAAAAAALICgCgAAAACABRBUAQAAAACwAIIqAAAAAAAWQFAFAAAA AMACCKoAAAAAAFgAQRUAAAAAAAsgqAIAAAAAYAEEVQAAAAAALICgCgAAAACABRBUAQAAAACwAIIq AAAAAAAWQFAFAAAAAMACCKoAAAAAAFjwf+H5cWvJpz6aAAAAAElFTkSuQmCC --=-=-= Content-Type: text/plain -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 29 09:18:43 2020 Received: (at 33740) by debbugs.gnu.org; 29 Dec 2020 14:18:43 +0000 Received: from localhost ([127.0.0.1]:38075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuFpi-00050a-QV for submit@debbugs.gnu.org; Tue, 29 Dec 2020 09:18:43 -0500 Received: from mail-wr1-f52.google.com ([209.85.221.52]:35045) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuFpd-00050K-Vr for 33740@debbugs.gnu.org; Tue, 29 Dec 2020 09:18:41 -0500 Received: by mail-wr1-f52.google.com with SMTP id r3so14799769wrt.2 for <33740@debbugs.gnu.org>; Tue, 29 Dec 2020 06:18:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=rZDJLQQx8CZBY4tzLbV8n3hkV0GuVUfroCxcB0tvOHI=; b=WIeunH591sR8Q46XoCkAQVmbQz+meoUn45bkJi482RkSAq5/z2jzoThP+ZMrLghnln SgJlfO5i8WQKzx8SlghSo1Ee5aqDKXmuLLlctOWAyxISu3f7oRIvnGmLfQvJC40Tb/Qv j+Em01QIp+iSVLECSqFI/QluawuLfE0DD96cR54qpglhkxzx+jvC9d1l6BgdKjNDHak7 5A7x3uqDFfDVB9JOvIQTmbTwqWU9jQE2UtDEhOlSl3TKaksim4xr06V/K6cwLf1RhwAZ y1GNbLSA/iq51Rw3/dCdc3PKmycB9OG1sK2LxiVgRhqmKGueg0FllmaKS9T4VIEscgeZ Kbxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=rZDJLQQx8CZBY4tzLbV8n3hkV0GuVUfroCxcB0tvOHI=; b=OGHhkbAvI2cAX41b1PYzI7TPGKRjcuBhTEUXkzb8nXybKJqc0J5SWgVR2RFvSqkecs n7V37GWKK9IlCZCTqbVz3azpUYVh1GF1aLa04Zma4hgEU9D2prRTeoc+5uyF3XbP9cjW Q8861hLy9+mwZSDQNBdrpmqwD4dZPFPlYOTU12a380JMp0be3TE+W87vc4FwaKiDqTXN w+SoJsQ002ylP8EF1XoCxyXlCSOxAO5qRj/YWgFednshhd07TiQpiFGvChu497E1o5nP m9pLD/bIROMJc91LJaqYU1wXqfOJyJmQ1IGDKtJOW7Hf1rqIpm/uhHHDaU5kEtyl877q VkTg== X-Gm-Message-State: AOAM53356de5N5Tggs+rCuqiKFz+RfO+CztpR7+C0KAj9naayHVLECV7 ArAbqfR0bCxZgT2xOX3SCYw= X-Google-Smtp-Source: ABdhPJymvQXBQz6tU4xLyL1gDNhEitlXcA/Skq1tOv6EaIfUiCC/yy/5J7h3+++UcEFVJHmFvw0g+g== X-Received: by 2002:a05:6000:cc:: with SMTP id q12mr57198316wrx.335.1609251512113; Tue, 29 Dec 2020 06:18:32 -0800 (PST) Received: from krug (222.201.137.78.rev.vodafone.pt. [78.137.201.222]) by smtp.gmail.com with ESMTPSA id r2sm61278190wrn.83.2020.12.29.06.18.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Dec 2020 06:18:31 -0800 (PST) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Lars Ingebrigtsen Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87lfdhgy2p.fsf@gnus.org> <87bledgxql.fsf@gnus.org> Date: Tue, 29 Dec 2020 14:18:29 +0000 In-Reply-To: <87bledgxql.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 29 Dec 2020 03:19:30 +0100") Message-ID: <87tus4g0ga.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Lars Ingebrigtsen writes: > >> I've now altered format-spec to (optionally) return a list of strings, >> which makes the previously proposed patch work, so I've now pushed it >> (after rebasing it). It seems to work fine in my test cases, but it >> hasn't been tested extensively. > > (Jo=C3=A3o, if you could have a look over the resulting code change (whic= h is > mostly just indentation changes, but also changes a lot of the quoting), > that'd be nice.) I've just reverted the patch: it is seriously flawed. I don't know if "format-spec" allows this, but the previous indicators semantics were to omit some counters (notably the notes counter) completely if the count was 0. This is why when opening the *scratch* buffer, which has 0 notes, the function you touched now exits non-locally with an error. I'm not sure you've taken these details into account, and they're quite an important feature that I don't think we can afford to lose. So better put the patch in a side branch and decide if we want to overhaul format-spec to allow for these things, or maybe just use the more powerful existing mode-line language for this, perhaps breaking up that big function into well-behaved pieces that users can compose. Thanks, Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 29 09:22:31 2020 Received: (at 33740) by debbugs.gnu.org; 29 Dec 2020 14:22:31 +0000 Received: from localhost ([127.0.0.1]:38079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuFtP-00056Q-CG for submit@debbugs.gnu.org; Tue, 29 Dec 2020 09:22:31 -0500 Received: from quimby.gnus.org ([95.216.78.240]:54662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuFtN-00056D-6s for 33740@debbugs.gnu.org; Tue, 29 Dec 2020 09:22:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9WZb9DXolvzOULf3O4aGlu7CHDhT5c9/3act90CW6Bw=; b=emsDnFXQTFSUOYJFkSPWg6oGcD JD8ITYVn6iw4Hghp3oCSng/z0tpvB0tPaxuvHczZnAS3qig76G/wwh4rqjXQfYbhxfXGS37o1o/Js L/jUwJWO4mC7strYjFks49WC0bcP2D+2phhall7Xd4Af6+wyYLQUBu7fKyr4gF8FjfEk=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kuFt9-0002PD-K7; Tue, 29 Dec 2020 15:22:22 +0100 From: Lars Ingebrigtsen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87lfdhgy2p.fsf@gnus.org> <87bledgxql.fsf@gnus.org> <87tus4g0ga.fsf@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEXa0MOifGBZSUAX EAz////FK/tFAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+QMHQ4NJku/R80AAAGpSURBVDjLdZMBkuwg CEQx/wLCXCDABSLc/27b6iQx2f1WJlPlC9I0SPTfVYgqlUrMz31WY8aDZWKin71wLSyULdsnGA/n WGbjjzI9BSybj40ItrQB3kvF/wCGxR7+CyBvUTF+Ay1Dn7A/QdSivQS2F2gktRcn7xyt2HTDXxEq Ov0QA4he4yl2X0DNnC6EX4A7IEeQIQogbxBGJcMsDMBRIGQxKQBPAFPD/BtRVCkVwF5gYwCuGwJk gDwjYADTlooumgwQA3yQvNAnlQ2WjqOyThCkDCn4QLcuIfPAGRQlqMdXkgv0s0oUG14RnRHzrC22 CSqjNOydSTaTCeJr4gDwF2P1tH0kQSWlst0ghu0edfSWV+Ddmr9AdGNcCxUTXnNg1DDdGGo20wF8 /tQwaiiWBSro1IMXc+U+QdY1rADd456rg3Wujr3r953T9AEqBlcgt+CKPMCuSAtlv0ATjDlkcb8h ABbfW9ccelGBJNo8InzW0sZ4jUovYH1KDx9Gzq965TbaER3cxsmVPLz9W8CtKmwFy3VuRMtR7W7t gRE+7fdYIo4rQEs38QeO1Z37pdofrwAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMC0xMi0yOVQxNDox MzozOCswMDowMN5nY/sAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMTItMjlUMTQ6MTM6MzgrMDA6 MDCvOttHAAAAAElFTkSuQmCC X-Now-Playing: The Honeymoon Killers's _Les tueurs de la lune de miel_: "Laisser tomber les filles" Date: Tue, 29 Dec 2020 15:22:14 +0100 In-Reply-To: <87tus4g0ga.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Tue, 29 Dec 2020 14:18:29 +0000") Message-ID: <8735zou1yh.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: João Távora writes: > So better put the patch in a side branch and decide if we want to > overhaul format-spec to allow for these things, or maybe just use the > more powerful existing mode-line language for this, perhap [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > So better put the patch in a side branch and decide if we want to > overhaul format-spec to allow for these things, or maybe just use the > more powerful existing mode-line language for this, perhaps breaking up > that big function into well-behaved pieces that users can compose. Well, the request was for being able to customise the flymake mode-line indicator, which isn't really feasible by asking the user to write mode line specs. But I don't really care one way or the other -- it's up to you, and I won't pursue this matter any further. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 29 10:13:59 2020 Received: (at 33740) by debbugs.gnu.org; 29 Dec 2020 15:13:59 +0000 Received: from localhost ([127.0.0.1]:39938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuGhD-0006pI-7d for submit@debbugs.gnu.org; Tue, 29 Dec 2020 10:13:59 -0500 Received: from mail-il1-f169.google.com ([209.85.166.169]:44864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuGhB-0006p4-Fs for 33740@debbugs.gnu.org; Tue, 29 Dec 2020 10:13:57 -0500 Received: by mail-il1-f169.google.com with SMTP id r17so12350925ilo.11 for <33740@debbugs.gnu.org>; Tue, 29 Dec 2020 07:13:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=PgVHJDbS0rolwA8ILHitFqlkcjoufiS46+HC3fpdHtI=; b=laWgclEOIrmcADioPXlOsQg3EO4JWCXPsqakyLS8kN1hdHANcko9EXr3mKuazyI0l7 sMEu237H3IhLJmDJDLOqrce3OVaMEJbYaGPat75mjs/hmKZtC68mIEIfq4aUtW94V1fh hrDs3IoIOuXkzkyoZP5NFaFwdMfVVLNP1LK2/0ktMLncuJlGk24lmZnz6jgjD/Z2NNVm BaME29hpJSy2BPUlLHKHv9zHKLU6aUUGfOFeVQtF6lUUDn01iUKNLBZFTcAbRQF+UBt5 3enA7yeHWKM7ka3z4fuSKQth3BGlaF2/pwxbwwFdZv6yAqvrajnP72d6VgTY+/g0EPQP /UUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=PgVHJDbS0rolwA8ILHitFqlkcjoufiS46+HC3fpdHtI=; b=TJafqUkXJNUXO62sK1qRuEBUcUtINqy6ZgPSMLBKC4qdv4n0WAjnajwyMtRT0q9b9k iBTwgxriPmfoW+b4kKucrZWCCV7F4Bn8ITPAXS70JQO3FgXtIuw9AlzDocU3/Kf7wkwY 5sZbTQkneROvnmW7tjKw6nKO9W7H91wICThMrz9LFV0d+ByKf/TU4IzoBssa6/JAqPF4 ey1F6MDkVeguRZNxMQzu/4l/Zn9HUFaegC8VUr8SA6Qn1ry6N79Kw16J3QxlupTh4SGF QqzD0wHAxpGKjrtUzedS+MulKJ1Wplrf5Cdy9z10yJn9+GzJvlvIO/hy+gDomKj8tmQI AIKA== X-Gm-Message-State: AOAM532ruA7YWAU8juFP8zlgp5kktcwE6pAnu/GMdxUCY8jjvYZfoMyn DMe9rbX44YHgf/ldobaJde2iAQY8XilV2tIeAnc= X-Google-Smtp-Source: ABdhPJzrN7iZ+2q3Hhf3PTP3zk3wstTj875nNEsN1jbsfmzyeDDl0UZXoowXTkNEvSrlGq/4KN58L1vgNCcM5k+d7QA= X-Received: by 2002:a92:4089:: with SMTP id d9mr43315772ill.199.1609254831757; Tue, 29 Dec 2020 07:13:51 -0800 (PST) MIME-Version: 1.0 References: <87bm4wjhgy.fsf@gmail.com> <87lfdhgy2p.fsf@gnus.org> <87bledgxql.fsf@gnus.org> <87tus4g0ga.fsf@gmail.com> <8735zou1yh.fsf@gnus.org> In-Reply-To: <8735zou1yh.fsf@gnus.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Tue, 29 Dec 2020 15:13:39 +0000 Message-ID: Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Tue, Dec 29, 2020 at 2:22 PM Lars Ingebrigtsen wrote: > > Jo=C3=A3o T=C3=A1vora writes: > > > So better put the patch in a side branch and decide if we want to > > overhaul format-spec to allow for these things, or maybe just use the > > more powerful existing mode-line language for this, perhaps breaking up > > that big function into well-behaved pieces that users can compose. > > Well, the request was for being able to customise the flymake mode-line > indicator, which isn't really feasible by asking the user to write mode > line specs. How is it more feasible to ask her to write such customizations inside a string than asking her to write the same customizations in a symbolic expression? > But I don't really care one way or the other -- it's up to you, and I > won't pursue this matter any further. I'm sorry, but the patch you pushed is crucially flawed, it simply banishes the indicator in every file without diagnostics in the "note" category. This is plain to see in many Elisp files, but is not only for Elisp, it affects Eglot and likely other uses that rely on Flymake. Since I don't know how to fix your "format-spec" mini-language in the very short term, I hope you understand I had to revert your patch. In other words, the problem at hand doesn't get any simpler just by choosing less powerful language. Either we make the language more powerful, or we choose to solve a narrower problem. I don't understand your "don't care" comment. You don't care for enhancing format-spec to allow for conditional formattings. Or you don't care for Flymake or what? Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 29 22:22:25 2020 Received: (at 33740) by debbugs.gnu.org; 30 Dec 2020 03:22:25 +0000 Received: from localhost ([127.0.0.1]:40647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuS48-0001am-Ui for submit@debbugs.gnu.org; Tue, 29 Dec 2020 22:22:25 -0500 Received: from quimby.gnus.org ([95.216.78.240]:60758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuS46-0001aW-PV for 33740@debbugs.gnu.org; Tue, 29 Dec 2020 22:22:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/KAlM1BYITft6jh9jUQf7Bdjr/eImzB3249JWFql+/E=; b=IpSRf7Oat4vAylBMFOIGNgZ5lK ZrtzeUBGRq4lobtPVadVVpDYWzcEjFNnikP9tHNLKa433fTcK0c2QEhAkpJtCwd83NQHBmF28ZoxM CKzEK0VLbciy8Z1wYErrDwz87GkhIIMeDOZ80pLceSrxG4u9+SPw6VqY0jMueXP6mcu4=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kuS3x-0001Qk-Tu; Wed, 30 Dec 2020 04:22:16 +0100 From: Lars Ingebrigtsen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87lfdhgy2p.fsf@gnus.org> <87bledgxql.fsf@gnus.org> <87tus4g0ga.fsf@gmail.com> <8735zou1yh.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEXZz8NXPznJkGgV ERGlaU3////FrsAdAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+QMHgMRB/vMNnMAAAGcSURBVDjLzZTr ceMwDIRhJQUYJgsQYRYQmCogpNB/TbcAbcdzJ8/k52HGD/ETFliQEtHb4MM406LMjdsjVJWVU7sF YPy7B7PG5b8g1pkPMp6gHcZ/ANI7oC8z+WUNjE0PpbLZX3W2CcyspAPAAHIEoJTfgJ5tPwKjmj2s MOc+QUKG1FGed+vYHWyJAYxfDsT4dKAdBUbtswbDrA1KLpW92x+HaiIThD9vimPOWarQ/vSBBKx4 Rq42RgANIyGRkDQMFSfoqXFX9WtvSURq9640CjvgO7DvE8C5Dgi1tJm0pN0A6sXBN8nwnvKQ4g1i OiJXgBtRFQC4R42LQWCMshE1ogXDgbY59ymw9TMAPjWh2ZrlGm5F2BfbbaGTV9h1xYQ5C2phiNSV 6MPdQQb+erNR2AHtK11x29X3LbWRlPcJTmfqcOvTvQGU+9YiVhqhm2Js0v1nm886EtBwbJXOUQIs AWocepcb0vmZsUgoq4OLFDzEAF8BYmO3+JKSugNzEHvXLvejljYGwHTpcx4RCz0Y0LJ6s6GFWL27 x0vpD3BItl1IjTbIAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIwLTEyLTMwVDAzOjE3OjA2KzAwOjAw s52djAAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMC0xMi0zMFQwMzoxNzowNiswMDowMMLAJTAAAAAA SUVORK5CYII= X-Now-Playing: Simon & Garfunkel's _The Concert In Central Park_: "Mrs. Robinson" Date: Wed, 30 Dec 2020 04:22:12 +0100 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Tue, 29 Dec 2020 15:13:39 +0000") Message-ID: <87ft3oq8pn.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: João Távora writes: > How is it more feasible to ask her to write such customizations > inside a string than asking her to write the same customizations > in a symbolic expression? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > How is it more feasible to ask her to write such customizations > inside a string than asking her to write the same customizations > in a symbolic expression? Format spec strings is the common idiom for customising display stuff in Emacs. > I don't understand your "don't care" comment. You don't care > for enhancing format-spec to allow for conditional formattings. Whether Flymake offers a way to customise the lighter (or not) is up to you. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 30 04:28:47 2020 Received: (at 33740) by debbugs.gnu.org; 30 Dec 2020 09:28:47 +0000 Received: from localhost ([127.0.0.1]:40912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuXmg-0008I7-NP for submit@debbugs.gnu.org; Wed, 30 Dec 2020 04:28:47 -0500 Received: from mail-il1-f181.google.com ([209.85.166.181]:41535) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuXme-0008Ht-0d for 33740@debbugs.gnu.org; Wed, 30 Dec 2020 04:28:45 -0500 Received: by mail-il1-f181.google.com with SMTP id w17so14305976ilj.8 for <33740@debbugs.gnu.org>; Wed, 30 Dec 2020 01:28:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=WdRwpYyZPiyFtWdYZxOM5vKJ8MDhgeSJGTcXr38FRFg=; b=u1emF7xcYGnrS1YH9Sexk61la/QTdBvC7+aoNrCECOCwEOfA/kwZh2L+akt4emXbFR ge9V/jJQYTy3zERwtc4NOm3OIOxyB0/nsnaRxGyzJNBHrRWV9FzBcZH6URaR6SKAGem1 VvRpVLgR09cGfjpg3491785YJdkSmb4FPTqgyTnnO4lzgTiYn+cpQ7To49HNmJX1lCZi Y/e7tWTyTIp0tIhNn7DeT42SLDHo/b9TWIFYLasQ/2ex+XmzUbLEGA2+U+ETXxQk+D+q DILvHdVXGGS73yB7DcDxRb3InKFYqnsxjqkgi9xct1C1bxCUVjujO02AaHnU8hKUjXtI Q9wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=WdRwpYyZPiyFtWdYZxOM5vKJ8MDhgeSJGTcXr38FRFg=; b=sLUAOVKNmKKIAoK2fOmALF8bdz2QhGOGMPmxOFJt9I+rbzO8GZBuVkYPZh/DGBM8Uz gZyDKPcpdLEvERbvGMqAkePNrr5T1ekXoKa/0IqH2nMyXdHygnm4FMwrLN88fWdHJn8K eKaxeg7W/x3cQ4Hy+BLsUKZE6xbuQSxDdolIWMYqVUc8oDM8mNkTAR6qSX6PqnJGDpAN fI0+B0p2nj1AZKAgjeW+3pkNJV7bNqluHXH0Aya2utK4ASX7G39vsGfmbF1V7+tKxl2g G+l0gLgPcDTzDb/Wi3Nx6NKmQoh0/lXTifneFZW9JyZNqqXzkSmq3era3G4svE8AA0y3 2CAg== X-Gm-Message-State: AOAM533ypXc3HuG/sNDlkfCr1bGuWRUyJdRZ2kqnot8kQ/2dEY8Nd2E/ bfpM3CRsxIaXvA+eAk8ntuIyH/miTMRVE4dxpYI= X-Google-Smtp-Source: ABdhPJypghPBpxImrPl+GfxzP1fDR1/VM9SBAAjGhiVL93WKRncdnyQ8Dg7RFjyuYvtBijQr4rYJaCcCt0AXIV1z/Q0= X-Received: by 2002:a92:4089:: with SMTP id d9mr46251370ill.199.1609320518428; Wed, 30 Dec 2020 01:28:38 -0800 (PST) MIME-Version: 1.0 References: <87bm4wjhgy.fsf@gmail.com> <87lfdhgy2p.fsf@gnus.org> <87bledgxql.fsf@gnus.org> <87tus4g0ga.fsf@gmail.com> <8735zou1yh.fsf@gnus.org> <87ft3oq8pn.fsf@gnus.org> In-Reply-To: <87ft3oq8pn.fsf@gnus.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Wed, 30 Dec 2020 09:28:22 +0000 Message-ID: Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, Dec 30, 2020 at 3:22 AM Lars Ingebrigtsen wrote: > > Jo=C3=A3o T=C3=A1vora writes: > > > How is it more feasible to ask her to write such customizations > > inside a string than asking her to write the same customizations > > in a symbolic expression? > > Format spec strings is the common idiom for customising display stuff in > Emacs. Not all of this "stuff" obviously, only the fraction of it that is trivial. Case in point, the very commonly customized mode-line. I appreciate the effort to try to move this along, but if you'd be more aware of Flymake's mode-line mechanics, you'd see the format-spec function is underpowered currently I mean, it _could_ become more powerful. See CL:FORMAT for example (some love it, some hate it, I respect and use it on occasion). It could do the job easily, because it has conditional formatting: http://www.lispworks.com/documentation/HyperSpec/Body/22_cgb.htm So, unless format spec grows something similar, it simply isn't the tool for the job. What growth? See the end of: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D33740#71 in this thread for a possible start. > > I don't understand your "don't care" comment. You don't care > > for enhancing format-spec to allow for conditional formattings. > > Whether Flymake offers a way to customise the lighter (or not) is up to > you. I've started work on a `flymake-mode-line` customizable var, where users can add and removed pre-baked pieces to control the main indicator, counters, brackets, etc. If you're interested in enhancing format-spec, let me know, else I'll continue this approach. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 30 15:16:29 2020 Received: (at 33740) by debbugs.gnu.org; 30 Dec 2020 20:16:29 +0000 Received: from localhost ([127.0.0.1]:51124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuhtV-0005K6-8g for submit@debbugs.gnu.org; Wed, 30 Dec 2020 15:16:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuhtU-0005Jt-8X for 33740@debbugs.gnu.org; Wed, 30 Dec 2020 15:16:28 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33976) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuhtP-0002Pt-1t; Wed, 30 Dec 2020 15:16:23 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3186 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kuhtN-0006As-7N; Wed, 30 Dec 2020 15:16:22 -0500 Date: Wed, 30 Dec 2020 22:16:17 +0200 Message-Id: <83im8jhwxa.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Wed, 30 Dec 2020 09:28:22 +0000) Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87lfdhgy2p.fsf@gnus.org> <87bledgxql.fsf@gnus.org> <87tus4g0ga.fsf@gmail.com> <8735zou1yh.fsf@gnus.org> <87ft3oq8pn.fsf@gnus.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 33740 Cc: larsi@gnus.org, 33740@debbugs.gnu.org, andreyk.mad@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Date: Wed, 30 Dec 2020 09:28:22 +0000 > Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets > > I mean, it _could_ become more powerful. See CL:FORMAT for > example (some love it, some hate it, I respect and use it on > occasion). It could do the job easily, because it has conditional > formatting: The mode-line constructs also support conditionals, so I don't think I follow you here. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 30 16:13:55 2020 Received: (at 33740) by debbugs.gnu.org; 30 Dec 2020 21:13:55 +0000 Received: from localhost ([127.0.0.1]:51205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuin5-0007Lw-4h for submit@debbugs.gnu.org; Wed, 30 Dec 2020 16:13:55 -0500 Received: from mail-il1-f171.google.com ([209.85.166.171]:36083) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuin3-0007LS-By for 33740@debbugs.gnu.org; Wed, 30 Dec 2020 16:13:54 -0500 Received: by mail-il1-f171.google.com with SMTP id u12so15890155ilv.3 for <33740@debbugs.gnu.org>; Wed, 30 Dec 2020 13:13:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=NpMberCmFCB9DIBC/rNLTlD02N1ofUa5de+/DH4DnRo=; b=Jz14obQlPKjX5XK3rtpGCXPCFw0KbficOMdjKSkolBr1arez+A4muvkl4A0jg5SZIy 8Vh7f3enwLLzHWfacUlEX/Fg4XSPpLHZQB6p1OeH0wWcDDru+8LHXGntdqdWfnVC4vJu 78BrNY/Tntj/dsQkF3nPyYCKNyGXKK4+1p9C5kkXHBIB79krQi+BDBgbonvX3UMLT0b4 JKaaigkg9bmFPGOK3GCTNw1UuriohGGR8lYUgSy/wMM7xTznHMgSNF1g2KCDIH0X7Uxo /CbTXrNcP25pWZIzSAXRNvLw/RUXHqdhrhc7M+Mp1aCijaRh31KPWNHJOgO2ruZ3Xh6w k2Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=NpMberCmFCB9DIBC/rNLTlD02N1ofUa5de+/DH4DnRo=; b=qvMIYagt7AmW6InFny0rtN5YezrcZ+sph2Y+oxHv2/PF/ZndU2ivE1ko3G14uoXRa2 ALGFzLTbifgGoRphXBxy71pveJ+ZZ/u8d1sPMm9TLvHGkUWtuc92pQ+dvXppZeqKjDRC LD9V2zYnYFjCREa+E0J+DEW3/iQhPHs0ZuMfAsc67D5j9b6tpURZ6FpCLx17QkSW/aMR Y32oTA2btbrq4lG5p2Z++ozsOHb72HcUzPUYRFMims7JltcbbE5EahwQQsAsl/PvlF7Q cAHL3YZiQeiQlbj9qU0GK7/JwfLfbzda+VNiO2fGBVkn/s+J4Q81/D6R58AiPYBHAETU Xn6w== X-Gm-Message-State: AOAM531FyDvF2mMnsCbVeTFCXyCjSdRcr15OXiuQDHPUCRDjE4WOzpJK 4PoFgnRGdLjOK+zxAA+8mD03hseDfyxqeZ4AkJo= X-Google-Smtp-Source: ABdhPJza4OmE2/7PXAlUVDu0txdIhL3WE03Vs93fXZMo7jiYk0EC7E7nGcy18RtLtgYnymgr/yYdCd6oyFaBN5TOe9E= X-Received: by 2002:a05:6e02:14ce:: with SMTP id o14mr53708903ilk.9.1609362827911; Wed, 30 Dec 2020 13:13:47 -0800 (PST) MIME-Version: 1.0 References: <87bm4wjhgy.fsf@gmail.com> <87lfdhgy2p.fsf@gnus.org> <87bledgxql.fsf@gnus.org> <87tus4g0ga.fsf@gmail.com> <8735zou1yh.fsf@gnus.org> <87ft3oq8pn.fsf@gnus.org> <83im8jhwxa.fsf@gnu.org> In-Reply-To: <83im8jhwxa.fsf@gnu.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Wed, 30 Dec 2020 21:13:36 +0000 Message-ID: Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: Lars Ingebrigtsen , 33740@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, Dec 30, 2020 at 8:16 PM Eli Zaretskii wrote: > > > From: Jo=C3=A3o T=C3=A1vora > > Date: Wed, 30 Dec 2020 09:28:22 +0000 > > Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets > > > > I mean, it _could_ become more powerful. See CL:FORMAT for > > example (some love it, some hate it, I respect and use it on > > occasion). It could do the job easily, because it has conditional > > formatting: > > The mode-line constructs also support conditionals, so I don't think I > follow you here. Yes, mode-line constructs are what I'm using right now and what I'm going to use to give users an interface. Lars was suggesting that format strings are the preferred customization method, and they could become an alternative. But currently, Emacs's format-spec falls well short of what is required. It could become more powerful, like CL:FORMAT, or not. Until then, mode-line constructs. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 31 09:06:19 2020 Received: (at 33740-done) by debbugs.gnu.org; 31 Dec 2020 14:06:19 +0000 Received: from localhost ([127.0.0.1]:39622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuyao-0006Dp-TU for submit@debbugs.gnu.org; Thu, 31 Dec 2020 09:06:19 -0500 Received: from mail-il1-f177.google.com ([209.85.166.177]:38238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuyan-0006DZ-Fw for 33740-done@debbugs.gnu.org; Thu, 31 Dec 2020 09:06:17 -0500 Received: by mail-il1-f177.google.com with SMTP id v3so17465748ilo.5 for <33740-done@debbugs.gnu.org>; Thu, 31 Dec 2020 06:06:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=LfrQwjO+iCec36wpkAIbzjthlM3Ehu89ADJMhoQYQAc=; b=V4woSGw3sk7RKuvczQdkD2i/irXruNAiEEhwsdvArRdzMi16WgVJANq9QZHwAax5Ka xJzG/PP4lxkxaquEQq07TiT6XpCHOD6gjYa+ayA/nzaRgkhADz7X/16pKTu3WE0Mxay8 N1sqSJmT0aBEHABpkV6buZRaBey8scG8pbqSnMHhuP2RzXU68n4oLGlV5HSv7S/KqPMK LYNEq78XSAqMA+1WRdQLuHYRGpQFj+1jYI9LQ2FOO/a8Z6lCiZKoX0+NC6KATob8InjY Z73Jiac9OXE/CXGuChHWqflkTm6Y8r1VKX1/fvK2nEBq2sdQprEriyb6bNqAiR9iP+QJ l7/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=LfrQwjO+iCec36wpkAIbzjthlM3Ehu89ADJMhoQYQAc=; b=G0j1Zp4Q37nuOWDVqVVy9gWrB/HyXKXcZHOUiNat+f8Y3Rjl8sm1dEGG9L3gIddhBT yvzrs3SiUMhOU2WhAilQh1RXfMJs6MlGMdFSM36khKWk/hUTvuIcomlmkCBWfYhvfGkT o8p7NT3ZNoJTVH3k4hpxh7MQpTQpJTi+vLHQRLZSZ0yHCkhwA4oZ25yxZDEijpTEUTZc VJaX9SSh0iNn4Xy0QIM1haZRKa9sYlqF4JmIJ1QeUUE/yOT8Kjd2UrNrMYc+D+Wg/1/8 xnRvA9NRdujjxnLTs9LhmZvNKuabZg6XNmByAYYOpubCB2cw6TppmAFw+xICSoMHHKtG hGZA== X-Gm-Message-State: AOAM530QlheaYKyg3lqzZ7jVrA/M0BalaZCx+hOrKsXRp18MxP4S4HTE az0BKqkOV++CHbpXJvl40SpnFRe+XtjIvatrlZQ= X-Google-Smtp-Source: ABdhPJwgAqkkz7ej4OWuGFvm1xyKPSMC16dQjhqaxUgvdqXnN2FLH/BfgW2QjpOqPWvBJLP48TDFkbgfT+rKJGp1HLs= X-Received: by 2002:a92:a804:: with SMTP id o4mr56720801ilh.125.1609423572036; Thu, 31 Dec 2020 06:06:12 -0800 (PST) MIME-Version: 1.0 References: <87bm4wjhgy.fsf@gmail.com> <87lfdhgy2p.fsf@gnus.org> <87bledgxql.fsf@gnus.org> <87tus4g0ga.fsf@gmail.com> <8735zou1yh.fsf@gnus.org> <87ft3oq8pn.fsf@gnus.org> <83im8jhwxa.fsf@gnu.org> In-Reply-To: From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Thu, 31 Dec 2020 14:05:59 +0000 Message-ID: Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740-done Cc: Lars Ingebrigtsen , 33740-done@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I finally did this work. Check it out in master. If you think it's accept= able we can bump the Flymake version to GNU Elpa. Happy new year (soon at least), Jo=C3=A3o On Wed, Dec 30, 2020 at 9:13 PM Jo=C3=A3o T=C3=A1vora wrote: > > On Wed, Dec 30, 2020 at 8:16 PM Eli Zaretskii wrote: > > > > > From: Jo=C3=A3o T=C3=A1vora > > > Date: Wed, 30 Dec 2020 09:28:22 +0000 > > > Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets > > > > > > I mean, it _could_ become more powerful. See CL:FORMAT for > > > example (some love it, some hate it, I respect and use it on > > > occasion). It could do the job easily, because it has conditional > > > formatting: > > > > The mode-line constructs also support conditionals, so I don't think I > > follow you here. > > Yes, mode-line constructs are what I'm using right now and what > I'm going to use to give users an interface. Lars was suggesting > that format strings are the preferred customization method, and they > could become an alternative. But currently, Emacs's format-spec > falls well short of what is required. It could become more powerful, > like CL:FORMAT, or not. Until then, mode-line constructs. > > Jo=C3=A3o --=20 Jo=C3=A3o T=C3=A1vora From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 01 05:56:52 2021 Received: (at 33740-done) by debbugs.gnu.org; 1 Jan 2021 10:56:52 +0000 Received: from localhost ([127.0.0.1]:55447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvI72-0006C6-IE for submit@debbugs.gnu.org; Fri, 01 Jan 2021 05:56:52 -0500 Received: from quimby.gnus.org ([95.216.78.240]:56660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvI70-0006Bs-Q6 for 33740-done@debbugs.gnu.org; Fri, 01 Jan 2021 05:56:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=VxyZ13LMCuRcfQeSh+mdBU3rCxNVHWrV4SE8euaaLds=; b=c5+bzDkgN+a6FEUWL6upKiw/lf fqnwz6bmlJCASPoo1k0ID7K5HZUKKMNlRFfpnI20b3ggi9wNHy+c92T9+t58VA1txQl7HYcQHlVZt UWh2FggO45YBcz2VoxxMtMw7rkMsOlgpaGES5gzfFMp2bvmCIek1KU05BJ5aXGfUzLT4=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kvI6r-00008N-RU; Fri, 01 Jan 2021 11:56:44 +0100 From: Lars Ingebrigtsen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87lfdhgy2p.fsf@gnus.org> <87bledgxql.fsf@gnus.org> <87tus4g0ga.fsf@gmail.com> <8735zou1yh.fsf@gnus.org> <87ft3oq8pn.fsf@gnus.org> <83im8jhwxa.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEUhQ1Zsjpx7mKP/ //9GoNHaAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+UBAQotB7xYJN4AAAFTSURBVCjPbZKxasMwEIbv RGxophYsaDVl6JSnkKF0VsHK4KlDO1hPoSmzC/GSyYWoxHrK3p2S0KEeTnz3n/67Ewb4/3MSK4l4 KkdJFWiIHaiF6rSlasz5ayAwTpM62TmMDOoe4BtGw0r3RsqAkU1Nh5w6itd2agjaYmySW13bM5CB L7CeNEm2QD1yDPlRJpPykC6TuepyHXABqz84hwVabUO2RWlb5UweC2hQEZ4ZqgzaYYSNKANsD9QT L+C7azscVrVMvOLgsT+xg0Bjdx3UAO8ywogCM9Ia9ck2oKY8e4YE5BaW1GfqmuwLl/9khkVWrgXA yzZ45DugOWBOAk+eVjF98jt+K37+TX3GnpXQAZplwcA+4QBq39oCmQY9Q6Sd2WgCtY4RuQ/sCOwc K1bgNTllTawFHj6dovUqGasKkxydxN7b209zN3l3A9DtHwBs5PgFAqBahyQmgO0AAAAldEVYdGRh dGU6Y3JlYXRlADIwMjEtMDEtMDFUMTA6NDU6MDcrMDA6MDBsZnTFAAAAJXRFWHRkYXRlOm1vZGlm eQAyMDIxLTAxLTAxVDEwOjQ1OjA3KzAwOjAwHTvMeQAAAABJRU5ErkJggg== X-Now-Playing: Dif Juz's _Who Says So?_: "Pass It On Charlie" Date: Fri, 01 Jan 2021 11:56:40 +0100 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Thu, 31 Dec 2020 14:05:59 +0000") Message-ID: <874kk1c4d3.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: João Távora writes: > I finally did this work. Check it out in master. If you think it's > acceptable we can bump the Flymake version to GNU Elpa. Sure; looks good. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740-done Cc: Eli Zaretskii , 33740-done@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > I finally did this work. Check it out in master. If you think it's > acceptable we can bump the Flymake version to GNU Elpa. Sure; looks good. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 02 06:27:37 2021 Received: (at 33740) by debbugs.gnu.org; 2 Jan 2021 11:27:37 +0000 Received: from localhost ([127.0.0.1]:52555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvf4L-0007AG-F0 for submit@debbugs.gnu.org; Sat, 02 Jan 2021 06:27:37 -0500 Received: from mail-wr1-f51.google.com ([209.85.221.51]:39016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvf4J-0007A3-MW for 33740@debbugs.gnu.org; Sat, 02 Jan 2021 06:27:36 -0500 Received: by mail-wr1-f51.google.com with SMTP id c5so26229821wrp.6 for <33740@debbugs.gnu.org>; Sat, 02 Jan 2021 03:27:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=QnXlg2nUwTCvphT94+enTJ18iUdiNi7y9MWkIE+NIlw=; b=HuZIdyXVrT8WODryfIy6dXGEhFMe2fKeke9eLjzgz2aPbTdqzfCeFjtsOYXbstncLz jIuw1Ds0vVN30KGqMNkk00IGsSYmVVIDIy1orbN8D0XvivgHWOnU4cG9CtcFrj8kR35q zf92v6UTN9voO7YFqQewhIPHYP+Lx7gDLMOHhZ4gyBaxncZZWRoabAwR6br4fYTPQONx Xc9cbFETi/5Rcs4biPy0SQHApuaDu/YuW0te1v7z9ZqqzhbgDtRFGcebfAfGd5VQ/aOs zCeRxp1SkSnX0nP6EnoSjNQqDswzRErqgKuv9df5ic+zCTnXFscuF1manecwX6V0Bnj+ MNJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=QnXlg2nUwTCvphT94+enTJ18iUdiNi7y9MWkIE+NIlw=; b=MBrtyxobTm3FMjy5+mvV/58hzutOpFVb3N2OXnJjRq4VeYverTB07asfelMiABU/da R1CP/+uIQTcvyLuPnCaUsGSaoRObmwC5wwdozu0G4SqwWzaNWvSYMAZTHTxDX18nUkSh BoSmusIoWmuSi6C8ybTxKQ3jHb8D62j2qUE87WVtezALMg3rI5BArO9wzGp5kBbWfLq/ /d61UfIewpn3jkk2cUbxru8QWY2dx13uOHYjwrd65My2Jw1ahWUFelWqDl4lgprqYK8R zmtZmlTWsm2/mOryMUpGAFaMjxf0sYC4kJjSLe8lVts5M8RXMu/x5s4ltcu4z+k8ha+y Jqvg== X-Gm-Message-State: AOAM5306C4L6eFeh/YpOA5CTigG04+ktFS+KCsn0iIu46IUODMArQkhA yZquNtpjzqaL1rvKLS3dvAgauWfKAyE= X-Google-Smtp-Source: ABdhPJwqhdteL2J1N4CiO2k/L07T8Co1CQ03lBmj03r3CVbKw0tBq8AnOgWFKZwMtua/pz4tHV3WUg== X-Received: by 2002:adf:e452:: with SMTP id t18mr69189446wrm.177.1609586849699; Sat, 02 Jan 2021 03:27:29 -0800 (PST) Received: from krug (222.201.137.78.rev.vodafone.pt. [78.137.201.222]) by smtp.gmail.com with ESMTPSA id u66sm22406371wmg.2.2021.01.02.03.27.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Jan 2021 03:27:28 -0800 (PST) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Lars Ingebrigtsen Subject: Re: bug#33740: [PATCH] Customizable flymake mode-line indicator References: <87bm4wjhgy.fsf@gmail.com> <87lfdhgy2p.fsf@gnus.org> <87bledgxql.fsf@gnus.org> <87tus4g0ga.fsf@gmail.com> <8735zou1yh.fsf@gnus.org> <87ft3oq8pn.fsf@gnus.org> <83im8jhwxa.fsf@gnu.org> <874kk1c4d3.fsf@gnus.org> Date: Sat, 02 Jan 2021 11:27:25 +0000 In-Reply-To: <874kk1c4d3.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 01 Jan 2021 11:56:40 +0100") Message-ID: <875z4fo9ya.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33740 Cc: Eli Zaretskii , 33740@debbugs.gnu.org, Andrii Kolomoiets X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Jo=C3=A3o T=C3=A1vora writes: > >> I finally did this work. Check it out in master. If you think it's >> acceptable we can bump the Flymake version to GNU Elpa. > > Sure; looks good. Done. Bumped to Flymake to 1.1.0, should be in GNU Elpa soon. Jo=C3=A3o From unknown Thu Jun 19 14:23:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 30 Jan 2021 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator