GNU bug report logs - #33739
27.0.50; [PATCH] Harfbuzz: fix compilation with --use-cairo

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33739 in the body.
You can then email your comments to 33739 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ari Roponen <ari.roponen <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Mohammad Nasirifar <far.nasiri.m <at> gmail.com>
Subject: 27.0.50; [PATCH] Harfbuzz: fix compilation with --use-cairo
Date: Fri, 14 Dec 2018 09:22:09 +0200

Emacs harfbuzz-branch compiled with --with-cairo crashes because of
these lines in ftcrfont.c:

  if (ftfont_info_size != offsetof (struct ftcrfont_info, cr_font_face))
    abort ();

The following patch fixes the problem:

diff --git a/src/ftcrfont.c b/src/ftcrfont.c
index e2f84d44fc..6d74d937a7 100644
--- a/src/ftcrfont.c
+++ b/src/ftcrfont.c
@@ -41,6 +41,9 @@ struct ftcrfont_info
   bool maybe_otf;	  /* Flag to tell if this may be OTF or not.  */
   OTF *otf;
 #endif	/* HAVE_LIBOTF */
+#ifdef HAVE_HARFBUZZ
+  hb_font_t *hb_font;
+#endif  /* HAVE_HARFBUZZ */
   FT_Size ft_size;
   int index;
   FT_Matrix matrix;


In GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.1, cairo version 1.16.0)
 of 2018-12-14 built on arirop
Repository revision: 0cf5d630009dfa215f488facc98c9f948eabaf2a
Repository branch: harfbuzz
Windowing system distributor 'Fedora Project', version 11.0.12003000
System Description: Fedora 29 (Twenty Nine)

Configured using:
 'configure --with-cairo'

Configured features:
XPM JPEG TIFF GIF PNG RSVG CAIRO IMAGEMAGICK SOUND DBUS GSETTINGS GLIB
NOTIFY INOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT
LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM THREADS LIBSYSTEMD
JSON LCMS2 GMP

Message #10 received at 33739-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ari Roponen <ari.roponen <at> gmail.com>
Cc: far.nasiri.m <at> gmail.com, 33739-done <at> debbugs.gnu.org
Subject: Re: bug#33739: 27.0.50;
 [PATCH] Harfbuzz: fix compilation with --use-cairo
Date: Fri, 14 Dec 2018 10:54:47 +0200

> From: Ari Roponen <ari.roponen <at> gmail.com>
> Date: Fri, 14 Dec 2018 09:22:09 +0200
> Cc: Mohammad Nasirifar <far.nasiri.m <at> gmail.com>
> 
> Emacs harfbuzz-branch compiled with --with-cairo crashes because of
> these lines in ftcrfont.c:
> 
>   if (ftfont_info_size != offsetof (struct ftcrfont_info, cr_font_face))
>     abort ();
> 
> The following patch fixes the problem:

Thanks, pushed to the harfbuzz branch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.