GNU bug report logs - #33736
flymake test different-diagnostic-types confuses gcc and CC

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33736 in the body.
You can then email your comments to 33736 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: flymake test different-diagnostic-types confuses gcc and CC
Date: Thu, 13 Dec 2018 21:35:06 -0500

Package: emacs
Version: 27.0.50
Severity: minor

flymake-test's different-diagnostic-types is skipped if "gcc" seems too old.
However, what matters to the rest of the test is $CC, not gcc.
So if gcc is new enough for the test to run, but $CC is older, the test fails.

Eg on RHEL 7.6:

scl enable devtoolset-7 bash
type -ap gcc   # /opt/rh/devtoolset-7/root/usr/bin/gcc
gcc --version  # 7.3.1
make lisp/progmodes/flymake-tests  # 9 tests pass
/usr/bin/gcc --version    # 4.8.5
make lisp/progmodes/flymake-tests CC=/usr/bin/gcc
  -> different-diagnostic-types fails rather than being skipped

This happens on hydra.nixos.org, ref eg https://hydra.nixos.org/build/85857843

Message #6 received at 33736 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 33736 <at> debbugs.gnu.org
Subject: Re: bug#33736: flymake test different-diagnostic-types confuses gcc
 and CC
Date: Fri, 14 Dec 2018 14:51:45 -0500

Glenn Morris wrote:

> flymake-test's different-diagnostic-types is skipped if "gcc" seems too old.
> However, what matters to the rest of the test is $CC, not gcc.

AFAICS the tests are gcc-specific, so the Makefile should enforce that:

--- i/test/lisp/progmodes/flymake-resources/Makefile
+++ w/test/lisp/progmodes/flymake-resources/Makefile
@@ -8,6 +8,6 @@ CC_OPTS = -Wall -Wextra
 ## normally use flymake, so it seems like just avoiding the issue
 ## in this test is fine.  Set flymake-log-level to 3 to investigate.
 check-syntax:
-	GCC_COLORS= $(CC) $(CC_OPTS) ${CHK_SOURCES} || true
+	GCC_COLORS= gcc $(CC_OPTS) ${CHK_SOURCES} || true
 
 # eof

Message #11 received at 33736 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 33736 <at> debbugs.gnu.org
Subject: Re: bug#33736: flymake test different-diagnostic-types confuses gcc
 and CC
Date: Fri, 04 Jan 2019 20:21:48 +0000

Glenn Morris <rgm <at> gnu.org> writes:

> Glenn Morris wrote:
>
>> flymake-test's different-diagnostic-types is skipped if "gcc" seems too old.
>> However, what matters to the rest of the test is $CC, not gcc.
>
> AFAICS the tests are gcc-specific, so the Makefile should enforce that:
>
> --- i/test/lisp/progmodes/flymake-resources/Makefile
> +++ w/test/lisp/progmodes/flymake-resources/Makefile
> @@ -8,6 +8,6 @@ CC_OPTS = -Wall -Wextra
>  ## normally use flymake, so it seems like just avoiding the issue
>  ## in this test is fine.  Set flymake-log-level to 3 to investigate.
>  check-syntax:
> -	GCC_COLORS= $(CC) $(CC_OPTS) ${CHK_SOURCES} || true
> +	GCC_COLORS= gcc $(CC_OPTS) ${CHK_SOURCES} || true
>  
>  # eof

Makes sense, thanks.

João

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.