From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 13 16:50:18 2018 Received: (at submit) by debbugs.gnu.org; 13 Dec 2018 21:50:18 +0000 Received: from localhost ([127.0.0.1]:46993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXYs6-0006z2-CC for submit@debbugs.gnu.org; Thu, 13 Dec 2018 16:50:18 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53073) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXYs4-0006yl-Ui for submit@debbugs.gnu.org; Thu, 13 Dec 2018 16:50:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXYrg-0000oG-Dv for submit@debbugs.gnu.org; Thu, 13 Dec 2018 16:50:05 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52596) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gXYrf-0000lM-OD for submit@debbugs.gnu.org; Thu, 13 Dec 2018 16:49:51 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33880) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXYrY-00061p-Gh for bug-gnu-emacs@gnu.org; Thu, 13 Dec 2018 16:49:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXYr8-0007Tn-Hw for bug-gnu-emacs@gnu.org; Thu, 13 Dec 2018 16:49:36 -0500 Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]:43069) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gXYr6-0006uk-OI for bug-gnu-emacs@gnu.org; Thu, 13 Dec 2018 16:49:17 -0500 Received: by mail-lj1-x243.google.com with SMTP id 83-v6so3110833ljf.10 for ; Thu, 13 Dec 2018 13:49:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:subject:from:message-id:date:user-agent:mime-version :content-transfer-encoding:content-language; bh=WenXAC28buitytcHWqdYtxy5so7G7tK3YPK4zr9iw5I=; b=t+PxtvUq8NnzxApgak6fm3wEUasbjXuBomUdExkgKUe16YcP1U9P9h4WCl2Jdn7riy jXQmn6F/c9Z8npWcZ8jLfQrXDVQypfXovTUSfdBvCYjKIihKjpOrJUNYg19jQ9q77IYg t7I98W867hdjLUqyDwB8vySEFJGxD2ZFOICYKoaZRDDcqeKwi6KaD9/TyB5IW3H7nT1P nS70nkuXMU4uMvC9k27VBRTJBWKLpNUpH836Ov3yOAeJYEYEyn/Bo60ms6nT3xxGwnTk yyJZ1b3kAq/tjxMNN3tdfHl/z3+7dsN7w4q1Eg86bs5K+NewWMKsEpAatBE+AXLdaH0G FP0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:subject:from:message-id:date:user-agent :mime-version:content-transfer-encoding:content-language; bh=WenXAC28buitytcHWqdYtxy5so7G7tK3YPK4zr9iw5I=; b=S4dqsyeajgbOSgEggRNAMnq/XcF+IulEPQNocmY2qsG+ERwoAURmTrzDj0jqLHpmom GSK3iXGFJaW1sYOeiVkNb5Oz8uRlV9OBjlqYYzXx+YPilwQJARGT+u4EKZNDgDHxSVLr Mo3e8kxVGsYRIXnP5P2san0DujjYfkNPGUACNB88XmWHLFbM5fsSWykNRaoesM2SZ8H9 8M4H4GkifmrKs1TxvsloYYo6BxRKVfP0j4Tav35nGcKwpc9ap9C4tThkLNkiaGJKFo3Z 2H938ZbOyBABXclytQKYSuvMDMMG6Ve9Ibqt4N11Ck27EH13t8o88HhOlBJXnDyXep8W bT5g== X-Gm-Message-State: AA+aEWZD9kqLRhkYTxYMWMZ+1699Ck26EyGMC/gblBAanuLOu5CQ7gQf hKdGnRyRnffpw9bLoTPmdB01CTDl X-Google-Smtp-Source: AFSGD/Ujn0VM0WfVRWNUmfxIAnjnCwm7AlPI2R9HemTV/bFMOaWLAg+QeLYEp5E/p48PGV6VKYBHfg== X-Received: by 2002:a2e:7615:: with SMTP id r21-v6mr230381ljc.131.1544737746343; Thu, 13 Dec 2018 13:49:06 -0800 (PST) Received: from [192.168.1.111] (84-216-153-198.customers.ownit.se. [84.216.153.198]) by smtp.gmail.com with ESMTPSA id s3-v6sm507657lje.73.2018.12.13.13.49.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Dec 2018 13:49:05 -0800 (PST) To: bug-gnu-emacs@gnu.org Subject: 27.0.50; line-number-current-line face bug From: Jonas Westlund Message-ID: <2fa6cf67-5344-be67-8b04-67c8c7de858f@gmail.com> Date: Thu, 13 Dec 2018 22:49:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.8 (----) When using the built-in display-line-number, placing the point at the last line of the file/end of buffer will make the rest of the display-number area adopt the line-number-current-line face. Modifying the face's background thus produces this kind of effect: https://i.imgur.com/pO214Wf.png Steps to reproduce: 1. emacs -Q 2. (setq display-line-numbers t) 3. (set-face-background 'line-number-current-line "#000000") 4. Go to end of buffer In GNU Emacs 27.0.50 (build 5, x86_64-pc-linux-gnu, GTK+ Version 3.22.30) of 2018-12-13 built on maskinen Repository revision: ef922e774ae33772ad86403332ddb5a1b49d268e Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Ubuntu 18.04.1 LTS Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Making completion list... C-M-g is undefined Quit Making completion list... C-M-g is undefined Quit Making completion list... Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM THREADS LCMS2 GMP Important settings: value of $LC_CTYPE: en_US.UTF-8 value of $LC_MONETARY: sv_SE.UTF-8 value of $LC_NUMERIC: sv_SE.UTF-8 value of $LC_TIME: sv_SE.UTF-8 value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr crm thingatpt emacsbug message rmc puny seq byte-opt gv bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils elec-pair mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 97237 13255) (symbols 48 20303 1) (strings 32 28883 1218) (string-bytes 1 759860) (vectors 16 15095) (vector-slots 8 511933 16416) (floats 8 48 69) (intervals 56 224 0) (buffers 992 12)) From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 14 03:46:43 2018 Received: (at 33732) by debbugs.gnu.org; 14 Dec 2018 08:46:44 +0000 Received: from localhost ([127.0.0.1]:47272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXj7L-0005xX-7k for submit@debbugs.gnu.org; Fri, 14 Dec 2018 03:46:43 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41851) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXj7J-0005xK-5o for 33732@debbugs.gnu.org; Fri, 14 Dec 2018 03:46:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXj7A-0001rz-Rx for 33732@debbugs.gnu.org; Fri, 14 Dec 2018 03:46:35 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54859) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXj7A-0001rv-Nn; Fri, 14 Dec 2018 03:46:32 -0500 Received: from [176.228.60.248] (port=3030 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gXj7A-0002mQ-AD; Fri, 14 Dec 2018 03:46:32 -0500 Date: Fri, 14 Dec 2018 10:46:30 +0200 Message-Id: <837egch4wp.fsf@gnu.org> From: Eli Zaretskii To: Jonas Westlund In-reply-to: <2fa6cf67-5344-be67-8b04-67c8c7de858f@gmail.com> (message from Jonas Westlund on Thu, 13 Dec 2018 22:49:03 +0100) Subject: Re: bug#33732: 27.0.50; line-number-current-line face bug References: <2fa6cf67-5344-be67-8b04-67c8c7de858f@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33732 Cc: 33732@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Jonas Westlund > Date: Thu, 13 Dec 2018 22:49:03 +0100 > > When using the built-in display-line-number, placing the point at the > last line of the file/end of buffer will make the rest of > the display-number area adopt the line-number-current-line > face. Modifying the face's background thus produces this kind of effect: > > https://i.imgur.com/pO214Wf.png Thanks, I tried to fix this on the emacs-26 branch with the patch below. Fix display of line numbers in empty lines beyond EOB * src/xdisp.c (maybe_produce_line_number): When the current line is at EOB, use the 'line-number-current-line' face only on that single line, but not on the rest of empty lines beyond EOB. (Bug#33732) diff --git a/src/xdisp.c b/src/xdisp.c index 808eab7..435ab2c 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -21185,7 +21185,10 @@ maybe_produce_line_number (struct it *it) if (lnum_face_id != current_lnum_face_id && (EQ (Vdisplay_line_numbers, Qvisual) ? this_line == 0 - : this_line == it->pt_lnum)) + : this_line == it->pt_lnum) + /* Avoid displaying the line-number-current-line face on + empty lines beyond EOB. */ + && it->what != IT_EOB) tem_it.face_id = current_lnum_face_id; else tem_it.face_id = lnum_face_id; From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 22 04:01:49 2018 Received: (at 33732) by debbugs.gnu.org; 22 Dec 2018 09:01:49 +0000 Received: from localhost ([127.0.0.1]:59119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gadAL-0003D8-3L for submit@debbugs.gnu.org; Sat, 22 Dec 2018 04:01:49 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60659) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gadAH-0003Cs-NO for 33732@debbugs.gnu.org; Sat, 22 Dec 2018 04:01:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gadA9-000524-EX for 33732@debbugs.gnu.org; Sat, 22 Dec 2018 04:01:40 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34981) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gadA5-00050i-0M; Sat, 22 Dec 2018 04:01:34 -0500 Received: from [176.228.60.248] (port=2169 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gadA4-0006Fd-K2; Sat, 22 Dec 2018 04:01:32 -0500 Date: Sat, 22 Dec 2018 11:01:17 +0200 Message-Id: <8336qqaqaq.fsf@gnu.org> From: Eli Zaretskii To: jonaswestlund101@gmail.com In-reply-to: <837egch4wp.fsf@gnu.org> (message from Eli Zaretskii on Fri, 14 Dec 2018 10:46:30 +0200) Subject: Re: bug#33732: 27.0.50; line-number-current-line face bug References: <2fa6cf67-5344-be67-8b04-67c8c7de858f@gmail.com> <837egch4wp.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33732 Cc: 33732@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Ping! Jonas, did you have a chance to test the change? > Date: Fri, 14 Dec 2018 10:46:30 +0200 > From: Eli Zaretskii > Cc: 33732@debbugs.gnu.org > > > From: Jonas Westlund > > Date: Thu, 13 Dec 2018 22:49:03 +0100 > > > > When using the built-in display-line-number, placing the point at the > > last line of the file/end of buffer will make the rest of > > the display-number area adopt the line-number-current-line > > face. Modifying the face's background thus produces this kind of effect: > > > > https://i.imgur.com/pO214Wf.png > > Thanks, I tried to fix this on the emacs-26 branch with the patch > below. > > Fix display of line numbers in empty lines beyond EOB > > * src/xdisp.c (maybe_produce_line_number): When the current > line is at EOB, use the 'line-number-current-line' face only > on that single line, but not on the rest of empty lines beyond > EOB. (Bug#33732) > > diff --git a/src/xdisp.c b/src/xdisp.c > index 808eab7..435ab2c 100644 > --- a/src/xdisp.c > +++ b/src/xdisp.c > @@ -21185,7 +21185,10 @@ maybe_produce_line_number (struct it *it) > if (lnum_face_id != current_lnum_face_id > && (EQ (Vdisplay_line_numbers, Qvisual) > ? this_line == 0 > - : this_line == it->pt_lnum)) > + : this_line == it->pt_lnum) > + /* Avoid displaying the line-number-current-line face on > + empty lines beyond EOB. */ > + && it->what != IT_EOB) > tem_it.face_id = current_lnum_face_id; > else > tem_it.face_id = lnum_face_id; > > > > From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 26 10:47:44 2018 Received: (at 33732-done) by debbugs.gnu.org; 26 Dec 2018 15:47:44 +0000 Received: from localhost ([127.0.0.1]:37875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gcBPM-0000cP-E4 for submit@debbugs.gnu.org; Wed, 26 Dec 2018 10:47:44 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gcBPK-0000cD-H0 for 33732-done@debbugs.gnu.org; Wed, 26 Dec 2018 10:47:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gcBPA-00066b-Tr for 33732-done@debbugs.gnu.org; Wed, 26 Dec 2018 10:47:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43146) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gcBP1-0005z4-CF; Wed, 26 Dec 2018 10:47:25 -0500 Received: from [176.228.60.248] (port=1417 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gcBOw-0007xQ-Iy; Wed, 26 Dec 2018 10:47:19 -0500 Date: Wed, 26 Dec 2018 17:47:15 +0200 Message-Id: <83wonw70jg.fsf@gnu.org> From: Eli Zaretskii To: Jonas Westlund In-reply-to: <0aa88273-68f9-6ef6-02a4-9cf69f2dc186@gmail.com> (message from Jonas Westlund on Wed, 26 Dec 2018 15:34:17 +0100) Subject: Re: bug#33732: 27.0.50; line-number-current-line face bug References: <2fa6cf67-5344-be67-8b04-67c8c7de858f@gmail.com> <837egch4wp.fsf@gnu.org> <8336qqaqaq.fsf@gnu.org> <0aa88273-68f9-6ef6-02a4-9cf69f2dc186@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33732-done Cc: 33732-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Jonas Westlund > Date: Wed, 26 Dec 2018 15:34:17 +0100 > > Sorry for the late response! > Yes I tested the change and it is working great, thank you! :-) Thanks, I'm therefore closing the bug. From unknown Sat Jun 21 10:42:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 24 Jan 2019 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator