GNU bug report logs - #3372
23.0.94; Wrong input of umlauts in table mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 3372 in the body.
You can then email your comments to 3372 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Uwe Siart <uwe.siart <at> tum.de>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.94; Wrong input of umlauts in table mode
Date: Mon, 25 May 2009 08:22:40 +0200

When I try to enter german umlauts (ä,ö,ü) in table mode I get octal sequences
instead. Typing »ä« results in display of »\344« etc. Everything is fine when
table mode is off.

Regards
Uwe


In GNU Emacs 23.0.94.1 (i386-mingw-nt5.0.2195)
 of 2009-05-24 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.0.2195
configured using `configure --with-gcc (3.4)'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: DEU
  value of $XMODIFIERS: nil
  locale-coding-system: cp1252
  default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  iswitchb-mode: t
  display-time-mode: t
  auto-insert-mode: t
  diff-auto-refine-mode: t
  delete-selection-mode: t
  pc-selection-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-x r b s e m <tab> <return> <down> <down> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> <right> C-c t r C-h m <help-echo> <help-echo> 
C-x 1 C-x k <return> M-x s u b m i t <tab> <tab> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
C-g C-h a b u g <tab> <backspace> <return> <help-echo> 
<help-echo> <wheel-down> <double-wheel-down> <help-echo> 
C-g <down> <up> q <down> <up> <up> <down> <backspace> 
C-x 1 M-x r e p o <tab> r <tab> <return>

Recent messages:
Type C-x 1 to remove help window.  
Quit
Type C-x 1 to remove help window.  
Quit
line-move-visual: End of buffer
line-move-visual: Beginning of buffer
line-move-visual: End of buffer
line-move-visual: Beginning of buffer [2 times]
line-move-visual: End of buffer
Making completion list...

Message #10 received at 3372 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Kenichi Handa <handa <at> m17n.org>
To: uwe.siart <at> tum.de, 3372 <at> debbugs.gnu.org
Cc: Takaaki.Ota <at> am.sony.com
Subject: Re: bug#3372: 23.0.94; Wrong input of umlauts in table mode
Date: Mon, 25 May 2009 16:45:01 +0900

In article <87octhln0v.fsf <at> tum.de>, Uwe Siart <uwe.siart <at> tum.de> writes:

> When I try to enter german umlauts (ä,ö,ü) in table mode I get octal sequences
> instead. Typing »ä« results in display of »\344« etc. Everything is fine when
> table mode is off.

The attached patch will fix that bug.

---
Kenichi Handa
handa <at> m17n.org

--- table.el.~1.39.~	2009-01-09 13:19:13.000000000 +0900
+++ table.el	2009-05-25 16:43:03.000000000 +0900
@@ -3943,7 +3943,7 @@
 (defun *table--cell-self-insert-command ()
   "Table cell version of `self-insert-command'."
   (interactive "*")
-  (let ((char (table--unibyte-char-to-multibyte last-command-event)))
+  (let ((char last-command-event))
     (if (eq buffer-undo-list t) nil
       (if (not (eq last-command this-command))
 	  (setq table-cell-self-insert-command-count 0)
@@ -4048,7 +4048,7 @@
 (defun *table--cell-quoted-insert (arg)
   "Table cell version of `quoted-insert'."
   (interactive "*p")
-  (let ((char (table--unibyte-char-to-multibyte (read-quoted-char))))
+  (let ((char (read-quoted-char)))
     (while (> arg 0)
       (table--cell-insert-char char nil)
       (setq arg (1- arg)))))
@@ -4349,19 +4349,6 @@
 	    (cdr (symbol-value (cdr prompt-history)))))
   (car (symbol-value (cdr prompt-history))))
 
-(defun table--unibyte-char-to-multibyte (char)
-  "Convert CHAR by `unibyte-char-to-multibyte' when possible and necessary."
-  ;; This part is take from `quoted-insert'.
-  ;; Assume character codes 0240 - 0377 stand for characters in some
-  ;; single-byte character set, and convert them to Emacs
-  ;; characters.
-  (if (and enable-multibyte-characters
-	   (fboundp 'unibyte-char-to-multibyte)
-	   (>= char ?\240)
-	   (<= char ?\377))
-      (unibyte-char-to-multibyte char)
-    char))
-
 (defun table--buffer-substring-and-trim (beg end)
   "Extract buffer substring and remove blanks from front and the rear of it."
   (save-excursion

Message #15 received at 3372-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Kenichi Handa <handa <at> m17n.org>
Cc: 3372-done <at> debbugs.gnu.org, uwe.siart <at> tum.de,
        Takaaki.Ota <at> am.sony.com
Subject: Re: bug#3372: 23.0.94; Wrong input of umlauts in table mode
Date: Mon, 25 May 2009 23:32:31 -0400

> In article <87octhln0v.fsf <at> tum.de>, Uwe Siart <uwe.siart <at> tum.de> writes:
>
> > When I try to enter german umlauts (ä,ö,ü) in table mode I get octal
> > sequences
> > instead. Typing »ä« results in display of »\344« etc. Everything is
> > fine when
> > table mode is off.
>
> The attached patch will fix that bug.

Thanks.  This seems clearly correct, so I went ahead and checked it in.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.