GNU bug report logs - #33707
[PATCH 0/2] Update python-celery and python-billiard.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33707 in the body.
You can then email your comments to 33707 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] Update python-celery and python-billiard.
Date: Tue, 11 Dec 2018 17:59:38 +0100

[Message part 1 (text/plain, inline)]

Following on from [1], these patches get python-celery building again,
along with updating the package, and updating python-billiard as it's a
dependency.

1: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33702


Christopher Baines (2):
  gnu: python-billiard: Update to 3.5.0.5.
  gnu: python-celery: Update to 4.2.1.

 gnu/packages/python.scm | 31 ++++++++++++++++++-------------
 1 file changed, 18 insertions(+), 13 deletions(-)

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 33707 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 33707 <at> debbugs.gnu.org
Subject: [PATCH 1/2] gnu: python-billiard: Update to 3.5.0.5.
Date: Tue, 11 Dec 2018 18:31:06 +0100

This is to enable updating python-celery.

* gnu/packages/python.scm (python-billiard): Update to 3.5.0.5.
[native-inputs]: Remove python-nose, add python-case and python-pytest.
---
 gnu/packages/python.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 52e23a19fa..709916d42c 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -8384,17 +8384,18 @@ RabbitMQ messaging server is the most popular implementation.")
 (define-public python-billiard
   (package
     (name "python-billiard")
-    (version "3.3.0.23")
+    (version "3.5.0.5")
     (source
      (origin
        (method url-fetch)
        (uri (pypi-uri "billiard" version))
        (sha256
         (base32
-         "02wxsc6bhqvzh8j6w758kvgqbnj14l796mvmrcms8fgfamd2lak9"))))
+         "03msmapj3s5zgqk87d646mafz7a01h5bm2wijalgpi0s80ks5na2"))))
     (build-system python-build-system)
     (native-inputs
-     `(("python-nose" ,python-nose)))
+     `(("python-case" ,python-case)
+       ("python-pytest" ,python-pytest)))
     (home-page "https://github.com/celery/billiard")
     (synopsis
      "Python multiprocessing fork with improvements and bugfixes")
-- 
2.18.0

Message #11 received at 33707 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 33707 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: python-celery: Update to 4.2.1.
Date: Tue, 11 Dec 2018 18:31:07 +0100

This is an attempt to get the package building after the update to Python
3.7. I'm not sure this totally works, as the tests detect an incompatibility
with Python 3.7 due to use of "async". But with the tests disabled, you can at
least import the celery module, which is a start.

* gnu/packages/python.scm (python-celery): Update to 4.2.1.
[arguments]: Switch to py.test, from nose, disable the tests and loosen the
requirements on pytest.
[native-inputs]: Remove python-nose, add python-pytest and python-case.
[home-page]: Change from HTTP to HTTPS.
---
 gnu/packages/python.scm | 24 ++++++++++++++----------
 1 file changed, 14 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 709916d42c..1e0af3ff6b 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -8419,31 +8419,35 @@ Python 2.4 and 2.5, and will draw its fixes/improvements from python-trunk.")
 (define-public python-celery
   (package
     (name "python-celery")
-    (version "3.1.24")
+    (version "4.2.1")
     (source
      (origin
        (method url-fetch)
        (uri (pypi-uri "celery" version))
        (sha256
         (base32
-         "0yh2prhdnx2dgkb67a5drj12hh2zvzx5f611p7mqqg01ydghif4r"))))
+         "0y66rz7z8dfcgs3s0qxmdddlaq57bzbgxgfz896nbp14grkv9nkp"))))
     (build-system python-build-system)
     (arguments
-     `(#:phases
+     '(;; TODO The tests fail with Python 3.7
+       ;; https://github.com/celery/celery/issues/4849
+       #:tests? #f
+       #:phases
        (modify-phases %standard-phases
-         ;; These tests break with Python 3.5:
-         ;; https://github.com/celery/celery/issues/2897#issuecomment-253066295
-         (replace 'check
+         (add-after 'unpack 'patch-requirements
            (lambda _
-             (zero?
-               (system* "nosetests" "--exclude=^test_safe_to_remove.*")))))))
+             (substitute* "requirements/test.txt"
+               (("pytest>=3\\.0,<3\\.3")
+                "pytest>=3.0"))
+             #t)))))
     (native-inputs
-     `(("python-nose" ,python-nose)))
+     `(("python-case" ,python-case)
+       ("python-pytest" ,python-pytest)))
     (propagated-inputs
      `(("python-pytz" ,python-pytz)
        ("python-billiard" ,python-billiard)
        ("python-kombu" ,python-kombu)))
-    (home-page "http://celeryproject.org")
+    (home-page "https://celeryproject.org")
     (synopsis "Distributed Task Queue")
     (description "Celery is an asynchronous task queue/job queue based on
 distributed message passing.  It is focused on real-time operation, but
-- 
2.18.0

Message #14 received at 33707 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 33707 <at> debbugs.gnu.org
Subject: Re: [bug#33707] [PATCH 0/2] Update python-celery and python-billiard.
Date: Tue, 11 Dec 2018 20:51:21 -0500

[Message part 1 (text/plain, inline)]

On Tue, Dec 11, 2018 at 05:59:38PM +0100, Christopher Baines wrote:
> Following on from [1], these patches get python-celery building again,
> along with updating the package, and updating python-billiard as it's a
> dependency.
> 
> 1: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33702
> 
> 
> Christopher Baines (2):
>   gnu: python-billiard: Update to 3.5.0.5.
>   gnu: python-celery: Update to 4.2.1.

Thanks, LGTM

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 33707-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Leo Famulari <leo <at> famulari.name>
Cc: 33707-done <at> debbugs.gnu.org
Subject: Re: [bug#33707] [PATCH 0/2] Update python-celery and python-billiard.
Date: Wed, 12 Dec 2018 09:07:23 +0100

[Message part 1 (text/plain, inline)]

Leo Famulari <leo <at> famulari.name> writes:

> On Tue, Dec 11, 2018 at 05:59:38PM +0100, Christopher Baines wrote:
>> Following on from [1], these patches get python-celery building again,
>> along with updating the package, and updating python-billiard as it's a
>> dependency.
>> 
>> 1: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33702
>> 
>> 
>> Christopher Baines (2):
>>   gnu: python-billiard: Update to 3.5.0.5.
>>   gnu: python-celery: Update to 4.2.1.
>
> Thanks, LGTM

Pushed, thanks for taking a look :)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.