From unknown Sat Jun 21 05:18:01 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Reply-To: "Drew Adams" , 3370@debbugs.gnu.org Resent-From: "Drew Adams" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 24 May 2009 22:40:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 3370 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12432042679236 (code B ref -1); Sun, 24 May 2009 22:40:04 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 24 May 2009 22:31:07 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.4 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4OMV3EZ009230 for ; Sun, 24 May 2009 15:31:04 -0700 Received: from mail.gnu.org ([199.232.76.166]:45625 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1M8MDe-0003CW-AR for emacs-pretest-bug@gnu.org; Sun, 24 May 2009 18:31:02 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1M8MDd-00020o-1G for emacs-pretest-bug@gnu.org; Sun, 24 May 2009 18:31:02 -0400 Received: from acsinet11.oracle.com ([141.146.126.233]:33628) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M8MDc-0001xI-KN for emacs-pretest-bug@gnu.org; Sun, 24 May 2009 18:31:00 -0400 Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by acsinet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4OMVTed001723 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 24 May 2009 22:31:30 GMT Received: from abhmt004.oracle.com (abhmt004.oracle.com [141.146.116.13]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4OMUuii018911 for ; Sun, 24 May 2009 22:30:56 GMT Received: from dradamslap1 (/98.210.250.59) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 24 May 2009 15:30:52 -0700 From: "Drew Adams" To: Date: Sun, 24 May 2009 15:31:08 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Acncv1VQt2eAVZT8Rj2XSA6IZi/qhQ== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt004.oracle.com [141.146.116.13] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090204.4A19CA9D.0054:SCFSTAT5015188,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) emacs -Q In buffer *scratch*, type this: SPC SPC ` a b c d e f ' RET That inserts this line, followed by a newline: `abcdef' Select the line, including the newline at its end: `M-< C-SPC C-n'. M-x comment-region In Emacs 23, this is the result: ;; `abcdef' In all previous versions of Emacs, the comment chars are inserted at the start of the line - they are not indented two spaces: ;; `abcdef' This is so for Emacs 20, 21, and 22. (Though in Emacs 20 only one semicolon is used.) This breaks any code that depends on the traditional behavior. For instance, I have code that updates file-header lines, and now, instead of this: ;; Features that might be required by this library: ;; ;; `abcdef', `ghijk', `lmnop'. ;; I get this; ;; Features that might be required by this library: ;; ;; `abcdef', `ghijk', `lmnop'. ;; I need this code to work in all Emacs versions. I certainly hope you do not consider this change to be a feature instead of a bug. In GNU Emacs 23.0.94.1 (i386-mingw-nt5.1.2600) of 2009-05-24 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4)' From unknown Sat Jun 21 05:18:01 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Reply-To: Chong Yidong , 3370@debbugs.gnu.org Resent-From: Chong Yidong Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 24 May 2009 23:40:07 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3370 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3370-submit@emacsbugs.donarmstrong.com id=B3370.124320788920847 (code B ref 3370); Sun, 24 May 2009 23:40:07 +0000 Received: (at 3370) by emacsbugs.donarmstrong.com; 24 May 2009 23:31:29 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.8 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4ONVPsG020830 for <3370@emacsbugs.donarmstrong.com>; Sun, 24 May 2009 16:31:26 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 9B55357E263; Sun, 24 May 2009 19:31:46 -0400 (EDT) From: Chong Yidong To: "Drew Adams" Cc: 3370@debbugs.gnu.org Date: Sun, 24 May 2009 19:31:46 -0400 Message-ID: <87prdynkm5.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > In buffer *scratch*, type this: SPC SPC ` a b c d e f ' RET > > Select the line, including the newline at its end: `M-< C-SPC C-n'. > M-x comment-region > > In Emacs 23, this is the result: > > ;; `abcdef' > > In all previous versions of Emacs, the comment chars are inserted at > the start of the line - they are not indented two spaces Wrong. The behavior is identical in Emacs 22. From unknown Sat Jun 21 05:18:01 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Reply-To: "Drew Adams" , 3370@debbugs.gnu.org Resent-From: "Drew Adams" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 25 May 2009 00:00:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3370 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3370-submit@emacsbugs.donarmstrong.com id=B3370.124320942025274 (code B ref 3370); Mon, 25 May 2009 00:00:05 +0000 Received: (at 3370) by emacsbugs.donarmstrong.com; 24 May 2009 23:57:00 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.7 required=4.0 tests=AWL,CR_SYSTEM2,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from rgminet11.oracle.com (rcsinet11.oracle.com [148.87.113.123]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4ONusp2025248 for <3370@emacsbugs.donarmstrong.com>; Sun, 24 May 2009 16:56:55 -0700 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rgminet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4ONvNn9016981 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 24 May 2009 23:57:25 GMT Received: from abhmt006.oracle.com (abhmt006.oracle.com [141.146.116.15]) by acsinet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4ONvVRq012950; Sun, 24 May 2009 23:57:31 GMT Received: from dradamslap1 (/98.210.250.59) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 24 May 2009 16:56:45 -0700 From: "Drew Adams" To: "'Chong Yidong'" Cc: <3370@debbugs.gnu.org> References: <87prdynkm5.fsf@cyd.mit.edu> Date: Sun, 24 May 2009 16:57:02 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87prdynkm5.fsf@cyd.mit.edu> Thread-Index: Acncx9I0pb/yWqt4Tza70cpr83VF1wAAnNuQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt006.oracle.com [141.146.116.15] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090202.4A19DEBD.0224:SCFSTAT5015188,ss=1,fgs=0 > From: Chong Yidong Sent: Sunday, May 24, 2009 4:32 PM > > In buffer *scratch*, type this: SPC SPC ` a b c d e f ' RET > > > > Select the line, including the newline at its end: `M-< C-SPC C-n'. > > M-x comment-region > > > > In Emacs 23, this is the result: > > > > ;; `abcdef' > > > > In all previous versions of Emacs, the comment chars are inserted at > > the start of the line - they are not indented two spaces > > Wrong. The behavior is identical in Emacs 22. You are absolutely incorrect. I just did it again, in `emacs -Q' in 22.3: GNU Emacs 22.3.1 (i386-mingw-nt5.1.2600) of 2008-09-06 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4)' The result is, exactly as I stated: ;; `abcdef' Please do not reply that way, without even trying the recipe. It doesn't help. Let me repeat the instructions differently, just so you are clear. Insert this text at the beginning of *scratch*: " `abcdef'". Follow that by hitting RET to insert a newline. Put point at bob and hit C-SPC to set mark. Use C-n to move past the inserted line. Do M-x comment-region You will *NOT* see this in Emacs 22 (or 21 or 20 or ...): ;; `abcdef' You WILL see this in Emacs 22: ;; `abcdef' From unknown Sat Jun 21 05:18:01 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Reply-To: Lennart Borgman , 3370@debbugs.gnu.org Resent-From: Lennart Borgman Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 25 May 2009 00:10:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3370 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3370-submit@emacsbugs.donarmstrong.com id=B3370.124320986726310 (code B ref 3370); Mon, 25 May 2009 00:10:05 +0000 Received: (at 3370) by emacsbugs.donarmstrong.com; 25 May 2009 00:04:27 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-fx0-f160.google.com (mail-fx0-f160.google.com [209.85.220.160]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4P04MOd026279 for <3370@emacsbugs.donarmstrong.com>; Sun, 24 May 2009 17:04:23 -0700 Received: by fxm4 with SMTP id 4so3249486fxm.1 for <3370@emacsbugs.donarmstrong.com>; Sun, 24 May 2009 17:04:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=ebpywkasuqlL3OUTMKpTl2n1GVCZ3X02PTw8jAgkY/Y=; b=jBnR0Bg6dd8xorMBD5G6GY+9erkWfSAsfD2YauPb4PkyVcO0fY/vYt7FU2tTVGQQ7Z ZhUzOKoiw6me5MerUqlGrultj/oGXxvzLil2yIflVd+hdtXIDUy1P06jFb3FDQRkZUyQ GUh1Ip9Hhq427n7jiPj1Lkxg3/gzHif1+x1o8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=pQUtfh+jaQQAWTER5bBo2PKgnu1RfhkL96Uc2r0HOf2VXMfJhZBBjbA4LBjFin193k iKpIZrDDxF9nGi12m2/kOLyw4yGWjpRUsUAywQ/qB+KqwFY/2KFNcRNGoWupGPtmzPL0 mog4dkyOBhKdBHQh2XMZN1qQU6R1YdFAw/er8= MIME-Version: 1.0 Received: by 10.239.164.6 with SMTP id r6mr476499hbd.104.1243209856385; Sun, 24 May 2009 17:04:16 -0700 (PDT) In-Reply-To: <87prdynkm5.fsf@cyd.mit.edu> References: <87prdynkm5.fsf@cyd.mit.edu> Date: Mon, 25 May 2009 02:04:16 +0200 Message-ID: From: Lennart Borgman To: Chong Yidong , 3370@debbugs.gnu.org Cc: Drew Adams Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, May 25, 2009 at 1:31 AM, Chong Yidong wrote= : >> In buffer *scratch*, type this: SPC SPC ` a b c d e f ' RET >> >> Select the line, including the newline at its end: `M-< C-SPC C-n'. >> M-x comment-region >> >> In Emacs 23, this is the result: >> >> =C2=A0 ;; `abcdef' >> >> In all previous versions of Emacs, the comment chars are inserted at >> the start of the line - they are not indented two spaces > > Wrong. =C2=A0The behavior is identical in Emacs 22. Are you sure? I never noticed it there. From unknown Sat Jun 21 05:18:01 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Reply-To: Chong Yidong , 3370@debbugs.gnu.org Resent-From: Chong Yidong Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 25 May 2009 00:55:09 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3370 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3370-submit@emacsbugs.donarmstrong.com id=B3370.12432128573521 (code B ref 3370); Mon, 25 May 2009 00:55:09 +0000 Received: (at 3370) by emacsbugs.donarmstrong.com; 25 May 2009 00:54:17 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.3 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4P0sCG7003511 for <3370@emacsbugs.donarmstrong.com>; Sun, 24 May 2009 17:54:13 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 3DBB257E263; Sun, 24 May 2009 20:54:34 -0400 (EDT) From: Chong Yidong To: Drew Adams Cc: rms@gnu.org, Dan Nicolaescu , 3370@debbugs.gnu.org, Lennart Borgman References: <87prdynkm5.fsf@cyd.mit.edu> Date: Sun, 24 May 2009 20:54:34 -0400 In-Reply-To: (Lennart Borgman's message of "Mon, 25 May 2009 02:04:16 +0200") Message-ID: <87tz3admt1.fsf@cyd.mit.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > > In buffer *scratch*, type this: SPC SPC ` a b c d e f ' RET > > > > Select the line, including the newline at its end: `M-< C-SPC C-n'. > > M-x comment-region > > > > In Emacs 23, this is the result: > > > > ;; `abcdef' > > > > In all previous versions of Emacs, the comment chars are inserted at > > the start of the line - they are not indented two spaces > Wrong. The behavior is identical in Emacs 22. Aha, I was mistaken. Sorry for the confusion. The default for `comment-style' has been changed, it is no longer `plain'. See Richard's 2007-10-26 changing it to `indent-or-tripe', and Dan's 2008-12-18 change making it `indent' (Bug#1153). This should have been documented in NEWS; I'll do that. From unknown Sat Jun 21 05:18:01 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Reply-To: Jason Rumney , 3370@debbugs.gnu.org Resent-From: Jason Rumney Original-Sender: Jason Rumney Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 25 May 2009 01:35:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3370 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3370-submit@emacsbugs.donarmstrong.com id=B3370.12432149249920 (code B ref 3370); Mon, 25 May 2009 01:35:04 +0000 Received: (at 3370) by emacsbugs.donarmstrong.com; 25 May 2009 01:28:44 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.9 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.239]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4P1Sen7009915 for <3370@emacsbugs.donarmstrong.com>; Sun, 24 May 2009 18:28:41 -0700 Received: by rv-out-0506.google.com with SMTP id f9so934304rvb.1 for <3370@emacsbugs.donarmstrong.com>; Sun, 24 May 2009 18:28:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=Ix6xzaDOcq/ke0L/eMjJcXeIcrCJEoZUNN9wmvr9ISs=; b=XjNpfGOOjLSJjjoQzg9n6T/iCqDFImZWuht9BtesP6qkDtWgvFuK4FNFwqXDzxoNVL ZfKhSRZOuFvc5eLqMgcOv785/CU41gLS4mnOiCtwkK6B+zck4fUdbizzRnFiQlrlg3v0 L0yt1mnk7p8KSERGyXfYntWBbTrnHtnEdt2Dc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=fhanLUuoBEOCFdyhuOI6GR6V5m7F0d2vuERsQDJ9UW+qGTT0hNbpibPBmDabJfhEDX 6kTxXcmwn/2zz4tWDs5lwFzEPSvp9fftOfku5fy5IYdAvBFbWLKofFUYUQr2IpCp3ecb BVxrBH4AvK8L/ak4ZNRjjwvBYgsrOL9g4ZGvI= Received: by 10.140.139.4 with SMTP id m4mr2390080rvd.292.1243214919733; Sun, 24 May 2009 18:28:39 -0700 (PDT) Received: from ?10.1.1.112? ([61.4.103.130]) by mx.google.com with ESMTPS id g22sm14345057rvb.56.2009.05.24.18.28.37 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 24 May 2009 18:28:39 -0700 (PDT) Sender: Jason Rumney Message-ID: <4A19F427.40606@gnu.org> Date: Mon, 25 May 2009 09:28:07 +0800 From: Jason Rumney User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Chong Yidong , 3370@debbugs.gnu.org CC: Drew Adams , Dan Nicolaescu , rms@gnu.org References: <87prdynkm5.fsf@cyd.mit.edu> <87tz3admt1.fsf@cyd.mit.edu> In-Reply-To: <87tz3admt1.fsf@cyd.mit.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Chong Yidong wrote: > Aha, I was mistaken. Sorry for the confusion. > > The default for `comment-style' has been changed, it is no longer > `plain'. See Richard's 2007-10-26 changing it to `indent-or-tripe', and > Dan's 2008-12-18 change making it `indent' (Bug#1153). > > This should have been documented in NEWS; I'll do that. > Or perhaps it would have been better putting it back to plain if Richard's new indent-or-triple option was found to not be a suitable default. I'm not sure that Dan looked into the history when he changed it to indent. From unknown Sat Jun 21 05:18:01 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Reply-To: "Drew Adams" , 3370@debbugs.gnu.org Resent-From: "Drew Adams" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 25 May 2009 02:15:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3370 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3370-submit@emacsbugs.donarmstrong.com id=B3370.124321735817367 (code B ref 3370); Mon, 25 May 2009 02:15:03 +0000 Received: (at 3370) by emacsbugs.donarmstrong.com; 25 May 2009 02:09:18 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from rgminet11.oracle.com (rcsinet11.oracle.com [148.87.113.123]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4P29EOo017360 for <3370@emacsbugs.donarmstrong.com>; Sun, 24 May 2009 19:09:15 -0700 Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rgminet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4P29ihH013359 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 25 May 2009 02:09:45 GMT Received: from abhmt004.oracle.com (abhmt004.oracle.com [141.146.116.13]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4P298JV006719; Mon, 25 May 2009 02:09:09 GMT Received: from dradamslap1 (/98.210.250.59) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 24 May 2009 19:09:04 -0700 From: "Drew Adams" To: "'Jason Rumney'" , "'Chong Yidong'" , <3370@debbugs.gnu.org> Cc: "'Dan Nicolaescu'" , References: <87prdynkm5.fsf@cyd.mit.edu> <87tz3admt1.fsf@cyd.mit.edu> <4A19F427.40606@gnu.org> Date: Sun, 24 May 2009 19:09:21 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <4A19F427.40606@gnu.org> Thread-Index: Acnc2GTc5jkfYpfOQvCyI+Kncn4TfwABFsTw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt004.oracle.com [141.146.116.13] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090207.4A19FDC1.023A:SCFSTAT5015188,ss=1,fgs=0 > > Aha, I was mistaken. Sorry for the confusion. > > > > The default for `comment-style' has been changed, it is no longer > > `plain'. See Richard's 2007-10-26 changing it to > > `indent-or-tripe', and Dan's 2008-12-18 change making it > > `indent' (Bug#1153). > > > > This should have been documented in NEWS; I'll do that. > > Or perhaps it would have been better putting it back to plain if > Richard's new indent-or-triple option was found to not be a suitable > default. I'm not sure that Dan looked into the history when > he changed it to indent. Please restore the traditional behavior. A mere doc change does not cut the mustard. From unknown Sat Jun 21 05:18:01 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Reply-To: Chong Yidong , 3370@debbugs.gnu.org Resent-From: Chong Yidong Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 25 May 2009 04:55:07 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3370 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3370-submit@emacsbugs.donarmstrong.com id=B3370.124322683512810 (code B ref 3370); Mon, 25 May 2009 04:55:07 +0000 Received: (at 3370) by emacsbugs.donarmstrong.com; 25 May 2009 04:47:15 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.4 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4P4lBmv012804 for <3370@emacsbugs.donarmstrong.com>; Sun, 24 May 2009 21:47:12 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id CA47E57E263; Mon, 25 May 2009 00:47:32 -0400 (EDT) From: Chong Yidong To: Jason Rumney Cc: 3370@debbugs.gnu.org, Drew Adams , Dan Nicolaescu , rms@gnu.org References: <87prdynkm5.fsf@cyd.mit.edu> <87tz3admt1.fsf@cyd.mit.edu> <4A19F427.40606@gnu.org> Date: Mon, 25 May 2009 00:47:32 -0400 In-Reply-To: <4A19F427.40606@gnu.org> (Jason Rumney's message of "Mon, 25 May 2009 09:28:07 +0800") Message-ID: <874ov9aivv.fsf@cyd.mit.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Jason Rumney writes: > Or perhaps it would have been better putting it back to plain if > Richard's new indent-or-triple option was found to not be a suitable > default. I'm not sure that Dan looked into the history when he > changed it to indent. Maybe. Could Dan or Richard weigh in on this? Personally, all else being equal, I think `indent' is a better comment style. For instance, all the Emacs sources use that style. From unknown Sat Jun 21 05:18:01 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Reply-To: Dan Nicolaescu , 3370@debbugs.gnu.org Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 25 May 2009 05:35:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3370 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3370-submit@emacsbugs.donarmstrong.com id=B3370.124322918920062 (code B ref 3370); Mon, 25 May 2009 05:35:04 +0000 Received: (at 3370) by emacsbugs.donarmstrong.com; 25 May 2009 05:26:29 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-7.1 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4P5QP7T020056 for <3370@emacsbugs.donarmstrong.com>; Sun, 24 May 2009 22:26:26 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n4P5Q5aU015071; Sun, 24 May 2009 22:26:05 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n4P5Q4sl024737; Sun, 24 May 2009 22:26:04 -0700 (PDT) Date: Sun, 24 May 2009 22:26:04 -0700 (PDT) Message-Id: <200905250526.n4P5Q4sl024737@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Jason Rumney Cc: Chong Yidong , 3370@debbugs.gnu.org, Drew Adams , rms@gnu.org, Stefan Monnier References: <87prdynkm5.fsf@cyd.mit.edu> <87tz3admt1.fsf@cyd.mit.edu> <4A19F427.40606@gnu.org> In-Reply-To: <4A19F427.40606@gnu.org> (Jason Rumney's message of "Mon, 25 May 2009 09:28:07 +0800") Lines: 21 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n4P5Q5aU015071 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Jason Rumney writes: > Chong Yidong wrote: > > Aha, I was mistaken. Sorry for the confusion. > > > > The default for `comment-style' has been changed, it is no longer > > `plain'. See Richard's 2007-10-26 changing it to `indent-or-tripe', and > > Dan's 2008-12-18 change making it `indent' (Bug#1153). > > > > This should have been documented in NEWS; I'll do that. > > > > Or perhaps it would have been better putting it back to plain if > Richard's new indent-or-triple option was found to not be a suitable > default. I'm not sure that Dan looked into the history when he > changed it to indent. I am quite sure I did. 'indent was also the preference of the person that wrote the new incarnation of the region indent code and who explicitly approved the change: Stefan. From unknown Sat Jun 21 05:18:01 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Reply-To: "Drew Adams" , 3370@debbugs.gnu.org Resent-From: "Drew Adams" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 25 May 2009 07:10:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3370 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3370-submit@emacsbugs.donarmstrong.com id=B3370.12432349134117 (code B ref 3370); Mon, 25 May 2009 07:10:06 +0000 Received: (at 3370) by emacsbugs.donarmstrong.com; 25 May 2009 07:01:53 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from rgminet11.oracle.com (rcsinet11.oracle.com [148.87.113.123]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4P71nbs004110 for <3370@emacsbugs.donarmstrong.com>; Mon, 25 May 2009 00:01:51 -0700 Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rgminet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4P72JHE003911 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 25 May 2009 07:02:20 GMT Received: from abhmt007.oracle.com (abhmt007.oracle.com [141.146.116.16]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4P71i0A003777; Mon, 25 May 2009 07:01:44 GMT Received: from dradamslap1 (/98.210.250.59) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 25 May 2009 00:01:39 -0700 From: "Drew Adams" To: "'Chong Yidong'" , "'Jason Rumney'" Cc: <3370@debbugs.gnu.org>, "'Dan Nicolaescu'" , References: <87prdynkm5.fsf@cyd.mit.edu><87tz3admt1.fsf@cyd.mit.edu> <4A19F427.40606@gnu.org> <874ov9aivv.fsf@cyd.mit.edu> Date: Mon, 25 May 2009 00:01:58 -0700 Message-ID: <460B8A8EC0204F4A830B9EC10995A169@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <874ov9aivv.fsf@cyd.mit.edu> Thread-Index: Acnc9ATzJTEv0T9lTv+F9pKuxmepmgAD2PAw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt007.oracle.com [141.146.116.16] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A010207.4A1A4255.0071:SCFSTAT5015188,ss=1,fgs=0 > > Or perhaps it would have been better putting it back to plain if > > Richard's new indent-or-triple option was found to not be a suitable > > default. I'm not sure that Dan looked into the history when he > > changed it to indent. > > Maybe. Could Dan or Richard weigh in on this? > > Personally, all else being equal, Why would everything else be equal? What's wrong with considering what Emacs has always done, and perhaps even thinking about breaking existing code (such as what I reported)? Everything else is not equal. > I think `indent' is a better comment > style. For instance, all the Emacs sources use that style. I don't know what `comment-style' is, so it's difficult for me to discuss it. There is no doc for it that explains anything - see bug #2271. What do you mean by "all the Emacs sources use that style"? I was guessing from your previous mail that `comment-style' somehow controls `comment-region' (which is what this bug report is about), which performs an action. How can static source code be said to "use that style"? If you are referring to ;; always being indented instead of starting a line (which is not what I reported about), then no, there are plenty of source code lines that start with ;; - in file headers, for instance. From unknown Sat Jun 21 05:18:01 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Reply-To: "Drew Adams" , 3370@debbugs.gnu.org Resent-From: "Drew Adams" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 25 May 2009 07:10:08 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3370 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3370-submit@emacsbugs.donarmstrong.com id=B3370.12432349174125 (code B ref 3370); Mon, 25 May 2009 07:10:08 +0000 Received: (at 3370) by emacsbugs.donarmstrong.com; 25 May 2009 07:01:57 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from rgminet11.oracle.com (rcsinet11.oracle.com [148.87.113.123]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4P71rtv004112 for <3370@emacsbugs.donarmstrong.com>; Mon, 25 May 2009 00:01:54 -0700 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rgminet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4P72NZr004108 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 25 May 2009 07:02:24 GMT Received: from abhmt007.oracle.com (abhmt007.oracle.com [141.146.116.16]) by acsinet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4P72TEe010194; Mon, 25 May 2009 07:02:29 GMT Received: from dradamslap1 (/98.210.250.59) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 25 May 2009 00:01:42 -0700 From: "Drew Adams" To: "'Dan Nicolaescu'" , "'Jason Rumney'" Cc: "'Chong Yidong'" , <3370@debbugs.gnu.org>, , "'Stefan Monnier'" References: <87prdynkm5.fsf@cyd.mit.edu><87tz3admt1.fsf@cyd.mit.edu> <4A19F427.40606@gnu.org> <200905250526.n4P5Q4sl024737@godzilla.ics.uci.edu> Date: Mon, 25 May 2009 00:02:02 -0700 Message-ID: <7E9473EA45C34C5EBECFBD78AB625B5E@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <200905250526.n4P5Q4sl024737@godzilla.ics.uci.edu> Thread-Index: Acnc+dXgknCJ4VrJSaqcFeGPm2Nm8gACsPYg X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt007.oracle.com [141.146.116.16] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090207.4A1A4258.0013:SCFSTAT5015188,ss=1,fgs=0 > 'indent was also the preference of the person that wrote the new > incarnation of the region indent code and who explicitly approved the > change: Stefan. `comment-region' is not, or at least was not, about indenting. It is about commenting out the code in the region. There is nothing in the Elisp manual about `comment-region'. What there is about it in the Emacs manual does not mention at all how it affects indenting or is affected by indenting, and it does not mention `comment-style' at all. The only mention of indenting in a node that talks also about `comment-region' is the mention that lines with multiple comment delimiters can sometimes be indented differently, depending on the number of comment delimiters. That has always been the case in Emacs (;;; vs ;; vs ; - indented differently by TAB or C-M-q etc.). Previously, there was no relation between `comment-region' and indenting, AFAIK. And there is still no documented relation, that I can find. Finally, the doc string for `comment-region' still says exactly what it said for Emacs 22. And it says that it comments (or uncomments) "each line" in the region. Not just some text in the line, starting after some whitespace, but the (whole) line. And it says nothing about indenting the commented line. And it says, "By default, comments start at the left margin". Admittedly, that is vague and could be interpreted to mean different things. But there is definitely no mention that `comment-region' indents lines that it comments, that is, that it produces an indented comment. From unknown Sat Jun 21 05:18:01 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Reply-To: "Drew Adams" , 3370@debbugs.gnu.org Resent-From: "Drew Adams" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 25 May 2009 21:30:12 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3370 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3370-submit@emacsbugs.donarmstrong.com id=B3370.124328675011143 (code B ref 3370); Mon, 25 May 2009 21:30:12 +0000 Received: (at 3370) by emacsbugs.donarmstrong.com; 25 May 2009 21:25:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from rgminet14.oracle.com (rcsinet14.oracle.com [148.87.113.126]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4PLPj2c011114 for <3370@emacsbugs.donarmstrong.com>; Mon, 25 May 2009 14:25:46 -0700 Received: from rgminet12.oracle.com (rcsinet12.oracle.com [148.87.113.124]) by rgminet14.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4PHgrbs005149 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <3370@emacsbugs.donarmstrong.com>; Mon, 25 May 2009 17:42:54 GMT Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rgminet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4PHfd3n019090 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 25 May 2009 17:41:43 GMT Received: from abhmt008.oracle.com (abhmt008.oracle.com [141.146.116.17]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4PHfoWN029050; Mon, 25 May 2009 17:41:50 GMT Received: from dradamslap1 (/98.210.250.59) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 25 May 2009 10:41:45 -0700 From: "Drew Adams" To: "'Stefan Monnier'" Cc: <3370@debbugs.gnu.org>, "'Chong Yidong'" , "'Jason Rumney'" , "'Dan Nicolaescu'" , References: <87prdynkm5.fsf@cyd.mit.edu><87tz3admt1.fsf@cyd.mit.edu> <4A19F427.40606@gnu.org><874ov9aivv.fsf@cyd.mit.edu><460B8A8EC0204F4A830B9EC10995A169@us.oracle.com> Date: Mon, 25 May 2009 10:42:05 -0700 Message-ID: <2425239E1D3C418886AD82BF7680D4BF@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: AcndPhZhNNv6jvvgS7+R5iw32iOPRAAHwU2w X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt008.oracle.com [141.146.116.17] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A010206.4A1AD85B.0119:SCFSTAT5015188,ss=1,fgs=0 > Emacs put the comment-starters at column-0 because that code > was written a looooonnng time ago and keeping things simple > was more important than now. Emacs Lisp files still use ;; in column 0 in file headers, AFAICT. What column would you prefer to indent them to? That is exactly the use case here: commenting a line that will be in a file header. There is nothing in the surrounding code that would indicate an indentation level (other than 0 indent). > Emacs-21's new commenting code was improved to be able to > comment and uncomment at other columns than column-0, I have no problem with that. > which made it more useful since most commenting styles use > other indentation styles. No idea what that means. Please define "commenting style" and "indentation style" or otherwise explain what you're trying to say here. > Emacs-21's default (as well as 22) was set to `plain' because Richard > always puts such comments at column-0 (the `plain' setting > had actually to be added specifically for this). Well I don't always put "such comments" (depending on what you mean by that) at column 0. I put `;;' comments where Emacs has always put them: at the same level of indentation that TAB puts code. This is about commenting out a region, however, not about inserting a comment at the current indentation level. Commenting out this line: `abcdef' gives this, prior to Emacs 23: ;; `abcdef' Commenting out the line is different from inserting a comment at the same level: ;; `abcdef' > If you don't like it, just (setq comment-style 'plain) and > live happily ever after. Done (just let-bound in the pertinent code context). That's all I needed. I would prefer, however, to _understand_, by getting some information about `comment-style', `comment-styles', etc. Please document `comment-style' and the rest of what might be missing. Please document this change in NEWS also. Thx. From unknown Sat Jun 21 05:18:01 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Reply-To: Stefan Monnier , 3370@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 25 May 2009 21:30:13 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3370 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3370-submit@emacsbugs.donarmstrong.com id=B3370.124328686111672 (code B ref 3370); Mon, 25 May 2009 21:30:13 +0000 Received: (at 3370) by emacsbugs.donarmstrong.com; 25 May 2009 21:27:41 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.7 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4PLRZLK011634 for <3370@emacsbugs.donarmstrong.com>; Mon, 25 May 2009 14:27:37 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: At8EANo7GkrO+IBc/2dsb2JhbACBT8pQhAsFhgA X-IronPort-AV: E=Sophos;i="4.41,244,1241409600"; d="scan'208";a="39040242" Received: from 206-248-128-92.dsl.teksavvy.com (HELO pastel.home) ([206.248.128.92]) by ironport2-out.teksavvy.com with ESMTP; 25 May 2009 09:39:52 -0400 Received: by pastel.home (Postfix, from userid 20848) id 3A7497EF7; Mon, 25 May 2009 09:39:52 -0400 (EDT) From: Stefan Monnier To: "Drew Adams" Cc: "'Dan Nicolaescu'" , "'Jason Rumney'" , "'Chong Yidong'" , <3370@debbugs.gnu.org>, Message-ID: References: <87prdynkm5.fsf@cyd.mit.edu> <87tz3admt1.fsf@cyd.mit.edu> <4A19F427.40606@gnu.org> <200905250526.n4P5Q4sl024737@godzilla.ics.uci.edu> <7E9473EA45C34C5EBECFBD78AB625B5E@us.oracle.com> Date: Mon, 25 May 2009 09:39:52 -0400 In-Reply-To: <7E9473EA45C34C5EBECFBD78AB625B5E@us.oracle.com> (Drew Adams's message of "Mon, 25 May 2009 00:02:02 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > C-M-q etc.). Previously, there was no relation between > `comment-region' and indenting, AFAIK. And there is still no > documented relation, that I can find. And indeed, there isn't. The new style just preserves the indentation that's present when you call comment-region. It doesn't use the indentation code. Stefan From unknown Sat Jun 21 05:18:01 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Reply-To: "Drew Adams" , 3370@debbugs.gnu.org Resent-From: "Drew Adams" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 25 May 2009 21:30:26 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3370 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3370-submit@emacsbugs.donarmstrong.com id=B3370.124328699611898 (code B ref 3370); Mon, 25 May 2009 21:30:26 +0000 Received: (at 3370) by emacsbugs.donarmstrong.com; 25 May 2009 21:29:56 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from rgminet14.oracle.com (rcsinet14.oracle.com [148.87.113.126]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4PLTqmK011874 for <3370@emacsbugs.donarmstrong.com>; Mon, 25 May 2009 14:29:53 -0700 Received: from rgminet12.oracle.com (rcsinet12.oracle.com [148.87.113.124]) by rgminet14.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4PHguxL005175 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <3370@emacsbugs.donarmstrong.com>; Mon, 25 May 2009 17:42:58 GMT Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rgminet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4PHfhfo019188 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 25 May 2009 17:41:47 GMT Received: from abhmt002.oracle.com (abhmt002.oracle.com [141.146.116.11]) by acsinet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4PHgb4O032098; Mon, 25 May 2009 17:42:38 GMT Received: from dradamslap1 (/98.210.250.59) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 25 May 2009 10:41:50 -0700 From: "Drew Adams" To: "'Chong Yidong'" Cc: "'Jason Rumney'" , <3370@debbugs.gnu.org>, "'Dan Nicolaescu'" , References: <87prdynkm5.fsf@cyd.mit.edu><87tz3admt1.fsf@cyd.mit.edu> <4A19F427.40606@gnu.org><874ov9aivv.fsf@cyd.mit.edu><460B8A8EC0204F4A830B9EC10995A169@us.oracle.com> <87fxet9usz.fsf@cyd.mit.edu> Date: Mon, 25 May 2009 10:42:09 -0700 Message-ID: <5DAE248701D648E8811B62D7C16C5034@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87fxet9usz.fsf@cyd.mit.edu> Thread-Index: AcndPLpKrRv0sxsZRg6dSpaiPu7pZAAH3Y3Q X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt002.oracle.com [141.146.116.11] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A010207.4A1AD85F.0173:SCFSTAT5015188,ss=1,fgs=0 > > Why would everything else be equal? What's wrong with > > considering what Emacs has always done, and perhaps even > > thinking about breaking existing code (such as what I > > reported)? Everything else is not equal. > > Obviously. But if changing the default provides significantly better > behavior, there is case for doing it anyway. My point is that this > default is indeed better. Are you aware that you provide no reasons for your assertion that it "is indeed better"? Better how? Why? For whom? In what contexts? > >> I think `indent' is a better comment style. For instance, all the > >> Emacs sources use that style. > > > > If you are referring to ;; always being indented instead of > > starting a line (which is not what I reported about), then no, > > there are plenty of source code lines that start with ;; - > > in file headers, for instance. > > The overwhelming majority of commented lines are indented, including > file headers, which are indented to top-level (column 0). Indented to column 0? Are you just trying to win an argument? Sure, then everything in the universe is indented. If you count no-op indentation as indentation, then the third policeman going up the middle elevator is indented. So far, you have provided zero content for this thread, AFAICT. And we still have no definition of "comment style" or `comment-style'... From unknown Sat Jun 21 05:18:01 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Reply-To: Stefan Monnier , 3370@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 25 May 2009 21:35:07 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3370 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3370-submit@emacsbugs.donarmstrong.com id=B3370.124328704612366 (code B ref 3370); Mon, 25 May 2009 21:35:07 +0000 Received: (at 3370) by emacsbugs.donarmstrong.com; 25 May 2009 21:30:46 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.7 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4PLUgbJ012359 for <3370@emacsbugs.donarmstrong.com>; Mon, 25 May 2009 14:30:43 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: At8EANo7GkrO+IBc/2dsb2JhbACBT8pQhAsFhgA X-IronPort-AV: E=Sophos;i="4.41,244,1241409600"; d="scan'208";a="39040135" Received: from 206-248-128-92.dsl.teksavvy.com (HELO pastel.home) ([206.248.128.92]) by ironport2-out.teksavvy.com with ESMTP; 25 May 2009 09:38:19 -0400 Received: by pastel.home (Postfix, from userid 20848) id DC2377EF7; Mon, 25 May 2009 09:38:18 -0400 (EDT) From: Stefan Monnier To: Drew Adams Cc: 3370@debbugs.gnu.org, "'Chong Yidong'" , "'Jason Rumney'" , "'Dan Nicolaescu'" , rms@gnu.org Message-ID: References: <87prdynkm5.fsf@cyd.mit.edu> <87tz3admt1.fsf@cyd.mit.edu> <4A19F427.40606@gnu.org> <874ov9aivv.fsf@cyd.mit.edu> <460B8A8EC0204F4A830B9EC10995A169@us.oracle.com> Date: Mon, 25 May 2009 09:38:18 -0400 In-Reply-To: <460B8A8EC0204F4A830B9EC10995A169@us.oracle.com> (Drew Adams's message of "Mon, 25 May 2009 00:01:58 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > Why would everything else be equal? What's wrong with considering what > Emacs has always done, and perhaps even thinking about breaking > existing code (such as what I reported)? Everything else is not equal. Emacs put the comment-starters at column-0 because that code was written a looooonnng time ago and keeping things simple was more important than now. Emacs-21's new commenting code was improved to be able to comment and uncomment at other columns than column-0, which made it more useful since most commenting styles use other indentation styles. Emacs-21's default (as well as 22) was set to `plain' because Richard always puts such comments at column-0 (the `plain' setting had actually to be added specifically for this). If you don't like it, just (setq comment-style 'plain) and live happily ever after. Stefan From unknown Sat Jun 21 05:18:01 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Reply-To: Chong Yidong , 3370@debbugs.gnu.org Resent-From: Chong Yidong Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 25 May 2009 21:50:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3370 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3370-submit@emacsbugs.donarmstrong.com id=B3370.124328781314398 (code B ref 3370); Mon, 25 May 2009 21:50:04 +0000 Received: (at 3370) by emacsbugs.donarmstrong.com; 25 May 2009 21:43:33 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.4 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4PLhTQG014393 for <3370@emacsbugs.donarmstrong.com>; Mon, 25 May 2009 14:43:30 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id BB89857E21A; Mon, 25 May 2009 09:27:40 -0400 (EDT) From: Chong Yidong To: "Drew Adams" Cc: "'Jason Rumney'" , <3370@debbugs.gnu.org>, "'Dan Nicolaescu'" , References: <87prdynkm5.fsf@cyd.mit.edu> <87tz3admt1.fsf@cyd.mit.edu> <4A19F427.40606@gnu.org> <874ov9aivv.fsf@cyd.mit.edu> <460B8A8EC0204F4A830B9EC10995A169@us.oracle.com> Date: Mon, 25 May 2009 09:27:40 -0400 In-Reply-To: <460B8A8EC0204F4A830B9EC10995A169@us.oracle.com> (Drew Adams's message of "Mon, 25 May 2009 00:01:58 -0700") Message-ID: <87fxet9usz.fsf@cyd.mit.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii "Drew Adams" writes: > Why would everything else be equal? What's wrong with considering what > Emacs has always done, and perhaps even thinking about breaking > existing code (such as what I reported)? Everything else is not equal. Obviously. But if changing the default provides significantly better behavior, there is case for doing it anyway. My point is that this default is indeed better. >> I think `indent' is a better comment style. For instance, all the >> Emacs sources use that style. > > If you are referring to ;; always being indented instead of starting a > line (which is not what I reported about), then no, there are plenty > of source code lines that start with ;; - in file headers, for > instance. The overwhelming majority of commented lines are indented, including file headers, which are indented to top-level (column 0). From unknown Sat Jun 21 05:18:01 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Reply-To: Chong Yidong , 3370@debbugs.gnu.org Resent-From: Chong Yidong Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 25 May 2009 21:55:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3370 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3370-submit@emacsbugs.donarmstrong.com id=B3370.124328811215364 (code B ref 3370); Mon, 25 May 2009 21:55:05 +0000 Received: (at 3370) by emacsbugs.donarmstrong.com; 25 May 2009 21:48:32 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.4 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4PLmTd1015359 for <3370@emacsbugs.donarmstrong.com>; Mon, 25 May 2009 14:48:30 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id E29AE57E26A; Mon, 25 May 2009 09:30:50 -0400 (EDT) From: Chong Yidong To: "Drew Adams" Cc: "'Dan Nicolaescu'" , "'Jason Rumney'" , <3370@debbugs.gnu.org>, , "'Stefan Monnier'" References: <87prdynkm5.fsf@cyd.mit.edu> <87tz3admt1.fsf@cyd.mit.edu> <4A19F427.40606@gnu.org> <200905250526.n4P5Q4sl024737@godzilla.ics.uci.edu> <7E9473EA45C34C5EBECFBD78AB625B5E@us.oracle.com> Date: Mon, 25 May 2009 09:30:50 -0400 In-Reply-To: <7E9473EA45C34C5EBECFBD78AB625B5E@us.oracle.com> (Drew Adams's message of "Mon, 25 May 2009 00:02:02 -0700") Message-ID: <878wkl9unp.fsf@cyd.mit.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii "Drew Adams" writes: > Finally, the doc string for `comment-region' still says exactly what > it said for Emacs 22. I will fix this. From unknown Sat Jun 21 05:18:01 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Reply-To: "Drew Adams" , 3370@debbugs.gnu.org Resent-From: "Drew Adams" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 25 May 2009 22:00:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3370 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3370-submit@emacsbugs.donarmstrong.com id=B3370.124328859217125 (code B ref 3370); Mon, 25 May 2009 22:00:05 +0000 Received: (at 3370) by emacsbugs.donarmstrong.com; 25 May 2009 21:56:32 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from acsinet12.oracle.com (acsinet12.oracle.com [141.146.126.234]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4PLuSIJ017114 for <3370@emacsbugs.donarmstrong.com>; Mon, 25 May 2009 14:56:29 -0700 Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by acsinet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4PLu499014804 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 25 May 2009 21:56:06 GMT Received: from abhmt004.oracle.com (abhmt004.oracle.com [141.146.116.13]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4PLuLb3020319; Mon, 25 May 2009 21:56:22 GMT Received: from dradamslap1 (/98.210.250.59) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 25 May 2009 14:56:17 -0700 From: "Drew Adams" To: "'Stefan Monnier'" Cc: <3370@debbugs.gnu.org>, "'Chong Yidong'" , "'Jason Rumney'" , "'Dan Nicolaescu'" , References: <87prdynkm5.fsf@cyd.mit.edu><87tz3admt1.fsf@cyd.mit.edu> <4A19F427.40606@gnu.org><874ov9aivv.fsf@cyd.mit.edu><460B8A8EC0204F4A830B9EC10995A169@us.oracle.com><2425239E1D3C418886AD82BF7680D4BF@us.oracle.com> Date: Mon, 25 May 2009 14:56:37 -0700 Message-ID: <5E5C09B3DBFB4C6B98C6903351B48B7E@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Acndfue4brVChyFkTrOY6S52bZ7MlgAA1g8w X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt004.oracle.com [141.146.116.13] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090201.4A1B1402.036C:SCFSTAT5015188,ss=1,fgs=0 > Yes, I know that. > > > Commenting out this line: > > `abcdef' > > gives this, prior to Emacs 23: > > ;; `abcdef' > > Commenting out the line is different from inserting a comment at the > > same level: > > ;; > > `abcdef' > > I know. Yet, most cases of commented-out code would use > > ;; `abcdef' No, that was not an example of commenting-out code. It was an example of inserting a comment - as I said. > Obviously, you don't like it, just like Richard doesn't like it. I do > believe you're in the minority, tho. No, you're mistaken. I don't really care one way or the other about it. The information that was missing (and is still missing) is about `comment-style' and `comment-styles'. You gave me a solution for the code I have, but still no explanation of `comment-style'. There is still no doc for it. I don't need to use a different value of `comment-style' for my own use interactively - I don't really care whether the commented lines are indented or not. (At least I don't have a preference at the moment.) My question was about use of `comment-region' in code, not interactively. See the original bug report's use case. The real bug I guess is that there is no explanation of `comment-style'. Whenever things like this change, there is the potential (almost the certainty) that existing code will break, as it did in my case. My real need, I came to realize here, is not that `comment-region' act, by default, as it did before, but that I know how to fix the broken code due to its behavior change. The answer was to bind `comment-style', as you suggested. But there is no explanation, hence no understanding, of that answer - no doc for `comment-style'. And, as I said, the doc string for `comment-style' (which is pretty much useless) refers to `comment-styles', which is not recognized (and therefore has no link). From unknown Sat Jun 21 05:18:01 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Reply-To: Stefan Monnier , 3370@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 25 May 2009 22:30:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3370 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3370-submit@emacsbugs.donarmstrong.com id=B3370.124329023422129 (code B ref 3370); Mon, 25 May 2009 22:30:06 +0000 Received: (at 3370) by emacsbugs.donarmstrong.com; 25 May 2009 22:23:54 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.7 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4PMNolg022124 for <3370@emacsbugs.donarmstrong.com>; Mon, 25 May 2009 15:23:52 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: At8EAAc9GkrO+IBc/2dsb2JhbACBT8pxhAsFhgA X-IronPort-AV: E=Sophos;i="4.41,244,1241409600"; d="scan'208";a="39040412" Received: from 206-248-128-92.dsl.teksavvy.com (HELO pastel.home) ([206.248.128.92]) by ironport2-out.teksavvy.com with ESMTP; 25 May 2009 09:41:48 -0400 Received: by pastel.home (Postfix, from userid 20848) id 775A17EF7; Mon, 25 May 2009 09:41:48 -0400 (EDT) From: Stefan Monnier To: Drew Adams Cc: 3370@debbugs.gnu.org Message-ID: References: Date: Mon, 25 May 2009 09:41:48 -0400 In-Reply-To: (Drew Adams's message of "Sun, 24 May 2009 15:31:08 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii The comment-syle was changed to `indent' because experience shows it to be closer to the style used by most people. But yes, thanks for pointing out the fact that it was poorly mentioned in NEWS. Stefan From unknown Sat Jun 21 05:18:01 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Reply-To: Jason Rumney , 3370@debbugs.gnu.org Resent-From: Jason Rumney Original-Sender: Jason Rumney Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 25 May 2009 22:55:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3370 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3370-submit@emacsbugs.donarmstrong.com id=B3370.124329165626116 (code B ref 3370); Mon, 25 May 2009 22:55:05 +0000 Received: (at 3370) by emacsbugs.donarmstrong.com; 25 May 2009 22:47:36 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.4 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-px0-f176.google.com (mail-px0-f176.google.com [209.85.216.176]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4PMlWtO026105 for <3370@emacsbugs.donarmstrong.com>; Mon, 25 May 2009 15:47:34 -0700 Received: by pxi6 with SMTP id 6so2775640pxi.19 for <3370@emacsbugs.donarmstrong.com>; Mon, 25 May 2009 15:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=Tvz6pp0ky5TWfIbmMt/ze+yXvWORRr2bBPig1wAR/fY=; b=l9t5ibRQ2+iVBvBlHhK512WfnyHQ/SwgbgKzHiY3HMDvhk99cHcaoK8zeYEbFr6xBZ FDL3fxm6G7+z0BJlKLoxs6W7YoAzSLFXeyIwC3DuWES79DZCc8DjcUEGlUFZHJ/X1nJT awqPJVqqwneuPGP9lFAGlCCCbgQw8Gx4/xarI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=c+sNYiTdoP+fTXdOAh7AueXPOdDE8XxPAIuDrJWX9DPfmv7mrtP3BOob3Emq65m+r+ NGPBBrVBqs6ENJ5AmDmTe/fykKjFwnTTUhPqtN5JeWV1xwKMSIk6GdDEdgS1WbffO2Dz 1GV+10G3HJuJ1704+grHq4ZBVhwdl6u5u7SyY= Received: by 10.142.126.6 with SMTP id y6mr2545756wfc.269.1243291647530; Mon, 25 May 2009 15:47:27 -0700 (PDT) Received: from ?192.168.249.26? ([124.13.7.47]) by mx.google.com with ESMTPS id 30sm2503116wfd.21.2009.05.25.15.47.25 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 25 May 2009 15:47:26 -0700 (PDT) Sender: Jason Rumney Message-ID: <4A1B1FDF.7030000@gnu.org> Date: Tue, 26 May 2009 06:46:55 +0800 From: Jason Rumney User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Stefan Monnier CC: 3370@debbugs.gnu.org References: <87prdynkm5.fsf@cyd.mit.edu> <87tz3admt1.fsf@cyd.mit.edu> <4A19F427.40606@gnu.org> <874ov9aivv.fsf@cyd.mit.edu> <460B8A8EC0204F4A830B9EC10995A169@us.oracle.com> <2425239E1D3C418886AD82BF7680D4BF@us.oracle.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Stefan Monnier wrote: > Obviously, you don't like it, just like Richard doesn't like it. I do > believe you're in the minority, tho. > I don't think we can say that without polling the users. FWIW, I prefer commented out code (as opposed to standard comments) to have plain style, and 99% of my use of comment-region would be to comment code. For the other 1%, there is indent-region. From unknown Sat Jun 21 05:18:01 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Reply-To: Stefan Monnier , 3370@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 25 May 2009 23:10:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3370 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3370-submit@emacsbugs.donarmstrong.com id=B3370.124329256628649 (code B ref 3370); Mon, 25 May 2009 23:10:06 +0000 Received: (at 3370) by emacsbugs.donarmstrong.com; 25 May 2009 23:02:46 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.5 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from pruche.dit.umontreal.ca (pruche.dit.umontreal.ca [132.204.246.22]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4PN2eI0028644 for <3370@emacsbugs.donarmstrong.com>; Mon, 25 May 2009 16:02:42 -0700 Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id n4PLM4tZ028523; Mon, 25 May 2009 17:22:04 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 6AF9A3A07A; Mon, 25 May 2009 17:22:02 -0400 (EDT) From: Stefan Monnier To: "Drew Adams" Cc: <3370@debbugs.gnu.org>, "'Chong Yidong'" , "'Jason Rumney'" , "'Dan Nicolaescu'" , Message-ID: References: <87prdynkm5.fsf@cyd.mit.edu> <87tz3admt1.fsf@cyd.mit.edu> <4A19F427.40606@gnu.org> <874ov9aivv.fsf@cyd.mit.edu> <460B8A8EC0204F4A830B9EC10995A169@us.oracle.com> <2425239E1D3C418886AD82BF7680D4BF@us.oracle.com> Date: Mon, 25 May 2009 17:22:02 -0400 In-Reply-To: <2425239E1D3C418886AD82BF7680D4BF@us.oracle.com> (Drew Adams's message of "Mon, 25 May 2009 10:42:05 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3282=0 >> Emacs put the comment-starters at column-0 because that code >> was written a looooonnng time ago and keeping things simple >> was more important than now. > Emacs Lisp files still use ;; in column 0 in file headers, > AFAICT. What column would you prefer to indent them to? If you use comment-region in such places, the result should also be at column-0, AFAIK. > That is exactly the use case here: commenting a line that will be in a file > header. There is nothing in the surrounding code that would indicate an > indentation level (other than 0 indent). Then I misunderstood your use case. Please give a recipe. Normally, code at top-level should have some part of it in column-0, so the resulting commented-out version should also be placed at column-0. >> Emacs-21's default (as well as 22) was set to `plain' because Richard >> always puts such comments at column-0 (the `plain' setting >> had actually to be added specifically for this). > Well I don't always put "such comments" (depending on what you mean by > that) at column 0. I put `;;' comments where Emacs has always put > them: at the same level of indentation that TAB puts code. Good. > This is about commenting out a region, however, not about inserting > a comment at the current indentation level. Yes, I know that. > Commenting out this line: > `abcdef' > gives this, prior to Emacs 23: > ;; `abcdef' > Commenting out the line is different from inserting a comment at the > same level: > ;; > `abcdef' I know. Yet, most cases of commented-out code would use ;; `abcdef' Obviously, you don't like it, just like Richard doesn't like it. I do believe you're in the minority, tho. Stefan From unknown Sat Jun 21 05:18:01 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Reply-To: Stefan Monnier , 3370@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 26 May 2009 01:25:07 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3370 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3370-submit@emacsbugs.donarmstrong.com id=B3370.124330062619008 (code B ref 3370); Tue, 26 May 2009 01:25:07 +0000 Received: (at 3370) by emacsbugs.donarmstrong.com; 26 May 2009 01:17:06 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.7 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4Q1H1CH018998 for <3370@emacsbugs.donarmstrong.com>; Mon, 25 May 2009 18:17:03 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: At8EACjgGkrO+IBc/2dsb2JhbACBT8srhAsFhgA X-IronPort-AV: E=Sophos;i="4.41,247,1241409600"; d="scan'208";a="39074607" Received: from 206-248-128-92.dsl.teksavvy.com (HELO ceviche.home) ([206.248.128.92]) by ironport2-out.teksavvy.com with ESMTP; 25 May 2009 21:16:56 -0400 Received: by ceviche.home (Postfix, from userid 20848) id C913EB40AF; Mon, 25 May 2009 21:16:55 -0400 (EDT) From: Stefan Monnier To: Jason Rumney Cc: 3370@debbugs.gnu.org Message-ID: References: <87prdynkm5.fsf@cyd.mit.edu> <87tz3admt1.fsf@cyd.mit.edu> <4A19F427.40606@gnu.org> <874ov9aivv.fsf@cyd.mit.edu> <460B8A8EC0204F4A830B9EC10995A169@us.oracle.com> <2425239E1D3C418886AD82BF7680D4BF@us.oracle.com> <4A1B1FDF.7030000@gnu.org> Date: Mon, 25 May 2009 21:16:55 -0400 In-Reply-To: <4A1B1FDF.7030000@gnu.org> (Jason Rumney's message of "Tue, 26 May 2009 06:46:55 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> Obviously, you don't like it, just like Richard doesn't like it. I do >> believe you're in the minority, tho. > I don't think we can say that without polling the users. It's based on examination of code rather than querying users. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 26 13:41:57 2010 Received: (at control) by debbugs.gnu.org; 26 Jan 2010 18:41:58 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZqMP-0002bu-EP for submit@debbugs.gnu.org; Tue, 26 Jan 2010 13:41:57 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZqMC-0002bf-7k for control@debbugs.gnu.org; Tue, 26 Jan 2010 13:41:56 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1NZqM6-00073h-Sb; Tue, 26 Jan 2010 13:41:38 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19295.14178.860840.157022@fencepost.gnu.org> Date: Tue, 26 Jan 2010 13:41:38 -0500 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: magenta X-Ran: c>qUJL[3-J}PozrYQKhkXmOqKZpEn9|:irefvRW$aMi54 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) severity 3304 minor severity 3314 minor close 3356 severity 3366 minor severity 3370 wishlist tags 3370 wontfix severity 3395 minor close 3396 unarchive 3443 unarchive 3431 reassign 3443 emacs,w32 merge 3431 3443 tags 3500 moreinfo From unknown Sat Jun 21 05:18:01 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: "Drew Adams" Subject: bug#3370: closed (Re: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately) Message-ID: References: X-Gnu-PR-Message: they-closed 3370 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: wontfix Reply-To: 3370@debbugs.gnu.org Date: Wed, 22 Feb 2012 02:49:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1329878942-4210-1" This is a multi-part message in MIME format... ------------=_1329878942-4210-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #3370: 23.0.94; `comment-region' indents comment chars inappropriately which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 3370@debbugs.gnu.org. --=20 3370: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D3370 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1329878942-4210-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 3370-done) by debbugs.gnu.org; 22 Feb 2012 02:48:28 +0000 Received: from localhost ([127.0.0.1]:49682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S02Fm-00014w-9N for submit@debbugs.gnu.org; Tue, 21 Feb 2012 21:48:27 -0500 Received: from fencepost.gnu.org ([140.186.70.10]:55849 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S02Fj-00014h-7k for 3370-done@debbugs.gnu.org; Tue, 21 Feb 2012 21:48:24 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1S02DS-0001nw-L2; Tue, 21 Feb 2012 21:46:02 -0500 From: Glenn Morris To: 3370-done@debbugs.gnu.org Subject: Re: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately References: <87prdynkm5.fsf@cyd.mit.edu> <87tz3admt1.fsf@cyd.mit.edu> <4A19F427.40606@gnu.org> <874ov9aivv.fsf@cyd.mit.edu> <460B8A8EC0204F4A830B9EC10995A169@us.oracle.com> <2425239E1D3C418886AD82BF7680D4BF@us.oracle.com> <4A1B1FDF.7030000@gnu.org> X-Spook: Marxist pipeline analyzer lock picking ammunition Uzi X-Ran: nu$xEw7A}&y%=wv$VsTvT4:H![!uWt35rCv@+8)]/$zLg#;cATAdHq\ZiyW8h:Q1&,ZsmT X-Hue: yellow X-Attribution: GM Date: Tue, 21 Feb 2012 21:46:02 -0500 In-Reply-To: (Stefan Monnier's message of "Mon, 25 May 2009 21:16:55 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 3370-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) It was explained that this can be customized with comment-style. The default isn't going to change. ------------=_1329878942-4210-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 24 May 2009 22:31:07 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.4 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4OMV3EZ009230 for ; Sun, 24 May 2009 15:31:04 -0700 Received: from mail.gnu.org ([199.232.76.166]:45625 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1M8MDe-0003CW-AR for emacs-pretest-bug@gnu.org; Sun, 24 May 2009 18:31:02 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1M8MDd-00020o-1G for emacs-pretest-bug@gnu.org; Sun, 24 May 2009 18:31:02 -0400 Received: from acsinet11.oracle.com ([141.146.126.233]:33628) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M8MDc-0001xI-KN for emacs-pretest-bug@gnu.org; Sun, 24 May 2009 18:31:00 -0400 Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by acsinet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4OMVTed001723 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 24 May 2009 22:31:30 GMT Received: from abhmt004.oracle.com (abhmt004.oracle.com [141.146.116.13]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4OMUuii018911 for ; Sun, 24 May 2009 22:30:56 GMT Received: from dradamslap1 (/98.210.250.59) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 24 May 2009 15:30:52 -0700 From: "Drew Adams" To: Subject: 23.0.94; `comment-region' indents comment chars inappropriately Date: Sun, 24 May 2009 15:31:08 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Acncv1VQt2eAVZT8Rj2XSA6IZi/qhQ== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt004.oracle.com [141.146.116.13] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090204.4A19CA9D.0054:SCFSTAT5015188,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) emacs -Q In buffer *scratch*, type this: SPC SPC ` a b c d e f ' RET That inserts this line, followed by a newline: `abcdef' Select the line, including the newline at its end: `M-< C-SPC C-n'. M-x comment-region In Emacs 23, this is the result: ;; `abcdef' In all previous versions of Emacs, the comment chars are inserted at the start of the line - they are not indented two spaces: ;; `abcdef' This is so for Emacs 20, 21, and 22. (Though in Emacs 20 only one semicolon is used.) This breaks any code that depends on the traditional behavior. For instance, I have code that updates file-header lines, and now, instead of this: ;; Features that might be required by this library: ;; ;; `abcdef', `ghijk', `lmnop'. ;; I get this; ;; Features that might be required by this library: ;; ;; `abcdef', `ghijk', `lmnop'. ;; I need this code to work in all Emacs versions. I certainly hope you do not consider this change to be a feature instead of a bug. In GNU Emacs 23.0.94.1 (i386-mingw-nt5.1.2600) of 2009-05-24 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4)' ------------=_1329878942-4210-1--